[issue27113] sqlite3 connect parameter "check_same_thread" not documented

[Senthil Kumaran]

Senthil Kumaran added the comment:

Thanks for the explanation, Dave. Completely agree with those points. Let's go 
ahead with the latest patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

[Roundup Robot]

Roundup Robot added the comment:

New changeset af1752e51a89 by Senthil Kumaran in branch '3.5':
issue27113 - Document "check_same_thread" parameter in sqlite3.connect api.
https://hg.python.org/cpython/rev/af1752e51a89

New changeset 17c8da643065 by Senthil Kumaran in branch 'default':
[merge from 3.5] - issue27113 - Document "check_same_thread" parameter in 
sqlite3.connect api.
https://hg.python.org/cpython/rev/17c8da643065

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

[Senthil Kumaran]

Senthil Kumaran added the comment:

Thanks for your contribution. It's now documented.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15476] Index "code object" and link to code object definition

[Martin Panter]

Martin Panter added the comment:

I left some minor review suggestions. But a more serious problem is that the 
change to Doc/reference/datamodel.rst breaks the formatting for me. Instead of 
a HTML , I get a  followed by a . Unfortunately I don’t know 
of a way to get index entries to point to the definition list heading without 
breaking up a definition list like this.

IMO having entries under both “code object” and “code” is redundant, but I see 
that is debatable. :) If I was looking this up, I would probably look at “code” 
first. If it wasn’t there, I might even miss a separate “code object” entry, 
considering there is also a second “code (. . .)” entry as well.

--
nosy: +martin.panter
versions: +Python 2.7, Python 3.5, Python 3.6 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Since the _pyio implementation doesn't support general memoryview-like objects, 
I consider using the new buffer protocol in the C implementation an 
implementation detail. Other implementations can lack this support. I think it 
would be better to left the wording more general ("preallocated writable array 
of bytes"), but mention other concrete example (array('b'), are there other 
examples in the stdlib?).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16182] readline: Wrong tab completion scope indices in Unicode terminals

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your comments and updated patches, and especially for tests 
Martin. Added some comments on Rietveld.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

[Martin Panter]

Martin Panter added the comment:

IMO I wouldn’t bother. David has already done the change a different way, which 
is simpler to understand commit-by-commit, even if it messes with the Mercurial 
annotate history.

FWIW I guess you could do a similar merge with an old version to restore the 
deleted file though.

--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Martin Panter]

Martin Panter added the comment:

Actually this bug report was opened because an implementation that lacked 
memoryview support was broken by 2.7. The point is to document that (a subset 
of) memoryview objects may be passed to custom implementations.

Does this need a “changed in 2.7” notice? I am not so familiar with the history 
of Python 2 or the various buffer APIs to be sure.

Also see , where I discovered 
array('b') does not work with io.BytesIO.write(). It seems you have to wrap it 
in buffer() first, presumably because array() does not support the “new” 
protocol, but buffer() does.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

[Roundup Robot]

Roundup Robot added the comment:

New changeset 70e19b014d2f by Serhiy Storchaka in branch '3.5':
Issue #27185: Rename test_string.py to test_string_merged.py.
https://hg.python.org/cpython/rev/70e19b014d2f

New changeset 0da07e73451d by Serhiy Storchaka in branch '3.5':
Issue #27185: Rename test_pep292.py to test_string_merged.py.
https://hg.python.org/cpython/rev/0da07e73451d

New changeset 14a036c696e8 by Serhiy Storchaka in branch '3.5':
Issue #27185: Merge test_pep292.py into test_string_merged.py.
https://hg.python.org/cpython/rev/14a036c696e8

New changeset 36f5229e45a6 by Serhiy Storchaka in branch '3.5':
Issue #27185: Rename test_string_merged.py back to test_string.py.
https://hg.python.org/cpython/rev/36f5229e45a6

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26359] CPython build options for out-of-the box performance

[Alecsandru Patrascu]

Alecsandru Patrascu added the comment:

I've updated the patch for 2.7 branch to contain the LTO part merged by Gregory.

--
Added file: 
http://bugs.python.org/file43142/cpython2_with_optimizations_v02.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27185] Clarify Test Coverage for the String Module (test_pep292 is not easily discoverable)

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Now the history is restored.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26359] CPython build options for out-of-the box performance

[Alecsandru Patrascu]

Alecsandru Patrascu added the comment:

The patches in discussions are the v02 ones.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Given what Serhiy said, the core of this patch is the original patch with a 
test of TkVersion instead of importing ttk.  Code that only ran for 8.4- is 
removed.  Some minimal new tests are added, and I may add some more.  None of 
the changes should depend on OS.  I want to apply this in a few days as it is a 
prerequisite for ttk patches.

--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

[Terry J. Reedy]

New submission from Terry J. Reedy:

When running "python_d.exe -m test_idle from console or when running test file 
from IDLE after starting it in either console or by import, the following 
sometimes appears.

can't invoke "event" command: application has been destroyed
while executing
"event generate $w <>"
(procedure "ttk::ThemeChanged" line 6)
invoked from within
"ttk::ThemeChanged"

Serhiy, this is pobably not critical, but it is annoying.  Perhaps the 
'kill-callbacks' patch would fix this.  Still, I try to have IDLE tests cleanup 
properly.

Known repeatable occurrences:
* test_configdialog.ConfigDialogTest.test_dialog, when run from IDLE after 
import, but not when part of suite.
* test_replace.ReplaceDialogTest.test_default_command, 3 times, when run as 
part suite, but not when run from IDLE after import.

--
components: IDLE, Tkinter
messages: 267078
nosy: serhiy.storchaka, terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: Eliminate 'ThemeChanged' warning when running IDLE tests
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

array is supported explicitly in the Python implementation of readinto().

What if write not "usable with memoryview", but mention memoryview as an 
example?

   The object *b* should be a pre-allocated, writable array of bytes,
   such as :class:`bytearray`, :class:`array.array` or
   :class:`memoryview`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Do you forgot to attach a patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27196] Eliminate 'ThemeChanged' warning when running IDLE tests

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This looks as a duplicate of issue20567.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15243] Misleading documentation for __prepare__

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19489] move quick search box above TOC

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20408] memoryview() constructor documentation error

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20408] memoryview() constructor documentation error

[Stefan Krah]

Stefan Krah added the comment:

Or pretend in the documentation that it's a positional arg and make it one 
later. There is a slight performance difference.

I agree with Damien that probably no one uses the keyword arg.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20408] memoryview() constructor documentation error

[Stefan Krah]

Stefan Krah added the comment:

Sorry, I meant *Demian*.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Martin Panter]

Martin Panter added the comment:

I don’t see the point of mentioning array() objects at all. It’s hard to 
support array in a Python 2 implementation, as demonstrated by readinto(). And 
the special support for array('b') won’t help if you pass in array('B') with 
values 128–255. I see this as an implementation detail of _pyio, rather than a 
need for others to follow its lead.

The array('b') code was added by r56225. I guess it is experimental code from 
an early phase of the io module. Also, test_array_writes() is disabled for 
_pyio in 2.7 
(https://hg.python.org/cpython/diff/760a710eb6c1/Lib/test/test_io.py), and in 
2.6 
(http://svn.python.org/view/python/branches/trunk-bytearray/Lib/test/test_io.py?r1=61775&r2=61774&pathrev=61775&view=patch).

I think it is better to avoid “such as” and be specific about what has to be 
supported. Perhaps:

readinto(b): The object *b* should be a pre-allocated, writable array of bytes, 
either :class:`bytearray` or :class:`memoryview`.

.. versionchanged:: 2.7
   Support for :class:`memoryview`.

write(b): The object *b* should be an array of bytes, either :class:`str`, 
:class:`bytearray`, or :class:`memoryview`.

.. versionchanged:: 2.7
   Support for :class:`memoryview`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2466] os.path.ismount doesn't work for mounts the user doesn't have permission to see

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

What if use os.stat(dirname(path)) instead of os.lstat(parent)?

-if isinstance(path, bytes):
-parent = join(path, b'..')
-else:
-parent = join(path, '..')
 try:
-s2 = os.lstat(parent)
+s2 = os.stat(dirname(path))
 except OSError:
 return False

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Why :class:`str` and not :class:`bytes`?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Martin Panter]

Martin Panter added the comment:

I thought :class:`str` is better documented in Python 2, but I can write bytes 
if you prefer. I guess it is more consistent with the rest of io.rst.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20699] Document that binary IO classes work with bytes-likes objects

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Current docs use "bytes or bytearray object" (without references). "bytes" is 
just an alias to "str" in 2.7, but I prefer to use this name, for consistency 
with 3.x and for accenting the binary nature of the data.

Your new wording LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2466] os.path.ismount doesn't work for mounts the user doesn't have permission to see

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ah, forget, this doesn't work with path like "./.". Agreed, using realpath() is 
the simplest solution.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27179] subprocess uses wrong encoding on Windows

[Eryk Sun]

Eryk Sun added the comment:

> I would say almost all Windows console programs does use 
> console's encoding for input/output because otherwise 
> user wouldn't be able to read it.

While some programs do use the console codepage, even when writing to a pipe or 
disk file -- such as more.com, reg.exe and tasklist.exe -- it's no where near 
"all Windows console programs". As a counterexample, here's a list of Microsoft 
utilities that always use the OEM codepage (CP_OEMCP) when writing to a pipe or 
disk file:

attrib.exe
cacls.exe
doskey.exe (e.g /history)
fc.exe
findstr.exe (calls SetFileApisToOEM)
hostname.exe
icacls.exe
net.exe
qprocess.exe (also to console)
quser.exe (also to console)
sc.exe
sort.exe (also to console)
tree.com

To further ensure that we're on the same page, the following demonstrates what 
happens for creation flags DETACHED_PROCESS, CREATE_NEW_CONSOLE, and 
CREATE_NO_WINDOW in Windows 10:

from subprocess import *

DETACHED_PROCESS = 0x0008
CREATE_NEW_CONSOLE = 0x0010
CREATE_NO_WINDOW = 0x0800

cmd = ('python -c "import ctypes;'
   "kernel32 = ctypes.WinDLL('kernel32');"
   'print(kernel32.GetConsoleCP())"')

>>> call('chcp.com 65001')
Active code page: 65001
0
>>> check_output(cmd, creationflags=0)
b'65001\r\n'
>>> check_output(cmd, creationflags=DETACHED_PROCESS)
b'0\r\n'
>>> check_output(cmd, creationflags=CREATE_NEW_CONSOLE)
b'437\r\n'
>>> check_output(cmd, creationflags=CREATE_NO_WINDOW)
b'437\r\n'

The test was run with a U.S. locale, so the OEM and ANSI codepages are 437 and 
1252. With DETACHED_PROCESS there's no console, so GetConsoleCP() returns 0. 
That's the value of CP_ACP, so ANSI is the natural default for a detached 
process. CREATE_NEW_CONSOLE and CREATE_NO_WINDOW cause Windows to load a new 
instance of conhost.exe, which is initially set to the OEM codepage.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27179] subprocess uses wrong encoding on Windows

[Eryk Sun]

Changes by Eryk Sun :


--
Removed message: http://bugs.python.org/msg267090

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27179] subprocess uses wrong encoding on Windows

[Eryk Sun]

Eryk Sun added the comment:

> I would say almost all Windows console programs does use 
> console's encoding for input/output because otherwise 
> user wouldn't be able to read it.

While some programs do use the console codepage, even when writing to a pipe or 
disk file -- such as more.com, reg.exe and tasklist.exe -- it's no where near 
"all Windows console programs". As a counterexample, here's a list of Microsoft 
utilities that always use the OEM codepage (CP_OEMCP) when writing to a pipe or 
disk file:

attrib.exe
cacls.exe
doskey.exe (e.g /history)
fc.exe
findstr.exe (calls SetFileApisToOEM)
hostname.exe
icacls.exe
net.exe
qprocess.exe (also to console)
quser.exe (also to console)
sc.exe
tree.com

To further ensure that we're on the same page, the following demonstrates what 
happens for creation flags DETACHED_PROCESS, CREATE_NEW_CONSOLE, and 
CREATE_NO_WINDOW in Windows 10:

from subprocess import *

DETACHED_PROCESS = 0x0008
CREATE_NEW_CONSOLE = 0x0010
CREATE_NO_WINDOW = 0x0800

cmd = ('python -c "import ctypes;'
   "kernel32 = ctypes.WinDLL('kernel32');"
   'print(kernel32.GetConsoleCP())"')

>>> call('chcp.com 65001')
Active code page: 65001
0
>>> check_output(cmd, creationflags=0)
b'65001\r\n'
>>> check_output(cmd, creationflags=DETACHED_PROCESS)
b'0\r\n'
>>> check_output(cmd, creationflags=CREATE_NEW_CONSOLE)
b'437\r\n'
>>> check_output(cmd, creationflags=CREATE_NO_WINDOW)
b'437\r\n'

The test was run with a U.S. locale, so the OEM and ANSI codepages are 437 and 
1252. With DETACHED_PROCESS there's no console, so GetConsoleCP() returns 0. 
That's the value of CP_ACP, so ANSI is the natural default for a detached 
process. CREATE_NEW_CONSOLE and CREATE_NO_WINDOW cause Windows to load a new 
instance of conhost.exe, which is initially set to the OEM codepage.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23670] Modifications to support iOS as a cross-compilation target

[Luke Taylor]

Luke Taylor added the comment:

Ok, great!

On Fri, Jun 3, 2016 at 7:34 AM Luke Taylor  wrote:

> Ah, cool!
> On Fri, Jun 3, 2016 at 2:58 AM Russell Keith-Magee 
> wrote:
>
>>
>> Russell Keith-Magee added the comment:
>>
>> Yes - I'm aware of Pythonista; the author of that app contracted me to
>> develop the 3.5 patch that is attached to this ticket :-)
>>
>> --
>>
>> ___
>> Python tracker 
>> 
>> ___
>>
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27073] redundant checks in long_add and long_sub

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

It would be nice.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution: fixed -> 
stage: patch review -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20041] TypeError when f_trace is None and tracing.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think the code would be simpler if convert the argument of frame_settrace() 
to NULL if it is Py_None.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

spoo, can you confirm that the patch fixes your issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26983] float() can return not exact float instance

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24291] Many servers (wsgiref, http.server, etc) can truncate large output blobs

[Martin Panter]

Martin Panter added the comment:

In wsgiref-only.v2.patch I added deprecated support for continuing when a 
partial write is detected. I don’t think it needs documenting though.

--
Added file: http://bugs.python.org/file43143/wsgiref-only.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27073] redundant checks in long_add and long_sub

[Oren Milman]

Changes by Oren Milman :


Added file: http://bugs.python.org/file43145/patchedCPythonTestOutput2.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23680] Sporadic freeze in test_interrupted_write_retry_text

[Martin Panter]

Martin Panter added the comment:

Here is my suggested change to use setitimer(). I also closed the pipe, which 
means there is no need to time out the read, speeding the test up a bit more.

--
keywords: +patch
stage:  -> patch review
versions: +Python 2.7
Added file: http://bugs.python.org/file43146/write-retry.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27073] redundant checks in long_add and long_sub

[Oren Milman]

Oren Milman added the comment:

All right. The updated diff file is attached.

I compiled and ran the tests again. They are quite the same. The test output is 
attached.

--
Added file: http://bugs.python.org/file43144/issue27073.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22331] test_io.test_interrupted_write_text() hangs on the buildbot FreeBSD 7.2

[Martin Panter]

Martin Panter added the comment:

Here is a patch with my suggestion to send the signal only when read() returns, 
and also closing the read end of the pipe before the write end.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file43147/int-write.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26983] float() can return not exact float instance

[Mark Dickinson]

Mark Dickinson added the comment:

float_exact2.patch LGTM

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27145] long_add and long_sub might return a new int where &small_ints[x] could be returned

[Oren Milman]

Oren Milman added the comment:

I just realized I had forgotten to check for a failure after using 
_PyLong_Negate. The updated diff file is attached.

--
Added file: http://bugs.python.org/file43148/proposedPatches.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27145] long_add and long_sub might return a new int where &small_ints[x] could be returned

[Oren Milman]

Oren Milman added the comment:

After giving it some more thought, I feel somewhat uncertain about that check 
for a failure after using _PyLong_Negate.

At first I noticed that after every call to _PyLong_Negate there is such a 
check. But then I realized that in my patch, and also in long_mul (in the 
default branch of CPython), the check is unnecessary, as z is just returned 
after the call to _PyLong_Negate.

Is adding such a check anyway (e.g. in long_mul) a convention? Or should such 
checks be removed?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27184] Support path objects in the ntpath module

[Ethan Furman]

Ethan Furman added the comment:

@Serhy:  Isn't that backwards?  I would think that by doing os.path first most 
other libraries would not have to change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27186] add os.fspath()

[Ethan Furman]

Ethan Furman added the comment:

Note:  My schedule changed -- I won't be at the sprints today, but tomorrow.  
I'll finish reviewing these patches and commit this afternoon if no one beats 
me to it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

[Xiang Zhang]

Xiang Zhang added the comment:

Serhiy, actually the patch(issue26915_s2.patch) I uploaded early has tried to 
make Sequence.index and Sequence.count consistent. Maybe the issue stage is not 
right.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

spoo added the comment:

On 06/03/2016 09:27 PM, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
> spoo, can you confirm that the patch fixes your issue?
> 
> --
> 
> ___
> Python tracker 
> 
> ___
> 

Yes, sorry, and thank you for looking into this!  It may take me a few
days to be able to test it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

[Terry J. Reedy]

Terry J. Reedy added the comment:

Trying again.  And yes, I would like a review.  I don't think there is anything 
system specific, but some deletions required a minor rewrite.

--
keywords: +patch
Added file: http://bugs.python.org/file43149/require85.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

This new patch makes the inspect module treat .0-type names as positional-only 
and renames them to implicit0. Includes a documentation patch too.

I'm not too happy with the wording in the documentation, so suggestions for 
better naming are appreciated.

--
Added file: http://bugs.python.org/file43150/issue19611.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Kushal Das]

Kushal Das added the comment:

Uploading the new patch with a new test case for the same.

--
Added file: http://bugs.python.org/file43151/issue25548v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27051] Create PIP gui

[Upendra Kumar]

Upendra Kumar added the comment:

@Terry and @Lorenzo,

As shown in the GUI of "install_pyPI_v1.png", I needed to add some tkinter 
widget into treeview. For example, adding a checkbox to the treeview so that 
multiple selections are possible. In figure "install_pyPI_v1.png", a checkbox 
in each row of treeview is needed.  I am not getting idea about how to 
implement it?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24617] os.makedirs()'s [mode] not correct

[Tommy Beadle]

Changes by Tommy Beadle :


--
nosy: +tbeadle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Emanuel Barry]

Emanuel Barry added the comment:

I'd probably change all instances of ".*" in the regex matches to be "0x.+" 
instead. For the docstrings that have "..." in them, I would probably make 
those " at ..." as well (although you get decide if it hinders readability too 
much).

Other than that patch LGTM.

--
nosy: +ebarry
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Brett Cannon]

Brett Cannon added the comment:

Patch LGTM. Just needs doc and What's New updates.

--
assignee:  -> kushal.das
nosy: +brett.cannon
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27197] mock.patch interactions with "from" imports

[Clark Breyman]

New submission from Clark Breyman:

Unclear if this is a code bug or a gotcha that should be documented:
Cross posted to https://github.com/testing-cabal/mock/issues/365

Since "from"-style imports in modules bind names on the first execution of the 
import, there is a subtle interaction with patching:

_If a name is imported when the source is patched, the imported name will refer 
to the patched version even after the source is restored_

Test case:
```python
# patchbug/__init__.py
#
```

```python
# patchbug/a.py
#
class A(object):
def name(self):
return "unpatched"
```

```python
# patchbug/b.py
#
from patchbug.a import A

def reference():
return A().name()

# patchbug/tests.py
#
import mock

"""
patchbug.reference.UnpatchedClass is bound to the value of 
patchbug.source.UnpatchedClass
at the time of the first import of patchbug.reference. If patched at that time 
it is not repaired.
"""

def test_unpatched():
import patchbug.a
assert patchbug.a.A().name() == "unpatched"

"""
uncommenting the import causes reference.UnpatchedClass to be bound before the 
patch, fixing
test_reference and breaking test_unpatched
"""
def test_import_reference():
#import patchbug.b
pass

def test_patched():
with mock.patch('patchbug.a.A') as P:
import patchbug.a, patchbug.b
P.return_value.name.return_value = "patched"
assert patchbug.a.A().name() == "patched"
assert patchbug.b.reference() == "patched"

def test_reference():
import patchbug.b
assert patchbug.b.reference() == "unpatched"
```

--
components: Library (Lib)
messages: 267114
nosy: clarkbreyman
priority: normal
severity: normal
status: open
title: mock.patch interactions with "from" imports
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15476] Index "code object" and link to code object definition

[Tommy Beadle]

Changes by Tommy Beadle :


Added file: 
http://bugs.python.org/file43152/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8090931ba850 by Terry Jan Reedy in branch '2.7':
Issue 20567: Revise idle_test/README.txt and some tests to match new advice.
https://hg.python.org/cpython/rev/8090931ba850

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

[Roundup Robot]

Roundup Robot added the comment:

New changeset aed4b9981fca by R David Murray in branch '3.5':
#22797: clarify when URLErrors are raised by urlopen.
https://hg.python.org/cpython/rev/aed4b9981fca

New changeset d085b4f779af by R David Murray in branch '3.5':
Merge: #22797: clarify when URLErrors are raised by urlopen.
https://hg.python.org/cpython/rev/d085b4f779af

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

[Terry J. Reedy]

Terry J. Reedy added the comment:

This and the followup for 3.x full the TODOs in msg219528, revise README.txt, 
and in msg221467, change delete order to match new advice.  

This issue was about conflict between test_idle and test_ttk-guionly and that 
has apparently been solved. After the 3.x commit, I will close this and follow 
up on the 'update before destroy' and 'prohibit default root' ideas on #27196.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15476] Index "code object" and link to code object definition

[R. David Murray]

R. David Murray added the comment:

There are entries for code with object as a subentry?  That's not what I was 
talking about, I was talking about preserving the sub entries for 'code' under 
the 'object' main entry.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Raymond Hettinger]

Raymond Hettinger added the comment:

Kushal.  If you don't mind, I would like Nofar to be able to do this patch.  
She's been working on it since before the sprints and was slowed down by a 
schoolwork crunch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22558] Missing doc links to source code for Python-coded modules.

[Nathan Harold]

Nathan Harold added the comment:

I'll give this a go, per Terry's instructions in msg266846.

I've noticed up front that, due to other changes near the headers of a couple 
of files (specifically fcntl.rst and termios.rst), the patch doesn't apply 
cleanly anymore.  Is it permissible for me to fix that myself and upload a new 
version, or is it preferable for a patch's original author to handle such 
things?  In any case, there are plenty of other files for me to look over for 
now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Raymond Hettinger]

Raymond Hettinger added the comment:

Nofar is about to upload her patch as well (she's been working on this for a 
while).  Perhaps the two can be compared and reconciled so that both can be 
credited on the commit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25548] Show the address in the repr for class objects

[Kushal Das]

Kushal Das added the comment:

Hey Raymond, I am uploading the patch which I almost committed along with whats 
new update :)
I am also reassigning the ticket to you so that you can decide the next steps.

--
assignee: kushal.das -> rhettinger
Added file: http://bugs.python.org/file43153/issue25548v4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27182] PEP 519 support in the stdlib

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

FYI, I'm working on a patch for builtins.open to call PyOS_FSPath.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Oh, sorry, I was absentminded. In general the patch LGTM. But I think that 
using list subclass for tests is not a good idea. If we make a typo in 
CustomSequence method name (__contain__, inedx, coumt), the test is still 
passed. It would be better to use a class that doesn't have any 
sequence-related methods besides explicitly defined.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27073] redundant checks in long_add and long_sub

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Maybe add an assert for the second size negation?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5124] IDLE - pasting text doesn't delete selection

[Terry J. Reedy]

Terry J. Reedy added the comment:

I just got a complaint from a Linux user who says IDLE is the only application 
she uses on Linux that has this augment rather than replace behavior.  She also 
uses IDLE on Windows, so this unique IDLE-Linux behavior is quite annoying.  
Replace at least needs to be an option.

Serhiy (or other current Linux user), what do you know about typical behavior 
on Linux today?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27186] add os.fspath()

[Dusty Phillips]

Dusty Phillips added the comment:

Adding a glossary entry for path-like. The references are all correct except:

:class:`os.PathLike` doesn't link to anything because PathLike hasn't been 
added to the os module yet. Similarly, :meth:`__fspath__` does not link to 
anything, although I think this is acceptable.

--
Added file: http://bugs.python.org/file43154/issue27186-glossary.buchuki.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27186] add os.fspath()

[Dusty Phillips]

Changes by Dusty Phillips :


Removed file: http://bugs.python.org/file43154/issue27186-glossary.buchuki.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27186] add os.fspath()

[Dusty Phillips]

Changes by Dusty Phillips :


Added file: http://bugs.python.org/file43155/issue27186-glossary.buchuki.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5124] IDLE - pasting text doesn't delete selection

[R. David Murray]

R. David Murray added the comment:

For what it is worth, as a dedicated X11 user, *if* the target is already 
hilighted by the application I expect the replace behavior.  But in my usage I 
never select the target myself, since that would replace my selection buffer.  
So in essence I'm seeing the "augment" behavior, but it's because I click to 
place the cursor where I want to paste, I don't select a target block to 
replace.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26983] float() can return not exact float instance

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your review Mark.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26983] float() can return not exact float instance

[Roundup Robot]

Roundup Robot added the comment:

New changeset 050e5f803999 by Serhiy Storchaka in branch 'default':
Issue #26983: float() now always return an instance of exact float.
https://hg.python.org/cpython/rev/050e5f803999

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27182] PEP 519 support in the stdlib

[Ethan Furman]

Ethan Furman added the comment:

Sorry, Serhiy, I had my module names mixed up.

`nt` and `posix` are the same, but `ntpath` and `posixpath` are not (I may have 
those first two names wrong again, but hopefully you get the idea).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27182] PEP 519 support in the stdlib

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

This patch makes the Python and C versions of open()/io.open() support the 
fspath protocol.

--
keywords: +patch
Added file: http://bugs.python.org/file43156/issue27182-open.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27198] Adding an assertClose() method to unittest.TestCase

[Chris Barker]

New submission from Chris Barker:

In py3.5, the math.isclose() function was added to the standard library. It can 
be used to compare floating point numbers to see if they are close to each 
other, rather than exactly equal. It's not a lot of code, but there are nuances 
that not every python user should need to understand.

One of the major use cases for isclose() is test code, so it would be good to 
make it easily available in unitest.TestCase.

TestCase.assertAlmostEqual is NOT the same thing, and can only be used properly 
for values near 1.

Enclosed is a patch that adds  assertClose and assertNotClose to unittest, as 
well as tests and additions to the docs.

Still pending: should this support complex numbers, there is a cmath.isclose(). 
If so, but switching on type?

Also -- should this be back-ported to 3.5 as well -- math.isclose() was 
introduced there.

Done in the pyCon sprints.

--
components: Library (Lib)
files: assertClose.patch
keywords: patch
messages: 267133
nosy: ChrisBarker, ezio.melotti, michael.foord, rbcollins
priority: normal
severity: normal
status: open
title: Adding an assertClose() method to unittest.TestCase
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file43157/assertClose.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26983] float() can return not exact float instance

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

[Jason Fried]

New submission from Jason Fried:

The default of 16k while good for memory usage it is not well suited for all 
cases. if we increased this to 4MB we saw a pretty large improvement to tar 
file creation and extraction on linux servers.

For a 1gb tar file containing 1024 random files each of 10MB in size.
Time Delta for TarFile: 146.3240258693695
Time Delta for FastTarFile 4MB copybufsize: 102.76440262794495
Time Diff: 43.55962324142456 0.2976928975444698

--
components: Library (Lib)
files: buftest.py
messages: 267134
nosy: asvetlov, fried, lukasz.langa
priority: normal
severity: normal
status: open
title: TarFile expose copyfileobj bufsize to improve throughput
type: performance
versions: Python 3.5
Added file: http://bugs.python.org/file43158/buftest.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

[Jason Fried]

Changes by Jason Fried :


--
keywords: +patch
Added file: http://bugs.python.org/file43159/copybufsize.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[Joshua Jay Herman]

Joshua Jay Herman added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue5124] IDLE - pasting text doesn't delete selection

[Terry J. Reedy]

Terry J. Reedy added the comment:

Thank you David, that does help.  Your comment emphasizes that on other systems 
and many other X-11 apps, the user already chooses 'replace' versus 'insert' by 
selecting a replacement or not.   I presume the 'selection buffer' you refer to 
is different from the 'clipboard' (or whatever linux calls it).  Otherwise, 
Roger's patch would not work and I assume he tested it.

Simply applying Roger's patch, in 3.6, would be **MUCH** easier than adding a 
new option.  I could even add a line to the sign-on message: "Paste now 
replaces selected text.  Use undo to correct mistakes."

Assuming the patch does work, here is a workaround for releases that lack it. 
Create in Lib/idlelib a file called, for instance @MYPATCHES.txt and insert 
with the following, to remind what to do after upgrading to a new bugfix 
release.
---
To make paste replace selection, insert the following 3 lines at the top (after 
the def line) of EditorWindow.paste, about line 600, in file EditorWindow.py 
(3.5 and before) or editor.py (3.6 and after).

sel = self.text.tag_ranges("sel")
if sel:
self.text.delete(*sel)   # issue5124
---

Save and then follow the instruction to patch the editor file. If doing the 
edit in IDLE, hit F5 to test the patched EditorWindow.

--
versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

[Kaushik N]

Changes by Kaushik N :


Removed file: http://bugs.python.org/file43121/Issue16484_python3.6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

[Kaushik N]

Kaushik N added the comment:

Applied patch from sean.rodman.
Created a tests.
Incorporated comments from rdmurray

--
Added file: http://bugs.python.org/file43160/Issue16484_rev_python3.6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27184] Support path objects in the ntpath module

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think that if some high-level function uses os.path, it likely should convert 
Path argument to str either because the path should be saved as a string, or 
for performance if multiple os.path functions are called with the same 
argument. Note, that some os.path functions will implicitly support path 
objects if the posix module support it.

Let first find the functions that need path objects support in os.path.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27190] Check sqlite3_version before allowing check_same_thread = False

[Dave Sawyer]

Dave Sawyer added the comment:

This can go into bugfix branches. In fact, it's most likely to be helpful there 
because they are more likely to be running with a version of sqlite 10 years 
old. I use the sqlite3_libversion_number() call because I'm testing against the 
version of sqlite actually loaded. The SQLITE_VERSION_NUMBER define is set at 
compile time.

--
Added file: http://bugs.python.org/file43161/issue27190_patch2.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27167] subprocess reports signal as negative exit status, not documented

[Roundup Robot]

Roundup Robot added the comment:

New changeset 365b5e6163a6 by Gregory P. Smith in branch 'default':
signal, socket, and ssl module IntEnum constant name lookups now return a
https://hg.python.org/cpython/rev/365b5e6163a6

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27198] Adding an assertClose() method to unittest.TestCase

[R. David Murray]

R. David Murray added the comment:

The word description of the meaning of the tolerance attributes told me 
absolutely nothing.  The equation from the math.islcose docs makes it prefectly 
clear.  So I think the formula should be included in the documentation.

assertAlomstEqual has a delta attribute now, which is equivalent to abs_tol.  
Perhaps instead we should add rel_tol to assertAlmostEqual?

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15476] Index "code object" and link to code object definition

[Tommy Beadle]

Tommy Beadle added the comment:

Using

.. index::
   object: code

puts a 'code' entry under 'object' as well as 'object' under 'code'.  That's 
the way it is for every other item that uses "object: XXX".  So if you want a 
new 'code object' top-level item and keep 'object -> code', you're going to get 
'code -> object' as well.  It would seem to me that the 'code object' top-level 
item is redundant.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27167] subprocess reports signal as negative exit status, not documented

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

[Dave Sawyer]

Dave Sawyer added the comment:

hurray! My first commit

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27184] Support path objects in the ntpath module

[Ethan Furman]

Ethan Furman added the comment:

The expected scenario, and the purpose of os.fspath(), is to enable high-level 
libraries to not know or care if they receive a pathlib object or a string.

In other words, they already have os.path.join() and os.path.split() calls, and 
currently break noisily if a pathlib.Path is passed in; by enhancing os.path to 
accept a pathlib.Path object that high-level library can start working with 
pathlib.Path objects without changing a thing, which means the user of that 
library can use pathlib.Path painlessly.

Unless I have seriously misunderstood something, os.path will be changed to 
work with __fspath__ objects.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Did you try to run tests with Tk 8.4?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

[Thomas Kluyver]

Thomas Kluyver added the comment:

Congrats! :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27051] Create PIP gui

[Terry J. Reedy]

Terry J. Reedy added the comment:

There is apparently no way to insert widgets in a Treeview -- text only.  See 
for instance 
https://stackoverflow.com/questions/16755176/tkinter-insert-a-combobox-inside-a-treeview-widget.
  I don't know whether clicks on a row can be pinpointed to a specific field 
(to pop up a widget), but it should certainly be possible to detect a right 
click to do the same.  Or put treeview in frame with button with command that 
detect highlighted row.  For your particular problem, I believe Treeview has a 
mode that allows multiple selections, with multiple rows highlighted 
simultaneously.  If not, or in addition, replace proposed boxes with a blank 
column and insert string 'X' to indicate selection and inclusion in 'Install' 
or any other action.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17888] docs: more information on documentation team

[Laura Rupprecht]

Laura Rupprecht added the comment:

I've updated the patch from Terry with Berker's suggestion.

--
nosy: +laura
Added file: http://bugs.python.org/file43162/issue17888_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22558] Missing doc links to source code for Python-coded modules.

[Terry J. Reedy]

Terry J. Reedy added the comment:

For me, the issue is willingness, not permission ;-).  Reviewing a patch 
includes somehow indicating changes needed to apply it 'today', and a revised 
patch is the best way.  Please say whether the header changes are in 3.6 only 
(in which case a separate 3.5 patch is needed) or in both.  'Commit ready' 
means that you believe a core dev could (and should) download, apply without 
issue, and commit when satisfies.  I should do so within a week if no one else 
does.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com