[issue7678] subprocess.Popen pipeline example code in the documentation is lacking

[Ross Lagerwall]

Ross Lagerwall  added the comment:

The docs should be updated. This has been noted in msg54949 and 
http://www.enricozini.org/2009/debian/python-pipes/

Perhaps this example will make it clear:
import subprocess

p1 = subprocess.Popen(["yes"], stdout=subprocess.PIPE)
p2 = subprocess.Popen(["head"], stdin=p1.stdout, stdout=subprocess.PIPE)
#p1.stdout.close()
p1.wait()

This example hangs. "yes" writes to "head" and head reads the first 10 lines 
and then exits. But, "yes" does not receive a SIGPIPE because the python 
process still has a p1.stdout open. Thus, p1.stdout should be closed after 
being passed to p2.

--
nosy: +rosslagerwall

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11098] syntax error at end of line in interactive python -u

[Alexey Luchko]

Alexey Luchko  added the comment:

I reported the issue just because I didn't find it is already known.
I don't think it is worth backporting.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11079] Make OS X entry in Applications like that in Windows

[Ned Deily]

Ned Deily  added the comment:

After discussions with Raymond, I now agree that it would be better to not copy 
the Tools into the Applications/Python 3.x directory since everything else 
there is of the double-clickable nature, i.e. aimed at the user more 
comfortable with a GUI interface.  Since the Tools files may be of interest to 
advanced command-line users, a better place for them is within the framework 
share directory as many other UNIX-like distributions install them in 
/usr/share.

The following two patches implement the following changes from 3.2rc2 OS X 
installer behavior.

issue11079_extras_py3k.patch:

1. modifies the Mac Makefile installextras target to put a copy of Tools/ in 
the framework at share/doc/pythonm.n/examples rather than in 
/Applications/Python m.n

2. updates the installer ReadMe file accordingly.

issue11079_doc_links.patch

3. places a link named "Python Documentation.html" in /Applications/Python m.n 
to the top-level index.html file of the installed documentation set.

4. places a link to the documentation directory in the framework at 
share/doc/pythonm.n/html

Summary of installed file differences:

/Applications/Python m.s/
  Extras/
2.7/3.1: contained ReadMe and old Demo directories
3.2rc2: contained Tools directory (note 1 below)
3.2: no longer created
  Python Documentation.html
2.7/3.1/3.2rc2: not created
3.2: symlink to index page of standard documentation:
   /Library/Frameworks/Python.framework/Versions/3.2/\
 Resources/English.lproj/Documentation/index.html

/Library/Frameworks/Python.framework/Versions/m.n/
  share/doc/pythonm.n/examples
2.7/3.1/3.2rc2: not created
3.2: contains Tools directory
  share/doc/pythonm.n/html
2.7/3.1/3.2rc1: not created
3.2: relative symlink to standard documentation location:
   ../../../Resources/English.lproj/Documentation

The included changes affect only the Mac installer script and the Mac Makefile. 
 Both variants of the installer were built with these fixes and tested on 10.5 
and 10.6 as appropriate.  If after review, the patches meet expectations, I ask 
for release manager approval to apply for 3.2final.


Note 1: If the user had installed one of the Python 3.2rc installers, the 
Extras directory and its contents will not be removed by the 3.2final installer.

Note 2: The additional documentation links should also be backported to 2.7.

--
keywords: +after moratorium, buildbot, easy, gsoc, needs review, patch
nosy: +georg.brandl
priority: normal -> critical
stage:  -> commit review
Added file: http://bugs.python.org/file20661/issue11079_doc_links.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11079] Make OS X entry in Applications like that in Windows

[Ned Deily]

Changes by Ned Deily :


Added file: http://bugs.python.org/file20662/issue11079_extras_py3k.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Stefan Behnel]

Stefan Behnel  added the comment:

Here are some real micro benchmarks (note that the pybench benchmarks actually 
do lots of other stuff besides slicing):

base line:

$ ./python -m timeit -s 'l = list(range(100)); s=slice(None)' 'l[s]'
100 loops, best of 3: 0.464 usec per loop
$ ./python -m timeit -s 'l = list(range(10)); s=slice(None)' 'l[s]'
1000 loops, best of 3: 0.149 usec per loop
$ ./python -m timeit -s 'l = list(range(10)); s=slice(None,1)' 'l[s]'
1000 loops, best of 3: 0.135 usec per loop


patched:

$ ./python -m timeit -s 'l = list(range(100))' 'l[:1]'
1000 loops, best of 3: 0.158 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[:]'
100 loops, best of 3: 0.49 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[1:]'
100 loops, best of 3: 0.487 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[1:3]'
1000 loops, best of 3: 0.184 usec per loop

$ ./python -m timeit -s 'l = list(range(10))' 'l[:]'
1000 loops, best of 3: 0.185 usec per loop
$ ./python -m timeit -s 'l = list(range(10))' 'l[1:]'
1000 loops, best of 3: 0.181 usec per loop


original:

$ ./python -m timeit -s 'l = list(range(100))' 'l[:1]'
1000 loops, best of 3: 0.171 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[:]'
100 loops, best of 3: 0.499 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[1:]'
100 loops, best of 3: 0.509 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[1:3]'
1000 loops, best of 3: 0.198 usec per loop

$ ./python -m timeit -s 'l = list(range(10))' 'l[:]'
1000 loops, best of 3: 0.188 usec per loop
$ ./python -m timeit -s 'l = list(range(10))' 'l[1:]'
100 loops, best of 3: 0.196 usec per loop


So the maximum impact seems to be 8% for very short slices (<10) and it quickly 
goes down for longer slices where the copy impact clearly dominates. There's 
still some 2% for 100 items, though.

I find it interesting that the base line is way below the other timings. That 
makes me think it's actually worth caching constant slice instances, as CPython 
already does for tuples. Cython also caches both now. I would expect that 
constant slices like [:], [1:] or [:-1] are extremely common. As you can see 
above, caching them could speed up slicing by up to 30% for short lists, and 
still some 7% for a list of length 100.

Stefan

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11079] Make OS X entry in Applications like that in Windows

[Ned Deily]

Changes by Ned Deily :


--
keywords:  -after moratorium, buildbot, easy, gsoc, patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Stefan Behnel]

Stefan Behnel  added the comment:

Here's another base line test: slicing an empty list

patched:

$ ./python -m timeit -s 'l = []' 'l[:]'
1000 loops, best of 3: 0.0847 usec per loop

original:

$ ./python -m timeit -s 'l = []' 'l[:]'
1000 loops, best of 3: 0.0977 usec per loop

That's about 13% less overhead.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> I find it interesting that the base line is way below the other
> timings. That makes me think it's actually worth caching constant
> slice instances, as CPython already does for tuples.

Indeed. I have never touched it, but I suppose it needs an upgrade of
the marshal format to support slices.
(of course, this will not help for other common cases such as l[x:x+2]).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1757072] Zipfile robustness

[Ernst Sjöstrand]

Changes by Ernst Sjöstrand :


--
nosy: +Ernst.Sjöstrand

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11098] syntax error at end of line in interactive python -u

[R. David Murray]

R. David Murray  added the comment:

Great.  Thanks for reporting it, and I'm glad we managed to already have it 
fixed :)

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11087] Speeding up the interpreter with a few lines of code

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Ok, things are at best 3-4% faster here (often unchanged).

--
versions:  -Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Stefan Behnel]

Stefan Behnel  added the comment:

> of course, this will not help for other common cases such as l[x:x+2]

... which is exactly what this slice caching patch is there for. ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Stefan Behnel]

Stefan Behnel  added the comment:

A quick test against the py3k stdlib:

find -name "*.py" | while read file; do egrep '\[[-0-9]*:[-0-9]*\]' "$file"; 
done | wc -l

This finds 2096 lines in 393 files.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11105] Compiling evil ast crashes interpreter

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Looks like a stack overflow caused by an infinite recursion.  I am not sure if 
it is possible to add cycle detection code without sacrificing performance or 
setting some arbitrary limits.

I wonder: Why ast nodes need to be mutable?

--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11105] Compiling evil ast crashes interpreter

[Benjamin Peterson]

Benjamin Peterson  added the comment:

2011/2/3 Alexander Belopolsky :
>
> Alexander Belopolsky  added the comment:
>
> Looks like a stack overflow caused by an infinite recursion.  I am not sure 
> if it is possible to add cycle detection code without sacrificing performance 
> or setting some arbitrary limits.

Yes, it's definitely low priority. It's probably easier to crash the
interpreter by producing differently malformed ast anyway.

>
> I wonder: Why ast nodes need to be mutable?

So people can change them.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11105] Compiling evil ast crashes interpreter

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

On Thu, Feb 3, 2011 at 12:08 PM, Benjamin Peterson
 wrote:
..
>> I wonder: Why ast nodes need to be mutable?
>
> So people can change them.

Well, they are hashable, so this needs to be done carefully.  Is this
necessary for AST-based optimizations?  Does Python actually change
AST after it has been created?  Note that for some optimizations it
may be more appropriate to build a new tree rather than mutate the old
one.  Depending on the algorithm, you may or may not need to change
the nodes after they have been created in the process.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11105] Compiling evil ast crashes interpreter

[Benjamin Peterson]

Benjamin Peterson  added the comment:

2011/2/3 Alexander Belopolsky :
>
> Alexander Belopolsky  added the comment:
>
> On Thu, Feb 3, 2011 at 12:08 PM, Benjamin Peterson
>  wrote:
> ..
>>> I wonder: Why ast nodes need to be mutable?
>>
>> So people can change them.
>
> Well, they are hashable, so this needs to be done carefully.  Is this
> necessary for AST-based optimizations?  Does Python actually change
> AST after it has been created?  Note that for some optimizations it
> may be more appropriate to build a new tree rather than mutate the old
> one.  Depending on the algorithm, you may or may not need to change
> the nodes after they have been created in the process.

Other people are, though. The hash is by identity anyway.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11106] python 2.6.6 and python 2.7.1 cannot be built successfully because of an segment fault on NetBSD-5.1-sparc

[H Xu]

New submission from H Xu :

Build python 2.6.6 and python 2.7.1 on a NetBSD-5.1-sparc machine.

1. Run './configure';
2. Run 'make';
3. Run 'make install'.

There will be a problem after run 'make install'.
The last few lines of error messages are like the following:

Compiling /usr/local/lib/python2.6/test/test_binop.py ...
Compiling /usr/local/lib/python2.6/test/test_bisect.py ...
Compiling /usr/local/lib/python2.6/test/test_bool.py ...
Compiling /usr/local/lib/python2.6/test/test_bsddb.py ...
Compiling /usr/local/lib/python2.6/test/test_bsddb185.py ...
Compiling /usr/local/lib/python2.6/test/test_bsddb3.py ...
Compiling /usr/local/lib/python2.6/test/test_buffer.py ...
Compiling /usr/local/lib/python2.6/test/test_bufio.py ...
Compiling /usr/local/lib/python2.6/test/test_builtin.py ...
[1]   Segmentation fault (core dumped) PYTHONPATH=/usr/...
*** Error code 139

Stop.
make: stopped in /home/xuh/src/Python-2.6.6

Same thing with python 2.7.1.

--
components: Build
messages: 127802
nosy: H.Xu
priority: normal
severity: normal
status: open
title: python 2.6.6 and python 2.7.1 cannot be built successfully because of an 
segment fault on NetBSD-5.1-sparc
type: compile error
versions: Python 2.6, Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

That's an interesting point.

Do you know of places where we use fd 2 instead of sys.stderr?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Stefan Behnel]

New submission from Stefan Behnel :

Follow-up to ticket 10227. The following facts seem to indicate that it would 
be worth caching constant instances of the slice type, such as in [:] or [:-1].

with cached slice instance:

$ ./python -m timeit -s 'l = list(range(100)); s=slice(None)' 'l[s]'
100 loops, best of 3: 0.464 usec per loop
$ ./python -m timeit -s 'l = list(range(10)); s=slice(None)' 'l[s]'
1000 loops, best of 3: 0.149 usec per loop
$ ./python -m timeit -s 'l = list(range(10)); s=slice(None,1)' 'l[s]'
1000 loops, best of 3: 0.135 usec per loop

uncached normal usage:

$ ./python -m timeit -s 'l = list(range(100))' 'l[:]'
100 loops, best of 3: 0.499 usec per loop
$ ./python -m timeit -s 'l = list(range(100))' 'l[:1]'
1000 loops, best of 3: 0.171 usec per loop

Timings based on Python 3.2 rc2.

A quick grep against the py3k stdlib finds 2096 lines in 393 files that use 
constant slices.

--
components: Interpreter Core
messages: 127804
nosy: scoder
priority: normal
severity: normal
status: open
title: Cache constant "slice" instances
type: performance
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10227] Improve performance of MemoryView slicing

[Stefan Behnel]

Stefan Behnel  added the comment:

Created follow-up issue 11107 for caching constant slice objects.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Stefan Behnel]

Stefan Behnel  added the comment:

Erm, issue 10227.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Brett Cannon  added the comment:

This was just dead assignments. I have not tackled Idempotent operations, dead 
increments, dead initializations, dead nested assignments, possible deref of 
NULL, deref of unassigned pointer, division by zero, undefined/garbage results, 
or undefined alloc of 0 bytes.

IOW I tackled 36 out of 164 reported issues. =)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Similar idea has been rejected in issue2268 because the win was too small to 
justify the number of changes that had to be made.

--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> That's an interesting point.
> 
> Do you know of places where we use fd 2 instead of sys.stderr?

We normally don't. One reason is that buffering inside sys.stderr can
make ordering of output incorrect. There are some places in C code where
we do "fprintf(stderr, ...)" but that's for specialized debugging
(disabled in normal builds) or fatal error messages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Stefan Behnel]

Stefan Behnel  added the comment:

Hmm, ok, but AFAICT, your patch was rejected rather because of the way it 
approached the problem, not so much because of the issue itself.

Plus, the fact that Python 3 requires slices in more places than Python 2 
(which had the lower level getslice protocol) makes this a bigger issue now 
than it was three years ago.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

On Thu, Feb 3, 2011 at 2:44 PM, Antoine Pitrou  wrote:
..
>> Do you know of places where we use fd 2 instead of sys.stderr?
>
> We normally don't. One reason is that buffering inside sys.stderr can
> make ordering of output incorrect. There are some places in C code where
> we do "fprintf(stderr, ...)" but that's for specialized debugging
> (disabled in normal builds) or fatal error messages.

This is the case that I had in mind.  What does non-debug build do on
a fatal error?  Also, can we be sure that Python does not call C
library functions that write to stderr behind the scenes?  If vanilla
Python is safe to run with closed fd 2, that may not be the case for
3rd party extensions.What is the use case for "python >&-"?Is
it important enough to justify the risk of accidental data loss?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

> On Thu, Feb 3, 2011 at 2:44 PM, Antoine Pitrou  wrote:
> ..
>> Do you know of places where we use fd 2 instead of sys.stderr?
>
> We normally don't.

Hmm, grep "fprintf(stderr," returned 122 hits in the py3k branch.
Are you sure these are all debug-build only?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +exarkun, loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> > We normally don't. One reason is that buffering inside sys.stderr can
> > make ordering of output incorrect. There are some places in C code where
> > we do "fprintf(stderr, ...)" but that's for specialized debugging
> > (disabled in normal builds) or fatal error messages.
> 
> This is the case that I had in mind.  What does non-debug build do on
> a fatal error?

It uses fprintf(stderr, ...). That's the only thing it can do (there's
no way sys.stderr is guaranteed to be usable at that point). If C stderr
is invalid, then too bad.

> Also, can we be sure that Python does not call C
> library functions that write to stderr behind the scenes?

I think you can guess the answer :)

> What is the use case for "python >&-"?Is
> it important enough to justify the risk of accidental data loss?

I don't think so. One more important use case is when running a Unix
daemon, which has (AFAIK) to close all std handles. I don't know how
that interacts with using C stderr, especially if the handle closing is
done in Python (and therefore only calls C close() and not fclose()!).

Perhaps we should provide a sys function to fclose() C std{in,out,err}.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Le jeudi 03 février 2011 à 19:59 +, Alexander Belopolsky a écrit :
> Alexander Belopolsky  added the comment:
> 
> > On Thu, Feb 3, 2011 at 2:44 PM, Antoine Pitrou  
> > wrote:
> > ..
> >> Do you know of places where we use fd 2 instead of sys.stderr?
> >
> > We normally don't.
> 
> Hmm, grep "fprintf(stderr," returned 122 hits in the py3k branch.
> Are you sure these are all debug-build only?

"grep -C2" seems to say most of them are. I haven't done a survey.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

On Thu, Feb 3, 2011 at 11:56 AM, Alexander Belopolsky
 wrote:
> 3rd party extensions.    What is the use case for "python >&-"?    Is
> it important enough to justify the risk of accidental data loss?

I don't think closing stderr via the command line is an important use
case, but pythonw.exe and Unix daemon processes are important use
cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11105] Compiling evil ast crashes interpreter

[Georg Brandl]

Georg Brandl  added the comment:

Alex: If the node attributes were not mutable, it would be extremely awkward, 
not to say inefficient, to mutate an already existing AST as returned by 
ast.parse().

The AST objects in the _ast module aren't what Python works with internally, 
anyway. When calling ast.parse(), the AST is converted to Python objects (these 
are defined in Python-ast.c), and compile()ing such an object converts them 
back to the internal tree representation.  This conversion is where recursions 
would need to be handled.

--
nosy: +georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> I don't think so. One more important use case is when running a Unix
> daemon, which has (AFAIK) to close all std handles.

I just took a look at http://pypi.python.org/pypi/python-daemon/, and it
uses dup2() to redirect standard streams, which is far nicer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11107] Cache constant "slice" instances

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> Hmm, ok, but AFAICT, your patch was rejected rather because of the way
> it approached the problem, not so much because of the issue itself.

I would be rather for the patch myself. The bytecode currently generated
for sliced indexing is awfully suboptimal.

> Plus, the fact that Python 3 requires slices in more places than
> Python 2 (which had the lower level getslice protocol) makes this a
> bigger issue now than it was three years ago.

True.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Am looking forward to the rest.
This will be a nice cleanup.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Changes by Brett Cannon :


Removed file: http://bugs.python.org/file20660/clang_analyzer.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Brett Cannon  added the comment:

New patch which covers dead assignments and increments.

--
Added file: http://bugs.python.org/file20663/clang_analyzer.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7111] abort when stderr is closed

[Daniel Stutzbach]

Daniel Stutzbach  added the comment:

On Thu, Feb 3, 2011 at 12:18 PM, Antoine Pitrou  wrote:
> I just took a look at http://pypi.python.org/pypi/python-daemon/, and it
> uses dup2() to redirect standard streams, which is far nicer.

I'm more worried about the case where a daemon launches python.

At startup, could we check that 2 and 3 are valid file descriptors,
and, if not, open /dev/null?  That way, they cannot later be
inadvertently assigned to some other file?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11108] Intermittent AttributeError when using time.strptime in threads

[Carlos Corbacho]

New submission from Carlos Corbacho :

time.strptime() intermittently (and I mean _really_ intermittently) throws an 
AttributeError.

Steps to reproduce:

Run the attached script (you may have to do this quite a lot of times; in an 
evening of trying, I could only trigger this bug once...) - this just starts 
lots of threads so that we have lots of time.strptime()'s running in parallel.

Expected:

It just keeps running every time.

Actual:

On one run, the script bailed out almost immediately -

ccorbacho@valkyrie:~/chroots/trunk/home/ccorbacho/scratch/ccorbacho$ python 
test_time.py
Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner
self.run()
  File "test_time.py", line 13, in run
time.strptime("30 Nov 00", "%d %b %y")
AttributeError: _strptime_time

---
This is with Python 2.6.6. However, at work we have been seeing this very 
intermittently with Python 2.5 in threaded code doing time.strptime() as well 
(though we just get AttributeError: strptime, but I don't have any code I can 
provide to reproduce on 2.5), hence I'm raising the bug.

--
components: None
files: test_time.py
messages: 127822
nosy: ccorbacho
priority: normal
severity: normal
status: open
title: Intermittent AttributeError when using time.strptime in threads
type: crash
versions: Python 2.6
Added file: http://bugs.python.org/file20664/test_time.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11106] python 2.6.6 and python 2.7.1 cannot be built successfully because of an segment fault on NetBSD-5.1-sparc

[Martin v . Löwis]

Martin v. Löwis  added the comment:

Can you debug this, e.g. by inspecting the core file?

--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11106] python 2.6.6 and python 2.7.1 cannot be built successfully because of an segment fault on NetBSD-5.1-sparc

[STINNER Victor]

STINNER Victor  added the comment:

Can you try to get a backtrace? Use make install SHELL="bash -x" to display 
executed shell commands. And then rerun the last command in gdb: after the 
crash, the "where" command will give you a backtrace.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies

[Justin]

New submission from Justin :

This is the same issue as was reported here: http://bugs.python.org/issue1954. 
It is still a problem in Python 3.1. I'm writing a server that will be 
receiving a massive number of requests and I'd like to eliminate the zombie 
problem. Once I figured out what was going on, I tried adding a call to 
collect_children() in the serve_forever() loop. It worked very well. I've 
included a patch of what I did, however, I obviously can't leave this change in 
my socketserver.py because we will be deploying this on a lot of servers.

Is there any reason not to collect_children() in the serve_forever() loop? It 
seems like the place to do it to me. The patch will only collect children if 
there are any, so it doesn't have to call it every time through the loop.

--
components: Library (Lib)
files: collect_children.patch
keywords: patch
messages: 127825
nosy: jwark
priority: normal
severity: normal
status: open
title: socketserver.ForkingMixIn leaves zombies
type: behavior
versions: Python 3.1
Added file: http://bugs.python.org/file20665/collect_children.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11106] python 2.6.6 and python 2.7.1 cannot be built successfully because of an segment fault on NetBSD-5.1-sparc

[Stefan Krah]

Stefan Krah  added the comment:

This seems to be a duplicate of #7424.

--
nosy: +skrah
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed
superseder:  -> segmentation fault in listextend during install

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7424] segmentation fault in listextend during install

[Stefan Krah]

Stefan Krah  added the comment:

See also:

http://gnats.netbsd.org/42627

--
nosy: +H.Xu, haypo, loewis, skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9045] 2.7rc1: 64-bit OSX installer is not built with 64-bit tkinter

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
components: +Build
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1038909] pydoc method documentation lookup enhancement

[Éric Araujo]

Éric Araujo  added the comment:

Note that similar (duplicate?) #426740 was rejected, so maybe the discussion 
here is moot.

FWIW, I believe using a decorator or a custom metaclass to explicitly inherit a 
docstring is a good way of achieving what you want.

--
nosy: +calvin
versions: +Python 3.3 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8887] “pydoc str” works but not “pydoc str.translate”

[Éric Araujo]

Éric Araujo  added the comment:

Yep, same bug.

Possibly related: #410336 (I have to read it again to make sure).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9364] some problems with the documentation of pydoc

[Éric Araujo]

Éric Araujo  added the comment:

>> In the Python interpreter, do "from pydoc import help" to provide online
>> help.  Calling help(thing) on a Python object documents the object.
> Which is no longer accurate, because the help() function has long ago
> become a built-in.
To be pedantic, help is not available if python was started with -S.  (The docs 
for site and -S are cross-linked, so that should be discoverable easily 
enough.)  +1 on removing the outdated piece of advice.

> 1. The output from help(help) could be made more clear.
Agreed.

> Why should help special-case itself (with a slightly garbled line?)
> This would be a code patch to pydoc.help
I haven’t found any special-casing code.  Quick testing shows it’s just how 
pydoc displays help for instances of Python classes.  I think making the 
docstring of site._Helper better (i.e. explain what the class is for + tell 
people to call help() to access the doc system) would be enough, nothing to 
change in pydoc.py unless I’ve missed something.

(BTW, pydoc code is quite intricated, reminds me a bit of distutils!  Who wants 
to make a graph explaining how help works?)

> "This is a wrapper around pydoc.help" good so far "(with a twist)" thanks a 
> lot.
> I think the comment should be either removed or explained.
Agreed.  I think the “twist” is that the import is lazy and that help has a 
useful repr (wow, talk about a twist!).  Those details need not be alluded to, 
just remove the comment (“wrapper” is IMO enough to raise curiosity, the source 
is here to find what’s the wrapping).

> Replace "Define the built-in 'help'." with something clearer and more 
> accurate,
> such as "The name 'help' is injected in module builtins after being bound
> to an instance of this class.".
I think that’s too much detail.  “Class used to implement the built-in help 
function” is enough for my taste.

> 2. Improve manual chapter for site module.
+1 on better explaining behavior where needed, -1 on documenting implementation 
details starting with underscores.

> Add "inject 'help' into builtins and " after append.
-1.  help is documented in http://docs.python.org/dev/library/functions#help ; 
quit, exit, license, copyright and credits are documented in 
http://docs.python.org/dev/library/constants#constants-added-by-the-site-module 
(see #652749).  To prevent duplication, let’s just add a link from site to 
constants.

(You don’t want to know how much time the previous paragraph has cost me.)

> "This module contains a class (_Helper) that wraps function pydoc.help.
> An instance of the class is bound to name 'help' in the builtins module."
-1.  Counter-proposal: Add a link to library/functions#help from 
library/constants; add a link from library/site to library/constants.

> A recent discussion on pydev or maybe python-list (in the thread mentioned
> above?) implied that one could usefully make another instance of _Helper or 
> maybe a
> subclass thereof. I did not pay enough attention, though, to really get it.
I’m curious about the use cases. Eli, can you give us the date of the private 
email from Terry so that someone can dig up the thread?

> "XXX Update documentation"
This comment refers to new functions in site to support PEP 370.

> "XXX document python -m site --user-base --user-site"
We can reuse the example written by Raymond for the whatsnew/3.2 document.

To sum up: needs one patch for Lib/site.py, one to add cross-links in 
Doc/library, one to add missing functions/data from PEP 370 in 
Doc/library/site.rst, another one to the same file to document the command-line 
interface of site (those last two may be one, if the contributor is motivated). 
 I suggest to wait for replies to my points above, and if there is consensus or 
lack of disagreement, someone can turn my suggestions into patches.

--
nosy: +eric.araujo
versions: +Python 2.7, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1613479] pydoc info for a package doesn't list all package contents

[Éric Araujo]

Éric Araujo  added the comment:

I’ve just tested that the behavior is now correct.  I reproduced the tree 
structure, set PYTHONPATH, ran “pydoc foo” to get only “one” listed, added the 
pkgutil call in first/path/foo/__init__.py, re-ran “pydoc foo”, got “one” and 
“two” listed.  I can also import both submodules.

The pydoc code now uses pkgutil.iter_modules.  Someone must have fixed that 
before 2.6, closing.  Thanks for the report nonetheless!

--
nosy: +eric.araujo -BreamoreBoy
resolution:  -> out of date
stage: unit test needed -> committed/rejected
status: open -> closed
versions:  -Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2193] Cookie Colon Name Bug

[Carsten Klein]

Carsten Klein  added the comment:

if you'd take a close look at the following lines accepted as part of the patch 
for stripping out unwanted/non standard cookies over trac:

+try:
+old_set(key, real_value, coded_value)
+except CookieError:
+bad_cookies.append(key)

then you will find that trac actually behaves just like what is requested in 
the "original" RFC, namely that the colon is part of the reserved or special 
characters not meant for inclusion with the cookie name or, as it was stated in 
the referred rfc, the token.

Please do not fix.

--
nosy: +carsten.kl...@axn-software.de

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3835] tkinter goes into an infinite loop (pydoc.gui)

[Éric Araujo]

Changes by Éric Araujo :


--
components: +Tkinter
versions: +Python 3.3 -Python 3.0

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8637] pydoc should respect MANPAGER over PAGER.

[Éric Araujo]

Éric Araujo  added the comment:

Is there a standard documenting MANPAGER somewhere?

--
nosy: +eric.araujo
versions: +Python 3.3 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Brett Cannon  added the comment:

Here is a new patch which includes setting the noreturn attribute on 
Py_FatalError() and Py_Exit() in order to make the null pointer deref analysis 
results more tractable.

--
Added file: http://bugs.python.org/file20666/analyzer_fixes.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Brett Cannon  added the comment:

This is a new set of results with the analyzer_fixes.diff file applied using 
the latest analyzer.

--
Added file: http://bugs.python.org/file20667/checker_254_2011-02-03.tar.xz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8637] pydoc should respect MANPAGER over PAGER.

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

On Thu, Feb 3, 2011 at 7:09 PM, Éric Araujo  wrote:
>
> Éric Araujo  added the comment:
>
> Is there a standard documenting MANPAGER somewhere?
>

Not really a standard, but man page for man on my OSX laptop says:

"""
   -P  pager
  Specify which pager to use.  This option overrides the
MANPAGER environment variable, which in turn overrides the PAGER
variable.
"""

POSIX only mandates PAGER.  See
.

As I said before, since pydoc is not man, if we want a pydoc-specific
variable to override PAGER, it should be callled PYDOCPAGER.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2193] Cookie Colon Name Bug

[Carsten Klein]

Carsten Klein  added the comment:

Besides that, BM is wrong in the assumption that *who ever he is* Davi M. 
Kristol states that the colon is a valid character.
There is no such notion in the article. In fact, DMK repeats the definition 
found in the original RFC on cookies, which also was referred to in the follow 
up RFC and then again referred to in the current RFC which seeks to get rid of 
the set-cookie2 directive, combining the two RFCs into a single RFC/pseudo 
standard.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3367] Uninitialized value read in parsetok.c

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

I don't have a working valgrind or purify, but I was able to reproduce the 
problem using a poor man's solution of adding

 assert(0xcbcbcbcbcbcbcbcb != tok->line_start);

before

 if (a >= tok->line_start)
 
With that assert the debug build indeed crashes once I hit Ctrl-D.  Attached 
patch fixes that. 

I have also added tok->line_start in a few tok constructors for which I don't 
have a test case demonstrating access to uninitialized value, but it seems to 
be good defensive programming.

--
nosy: +belopolsky
Added file: http://bugs.python.org/file20668/issue3367.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11108] Intermittent AttributeError when using time.strptime in threads

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc  added the comment:

It's a duplicate of issue7980.
One workaround is to call strptime() once in the main thread.

--
nosy: +amaury.forgeotdarc
resolution:  -> duplicate
status: open -> closed
superseder:  -> time.strptime not thread safe

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue940286] pydoc.Helper.help() ignores input/output init parameters

[Éric Araujo]

Éric Araujo  added the comment:

I just added another comment on Rietveld because I thought this was not fixed 
:)  Demo session:

  $ pydoc3.2 nonlocal  # will launch my pager, then print to stdout
  
  Related help topics: global, NAMESPACES

Kevin Le, would you like to write a failing test to confirm my bug?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8637] Add PYDOCPAGER envvar to specify pager for pydoc

[Éric Araujo]

Éric Araujo  added the comment:

My man(1) also respects MANPAGER (it’s the one from http://man-db.nongnu.org/), 
but given the lack of a standard, I agree with you.

However, I’m reluctant to add another env variable.  There are workarounds, for 
example using a shell alias like “docpy="PAGER=most pydoc"”.  I think this 
warrants a python-ideas discussion.

Justin: what exactly is a pager that does not support man pages?

--
stage: unit test needed -> 
title: pydoc should respect MANPAGER over PAGER. -> Add PYDOCPAGER envvar to 
specify pager for pydoc

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3367] Uninitialized value read in parsetok.c

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

George,

This is not really important enough to get into the 3.2 release, but 
uninitialized variable bugs tend to be nasty when they bite you, so I'll ask 
your opinion before bumping the version.

--
assignee:  -> georg.brandl
nosy: +georg.brandl
stage: unit test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8637] Add PYDOCPAGER envvar to specify pager for pydoc

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

On Thu, Feb 3, 2011 at 7:39 PM, Éric Araujo  wrote:
..
> Justin: what exactly is a pager that does not support man pages?

I may know the answer to this one.  A common PAGER setting is "less
-rs" which makes less skip whitespace lines and passes through
terminal control chars.  Nether of these options are needed for pydoc,
but I don't know if they cause any harm.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9523] Improve dbm modules

[Éric Araujo]

Éric Araujo  added the comment:

Thank you for working on a patch, especially with such comprehensive tests.

> The object returned by :func:`.open` supports the same basic functionality as
> -dictionaries
> +:mod:`collection`.MutableMapping

The previous text was okay, I wouldn’t have changed it.

> def items(self):
>+return set([(key, self[key]) for key in self._index.keys()])
I don’t know if you should use a plain set or a collections.ItemsView here.  In 
dict objects, KeysView and ValuesView are set-like objects with added behavior, 
for example they yield their elements in the same order.  Raymond, can you 
comment?

Style remarks: you can iter without calling _index.keys(); you can avoid the 
intermediary list (IOW, remove enclosing [ and ]).

In the tests, you can use specialized methods like assertIn and assertIsNone, 
they remove some boilerplate and can give better error output.

I can’t review the C code. :)

--
nosy: +rhettinger
versions: +Python 3.3 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6045] Add more dict methods to dbm interfaces

[Éric Araujo]

Éric Araujo  added the comment:

I believe this is now superseded by #9523, which has less discussion but a 
patch.

--
resolution:  -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
superseder:  -> Improve dbm modules

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9523] Improve dbm modules

[Éric Araujo]

Éric Araujo  added the comment:

See #5736 for a patch adding iteration support.  If the patch attached to his 
report supersedes the other one, I’ll close the other bug as duplicate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11104] distutils sdist ignores MANIFEST

[Éric Araujo]

Éric Araujo  added the comment:

This behavior change is actually present in 2.7.1, 3.1.3 and 3.2.  I’m 
concerned that you’ve found a bug with it (thanks for the report), and that we 
may have to change behavior again.

First, could you open another report about comment handling in read_manifest?  
I overlooked that, and it should be fixed as quickly as possible, although 
there’s very little change this will make it into 3.2.0 (we’ll have 3.2.1 
though).

Second, can you give us a test script (shell or Python) or a set of 
instructions we can reproduce to observe the behavior you say is defective?  
Thanks in advance.

--
components: +Distutils2
versions: +3rd party, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9189] Improve CFLAGS handling

[Éric Araujo]

Éric Araujo  added the comment:

I think this report can be closed now.

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9189] Improve CFLAGS handling

[Brett Cannon]

Changes by Brett Cannon :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10847] Distutils drops -fno-strict-aliasing when CFLAGS are set

[Éric Araujo]

Éric Araujo  added the comment:

Thanks for the report.  It came up on the debian-python ML recently too, and is 
actually already reported.  Following up on the other report.

--
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed
superseder:  -> BASECFLAGS are not passed to module build line

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue969718] BASECFLAGS are not passed to module build line

[Éric Araujo]

Éric Araujo  added the comment:

Pythons in Debian seem to be immune to this problem, thanks to this patch: 
http://deb.li/3ku1g (via 
http://lists.debian.org/debian-python/2010/12/msg5.html).

I haven’t had time to learn the intricacies of make variables yet, so I can’t 
approve a patch.  I’m adding people from the nosy lists of other make variables 
bugs, hopefully someone will be able to review.

--
nosy: +brett.cannon, georg.brandl, jyasskin, lemburg, lukasz.langa, 
mark.dickinson, pitrou, ronaldoussoren, skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue969718] BASECFLAGS are not passed to module build line

[Éric Araujo]

Éric Araujo  added the comment:

Duplicate report from Stephan Krah:

When CFLAGS are set, distutils drops -fno-strict-aliasing (among other
flags):


$ python2.7 setup.py build
...
gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes -fPIC -I./src -I/usr/local/include 
-I/usr/local/include/python2.7 -c src/gmpy.c -o 
build/temp.linux-x86_64-2.7/src/gmpy.o
...

$ CFLAGS="-fomit-frame-pointer" python2.7 setup.py build
...
gcc -pthread -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes 
-fomit-frame-pointer -fPIC -I./src -I/usr/local/include 
-I/usr/local/include/python2.7 -c src/gmpy.c -o 
build/temp.linux-x86_64-2.7/src/gmpy.o
src/gmpy.c: In function ‘_cmp_to_object’:
src/gmpy.c:4692: warning: dereferencing type-punned pointer will break 
strict-aliasing rules
...

I'm not sure if this is intentional. The documentation says:

"Compiler flags can also be supplied through setting the CFLAGS
environment variable. If set, the contents of CFLAGS will be added
to the compiler flags specified in the Setup file."

To me, this sounds as if they should be appended to the regular flags.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9168] setuid in smtp.py sheds privileges before binding port

[Éric Araujo]

Changes by Éric Araujo :


--
keywords: +needs review
stage:  -> patch review
type: crash -> behavior
versions: +Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8914] Run clang's static analyzer

[Brett Cannon]

Brett Cannon  added the comment:

OK, done going through the results. Attached is a patch with all of the fixes 
(only one actual bug which I file an issue for separately; everything else is 
removing a little bit of dead code here and there).

--
Added file: http://bugs.python.org/file20669/wheres_my_pony.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11110] Py_DECREF->Py_XDECREF in Module/_sqlite/module.c

[Brett Cannon]

New submission from Brett Cannon :

Pretty straight forward change, but could potentially cause a NULL pointer 
deref in a rare situation.

diff --git a/Modules/_sqlite/module.c b/Modules/_sqlite/module.c
--- a/Modules/_sqlite/module.c
+++ b/Modules/_sqlite/module.c
@@ -329,7 +329,7 @@
 (pysqlite_statement_setup_types() < 0) ||
 (pysqlite_prepare_protocol_setup_types() < 0)
) {
-Py_DECREF(module);
+Py_XDECREF(module);
 return NULL;
 }

--
components: Extension Modules
files: fix_sqlite.diff
keywords: patch
messages: 127853
nosy: brett.cannon, georg.brandl
priority: release blocker
severity: normal
stage: commit review
status: open
title: Py_DECREF->Py_XDECREF in Module/_sqlite/module.c
versions: Python 3.2
Added file: http://bugs.python.org/file20670/fix_sqlite.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8933] Invalid detection of metadata version

[Éric Araujo]

Changes by Éric Araujo :


--
keywords: +easy
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1038909] pydoc method documentation lookup enhancement

[Ron Adam]

Ron Adam  added the comment:

I agree. It is close enough to be a duplicate. I suggest closing it.

As Ka-Ping noted in the other issue:
"There's a link to the base class provided if you want to find out what the 
base class does."

This is easy to do if your viewing pydoc output in a web browser.  And you can 
also look at the source code to see any comments.

At some point we can consider enhancing the command line help mode to make it 
easier to do the same.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9399] Provide a 'print' action for argparse

[Éric Araujo]

Éric Araujo  added the comment:

Thanks for the new patch.  It does not apply cleanly to the py3k branch, but 
that’s very easily corrected.


self.file.write(self.message)
self.file.write('\n')

Could be replaced by
print(self.message, file=self.file)

print will use the right EOL for the platform and is just coooler.


By the way, self.file should not be rebound in __call__:
if self.file is None:
self.file = _sys.stdout
→
file = (self.file if self.file is not None else _sys.stdout)


> Second, there are cases where you want whitespaces to be preserved,
> like printing out the license of your program (as I mentioned in my
> first post) Just look at this BSD license: [...]
> This is just plain ugly.

Agreed, but I did not suggest that the output be like that.  In my previous 
message, I suggested that argparse could replace \n with spaces and do its own 
line wrapping, to adapt to terminal length while avoiding chunking ugliness.  
That’s Steven’s call anyway, I don’t have any strong feeling in favor of 
preserving whitespace or rewrapping.  If argparse wraps lines to the terminal 
width in other cases (like with epilog text), I think it should do so here too.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11111] See "Gmail" on your Google homepage

[reynaldo]

New submission from reynaldo :

Your friend, renbe...@gmail.com, has sent you the following Google Gadget.

See "Gmail" on your Google homepage »

screenshot

--
files: unnamed
messages: 127856
nosy: renben
priority: normal
severity: normal
status: open
title: See "Gmail" on your Google homepage
Added file: http://bugs.python.org/file20671/unnamed

___
Python tracker 

___Your friend, renbe...@gmail.com, has sent you the following Google 
Gadget.http://www.google.com/ig/adde?moduleurl=builtin_gmail.xml&source=imag";>See
 "Gmail" on your Google homepage »http://www.google.com/ig/modules/builtin_content/en_us/gmail.jpg"; 
alt="screenshot">___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11104] distutils sdist ignores MANIFEST

[John Dennis]

John Dennis  added the comment:

$ tar xzf distutils_bug.tar.gz
$ cd distutils_bug
$ ./setup.py sdist

$ ./setup.py sdist
running sdist
running check
warning: sdist: manifest template 'MANIFEST.in' does not exist (using default 
file list)

not writing to manually maintained manifest file 'MANIFEST'
creating foobar-1.0
making hard links in foobar-1.0...
hard linking README -> foobar-1.0
hard linking setup.py -> foobar-1.0
creating dist
Creating tar archive
removing 'foobar-1.0' (and everything under it)

$ cat MANIFEST 
README
setup.py
my_special_file

Note, the MANIFEST should have been read and the resulting tar file should have 
had my_special_file in it. sdist complains about a missing MANIFEST.in template 
which it shouldn't, it should use the existing MANIFEST, it also emits a 
warning about not overwriting a manually maintained MANIFEST which it 
shouldn't. It should just use the existing MANIFEST.

--
Added file: http://bugs.python.org/file20672/distutils_bug.tar.gz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11111] See "Gmail" on your Google homepage

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Spam.

--
nosy: +belopolsky -renben
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11110] Py_DECREF->Py_XDECREF in Module/_sqlite/module.c

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

It may be clearer and match Python coding style better to fix it as follows:


Index: Modules/_sqlite/module.c
===
--- Modules/_sqlite/module.c(revision 88320)
+++ Modules/_sqlite/module.c(working copy)
@@ -321,14 +321,16 @@
 
 module = PyModule_Create(&_sqlite3module);
 
-if (!module ||
-(pysqlite_row_setup_types() < 0) ||
-(pysqlite_cursor_setup_types() < 0) ||
-(pysqlite_connection_setup_types() < 0) ||
-(pysqlite_cache_setup_types() < 0) ||
-(pysqlite_statement_setup_types() < 0) ||
-(pysqlite_prepare_protocol_setup_types() < 0)
-   ) {
+if (module == NULL)
+return NULL;
+
+if (pysqlite_row_setup_types() < 0 ||
+pysqlite_cursor_setup_types() < 0 ||
+pysqlite_connection_setup_types() < 0 ||
+pysqlite_cache_setup_types() < 0 ||
+pysqlite_statement_setup_types() < 0 ||
+pysqlite_prepare_protocol_setup_types() < 0)
+{
 Py_DECREF(module);
 return NULL;
 }

--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11045] shutil._make_tarball

[Éric Araujo]

Éric Araujo  added the comment:

Arg, #9173 had a patch including a test.  Not sure which bug is superseded by 
the other.

--
nosy: +fdrake, paulsmith, v_peter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9173] logger statement not guarded in shutil._make_tarball

[Éric Araujo]

Éric Araujo  added the comment:

Duplicate report #11045 was opened recently; I didn’t remember this report and 
committed a one-line fix without a test.  Should we try to get a test into 
3.2.0?

--
nosy: +georg.brandl, kelseyhightower, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6142] distutils2 clean command: Remove extension modules built in-place

[Éric Araujo]

Éric Araujo  added the comment:

Discussion summary:
- clean is supposed to remove the products of build
- build_ext is a subcommand of build
- build_ext with the inplace option writes files that are not removed by clean
- removing .pyc files is out of scope (they’re products of normal Python 
behavior, not related to distutils)
→ I’m reclassifying this as a distutils2 feature request concerning the 
products of build_ext --inplace.

I’m not sure whether we should remove those products when the --all option is 
given to clean, or add a new option that we could enable by default.

--
assignee: tarek -> 
components: +Distutils2 -Distutils
stage:  -> needs patch
title: Distutils doesn't remove .pyc files -> distutils2 clean command: Remove 
extension modules built in-place
versions: +3rd party -Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11112] UDPTimeoutTest derives from SocketTCPTest

[rmtew]

New submission from rmtew :

File: Lib\test\test_socket.py

Code: 

  class UDPTimeoutTest(SocketTCPTest):

Problem:

This test is intended to test UDP sockets, but derives from SocketTCPTest.  
Logic dictates this should derive from SocketUDPTest.

I've searched for UDP (with differing case, as that seems to matter) in several 
different fields on this site, and found no relevant matches.

--
components: Tests
messages: 127863
nosy: rmtew
priority: normal
severity: normal
status: open
title: UDPTimeoutTest derives from SocketTCPTest
versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9691] sdist includes files that are not in MANIFEST.in

[Éric Araujo]

Éric Araujo  added the comment:

Can’t reproduce on POSIX (linux2) either.  Have you tested with 3.1, 3.2 and 
distutils2?

--
components: +Windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11113] html.entities mapping dicts need updating?

[Brian Jones]

New submission from Brian Jones :

In Python 3.2b2, html.entities.codepoint2name and name2codepoint only support 
the 252 HTML entity names defined in the HTML 4 spec from 1997. I'm wondering 
if there's a reason not to support W3C Recommendation 'XML Entity Definitions 
for Characters' 

http://www.w3.org/TR/xml-entity-names/

This standard contains significantly more characters, and it is noted in that 
spec that the HTML 5 drafts use that spec's entities. You can see the current 
HTML 5 'Named character references' here: 

http://www.w3.org/TR/html5/named-character-references.html#named-character-references

If this is just a matter of somebody going in to do the grunt work, let me 
know. 

If startup costs associated with importing a huge dictionary are a concern, 
perhaps a more efficient type that enables the same lookup interface can be 
defined. 

If other reasons exist to not move in this direction, please do let me know!

--
components: Library (Lib), Unicode, XML
messages: 127865
nosy: Brian.Jones
priority: normal
severity: normal
status: open
title: html.entities mapping dicts need updating?
type: feature request
versions: Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10419] distutils command build_scripts fails with UnicodeDecodeError

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2437] Distutils runtime_library_dirs broken on Windows

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8688] distutils sdist is too lazy w.r.t. recalculating MANIFEST

[Éric Araujo]

Éric Araujo  added the comment:

There is a bug in the new code.  See #11104.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7100] test_xmlrpc: global name 'stop_serving' is not defined

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11104] distutils sdist ignores MANIFEST

[Éric Araujo]

Éric Araujo  added the comment:

Thank you, the bug is clear now.  To fix this regression, the first step is to 
turn your tarball and instructions into a unit test and then fix the logic in 
the code.  If you want to do it, there are some process guidelines at 
http://wiki.python.org/moin/Distutils/FixingBugs

--
assignee: tarek -> eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10860] Handle empty port after port delimiter in httplib

[Éric Araujo]

Éric Araujo  added the comment:

>From RFC 3986, section 6.2.3 “Scheme-Based Normalization”:

   The syntax and semantics of URIs vary from scheme to scheme, as
   described by the defining specification for each scheme.
   Implementations may use scheme-specific rules, at further processing
   cost, to reduce the probability of false negatives.  For example,
   because the "http" scheme makes use of an authority component, has a
   default port of "80", and defines an empty path to be equivalent to
   "/", the following four URIs are equivalent:

  http://example.com
  http://example.com/
  http://example.com:/
  http://example.com:80/

IOW, the empty string is not an invalid port.  The patch fixes that.  It 
includes tests but lacks a doc update.  I think it works for https URIs too, 
but I’d like a test to make sure.

--
resolution: invalid -> 
stage: needs patch -> patch review
status: pending -> open
versions: +Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9756] Crash with custom __getattribute__

[Alexander Belopolsky]

Alexander Belopolsky  added the comment:

Here is a somewhat more straightforward way to reproduce the problem:

>>> class X:
...__class__ = int
... 
[55910 refs]
>>> isinstance(X(), int)
True
[55914 refs]
>>> int.bit_length(X())
Assertion failed: (PyLong_Check(v)), function long_bit_length, file 
../py3k-commit/Objects/longobject.c, line 4413.
Abort trap

The place to implement a stricter check would be in methoddescr_call() function 
defined in Objects/descrobject.c, but it may affect legitimate tricks.  On the 
other hand, requiring that every C implemented method checks the type of self 
in a type-specific way is probably not feasible either.

--
nosy: +belopolsky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10042] total_ordering stack overflow

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
type: crash -> behavior
versions:  -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11106] python 2.6.6 and python 2.7.1 cannot be built successfully because of an segment fault on NetBSD-5.1-sparc

[H Xu]

H Xu  added the comment:

The result of 'make install SHELL="bash -x"' seems nothing different with the 
"make install". Could there be any other way to debug?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10736] test_ttk_guionly fails on OS X using ActiveState Tcl 8.5.9 (Cocoa)

[Ned Deily]

Ned Deily  added the comment:

After looking into these two test failures a bit more, it looks like both are 
due to regressions and/or bugs in the ActiveState Tk 8.5.9 Cocoa behavior 
versus the Apple Cocoa Tk 8.5.7, with which neither test fails.

The test_tab_identifiers failure may be a test case error where the test is 
making unwarranted assumptions about how the Notebook widget lays out its tabs.

The test_traversal failure may need to be modified to use a different key 
modifier for OS X ( -> ) but there appears to be a deeper problem 
within Cocoa Tk on how the traversal is implemented (hint, option-char can run 
into the dead key problem documented in Issue10973).

http://docs.python.org/py3k/library/tkinter.ttk.html#tkinter.ttk.Notebook.enable_traversal

Neither of these failures appear to indicate any problems with tkinter itself.  
At this stage in the 3.2 cycle, the failures can either be ignored or, if 
necessary, conditionally disabled for platform 'darwin'. This should be a 
release manager call.  Otherwise, the next step would be to isolate further and 
report as possible upstream bugs.

Also, the "setCanCycle: is deprecated" warnings have subsequently been shown to 
be avoidable by a change in the upstream Tcl/Tk build process and are expected 
to disappear in the next release of ActiveState Tcl/Tk 8.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com