Re: [pve-devel] [PATCH v4 qemu-server 1/2] bump pve-common
This isn't bumping the version of pve-common, but the build-dependency only (why not the installation dependency too?). The common commit subject style used for such things, as can be seen by checking git log on debian/control, is: "d/control: bump build-dependency of pve-common" Then a short sentence in the message: "we require the new for XYZ" On 27/05/2022 13:48, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > > Changes from v3: > None > > Changes from v1/v2: > new patch > > > debian/control | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/control b/debian/control > index af258db..2898593 100644 > --- a/debian/control > +++ b/debian/control > @@ -7,7 +7,7 @@ Build-Depends: debhelper (>= 12~), > libio-multiplex-perl, > libjson-c-dev, > libpve-cluster-perl, > - libpve-common-perl (>= 7.1-3), > + libpve-common-perl (>= 7.1-4), > libpve-guest-common-perl (>= 4.1-1), > libpve-storage-perl (>= 6.1-7), > libtest-mockmodule-perl, ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] applied: [PATCH v4 manager 1/3] fix typo
On 27/05/2022 13:48, Matthias Heiserer wrote: > Worked before because if SCSI should be a value, that's set in init. > isScsi is never used. > > Signed-off-by: Matthias Heiserer > --- > > Changes from v3: > New patch > > www/manager6/qemu/HDEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, but amended the commit to add an actual telling commit subject and reworded the message a bit, thanks! ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH pve-cluster] Change log statements to debug
On 27/05/2022 11:37, Matthias Heiserer wrote:
> They have been commented with //fixme for more than 11 years
> and contain little information, so at least make them debug logs.
not really that of a good reason? Was there some actual event from a
user report or similar to trigger this? As otherwise one could argue
that they didn't really bother anyone in 11 years, so not much gained
in removing them. If there where actual some complaints about noise,
I'd at least also drop the fixme comment.
>
> Signed-off-by: Matthias Heiserer
> ---
> data/src/logger.c | 2 +-
> data/src/status.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/src/logger.c b/data/src/logger.c
> index 619e1f6..c4fcdaa 100644
> --- a/data/src/logger.c
> +++ b/data/src/logger.c
> @@ -626,7 +626,7 @@ clusterlog_insert(
> if (dedup_lookup(cl->dedup, entry)) {
> clog_copy(cl->base, entry);
> } else {
> - cfs_message("ignore duplicate"); // fixme remove
> + cfs_debug("ignore duplicate"); // fixme remove
> }
>
> g_mutex_unlock(&cl->mutex);
> diff --git a/data/src/status.c b/data/src/status.c
> index 9bceaeb..5e39109 100644
> --- a/data/src/status.c
> +++ b/data/src/status.c
> @@ -1668,7 +1668,7 @@ dfsm_deliver(
> cfs_critical("cant parse update message");
> }
> } else if (msg_type == KVSTORE_MESSAGE_LOG) {
> - cfs_message("received log"); // fixme: remove
> + cfs_debug("received log"); // fixme: remove
> const clog_entry_t *entry;
> if ((entry = kvstore_parse_log_message(msg, msg_len))) {
> clusterlog_insert(cfs_status.clusterlog, entry);
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH-SERIES cluster/common/qemu-server/lxc/manager] add new metric stats in single rrd
Hi Thomas, for pressure, I don't really need rrd or history, as I can already broadcast last 10s,60s, 300s. so could simply broadcast them in kvstore. This was the original patch in 2020 https://lists.proxmox.com/pipermail/pve-devel/2020-October/045493.html but Dietmar asked about to put them in rrd ;) So, as you want, just tell me :) I don't care about rrd for my need. Anyway, For vm balancing, I was planning to compute average metric instead parsing at lot of rrd. for ksm, I really need current value for qemu hostcpu/hostmem, last (1-5) minutes average could be enough, so I could compute from pvestatd too. Alexandre Le mercredi 25 mai 2022 à 17:03 +0200, Thomas Lamprecht a écrit : > On 25/05/2022 08:52, Alexandre Derumier wrote: > > Hi, > > > > I'm still working on vm balancing/scheduling, and need some new > > metrics. > > > > but you don't actually need the metrics themselves but only the > computed > moving avg result and such of them? Because if that's the case we > could just > keep the last X values we require for the moving window cached > locally in > pvestatd and use those to broadcast the calculated ones use for DRS > once or > twice every minute or so via the per-node kv status in the pvestatd? > > Could mean less data an no new RRD format/paths (iow. no touching of > pve-cluster at all). What do you think? > > ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
