Re: typo

[Magnus Hagander]

On Mon, Nov 26, 2018 at 8:42 AM Michael Paquier  wrote:

> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
> > On 26/11/2018 08:03, Magnus Hagander wrote:
> >> Are you sure that's right? To me the original wording of that sentence
> >> seems to convey the message properly, and the update done does not?
> >
> > Yeah, I just found this on the committers list and I disagree with the
> > change as well.
>
> [... checking around ...]
> Hm.  I have read the sentence and the surroundings a couple of times
> before doing anything, and using an adverb looked clearer than the
> adjective.  Is an adjective more appropriate than an adverb here because
> it insists more on the fact that each row is involved?  Just trying to
> grab the difference.
>

If the current text is unclear to people we should definitely fix it --
just to the right thing.

Maybe say something like "keep inline in the regular table rows" instead?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: typo

[Tom Lane]

Michael Paquier  writes:
> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>> On 26/11/2018 08:03, Magnus Hagander wrote:
>>> Are you sure that's right? To me the original wording of that sentence
>>> seems to convey the message properly, and the update done does not?

>> Yeah, I just found this on the committers list and I disagree with the
>> change as well.

> [... checking around ...]
> Hm.  I have read the sentence and the surroundings a couple of times
> before doing anything, and using an adverb looked clearer than the
> adjective.  Is an adjective more appropriate than an adverb here because
> it insists more on the fact that each row is involved?  Just trying to
> grab the difference.

I think that text is mine originally, and it was not a typo.  The meaning
of "table rows proper", in this case, is basically "table rows themelves".
The first dictionary I looked at gives this example:

PROPER
Adjective [ chiefly British ]
  ... [ postpositive ] Strictly so called; in its true form.
  "some of the dos and don'ts in espionage proper"

But I can see that a lot of people might not be familiar with that usage,
so I've got no objections to rewriting it more clearly --- any
suggestions?

regards, tom lane

Re: typo

[Vik Fearing]

On 26/11/2018 15:14, Tom Lane wrote:
> Michael Paquier  writes:
>> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>>> On 26/11/2018 08:03, Magnus Hagander wrote:
 Are you sure that's right? To me the original wording of that sentence
 seems to convey the message properly, and the update done does not?
> 
>>> Yeah, I just found this on the committers list and I disagree with the
>>> change as well.
> 
>> [... checking around ...]
>> Hm.  I have read the sentence and the surroundings a couple of times
>> before doing anything, and using an adverb looked clearer than the
>> adjective.  Is an adjective more appropriate than an adverb here because
>> it insists more on the fact that each row is involved?  Just trying to
>> grab the difference.
> 
> I think that text is mine originally, and it was not a typo.  The meaning
> of "table rows proper", in this case, is basically "table rows themelves".
> The first dictionary I looked at gives this example:
> 
> PROPER
> Adjective [ chiefly British ]
>   ... [ postpositive ] Strictly so called; in its true form.
>   "some of the dos and don'ts in espionage proper"
> 
> But I can see that a lot of people might not be familiar with that usage,
> so I've got no objections to rewriting it more clearly --- any
> suggestions?

How about

  A table that has columns with potentially large entries will have an
  associated TOAST table, which is used for out-of-line storage of field
- values that are too large to keep in the table rows proper.
+ values that are too large to keep in the main table storage.

-- 
Vik Fearing  +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

Re: typo

[Erik Rijkers]

On 2018-11-26 15:14, Tom Lane wrote:

Michael Paquier  writes:

On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:

On 26/11/2018 08:03, Magnus Hagander wrote:
Are you sure that's right? To me the original wording of that 
sentence

seems to convey the message properly, and the update done does not?


Yeah, I just found this on the committers list and I disagree with 
the

change as well.



[... checking around ...]
Hm.  I have read the sentence and the surroundings a couple of times
before doing anything, and using an adverb looked clearer than the
adjective.  Is an adjective more appropriate than an adverb here 
because

it insists more on the fact that each row is involved?  Just trying to
grab the difference.


I think that text is mine originally, and it was not a typo.  The 
meaning
of "table rows proper", in this case, is basically "table rows 
themelves".


Maybe that is not a bad alternative
   "table rows themselves"

Even if that sounds slightly less idiomatic than the original, I think 
it'd be less of a stumbling block for non-native readers.

Re: Error in 42.12. Porting from Oracle PL/SQL

[Bruce Momjian]

On Wed, Nov 14, 2018 at 12:28:27AM -0500, Anthony Greene wrote:
> Documentation for v10.5, second paragraph, third sentence.
> 
> Currently reads: Assignments, loops, conditionals are similar.
> 
> Should read: Assignments, loops, and conditionals are similar.

Agreed.  Fix applied back through 9.4.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

RE: typo

[Ahmed, Nawaz]

I think "table rows themselves" makes sense. I came up with another alternative 
as below, as long as it does not change the message, the sentence is trying to 
convey.

"TOAST table, which is used for out-of-line storage of field values that are 
too large to keep [or, be kept] within the original table."


Best Regards,

Nawaz Ahmed
Software Development Engineer

Fujitsu Australia Software Technology Pty Ltd
14 Rodborough Road, Frenchs Forest NSW 2086, Australia
T +61 2 9452 9027
na...@fast.au.fujitsu.com
fastware.com.au





-Original Message-
From: Erik Rijkers [mailto:e...@xs4all.nl]
Sent: Tuesday, 27 November 2018 1:35 AM
To: Tom Lane 
Cc: Michael Paquier ; Vik Fearing 
; Magnus Hagander ; Ahmed, 
Nawaz ; pgsql-docs@lists.postgresql.org
Subject: Re: typo

On 2018-11-26 15:14, Tom Lane wrote:
> Michael Paquier  writes:
>> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>>> On 26/11/2018 08:03, Magnus Hagander wrote:
 Are you sure that's right? To me the original wording of that
 sentence seems to convey the message properly, and the update done
 does not?
>
>>> Yeah, I just found this on the committers list and I disagree with
>>> the change as well.
>
>> [... checking around ...]
>> Hm.  I have read the sentence and the surroundings a couple of times
>> before doing anything, and using an adverb looked clearer than the
>> adjective.  Is an adjective more appropriate than an adverb here
>> because it insists more on the fact that each row is involved?  Just
>> trying to grab the difference.
>
> I think that text is mine originally, and it was not a typo.  The
> meaning of "table rows proper", in this case, is basically "table rows
> themelves".

Maybe that is not a bad alternative
"table rows themselves"

Even if that sounds slightly less idiomatic than the original, I think it'd be 
less of a stumbling block for non-native readers.







Disclaimer

The information in this e-mail is confidential and may contain content that is 
subject to copyright and/or is commercial-in-confidence and is intended only 
for the use of the above named addressee. If you are not the intended 
recipient, you are hereby notified that dissemination, copying or use of the 
information is strictly prohibited. If you have received this e-mail in error, 
please telephone Fujitsu Australia Software Technology Pty Ltd on + 61 2 9452 
9000 or by reply e-mail to the sender and delete the document and all copies 
thereof.


Whereas Fujitsu Australia Software Technology Pty Ltd would not knowingly 
transmit a virus within an email communication, it is the receiver’s 
responsibility to scan all communication and any files attached for computer 
viruses and other defects. Fujitsu Australia Software Technology Pty Ltd does 
not accept liability for any loss or damage (whether direct, indirect, 
consequential or economic) however caused, and whether by negligence or 
otherwise, which may result directly or indirectly from this communication or 
any files attached.


If you do not wish to receive commercial and/or marketing email messages from 
Fujitsu Australia Software Technology Pty Ltd, please email 
unsubscr...@fast.au.fujitsu.com

Re: typo

[Michael Paquier]

On Mon, Nov 26, 2018 at 09:14:18AM -0500, Tom Lane wrote:
> But I can see that a lot of people might not be familiar with that usage,
> so I've got no objections to rewriting it more clearly --- any
> suggestions?

It has been suggested upthread to use "in the table rows themselves",
which does not sound bad to me.  So that would give, quoting the whole
portion:
 A table that has columns with potentially large entries will have an
  associated TOAST table, which is used for
 out-of-line storage of
 -field values that are too large to keep in the table rows properly.
 +field values that are too large to keep in the table rows themselves.
  pg_class.reltoastrelid
 links from a table to
  its TOAST table, if any.

Now I cannot really stand as somebody able to decide the right thing on
this thread, proofs present on the table ;)
--
Michael


signature.asc
Description: PGP signature

Re: missing windows info

[Bruce Momjian]

On Mon, Nov 19, 2018 at 05:40:04PM +, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/11/libpq-pgservice.html
> Description:
> 
> The default location for a user level connection service file on Windows is
> not given. The path is given for the password file on the previous page in
> the documentation.
> 
> Please add that '%APPDATA%\postgresql\.pg_service.conf' is the default
> location in https://www.postgresql.org/docs/current/libpq-pgservice.html.

Well, in the pgpass case, we have a default location, while in the
service file case, we rely on the output of 'pg_config --sysconfdir'. 
We don't specify the location of the service file on Unix-like systems
either.  Should this be changed?

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +

Re: Section 26.2.1. Planning wording

[Bruce Momjian]

On Tue, Nov 20, 2018 at 08:38:02AM +0200, Theo Kramer wrote:
> Section 26.2.1. Planning wording includes the following
> 
> "In any case the hardware architecture must be the same — shipping from, say, 
> a 32-bit to a 64-bit system will not work."
> 
> would  be more correct if it read as follows
> 
> "In any case the CPU architecture must be the same — shipping from, say, a 
> 32-bit to a 64-bit system will not work."
> 
> as “hardware architecture” would imply the difference between say Dell and 
> IBM which should be ok if the CPU is the same architecture ...

I feel we might have cases where differences beyond the CPU might
matter, though I can't think of any now.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +