[pgAdmin4][Patch] - Issue fixes reported by SonarQube

2020-06-15 Thread Khushboo Vashi
Hi,

Please find the attached patch for some of the fixes reported by SonarQube
related to :

   - Properties of variables with "null" or "undefined" values should not
   be accessed
   - Variables should not be self-assigned
   - "in" should not be used with primitive types


Thanks,
Khushboo


sonarqube_fixes.patch
Description: Binary data


[pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

2020-06-15 Thread Yogesh Mahajan
Hi Hackers,

Please find attached patch fixing behaviour on checking  select-all
checkbox from properties tab for more than 50 entities.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


RM4226_v1.patch
Description: Binary data


Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

2020-06-15 Thread Mishika Singh
Thanks Aditya for looking into this. I have done the changes noting
your suggestion to pass the maxLength param for the password field.
PFA of the patch for the same.

On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
 wrote:
>
> Hi Mishika,
>
> You've changed the defaults directly which will change the maxLength for all 
> the text boxes across pgAdmin.
> If you want to change the maxLength for the server dialog password field then 
> you can pass the maxLength param for the password field. This will affect the 
> password field only without affecting others.
>
>
> On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh  wrote:
>>
>> Hi Team,
>>
>> I have created an issue :https://redmine.postgresql.org/issues/5592.
>> In pgAdmin4 there is a restriction on the password length while trying
>> to connect to the server, the limit is 255. We have use cases where
>> the password length is more than that.
>>
>> PFA of the patch to increase the maximum length.
>>
>> --
>> Regards
>> Mishika Singh
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"



--
Regards

Mishika Singh


server_password_length.patch
Description: Binary data


pgAdmin 4 commit: Added support of Row Security Policies. Fixes #5516

2020-06-15 Thread Akshay Joshi
Added support of Row Security Policies. Fixes #5516

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18277543b6c702fa84f332c3a74840c376cd43e2
Author: Pradip Parkale 

Modified Files
--
docs/en_US/release_notes_4_23.rst  |   1 +
.../servers/databases/schemas/tables/__init__.py   |  11 +
.../tables/row_security_policies/__init__.py   | 589 +
.../static/img/coll-row_security_policy.svg|  37 ++
.../static/img/row_security_policy.svg |  22 +
.../static/js/row_security_policy.js   | 184 +++
.../tables/row_security_policies/tests/__init__.py |  16 +
.../tests/default/alter_policy.sql |  11 +
.../tests/default/alter_policy_msql.sql|   2 +
.../tests/default/create_insert_policy.sql |  11 +
.../tests/default/create_public_policy.sql |  11 +
.../tests/default/create_select_policy.sql |  11 +
.../row_security_policies/tests/default/test.json  |  86 +++
.../row_security_policies/tests/rls_test_data.json | 493 +
.../row_security_policies/tests/test_rls_add.py| 116 
.../row_security_policies/tests/test_rls_delete.py |  91 
.../tests/test_rls_delete_multiple.py  |  94 
.../row_security_policies/tests/test_rls_get.py|  98 
.../row_security_policies/tests/test_rls_put.py| 122 +
.../tables/row_security_policies/tests/utils.py| 140 +
.../schemas/tables/row_security_policies/utils.py  | 145 +
.../databases/schemas/tables/static/js/table.js|  61 ++-
.../row_security_policies/sql/9.5_plus/create.sql  |  22 +
.../row_security_policies/sql/9.5_plus/delete.sql  |   1 +
.../sql/9.5_plus/get_parent.sql|   5 +
.../sql/9.5_plus/get_policy_name.sql   |   9 +
.../sql/9.5_plus/get_position.sql  |   2 +
.../row_security_policies/sql/9.5_plus/nodes.sql   |  13 +
.../sql/9.5_plus/properties.sql|  19 +
.../row_security_policies/sql/9.5_plus/update.sql  |  33 ++
.../tables/templates/tables/sql/10_plus/create.sql |  17 +
.../templates/tables/sql/10_plus/properties.sql|   2 +-
.../tables/templates/tables/sql/11_plus/create.sql |  17 +
.../templates/tables/sql/11_plus/properties.sql|   2 +-
.../tables/templates/tables/sql/11_plus/update.sql |  24 +
.../tables/templates/tables/sql/12_plus/create.sql |  17 +
.../templates/tables/sql/12_plus/properties.sql|   2 +-
.../tables/templates/tables/sql/12_plus/update.sql |  25 +
.../templates/tables/sql/9.6_plus/create.sql   |  18 +
.../templates/tables/sql/9.6_plus/properties.sql   |   2 +-
.../templates/tables/sql/9.6_plus/update.sql   |  25 +
.../tables/templates/tables/sql/default/create.sql |  15 +
.../templates/tables/sql/default/properties.sql|   2 +-
.../tables/templates/tables/sql/default/update.sql |  24 +
.../servers/databases/schemas/tables/utils.py  |  34 ++
web/webpack.config.js  |   1 +
web/webpack.shim.js|   1 +
47 files changed, 2678 insertions(+), 6 deletions(-)



Re: [pgAdmin][RM5516]: Added support of Row Security Policies

2020-06-15 Thread Akshay Joshi
Thanks, patch applied with the following modifications:

- js file name should be "row_security_policy.js" instead of
"row_security_policies.js".
- Node name should be "row_security_policy" instead of
"row_level_policies". Node name should not be pluralized and it matches the
folder name.
- Icon name should be "coll-row_security_policy.svg" and
"row_security_policy.svg", it should matches with the Node name.
- The 'Owner' should be renamed to 'Role' and there must be a role 'public'
in the drop-down list. If the user does not provide any role then by
default it is public.
- Keywords like select, where, As should be in upper case in Jinja template.
- The policy node is disappeared when updating any value. Fixed that issue.
- There is no icon showing after creating the RLS node.


On Fri, Jun 12, 2020 at 4:45 PM Pradip Parkale <
pradip.park...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for the 'Row Level Security' feature.
> I have added RE-SQL and API test cases also.
>
> To run the RE-SQL cases -
>
>- python runtests.py --pkg resql --modules row_security_policies.
>
> To run the API cases -
>
>-  python runtests.py --pkg
>
> browser.server_groups.servers.databases.schemas.tables.row_security_policies.tests
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

2020-06-15 Thread Khushboo Vashi
Hi Yogesh,

this.data.splice is not required as you are adding the entire dataset
into collection.

Thanks,

Khushboo


On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find attached patch fixing behaviour on checking  select-all
> checkbox from properties tab for more than 50 entities.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

2020-06-15 Thread Aditya Toshniwal
Hi Mishika,

The patch looks good to me. Just out of curiosity, what is the use case
where the password is more than 1000 characters ? :O

On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh  wrote:

> Thanks Aditya for looking into this. I have done the changes noting
> your suggestion to pass the maxLength param for the password field.
> PFA of the patch for the same.
>
> On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
>  wrote:
> >
> > Hi Mishika,
> >
> > You've changed the defaults directly which will change the maxLength for
> all the text boxes across pgAdmin.
> > If you want to change the maxLength for the server dialog password field
> then you can pass the maxLength param for the password field. This will
> affect the password field only without affecting others.
> >
> >
> > On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh 
> wrote:
> >>
> >> Hi Team,
> >>
> >> I have created an issue :https://redmine.postgresql.org/issues/5592.
> >> In pgAdmin4 there is a restriction on the password length while trying
> >> to connect to the server, the limit is 255. We have use cases where
> >> the password length is more than that.
> >>
> >> PFA of the patch to increase the maximum length.
> >>
> >> --
> >> Regards
> >> Mishika Singh
> >
> >
> >
> > --
> > Thanks and Regards,
> > Aditya Toshniwal
> > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> > "Don't Complain about Heat, Plant a TREE"
>
>
>
> --
> Regards
>
> Mishika Singh
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

2020-06-15 Thread Aditya Toshniwal
Hi,

The patch looks good to me.

On Mon, Jun 15, 2020 at 11:20 AM Satish V  wrote:

> Hi Hackers,
>
> Please find the patch in the attachment which clears the sonarqube error,
> related to expressions evaluated to true/false always. Kindly review the
> patch and share the changes required
>
>
> Thanks,
> Sathish V
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Patch for SonarQube UI fixes.

2020-06-15 Thread Nikhil Mohite
Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and
few js standard syntax fixes.
PFA patch.


sonarqube_ui_fix.patch
Description: Binary data


Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

2020-06-15 Thread Mishika Singh
Hi Aditya,

I am part of Adobe Experience Platform - Query Service team. Query Service
uses the Postgres protocol to query data in Platform. We have enabled a
variety of client applications to connect to Query Service like Aqua Data
Studio, Power BI, Tableau. [
https://docs.adobe.com/content/help/en/experience-platform/query/clients/overview.html
]
Length of the password to connect to query service is more than 1000
characters.


On Mon, Jun 15, 2020 at 3:55 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Mishika,
>
> The patch looks good to me. Just out of curiosity, what is the use case
> where the password is more than 1000 characters ? :O
>
> On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh  wrote:
>
>> Thanks Aditya for looking into this. I have done the changes noting
>> your suggestion to pass the maxLength param for the password field.
>> PFA of the patch for the same.
>>
>> On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
>>  wrote:
>> >
>> > Hi Mishika,
>> >
>> > You've changed the defaults directly which will change the maxLength
>> for all the text boxes across pgAdmin.
>> > If you want to change the maxLength for the server dialog password
>> field then you can pass the maxLength param for the password field. This
>> will affect the password field only without affecting others.
>> >
>> >
>> > On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh 
>> wrote:
>> >>
>> >> Hi Team,
>> >>
>> >> I have created an issue :https://redmine.postgresql.org/issues/5592.
>> >> In pgAdmin4 there is a restriction on the password length while trying
>> >> to connect to the server, the limit is 255. We have use cases where
>> >> the password length is more than that.
>> >>
>> >> PFA of the patch to increase the maximum length.
>> >>
>> >> --
>> >> Regards
>> >> Mishika Singh
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> > "Don't Complain about Heat, Plant a TREE"
>>
>>
>>
>> --
>> Regards
>>
>> Mishika Singh
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Regards
Mishika Singh


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Aditya Toshniwal
Hi,

The patch looks good to me.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some UI related  issues of SonarQube scan.
> Mainly fixes are related to removing duplicate properties in css class and
> few js standard syntax fixes.
> PFA patch.
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


pgAdmin 4 commit: Tidy up some code to keep SonarQube happy.

2020-06-15 Thread Dave Page
Tidy up some code to keep SonarQube happy.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a23fad0ba8e16cf0adc8d6d8107b6777956fb71e
Author: Akshay Joshi 

Modified Files
--
runtime/ConfigWindow.cpp   |  8 ++--
runtime/ConfigWindow.h |  1 -
runtime/FloatingWindow.cpp | 21 +
runtime/FloatingWindow.h   |  1 -
runtime/LogWindow.cpp  | 21 +++--
runtime/LogWindow.h|  2 --
runtime/Logger.h   |  1 -
runtime/MenuActions.cpp| 18 ++
runtime/MenuActions.h  |  4 ++--
runtime/Server.cpp | 41 +
runtime/TrayIcon.cpp   | 22 --
runtime/TrayIcon.h |  1 -
12 files changed, 55 insertions(+), 86 deletions(-)



Re: [pgAdmin][patch] Runtime fixes reported by SonarQube

2020-06-15 Thread Dave Page
Thanks - committed with a minor change to sleep for 250ms in the loop
whilst we're waiting for the server thread to shut down, during which time
we process any Qt events.

On Fri, Jun 12, 2020 at 10:21 AM Akshay Joshi 
wrote:

> Hi Hackers,
>
> Attached is the patch to fix runtime issues reported by SonarQube.
> Please review it.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Khushboo Vashi
On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> The patch looks good to me.
>
I think the dashboard.js fix is not accurate as when you return something
you have to assign that value to any variable.

>
> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have fixed some UI related  issues of SonarQube scan.
>> Mainly fixes are related to removing duplicate properties in css class
>> and few js standard syntax fixes.
>> PFA patch.
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Aditya Toshniwal
Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> The patch looks good to me.
>>
> I think the dashboard.js fix is not accurate as when you return something
> you have to assign that value to any variable.
>
It's the map function which requires the return. Not necessary to assign
the return value.

>
>> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> I have fixed some UI related  issues of SonarQube scan.
>>> Mainly fixes are related to removing duplicate properties in css class
>>> and few js standard syntax fixes.
>>> PFA patch.
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


pgAdmin 4 commit: Fix 'expressions evaluated to true/false always' issu

2020-06-15 Thread Akshay Joshi
Fix 'expressions evaluated to true/false always' issue reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eb1b17b636cfd6cbf00df98dbbdbadac8976043d
Author: Satish V 

Modified Files
--
.../static/js/domain_constraints.js|  3 +-
.../databases/schemas/domains/static/js/domain.js  |  2 +-
.../foreign_tables/static/js/foreign_table.js  | 85 +++---
.../schemas/functions/static/js/function.js|  2 +-
.../schemas/functions/static/js/procedure.js   |  2 +-
.../functions/static/js/trigger_function.js|  2 +-
6 files changed, 48 insertions(+), 48 deletions(-)



pgAdmin 4 commit: Ensure that pgadmin should be able to connect to the

2020-06-15 Thread Akshay Joshi
Ensure that pgadmin should be able to connect to the server which has password 
more than 1000 characters. Fixes #5592

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38cd3327f354c2c2a850b08086a7602c85a4f48c
Author: Mishika Singh 

Modified Files
--
docs/en_US/release_notes_4_23.rst | 3 ++-
web/pgadmin/browser/server_groups/servers/static/js/server.js | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)



pgAdmin 4 commit: Some clumsy coding related fixes reported by SonarQub

2020-06-15 Thread Akshay Joshi
Some clumsy coding related fixes reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=641f7bbe9d12068560ebce47bcb82d54723247ed
Author: Aditya Toshniwal 

Modified Files
--
.../databases/languages/static/js/language.js  |  21 +--
web/pgadmin/browser/utils.py   |   6 +-
.../pg_utilities_backup_restore_test.py|   5 +-
web/pgadmin/misc/file_manager/__init__.py  |  10 +-
web/pgadmin/tools/debugger/__init__.py |  30 ++---
.../tools/debugger/utils/debugger_instance.py  |  16 +--
web/pgadmin/tools/restore/__init__.py  |  42 +++---
web/pgadmin/tools/sqleditor/__init__.py|  22 ++--
web/pgadmin/tools/sqleditor/command.py |   6 +-
web/pgadmin/utils/driver/psycopg2/__init__.py  |   7 +-
web/pgadmin/utils/driver/psycopg2/connection.py| 145 ++---
.../utils/driver/psycopg2/server_manager.py|  11 +-
web/pgadmin/utils/preferences.py   |   7 +-
web/pgadmin/utils/route.py |   9 +-
web/pgadmin/utils/session.py   |  15 +--
web/pgadmin/utils/sqlautocomplete/sqlcompletion.py |  12 +-
web/regression/runtests.py |  28 ++--
17 files changed, 184 insertions(+), 208 deletions(-)



pgAdmin 4 commit: Fix following issues reported by SonarQube:

2020-06-15 Thread Akshay Joshi
Fix following issues reported by SonarQube:
1) Properties of variables with "null" or "undefined" values should not be 
accessed
2) Variables should not be self-assigned
3) "in" should not be used with primitive types

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8ab358ccecc7e8f0e4e4c364eb162368df8b74f2
Author: Khushboo Vashi 

Modified Files
--
.../servers/databases/schemas/tables/rules/static/js/rule.js  | 4 ++--
.../server_groups/servers/databases/schemas/views/static/js/mview.js  | 2 +-
web/pgadmin/browser/server_groups/servers/static/js/variable.js   | 2 +-
web/pgadmin/browser/static/js/browser.js  | 4 ++--
web/pgadmin/browser/static/js/collection.js   | 2 +-
web/pgadmin/browser/static/js/node.js | 4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)



Re: [pgAdmin][patch] Clumsy coding related fixes

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 12:08 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> Please ignore the previous patch, attached is the updated patch.
>
> On Mon, Jun 15, 2020 at 11:50 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Few more clumsy coding related fixes.
>> Please review.
>>
>> On Fri, Jun 12, 2020 at 3:25 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Fri, Jun 12, 2020 at 11:40 AM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi Hackers,

 Attached is the patch for some clumsy coding related fixes as reported
 by SonarQube. This is the first batch, and will be sending another later.
 Please review.

 --
 Thanks and Regards,
 Aditya Toshniwal
 pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:19 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> The patch looks good to me.
>
> On Mon, Jun 15, 2020 at 11:20 AM Satish V 
> wrote:
>
>> Hi Hackers,
>>
>> Please find the patch in the attachment which clears the sonarqube error,
>> related to expressions evaluated to true/false always. Kindly review the
>> patch and share the changes required
>>
>>
>> Thanks,
>> Sathish V
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:28 PM Mishika Singh  wrote:

> Hi Aditya,
>
> I am part of Adobe Experience Platform - Query Service team. Query Service
> uses the Postgres protocol to query data in Platform. We have enabled a
> variety of client applications to connect to Query Service like Aqua Data
> Studio, Power BI, Tableau. [
> https://docs.adobe.com/content/help/en/experience-platform/query/clients/overview.html
> ]
> Length of the password to connect to query service is more than 1000
> characters.
>
>
> On Mon, Jun 15, 2020 at 3:55 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Mishika,
>>
>> The patch looks good to me. Just out of curiosity, what is the use case
>> where the password is more than 1000 characters ? :O
>>
>> On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh 
>> wrote:
>>
>>> Thanks Aditya for looking into this. I have done the changes noting
>>> your suggestion to pass the maxLength param for the password field.
>>> PFA of the patch for the same.
>>>
>>> On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal
>>>  wrote:
>>> >
>>> > Hi Mishika,
>>> >
>>> > You've changed the defaults directly which will change the maxLength
>>> for all the text boxes across pgAdmin.
>>> > If you want to change the maxLength for the server dialog password
>>> field then you can pass the maxLength param for the password field. This
>>> will affect the password field only without affecting others.
>>> >
>>> >
>>> > On Mon, Jun 8, 2020 at 12:46 AM Mishika Singh 
>>> wrote:
>>> >>
>>> >> Hi Team,
>>> >>
>>> >> I have created an issue :https://redmine.postgresql.org/issues/5592.
>>> >> In pgAdmin4 there is a restriction on the password length while trying
>>> >> to connect to the server, the limit is 255. We have use cases where
>>> >> the password length is more than that.
>>> >>
>>> >> PFA of the patch to increase the maximum length.
>>> >>
>>> >> --
>>> >> Regards
>>> >> Mishika Singh
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks and Regards,
>>> > Aditya Toshniwal
>>> > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> > "Don't Complain about Heat, Plant a TREE"
>>>
>>>
>>>
>>> --
>>> Regards
>>>
>>> Mishika Singh
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Regards
> Mishika Singh
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 2:17 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for some of the fixes reported by SonarQube
> related to :
>
>- Properties of variables with "null" or "undefined" values should not
>be accessed
>- Variables should not be self-assigned
>- "in" should not be used with primitive types
>
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


pgAdmin 4 commit: Fixed RESQL test cases, regression of RLS policy.

2020-06-15 Thread Akshay Joshi
Fixed RESQL test cases, regression of RLS policy.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a21e6448ce7afb43fc56a06cf2d1ce2dbace6729

Modified Files
--
.../tables/row_security_policies/tests/default/alter_policy.sql| 7 +++
.../row_security_policies/tests/default/alter_policy_msql.sql  | 2 +-
.../row_security_policies/tests/default/create_insert_policy.sql   | 7 +++
.../row_security_policies/tests/default/create_public_policy.sql   | 7 +++
.../row_security_policies/tests/default/create_select_policy.sql   | 7 +++
.../schemas/tables/row_security_policies/tests/default/test.json   | 2 +-
.../tables/templates/row_security_policies/sql/9.5_plus/create.sql | 1 -
7 files changed, 14 insertions(+), 19 deletions(-)



pgAdmin 4 commit: Remove duplicate properties in CSS and few js standar

2020-06-15 Thread Akshay Joshi
Remove duplicate properties in CSS and few js standard fixes reported by 
SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=023a1f222f05abb2ded1e9f8bfc38f89fd3dd4d2
Author: Nikhil Mohite 

Modified Files
--
web/pgadmin/dashboard/static/js/dashboard.js | 2 ++
web/pgadmin/misc/file_manager/static/css/file_manager.css| 1 -
web/pgadmin/misc/file_manager/static/scss/_file_manager.scss | 2 --
web/pgadmin/misc/static/explain/scss/_explain.scss   | 1 -
4 files changed, 2 insertions(+), 4 deletions(-)



Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> The patch looks good to me.
>>>
>> I think the dashboard.js fix is not accurate as when you return something
>> you have to assign that value to any variable.
>>
> It's the map function which requires the return. Not necessary to assign
> the return value.
>
>>
>>> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 I have fixed some UI related  issues of SonarQube scan.
 Mainly fixes are related to removing duplicate properties in css class
 and few js standard syntax fixes.
 PFA patch.

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


[pgAdmin4][Patch] - Issue fixes reported by SonarQube

2020-06-15 Thread Yogesh Mahajan
Hi,

Please find patching fixing issues related to shadowing variables -

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


SonarQubeFix1_v1.patch
Description: Binary data


Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

2020-06-15 Thread Yogesh Mahajan
Hi Hackers,

Please find an updated patch.

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi Yogesh,
>
> this.data.splice is not required as you are adding the entire dataset into 
> collection.
>
> Thanks,
>
> Khushboo
>
>
> On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
> yogesh.maha...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find attached patch fixing behaviour on checking  select-all
>> checkbox from properties tab for more than 50 entities.
>>
>> Thanks,
>> Yogesh Mahajan
>> QA - Team
>> EnterpriseDB Corporation
>>
>> Phone: +91-9741705709
>>
>


RM4226_v2.patch
Description: Binary data


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Khushboo Vashi
As per my earlier comment, the dashboard.js fix is still failing.

On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi 
wrote:

> Thanks, patch applied.
>
> On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi,

 The patch looks good to me.

>>> I think the dashboard.js fix is not accurate as when you return
>>> something you have to assign that value to any variable.
>>>
>> It's the map function which requires the return. Not necessary to assign
>> the return value.
>>
>>>
 On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some UI related  issues of SonarQube scan.
> Mainly fixes are related to removing duplicate properties in css class
> and few js standard syntax fixes.
> PFA patch.
>


 --
 Thanks and Regards,
 Aditya Toshniwal
 pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Aditya Toshniwal
On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> As per my earlier comment, the dashboard.js fix is still failing.
>
But assigning the return value is not a solution. Replace map with forEach
so that it doesn't expect a return value at all (as there is none).

>
> On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Thanks, patch applied.
>>
>> On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>

 On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> The patch looks good to me.
>
 I think the dashboard.js fix is not accurate as when you return
 something you have to assign that value to any variable.

>>> It's the map function which requires the return. Not necessary to assign
>>> the return value.
>>>

> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
> nikhil.moh...@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have fixed some UI related  issues of SonarQube scan.
>> Mainly fixes are related to removing duplicate properties in css
>> class and few js standard syntax fixes.
>> PFA patch.
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Khushboo Vashi
On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

>
>
> On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> As per my earlier comment, the dashboard.js fix is still failing.
>>
> But assigning the return value is not a solution. Replace map with forEach
> so that it doesn't expect a return value at all (as there is none).
>

I think this is not a problem of map but the combination, Object.keys.map
which expects return value and that is the reason I previously pointed out
that *this is not the accurate fix*.


>
>> On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi,

 On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> The patch looks good to me.
>>
> I think the dashboard.js fix is not accurate as when you return
> something you have to assign that value to any variable.
>
 It's the map function which requires the return. Not necessary to
 assign the return value.

>
>> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
>> nikhil.moh...@enterprisedb.com> wrote:
>>
>>> Hi Team,
>>>
>>> I have fixed some UI related  issues of SonarQube scan.
>>> Mainly fixes are related to removing duplicate properties in css
>>> class and few js standard syntax fixes.
>>> PFA patch.
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

 --
 Thanks and Regards,
 Aditya Toshniwal
 pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Aditya Toshniwal
On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

>
>
> On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> As per my earlier comment, the dashboard.js fix is still failing.
>>>
>> But assigning the return value is not a solution. Replace map with
>> forEach so that it doesn't expect a return value at all (as there is none).
>>
>
> I think this is not a problem of map but the combination, Object.keys.map
> which expects return value and that is the reason I previously pointed out
> that *this is not the accurate fix*.
>
That's what I said - Replace map with forEach so that it doesn't expect a
return value at all (as there is none) :)

>
>
>>
>>> On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Thanks, patch applied.

 On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
 aditya.toshni...@enterprisedb.com> wrote:

> Hi,
>
> On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> The patch looks good to me.
>>>
>> I think the dashboard.js fix is not accurate as when you return
>> something you have to assign that value to any variable.
>>
> It's the map function which requires the return. Not necessary to
> assign the return value.
>
>>
>>> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
>>> nikhil.moh...@enterprisedb.com> wrote:
>>>
 Hi Team,

 I have fixed some UI related  issues of SonarQube scan.
 Mainly fixes are related to removing duplicate properties in css
 class and few js standard syntax fixes.
 PFA patch.

>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


 --
 *Thanks & Regards*
 *Akshay Joshi*

 *Sr. Software Architect*
 *EnterpriseDB Software India Private Limited*
 *Mobile: +91 976-788-8246*

>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


Re: Patch for SonarQube UI fixes.

2020-06-15 Thread Khushboo Vashi
On Tue, Jun 16, 2020 at 9:20 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

>
>
> On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 As per my earlier comment, the dashboard.js fix is still failing.

>>> But assigning the return value is not a solution. Replace map with
>>> forEach so that it doesn't expect a return value at all (as there is none).
>>>
>>
>> I think this is not a problem of map but the combination, Object.keys.map
>> which expects return value and that is the reason I previously pointed out
>> that *this is not the accurate fix*.
>>
> That's what I said - Replace map with forEach so that it doesn't expect a
> return value at all (as there is none) :)
>
I have replied to prove that my yesterday's comment was right. :P

>
>>
>>>
 On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Thanks, patch applied.
>
> On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
>>> aditya.toshni...@enterprisedb.com> wrote:
>>>
 Hi,

 The patch looks good to me.

>>> I think the dashboard.js fix is not accurate as when you return
>>> something you have to assign that value to any variable.
>>>
>> It's the map function which requires the return. Not necessary to
>> assign the return value.
>>
>>>
 On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
 nikhil.moh...@enterprisedb.com> wrote:

> Hi Team,
>
> I have fixed some UI related  issues of SonarQube scan.
> Mainly fixes are related to removing duplicate properties in css
> class and few js standard syntax fixes.
> PFA patch.
>


 --
 Thanks and Regards,
 Aditya Toshniwal
 pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
 "Don't Complain about Heat, Plant a TREE"

>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


[pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

2020-06-15 Thread Aditya Toshniwal
Hi Hackers,

Attached patch will fix few vulnerabilities and few design suspicions where
two conditional structures are having same implementation.
Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


sonarqube.vulnerable.patch
Description: Binary data


pgAdmin 4 commit: Fixed an issue where select all checkbox only selects

2020-06-15 Thread Akshay Joshi
Fixed an issue where select all checkbox only selects the first 50 tables. 
Fixes #4226

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ae5c0ec4f8c29575bde0b18dc0f4ba1faad94bc
Author: Yogesh Mahajan 

Modified Files
--
docs/en_US/release_notes_4_23.rst   |  1 +
web/pgadmin/browser/static/js/collection.js | 11 +++
2 files changed, 12 insertions(+)



pgAdmin 4 commit: Fixed issue related to shadowing variables reported b

2020-06-15 Thread Akshay Joshi
Fixed issue related to shadowing variables reported by SonarQube.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=697f4aec95dc1f7887ab7c2a3c46d2ecfb7681be
Author: Yogesh Mahajan 

Modified Files
--
.../server_groups/servers/static/js/server.js  | 40 +++---
1 file changed, 20 insertions(+), 20 deletions(-)



pgAdmin 4 commit: Fixed vulnerabilities and few design suspicions where

2020-06-15 Thread Akshay Joshi
Fixed vulnerabilities and few design suspicions where two conditional 
structures are having the same implementation. Reported by SonarQube

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e00fe2b0fd19d3837b7ab45c25036d8c96a551f
Author: Aditya Toshniwal 

Modified Files
--
.../servers/databases/schemas/functions/__init__.py   |  5 ++---
.../servers/databases/schemas/static/js/schema.js |  7 ++-
.../schemas/tables/constraints/check_constraint/utils.py  |  5 ++---
.../tables/constraints/exclusion_constraint/__init__.py   | 11 ++-
.../schemas/tables/constraints/exclusion_constraint/utils.py  |  6 +++---
.../schemas/tables/constraints/foreign_key/__init__.py| 11 ++-
.../databases/schemas/tables/constraints/foreign_key/utils.py |  6 +++---
.../servers/databases/schemas/tables/indexes/__init__.py  |  6 ++
.../databases/schemas/tables/indexes/static/js/index.js   |  4 +---
.../servers/databases/schemas/tables/rules/static/js/rule.js  |  4 +---
web/pgadmin/static/js/backform.pgadmin.js |  2 +-
web/regression/python_test_utils/template_helper.py   |  3 ++-
12 files changed, 23 insertions(+), 47 deletions(-)



Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 6:43 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi,
>
> Please find patching fixing issues related to shadowing variables -
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Tue, Jun 16, 2020 at 10:01 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch will fix few vulnerabilities and few design suspicions
> where
> two conditional structures are having same implementation.
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

2020-06-15 Thread Akshay Joshi
Thanks, patch applied.

On Mon, Jun 15, 2020 at 6:58 PM Yogesh Mahajan <
yogesh.maha...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find an updated patch.
>
> Thanks,
> Yogesh Mahajan
> QA - Team
> EnterpriseDB Corporation
>
> Phone: +91-9741705709
>
>
> On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Yogesh,
>>
>> this.data.splice is not required as you are adding the entire dataset into 
>> collection.
>>
>> Thanks,
>>
>> Khushboo
>>
>>
>> On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan <
>> yogesh.maha...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find attached patch fixing behaviour on checking  select-all
>>> checkbox from properties tab for more than 50 entities.
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> QA - Team
>>> EnterpriseDB Corporation
>>>
>>> Phone: +91-9741705709
>>>
>>

-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*