Re: RM5576: Improve error messaging if the storage and log directories cannot be created
Hi Dave I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module is not available on windows hence Jenkins build is failing. Attached is the patch to fix for Windows OS. I have used the "*getpass*" module for Windows. Please review it. If looks good I'll commit the code. On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: > >> Patch for $SUBJECT attached. Sample output: >> >> python web/pgAdmin4.py >> ERROR : Failed to create the directory /var/lib/pgadmin: >>[Errno 13] Permission denied: '/var/lib/pgadmin' >> HINT : Create the directory /var/lib/pgadmin, ensure it is writeable by >> 'dpage', and try again, or, create a config_local.py file >> and override the SQLITE_PATH setting per >> https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_5576_v2.patch Description: Binary data
Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
Hi Kushboo, All the menus for all the deleted nodes were handled except Maintenance, backup /restore, import/export. Scripts,Refers View,View/Edit data and Create- child nodes for any parent node which is deleted are handled. Refresh, Delete/drop,drop cascade and properties were already handled for all the nodes. So i didn't make changes to them as they are displaying proper error messages already and I checked it for all the nodes. Thanks Sathish V On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Satish, > > On Mon, Jun 1, 2020 at 2:16 PM Satish V wrote: > >> Hi Hackers, >> >> Attached is the patch which alerts the users when they try to consume the >> options in the context menu of the deleted node. >> > Can you please specify the context menu options which you handled, so it > will be easy for me to review. > > Thanks, > Khushboo > >> -fixed the opening of an empty query tool window for non existing >> nodes.(create/delete/update..) >> - handles the error like "list index out of range" with a reasonable >> error dialog or alert. >> >> Kindly review the patch and let me know of the changes required. >> >> >> Thanks, >> Sathish V >> >
Re: RM5576: Improve error messaging if the storage and log directories cannot be created
Hi Urgh, didn't realise pwd wasn't available on Windows :-(. What about just using getpass.getuser() everywhere? According to the docs it falls back to using pwd where that's supported anyway: https://docs.python.org/3.8/library/getpass.html On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi wrote: > Hi Dave > > I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module > is not available on windows hence Jenkins build is failing. > Attached is the patch to fix for Windows OS. I have used the "*getpass*" > module for Windows. > > Please review it. If looks good I'll commit the code. > > On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: >> >>> Patch for $SUBJECT attached. Sample output: >>> >>> python web/pgAdmin4.py >>> ERROR : Failed to create the directory /var/lib/pgadmin: >>>[Errno 13] Permission denied: '/var/lib/pgadmin' >>> HINT : Create the directory /var/lib/pgadmin, ensure it is writeable by >>> 'dpage', and try again, or, create a config_local.py file >>> and override the SQLITE_PATH setting per >>> https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: RM5576: Improve error messaging if the storage and log directories cannot be created
Hi Dave On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > Hi > > Urgh, didn't realise pwd wasn't available on Windows :-(. What about just > using getpass.getuser() everywhere? According to the docs it falls back to > using pwd where that's supported anyway: > https://docs.python.org/3.8/library/getpass.html > Sure we can use the getpass.getuser() everywhere. > > On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi > wrote: > >> Hi Dave >> >> I have tested the logic on Mac OSX but not on Windows. The "*pwd*" >> module is not available on windows hence Jenkins build is failing. >> Attached is the patch to fix for Windows OS. I have used the "*getpass*" >> module for Windows. >> >> Please review it. If looks good I'll commit the code. >> >> On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: >>> Patch for $SUBJECT attached. Sample output: python web/pgAdmin4.py ERROR : Failed to create the directory /var/lib/pgadmin: [Errno 13] Permission denied: '/var/lib/pgadmin' HINT : Create the directory /var/lib/pgadmin, ensure it is writeable by 'dpage', and try again, or, create a config_local.py file and override the SQLITE_PATH setting per https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: RM5576: Improve error messaging if the storage and log directories cannot be created
On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi wrote: > Hi Dave > > On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: > >> Hi >> >> Urgh, didn't realise pwd wasn't available on Windows :-(. What about just >> using getpass.getuser() everywhere? According to the docs it falls back to >> using pwd where that's supported anyway: >> https://docs.python.org/3.8/library/getpass.html >> > >Sure we can use the getpass.getuser() everywhere. > Are you working on that, or do you want me to update it and commit? > >> On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> I have tested the logic on Mac OSX but not on Windows. The "*pwd*" >>> module is not available on windows hence Jenkins build is failing. >>> Attached is the patch to fix for Windows OS. I have used the "*getpass*" >>> module for Windows. >>> >>> Please review it. If looks good I'll commit the code. >>> >>> On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Thanks, patch applied. On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: > Patch for $SUBJECT attached. Sample output: > > python web/pgAdmin4.py > ERROR : Failed to create the directory /var/lib/pgadmin: >[Errno 13] Permission denied: '/var/lib/pgadmin' > HINT : Create the directory /var/lib/pgadmin, ensure it is writeable > by > 'dpage', and try again, or, create a config_local.py file > and override the SQLITE_PATH setting per > https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: RM5576: Improve error messaging if the storage and log directories cannot be created
I'll change and commit the code. On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > > > On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi > wrote: > >> Hi Dave >> >> On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: >> >>> Hi >>> >>> Urgh, didn't realise pwd wasn't available on Windows :-(. What about >>> just using getpass.getuser() everywhere? According to the docs it falls >>> back to using pwd where that's supported anyway: >>> https://docs.python.org/3.8/library/getpass.html >>> >> >>Sure we can use the getpass.getuser() everywhere. >> > > Are you working on that, or do you want me to update it and commit? > > > >> >>> On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Dave I have tested the logic on Mac OSX but not on Windows. The "*pwd*" module is not available on windows hence Jenkins build is failing. Attached is the patch to fix for Windows OS. I have used the "*getpass*" module for Windows. Please review it. If looks good I'll commit the code. On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Thanks, patch applied. > > On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: > >> Patch for $SUBJECT attached. Sample output: >> >> python web/pgAdmin4.py >> ERROR : Failed to create the directory /var/lib/pgadmin: >>[Errno 13] Permission denied: '/var/lib/pgadmin' >> HINT : Create the directory /var/lib/pgadmin, ensure it is >> writeable by >> 'dpage', and try again, or, create a config_local.py file >> and override the SQLITE_PATH setting per >> https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
Re: RM5576: Improve error messaging if the storage and log directories cannot be created
Thanks. On Tue, Jun 2, 2020 at 9:27 AM Akshay Joshi wrote: > I'll change and commit the code. > > On Tue, Jun 2, 2020 at 1:55 PM Dave Page wrote: > >> >> >> On Tue, Jun 2, 2020 at 9:20 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On Tue, Jun 2, 2020 at 1:41 PM Dave Page wrote: >>> Hi Urgh, didn't realise pwd wasn't available on Windows :-(. What about just using getpass.getuser() everywhere? According to the docs it falls back to using pwd where that's supported anyway: https://docs.python.org/3.8/library/getpass.html >>> >>>Sure we can use the getpass.getuser() everywhere. >>> >> >> Are you working on that, or do you want me to update it and commit? >> >> >> >>> On Tue, Jun 2, 2020 at 8:00 AM Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > I have tested the logic on Mac OSX but not on Windows. The "*pwd*" > module is not available on windows hence Jenkins build is failing. > Attached is the patch to fix for Windows OS. I have used the " > *getpass*" module for Windows. > > Please review it. If looks good I'll commit the code. > > On Tue, Jun 2, 2020 at 11:12 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: >> >>> Patch for $SUBJECT attached. Sample output: >>> >>> python web/pgAdmin4.py >>> ERROR : Failed to create the directory /var/lib/pgadmin: >>>[Errno 13] Permission denied: '/var/lib/pgadmin' >>> HINT : Create the directory /var/lib/pgadmin, ensure it is >>> writeable by >>> 'dpage', and try again, or, create a config_local.py file >>> and override the SQLITE_PATH setting per >>> https://www.pgadmin.org/docs/pgadmin4/4.22/config_py.html >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
pgAdmin 4 commit: The 'pwd' module is not available on Windows, so repl
The 'pwd' module is not available on Windows, so replacing it with the 'getpass' module. refs #5576 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a1a232a1f19b003ed261aad8bcd5235d160d6b62 Modified Files -- web/pgadmin/setup/data_directory.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)
Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
Hi Satish, - On failure, you have added a new condition if (e.status == 410) at some places, this is not necessary as we have generalised code for that. - Please maintain the consistency in messages, you can check the GONE message template, we do have them at some places. (Example: on Database expansion ) - Please follow basic JS coding standards. Ex: A space is required after/before any operator. I have seen 1 or 2 places where a space is missing in your patch. Thanks, Khushboo On Tue, Jun 2, 2020 at 12:45 PM Satish V wrote: > Hi Kushboo, > > All the menus for all the deleted nodes were handled except Maintenance, > backup /restore, import/export. > > Scripts,Refers View,View/Edit data and Create- child nodes for any parent > node which is deleted are handled. > Refresh, Delete/drop,drop cascade and properties were already handled for > all the nodes. So i didn't make changes to them as they are displaying > proper error messages already and I checked it for all the nodes. > > > Thanks > Sathish V > > On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Satish, >> >> On Mon, Jun 1, 2020 at 2:16 PM Satish V >> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch which alerts the users when they try to consume >>> the options in the context menu of the deleted node. >>> >> Can you please specify the context menu options which you handled, so it >> will be easy for me to review. >> >> Thanks, >> Khushboo >> >>> -fixed the opening of an empty query tool window for non existing >>> nodes.(create/delete/update..) >>> - handles the error like "list index out of range" with a reasonable >>> error dialog or alert. >>> >>> Kindly review the patch and let me know of the changes required. >>> >>> >>> Thanks, >>> Sathish V >>> >>
pgAdmin 4 commit: Include postgresql-libs in our Yum repos.
Include postgresql-libs in our Yum repos. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e67a0b0e7624dd638253fbfcb74acf2d6504035 Modified Files -- pkg/redhat/build.sh | 11 +-- pkg/redhat/setup.sh | 19 +++ 2 files changed, 20 insertions(+), 10 deletions(-)
pgAdmin 4 commit: We need yum-utils. Fix the rpmmacros message whilst p
We need yum-utils. Fix the rpmmacros message whilst passing. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2549085872c435bc08e1f00a68e0893f779e6ca1 Modified Files -- pkg/redhat/setup.sh | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-)
pgAdmin 4 commit: Include the PostgreSQL repo so we get the latest libp
Include the PostgreSQL repo so we get the latest libpq Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f58552f60235cf79a8c63f9c10bc4a29377ddfa Modified Files -- pkg/debian/setup.sh | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Quieten pushd/popd
Quieten pushd/popd Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=445abf1e3152277901879b739e0ddcd131bee0c1 Modified Files -- pkg/linux/build-functions.sh | 4 ++-- pkg/src/build.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
pgAdmin 4 commit: Include the libpq5 deb in the Debian/Ubuntu repos.
Include the libpq5 deb in the Debian/Ubuntu repos. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d0319dba7ef91561c508cb480dd5fbe9297c0cf Modified Files -- pkg/debian/build.sh | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)
pgAdmin 4 commit: Fix message.
Fix message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a0efc0e869b3a06499154676bdbd76f47b75fce Modified Files -- pkg/redhat/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
Hi Khushboo, The Reason for checking status==410 is to show error dialog to the user which will not go unnoticed at any situation. For closing the empty query tool we need this error dialog pop which shows the error message and closes the empty query tool for deleted nodes upon clicking ok. Changes inside the "alertify.pgadmin.defaults.js file" is made to avoid repeating the same patch which calls pgBrowser.report_error(which is used to show the error dialog message), in multiple places . Changes inside database.js file are made to make sure that the error message has the proper title, which was missing previously for the "connect database" context menu. -fixed the issues related to spacing between the operators. Please find the updated patch in the attached file. Thanks, Sathish V On Tue, Jun 2, 2020 at 2:40 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Satish, > > - On failure, you have added a new condition if (e.status == 410) at some > places, this is not necessary as we have generalised code for that. > - Please maintain the consistency in messages, you can check the GONE > message template, we do have them at some places. (Example: on Database > expansion ) > - Please follow basic JS coding standards. Ex: A space is required > after/before any operator. I have seen 1 or 2 places where a space is > missing in your patch. > > Thanks, > Khushboo > > On Tue, Jun 2, 2020 at 12:45 PM Satish V > wrote: > >> Hi Kushboo, >> >> All the menus for all the deleted nodes were handled except Maintenance, >> backup /restore, import/export. >> >> Scripts,Refers View,View/Edit data and Create- child nodes for any parent >> node which is deleted are handled. >> Refresh, Delete/drop,drop cascade and properties were already handled for >> all the nodes. So i didn't make changes to them as they are displaying >> proper error messages already and I checked it for all the nodes. >> >> >> Thanks >> Sathish V >> >> On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Satish, >>> >>> On Mon, Jun 1, 2020 at 2:16 PM Satish V >>> wrote: >>> Hi Hackers, Attached is the patch which alerts the users when they try to consume the options in the context menu of the deleted node. >>> Can you please specify the context menu options which you handled, so it >>> will be easy for me to review. >>> >>> Thanks, >>> Khushboo >>> -fixed the opening of an empty query tool window for non existing nodes.(create/delete/update..) - handles the error like "list index out of range" with a reasonable error dialog or alert. Kindly review the patch and let me know of the changes required. Thanks, Sathish V >>> Rm3669s2.patch Description: Binary data
Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
The patch looks good to me. On Tue, Jun 2, 2020 at 6:36 PM Satish V wrote: > Hi Khushboo, > > The Reason for checking status==410 is to show error dialog to the user > which will not go unnoticed at any situation. For closing the empty query > tool we need this error dialog pop which shows the error message and closes > the empty query tool for deleted nodes upon clicking ok. > > Changes inside the "alertify.pgadmin.defaults.js file" is made to avoid > repeating the same patch which calls pgBrowser.report_error(which is used > to show the error dialog message), in multiple places . > > Changes inside database.js file are made to make sure that the error > message has the proper title, which was missing previously for the "connect > database" context menu. > > -fixed the issues related to spacing between the operators. > > Please find the updated patch in the attached file. > > Thanks, > Sathish V > > On Tue, Jun 2, 2020 at 2:40 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Satish, >> >> - On failure, you have added a new condition if (e.status == 410) at >> some places, this is not necessary as we have generalised code for that. >> - Please maintain the consistency in messages, you can check the GONE >> message template, we do have them at some places. (Example: on Database >> expansion ) >> - Please follow basic JS coding standards. Ex: A space is required >> after/before any operator. I have seen 1 or 2 places where a space is >> missing in your patch. >> >> Thanks, >> Khushboo >> >> On Tue, Jun 2, 2020 at 12:45 PM Satish V >> wrote: >> >>> Hi Kushboo, >>> >>> All the menus for all the deleted nodes were handled except Maintenance, >>> backup /restore, import/export. >>> >>> Scripts,Refers View,View/Edit data and Create- child nodes for any >>> parent node which is deleted are handled. >>> Refresh, Delete/drop,drop cascade and properties were already handled >>> for all the nodes. So i didn't make changes to them as they are displaying >>> proper error messages already and I checked it for all the nodes. >>> >>> >>> Thanks >>> Sathish V >>> >>> On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Satish, On Mon, Jun 1, 2020 at 2:16 PM Satish V wrote: > Hi Hackers, > > Attached is the patch which alerts the users when they try to consume > the options in the context menu of the deleted node. > Can you please specify the context menu options which you handled, so it will be easy for me to review. Thanks, Khushboo > -fixed the opening of an empty query tool window for non existing > nodes.(create/delete/update..) > - handles the error like "list index out of range" with a reasonable > error dialog or alert. > > Kindly review the patch and let me know of the changes required. > > > Thanks, > Sathish V >
pgAdmin 4 commit: Ensure that proper error should be displayed for the
Ensure that proper error should be displayed for the deleted node. Fixes #3669 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d22e27658671dac11d91e4ce7ecf72a4ea167e39 Author: Satish V Modified Files -- docs/en_US/release_notes_4_23.rst | 1 + .../foreign_servers/__init__.py| 5 +- .../foreign_servers/user_mappings/__init__.py | 3 + .../schemas/domains/domain_constraints/__init__.py | 8 +++ .../databases/schemas/foreign_tables/__init__.py | 23 +++- .../databases/schemas/functions/__init__.py| 2 + .../servers/databases/schemas/tables/__init__.py | 23 .../databases/schemas/tables/columns/__init__.py | 3 +- .../constraints/check_constraint/__init__.py | 4 ++ .../databases/schemas/tables/indexes/__init__.py | 2 + .../databases/schemas/tables/triggers/__init__.py | 2 + .../servers/databases/schemas/tables/utils.py | 18 +- .../servers/databases/static/js/database.js| 3 + .../server_groups/servers/roles/__init__.py| 2 +- web/pgadmin/browser/static/js/error.js | 11 +++- web/pgadmin/browser/static/js/node.js | 2 +- web/pgadmin/browser/static/js/toolbar.js | 1 + web/pgadmin/static/js/alertify.pgadmin.defaults.js | 67 -- web/pgadmin/tools/datagrid/__init__.py | 5 ++ web/pgadmin/tools/datagrid/static/js/show_data.js | 14 +++-- web/pgadmin/tools/debugger/__init__.py | 5 +- web/pgadmin/tools/sqleditor/command.py | 4 ++ web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 27 ++--- .../utils/driver/psycopg2/server_manager.py| 3 +- 24 files changed, 186 insertions(+), 52 deletions(-)
Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present
Thanks, patch applied. On Tue, Jun 2, 2020 at 6:36 PM Satish V wrote: > Hi Khushboo, > > The Reason for checking status==410 is to show error dialog to the user > which will not go unnoticed at any situation. For closing the empty query > tool we need this error dialog pop which shows the error message and closes > the empty query tool for deleted nodes upon clicking ok. > > Changes inside the "alertify.pgadmin.defaults.js file" is made to avoid > repeating the same patch which calls pgBrowser.report_error(which is used > to show the error dialog message), in multiple places . > > Changes inside database.js file are made to make sure that the error > message has the proper title, which was missing previously for the "connect > database" context menu. > > -fixed the issues related to spacing between the operators. > > Please find the updated patch in the attached file. > > Thanks, > Sathish V > > On Tue, Jun 2, 2020 at 2:40 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Satish, >> >> - On failure, you have added a new condition if (e.status == 410) at >> some places, this is not necessary as we have generalised code for that. >> - Please maintain the consistency in messages, you can check the GONE >> message template, we do have them at some places. (Example: on Database >> expansion ) >> - Please follow basic JS coding standards. Ex: A space is required >> after/before any operator. I have seen 1 or 2 places where a space is >> missing in your patch. >> >> Thanks, >> Khushboo >> >> On Tue, Jun 2, 2020 at 12:45 PM Satish V >> wrote: >> >>> Hi Kushboo, >>> >>> All the menus for all the deleted nodes were handled except Maintenance, >>> backup /restore, import/export. >>> >>> Scripts,Refers View,View/Edit data and Create- child nodes for any >>> parent node which is deleted are handled. >>> Refresh, Delete/drop,drop cascade and properties were already handled >>> for all the nodes. So i didn't make changes to them as they are displaying >>> proper error messages already and I checked it for all the nodes. >>> >>> >>> Thanks >>> Sathish V >>> >>> On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> Hi Satish, On Mon, Jun 1, 2020 at 2:16 PM Satish V wrote: > Hi Hackers, > > Attached is the patch which alerts the users when they try to consume > the options in the context menu of the deleted node. > Can you please specify the context menu options which you handled, so it will be easy for me to review. Thanks, Khushboo > -fixed the opening of an empty query tool window for non existing > nodes.(create/delete/update..) > - handles the error like "list index out of range" with a reasonable > error dialog or alert. > > Kindly review the patch and let me know of the changes required. > > > Thanks, > Sathish V > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
