Hi Satish, - On failure, you have added a new condition if (e.status == 410) at some places, this is not necessary as we have generalised code for that. - Please maintain the consistency in messages, you can check the GONE message template, we do have them at some places. (Example: on Database expansion ) - Please follow basic JS coding standards. Ex: A space is required after/before any operator. I have seen 1 or 2 places where a space is missing in your patch.
Thanks, Khushboo On Tue, Jun 2, 2020 at 12:45 PM Satish V <satis...@enterprisedb.com> wrote: > Hi Kushboo, > > All the menus for all the deleted nodes were handled except Maintenance, > backup /restore, import/export. > > Scripts,Refers View,View/Edit data and Create- child nodes for any parent > node which is deleted are handled. > Refresh, Delete/drop,drop cascade and properties were already handled for > all the nodes. So i didn't make changes to them as they are displaying > proper error messages already and I checked it for all the nodes. > > > Thanks > Sathish V > > On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Satish, >> >> On Mon, Jun 1, 2020 at 2:16 PM Satish V <satis...@enterprisedb.com> >> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch which alerts the users when they try to consume >>> the options in the context menu of the deleted node. >>> >> Can you please specify the context menu options which you handled, so it >> will be easy for me to review. >> >> Thanks, >> Khushboo >> >>> -fixed the opening of an empty query tool window for non existing >>> nodes.(create/delete/update..) >>> - handles the error like "list index out of range" with a reasonable >>> error dialog or alert. >>> >>> Kindly review the patch and let me know of the changes required. >>> >>> >>> Thanks, >>> Sathish V >>> >>
