Re: Want to contribute as a developer

[Vijender Thakur]

Hi Aditya,
Thanks for the informations.

> On 23-Mar-2020, at 10:42 AM, Aditya Toshniwal 
>  wrote:
> 
> Hi Vijender,
> 
> 
> 
> On Mon, Mar 23, 2020 at 5:00 AM Vijender Thakur  > wrote:
> Hi, 
> I want to contribute to the pgadmin4 project as a developer. I am a full 
> stack software engineer having around 4 year of experience. I don’t know 
> where to start. Can you share some path regarding contributing to this 
> project.
> Please visit - https://www.pgadmin.org/development/ 
> 
> pgAdmin uses https://redmine.postgresql.org/projects/pgadmin4 
>  for bug/feature tracking.
> You can start by cloning https://github.com/postgres/pgadmin4 
>  and try to understand the code. The 
> steps to build the project is given in the README.
>  
> 
> Thanks & Regards
> Vijender Kumar
> 
> 
> 
> -- 
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"

Re: pgAdmin 4 - gettext usage fixes

[Akshay Joshi]

Hi Aditya

Can you please review this?

On Mon, Mar 23, 2020 at 5:00 AM Libor M.  wrote:

> Hello,
> I fixed using gettext function and add more usages for translations,
> specifically:
>
> - fixed usage gettext('') instead of _('') in javascript files
> - fixed usage gettext('') instead of `${gettext('')}` in javascript
> files, because "pybabel extract" not support extracting from this
> syntax
> - added a lot of gettext for support translations
>
> Diff file is attached.
>
> Best regards,
>
> Libor M.
>
> E-mail: libor...@gmail.com
> GitHub: https://github.com/liborm85
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

[pgAdmin][RM5128] [Accessibility] Revisit color contrast to meet the standards

[Aditya Toshniwal]

Hi Hackers,

Attached is a small patch to change certain colors and opacity in pgAdmin
in order to comply with WCAG color contrast standards.

Please review.

-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM5128.patch
Description: Binary data

pgAdmin 4 commit: Change some colors and opacity to comply with WCAG co

[Akshay Joshi]

Change some colors and opacity to comply with WCAG color contrast standards. 
Fixes #5128

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6988ce96d7a32eaa64c05e1bb2424426f68b9b2e
Author: Aditya Toshniwal 

Modified Files
--
docs/en_US/release_notes_4_20.rst| 1 +
web/pgadmin/static/scss/resources/_default.variables.scss| 8 
web/pgadmin/static/scss/resources/dark/_theme.variables.scss | 6 +++---
3 files changed, 8 insertions(+), 7 deletions(-)

Re: [pgAdmin][RM5128] [Accessibility] Revisit color contrast to meet the standards

[Akshay Joshi]

Thanks, patch applied.

On Mon, Mar 23, 2020 at 5:46 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is a small patch to change certain colors and opacity in pgAdmin
> in order to comply with WCAG color contrast standards.
>
> Please review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

Re: pgAdmin 4 - gettext usage fixes

[Aditya Toshniwal]

Hi Libor,

Thank you for the patch. It is good clean up patch.
I've made a few changes in the patch. You've imported sprintf which was not
required since gettext also works as sprintf directly.
I've also created a housekeeping redmine ticket to track it -
https://redmine.postgresql.org/issues/5284

The messages compile fine. The patch can be committed.
Please find the attached updated patch.



On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi 
wrote:

> Hi Aditya
>
> Can you please review this?
>
> On Mon, Mar 23, 2020 at 5:00 AM Libor M.  wrote:
>
>> Hello,
>> I fixed using gettext function and add more usages for translations,
>> specifically:
>>
>> - fixed usage gettext('') instead of _('') in javascript files
>> - fixed usage gettext('') instead of `${gettext('')}` in javascript
>> files, because "pybabel extract" not support extracting from this
>> syntax
>> - added a lot of gettext for support translations
>>
>> Diff file is attached.
>>
>> Best regards,
>>
>> Libor M.
>>
>> E-mail: libor...@gmail.com
>> GitHub: https://github.com/liborm85
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM5284.patch
Description: Binary data

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

[Khushboo Vashi]

Hi,

Please find the attached updated patch.


On Tue, Mar 17, 2020 at 4:11 PM Dave Page  wrote:

> Hi
>
> On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Thanks for the review.
>>
>> On Tue, Mar 17, 2020 at 3:42 PM Dave Page  wrote:
>>
>>> Hi
>>>
>>> 30 second read of the first version of the patch...
>>>
>>> - Please move the configuration into config.py. Users should never have
>>> to modify a distributed file (it messes up packaging). I don't see any
>>> reason to use a different file just for auth config.
>>>
>>> There are many settings for the LDAP, and in the future we will add
>> other external sources also, so I thought it would be better if we have
>> different file for the authentication.
>>
>
> Sure, but our config file is small compared to many. Splitting things out
> is more confusing for users. If they want to do that themselves of course,
> they can add a config_local.py file which includes other files as needed.
>
Fixed.

>
>
>> - I think all config options should be prefixed with LDAP_ as we may have
>>> things like CERT_FILE for other purposes too.
>>>
>>> Sure.
>>
> Done.

> - I don't see any test cases.
>>>
>>> I will think about this, as right now no idea how to write test cases
>> for this.
>>
>
> It should be fairly straightforward to write tests for some of the
> functions in the auth classes. For testing the actual LDAP stuff, we
> probably need to add LDAP config options to test_config.json, and only if
> present, run the tests. That would probably need to support a list of LDAP
> servers, so we can test with different configurations (LDAP, LDAPS,
> LDAP_STARTTLS, AD etc).
>
>
Done.

Thanks,
Khushboo

> Thanks.
>>>
>>> Thanks,
>> Khushboo
>>
>>>
>>> On Tue, Mar 17, 2020 at 8:55 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find the attached patch to support LDAP Authentication in Server
 mode.
 To test the patch, config_auth.py needs to be configured for LDAP
 configurations. The config settings are explained in this file in detail.
 After configuring the parameters, start the pgadmin server in Server mode
 and connect with LDAP server with the valid user via login page.

 I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
 have used the default config of ldap3 without certificates.

 @Dave, can you please review this patch, as you have a better
 understanding of LDAP and you can easily pointed out if I have missed
 anything.

 Note: For the document update I will create the task and assign to
 Nidhi for the same.

 Thanks,
 Khushboo

>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_2186_v1.patch
Description: Binary data

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

[Khushboo Vashi]

Please disregard my previous patch, attached the updated patch.

On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached updated patch.
>
>
> On Tue, Mar 17, 2020 at 4:11 PM Dave Page  wrote:
>
>> Hi
>>
>> On Tue, Mar 17, 2020 at 10:24 AM Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Thanks for the review.
>>>
>>> On Tue, Mar 17, 2020 at 3:42 PM Dave Page  wrote:
>>>
 Hi

 30 second read of the first version of the patch...

 - Please move the configuration into config.py. Users should never have
 to modify a distributed file (it messes up packaging). I don't see any
 reason to use a different file just for auth config.

 There are many settings for the LDAP, and in the future we will add
>>> other external sources also, so I thought it would be better if we have
>>> different file for the authentication.
>>>
>>
>> Sure, but our config file is small compared to many. Splitting things out
>> is more confusing for users. If they want to do that themselves of course,
>> they can add a config_local.py file which includes other files as needed.
>>
> Fixed.
>
>>
>>
>>> - I think all config options should be prefixed with LDAP_ as we may
 have things like CERT_FILE for other purposes too.

 Sure.
>>>
>> Done.
>
>> - I don't see any test cases.

 I will think about this, as right now no idea how to write test cases
>>> for this.
>>>
>>
>> It should be fairly straightforward to write tests for some of the
>> functions in the auth classes. For testing the actual LDAP stuff, we
>> probably need to add LDAP config options to test_config.json, and only if
>> present, run the tests. That would probably need to support a list of LDAP
>> servers, so we can test with different configurations (LDAP, LDAPS,
>> LDAP_STARTTLS, AD etc).
>>
>>
> Done.
>
> Thanks,
> Khushboo
>
>> Thanks.

 Thanks,
>>> Khushboo
>>>

 On Tue, Mar 17, 2020 at 8:55 AM Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to support LDAP Authentication in
> Server mode.
> To test the patch, config_auth.py needs to be configured for LDAP
> configurations. The config settings are explained in this file in detail.
> After configuring the parameters, start the pgadmin server in Server mode
> and connect with LDAP server with the valid user via login page.
>
> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
> have used the default config of ldap3 without certificates.
>
> @Dave, can you please review this patch, as you have a better
> understanding of LDAP and you can easily pointed out if I have missed
> anything.
>
> Note: For the document update I will create the task and assign to
> Nidhi for the same.
>
> Thanks,
> Khushboo
>


 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>


RM_2186_v1.patch
Description: Binary data

Re: pgAdmin 4 - gettext usage fixes

[Aditya Toshniwal]

Hi Hackers,

Please find the updated patch with pep8, linter issues fixed.


On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Libor,
>
> Thank you for the patch. It is good clean up patch.
> I've made a few changes in the patch. You've imported sprintf which was
> not required since gettext also works as sprintf directly.
> I've also created a housekeeping redmine ticket to track it -
> https://redmine.postgresql.org/issues/5284
>
> The messages compile fine. The patch can be committed.
> Please find the attached updated patch.
>
>
>
> On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Aditya
>>
>> Can you please review this?
>>
>> On Mon, Mar 23, 2020 at 5:00 AM Libor M.  wrote:
>>
>>> Hello,
>>> I fixed using gettext function and add more usages for translations,
>>> specifically:
>>>
>>> - fixed usage gettext('') instead of _('') in javascript files
>>> - fixed usage gettext('') instead of `${gettext('')}` in javascript
>>> files, because "pybabel extract" not support extracting from this
>>> syntax
>>> - added a lot of gettext for support translations
>>>
>>> Diff file is attached.
>>>
>>> Best regards,
>>>
>>> Libor M.
>>>
>>> E-mail: libor...@gmail.com
>>> GitHub: https://github.com/liborm85
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


RM5284_v2.patch
Description: Binary data

pgAdmin 4 commit: Added and fixed gettext usage for better translation

[Akshay Joshi]

Added and fixed gettext usage for better translation coverage. Fixes #5284
  1) Fixed usage gettext('') instead of _('') in javascript files.
  2) Fixed usage gettext('') instead of `${gettext('')}` in javascript files,
 because "pybabel extract" not support extracting from this syntax.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94864104e44a50fd4d3c5278c2c39c1bd1d93a88
Author: Libor M 

Modified Files
--
docs/en_US/release_notes_4_20.rst  |  1 +
.../browser/server_groups/servers/__init__.py  |  9 +
.../servers/databases/casts/__init__.py|  2 +-
.../event_triggers/static/js/event_trigger.js  | 14 +++---
.../databases/external_tables/properties.py| 16 
.../static/js/exclusion_constraint.js  |  2 +-
.../foreign_key/static/js/foreign_key.js   |  2 +-
.../tables/partitions/static/js/partition.js   |  4 ++--
.../databases/schemas/tables/static/js/table.js|  8 
.../server_groups/servers/static/js/variable.js|  2 +-
.../servers/templates/servers/password.html|  2 +-
.../servers/templates/servers/tunnel_password.html |  2 +-
web/pgadmin/browser/static/js/collection.js|  2 +-
web/pgadmin/browser/static/js/node.js  |  2 +-
web/pgadmin/browser/static/js/node.ui.js   | 12 ++--
.../browser/templates/browser/master_password.html |  2 +-
web/pgadmin/dashboard/static/js/dashboard.js   |  2 +-
.../templates/dashboard/server_dashboard.html  |  2 +-
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  8 
.../misc/dependencies/static/js/dependencies.js|  2 +-
.../misc/dependents/static/js/dependents.js|  2 +-
web/pgadmin/misc/file_manager/static/js/utility.js |  8 
.../misc/statistics/static/js/statistics.js|  2 +-
web/pgadmin/static/js/backform.pgadmin.js  |  8 
web/pgadmin/static/js/backgrid.pgadmin.js  |  6 +++---
web/pgadmin/static/js/keyboard_shortcuts.js|  2 +-
.../js/sqleditor/calculate_query_run_time.js   |  9 +
web/pgadmin/static/js/sqleditor/filter_dialog.js   |  2 +-
.../static/js/sqleditor/history/query_history.js   |  6 +++---
.../js/sqleditor/history/query_history_details.js  | 22 +++---
.../js/sqleditor/history/query_history_entries.js  |  4 ++--
.../js/sqleditor/query_tool_notifications.js   |  2 +-
.../backup/static/js/backup_dialog_wrapper.js  |  2 +-
web/pgadmin/tools/debugger/static/js/direct.js |  8 
.../tools/grant_wizard/static/js/grant_wizard.js   | 22 +++---
web/pgadmin/tools/maintenance/__init__.py  |  2 +-
web/pgadmin/tools/schema_diff/__init__.py  | 11 ++-
web/pgadmin/tools/schema_diff/compare.py   |  3 ++-
web/pgadmin/tools/schema_diff/model.py |  4 +++-
.../schema_diff/static/js/schema_diff.backform.js  | 10 +-
.../tools/schema_diff/static/js/schema_diff.js |  2 +-
.../tools/schema_diff/static/js/schema_diff_ui.js  | 12 ++--
web/pgadmin/tools/sqleditor/static/js/sqleditor.js |  2 +-
.../sqleditor/utils/query_tool_preferences.py  | 16 
.../user_management/static/js/user_management.js   |  4 ++--
45 files changed, 137 insertions(+), 130 deletions(-)

Re: pgAdmin 4 - gettext usage fixes

[Akshay Joshi]

Thanks, patch applied.

On Tue, Mar 24, 2020 at 11:06 AM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the updated patch with pep8, linter issues fixed.
>
>
> On Mon, Mar 23, 2020 at 8:31 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Libor,
>>
>> Thank you for the patch. It is good clean up patch.
>> I've made a few changes in the patch. You've imported sprintf which was
>> not required since gettext also works as sprintf directly.
>> I've also created a housekeeping redmine ticket to track it -
>> https://redmine.postgresql.org/issues/5284
>>
>> The messages compile fine. The patch can be committed.
>> Please find the attached updated patch.
>>
>>
>>
>> On Mon, Mar 23, 2020 at 4:00 PM Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review this?
>>>
>>> On Mon, Mar 23, 2020 at 5:00 AM Libor M.  wrote:
>>>
 Hello,
 I fixed using gettext function and add more usages for translations,
 specifically:

 - fixed usage gettext('') instead of _('') in javascript files
 - fixed usage gettext('') instead of `${gettext('')}` in javascript
 files, because "pybabel extract" not support extracting from this
 syntax
 - added a lot of gettext for support translations

 Diff file is attached.

 Best regards,

 Libor M.

 E-mail: libor...@gmail.com
 GitHub: https://github.com/liborm85

>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*