pgAdmin 4 commit: Don't try to render security URLs in desktop mode. Fi

2017-12-18 Thread Dave Page 
Don't try to render security URLs in desktop mode. Fixes #2952. Fixes #2922

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bceb6aef3cdde642acdf39ddd8abed0634ee1733
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/__init__.py | 6 +-
web/pgadmin/templates/security/change_password.html | 2 ++
web/pgadmin/templates/security/forgot_password.html | 2 ++
web/pgadmin/templates/security/login_user.html  | 2 ++
web/pgadmin/templates/security/reset_password.html  | 2 ++
5 files changed, 9 insertions(+), 5 deletions(-)

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-18 Thread Dave Page 
Thanks, applied.

On Thu, Dec 14, 2017 at 4:00 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Yes Harshal, you are right but due to RM#2922 changes now runtime is
> rendering the Login page.
>
> @Dave,
> Please find updated patch, which will also fix the issue of user login on
> each request in runtime.
> RM#2952
> RM#2922
>
> --
> ​ ​
> Murtuza
>
> On Thu, Dec 14, 2017 at 2:25 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> Moving login related code from under  decorator @app.before_first_request
>> to @app.before_request
>> will cause runtime user to login on each request. I think we need to find
>> some better way.
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Dec 14, 2017 at 2:02 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where we were rendering Security URL's like
>>> change password, reset password in HTML templates while running in Desktop
>>> mode, we only register these security blueprints in Server mode hence it
>>> was failing with BuildError.
>>> RM#2952
>>>
>>> Also reverted RM#2922 because it not working as expected and causing
>>> runtime to render login screen.
>>>
>>>
>>> Thanks to Neel for helping me in testing the patch with latest runtime
>>> code.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add tab indexes for debugger controls.

2017-12-18 Thread Dave Page 
Add tab indexes for debugger controls.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36d779df5d70b70f40fe1123eb8457a614edd109
Author: Murtuza Zabuawala 

Modified Files
--
.../tools/debugger/static/js/debugger_ui.js| 37 +++---
.../tools/debugger/templates/debugger/direct.html  | 18 +++
2 files changed, 45 insertions(+), 10 deletions(-)

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Dave Page 
Hi

I've committed this, but a couple of thoughts that should be
considered/implemented:

1) The first button should have focus immediately rather than the text
area. In the debugger at least, there is no real reason to have the text
area get focus by default.

2) If a button gets focus and is pushed, it should retain focus. Otherwise,
stepping through code is *really* tedious.

Thanks.

On Thu, Dec 14, 2017 at 9:07 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Yes, we can commit this code, It will add basic button navigation via
>>> Tab key.
>>>
>>> I think we should hold till our final design gets ready.
>>
> ​Adding 'tabindex' on button won't hurt in anyway and not become any kind
> of hurdle in design.​
>
>
>> I will keep the RM open until we add Tab navigation :)
>>>
>>>
>>> On Wed, Dec 13, 2017 at 9:33 PM, Dave Page  wrote:
>>>
 Hi,

 On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to add basic Tab key navigation in debugger window, where
> user will be able to navigate buttons using Tab key.
> RM#2897
>
> TODO:// Need to work on Debugger window Panel navigation.
>

 Given our conversation this morning, do we still want to apply this at
 this time?

 (for the benefit of the list, Murtuza, Khushboo, Harshal and I were
 discussing a keyboard navigation strategy for the whole application).

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Murtuza Zabuawala 
Sure Dave.

On Mon, Dec 18, 2017 at 2:55 PM, Dave Page  wrote:

> Hi
>
> I've committed this, but a couple of thoughts that should be
> considered/implemented:
>
> 1) The first button should have focus immediately rather than the text
> area. In the debugger at least, there is no real reason to have the text
> area get focus by default.
>
> 2) If a button gets focus and is pushed, it should retain focus.
> Otherwise, stepping through code is *really* tedious.
>
> Thanks.
>
> On Thu, Dec 14, 2017 at 9:07 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Yes, we can commit this code, It will add basic button navigation via
 Tab key.

 I think we should hold till our final design gets ready.
>>>
>> ​Adding 'tabindex' on button won't hurt in anyway and not become any kind
>> of hurdle in design.​
>>
>>
>>> I will keep the RM open until we add Tab navigation :)


 On Wed, Dec 13, 2017 at 9:33 PM, Dave Page  wrote:

> Hi,
>
> On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to add basic Tab key navigation in debugger window, where
>> user will be able to navigate buttons using Tab key.
>> RM#2897
>>
>> TODO:// Need to work on Debugger window Panel navigation.
>>
>
> Given our conversation this morning, do we still want to apply this at
> this time?
>
> (for the benefit of the list, Murtuza, Khushboo, Harshal and I were
> discussing a keyboard navigation strategy for the whole application).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: Enums printout - possible bug

2017-12-18 Thread Dave Page 
Hi

Looks like there's a TZ issue in the datatype test:

==
FAIL: runTest
(pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest)
Test checks for PG data-types output
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
line 105, in runTest
self._check_datatype()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
line 155, in _check_datatype
batch['output'][cnt - 2]
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
line 186, in check_result
datatype, source_code, string_to_find
AssertionError: for datatype tstzrange
["2010-01-01 08:30:00+00","2010-06-01 10:30:00+01") does not match with
["2010-01-01 14:00:00+05:30","2010-06-01 15:00:00+05:30")


On Fri, Dec 15, 2017 at 6:34 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> +pgadmin-hackers
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Dec 14, 2017 at 5:26 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch for various data type test cases.
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Mon, Dec 11, 2017 at 5:24 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Sat, Dec 9, 2017 at 12:06 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Sat, Dec 9, 2017 at 11:50 AM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

>
> On Sat, Dec 9, 2017 at 11:30 AM, Dave Page  wrote:
>
>> Hi
>>
>> Yeah, that one is in my list to work on. Have you specifically tested
>> it with enum types (not enum[])?
>>
>
> Yes.
>

 @Harshal,

 Can you add multidimensional array, enum types into feature test
 (pg_datatype_validation_test.py) ?

>>>
>>> I think I need to add test cases for all array data types not just enum
>>> types since fix was not targeted for any particular data type.
>>>
>>>

 [image: Inline image 3]
>
>
>
>>
>> On Sat, Dec 9, 2017 at 5:55 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Recently I sent a patch
>>> 
>>> regarding multidimensional array representation issue.
>>> In that patch I have reworked about how multidimensional (1
>>> dimension to n dimension)
>>> array data should be represented in grid.
>>> Also this patch covers almost all the array data types including
>>> composite array data types like
>>> int8range[], enum[], inet[], cidr[], macaddr[], uuid[], xml[],
>>> bit[], varbit[] and so on.
>>>
>>> Please review the patch and let me know if any thing needs to be
>>> included in this patch.
>>>
>>> Thanks,
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Sat, Dec 9, 2017 at 10:45 AM, Dave Page 
>>> wrote:
>>>
 Murtuza, can you investigate please?

 Thanks!

 On Fri, Dec 8, 2017 at 8:08 PM, Bartosz Dmytrak >>> > wrote:

> Hi all,
>
> According to documentation: https://www.postgresql.org/doc
> s/current/static/functions-enum.html when I execute SELECT
> enum_range(null::rainbow) then output should look like this:
> {red,orange,yellow,green,blue,purple}
>
> But in pgAdmin output looks like this:
> {{,r,e,d,,,o,r,a,n,g,e,,,y,e,l,l,o,w,,,g,r,e,e,n,,,b,l,u,e,,,p,u,r,p,l,e,}}.
> When you click on the field, popup window shows correct value. I’ve 
> double
> checked it in psql, and output is correct. I think it could be 
> considered
> as bug in pgAdmin
>
>
>
> PgAdmin details:
>
> *Version *2.0
>
> *Python Version *2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016,
> 20:42:59) [MSC v.1500 32 bit (Intel)]
>
> *Flask Version *0.12.2
>
> *Application Mode *Desktop
>
>
>
> Pg Version: 10.1
>
> Regardless this one, many thanks for your great job

pgAdmin 4 commit: Allow files to be opened by double clicking on them.

2017-12-18 Thread Dave Page 
Allow files to be opened by double clicking on them. Fixes #2810

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eae6f05b7c1b8e23b1cdc15225900ad713d91129
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/misc/file_manager/static/js/utility.js | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)

Re: [pgAdmin4][Patch]: File manager - Allow user to load the file by double clicking on it

2017-12-18 Thread Dave Page 
Thanks, patch applied.

On Thu, Dec 14, 2017 at 12:41 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch which will allow user to load the file via file manager by
> double clicking on the file just like native file manager.
> RM#2810
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to select error text

2017-12-18 Thread Dave Page 
Thanks, patch applied.

On Thu, Dec 14, 2017 at 12:57 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch which will allow user to select the text from error
> message.
> RM#2954
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow selection of validation error text. Fixes #2954

2017-12-18 Thread Dave Page 
Allow selection of validation error text. Fixes #2954

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3fe655e9444cfb19d9a05c43bc50474381992fbd
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/static/scss/_alert.scss | 5 +
1 file changed, 5 insertions(+)

Re: Polish translation update

2017-12-18 Thread Dave Page 
Thanks, update applied!

On Sun, Dec 17, 2017 at 10:37 PM, Begina Felicysym 
wrote:

> Hello,
>
> Please find the attached file with polish translation of pgAdmin.
> Cheers
>
> Begina
>
>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Updated Polish translation from Begina. Extract/updat

2017-12-18 Thread Dave Page 
Updated Polish translation from Begina. Extract/update/compile as well for 
completeness. Current status:

1480 of 1857 messages (79%) translated in 
pgadmin/translations/de/LC_MESSAGES/messages.po
1692 of 1857 messages (91%) translated in 
pgadmin/translations/ja/LC_MESSAGES/messages.po
1827 of 1857 messages (98%) translated in 
pgadmin/translations/pl/LC_MESSAGES/messages.po
1829 of 1857 messages (98%) translated in 
pgadmin/translations/ru/LC_MESSAGES/messages.po
1435 of 1857 messages (77%) translated in 
pgadmin/translations/zh/LC_MESSAGES/messages.po

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ebd096f5cc7214d128cfa45b675dae552b386e78
Author: Begina Felicysym 

Modified Files
--
web/pgadmin/messages.pot   | 1779 ---
.../translations/de/LC_MESSAGES/messages.mo|  Bin 132000 -> 134062 bytes
.../translations/de/LC_MESSAGES/messages.po| 1793 +---
.../translations/ja/LC_MESSAGES/messages.mo|  Bin 141384 -> 143439 bytes
.../translations/ja/LC_MESSAGES/messages.po| 1795 +---
.../translations/pl/LC_MESSAGES/messages.mo|  Bin 131960 -> 134422 bytes
.../translations/pl/LC_MESSAGES/messages.po| 2037 ++
.../translations/ru/LC_MESSAGES/messages.mo|  Bin 172074 -> 173920 bytes
.../translations/ru/LC_MESSAGES/messages.po| 2260 +++-
.../translations/zh/LC_MESSAGES/messages.mo|  Bin 108613 -> 110686 bytes
.../translations/zh/LC_MESSAGES/messages.po| 1793 +---
11 files changed, 6193 insertions(+), 5264 deletions(-)

pgAdmin 4 commit: Bump version for some dev builds.

2017-12-18 Thread Dave Page 
Bump version for some dev builds.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d44328664a556dd7dff0b807444a7eb8f60bc014

Modified Files
--
web/config.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2017-12-18 Thread Dave Page 
Doc updates for server connection dialogue and related info.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10d03078342b9f7c0860bbaf14d6a0ad777f20e5
Author: Susan Douglas 

Modified Files
--
docs/en_US/images/server_advanced.png   | Bin 53629 -> 34067 bytes
docs/en_US/images/server_connection.png | Bin 63173 -> 39678 bytes
docs/en_US/images/server_general.png| Bin 58263 -> 37276 bytes
docs/en_US/images/server_ssl.png| Bin 68333 -> 42132 bytes
docs/en_US/pgadmin_tabbed_browser.rst   |  49 ---
docs/en_US/server_dialog.rst|  83 +---
6 files changed, 45 insertions(+), 87 deletions(-)

Re: pgAdmin 4 - Update for Server dialog

2017-12-18 Thread Dave Page 
Thanks, patch applied.

It's probably worth updating your system to make sure you're running an up
to date version of git etc. I'm not sure whether that would require an app
store update or update to macports or homebrew - that depends on how your
machine was originally setup.

You might also want to look at the ~/.gitconfig file on your system. This
is what works for me:

(pgadmin4)piranha:pgadmin4 dpage$ more ~/.gitconfig
[push]
default = simple
[core]
autocrlf = input
[user]
name = Dave Page
email = dp...@pgadmin.org


On Mon, Dec 18, 2017 at 10:51 AM, Susan Douglas <
susan.doug...@enterprisedb.com> wrote:

> Hi All,
>
> Khushboo has helped generate the attached patch for the server_dialog.rst
> and pgadmin_tabbed_browser.rst changes.  When generated on my system, the
> patch fails, but when generated on her system, the patch applies.  In both
> cases, we're using the same files and commands to generate the patch.
>
> Let me know if there are any further problems!
>
> Thanks!
>
> -- Susan
>
>
>
>
>
>
>
> On Dec 18, 2017, at 4:11 AM, Dave Page  wrote:
>
> Hi
>
> For some reason I usually find Susan's patches will only apply using
> "patch -p1" and not "git apply". It's very odd.
>
> In this case, patch seems to think it's reversed (i.e. already applied):
>
> piranha:pgadmin4 dpage$ patch -p1 < ~/Downloads/server_dialog.patch
> (Stripping trailing CRs from patch.)
> patching file docs/en_US/server_dialog.rst
> Reversed (or previously applied) patch detected!  Assume -R? [n]
>
> On Fri, Dec 15, 2017 at 4:48 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Susan,
>>
>> Now, getting another error as attached.
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Dec 14, 2017 at 5:44 PM, Susan Douglas <
>> susan.doug...@enterprisedb.com> wrote:
>>
>>>
>>> > On Dec 13, 2017, at 11:39 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>> >
>>> > Hi susan,
>>> >
>>> > I am getting an error while applying the patch, attached the
>>> screen-shot for the same.
>>> >
>>> > Thanks,
>>> > Khushboo
>>> >
>>>
>>> Hi Khushboo,
>>>
>>> The error message is complaining about line 3 (GIT binary patch), so I
>>> regenerated the patch without the --cached --binary directives... it's
>>> attached below.  Can you try this patch?
>>>
>>> -- Susan
>>>
>>>
>>>
>>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Build failed in Jenkins: pgadmin4-master-python26 #554

2017-12-18 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bump version for some dev builds.

[Dave Page] Doc updates for server connection dialogue and related info.

--
[...truncated 378.37 KB...]
PhantomJS 2.1.1 (Linux 0.0.0): Executed 208 of 302 SUCCESS (0 secs / 
4.245 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 209 of 302 SUCCESS (0 secs / 
4.257 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 210 of 302 SUCCESS (0 secs / 
4.271 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 211 of 302 SUCCESS (0 secs / 
4.283 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 212 of 302 SUCCESS (0 secs / 
4.287 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 213 of 302 SUCCESS (0 secs / 
4.291 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 214 of 302 SUCCESS (0 secs / 
4.295 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 215 of 302 SUCCESS (0 secs / 
4.299 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 216 of 302 SUCCESS (0 secs / 
4.303 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 217 of 302 SUCCESS (0 secs / 
4.307 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 218 of 302 SUCCESS (0 secs / 
4.311 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 219 of 302 SUCCESS (0 secs / 
4.315 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 220 of 302 SUCCESS (0 secs / 
4.319 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 221 of 302 SUCCESS (0 secs / 
4.323 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 222 of 302 SUCCESS (0 secs / 
4.343 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 223 of 302 SUCCESS (0 secs / 
4.362 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 224 of 302 SUCCESS (0 secs / 
4.38 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 225 of 302 SUCCESS (0 secs / 
4.394 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 226 of 302 SUCCESS (0 secs / 
4.405 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 227 of 302 SUCCESS (0 secs / 
4.417 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 228 of 302 SUCCESS (0 secs / 
4.429 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 229 of 302 SUCCESS (0 secs / 
4.441 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 230 of 302 SUCCESS (0 secs / 
4.446 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 231 of 302 SUCCESS (0 secs / 
4.45 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 232 of 302 SUCCESS (0 secs / 
4.454 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 233 of 302 SUCCESS (0 secs / 
4.466 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 234 of 302 SUCCESS (0 secs / 
4.47 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 235 of 302 SUCCESS (0 secs / 
4.474 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 236 of 302 SUCCESS (0 secs / 
4.478 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 237 of 302 SUCCESS (0 secs / 
4.482 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 238 of 302 SUCCESS (0 secs / 
4.487 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 239 of 302 SUCCESS (0 secs / 
4.491 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 240 of 302 SUCCESS (0 secs / 
4.495 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 241 of 302 SUCCESS (0 secs / 
4.499 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 242 of 302 SUCCESS (0 secs / 
4.503 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 243 of 302 SUCCESS (0 secs / 
4.507 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 244 of 302 SUCCESS (0 secs / 
4.512 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 245 of 302 SUCCESS (0 secs / 
4.516 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 246 of 302 SUCCESS (0 secs / 
4.52 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 247 of 302 SUCCESS (0 secs / 
4.525 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 248 of 302 SUCCESS (0 secs / 
4.529 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 249 of 302 SUCCESS (0 secs / 
4.533 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 250 of 302 SUCCESS (0 secs / 
4.537 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 251 of 302 SUCCESS (0 secs / 
4.541 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 252 of 302 SUCCESS (0 secs / 
4.545 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 253 of 302 SUCCESS (0 secs / 
4.549 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 254 of 302 SUCCESS (0 secs / 
4.555 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 255 of 302 SUCCESS (0 secs / 
4.563 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 256 of 302 SUCCESS (0 secs / 
4.567 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 257 of 302 SUCCESS (0 secs / 
4.571 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 258 of 302 SUCCESS (0 secs / 
4.576 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 259 of 302 SUCCESS (0 secs / 
4.58 secs)
PhantomJS 2.1.1

pgAdmin 4 commit: Runtime version update

2017-12-18 Thread Dave Page 
Runtime version update

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=005abab7c4ca721dd0abde33ca348afd0e6a8dff

Modified Files
--
runtime/Info.plist   | 4 ++--
runtime/pgAdmin4.pro | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

Build failed in Jenkins: pgadmin4-master-python34 #415

2017-12-18 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bump version for some dev builds.

[Dave Page] Doc updates for server connection dialogue and related info.

--
[...truncated 373.38 KB...]
PhantomJS 2.1.1 (Linux 0.0.0): Executed 209 of 302 SUCCESS (0 secs / 
4.178 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 210 of 302 SUCCESS (0 secs / 
4.191 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 211 of 302 SUCCESS (0 secs / 
4.204 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 212 of 302 SUCCESS (0 secs / 
4.208 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 213 of 302 SUCCESS (0 secs / 
4.212 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 214 of 302 SUCCESS (0 secs / 
4.216 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 215 of 302 SUCCESS (0 secs / 
4.22 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 216 of 302 SUCCESS (0 secs / 
4.225 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 217 of 302 SUCCESS (0 secs / 
4.23 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 218 of 302 SUCCESS (0 secs / 
4.234 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 219 of 302 SUCCESS (0 secs / 
4.238 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 220 of 302 SUCCESS (0 secs / 
4.242 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 221 of 302 SUCCESS (0 secs / 
4.247 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 222 of 302 SUCCESS (0 secs / 
4.267 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 223 of 302 SUCCESS (0 secs / 
4.283 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 224 of 302 SUCCESS (0 secs / 
4.302 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 225 of 302 SUCCESS (0 secs / 
4.315 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 226 of 302 SUCCESS (0 secs / 
4.327 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 227 of 302 SUCCESS (0 secs / 
4.338 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 228 of 302 SUCCESS (0 secs / 
4.349 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 229 of 302 SUCCESS (0 secs / 
4.36 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 230 of 302 SUCCESS (0 secs / 
4.365 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 231 of 302 SUCCESS (0 secs / 
4.369 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 232 of 302 SUCCESS (0 secs / 
4.374 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 233 of 302 SUCCESS (0 secs / 
4.382 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 234 of 302 SUCCESS (0 secs / 
4.387 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 235 of 302 SUCCESS (0 secs / 
4.391 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 236 of 302 SUCCESS (0 secs / 
4.395 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 237 of 302 SUCCESS (0 secs / 
4.4 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 238 of 302 SUCCESS (0 secs / 
4.404 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 239 of 302 SUCCESS (0 secs / 
4.408 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 240 of 302 SUCCESS (0 secs / 
4.412 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 241 of 302 SUCCESS (0 secs / 
4.416 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 242 of 302 SUCCESS (0 secs / 
4.423 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 243 of 302 SUCCESS (0 secs / 
4.427 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 244 of 302 SUCCESS (0 secs / 
4.431 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 245 of 302 SUCCESS (0 secs / 
4.435 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 246 of 302 SUCCESS (0 secs / 
4.439 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 247 of 302 SUCCESS (0 secs / 
4.444 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 248 of 302 SUCCESS (0 secs / 
4.448 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 249 of 302 SUCCESS (0 secs / 
4.452 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 250 of 302 SUCCESS (0 secs / 
4.457 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 251 of 302 SUCCESS (0 secs / 
4.461 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 252 of 302 SUCCESS (0 secs / 
4.465 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 253 of 302 SUCCESS (0 secs / 
4.47 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 254 of 302 SUCCESS (0 secs / 
4.474 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 255 of 302 SUCCESS (0 secs / 
4.482 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 256 of 302 SUCCESS (0 secs / 
4.487 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 257 of 302 SUCCESS (0 secs / 
4.491 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 258 of 302 SUCCESS (0 secs / 
4.495 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 259 of 302 SUCCESS (0 secs / 
4.5 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 260 of 302 SUCCESS (0 secs / 
4.504 secs)
PhantomJS 2.1.1 (L

pgAdmin 4 commit: Fix duplicate link text

2017-12-18 Thread Dave Page 
Fix duplicate link text

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6577723a2a385115515749aefbbb2816f9bff27d

Modified Files
--
docs/en_US/server_dialog.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #423

2017-12-18 Thread pgAdmin 4 Jenkins 
See 


Changes:

[Dave Page] Bump version for some dev builds.

[Dave Page] Doc updates for server connection dialogue and related info.

[Dave Page] Runtime version update

--
[...truncated 372.31 KB...]
PhantomJS 2.1.1 (Linux 0.0.0): Executed 195 of 302 SUCCESS (0 secs / 
4.033 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 196 of 302 SUCCESS (0 secs / 
4.046 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 197 of 302 SUCCESS (0 secs / 
4.058 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 198 of 302 SUCCESS (0 secs / 
4.07 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 199 of 302 SUCCESS (0 secs / 
4.084 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 200 of 302 SUCCESS (0 secs / 
4.1 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 201 of 302 SUCCESS (0 secs / 
4.115 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 202 of 302 SUCCESS (0 secs / 
4.127 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 203 of 302 SUCCESS (0 secs / 
4.14 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 204 of 302 SUCCESS (0 secs / 
4.157 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 205 of 302 SUCCESS (0 secs / 
4.172 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 206 of 302 SUCCESS (0 secs / 
4.185 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 207 of 302 SUCCESS (0 secs / 
4.198 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 208 of 302 SUCCESS (0 secs / 
4.219 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 209 of 302 SUCCESS (0 secs / 
4.233 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 210 of 302 SUCCESS (0 secs / 
4.245 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 211 of 302 SUCCESS (0 secs / 
4.258 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 212 of 302 SUCCESS (0 secs / 
4.262 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 213 of 302 SUCCESS (0 secs / 
4.266 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 214 of 302 SUCCESS (0 secs / 
4.27 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 215 of 302 SUCCESS (0 secs / 
4.274 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 216 of 302 SUCCESS (0 secs / 
4.278 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 217 of 302 SUCCESS (0 secs / 
4.282 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 218 of 302 SUCCESS (0 secs / 
4.286 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 219 of 302 SUCCESS (0 secs / 
4.29 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 220 of 302 SUCCESS (0 secs / 
4.294 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 221 of 302 SUCCESS (0 secs / 
4.298 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 222 of 302 SUCCESS (0 secs / 
4.318 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 223 of 302 SUCCESS (0 secs / 
4.334 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 224 of 302 SUCCESS (0 secs / 
4.353 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 225 of 302 SUCCESS (0 secs / 
4.366 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 226 of 302 SUCCESS (0 secs / 
4.378 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 227 of 302 SUCCESS (0 secs / 
4.39 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 228 of 302 SUCCESS (0 secs / 
4.402 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 229 of 302 SUCCESS (0 secs / 
4.416 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 230 of 302 SUCCESS (0 secs / 
4.421 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 231 of 302 SUCCESS (0 secs / 
4.425 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 232 of 302 SUCCESS (0 secs / 
4.43 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 233 of 302 SUCCESS (0 secs / 
4.438 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 234 of 302 SUCCESS (0 secs / 
4.442 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 235 of 302 SUCCESS (0 secs / 
4.447 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 236 of 302 SUCCESS (0 secs / 
4.451 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 237 of 302 SUCCESS (0 secs / 
4.455 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 238 of 302 SUCCESS (0 secs / 
4.459 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 239 of 302 SUCCESS (0 secs / 
4.463 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 240 of 302 SUCCESS (0 secs / 
4.468 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 241 of 302 SUCCESS (0 secs / 
4.472 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 242 of 302 SUCCESS (0 secs / 
4.476 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 243 of 302 SUCCESS (0 secs / 
4.481 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 244 of 302 SUCCESS (0 secs / 
4.485 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 245 of 302 SUCCESS (0 secs / 
4.489 secs)
PhantomJS 2.1.1 (Linux 0.0.0): Executed 246 of 302 SUCCESS (0 secs / 
4.

pgAdmin v2.1-dev test builds

2017-12-18 Thread Dave Page 
Can be found at https://developer.pgadmin.org/~dpage/2.1-dev/ if anyone
wants to play.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Jenkins build is back to normal : pgadmin4-master-python26 #555

2017-12-18 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python34 #416

2017-12-18 Thread pgAdmin 4 Jenkins 
See

Jenkins build is back to normal : pgadmin4-master-python33 #424

2017-12-18 Thread pgAdmin 4 Jenkins 
See

pgAdmin 4 commit: Make the query tool datatype test easily configurable

2017-12-18 Thread Dave Page 
Make the query tool datatype test easily configurable and extendable and add 
support for multi-dimensional arrays and enums.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88bcd3b5129db88975421e26c1bf188daf4892f9
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/feature_tests/datatype_test.json   | 173 +
.../feature_tests/pg_datatype_validation_test.py   | 204 -
web/regression/feature_utils/pgadmin_page.py   |  13 ++
web/regression/python_test_utils/test_utils.py |  18 ++
4 files changed, 359 insertions(+), 49 deletions(-)

Re: Enums printout - possible bug

2017-12-18 Thread Dave Page 
Awesome - thanks, applied!

On Mon, Dec 18, 2017 at 2:24 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Dec 18, 2017 at 3:13 PM, Dave Page  wrote:
>
>> Hi
>>
>> Looks like there's a TZ issue in the datatype test:
>>
>> ==
>> FAIL: runTest (pgadmin.feature_tests.pg_data
>> type_validation_test.PGDataypeFeatureTest)
>> Test checks for PG data-types output
>> --
>> Traceback (most recent call last):
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
>> line 105, in runTest
>> self._check_datatype()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
>> line 155, in _check_datatype
>> batch['output'][cnt - 2]
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/pg_datatype_validation_test.py",
>> line 186, in check_result
>> datatype, source_code, string_to_find
>> AssertionError: for datatype tstzrange
>> ["2010-01-01 08:30:00+00","2010-06-01 10:30:00+01") does not match with
>> ["2010-01-01 14:00:00+05:30","2010-06-01 15:00:00+05:30")
>>
>> Fixed.
>
> Please find attached updated patch.
>
>
>>
>> On Fri, Dec 15, 2017 at 6:34 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> +pgadmin-hackers
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Thu, Dec 14, 2017 at 5:26 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>
 Hi,

 Please find attached patch for various data type test cases.


 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Mon, Dec 11, 2017 at 5:24 PM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Sat, Dec 9, 2017 at 12:06 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Sat, Dec 9, 2017 at 11:50 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>>
>>> On Sat, Dec 9, 2017 at 11:30 AM, Dave Page 
>>> wrote:
>>>
 Hi

 Yeah, that one is in my list to work on. Have you specifically
 tested it with enum types (not enum[])?

>>>
>>> Yes.
>>>
>>
>> @Harshal,
>>
>> Can you add multidimensional array, enum types into feature test
>> (pg_datatype_validation_test.py) ?
>>
>
> I think I need to add test cases for all array data types not just
> enum types since fix was not targeted for any particular data type.
>
>
>>
>> [image: Inline image 3]
>>>
>>>
>>>

 On Sat, Dec 9, 2017 at 5:55 AM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi Dave,
>
> Recently I sent a patch
> 
> regarding multidimensional array representation issue.
> In that patch I have reworked about how multidimensional (1
> dimension to n dimension)
> array data should be represented in grid.
> Also this patch covers almost all the array data types including
> composite array data types like
> int8range[], enum[], inet[], cidr[], macaddr[], uuid[], xml[],
> bit[], varbit[] and so on.
>
> Please review the patch and let me know if any thing needs to be
> included in this patch.
>
> Thanks,
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Sat, Dec 9, 2017 at 10:45 AM, Dave Page 
> wrote:
>
>> Murtuza, can you investigate please?
>>
>> Thanks!
>>
>> On Fri, Dec 8, 2017 at 8:08 PM, Bartosz Dmytrak <
>> bdmyt...@gmail.com> wrote:
>>
>>> Hi all,
>>>
>>> According to documentation: https://www.postgresql.org/doc
>>> s/current/static/functions-enum.html when I execute SELECT
>>> enum_range(null::rainbow) then output should look like this:
>>> {red,orange,yellow,green,blue,purple}
>>>
>>> But in pgAdmin output looks like this:
>>> {{,r,

[pgAdmin4][Patch]: RM #2964 - [Desktop Runtime] pgAdmin4 crash if user download query as CVS

2017-12-18 Thread Khushboo Vashi 
Hi,

Please find the attached patch to fix the RM #2964:  [Desktop Runtime]
pgAdmin4 crash if user download query as CVS.

Patch by Neel Patel.

Thanks,
Khushboo
diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp
index 2dd5b49..38982c7 100644
--- a/runtime/BrowserWindow.cpp
+++ b/runtime/BrowserWindow.cpp
@@ -662,7 +662,7 @@ void BrowserWindow::downloadFileProgress(qint64 readData, qint64 totalData)
 }
 
 // Check if download is finished without readyRead signal then write the data.
-if(m_reply->isFinished() && !is_readyReadSignaled)
+if(m_reply && m_reply->isFinished() && !is_readyReadSignaled)
 {
 // Write data to file
 m_file->write(m_reply->read(readData));
@@ -691,7 +691,7 @@ void BrowserWindow::downloadFileProgress(qint64 readData, qint64 totalData)
   m_reply = NULL;
 }
 
-if(m_reply->isFinished() && readData == totalData)
+if(m_reply && m_reply->isFinished() && readData == totalData)
 m_readBytes = 0;
  }
 }