date:20170825

Re: Next release

2017-08-25 Thread Surinder Kumar

Hi

On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>


 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Thu, Aug 24, 2017 at 9:44 PM, Dave Page  wrote:

>
>
> On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Thu, Aug 24, 2017 at 2:28 PM, Dave Page  wrote:
>>
>>> Anyone object to doing a release on 14th September, wrapping the
>>> code on Monday 11th? This seems like the best option for our QA folks 
>>> who
>>> will be off for EID somewhen in the two weeks before.
>>>
>>> Assuming not, should this be 1.7 or 2.0?
>>>
>>> If we go with 2.0, it'll be for "safety" given the proposed changes
>>> to path management to allow both server and desktop modes to work out of
>>> the box on Linux.
>>>
>>> If we do that, we also need to ensure that any changes to the config
>>> database are backwards compatible, as a 2.0 release would be a 
>>> side-by-side
>>> installation. Surinder; was it you that had looked into that?
>>>
>> I had looked into this and here are my findings:
>> 1. If we are using newer version of pgAdmin and the go back to older
>> version of pgAdmin, then on running `python pgAdmin4.py`. the
>> flask-migrate(Alembic) try to perform downgrade by one step only(ie. it 
>> can
>> switch back to one migration only when we run  `python pgAdmin4.py`). But
>> we have multiple database revisions to be migrated. So migration fails 
>> here.
>>
>> 2. When Alebmic downgrade is performed by one step, it looks for
>> downgrade function in that specific database revision, but in our code we
>> didn't written downgrade function. But if we have written downgrade
>> statement, still there is an issue:
>> ie. If we add a new column to a table xyz using ALTER statement like:
>>
>> ```
>> 
>> def upgrade():
>> 
>> verison = get_version()
>>
>> 
>> db.engine.execute(
>> 
>> 'ALTER TABLE server ADD COLUMN hostaddr TEXT(1024)'
>>  
>> )
>>
>> def downgrade():
>> 
>> pass
>> ```
>> then on downgrade it executes `downgrade` method, so downgrade should
>> have code like
>> `ALTER TABLE server DROP COLUMN hostaddr `
>> but in sqlite DROP COLUMN statements don't work.
>> So, this is a an issue with Sqlite database. However, an alternative
>> way is also given. Here is link
>> 
>>
>>
>> Still, I didn't find any other solution on upgrading/downgrading
>> database revisions without errors.
>> It is an issue with Flask-Migrate(Alembic) plugin.
>>
>
>
> Urgh. So I guess the other option is that we version the DB filename
> as well. The downside of that is that users will want to migrate their
> settings - which may be awkward as we'll have no real way of knowing where
> they are.
>
> Thoughts?
>
> Or should we write our own custom backword migrations? For eg.
 dropping  column can be achieved by creating another table excluding the
 columns which we want to drop then copy data to new table and then drop old
 table and rename new table to old name. And also sqlite database schema
 which we have in pgAdmin4 is small so writing and maintaining custom
 migration won be that hard.

>>>
>>> The problem is that we don't want to migrate backwards; we want both
>>> versions to be able to run with the same database (for example, because you
>>> might have multiple versions installed with the EDB PG installer as I do on
>>> my laptop).
>>>
>>> Previously, we always made sure our changes were backwards compatible
>>> (e.g. by only adding new columns, never removing or renaming them), and our
>>> home-grown migration code only cared about upgrading the database to the
>>> current version; it wouldn't complain if the database was of a newer
>>> version.
>>>
>> The code which is responsible to run database migration is
>> `db_upgrade(app)` in `pgadmin/__init__.py` it executes when python server
>> runs `python pgAdmin4.py`, It fails with older version of pgAdmin4(say 1.5)
>> because it cannot find db revision file (revision id stored in table
>> 'alembic_version') in `web/migrations` folder of latest pgAdmin4-1.5
>>
>> But If we catch this exception like:
>> ```
>> import alembic
>> try:

Re: Next release

2017-08-25 Thread Dave Page

On Fri, Aug 25, 2017 at 9:15 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page  wrote:
>>>


 On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Aug 24, 2017 at 9:44 PM, Dave Page  wrote:
>
>>
>>
>> On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Aug 24, 2017 at 2:28 PM, Dave Page 
>>> wrote:
>>>
 Anyone object to doing a release on 14th September, wrapping the
 code on Monday 11th? This seems like the best option for our QA folks 
 who
 will be off for EID somewhen in the two weeks before.

 Assuming not, should this be 1.7 or 2.0?

 If we go with 2.0, it'll be for "safety" given the proposed changes
 to path management to allow both server and desktop modes to work out 
 of
 the box on Linux.

 If we do that, we also need to ensure that any changes to the
 config database are backwards compatible, as a 2.0 release would be a
 side-by-side installation. Surinder; was it you that had looked into 
 that?

>>> I had looked into this and here are my findings:
>>> 1. If we are using newer version of pgAdmin and the go back to older
>>> version of pgAdmin, then on running `python pgAdmin4.py`. the
>>> flask-migrate(Alembic) try to perform downgrade by one step only(ie. it 
>>> can
>>> switch back to one migration only when we run  `python pgAdmin4.py`). 
>>> But
>>> we have multiple database revisions to be migrated. So migration fails 
>>> here.
>>>
>>> 2. When Alebmic downgrade is performed by one step, it looks for
>>> downgrade function in that specific database revision, but in our code 
>>> we
>>> didn't written downgrade function. But if we have written downgrade
>>> statement, still there is an issue:
>>> ie. If we add a new column to a table xyz using ALTER statement like:
>>>
>>> ```
>>> 
>>> def upgrade():
>>> 
>>> verison = get_version()
>>>
>>> 
>>> db.engine.execute(
>>> 
>>> 'ALTER TABLE server ADD COLUMN hostaddr TEXT(1024)'
>>>  
>>> )
>>>
>>> def downgrade():
>>> 
>>> pass
>>> ```
>>> then on downgrade it executes `downgrade` method, so downgrade
>>> should have code like
>>> `ALTER TABLE server DROP COLUMN hostaddr `
>>> but in sqlite DROP COLUMN statements don't work.
>>> So, this is a an issue with Sqlite database. However, an alternative
>>> way is also given. Here is link
>>> 
>>>
>>>
>>> Still, I didn't find any other solution on upgrading/downgrading
>>> database revisions without errors.
>>> It is an issue with Flask-Migrate(Alembic) plugin.
>>>
>>
>>
>> Urgh. So I guess the other option is that we version the DB filename
>> as well. The downside of that is that users will want to migrate their
>> settings - which may be awkward as we'll have no real way of knowing 
>> where
>> they are.
>>
>> Thoughts?
>>
>> Or should we write our own custom backword migrations? For eg.
> dropping  column can be achieved by creating another table excluding the
> columns which we want to drop then copy data to new table and then drop 
> old
> table and rename new table to old name. And also sqlite database schema
> which we have in pgAdmin4 is small so writing and maintaining custom
> migration won be that hard.
>

 The problem is that we don't want to migrate backwards; we want both
 versions to be able to run with the same database (for example, because you
 might have multiple versions installed with the EDB PG installer as I do on
 my laptop).

 Previously, we always made sure our changes were backwards compatible
 (e.g. by only adding new columns, never removing or renaming them), and our
 home-grown migration code only cared about upgrading the database to the
 current version; it wouldn't complain if the database was of a newer
 version.

>>> The code which is responsible to run database migration is
>>> `db_upgrade(app)` in `pgadmin/__init__.py` it executes when python server
>>> runs `python pgAdmin4.py`, It f

Re: Next release

2017-08-25 Thread Harshal Dhumal

One more thing that this will only work for future pgAdmin4 versions

-- 
*Harshal Dhumal*
*Sr. Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Aug 25, 2017 at 1:48 PM, Dave Page  wrote:

>
>
> On Fri, Aug 25, 2017 at 9:15 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi
 On Fri, Aug 25, 2017 at 1:03 AM, Dave Page  wrote:

>
>
> On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Aug 24, 2017 at 9:44 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 On Thu, Aug 24, 2017 at 2:28 PM, Dave Page 
 wrote:

> Anyone object to doing a release on 14th September, wrapping the
> code on Monday 11th? This seems like the best option for our QA folks 
> who
> will be off for EID somewhen in the two weeks before.
>
> Assuming not, should this be 1.7 or 2.0?
>
> If we go with 2.0, it'll be for "safety" given the proposed
> changes to path management to allow both server and desktop modes to 
> work
> out of the box on Linux.
>
> If we do that, we also need to ensure that any changes to the
> config database are backwards compatible, as a 2.0 release would be a
> side-by-side installation. Surinder; was it you that had looked into 
> that?
>
 I had looked into this and here are my findings:
 1. If we are using newer version of pgAdmin and the go back to
 older version of pgAdmin, then on running `python pgAdmin4.py`. the
 flask-migrate(Alembic) try to perform downgrade by one step only(ie. 
 it can
 switch back to one migration only when we run  `python pgAdmin4.py`). 
 But
 we have multiple database revisions to be migrated. So migration fails 
 here.

 2. When Alebmic downgrade is performed by one step, it looks for
 downgrade function in that specific database revision, but in our code 
 we
 didn't written downgrade function. But if we have written downgrade
 statement, still there is an issue:
 ie. If we add a new column to a table xyz using ALTER statement
 like:

 ```
 
 def upgrade():
 
 verison = get_version()

 
 db.engine.execute(
 
 'ALTER TABLE server ADD COLUMN hostaddr TEXT(1024)'
  
 )

 def downgrade():
 
 pass
 ```
 then on downgrade it executes `downgrade` method, so downgrade
 should have code like
 `ALTER TABLE server DROP COLUMN hostaddr `
 but in sqlite DROP COLUMN statements don't work.
 So, this is a an issue with Sqlite database. However, an
 alternative way is also given. Here is link
 


 Still, I didn't find any other solution on upgrading/downgrading
 database revisions without errors.
 It is an issue with Flask-Migrate(Alembic) plugin.

>>>
>>>
>>> Urgh. So I guess the other option is that we version the DB filename
>>> as well. The downside of that is that users will want to migrate their
>>> settings - which may be awkward as we'll have no real way of knowing 
>>> where
>>> they are.
>>>
>>> Thoughts?
>>>
>>> Or should we write our own custom backword migrations? For eg.
>> dropping  column can be achieved by creating another table excluding the
>> columns which we want to drop then copy data to new table and then drop 
>> old
>> table and rename new table to old name. And also sqlite database schema
>> which we have in pgAdmin4 is small so writing and maintaining custom
>> migration won be that hard.
>>
>
> The problem is that we don't want to migrate backwards; we want both
> versions to be able to run with the same database (for example, because 
> you
> might have multiple versions installed with the EDB PG installer as I do 
> on
> my laptop).
>
> Previously, we always made sure our changes were backwards compatible
> (e.g. by only a

pgAdmin 4 commit: Properly cleanup after running the FTS test cases.

2017-08-25 Thread Dave Page

Properly cleanup after running the FTS test cases.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd04cfaaa8bd6830b8c6277d5580fe5b1bb0aabe
Author: Navnath Gadakh 

Modified Files
--
.../foreign_data_wrappers/tests/test_fdw_add.py|  4 ++--
.../foreign_data_wrappers/tests/test_fdw_get.py|  4 ++--
.../foreign_data_wrappers/tests/test_fdw_put.py|  6 ++---
.../databases/foreign_data_wrappers/tests/utils.py | 23 +++
.../tests/test_fts_configuration_add.py| 19 +---
.../tests/test_fts_configuration_get.py| 25 +
.../tests/test_fts_configuration_put.py|  9 ++--
.../schemas/fts_configurations/tests/utils.py  | 26 ++
.../tests/test_fts_dictionaries_add.py | 13 +++
.../tests/test_fts_dictionaries_get.py | 10 ++---
.../tests/test_fts_dictionaries_put.py | 10 ++---
.../schemas/fts_dictionaries/tests/utils.py| 26 ++
.../fts_parser/tests/test_fts_parser_add.py| 11 ++---
.../fts_parser/tests/test_fts_parser_get.py|  7 --
.../fts_parser/tests/test_fts_parser_put.py|  7 --
.../databases/schemas/fts_parser/tests/utils.py| 26 ++
.../fts_templates/tests/test_fts_templates_add.py  | 14 
.../fts_templates/tests/test_fts_templates_get.py  |  7 --
.../fts_templates/tests/test_fts_templates_put.py  |  7 --
.../databases/schemas/fts_templates/tests/utils.py | 26 ++
20 files changed, 229 insertions(+), 51 deletions(-)

Re: Next release

2017-08-25 Thread Dave Page

On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> One more thing that this will only work for future pgAdmin4 versions
>


Yeah :-(


>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Aug 25, 2017 at 1:48 PM, Dave Page  wrote:
>
>>
>>
>> On Fri, Aug 25, 2017 at 9:15 AM, Surinder Kumar <
>> surinder.ku...@enterprisedb.com> wrote:
>>
>>> Hi
>>>
>>> On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi
> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page  wrote:
>
>>
>>
>> On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Sr. Software Engineer*
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Thu, Aug 24, 2017 at 9:44 PM, Dave Page 
>>> wrote:
>>>


 On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar <
 surinder.ku...@enterprisedb.com> wrote:

> Hi Dave,
>
> On Thu, Aug 24, 2017 at 2:28 PM, Dave Page 
> wrote:
>
>> Anyone object to doing a release on 14th September, wrapping the
>> code on Monday 11th? This seems like the best option for our QA 
>> folks who
>> will be off for EID somewhen in the two weeks before.
>>
>> Assuming not, should this be 1.7 or 2.0?
>>
>> If we go with 2.0, it'll be for "safety" given the proposed
>> changes to path management to allow both server and desktop modes to 
>> work
>> out of the box on Linux.
>>
>> If we do that, we also need to ensure that any changes to the
>> config database are backwards compatible, as a 2.0 release would be a
>> side-by-side installation. Surinder; was it you that had looked into 
>> that?
>>
> I had looked into this and here are my findings:
> 1. If we are using newer version of pgAdmin and the go back to
> older version of pgAdmin, then on running `python pgAdmin4.py`. the
> flask-migrate(Alembic) try to perform downgrade by one step only(ie. 
> it can
> switch back to one migration only when we run  `python pgAdmin4.py`). 
> But
> we have multiple database revisions to be migrated. So migration 
> fails here.
>
> 2. When Alebmic downgrade is performed by one step, it looks for
> downgrade function in that specific database revision, but in our 
> code we
> didn't written downgrade function. But if we have written downgrade
> statement, still there is an issue:
> ie. If we add a new column to a table xyz using ALTER statement
> like:
>
> ```
> 
> def upgrade():
> 
> verison = get_version()
>
> 
> db.engine.execute(
> 
> 'ALTER TABLE server ADD COLUMN hostaddr TEXT(1024)'
>  
> )
>
> def downgrade():
> 
> pass
> ```
> then on downgrade it executes `downgrade` method, so downgrade
> should have code like
> `ALTER TABLE server DROP COLUMN hostaddr `
> but in sqlite DROP COLUMN statements don't work.
> So, this is a an issue with Sqlite database. However, an
> alternative way is also given. Here is link
> 
>
>
> Still, I didn't find any other solution on upgrading/downgrading
> database revisions without errors.
> It is an issue with Flask-Migrate(Alembic) plugin.
>


 Urgh. So I guess the other option is that we version the DB
 filename as well. The downside of that is that users will want to 
 migrate
 their settings - which may be awkward as we'll have no real way of 
 knowing
 where they are.

 Thoughts?

 Or should we write our own custom backword migrations? For eg.
>>> dropping  column can be achieved by creating another table excluding the
>>> columns which we want to drop then copy data to new table and then drop 
>>> old
>>> table and rename new table to old name. And also sqlite database schema
>>> which we have in pgAdmin4 is small so writing and maintaining custom
>>> migration won be that hard.
>>>
>>
>> The problem is that we don't want to migrate backwards; we want both
>> versions to be able to r

Re: pgAdmin4: Random failure of FTS test cases due to improper random string creation

2017-08-25 Thread Dave Page

Thanks, patch applied.

On Fri, Aug 25, 2017 at 6:47 AM, Navnath Gadakh <
navnath.gad...@enterprisedb.com> wrote:

> Hi Dave,
>
>   Please find the attached patch. The code added to tear down the FTS
> related objects. As this issue was random, I have tested this patch on all
> 12 servers (pg/ppas) with multiple time and got no errors.
>
> Thanks.
>
>
> On Fri, Aug 18, 2017 at 1:35 PM, Dave Page 
> wrote:
>
>>
>>
>> On Fri, Aug 18, 2017 at 4:54 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Fri, Aug 11, 2017 at 1:24 PM, Navnath Gadakh <
>>> navnath.gad...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Please find the attached patch for UUID creation issues with
 test objects for FTS configurations, FTS dictionaries and FTS parsers.
 Previously(refer email with subject "Build failed in Jenkins:
 pgadmin4-master-python27 #279" and "Build failed in Jenkins:
 pgadmin4-master-python33 #207"), test cases were randomly failing due to
 repetitions of the test object names.

 In the old code we used some part of the string for creating a UUID
 string, but it seems that at some point that created string gets repeated
 and due to which test cases were failing as this was a random behavior, now
 it is fixed.

>>> Navnath,
>>>
>>> We're still not removing the temporary objects, created by test-cases,
>>> in the tear-down function.
>>> We should have removed them in the tear-down function to fix the issue
>>> in proper way.
>>>
>>> Dave - thoughts?
>>>
>>
>> Right - it only seems to be FTS and FDW related objects that suffer from
>> this problem from what I can see, so I assume we're getting it right for
>> everything else by removing objects in the tear-down.
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>
>
>
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-25 Thread Dave Page

Hi

On Thu, Aug 24, 2017 at 9:02 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to allow user to provide custom path for SSL certificates and
> also allow user to pass .pgpass file when making server connection.
> RM#2649
> RM#2650
>
> *SSL certificates options reference:*
> https://www.postgresql.org/docs/10/static/libpq-connect.html
> https://www.postgresql.org/docs/9.1/static/ssl-tcp.html
>
> *.pgpass file reference:*
> https://www.postgresql.org/docs/10/static/libpq-pgpass.html
>

Nice! A few comments:

- Should we enable the certificate options for "Prefer" mode? What did we
do in pgAdmin 3?

- We need a doc update :-). Please include updates to all the screenshots
on the relevant page, to ensure they all show the right tabs.

- I think the file browser needs an option to view hidden files/folders.
Typically a pgpass file is at ~/.pgpass on *nix systems, and certificates
are likely to be stored in ~/.ssh.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM2586] Cleanup feature test

2017-08-25 Thread Dave Page

Hi

On Thu, Aug 24, 2017 at 11:51 AM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Last week Sarah, Matt and I had call regarding some issues with feature
> test cases.
> For example in auto commit disable test scenario from query tool test
> cases by removing code line
> *self.page.find_by_id("btn-auto-commit").click() *the test case scenario
> was not falling.
> This issue was due to previously on going database transaction. This issue
> was also with test scenarios like
> auto commit enable and auto rollback enabled. The attached patch fixes
> this issue.
>
> @Sarah and Matt can you please give this patch a try to check if issues we
> discussed last week are fixed.
>

I don't think Matt and Sarah are working on pgAdmin any more :-(

I just tried this patch, and whilst the tests all passed, it spent quite
some time typing "select * from hats" into random places in the query tool,
such that it ended up running queries like

select * select * select * from hats from hats from hats

I don't remember it doing that before; I think it was a) clearing
codemirror each time and b) entering the text much more quickly (in fact I
just tried it, and it enters the text and executes the query so fast the
screen basically strobes).

Performance-wise, I got 266 seconds with the patch, and 378 without, so
there's definitely some good improvement here, just a little funkyness with
the query tool journey test.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to provide custom SSL certificates and provide .pgpass file

2017-08-25 Thread Murtuza Zabuawala

Hi Dave,

On Fri, Aug 25, 2017 at 2:14 PM, Dave Page  wrote:

> Hi
>
> On Thu, Aug 24, 2017 at 9:02 AM, Murtuza Zabuawala  enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to allow user to provide custom path for SSL certificates and
>> also allow user to pass .pgpass file when making server connection.
>> RM#2649
>> RM#2650
>>
>> *SSL certificates options reference:*
>> https://www.postgresql.org/docs/10/static/libpq-connect.html
>> https://www.postgresql.org/docs/9.1/static/ssl-tcp.html
>>
>> *.pgpass file reference:*
>> https://www.postgresql.org/docs/10/static/libpq-pgpass.html
>>
>
> Nice! A few comments:
>
> - Should we enable the certificate options for "Prefer" mode? What did we
> do in pgAdmin 3?
>
In pgAdmin3, all SSL options are enabled for each mode.
Yes, we should also consider 'prefer' mode.

>
> - We need a doc update :-). Please include updates to all the screenshots
> on the relevant page, to ensure they all show the right tabs.
>
Sure, will sent it in next patch.

>
> - I think the file browser needs an option to view hidden files/folders.
> Typically a pgpass file is at ~/.pgpass on *nix systems, and certificates
> are likely to be stored in ~/.ssh.
>
Let me check the file manager code, I will update on this.


>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

pgAdmin 4 commit: Bump the version number for 2.0. Let's get testing st

2017-08-25 Thread Dave Page

Bump the version number for 2.0. Let's get testing started ASAP!

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb9eee47bd9b2745b613336f0c4ef76d19fe2bde

Modified Files
--
runtime/Info.plist   |  4 ++--
runtime/pgAdmin4.pro |  2 +-
web/config.py| 10 --
3 files changed, 7 insertions(+), 9 deletions(-)

Re: Next release

2017-08-25 Thread Surinder Kumar

Hi

On Fri, Aug 25, 2017 at 2:04 PM, Dave Page  wrote:

>
>
> On Fri, Aug 25, 2017 at 9:28 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> One more thing that this will only work for future pgAdmin4 versions
>>
>
>
> Yeah :-(
>
>
>>
>> --
>> *Harshal Dhumal*
>> *Sr. Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Aug 25, 2017 at 1:48 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Fri, Aug 25, 2017 at 9:15 AM, Surinder Kumar <
>>> surinder.ku...@enterprisedb.com> wrote:
>>>
 Hi

 On Fri, Aug 25, 2017 at 12:21 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Fri, Aug 25, 2017 at 12:16 PM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi
>> On Fri, Aug 25, 2017 at 1:03 AM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Aug 24, 2017 at 8:28 PM, Harshal Dhumal <
>>> harshal.dhu...@enterprisedb.com> wrote:
>>>


 --
 *Harshal Dhumal*
 *Sr. Software Engineer*

 EnterpriseDB India: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Thu, Aug 24, 2017 at 9:44 PM, Dave Page 
 wrote:

>
>
> On Thu, Aug 24, 2017 at 10:36 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> On Thu, Aug 24, 2017 at 2:28 PM, Dave Page 
>> wrote:
>>
>>> Anyone object to doing a release on 14th September, wrapping the
>>> code on Monday 11th? This seems like the best option for our QA 
>>> folks who
>>> will be off for EID somewhen in the two weeks before.
>>>
>>> Assuming not, should this be 1.7 or 2.0?
>>>
>>> If we go with 2.0, it'll be for "safety" given the proposed
>>> changes to path management to allow both server and desktop modes 
>>> to work
>>> out of the box on Linux.
>>>
>>> If we do that, we also need to ensure that any changes to the
>>> config database are backwards compatible, as a 2.0 release would be 
>>> a
>>> side-by-side installation. Surinder; was it you that had looked 
>>> into that?
>>>
>> I had looked into this and here are my findings:
>> 1. If we are using newer version of pgAdmin and the go back to
>> older version of pgAdmin, then on running `python pgAdmin4.py`. the
>> flask-migrate(Alembic) try to perform downgrade by one step only(ie. 
>> it can
>> switch back to one migration only when we run  `python 
>> pgAdmin4.py`). But
>> we have multiple database revisions to be migrated. So migration 
>> fails here.
>>
>> 2. When Alebmic downgrade is performed by one step, it looks for
>> downgrade function in that specific database revision, but in our 
>> code we
>> didn't written downgrade function. But if we have written downgrade
>> statement, still there is an issue:
>> ie. If we add a new column to a table xyz using ALTER statement
>> like:
>>
>> ```
>> 
>> def upgrade():
>> 
>> verison = get_version()
>>
>> 
>> db.engine.execute(
>> 
>> 'ALTER TABLE server ADD COLUMN hostaddr TEXT(1024)'
>>  
>> )
>>
>> def downgrade():
>> 
>> pass
>> ```
>> then on downgrade it executes `downgrade` method, so downgrade
>> should have code like
>> `ALTER TABLE server DROP COLUMN hostaddr `
>> but in sqlite DROP COLUMN statements don't work.
>> So, this is a an issue with Sqlite database. However, an
>> alternative way is also given. Here is link
>> 
>>
>>
>> Still, I didn't find any other solution on upgrading/downgrading
>> database revisions without errors.
>> It is an issue with Flask-Migrate(Alembic) plugin.
>>
>
>
> Urgh. So I guess the other option is that we version the DB
> filename as well. The downside of that is that users will want to 
> migrate
> their settings - which may be awkward as we'll have no real way of 
> knowing
> where they are.
>
> Thoughts?
>
> Or should we write our own custom backword migrations? For eg.
 dropping  column can be achieved by creating another table excluding 
 the
 columns which we want to drop then copy data to new table and then 
 drop old
 table and rename new table to old name. And also sqlite database schema
>

pgAdmin 4 commit: Ship with pre-configured paths that can work in both

2017-08-25 Thread Dave Page

Ship with pre-configured paths that can work in both Server and Desktop modes 
out of the box. Fixes #2662

Ship the web code using server mode with appropriate paths by default and 
enable the runtime to override the mode, and force into desktop changing the 
appropriate paths to user-specific ones.

Note that this change will likely cause more advanced users to have to tweak 
configs.

RPMs will also need changes to create /var/lib/pgadmin and /var/log/pgadmin, 
owned by the webserver account.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f195b18f2d9145592ae60c55840405dc3dfc8ea6

Modified Files
--
runtime/Server.cpp |   3 +-
web/config.py  | 106 +++--
web/pgAdmin4.py|  11 +
web/regression/runtests.py |  11 +
4 files changed, 89 insertions(+), 42 deletions(-)

Re: pgAdmin 4 commit: Ship with pre-configured paths that can work in both

2017-08-25 Thread Dave Page

All,

Please note, this patch will probably break your dev environments :-). You
may need to override a few more things in config_local.py, or as in my
case, remove a few things.

Devrim; we'll need RPM changes for this. We need to work together to
thoroughly test those changes. Please book time in my calendar to
collaborate.

On Fri, Aug 25, 2017 at 10:54 AM, Dave Page  wrote:

> Ship with pre-configured paths that can work in both Server and Desktop
> modes out of the box. Fixes #2662
>
> Ship the web code using server mode with appropriate paths by default and
> enable the runtime to override the mode, and force into desktop changing
> the appropriate paths to user-specific ones.
>
> Note that this change will likely cause more advanced users to have to
> tweak configs.
>
> RPMs will also need changes to create /var/lib/pgadmin and
> /var/log/pgadmin, owned by the webserver account.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> f195b18f2d9145592ae60c55840405dc3dfc8ea6
>
> Modified Files
> --
> runtime/Server.cpp |   3 +-
> web/config.py  | 106 +++---
> ---
> web/pgAdmin4.py|  11 +
> web/regression/runtests.py |  11 +
> 4 files changed, 89 insertions(+), 42 deletions(-)
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python36 #291

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Bump the version number for 2.0. Let's get testing started ASAP!

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

--
[...truncated 360.46 KB...]
[33m25 08 2017 10:06:45.688:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 121 of 304 SUCCESS (0 secs / 
3.084 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 122 of 304 SUCCESS (0 secs / 
3.101 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 123 of 304 SUCCESS (0 secs / 
3.105 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 124 of 304 SUCCESS (0 secs / 
3.109 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 125 of 304 SUCCESS (0 secs / 
3.118 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 126 of 304 SUCCESS (0 secs / 
3.122 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 127 of 304 SUCCESS (0 secs / 
3.127 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 128 of 304 SUCCESS (0 secs / 
3.132 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 129 of 304 SUCCESS (0 secs / 
3.137 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 130 of 304 SUCCESS (0 secs / 
3.142 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 131 of 304 SUCCESS (0 secs / 
3.147 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 132 of 304 SUCCESS (0 secs / 
3.152 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 133 of 304 SUCCESS (0 secs / 
3.157 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 134 of 304 SUCCESS (0 secs / 
3.162 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 135 of 304 SUCCESS (0 secs / 
3.167 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 304 SUCCESS (0 secs / 
3.176 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 137 of 304 SUCCESS (0 secs / 
3.191 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 138 of 304 SUCCESS (0 secs / 
3.202 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 139 of 304 SUCCESS (0 secs / 
3.213 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 140 of 304 SUCCESS (0 secs / 
3.224 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 141 of 304 SUCCESS (0 secs / 
3.235 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 142 of 304 SUCCESS (0 secs / 
3.269 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 143 of 304 SUCCESS (0 secs / 
3.284 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 144 of 304 SUCCESS (0 secs / 
3.305 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 145 of 304 SUCCESS (0 secs / 
3.324 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 146 of 304 SUCCESS (0 secs / 
3.341 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 147 of 304 SUCCESS (0 secs / 
3.358 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 304 SUCCESS (0 secs / 
3.376 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 149 of 304 SUCCESS (0 secs / 
3.394 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 150 of 304 SUCCESS (0 secs / 
3.413 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 151 of 304 SUCCESS (0 secs / 
3.43 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 152 of 304 SUCCESS (0 secs / 
3.446 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 153 of 304 SUCCESS (0 secs / 
3.462 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 154 of 304 SUCCESS (0 secs / 
3.479 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 155 of 304 SUCCESS (0 secs / 
3.495 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 156 of 304 SUCCESS (0 secs / 
3.512 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 157 of 304 SUCCESS (0 secs / 
3.528 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 158 of 304 SUCCESS (0 secs / 
3.543 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 159 of 304 SUCCESS (0 secs / 
3.558 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 160 of 304 SUCCESS (0 secs / 
3.574 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 161 of 304 SUCCESS (0 secs / 
3.59 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 162 of 304 SUCCESS (0 secs / 
3.607 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 163 of 304 SUCCESS (0 secs / 
3.614 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 164 of 304 SUCCESS (0 secs / 
3.62 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 165 of 304 SUCCESS (0 secs / 
3.625 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 166 of 304 SUCCESS (0 secs / 
3.631 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 167 of 304 SUCCESS (0 secs / 
3.637 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 168 of 304 SUCCESS (0 secs / 
3.642 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 169 of 304 SUCCESS (0 secs / 
3.648 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 170 of 304 SUCCESS (0 secs / 
3.654 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 171 of

Re: pgAdmin 4 commit: Ship with pre-configured paths that can work in both

2017-08-25 Thread Devrim Gündüz


Hi Dave,

On Fri, 2017-08-25 at 10:59 +0100, Dave Page wrote:

> Devrim; we'll need RPM changes for this. We need to work together to
> thoroughly test those changes. Please book time in my calendar to
> collaborate.

Ack.

Regards,
-- 
Devrim Gündüz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


signature.asc
Description: This is a digitally signed message part

Build failed in Jenkins: pgadmin4-master-python26 #416

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Bump the version number for 2.0. Let's get testing started ASAP!

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

--
[...truncated 364.05 KB...]
[33m25 08 2017 10:12:40.933:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 119 of 304 SUCCESS (0 secs / 
3.03 secs)
[33m25 08 2017 10:12:40.950:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 120 of 304 SUCCESS (0 secs / 
3.046 secs)
[33m25 08 2017 10:12:40.966:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 121 of 304 SUCCESS (0 secs / 
3.062 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 122 of 304 SUCCESS (0 secs / 
3.079 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 123 of 304 SUCCESS (0 secs / 
3.084 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 124 of 304 SUCCESS (0 secs / 
3.089 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 125 of 304 SUCCESS (0 secs / 
3.098 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 126 of 304 SUCCESS (0 secs / 
3.103 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 127 of 304 SUCCESS (0 secs / 
3.108 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 128 of 304 SUCCESS (0 secs / 
3.113 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 129 of 304 SUCCESS (0 secs / 
3.117 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 130 of 304 SUCCESS (0 secs / 
3.121 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 131 of 304 SUCCESS (0 secs / 
3.127 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 132 of 304 SUCCESS (0 secs / 
3.132 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 133 of 304 SUCCESS (0 secs / 
3.137 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 134 of 304 SUCCESS (0 secs / 
3.141 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 135 of 304 SUCCESS (0 secs / 
3.145 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 304 SUCCESS (0 secs / 
3.153 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 137 of 304 SUCCESS (0 secs / 
3.166 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 138 of 304 SUCCESS (0 secs / 
3.177 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 139 of 304 SUCCESS (0 secs / 
3.188 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 140 of 304 SUCCESS (0 secs / 
3.198 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 141 of 304 SUCCESS (0 secs / 
3.209 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 142 of 304 SUCCESS (0 secs / 
3.243 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 143 of 304 SUCCESS (0 secs / 
3.258 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 144 of 304 SUCCESS (0 secs / 
3.276 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 145 of 304 SUCCESS (0 secs / 
3.296 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 146 of 304 SUCCESS (0 secs / 
3.313 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 147 of 304 SUCCESS (0 secs / 
3.33 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 304 SUCCESS (0 secs / 
3.348 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 149 of 304 SUCCESS (0 secs / 
3.366 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 150 of 304 SUCCESS (0 secs / 
3.385 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 151 of 304 SUCCESS (0 secs / 
3.401 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 152 of 304 SUCCESS (0 secs / 
3.417 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 153 of 304 SUCCESS (0 secs / 
3.433 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 154 of 304 SUCCESS (0 secs / 
3.451 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 155 of 304 SUCCESS (0 secs / 
3.498 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 156 of 304 SUCCESS (0 secs / 
3.518 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 157 of 304 SUCCESS (0 secs / 
3.535 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 158 of 304 SUCCESS (0 secs / 
3.55 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 159 of 304 SUCCESS (0 secs / 
3.564 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 160 of 304 SUCCESS (0 secs / 
3.58 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 161 of 304 SUCCESS (0 secs / 
3.605 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 162 of 304 SUCCESS (0 secs / 
3.622 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 163 of 304 SUCCESS (0 secs / 
3.629 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 164 of 304 SUCCESS (0 secs / 
3.635 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 165 of 304 SUCCESS (0 secs / 
3.64 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 166 of 304 SUCCESS (0 secs / 
3.646 secs)
[1A[2KPhantomJS 2.1.1 (Lin

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is present so the docs bu

2017-08-25 Thread Dave Page

Ensure builtins.SERVER_MODE is present so the docs build cleanly.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0e5ea582943dd345c6b5e62a1d5213f89f6ca834

Modified Files
--
docs/en_US/build_code_snippet.py | 8 
docs/en_US/conf.py   | 8 
2 files changed, 16 insertions(+)

Build failed in Jenkins: pgadmin4-master-python35 #293

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

--
[...truncated 360.50 KB...]
[33m25 08 2017 10:19:02.541:WARN [web-server]: [39m404: 
/base/pgadmin/static/img/select-all-icon.png
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 121 of 304 SUCCESS (0 secs / 
2.96 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 122 of 304 SUCCESS (0 secs / 
2.977 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 123 of 304 SUCCESS (0 secs / 
2.982 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 124 of 304 SUCCESS (0 secs / 
2.987 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 125 of 304 SUCCESS (0 secs / 
2.996 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 126 of 304 SUCCESS (0 secs / 
3.001 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 127 of 304 SUCCESS (0 secs / 
3.006 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 128 of 304 SUCCESS (0 secs / 
3.011 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 129 of 304 SUCCESS (0 secs / 
3.015 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 130 of 304 SUCCESS (0 secs / 
3.019 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 131 of 304 SUCCESS (0 secs / 
3.024 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 132 of 304 SUCCESS (0 secs / 
3.029 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 133 of 304 SUCCESS (0 secs / 
3.063 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 134 of 304 SUCCESS (0 secs / 
3.068 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 135 of 304 SUCCESS (0 secs / 
3.073 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 304 SUCCESS (0 secs / 
3.081 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 137 of 304 SUCCESS (0 secs / 
3.096 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 138 of 304 SUCCESS (0 secs / 
3.107 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 139 of 304 SUCCESS (0 secs / 
3.118 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 140 of 304 SUCCESS (0 secs / 
3.128 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 141 of 304 SUCCESS (0 secs / 
3.139 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 142 of 304 SUCCESS (0 secs / 
3.182 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 143 of 304 SUCCESS (0 secs / 
3.197 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 144 of 304 SUCCESS (0 secs / 
3.216 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 145 of 304 SUCCESS (0 secs / 
3.236 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 146 of 304 SUCCESS (0 secs / 
3.253 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 147 of 304 SUCCESS (0 secs / 
3.271 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 304 SUCCESS (0 secs / 
3.29 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 149 of 304 SUCCESS (0 secs / 
3.31 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 150 of 304 SUCCESS (0 secs / 
3.33 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 151 of 304 SUCCESS (0 secs / 
3.347 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 152 of 304 SUCCESS (0 secs / 
3.364 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 153 of 304 SUCCESS (0 secs / 
3.38 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 154 of 304 SUCCESS (0 secs / 
3.398 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 155 of 304 SUCCESS (0 secs / 
3.414 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 156 of 304 SUCCESS (0 secs / 
3.43 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 157 of 304 SUCCESS (0 secs / 
3.447 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 158 of 304 SUCCESS (0 secs / 
3.463 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 159 of 304 SUCCESS (0 secs / 
3.478 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 160 of 304 SUCCESS (0 secs / 
3.494 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 161 of 304 SUCCESS (0 secs / 
3.509 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 162 of 304 SUCCESS (0 secs / 
3.525 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 163 of 304 SUCCESS (0 secs / 
3.531 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 164 of 304 SUCCESS (0 secs / 
3.536 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 165 of 304 SUCCESS (0 secs / 
3.542 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 166 of 304 SUCCESS (0 secs / 
3.548 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 167 of 304 SUCCESS (0 secs / 
3.553 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 168 of 304 SUCCESS (0 secs / 
3.558 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 169 of 304 SUCCESS (0 secs / 
3.564 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 170 of 304 SUCCESS (0 secs / 
3.569 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 171 of 304 SUCCESS (0 secs / 
3.574 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Execut

Build failed in Jenkins: pgadmin4-master-python27 #295

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

--
[...truncated 361.47 KB...]
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 122 of 304 SUCCESS (0 secs / 
3.005 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 123 of 304 SUCCESS (0 secs / 
3.01 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 124 of 304 SUCCESS (0 secs / 
3.015 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 125 of 304 SUCCESS (0 secs / 
3.024 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 126 of 304 SUCCESS (0 secs / 
3.029 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 127 of 304 SUCCESS (0 secs / 
3.034 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 128 of 304 SUCCESS (0 secs / 
3.039 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 129 of 304 SUCCESS (0 secs / 
3.044 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 130 of 304 SUCCESS (0 secs / 
3.048 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 131 of 304 SUCCESS (0 secs / 
3.053 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 132 of 304 SUCCESS (0 secs / 
3.058 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 133 of 304 SUCCESS (0 secs / 
3.063 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 134 of 304 SUCCESS (0 secs / 
3.068 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 135 of 304 SUCCESS (0 secs / 
3.073 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 304 SUCCESS (0 secs / 
3.082 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 137 of 304 SUCCESS (0 secs / 
3.095 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 138 of 304 SUCCESS (0 secs / 
3.106 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 139 of 304 SUCCESS (0 secs / 
3.117 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 140 of 304 SUCCESS (0 secs / 
3.127 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 141 of 304 SUCCESS (0 secs / 
3.138 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 142 of 304 SUCCESS (0 secs / 
3.171 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 143 of 304 SUCCESS (0 secs / 
3.186 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 144 of 304 SUCCESS (0 secs / 
3.205 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 145 of 304 SUCCESS (0 secs / 
3.225 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 146 of 304 SUCCESS (0 secs / 
3.242 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 147 of 304 SUCCESS (0 secs / 
3.259 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 304 SUCCESS (0 secs / 
3.31 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 149 of 304 SUCCESS (0 secs / 
3.33 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 150 of 304 SUCCESS (0 secs / 
3.35 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 151 of 304 SUCCESS (0 secs / 
3.368 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 152 of 304 SUCCESS (0 secs / 
3.385 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 153 of 304 SUCCESS (0 secs / 
3.41 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 154 of 304 SUCCESS (0 secs / 
3.427 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 155 of 304 SUCCESS (0 secs / 
3.442 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 156 of 304 SUCCESS (0 secs / 
3.457 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 157 of 304 SUCCESS (0 secs / 
3.473 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 158 of 304 SUCCESS (0 secs / 
3.488 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 159 of 304 SUCCESS (0 secs / 
3.503 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 160 of 304 SUCCESS (0 secs / 
3.519 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 161 of 304 SUCCESS (0 secs / 
3.534 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 162 of 304 SUCCESS (0 secs / 
3.55 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 163 of 304 SUCCESS (0 secs / 
3.558 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 164 of 304 SUCCESS (0 secs / 
3.563 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 165 of 304 SUCCESS (0 secs / 
3.568 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 166 of 304 SUCCESS (0 secs / 
3.574 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 167 of 304 SUCCESS (0 secs / 
3.579 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 168 of 304 SUCCESS (0 secs / 
3.584 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 169 of 304 SUCCESS (0 secs / 
3.589 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 170 of 304 SUCCESS (0 secs / 
3.595 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 171 of 304 SUCCESS (0 secs / 
3.6 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 172 of 304 SUCCESS (0 secs / 
3.606 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 173 of 304 SUCCESS (0 secs / 
3.611 secs)
[1A[2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 174 of 304 SU

Build failed in Jenkins: pgadmin4-master-python34 #287

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

--
[...truncated 797.39 KB...]
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_sql.png
Adding en_US/images/schema_default_privileges.png
Adding en_US/images/schema_general.png
Adding en_US/images/schema_security.png
Adding en_US/images/schema_sql.png
Adding en_US/images/schema_sq

pgAdmin 4 commit: Branch refs/heads/REL-1_X was created

2017-08-25 Thread git

Branch refs/heads/REL-1_X was created.

View: 
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=shortlog;h=refs/heads/REL-1_X

Build failed in Jenkins: pgadmin4-master-python33 #295

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

--
[...truncated 795.67 KB...]
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_sql.png
Adding en_US/images/schema_default_privileges.png
Adding en_US/images/schema_general.png
Adding en_US/images/schema_security.png
Adding en_US/images/schema_sql.png
Adding en_US/images/schema_sql_example.png
Adding en_US/images/

Build failed in Jenkins: pgadmin4-master-python35 #294

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

--
[...truncated 797.09 KB...]
Adding en_US/images/index_general.png
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_sql.png
Adding en_US/images/schema_default_privileges.png
Adding en_US/images/schema_general.png
Adding en_US/images/schema_security.png
Adding en_US/images/schema_sql.png
Adding en_US/images/schema_sql_example.png
Adding en_US/images/sequence_defin

pgAdmin 4 commit: Regression tests aren't run under the runtime, so no

2017-08-25 Thread Dave Page

Regression tests aren't run under the runtime, so no need to check for 
builtins.SERVER_MODE's existence.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=507d8b3fe41fcb7d402822f3b02c0b2cbc85f7b7

Modified Files
--
web/regression/runtests.py | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)

pgAdmin 4 commit: Ensure builtins.SERVER_MODE is handled if running set

2017-08-25 Thread Dave Page

Ensure builtins.SERVER_MODE is handled if running setup.py standalone.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a65f7b330b48b83adfde0ca661c0e6ec9f05909b

Modified Files
--
web/setup.py | 10 ++
1 file changed, 10 insertions(+)

Build failed in Jenkins: pgadmin4-master-python26 #417

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

--
[...truncated 816.81 KB...]
Adding en_US/images/import_export_pw.png
Adding en_US/images/index_definition.png
Adding en_US/images/index_general.png
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_sql.png
Adding en_US/images/schema_default_privileges.png
Adding en_US/images/schema_general.png
Adding en_US/images/schema_security.png
Adding en_US/images/schema_sql

Build failed in Jenkins: pgadmin4-master-python36 #292

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

[Dave Page] Regression tests aren't run under the runtime, so no need to check 
for

[Dave Page] Ensure builtins.SERVER_MODE is handled if running setup.py 
standalone.

--
[...truncated 797.00 KB...]
Adding en_US/images/index_general.png
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_sql.png
Adding en_US/images/schema_default_privileges.png
Adding en_US/images/s

pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

2017-08-25 Thread Dave Page

Update docs to more accurately reflect the SERVER_MODE config requirements.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c016f0993fb557052cce7e11cd6ad818bd7c3a3

Modified Files
--
docs/en_US/desktop_deployment.rst | 39 ++-
docs/en_US/server_deployment.rst  | 18 --
2 files changed, 18 insertions(+), 39 deletions(-)

Build failed in Jenkins: pgadmin4-master-python27 #296

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

[Dave Page] Regression tests aren't run under the runtime, so no need to check 
for

[Dave Page] Ensure builtins.SERVER_MODE is handled if running setup.py 
standalone.

--
[...truncated 799.80 KB...]
Adding en_US/images/import_export_columns.png
Adding en_US/images/import_export_complete.png
Adding en_US/images/import_export_miscellaneous.png
Adding en_US/images/import_export_options.png
Adding en_US/images/import_export_pw.png
Adding en_US/images/index_definition.png
Adding en_US/images/index_general.png
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/

Re: pgAdmin 4 commit: Update docs to more accurately reflect the SERVER_MOD

2017-08-25 Thread Dave Page

Akshay, Ashesh,

I've committed these doc changes to reflect the paths/SERVER_MODE changes.
Could you both please review them and let me know if I missed anything of
importance, or if anything isn't clear?

Thanks.

On Fri, Aug 25, 2017 at 12:13 PM, Dave Page  wrote:

> Update docs to more accurately reflect the SERVER_MODE config requirements.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 5c016f0993fb557052cce7e11cd6ad818bd7c3a3
>
> Modified Files
> --
> docs/en_US/desktop_deployment.rst | 39 ++
> -
> docs/en_US/server_deployment.rst  | 18 --
> 2 files changed, 18 insertions(+), 39 deletions(-)
>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure the SERVER_MODE changes don't break the PIP bu

2017-08-25 Thread Dave Page

Ensure the SERVER_MODE changes don't break the PIP build.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=857990955864ebc78697e6de0455c45a36571907

Modified Files
--
pkg/pip/setup_pip.py | 8 
1 file changed, 8 insertions(+)

Build failed in Jenkins: pgadmin4-master-python26 #418

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Regression tests aren't run under the runtime, so no need to check 
for

[Dave Page] Ensure builtins.SERVER_MODE is handled if running setup.py 
standalone.

[Dave Page] Update docs to more accurately reflect the SERVER_MODE config

--
[...truncated 817.84 KB...]
Adding en_US/images/import_export_pw.png
Adding en_US/images/index_definition.png
Adding en_US/images/index_general.png
Adding en_US/images/index_sql.png
Adding en_US/images/language_definition.png
Adding en_US/images/language_general.png
Adding en_US/images/language_security.png
Adding en_US/images/language_sql.png
Adding en_US/images/logo-128.png
Adding en_US/images/logo-right-128.png
Adding en_US/images/main_dashboard.png
Adding en_US/images/main_dependencies.png
Adding en_US/images/main_dependents.png
Adding en_US/images/main_left_pane.png
Adding en_US/images/main_properties_edit.png
Adding en_US/images/main_properties_icons.png
Adding en_US/images/main_properties_table.png
Adding en_US/images/main_query_tool.png
Adding en_US/images/main_sql.png
Adding en_US/images/main_statistics.png
Adding en_US/images/maintenance.png
Adding en_US/images/maintenance_complete.png
Adding en_US/images/maintenance_pw.png
Adding en_US/images/materialized_view_definition.png
Adding en_US/images/materialized_view_general.png
Adding en_US/images/materialized_view_parameter.png
Adding en_US/images/materialized_view_security.png
Adding en_US/images/materialized_view_sql.png
Adding en_US/images/materialized_view_storage.png
Adding en_US/images/move_objects_general.png
Adding en_US/images/move_objects_sql.png
Adding en_US/images/object_menu.png
Adding en_US/images/package_code.png
Adding en_US/images/package_general.png
Adding en_US/images/package_security.png
Adding en_US/images/package_sql.png
Adding en_US/images/password.png
Adding en_US/images/pgadmin_login.png
Adding en_US/images/pgadmin_login_recover.png
Adding en_US/images/pgadmin_user.png
Adding en_US/images/pgadmin_welcome.png
Adding en_US/images/pgagent_general.png
Adding en_US/images/pgagent_properties.png
Adding en_US/images/pgagent_schedule_definition.png
Adding en_US/images/pgagent_schedule_exceptions.png
Adding en_US/images/pgagent_schedule_repeat.png
Adding en_US/images/pgagent_schedules.png
Adding en_US/images/pgagent_sql.png
Adding en_US/images/pgagent_step_definition.png
Adding en_US/images/pgagent_step_definition_code.png
Adding en_US/images/pgagent_steps.png
Adding en_US/images/preferences_browser_display.png
Adding en_US/images/preferences_browser_nodes.png
Adding en_US/images/preferences_dashboard_graphs.png
Adding en_US/images/preferences_paths_binary.png
Adding en_US/images/preferences_paths_help.png
Adding en_US/images/preferences_sql_display.png
Adding en_US/images/preferences_sql_explain_options.png
Adding en_US/images/preferences_sql_options.png
Adding en_US/images/preferences_storage_options.png
Adding en_US/images/preferences_tree.png
Adding en_US/images/primary_key_definition.png
Adding en_US/images/primary_key_general.png
Adding en_US/images/primary_key_sql.png
Adding en_US/images/procedure_arguments.png
Adding en_US/images/procedure_definition.png
Adding en_US/images/procedure_general.png
Adding en_US/images/procedure_options.png
Adding en_US/images/procedure_parameters.png
Adding en_US/images/procedure_security.png
Adding en_US/images/procedure_sql.png
Adding en_US/images/procedure_sql_example.png
Adding en_US/images/query_autocomplete.png
Adding en_US/images/query_execute_section.png
Adding en_US/images/query_output_confirm.png
Adding en_US/images/query_output_data.png
Adding en_US/images/query_output_error.png
Adding en_US/images/query_output_explain.png
Adding en_US/images/query_output_explain_details.png
Adding en_US/images/query_output_history.png
Adding en_US/images/query_output_messages.png
Adding en_US/images/query_sql_editor.png
Adding en_US/images/query_tool.png
Adding en_US/images/query_tool_message.png
Adding en_US/images/query_toolbar.png
Adding en_US/images/resource_group_general.png
Adding en_US/images/resource_group_sql.png
Adding en_US/images/resource_group_sql_example.png
Adding en_US/images/restore_disable.png
Adding en_US/images/restore_do_not_save.png
Adding en_US/images/restore_general.png
Adding en_US/images/restore_messages.png
Adding en_US/images/restore_miscellaneous.png
Adding en_US/images/restore_objects.png
Adding en_US/images/restore_process_watcher.png
Adding en_US/images/restore_queries.png
Adding en_US/images/restore_sections.png
Adding en_US/images/role_definition.png
Adding en_US/images/role_general.png
Adding en_US/images/role_parameters.png
Adding en_US/images/role_privileges.png
Adding en_US/images/role_security.png
Adding en_US/images/role_sql.png
Adding en_US/images/role_sql_example.png
Adding en_US/images/rule_definition.png
Adding en_US/images/rule_general.png
Adding en_US/images/rule_s

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Dave Cramer

I'm suggesting that it be pushed

Dave Cramer

On 24 August 2017 at 23:00, Teng Zhang  wrote:

> Sure, you can get as much as you like.
> Thanks
>
> -- Forwarded message --
> From: Dave Cramer 
> Date: Thu, Aug 24, 2017 at 8:34 PM
> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display
> To: Teng Zhang 
> Cc: Ashesh Vashi , pgadmin-hackers <
> pgadmin-hack...@postgresql.org>, Dave Page , Jing Li <
> jin...@pivotal.io>
>
>
> Can we get some movement on this patch? This seems like a more sane way to
> go to support different "products"
>
> Dave Cramer
>
> On 22 August 2017 at 16:56, Dave Cramer  wrote:
>
>>
>> On 22 August 2017 at 16:41, Dave Cramer  wrote:
>>
>>> Ok,
>>>
>>> Surely this :
>>>
>>> self.table_template_path = 'table/sql/' + (
>>> +'#{0}#{1}#'.format(server_type, ver)
>>> +if server_type == 'gpdb' else
>>> +'#{0}#'.format(ver)
>>> +)
>>>
>>> could be written in a more readable manner ??
>>>
>>>
>>>
>> Apologies, after reading a bit, this is apparently idiomatic python.
>>
>> Please ignore
>>
>>
>>> Dave Cramer
>>>
>>> On 22 August 2017 at 14:25, Dave Cramer  wrote:
>>>
 Hi,

 I've been able to get back to this and test it. So far so good. It
 applies more or less cleanly against 1.6 and everything I've tried so far
 works

 I'll update more as I test it.

 Thanks

 Dave Cramer

 On 21 August 2017 at 05:29, Teng Zhang  wrote:

> Hi,
>
> Thanks for the review, here is a fixed patch working for GBDP which
> shows the appropriate graphs.
> In this fix, we toke out the changes to diver/psycopg2 and
> implemented the greenplum version checking process in the ppas way
> mentioned by Dave Cramer.
>
> Regards,
> Teng Zhang & Hao Wang
>
> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page  wrote:
>>
>>> Ashesh, do you have a recommended way to do this?
>>>
>>> I haven't looked at the patch, but I assume it adds a database
>>> driver module for GPDB?
>>>
>> I have not looked at the patch yet.
>> I will take a look at it.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:
>>>
 Hi Dave,

 Since we're hoping to get this change working for GPDB we've
 currently using this method to detect if it's gpdb and show the 
 appropriate
 graphs. Right now it displays errors on the dashboard if it's 
 connected to
 a gpdb server.
 For this patch specifically, the goal is to improve the experience
 for greenplum users so they can get the same information as someone
 connected to a postgres server.

 I do agree that this is a bigger discussion about how we handle
 behavior change overall if it's regular postgres or something else. 
 Let's
 talk about how we can restructure this behavior in a wider context. 
 Are you
 open to meeting about it?

 Thanks,
 ~Jing



 On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
 wrote:

> Hi Violet.
>
> I don't really like the way this has been implemented. It adds a
> variable which is only used for gpdb.
>
> There are other places in the code where the behaviour is changed
> if the server is ppas or regular postgres.
>
> Candidly I think all of this needs restructuring.
>
> Dave Cramer
>
> On 15 August 2017 at 23:29, Violet Cheng 
> wrote:
>
> Hi,
>
> Any comment on this patch? If no, will it be committed soon?
>
> Thanks,
> Violet
>
> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <
> smcal...@pivotal.io> wrote:
>
> Hi Hackers!
>
> This patch enables Greenplum users to see the same charts on the
> dashboard as postgres users. It also adds some additional information 
> to
> the DDL that is Greenplum specific and necessary to create a new 
> table.
>
> Thanks!
> Sarah
>
>
>
>
>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Ashesh Vashi

On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer  wrote:

> I'm suggesting that it be pushed
>
Akshay is already on to it, and currently reviewing it.
Will push it once get the confirmation.

-- Thanks, Ashesh

>
> Dave Cramer
>
> On 24 August 2017 at 23:00, Teng Zhang  wrote:
>
>> Sure, you can get as much as you like.
>> Thanks
>>
>> -- Forwarded message --
>> From: Dave Cramer 
>> Date: Thu, Aug 24, 2017 at 8:34 PM
>> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
>> display
>> To: Teng Zhang 
>> Cc: Ashesh Vashi , pgadmin-hackers <
>> pgadmin-hack...@postgresql.org>, Dave Page , Jing Li <
>> jin...@pivotal.io>
>>
>>
>> Can we get some movement on this patch? This seems like a more sane way
>> to go to support different "products"
>>
>> Dave Cramer
>>
>> On 22 August 2017 at 16:56, Dave Cramer  wrote:
>>
>>>
>>> On 22 August 2017 at 16:41, Dave Cramer  wrote:
>>>
 Ok,

 Surely this :

 self.table_template_path = 'table/sql/' + (
 +'#{0}#{1}#'.format(server_type, ver)
 +if server_type == 'gpdb' else
 +'#{0}#'.format(ver)
 +)

 could be written in a more readable manner ??



>>> Apologies, after reading a bit, this is apparently idiomatic python.
>>>
>>> Please ignore
>>>
>>>
 Dave Cramer

 On 22 August 2017 at 14:25, Dave Cramer  wrote:

> Hi,
>
> I've been able to get back to this and test it. So far so good. It
> applies more or less cleanly against 1.6 and everything I've tried so far
> works
>
> I'll update more as I test it.
>
> Thanks
>
> Dave Cramer
>
> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>
>> Hi,
>>
>> Thanks for the review, here is a fixed patch working for GBDP which
>> shows the appropriate graphs.
>> In this fix, we toke out the changes to diver/psycopg2 and
>> implemented the greenplum version checking process in the ppas way
>> mentioned by Dave Cramer.
>>
>> Regards,
>> Teng Zhang & Hao Wang
>>
>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page 
>>> wrote:
>>>
 Ashesh, do you have a recommended way to do this?

 I haven't looked at the patch, but I assume it adds a database
 driver module for GPDB?

>>> I have not looked at the patch yet.
>>> I will take a look at it.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> 
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> 
>>>

 On Mon, Aug 21, 2017 at 8:50 AM, Jing Li  wrote:

> Hi Dave,
>
> Since we're hoping to get this change working for GPDB we've
> currently using this method to detect if it's gpdb and show the 
> appropriate
> graphs. Right now it displays errors on the dashboard if it's 
> connected to
> a gpdb server.
> For this patch specifically, the goal is to improve the experience
> for greenplum users so they can get the same information as someone
> connected to a postgres server.
>
> I do agree that this is a bigger discussion about how we handle
> behavior change overall if it's regular postgres or something else. 
> Let's
> talk about how we can restructure this behavior in a wider context. 
> Are you
> open to meeting about it?
>
> Thanks,
> ~Jing
>
>
>
> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
> wrote:
>
>> Hi Violet.
>>
>> I don't really like the way this has been implemented. It adds a
>> variable which is only used for gpdb.
>>
>> There are other places in the code where the behaviour is changed
>> if the server is ppas or regular postgres.
>>
>> Candidly I think all of this needs restructuring.
>>
>> Dave Cramer
>>
>> On 15 August 2017 at 23:29, Violet Cheng 
>> wrote:
>>
>> Hi,
>>
>> Any comment on this patch? If no, will it be committed soon?
>>
>> Thanks,
>> Violet
>>
>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <
>> smcal...@pivotal.io> wrote:
>>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional 
>> information to
>> the DDL that is Greenplum specific and necessary to create a new 
>>

Jenkins build is back to normal : pgadmin4-master-python33 #296

2017-08-25 Thread pgAdmin 4 Jenkins

See

Jenkins build is back to normal : pgadmin4-master-python34 #288

2017-08-25 Thread pgAdmin 4 Jenkins

See

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-25 Thread Anthony DeBarros

Dave and all,

Out of curiosity (because I’m writing a book that includes pgAdmin screen
grabs), do you expect these icons to make it into your September release?

Thanks,
Anthony


On August 23, 2017 at 4:03:42 AM, Murtuza Zabuawala (
murtuza.zabuaw...@enterprisedb.com) wrote:

Hi Chethana,


On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar <
chethana.ku...@enterprisedb.com> wrote:

> Hi Murtuza,
>
> Please see my reply inline along with the updated .svg file for tree view
> icons.
>
>
> On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi Chethana,
>>
>> - The icons for Server node is missing, we will need given set of icons
>> for server.
>> 1) Basic Server icon (Disconnect state)
>> 2) PG (Connected state)
>> 3) EPAS (Connected state)
>> 4) GreenPlum (Connected state)
>> [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum
>> server icon.]
>>
>> - I'm not sure where we will use serverbad icon from
>> 'tree_view_Icons.svg' file as it looks like server-group icon and not
>> individual server.
>>
>  The icon is there in the pgAdmin's icon folder and it is needed for the
> application
>
Yes, we need serverbad icon which indicates the server in disconnect state
but what we have on svg is same icon as server-group icon, we need icon for
individual server.

[image: Inline image 1]

Something like this below which will differentiate individual server icon
from server-group icon,
[image: Inline image 6]


>> - Icon set for Schema & Catalog (both collection and individual) looks
>> very similar to each other with minor colour difference, we have to look
>> very carefully to identify them each.
>>
>  Agree with this point and come up with some updations on it. This time I
> have made it pretty differentiable between Schema and Catalog.
>
>>
>> - Why do we require two different set of icons for Tables & Columns, I
>> mean one for Schema and one for Catalog?
>>
>  Agreed, I have kept single icon for tables and columns.
>
>>
>> - Icons for Partition node is same for collection and individual.
>>
>  Working on it
>
>>
>> - Icons for Event trigger node and Trigger node are very different from
>> each other despite both are triggers.
>>
>   Agreed, done the changes accordingly.
>
This is still different.

*Current Event trigger icon:*
[image: Inline image 4]
*New*
* *
*Event trigger*
**
*Icon:*
[image: Inline image 2]


*Current Trigger icon:*

*[image: Inline image 5]*
*New Trigger Icon:*
[image: Inline image 3]
If you see both icons are same.
*[Suggestion: Can we do similar to what we have done with View &
Materialized view icons, we have added M in the icon for materialized view,
Same way we can have Trigger icon and for Event trigger we can add E in the
icon]*


> I know this is out of context but in my own opinion these icons have
>> resemblance with Flat design where as rest of our application is in 2d
>> design, for example buttons, dialogs etc.
>>
> Yes, the icons look and feel are more towards flat and stylish now as it
> represents the current trend.  You treat this as a first step towards
> making the whole application flat design from the current design. But
> this will happen in a long run, not on a quick basis.
>
>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>>
>> On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar <
>> chethana.ku...@enterprisedb.com> wrote:
>>
>>> Yes Shirley, I have already thought through on it.
>>> Basically, we need to have one more set of icons in white color mode so
>>> that we can use it on dialog headers as well.
>>> As the blue theme icons won't fit there.
>>>
>>> Please share your thoughts.
>>>
>>> Regards,
>>> Chethana kumar
>>>
>>> On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang  wrote:
>>>
 Hi Chethana,

 I just thought of something with these icons. What happens with the
 ones that appear in dialog headers? In the blue bar?

 On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
 chethana.ku...@enterprisedb.com> wrote:

> Hello Team,
>
> I have applied labels for each icon for identification purpose.  So
> please consider this copy for your feedback.
>
> *Note*: The "icon_demo.png" is attached to show case the view on
> webpage.
>
> Regards,
> Chethana kumar
>
> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hello Team,
>>
>> Here are the revised and final icons for tree view control.
>> I have attached in .svg file format as well so that you can do zoom
>> in view at any level.
>>
>> Please share your feedback on the same.
>>
>>
>> Thanks and regards,
>>
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>>

Re: pgAdmin4 - Tree view icons for final reveiw

2017-08-25 Thread Dave Page

Hi

Yes, that's my expectation. Hopefully they'll go in in the next week or so.

On Fri, Aug 25, 2017 at 12:40 PM, Anthony DeBarros 
wrote:

> Dave and all,
>
> Out of curiosity (because I’m writing a book that includes pgAdmin screen
> grabs), do you expect these icons to make it into your September release?
>
> Thanks,
> Anthony
>
>
> On August 23, 2017 at 4:03:42 AM, Murtuza Zabuawala (murtuza.zabuawala@
> enterprisedb.com) wrote:
>
> Hi Chethana,
>
>
> On Wed, Aug 23, 2017 at 12:51 PM, Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>> Please see my reply inline along with the updated .svg file for tree view
>> icons.
>>
>>
>> On Tue, Aug 22, 2017 at 11:17 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Chethana,
>>>
>>> - The icons for Server node is missing, we will need given set of icons
>>> for server.
>>> 1) Basic Server icon (Disconnect state)
>>> 2) PG (Connected state)
>>> 3) EPAS (Connected state)
>>> 4) GreenPlum (Connected state)
>>> [Attaching current icons for PG & EPAS, I'm not sure about GreenPlum
>>> server icon.]
>>>
>>> - I'm not sure where we will use serverbad icon from
>>> 'tree_view_Icons.svg' file as it looks like server-group icon and not
>>> individual server.
>>>
>>  The icon is there in the pgAdmin's icon folder and it is needed for the
>> application
>>
> Yes, we need serverbad icon which indicates the server in disconnect
> state but what we have on svg is same icon as server-group icon, we need
> icon for individual server.
>
> [image: Inline image 1]
>
> Something like this below which will differentiate individual server icon
> from server-group icon,
> [image: Inline image 6]
>
>
>>> - Icon set for Schema & Catalog (both collection and individual) looks
>>> very similar to each other with minor colour difference, we have to look
>>> very carefully to identify them each.
>>>
>>  Agree with this point and come up with some updations on it. This time
>> I have made it pretty differentiable between Schema and Catalog.
>>
>>>
>>> - Why do we require two different set of icons for Tables & Columns, I
>>> mean one for Schema and one for Catalog?
>>>
>>  Agreed, I have kept single icon for tables and columns.
>>
>>>
>>> - Icons for Partition node is same for collection and individual.
>>>
>>  Working on it
>>
>>>
>>> - Icons for Event trigger node and Trigger node are very different from
>>> each other despite both are triggers.
>>>
>>   Agreed, done the changes accordingly.
>>
> This is still different.
>
> *Current Event trigger icon:*
> [image: Inline image 4]
> *New*
> * *
> *Event trigger*
> **
> *Icon:*
> [image: Inline image 2]
>
>
> *Current Trigger icon:*
>
> *[image: Inline image 5]*
> *New Trigger Icon:*
> [image: Inline image 3]
> If you see both icons are same.
> *[Suggestion: Can we do similar to what we have done with View &
> Materialized view icons, we have added M in the icon for materialized view,
> Same way we can have Trigger icon and for Event trigger we can add E in the
> icon]*
>
>
>> I know this is out of context but in my own opinion these icons have
>>> resemblance with Flat design where as rest of our application is in 2d
>>> design, for example buttons, dialogs etc.
>>>
>> Yes, the icons look and feel are more towards flat and stylish now as it
>> represents the current trend.  You treat this as a first step towards
>> making the whole application flat design from the current design. But
>> this will happen in a long run, not on a quick basis.
>>
>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>>
>>> On Tue, Aug 22, 2017 at 9:37 AM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Yes Shirley, I have already thought through on it.
 Basically, we need to have one more set of icons in white color mode so
 that we can use it on dialog headers as well.
 As the blue theme icons won't fit there.

 Please share your thoughts.

 Regards,
 Chethana kumar

 On Tue, Aug 22, 2017 at 4:32 AM, Shirley Wang  wrote:

> Hi Chethana,
>
> I just thought of something with these icons. What happens with the
> ones that appear in dialog headers? In the blue bar?
>
> On Mon, Aug 21, 2017 at 8:31 AM Chethana Kumar <
> chethana.ku...@enterprisedb.com> wrote:
>
>> Hello Team,
>>
>> I have applied labels for each icon for identification purpose.  So
>> please consider this copy for your feedback.
>>
>> *Note*: The "icon_demo.png" is attached to show case the view on
>> webpage.
>>
>> Regards,
>> Chethana kumar
>>
>> On Mon, Aug 21, 2017 at 3:57 PM, Chethana Kumar <
>> chethana.ku...@enterprisedb.com> wrote:
>>
>>> Hello Team,
>>>
>>> Here are the revised and final icons for tree view control.
>>> I have attached in .svg file format as well so that yo

pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-25 Thread Ashesh Vashi

Fix the feature tests failuers.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5dd375dd2081c126b7b3b9f0dba21976d2a45a1f
Author: Wenlin Zhang 

Modified Files
--
web/pgadmin/feature_tests/query_tool_journey_test.py |  7 ---
web/pgadmin/feature_tests/query_tool_tests.py| 10 +-
2 files changed, 5 insertions(+), 12 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python35 #295

2017-08-25 Thread pgAdmin 4 Jenkins

See

Re: [pgAdmin4][patch] Fix feature tests failure

2017-08-25 Thread Ashesh Vashi

On Wed, Aug 16, 2017 at 8:54 AM, Violet Cheng  wrote:

> Hi,
>
> Is there any update on this patch? Will it be committed soon?
>
> Hi Violet,

I've committed the patch with some changes.
Removed one more occurrence of '_assert_not_clickable_because_out_of_view'
added later by Hao Wang in commit: 5141debae7e08d205e813dd9fc52b737a9f18184.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


> Thanks,
> Violet
>
> On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang  wrote:
>
>> As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for
>> those who would like to join) yesterday, these errors seem to occur only on
>> her Ubuntu system. We have not replicated them on Mac. But they exist
>> before this patch, also.
>>
>> We notice that copy/paste functionality is being tested in two feature
>> tests, the query_tool_journey_test.py and 
>> copy_selected_query_results_feature_test.py.
>> Perhaps we only need to test this behavior in one of the tests?
>>
>> We've confirmed that the patch is able to be applied against the current
>> state of master without any changes after yesterday's commits.
>>
>> Thanks,
>>
>> Wenlin and Matt
>>
>
>

Jenkins build is back to normal : pgadmin4-master-python36 #293

2017-08-25 Thread pgAdmin 4 Jenkins

See

pgAdmin 4 commit: Add package run scripts to allow to run the webpack i

2017-08-25 Thread Ashesh Vashi

Add package run scripts to allow to run the webpack in watch mode, also
added '--progress' option to make it more interactive.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f711336a6b96b6a893605cd28beb6486d186975d
Author: Surinder Kumar 

Modified Files
--
web/package.json  | 2 ++
web/webpack.config.js | 9 +
2 files changed, 11 insertions(+)

Re: [pgAdmin4][Patch]: Add command under scripts to run webpack bundle in watch mode

2017-08-25 Thread Ashesh Vashi

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Wed, Aug 9, 2017 at 6:51 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> Currently, whenever we are making a change in JS file, we have to re-run
> bundle script again to generate all bundles again, which takes time and it
> is pain for developers to watch it till finished.
>
> So Webpack `watch` option lets the Webapck watch for changes in the file
> and compiles only files which are changed after the initial build.
>
> Also added an option `--progress` which updates on terminal about packages
> being built and percentage completed.
>
> So, you can run bundle in watch mode in terminal:
>
> ``` $ yarn run bundle:watch ```
>
> Reference [link](https://webpack.js.org/configuration/watch/#
> components/sidebar/sidebar.jsx)
>
> Please review the patch
>
> Thanks,
> Surinder Kumar
>

Jenkins build is back to normal : pgadmin4-master-python27 #297

2017-08-25 Thread pgAdmin 4 Jenkins

See

pgAdmin 4 commit: Fixes #2560 - View is not fully qualified in Trigger

2017-08-25 Thread Ashesh Vashi

Fixes #2560 - View is not fully qualified in Trigger definition.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3babd78aa9f337344480f56359f9eab66d9b56a
Author: Murtuza Zabuawala 

Modified Files
--
.../browser/server_groups/servers/databases/schemas/views/__init__.py   | 2 ++
1 file changed, 2 insertions(+)

Re: [pgAdmin4][PATCH] Fix trigger's reversed engineered SQL for View

2017-08-25 Thread Ashesh Vashi

On Fri, Aug 18, 2017 at 1:18 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue where view is not fully qualified in
> Trigger definition.
> RM#2560
>
Thanks - committed!

-- Thanks, Ashesh

>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>

Jenkins build is back to normal : pgadmin4-master-python26 #419

2017-08-25 Thread pgAdmin 4 Jenkins

See

pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Akshay Joshi

Greenplum specific DDL and Dashboard display changes.
Initial patch by Sarah McAlear.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46c5df4e7bb7abba6896cfb86eed43914a74850a
Author: Teng Zhang 

Modified Files
--
web/config.py  |   3 +-
.../templates/table/sql/gpdb_5.0_plus/create.sql   | 168 +
.../table/sql/gpdb_5.0_plus/properties.sql |  82 ++
.../servers/databases/schemas/tables/utils.py  |   7 +-
web/pgadmin/browser/server_groups/servers/gpdb.py  |  20 +++
web/pgadmin/dashboard/__init__.py  |   7 +-
.../dashboard/sql/gpdb_5.0_plus/activity.sql   |  14 ++
.../dashboard/sql/gpdb_5.0_plus/locks.sql  |  22 +++
.../dashboard/sql/gpdb_5.0_plus/session_stats.sql  |   4 +
.../gpdb_5.0_plus/some_action_with_gpdb_5_0.sql|   1 +
.../utils/tests/test_versioned_template_loader.py  |  36 -
web/pgadmin/utils/versioned_template_loader.py |  39 +++--
12 files changed, 385 insertions(+), 18 deletions(-)

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Akshay Joshi

Thanks patch applied. I haven't tested it on GPDB.

On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi  wrote:

> On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer  wrote:
>
>> I'm suggesting that it be pushed
>>
> Akshay is already on to it, and currently reviewing it.
> Will push it once get the confirmation.
>
> -- Thanks, Ashesh
>
>>
>> Dave Cramer
>>
>> On 24 August 2017 at 23:00, Teng Zhang  wrote:
>>
>>> Sure, you can get as much as you like.
>>> Thanks
>>>
>>> -- Forwarded message --
>>> From: Dave Cramer 
>>> Date: Thu, Aug 24, 2017 at 8:34 PM
>>> Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
>>> display
>>> To: Teng Zhang 
>>> Cc: Ashesh Vashi , pgadmin-hackers <
>>> pgadmin-hack...@postgresql.org>, Dave Page , Jing Li
>>> 
>>>
>>>
>>> Can we get some movement on this patch? This seems like a more sane way
>>> to go to support different "products"
>>>
>>> Dave Cramer
>>>
>>> On 22 August 2017 at 16:56, Dave Cramer  wrote:
>>>

 On 22 August 2017 at 16:41, Dave Cramer  wrote:

> Ok,
>
> Surely this :
>
> self.table_template_path = 'table/sql/' + (
> +'#{0}#{1}#'.format(server_type, ver)
> +if server_type == 'gpdb' else
> +'#{0}#'.format(ver)
> +)
>
> could be written in a more readable manner ??
>
>
>
 Apologies, after reading a bit, this is apparently idiomatic python.

 Please ignore


> Dave Cramer
>
> On 22 August 2017 at 14:25, Dave Cramer  wrote:
>
>> Hi,
>>
>> I've been able to get back to this and test it. So far so good. It
>> applies more or less cleanly against 1.6 and everything I've tried so far
>> works
>>
>> I'll update more as I test it.
>>
>> Thanks
>>
>> Dave Cramer
>>
>> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>>
>>> Hi,
>>>
>>> Thanks for the review, here is a fixed patch working for GBDP which
>>> shows the appropriate graphs.
>>> In this fix, we toke out the changes to diver/psycopg2 and
>>> implemented the greenplum version checking process in the ppas way
>>> mentioned by Dave Cramer.
>>>
>>> Regards,
>>> Teng Zhang & Hao Wang
>>>
>>> On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Mon, Aug 21, 2017 at 1:23 PM, Dave Page 
 wrote:

> Ashesh, do you have a recommended way to do this?
>
> I haven't looked at the patch, but I assume it adds a database
> driver module for GPDB?
>
 I have not looked at the patch yet.
 I will take a look at it.

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

>
> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li 
> wrote:
>
>> Hi Dave,
>>
>> Since we're hoping to get this change working for GPDB we've
>> currently using this method to detect if it's gpdb and show the 
>> appropriate
>> graphs. Right now it displays errors on the dashboard if it's 
>> connected to
>> a gpdb server.
>> For this patch specifically, the goal is to improve the
>> experience for greenplum users so they can get the same information 
>> as
>> someone connected to a postgres server.
>>
>> I do agree that this is a bigger discussion about how we handle
>> behavior change overall if it's regular postgres or something else. 
>> Let's
>> talk about how we can restructure this behavior in a wider context. 
>> Are you
>> open to meeting about it?
>>
>> Thanks,
>> ~Jing
>>
>>
>>
>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
>> wrote:
>>
>>> Hi Violet.
>>>
>>> I don't really like the way this has been implemented. It adds a
>>> variable which is only used for gpdb.
>>>
>>> There are other places in the code where the behaviour is
>>> changed if the server is ppas or regular postgres.
>>>
>>> Candidly I think all of this needs restructuring.
>>>
>>> Dave Cramer
>>>
>>> On 15 August 2017 at 23:29, Violet Cheng 
>>> wrote:
>>>
>>> Hi,
>>>
>>> Any comment on this patch? If no, will it be committed soon?
>>>
>>> Thanks,
>>> Violet
>>>
>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <
>>> smcal...@pivotal.io> wrote:
>>>
>>> H

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-25 Thread Robert Eckhardt

Given that Greenplum is going to GA next month can we get that stable OSS
version included in the CI?

Rob

On Aug 25, 2017 8:27 AM, "Akshay Joshi" 
wrote:

> Thanks patch applied. I haven't tested it on GPDB.
>
> On Fri, Aug 25, 2017 at 4:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Aug 25, 2017 at 4:53 PM, Dave Cramer 
>> wrote:
>>
>>> I'm suggesting that it be pushed
>>>
>> Akshay is already on to it, and currently reviewing it.
>> Will push it once get the confirmation.
>>
>> -- Thanks, Ashesh
>>
>>>
>>> Dave Cramer
>>>
>>> On 24 August 2017 at 23:00, Teng Zhang  wrote:
>>>
 Sure, you can get as much as you like.
 Thanks

 -- Forwarded message --
 From: Dave Cramer 
 Date: Thu, Aug 24, 2017 at 8:34 PM
 Subject: Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard
 display
 To: Teng Zhang 
 Cc: Ashesh Vashi , pgadmin-hackers <
 pgadmin-hack...@postgresql.org>, Dave Page , Jing
 Li 


 Can we get some movement on this patch? This seems like a more sane way
 to go to support different "products"

 Dave Cramer

 On 22 August 2017 at 16:56, Dave Cramer  wrote:

>
> On 22 August 2017 at 16:41, Dave Cramer  wrote:
>
>> Ok,
>>
>> Surely this :
>>
>> self.table_template_path = 'table/sql/' + (
>> +'#{0}#{1}#'.format(server_type, ver)
>> +if server_type == 'gpdb' else
>> +'#{0}#'.format(ver)
>> +)
>>
>> could be written in a more readable manner ??
>>
>>
>>
> Apologies, after reading a bit, this is apparently idiomatic python.
>
> Please ignore
>
>
>> Dave Cramer
>>
>> On 22 August 2017 at 14:25, Dave Cramer  wrote:
>>
>>> Hi,
>>>
>>> I've been able to get back to this and test it. So far so good. It
>>> applies more or less cleanly against 1.6 and everything I've tried so 
>>> far
>>> works
>>>
>>> I'll update more as I test it.
>>>
>>> Thanks
>>>
>>> Dave Cramer
>>>
>>> On 21 August 2017 at 05:29, Teng Zhang  wrote:
>>>
 Hi,

 Thanks for the review, here is a fixed patch working for GBDP which
 shows the appropriate graphs.
 In this fix, we toke out the changes to diver/psycopg2 and
 implemented the greenplum version checking process in the ppas way
 mentioned by Dave Cramer.

 Regards,
 Teng Zhang & Hao Wang

 On Mon, Aug 21, 2017 at 3:55 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Mon, Aug 21, 2017 at 1:23 PM, Dave Page 
> wrote:
>
>> Ashesh, do you have a recommended way to do this?
>>
>> I haven't looked at the patch, but I assume it adds a database
>> driver module for GPDB?
>>
> I have not looked at the patch yet.
> I will take a look at it.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> On Mon, Aug 21, 2017 at 8:50 AM, Jing Li 
>> wrote:
>>
>>> Hi Dave,
>>>
>>> Since we're hoping to get this change working for GPDB we've
>>> currently using this method to detect if it's gpdb and show the 
>>> appropriate
>>> graphs. Right now it displays errors on the dashboard if it's 
>>> connected to
>>> a gpdb server.
>>> For this patch specifically, the goal is to improve the
>>> experience for greenplum users so they can get the same information 
>>> as
>>> someone connected to a postgres server.
>>>
>>> I do agree that this is a bigger discussion about how we handle
>>> behavior change overall if it's regular postgres or something else. 
>>> Let's
>>> talk about how we can restructure this behavior in a wider context. 
>>> Are you
>>> open to meeting about it?
>>>
>>> Thanks,
>>> ~Jing
>>>
>>>
>>>
>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
>>> wrote:
>>>
 Hi Violet.

 I don't really like the way this has been implemented. It adds
 a variable which is only used for gpdb.

 There are other places in the code where the behaviour is
 changed if the server is ppas or regular postgres.

 Candidly I think all of this needs restructuring.

 Dave Cramer

>>

[pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

2017-08-25 Thread Surinder Kumar

Hi,

We will use config variable `SCHEMA_VERSION` to keep track of SQLite
database changes. Whenever there is any change is performed in the
database, the count of schema version will be incremented by 1 and the same
will be updated in SQLite table `version`.

So, these changes make sure the database migration is not performed on the
older version of pgAdmin4 and this way the same database will work
irrespective of pgAdmin4 version.

Also, this will only work for future pgAdmin4 versions.

Please find attached patch and review.

Thanks,
Surinder


db_migration_for_multiple_pgadmin_versions.patch
Description: Binary data

Re: [pgAdmin4][Patch]: Ensure any changes to the config database are backward compatible

2017-08-25 Thread Surinder Kumar

Created an RM  to track this
issue.

On Fri, Aug 25, 2017 at 7:19 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> We will use config variable `SCHEMA_VERSION` to keep track of SQLite
> database changes. Whenever there is any change is performed in the
> database, the count of schema version will be incremented by 1 and the same
> will be updated in SQLite table `version`.
>
> So, these changes make sure the database migration is not performed on the
> older version of pgAdmin4 and this way the same database will work
> irrespective of pgAdmin4 version.
>
> Also, this will only work for future pgAdmin4 versions.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>

Build failed in Jenkins: pgadmin4-master-python27-feature #10

2017-08-25 Thread pgAdmin 4 Jenkins

See 


Changes:

[Dave Page] Ensure babel-polyfill is loaded in older qWebKits. Fixes #2593

[Dave Page] Fix test assertion.

[Dave Page] Update yarn.lock

[Dave Page] Ensure the appropriate entry is focussed when entering the history 
tab.

[Dave Page] Allow queries to be cancelled from the dashboards. Fixes #1812

[Dave Page] Fix paths under non-standard virtual directories. Fixes #2563

[Ashesh Vashi] Do not dump the session data on the disk on every request.

[Dave Page] Update keyboard shortcuts per discussion. Also, make the labels 
platform

[Dave Page] Handle control visibility properly in javascript strict mode.

[Dave Page] Default the file browser view to list, and make it configurable. 
Fixes

[Dave Page] Fixup tests following label changes.

[Dave Page] Store the file dialog view on toggle.

[Ashesh Vashi] Moved the javascripts of different modules from 'templates' to 
'static'

[Ashesh Vashi] Requests for statistics were not stopped even when Dashboard 
panel is

[akshay.joshi] 1) Added partition module in webpack config. 2) Fixed missing 
logic of

[akshay.joshi] Improved alertify notification logic. Remove AlertifyWrapper 
class and

[akshay.joshi] Domain create dialog do not open and Font size issue in Security 
label

[akshay.joshi] Fixed collation tests on Windows, replace use of default 'POSIX'

[akshay.joshi] Fixed issue in query tool where messages were not displaying from

[akshay.joshi] Added missing pgagent file in webpack.config.js Fixes #2617

[akshay.joshi] Set the database name to blank('') when job type is set to 
batch, while

[akshay.joshi] Changed the mapping of cell from 'numeric' to 'integer' for 
integer

[Ashesh Vashi] Some cosmetic changes.

[Ashesh Vashi] Enable source maps for debugging purpose in all webpack modules 
(except

[Ashesh Vashi] UX improvements of the history in the query tool.

[Ashesh Vashi] Fixed some UX issue with the Import/Export tool.

[Ashesh Vashi] On certain linux operating systems, Qt application exits with an 
error

[akshay.joshi] Use dict based data instead of 2d-array in Type module as we are 
adding

[akshay.joshi] 1) Connection Type cell was not honouring to 'Kind' option in 
Subnode

[akshay.joshi] Fixed the path reference of load-node.gif which was referencing 
to

[akshay.joshi] Unset compression ratio if it is an empty string in Backup 
module. Fixes

[akshay.joshi] Fixed alertify notification messages where checkmark box 
disconnected

[akshay.joshi] User can not add New Server through Quick links. Fixes #2634

[Ashesh Vashi] Extract the generate_url(..) function from node.js, and 
collection.js

[Ashesh Vashi] Fixes #2567 - Use the proper database connection to fetch the 
default

[Dave Page] Update datetime picker. Fixes #2654

[Dave Page] Fix connection string validation for pgAgent jobs. Fixes #2655

[Dave Page] Update CodeMirror version. Fixes #1697. Fixes #2168. Fixes #2447. 
Fixes

[Dave Page] Ensure role names are escaped in the membership control. Fixes #2606

[Dave Page] Refactor keyboard shortcut functions in the query tool. Fix some

[akshay.joshi] Datetimepicker will expand from bottom instead of Top, because 
of that

[akshay.joshi] Syntax error while saving changes for start/end time, weekdays,

[akshay.joshi] Unable to add/update variables for columns of a table. Fixes 
#2659

[Dave Page] Properly cleanup after running the FTS test cases.

[Dave Page] Bump the version number for 2.0. Let's get testing started ASAP!

[Dave Page] Ship with pre-configured paths that can work in both Server and 
Desktop

[Dave Page] Ensure builtins.SERVER_MODE is present so the docs build cleanly.

[Dave Page] Regression tests aren't run under the runtime, so no need to check 
for

[Dave Page] Ensure builtins.SERVER_MODE is handled if running setup.py 
standalone.

[Dave Page] Update docs to more accurately reflect the SERVER_MODE config

[Dave Page] Ensure the SERVER_MODE changes don't break the PIP build.

[Ashesh Vashi] Fix the feature tests failuers.

[Ashesh Vashi] Add package run scripts to allow to run the webpack in watch 
mode, also

[Ashesh Vashi] Fixes #2560 - View is not fully qualified in Trigger definition.

[akshay.joshi] Greenplum specific DDL and Dashboard display changes. Initial 
patch by

--
[...truncated 84.66 KB...]
Test database connection ... ok
runTest 
(pgadmin.feature_tests.copy_selected_query_results_feature_test.CopySelectedQueryResultsFeatureTest)
Copy rows, column using button and keyboard shortcut ... ok
runTest (pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest)
Test checks for PG data-types output ... ok
runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest)
Tests the path through the query tool ... ok
runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
Query tool feature test ... 
On demand result set on sc

Re: pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-25 Thread Dave Page

QueryToolFeatureTest seems to be failing on both Jenkins and my test mac
system since this was applied. The other one below seems more intermittent.

==
ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
Query tool feature test
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 84, in runTest
self._query_tool_explain_cost()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
line 361, in _query_tool_explain_cost
canvas.find_element_by_xpath("//*[contains(string(),'Total Cost')]")
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 260, in find_element_by_xpath
return self.find_element(by=By.XPATH, value=xpath)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 510, in find_element
{"using": by, "value": value})['value']
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 493, in _execute
return self._parent.execute(command, params)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 249, in execute
self.error_handler.check_response(response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 193, in check_response
raise exception_class(message, screen, stacktrace)
NoSuchElementException: Message: no such element: Unable to locate element:
{"method":"xpath","selector":"//*[contains(string(),'Total Cost')]"}
  (Session info: chrome=60.0.3112.101)
  (Driver info: chromedriver=2.29.461585
(0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.11.6 x86_64)


==
ERROR: runTest
(pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Update operations in View/Edit data with given test data
--
Traceback (most recent call last):
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 107, in runTest
self._verify_row_data(True)
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
line 291, in _verify_row_data
result_row = self.page.find_by_xpath(xpath)
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 148, in find_by_xpath
return self.wait_for_element(lambda driver:
driver.find_element_by_xpath(xpath))
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 232, in wait_for_element
return self._wait_for("element to exist", element_if_it_exists)
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 282, in _wait_for
"Timed out waiting for " + waiting_for_message)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/support/wait.py",
line 71, in until
value = method(self._driver)
  File
"/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
line 227, in element_if_it_exists
if element.is_displayed() and element.is_enabled():
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 157, in is_enabled
return self._execute(Command.IS_ELEMENT_ENABLED)['value']
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
line 493, in _execute
return self._parent.execute(command, params)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
line 249, in execute
self.error_handler.check_response(response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
line 193, in check_response
raise exception_class(message, screen, stacktrace)
StaleElementReferenceException: Message: stale element reference: element
is not attached to the page document
  (Session info: chrome=60.0.3112.101)
  (Driver info: chromedriver=2.29.461585
(0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.11.6 x86_64)

On Fri, Aug 25, 2017 at 12:46 PM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Fix the feature tests failuers.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 5dd375dd2081c126b7b3b9f0dba21976d2a45a1f
> Author: Wenlin Zhang 
>
> Modified Files
> --
> web/pgadmin/feature_tests/query_tool_journey_test.py |  7 ---
> web/pgadmin/feature_tests/query_tool_tests.py

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Dave Page

I believe this patch has broken my installation. When I try to run now, I
get:

Exception in thread Thread-1:
Traceback (most recent call last):
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 810, in __bootstrap_inner
self.run()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
line 763, in run
self.__target(*self.__args, **self.__kwargs)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 602, in process_request_thread
self.handle_error(request, client_address)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 599, in process_request_thread
self.finish_request(request, client_address)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 334, in finish_request
self.RequestHandlerClass(request, client_address, self)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
line 655, in __init__
self.handle()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 200, in handle
rv = BaseHTTPRequestHandler.handle(self)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/BaseHTTPServer.py",
line 340, in handle
self.handle_one_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 235, in handle_one_request
return self.run_wsgi()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 177, in run_wsgi
execute(self.server.app)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
line 165, in execute
application_iter = app(environ, start_response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 2000, in __call__
return self.wsgi_app(environ, start_response)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1991, in wsgi_app
response = self.make_response(self.handle_exception(e))
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1567, in handle_exception
reraise(exc_type, exc_value, tb)
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1988, in wsgi_app
response = self.full_dispatch_request()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1634, in full_dispatch_request
self.try_trigger_before_first_request_functions()
  File
"/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
line 1660, in try_trigger_before_first_request_functions
func()
  File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line 43,
in create_module_preference
self.register_preferences()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
line 172, in register_preferences
ServerType.register_preferences()
  File
"/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/types.py",
line 57, in register_preferences
default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
KeyError: 'gpdb'


On Fri, Aug 25, 2017 at 1:25 PM, Akshay Joshi  wrote:

> Greenplum specific DDL and Dashboard display changes.
> Initial patch by Sarah McAlear.
>
> Branch
> --
> master
>
> Details
> ---
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 46c5df4e7bb7abba6896cfb86eed43914a74850a
> Author: Teng Zhang 
>
> Modified Files
> --
> web/config.py  |   3 +-
> .../templates/table/sql/gpdb_5.0_plus/create.sql   | 168
> +
> .../table/sql/gpdb_5.0_plus/properties.sql |  82 ++
> .../servers/databases/schemas/tables/utils.py  |   7 +-
> web/pgadmin/browser/server_groups/servers/gpdb.py  |  20 +++
> web/pgadmin/dashboard/__init__.py  |   7 +-
> .../dashboard/sql/gpdb_5.0_plus/activity.sql   |  14 ++
> .../dashboard/sql/gpdb_5.0_plus/locks.sql  |  22 +++
> .../dashboard/sql/gpdb_5.0_plus/session_stats.sql  |   4 +
> .../gpdb_5.0_plus/some_action_with_gpdb_5_0.sql|   1 +
> .../utils/tests/test_versioned_template_loader.py  |  36 -
> web/pgadmin/utils/versioned_template_loader.py |  39 +++--
> 12 files changed, 385 insertions(+), 18 deletions(-)
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAdmin 4 commit: Fix the feature tests failuers.

2017-08-25 Thread Ashesh Vashi

On Fri, Aug 25, 2017 at 8:26 PM, Dave Page  wrote:

> QueryToolFeatureTest seems to be failing on both Jenkins and my test mac
> system since this was applied. The other one below seems more intermittent.
>
> ==
> ERROR: runTest (pgadmin.feature_tests.query_tool_tests.
> QueryToolFeatureTest)
> Query tool feature test
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
> line 84, in runTest
> self._query_tool_explain_cost()
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
> line 361, in _query_tool_explain_cost
> canvas.find_element_by_xpath("//*[contains(string(),'Total Cost')]")
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webelement.py", line 260, in
> find_element_by_xpath
> return self.find_element(by=By.XPATH, value=xpath)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webelement.py", line 510, in
> find_element
> {"using": by, "value": value})['value']
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webelement.py", line 493, in _execute
> return self._parent.execute(command, params)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webdriver.py", line 249, in execute
> self.error_handler.check_response(response)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/errorhandler.py", line 193, in
> check_response
> raise exception_class(message, screen, stacktrace)
> NoSuchElementException: Message: no such element: Unable to locate
> element: {"method":"xpath","selector":"//*[contains(string(),'Total
> Cost')]"}
>
  (Session info: chrome=60.0.3112.101)
>   (Driver info: chromedriver=2.29.461585 
> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac
> OS X 10.11.6 x86_64)
>
>
> ==
> ERROR: runTest (pgadmin.feature_tests.view_data_dml_queries.
> CheckForViewDataTest)
> Validate Insert, Update operations in View/Edit data with given test data
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 107, in runTest
> self._verify_row_data(True)
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 291, in _verify_row_data
> result_row = self.page.find_by_xpath(xpath)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 148, in find_by_xpath
> return self.wait_for_element(lambda driver:
> driver.find_element_by_xpath(xpath))
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 232, in wait_for_element
> return self._wait_for("element to exist", element_if_it_exists)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 282, in _wait_for
> "Timed out waiting for " + waiting_for_message)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/support/wait.py", line 71, in until
> value = method(self._driver)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 227, in element_if_it_exists
> if element.is_displayed() and element.is_enabled():
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webelement.py", line 157, in is_enabled
> return self._execute(Command.IS_ELEMENT_ENABLED)['value']
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webelement.py", line 493, in _execute
> return self._parent.execute(command, params)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/webdriver.py", line 249, in execute
> self.error_handler.check_response(response)
>   File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/selenium/webdriver/remote/errorhandler.py", line 193, in
> check_response
> raise exception_class(message, screen, stacktrace)
> StaleElementReferenceException: Message: stale element reference: element
> is not attached to the page document
>   (Session info: chrome=60.0.3112.101)
>   (Driver info: chromedriver=2.29.461585 
> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac
> OS X 10.11.6 x86_64)
>
There is nothing changed in these areas.
I will investigate more.

-- Thanks, Ashesh

>
> On Fri, Aug 25, 2017 at 12:46 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Fix the fe

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Ashesh Vashi

On Fri, Aug 25, 2017 at 8:30 PM, Dave Page  wrote:

> I believe this patch has broken my installation. When I try to run now, I
> get:
>
> Exception in thread Thread-1:
> Traceback (most recent call last):
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
> line 810, in __bootstrap_inner
> self.run()
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
> line 763, in run
> self.__target(*self.__args, **self.__kwargs)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 602, in process_request_thread
> self.handle_error(request, client_address)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 599, in process_request_thread
> self.finish_request(request, client_address)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 334, in finish_request
> self.RequestHandlerClass(request, client_address, self)
>   File 
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
> line 655, in __init__
> self.handle()
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
> line 200, in handle
> rv = BaseHTTPRequestHandler.handle(self)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
> b/python2.7/BaseHTTPServer.py", line 340, in handle
> self.handle_one_request()
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
> line 235, in handle_one_request
> return self.run_wsgi()
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
> line 177, in run_wsgi
> execute(self.server.app)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
> line 165, in execute
> application_iter = app(environ, start_response)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 1634, in full_dispatch_request
> self.try_trigger_before_first_request_functions()
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
> line 1660, in try_trigger_before_first_request_functions
> func()
>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line
> 43, in create_module_preference
> self.register_preferences()
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 172, in register_preferences
> ServerType.register_preferences()
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/types.py",
> line 57, in register_preferences
> default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
> KeyError: 'gpdb'
>
That's because - you must have DEFAULT_BINARY_PATHS definition in the
config_local.py/config_distro.py.

I will modify the code to take of that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
> On Fri, Aug 25, 2017 at 1:25 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Greenplum specific DDL and Dashboard display changes.
>> Initial patch by Sarah McAlear.
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=46c5df4e7bb7abba6896cfb86eed43914a74850a
>> Author: Teng Zhang 
>>
>> Modified Files
>> --
>> web/config.py  |   3 +-
>> .../templates/table/sql/gpdb_5.0_plus/create.sql   | 168
>> +
>> .../table/sql/gpdb_5.0_plus/properties.sql |  82 ++
>> .../servers/databases/schemas/tables/utils.py  |   7 +-
>> web/pgadmin/browser/server_groups/servers/gpdb.py  |  20 +++
>> web/pgadmin/dashboard/__init__.py  |   7 +-
>> .../dashboard/sql/gpdb_5.0_plus/activity.sql   |  14 ++
>> .../dashboard/sql/gpdb_5.0_plus/locks.sql  |  22 +++
>> .../dashboard/sql/gpdb_5.0_plus/session_stats.sql  |   4 +
>> .../gpdb_5.0_plus/some_action_

pgAdmin 4 commit: Allow queries to be cancelled from the dashboard, and

2017-08-25 Thread Dave Page

Allow queries to be cancelled from the dashboard, and display additional info 
in the subnode control. Fixes #2597

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74db8374173fe42112c9ed9c3477c6301337e290
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/dashboard/static/css/dashboard.css |  80 
web/pgadmin/dashboard/static/js/dashboard.js   | 104 +
.../templates/dashboard/sql/9.6_plus/activity.sql  |   8 +-
.../templates/dashboard/sql/default/activity.sql   |   7 +-
web/pgadmin/static/js/backgrid.pgadmin.js  |   8 +-
5 files changed, 200 insertions(+), 7 deletions(-)

Re: [pgAdmin4][Patch]: Allow user to cancel long running queries from dashboard

2017-08-25 Thread Dave Page

Thanks, patch applied.

On Wed, Aug 9, 2017 at 12:19 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Please find the updated patch with new UI style in dashboard subnode
> control based on Chethana's design suggestion.
>
> @Shirley,
> Yes, DBA needs to click on the drop down to expand.
> - If we make whole row clickable then how are we going to identify if user
> is trying to expand the row or trying to cancel the active session? I am
> asking this because table row  tag comes before table column tag 
> in HTML DOM, so if we have click event listers on both of the tags then how
> are we going to differentiate the user operation?
> - In my opinion, another reason we can not do that on a dashboard grid
> because it will break the subnode control consistency, If user sees that
> grid expands on clicking the row they will expect the same behaviour in
> other grids as well.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> 
>
> On Tue, Aug 8, 2017 at 7:47 PM, Shirley Wang  wrote:
>
>> Nice!
>>
>> Would a DBA need to click on the drop down to expand? I think that drop
>> down icon might be too small. Perhaps the whole row could be a clickable
>> area to show further details. This is a good thing to test with some people
>>
>>
>> On Aug 8, 2017, at 12:52, Ashesh Vashi 
>> wrote:
>>
>> On Mon, Aug 7, 2017 at 9:06 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Aug 7, 2017 at 3:49 PM, Chethana Kumar <
>>> chethana.ku...@enterprisedb.com> wrote:
>>>
 Hi Dave,

 Could you comment on the new design update for subnode control ?

 Attached designs -

 1. subnode_current.png -  The existing view
 2. subnode_new.png - The updated view
 3. current_new.png - Existing and new design placed together for
 comparison purpose

 Below changes done -

 1. Reduced number of gray color variations
 2. Made more simplified by removing unwanted borders
 3. Merged "Arrow Down" background and the body background for more
 clarity

 Please feel free to provide your input on the same.

>>>
>>> Much nicer in my opinion! Good work.
>>>
>>> Anyone else have any comments?
>>>
>> It looks much nicer.
>> I would like to see the effect on another dialogs like 'Table
>> properties', where we have multiple level of subgrid controls with tabs.
>>
>> -- Thanks, Ashesh
>>
>>>
>>>

 Regards,
 Chethana kumar



 On Fri, Jul 28, 2017 at 4:11 PM, Dave Page  wrote:

> Hi
>
> I took a quick look at this and have a couple of thoughts:
>
> - Instead of the "edit" icon to open the subnode, we should use
> something more appropriate - a "properties" icon perhaps.
>
> - There seems to be a lot of different shades of grey on there (maybe
> a subnode design in general that just shows up with the disabled 
> controls),
> and the subnode control looks a bit messy as a result.
>
> Can you work with Chethana to improve the look and feel please?
>
> Input from others welcome of course - screenshot attached.
>
> Thanks.
>
> On Fri, Jul 28, 2017 at 11:33 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> ++ Attaching the patch
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jul 28, 2017 at 4:02 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> PFA patch to display additional information from pg_stat_activity
>>> table using subnode control.
>>> RM#2597
>>>
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Jul 25, 2017 at 10:56 AM, Shirley Wang 
>>> wrote:
>>>

> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page 
> wrote:
>
>>
>>
>> On Mon, Jul 24, 2017 at 3:28 PM, Shirley Wang 
>> wrote:
>>
>>> 2-3 days is a lot of valuable engineering time. Is this a 'drop
>>> everything now' kind of feature or can this wait for some user 
>>> validation
>>> on a mock up first?
>>>
>>
>> Most of the time will likely be on the infrastructure to change
>> the display to a subnode control. If you have some cycles to mockup
>> potential layouts for the subnode view and have them validated, 
>> please feel
>> free, however, that seems like an awful lot of work to me to display 
>> some
>> missing SQL using a standard control.
>>
> Regarding SQL display: Develo

pgAdmin 4 commit: Define the utility path lable, and help message for t

2017-08-25 Thread Ashesh Vashi

Define the utility path lable, and help message for the Greenplum
database server, shown in the preferences dialog.

Also, fixed the issue, when server type is not defined in the
DEFAULT_BINARY_PATHS, in the configuration.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b727c43b9c070595ca55b37cd9d61cac44e205f

Modified Files
--
web/pgadmin/browser/server_groups/servers/gpdb.py  | 6 ++
web/pgadmin/browser/server_groups/servers/types.py | 5 -
2 files changed, 10 insertions(+), 1 deletion(-)

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Ashesh Vashi

On Fri, Aug 25, 2017 at 9:14 PM, Ashesh Vashi  wrote:

> On Fri, Aug 25, 2017 at 8:30 PM, Dave Page  wrote:
>
>> I believe this patch has broken my installation. When I try to run now, I
>> get:
>>
>> Exception in thread Thread-1:
>> Traceback (most recent call last):
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>> line 810, in __bootstrap_inner
>> self.run()
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>> line 763, in run
>> self.__target(*self.__args, **self.__kwargs)
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 602, in process_request_thread
>> self.handle_error(request, client_address)
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 599, in process_request_thread
>> self.finish_request(request, client_address)
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 334, in finish_request
>> self.RequestHandlerClass(request, client_address, self)
>>   File 
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>> line 655, in __init__
>> self.handle()
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 200, in handle
>> rv = BaseHTTPRequestHandler.handle(self)
>>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
>> b/python2.7/BaseHTTPServer.py", line 340, in handle
>> self.handle_one_request()
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 235, in handle_one_request
>> return self.run_wsgi()
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 177, in run_wsgi
>> execute(self.server.app)
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>> line 165, in execute
>> application_iter = app(environ, start_response)
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 2000, in __call__
>> return self.wsgi_app(environ, start_response)
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 1991, in wsgi_app
>> response = self.make_response(self.handle_exception(e))
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 1567, in handle_exception
>> reraise(exc_type, exc_value, tb)
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 1988, in wsgi_app
>> response = self.full_dispatch_request()
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 1634, in full_dispatch_request
>> self.try_trigger_before_first_request_functions()
>>   File 
>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>> line 1660, in try_trigger_before_first_request_functions
>> func()
>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line
>> 43, in create_module_preference
>> self.register_preferences()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
>> line 172, in register_preferences
>> ServerType.register_preferences()
>>   File 
>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/types.py",
>> line 57, in register_preferences
>> default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
>> KeyError: 'gpdb'
>>
> That's because - you must have DEFAULT_BINARY_PATHS definition in the
> config_local.py/config_distro.py.
>
> I will modify the code to take of that.
>
Checked-in the code for the same.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>
>> On Fri, Aug 25, 2017 at 1:25 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Greenplum specific DDL and Dashboard display changes.
>>> Initial patch by Sarah McAlear.
>>>
>>> Branch
>>> --
>>> master
>>>
>>> Details
>>> ---
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=46c5df4e7bb7abba6896cfb86eed43914a74850a
>>> Author: Teng Zhang 
>>>
>>> Modified Files
>>> --
>>> web/config.py  |   3 +-
>>> .../templates/table/sql/gpdb_5.0_plus/create.sql   | 168
>>> +
>>> .../table/sql/gpdb_5.0_plus/properties.sql

Re: pgAdmin 4 commit: Greenplum specific DDL and Dashboard display changes.

2017-08-25 Thread Dave Page

Thanks.

On Fri, Aug 25, 2017 at 5:06 PM, Ashesh Vashi  wrote:

> On Fri, Aug 25, 2017 at 9:14 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Fri, Aug 25, 2017 at 8:30 PM, Dave Page  wrote:
>>
>>> I believe this patch has broken my installation. When I try to run now,
>>> I get:
>>>
>>> Exception in thread Thread-1:
>>> Traceback (most recent call last):
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>>> line 810, in __bootstrap_inner
>>> self.run()
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py",
>>> line 763, in run
>>> self.__target(*self.__args, **self.__kwargs)
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 602, in process_request_thread
>>> self.handle_error(request, client_address)
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 599, in process_request_thread
>>> self.finish_request(request, client_address)
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 334, in finish_request
>>> self.RequestHandlerClass(request, client_address, self)
>>>   File 
>>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/SocketServer.py",
>>> line 655, in __init__
>>> self.handle()
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 200, in handle
>>> rv = BaseHTTPRequestHandler.handle(self)
>>>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/li
>>> b/python2.7/BaseHTTPServer.py", line 340, in handle
>>> self.handle_one_request()
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 235, in handle_one_request
>>> return self.run_wsgi()
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 177, in run_wsgi
>>> execute(self.server.app)
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/serving.py",
>>> line 165, in execute
>>> application_iter = app(environ, start_response)
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 2000, in __call__
>>> return self.wsgi_app(environ, start_response)
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 1991, in wsgi_app
>>> response = self.make_response(self.handle_exception(e))
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 1567, in handle_exception
>>> reraise(exc_type, exc_value, tb)
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 1988, in wsgi_app
>>> response = self.full_dispatch_request()
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 1634, in full_dispatch_request
>>> self.try_trigger_before_first_request_functions()
>>>   File 
>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py",
>>> line 1660, in try_trigger_before_first_request_functions
>>> func()
>>>   File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/__init__.py", line
>>> 43, in create_module_preference
>>> self.register_preferences()
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
>>> line 172, in register_preferences
>>> ServerType.register_preferences()
>>>   File 
>>> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/types.py",
>>> line 57, in register_preferences
>>> default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
>>> KeyError: 'gpdb'
>>>
>> That's because - you must have DEFAULT_BINARY_PATHS definition in the
>> config_local.py/config_distro.py.
>>
>> I will modify the code to take of that.
>>
> Checked-in the code for the same.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>>
>>> On Fri, Aug 25, 2017 at 1:25 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Greenplum specific DDL and Dashboard display changes.
 Initial patch by Sarah McAlear.

 Branch
 --
 master

 Details
 ---
 https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
 f;h=46c5df4e7bb7abba6896cfb86eed43914a74850a
 Author: Teng Zhang

fix keyerror problems

2017-08-25 Thread Dave Cramer

See attached patch


Dave Cramer


keyerror.patch
Description: Binary data

Re: fix keyerror problems

2017-08-25 Thread Harshal Dhumal

how about this?

default_path = (
config.DEFAULT_BINARY_PATHS.get(st.stype, "")
 )




On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer  wrote:

> See attached patch
>
>
> Dave Cramer
>

Re: fix keyerror problems

2017-08-25 Thread Dave Cramer

Even better.

I'm a python noob so help me out!

Dave Cramer

On 25 August 2017 at 15:17, Harshal Dhumal 
wrote:

> how about this?
>
> default_path = (
> config.DEFAULT_BINARY_PATHS.get(st.stype, "")
>  )
>
>
>
>
> On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer 
> wrote:
>
>> See attached patch
>>
>>
>> Dave Cramer
>>
>
>

pgAdmin 4 commit: Using the proper python syntax to fetch the default b

2017-08-25 Thread Ashesh Vashi

Using the proper python syntax to fetch the default binary path for
different servers types.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b1ad89fb4a772c0b396cb8907a1a1ce5973bc82e
Author: Harshal Dhumal 

Modified Files
--
web/pgadmin/browser/server_groups/servers/types.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)

Re: fix keyerror problems

2017-08-25 Thread Ashesh Vashi

On Sat, Aug 26, 2017 at 12:24 AM, Dave Cramer  wrote:

> See attached patch
>
I have already committed a patch for the same.

But - improved the syntax as per Harshal's suggestion.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

*http://www.linkedin.com/in/asheshvashi*

>
>
> Dave Cramer
>

68 matches

Mail list logo