Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Dave Page]

On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue in Debugger module where it was unable to start
> debugging if 'plugin_debugger' can not found in shared_preload_libraries.
> RM#2162
>
> Original patch by: Kit Yam Tse
> (who reported the issue)
>
> I just re-based it against current code.

Isn't that code required? We do need plugin_debugger to be present for
global (indirect) debugging to work. I suppose it may not be required
for direct debugging, but I haven't tested that.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure the relevant Makefile targets install node mod

[Dave Page]

Ensure the relevant Makefile targets install node modules before running.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b98fcaa829aa71493af8419d6d97a5c8a3b74302
Author: Matthew Kleiman 

Modified Files
--
Makefile | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)

pgAdmin 4 commit: Update Slickgrid to 2.3.7. As this version includes a

[Dave Page]

Update Slickgrid to 2.3.7. As this version includes all the features we need, 
it can be moved out of the vendor directory and we'll use yarn to pull it in.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=94aa5487fb9c4e24b3b06e02e40bd3f9829b543e
Author: Matthew Kleiman 

Modified Files
--
libraries.txt  |   66 +-
web/karma.conf.js  |2 +
web/package.json   |6 +-
web/pgadmin/static/bundle/components.js|9 +
web/pgadmin/static/bundle/slickgrid.js |   13 +
.../static/js/selection/xcell_selection_model.js   |5 +-
.../js/slickgrid/pgslick.cellrangedecorator.js |   73 -
.../js/slickgrid/pgslick.cellrangeselector.js  |  119 -
web/pgadmin/static/jsx/components.jsx  |   10 -
web/pgadmin/static/vendor/slickgrid/README.md  |9 -
.../slickgrid/controls/slick.columnpicker.css  |   31 -
.../slickgrid/controls/slick.columnpicker.js   |  153 -
.../vendor/slickgrid/controls/slick.pager.css  |   41 -
.../vendor/slickgrid/controls/slick.pager.js   |  147 -
.../static/vendor/slickgrid/images/CheckboxN.png   |  Bin 257 -> 0 bytes
.../static/vendor/slickgrid/images/CheckboxY.png   |  Bin 361 -> 0 bytes
.../static/vendor/slickgrid/images/actions.gif |  Bin 170 -> 0 bytes
.../vendor/slickgrid/images/ajax-loader-small.gif  |  Bin 1849 -> 0 bytes
.../static/vendor/slickgrid/images/arrow_redo.png  |  Bin 572 -> 0 bytes
.../slickgrid/images/arrow_right_peppermint.png|  Bin 128 -> 0 bytes
.../slickgrid/images/arrow_right_spearmint.png |  Bin 128 -> 0 bytes
.../static/vendor/slickgrid/images/arrow_undo.png  |  Bin 578 -> 0 bytes
.../static/vendor/slickgrid/images/bullet_blue.png |  Bin 241 -> 0 bytes
.../static/vendor/slickgrid/images/bullet_star.png |  Bin 279 -> 0 bytes
.../slickgrid/images/bullet_toggle_minus.png   |  Bin 154 -> 0 bytes
.../vendor/slickgrid/images/bullet_toggle_plus.png |  Bin 156 -> 0 bytes
.../static/vendor/slickgrid/images/calendar.gif|  Bin 1035 -> 0 bytes
.../static/vendor/slickgrid/images/collapse.gif|  Bin 846 -> 0 bytes
.../vendor/slickgrid/images/comment_yellow.gif |  Bin 257 -> 0 bytes
.../static/vendor/slickgrid/images/down.gif|  Bin 59 -> 0 bytes
.../static/vendor/slickgrid/images/drag-handle.png |  Bin 1130 -> 0 bytes
.../vendor/slickgrid/images/editor-helper-bg.gif   |  Bin 1164 -> 0 bytes
.../static/vendor/slickgrid/images/expand.gif  |  Bin 851 -> 0 bytes
.../static/vendor/slickgrid/images/header-bg.gif   |  Bin 872 -> 0 bytes
.../vendor/slickgrid/images/header-columns-bg.gif  |  Bin 836 -> 0 bytes
.../slickgrid/images/header-columns-over-bg.gif|  Bin 823 -> 0 bytes
.../static/vendor/slickgrid/images/help.png|  Bin 345 -> 0 bytes
.../static/vendor/slickgrid/images/info.gif|  Bin 80 -> 0 bytes
.../static/vendor/slickgrid/images/listview.gif|  Bin 2380 -> 0 bytes
.../static/vendor/slickgrid/images/pencil.gif  |  Bin 914 -> 0 bytes
.../static/vendor/slickgrid/images/row-over-bg.gif |  Bin 823 -> 0 bytes
.../static/vendor/slickgrid/images/sort-asc.gif|  Bin 830 -> 0 bytes
.../static/vendor/slickgrid/images/sort-asc.png|  Bin 105 -> 0 bytes
.../static/vendor/slickgrid/images/sort-desc.gif   |  Bin 833 -> 0 bytes
.../static/vendor/slickgrid/images/sort-desc.png   |  Bin 107 -> 0 bytes
.../static/vendor/slickgrid/images/stripes.png |  Bin 1125 -> 0 bytes
.../static/vendor/slickgrid/images/tag_red.png |  Bin 537 -> 0 bytes
.../static/vendor/slickgrid/images/tick.png|  Bin 484 -> 0 bytes
.../vendor/slickgrid/images/user_identity.gif  |  Bin 905 -> 0 bytes
.../vendor/slickgrid/images/user_identity_plus.gif |  Bin 546 -> 0 bytes
.../vendor/slickgrid/plugins/slick.autotooltips.js |   83 -
.../slickgrid/plugins/slick.cellcopymanager.js |   88 -
.../plugins/slick.cellexternalcopymanager.js   |  449 ---
.../slickgrid/plugins/slick.cellrangedecorator.js  |   66 -
.../slickgrid/plugins/slick.cellrangeselector.js   |  120 -
.../slickgrid/plugins/slick.cellselectionmodel.js  |  159 -
.../plugins/slick.checkboxselectcolumn.js  |  153 -
.../slickgrid/plugins/slick.headerbuttons.css  |   39 -
.../slickgrid/plugins/slick.headerbuttons.js   |  177 -
.../vendor/slickgrid/plugins/slick.headermenu.css  |   59 -
.../vendor/slickgrid/plugins/slick.headermenu.js   |  275 --
.../slickgrid/plugins/slick.rowmovemanager.js  |  138 -
.../slickgrid/plugins/slick.rowselectionmodel.js   |  189 -
.../vendor/slickgrid/slick-default-theme.css   |  118 -
web/pgadmin/static/vendor/slickgrid/slick.core.js  |  485 ---
.../static/vendor/slickgrid/slick.dataview.js  | 1159 --
.../static/vendor/slickgrid/slick.editors.js   |  634 
.../static/vendor/slickgrid/slick.formatters.js|   65 -
web/pgadmin/static/vendor/slickgrid/slick.grid.css |  179 -
web/pgadmin/st

pgAdmin 4 commit: Fix cell selection window alignment for the updated S

[Dave Page]

Fix cell selection window alignment for the updated SlickGrid.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9af29364c7414128d091d57b020750657946cc8c
Author: Matthew Kleiman 

Modified Files
--
web/pgadmin/static/js/selection/xcell_selection_model.js | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

[Dave Page]

Thanks - all applied!

On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman 
wrote:

> Hello Dave,
>
> We noticed that the makefile is not installing node_modules dependencies,
> so we created a new patch that changes the makefile to install
> node_modules first and then execute the tasks.
>
> Thanks
> Matt && João
>
> On Tue, Jun 20, 2017 at 5:23 AM, Dave Page  wrote:
>
>> Hi,
>>
>> This fails tests:
>>
>> (pgadmin4)piranha:pgadmin4 dpage$ make check-feature
>> cd web && yarn run bundle && python regression/runtests.py --pkg
>> feature_tests
>> yarn run v0.24.6
>> $ yarn run linter && yarn run webpacker
>> yarn run v0.24.6
>> $ yarn run eslint pgadmin/static/jsx/**/*.jsx
>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>> regression/javascript/**/*.js *.js
>> yarn run v0.24.6
>> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint"
>> pgadmin/static/jsx/history/query_history.jsx
>> pgadmin/static/jsx/history/query_history_entry.jsx
>> pgadmin/static/js/selection/active_cell_capture.js
>> pgadmin/static/js/selection/clipboard.js
>> pgadmin/static/js/selection/column_selector.js
>> pgadmin/static/js/selection/copy_data.js
>> pgadmin/static/js/selection/grid_selector.js
>> pgadmin/static/js/selection/range_boundary_navigator.js
>> pgadmin/static/js/selection/range_selection_helper.js
>> pgadmin/static/js/selection/row_selector.js
>> pgadmin/static/js/selection/set_staged_rows.js
>> pgadmin/static/js/selection/xcell_selection_model.js
>> regression/javascript/history/query_history_entry_spec.jsx
>> regression/javascript/history/query_history_spec.jsx
>> regression/javascript/browser/menu_spec.js
>> regression/javascript/history/history_collection_spec.js
>> regression/javascript/selection/active_cell_capture_spec.js
>> regression/javascript/selection/column_selector_spec.js
>> regression/javascript/selection/copy_data_spec.js
>> regression/javascript/selection/grid_selector_spec.js
>> regression/javascript/selection/range_boundary_navigator_spec.js
>> regression/javascript/selection/range_selection_helper_spec.js
>> regression/javascript/selection/row_selector_spec.js
>> regression/javascript/selection/set_staged_rows_spec.js
>> regression/javascript/selection/xcell_selection_model_spec.js
>> regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js
>> webpack.config.js webpack.test.config.js
>> ✨  Done in 1.17s.
>> ✨  Done in 1.40s.
>> yarn run v0.24.6
>> $ yarn run webpack -- --config webpack.config.js
>> yarn run v0.24.6
>> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack" --config
>> webpack.config.js
>> (node:33997) DeprecationWarning: loaderUtils.parseQuery() received a
>> non-string value which can be problematic, see
>> https://github.com/webpack/loader-utils/issues/56
>> parseQuery() will be replaced with getOptions() in the next major
>> version of loader-utils.
>> Hash: fe4471bbef0e7c5081ef
>> Version: webpack 2.3.3
>> Time: 1552ms
>>  Asset Size  ChunksChunk Names
>> reactComponents.js  1.21 MB   0  [emitted]  [big]  reactComponents
>> history.js  5.37 kB   1  [emitted] history
>>   slickgrid.js  4.78 kB   2  [emitted] slickgrid
>>[5] /Users/dpage/git/pgadmin4/web/~/object-assign/index.js 2.11 kB
>> {0} [built]
>>   [20] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0}
>> [built]
>>   [32] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0}
>> [built]
>>  [196] ./js/history/history_collection.js 1.91 kB {1} [built]
>>  [197] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
>>  [198] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0}
>> [built]
>>  [199] ./bundle/components.js 604 bytes {0} [built]
>>  [200] ./bundle/slickgrid.js 620 bytes {2} [built]
>>  [201] ./js/history/index.js 690 bytes {1} [built]
>>  [202] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
>>  [233] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
>> kB {0} [built]
>>  [282] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/findDOMNode.js
>> 2.46 kB {0} [built]
>>  [296] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js
>> 15.8 kB {0} [built]
>>  [297] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js
>> 1.32 kB {0} [built]
>>  [298] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350
>> bytes {0} [built]
>> + 288 hidden modules
>>
>> ERROR in ./bundle/slickgrid.js
>> Module not found: Error: Can't resolve 'slickgrid/slick.grid.css' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle'
>>  @ ./bundle/slickgrid.js 7:0-35
>>
>> ERROR in ./bundle/slickgrid.js
>> Module not found: Error: Can't resolve
>> 'slickgrid/slick-default-theme.css' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle'
>>  @ ./bundle/slickgrid.js 9:0-44
>>
>> ERROR in ./bundle/slickgrid.js
>> Module not found: Error: Can't resolve 'slickgrid/slick.core' in
>> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle'
>>  @ ./bundle/slickgr

pgAdmin 4 commit: Fix removal of sizes from column definitions. Fixes #

[Dave Page]

Fix removal of sizes from column definitions. Fixes #2155

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a4945ff9e9a3cb7cf9dc0c4f042f5502d76464f
Author: Murtuza Zabuawala 

Modified Files
--
.../databases/schemas/tables/templates/column/sql/9.2_plus/update.sql   | 2 +-
.../databases/schemas/tables/templates/column/sql/default/update.sql| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Re: [pgAdmin4][Patch] To fix the issue in Column module

[Dave Page]

Thanks, patch applied.

On Fri, Jun 23, 2017 at 6:55 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue in Column module where clearing the length of a
> character(or any other type as well) generates empty SQL.
> RM#2155
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Murtuza Zabuawala]

Yes Dave,

You are right, I tested and found that indirect debugging is not working.
But otherwise for direct debugging it works properly.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 23, 2017 at 1:20 PM, Dave Page  wrote:

> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>  wrote:
> > Hi,
> >
> > PFA patch to fix the issue in Debugger module where it was unable to
> start
> > debugging if 'plugin_debugger' can not found in shared_preload_libraries.
> > RM#2162
> >
> > Original patch by: Kit Yam Tse
> > (who reported the issue)
> >
> > I just re-based it against current code.
>
> Isn't that code required? We do need plugin_debugger to be present for
> global (indirect) debugging to work. I suppose it may not be required
> for direct debugging, but I haven't tested that.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

pgAdmin 4 commit: Add access keys for top level menus.

[Dave Page]

Add access keys for top level menus.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fabf4764b51c9978c896ce93733b474a3c3a8ff

Modified Files
--
web/pgadmin/browser/templates/browser/index.html | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Dave Page]

On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
 wrote:
> Yes Dave,
>
> You are right, I tested and found that indirect debugging is not working.
> But otherwise for direct debugging it works properly.

Does the patch take that into account, or are you modifying it?

> On Fri, Jun 23, 2017 at 1:20 PM, Dave Page  wrote:
>>
>> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi,
>> >
>> > PFA patch to fix the issue in Debugger module where it was unable to
>> > start
>> > debugging if 'plugin_debugger' can not found in
>> > shared_preload_libraries.
>> > RM#2162
>> >
>> > Original patch by: Kit Yam Tse
>> > (who reported the issue)
>> >
>> > I just re-based it against current code.
>>
>> Isn't that code required? We do need plugin_debugger to be present for
>> global (indirect) debugging to work. I suppose it may not be required
>> for direct debugging, but I haven't tested that.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Murtuza Zabuawala]

Yes, I'm looking into it, I will send updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 23, 2017 at 2:32 PM, Dave Page  wrote:

> On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
>  wrote:
> > Yes Dave,
> >
> > You are right, I tested and found that indirect debugging is not working.
> > But otherwise for direct debugging it works properly.
>
> Does the patch take that into account, or are you modifying it?
>
> > On Fri, Jun 23, 2017 at 1:20 PM, Dave Page  wrote:
> >>
> >> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
> >>  wrote:
> >> > Hi,
> >> >
> >> > PFA patch to fix the issue in Debugger module where it was unable to
> >> > start
> >> > debugging if 'plugin_debugger' can not found in
> >> > shared_preload_libraries.
> >> > RM#2162
> >> >
> >> > Original patch by: Kit Yam Tse
> >> > (who reported the issue)
> >> >
> >> > I just re-based it against current code.
> >>
> >> Isn't that code required? We do need plugin_debugger to be present for
> >> global (indirect) debugging to work. I suppose it may not be required
> >> for direct debugging, but I haven't tested that.
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

pgAdmin 4 commit: Tidy up About box formatting, 'cos it's been annoying

[Dave Page]

Tidy up About box formatting, 'cos it's been annoying me for ages.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=92b1b1365e9b82bcc7ff201f94496b94f1ae8759

Modified Files
--
web/pgadmin/about/templates/about/index.html | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)

Build failed in Jenkins: pgadmin4-master-python33 #195

[pgAdmin 4 Jenkins]

See 


Changes:

[Dave Page] Tidy up About box formatting, 'cos it's been annoying me for ages.

--
[...truncated 288.93 KB...]
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_add.ResourceGroupsAddTestCase)
Add resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_delete.ResourceGroupsDeleteTestCase)
Delete resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.test_resource_groups_put.ResourceGroupsPutTestCase)
Put resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.resource_groups.tests.tests_resource_groups_get.ResourceGroupsGetTestCase)
Get resource groups ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_add.LoginRoleAddTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_delete.LoginRoleDeleteTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_get.LoginRoleGetTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.roles.tests.test_role_put.LoginRolePutTestCase)
Check Role Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.TableSpaceAddTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_delete.TableSpaceDeleteTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.TablespaceGetTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.TableSpaceUpdateTestCase)
Check Tablespace Node ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_check_recovery.TestCheckRecovery)
Test for check recovery ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependencies_sql.TestDependenciesSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_dependents_sql.TestDependentsSql)
Test dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_role_dependencies_sql.TestRoleDependenciesSql)
Test Role Dependencies SQL file ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_add.ServersAddTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_delete.ServerDeleteTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_get.ServersGetTestCase)
Default Server Node url ... ok
runTest 
(pgadmin.browser.server_groups.servers.tests.test_server_put.ServerUpdateTestCase)
Default Server Node url ... ok
runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
Check Server Group Node ... ok
runTest 
(pgadmin.utils.javascript.tests.test_javascript_bundler.JavascriptBundlerTestCase)
scenario name: JavascriptBundlerTestCase ... ok
runTest 
(pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Render a template when called ... ok
runTest 
(pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Render a version 9.1 template when it is present ... ok
runTest 
(pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Render a version 9.2 template when request for a higher version ... ok
runTest 
(pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Render default version when version 9.0 was requested and only 9.1 and 9.2 are 
present ... ok
runTest 
(pgadmin.utils.tests.test_versioned_template_loader.TestVersionedTemplateLoader)
Raise error when version is smaller than available templates ... ok
runTest 
(regression.python_test_utils.sql_template_test_base.SQLTemplateTestBase)
parent test class ... ok

==
ERROR: runTest 
(pgadmin.browser.server_groups.servers.databases.event_triggers.tests.test_event_trigger_delete.EventTriggerDeleteTestCase)
Fetch Event Trigger Node URL
--
Traceback (most recent call last):
  File 
"
 line 72, in runTest
func_name = self.function_info[1]
TypeError: 'NoneType' object is not subscriptable

--
Ran 163 tests in 25.090s

FAILED (errors=1)

==
Test Result Summary
==

PostgreSQL 9.2:

143 tests passed
0

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

[Surinder Kumar]

Hi

On latest git pull, couple of issues:

1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana.
2. The dotted border around cell appears again.

The class 'ui-widget' is added dynamically which i don't know why it is
added.

Also, Cascaded style is used(i.e. CSS is embedded into HTML(markup) which
is not recommended due to which css written in files have less precendece
over css written in markup.

Thanks,
Surinder


On Fri, Jun 23, 2017 at 2:08 PM, Dave Page  wrote:

> Thanks - all applied!
>
> On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman 
> wrote:
>
>> Hello Dave,
>>
>> We noticed that the makefile is not installing node_modules
>> dependencies, so we created a new patch that changes the makefile to
>> install node_modules first and then execute the tasks.
>>
>> Thanks
>> Matt && João
>>
>> On Tue, Jun 20, 2017 at 5:23 AM, Dave Page  wrote:
>>
>>> Hi,
>>>
>>> This fails tests:
>>>
>>> (pgadmin4)piranha:pgadmin4 dpage$ make check-feature
>>> cd web && yarn run bundle && python regression/runtests.py --pkg
>>> feature_tests
>>> yarn run v0.24.6
>>> $ yarn run linter && yarn run webpacker
>>> yarn run v0.24.6
>>> $ yarn run eslint pgadmin/static/jsx/**/*.jsx
>>> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
>>> regression/javascript/**/*.js *.js
>>> yarn run v0.24.6
>>> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint"
>>> pgadmin/static/jsx/history/query_history.jsx
>>> pgadmin/static/jsx/history/query_history_entry.jsx
>>> pgadmin/static/js/selection/active_cell_capture.js
>>> pgadmin/static/js/selection/clipboard.js
>>> pgadmin/static/js/selection/column_selector.js
>>> pgadmin/static/js/selection/copy_data.js
>>> pgadmin/static/js/selection/grid_selector.js
>>> pgadmin/static/js/selection/range_boundary_navigator.js
>>> pgadmin/static/js/selection/range_selection_helper.js
>>> pgadmin/static/js/selection/row_selector.js
>>> pgadmin/static/js/selection/set_staged_rows.js
>>> pgadmin/static/js/selection/xcell_selection_model.js
>>> regression/javascript/history/query_history_entry_spec.jsx
>>> regression/javascript/history/query_history_spec.jsx
>>> regression/javascript/browser/menu_spec.js
>>> regression/javascript/history/history_collection_spec.js
>>> regression/javascript/selection/active_cell_capture_spec.js
>>> regression/javascript/selection/column_selector_spec.js
>>> regression/javascript/selection/copy_data_spec.js
>>> regression/javascript/selection/grid_selector_spec.js
>>> regression/javascript/selection/range_boundary_navigator_spec.js
>>> regression/javascript/selection/range_selection_helper_spec.js
>>> regression/javascript/selection/row_selector_spec.js
>>> regression/javascript/selection/set_staged_rows_spec.js
>>> regression/javascript/selection/xcell_selection_model_spec.js
>>> regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js
>>> webpack.config.js webpack.test.config.js
>>> ✨  Done in 1.17s.
>>> ✨  Done in 1.40s.
>>> yarn run v0.24.6
>>> $ yarn run webpack -- --config webpack.config.js
>>> yarn run v0.24.6
>>> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack" --config
>>> webpack.config.js
>>> (node:33997) DeprecationWarning: loaderUtils.parseQuery() received a
>>> non-string value which can be problematic, see
>>> https://github.com/webpack/loader-utils/issues/56
>>> parseQuery() will be replaced with getOptions() in the next major
>>> version of loader-utils.
>>> Hash: fe4471bbef0e7c5081ef
>>> Version: webpack 2.3.3
>>> Time: 1552ms
>>>  Asset Size  ChunksChunk Names
>>> reactComponents.js  1.21 MB   0  [emitted]  [big]  reactComponents
>>> history.js  5.37 kB   1  [emitted] history
>>>   slickgrid.js  4.78 kB   2  [emitted] slickgrid
>>>[5] /Users/dpage/git/pgadmin4/web/~/object-assign/index.js 2.11 kB
>>> {0} [built]
>>>   [20] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0}
>>> [built]
>>>   [32] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0}
>>> [built]
>>>  [196] ./js/history/history_collection.js 1.91 kB {1} [built]
>>>  [197] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
>>>  [198] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0}
>>> [built]
>>>  [199] ./bundle/components.js 604 bytes {0} [built]
>>>  [200] ./bundle/slickgrid.js 620 bytes {2} [built]
>>>  [201] ./js/history/index.js 690 bytes {1} [built]
>>>  [202] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
>>>  [233] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
>>> kB {0} [built]
>>>  [282] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/findDOMNode.js
>>> 2.46 kB {0} [built]
>>>  [296] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js
>>> 15.8 kB {0} [built]
>>>  [297] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js
>>> 1.32 kB {0} [built]
>>>  [298] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350
>>> bytes {0} [built]
>>> + 288 hidden module

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

[Dave Page]

Hi

On Fri, Jun 23, 2017 at 11:33 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> On latest git pull, couple of issues:
>
> 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana.
> 2. The dotted border around cell appears again.
>
> The class 'ui-widget' is added dynamically which i don't know why it is
> added.
>
> Also, Cascaded style is used(i.e. CSS is embedded into HTML(markup) which
> is not recommended due to which css written in files have less precendece
> over css written in markup.
>

Where are you seeing these changes? I can't spot them in the diff (though,
I've only looked at changes to our code).


> Thanks,
> Surinder
>
>
> On Fri, Jun 23, 2017 at 2:08 PM, Dave Page  wrote:
>
>> Thanks - all applied!
>>
>> On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman 
>> wrote:
>>
>>> Hello Dave,
>>>
>>> We noticed that the makefile is not installing node_modules
>>> dependencies, so we created a new patch that changes the makefile to
>>> install node_modules first and then execute the tasks.
>>>
>>> Thanks
>>> Matt && João
>>>
>>> On Tue, Jun 20, 2017 at 5:23 AM, Dave Page  wrote:
>>>
 Hi,

 This fails tests:

 (pgadmin4)piranha:pgadmin4 dpage$ make check-feature
 cd web && yarn run bundle && python regression/runtests.py --pkg
 feature_tests
 yarn run v0.24.6
 $ yarn run linter && yarn run webpacker
 yarn run v0.24.6
 $ yarn run eslint pgadmin/static/jsx/**/*.jsx
 pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx
 regression/javascript/**/*.js *.js
 yarn run v0.24.6
 $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint"
 pgadmin/static/jsx/history/query_history.jsx
 pgadmin/static/jsx/history/query_history_entry.jsx
 pgadmin/static/js/selection/active_cell_capture.js
 pgadmin/static/js/selection/clipboard.js
 pgadmin/static/js/selection/column_selector.js
 pgadmin/static/js/selection/copy_data.js
 pgadmin/static/js/selection/grid_selector.js
 pgadmin/static/js/selection/range_boundary_navigator.js
 pgadmin/static/js/selection/range_selection_helper.js
 pgadmin/static/js/selection/row_selector.js
 pgadmin/static/js/selection/set_staged_rows.js
 pgadmin/static/js/selection/xcell_selection_model.js
 regression/javascript/history/query_history_entry_spec.jsx
 regression/javascript/history/query_history_spec.jsx
 regression/javascript/browser/menu_spec.js
 regression/javascript/history/history_collection_spec.js
 regression/javascript/selection/active_cell_capture_spec.js
 regression/javascript/selection/column_selector_spec.js
 regression/javascript/selection/copy_data_spec.js
 regression/javascript/selection/grid_selector_spec.js
 regression/javascript/selection/range_boundary_navigator_spec.js
 regression/javascript/selection/range_selection_helper_spec.js
 regression/javascript/selection/row_selector_spec.js
 regression/javascript/selection/set_staged_rows_spec.js
 regression/javascript/selection/xcell_selection_model_spec.js
 regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js
 webpack.config.js webpack.test.config.js
 ✨  Done in 1.17s.
 ✨  Done in 1.40s.
 yarn run v0.24.6
 $ yarn run webpack -- --config webpack.config.js
 yarn run v0.24.6
 $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack" --config
 webpack.config.js
 (node:33997) DeprecationWarning: loaderUtils.parseQuery() received a
 non-string value which can be problematic, see
 https://github.com/webpack/loader-utils/issues/56
 parseQuery() will be replaced with getOptions() in the next major
 version of loader-utils.
 Hash: fe4471bbef0e7c5081ef
 Version: webpack 2.3.3
 Time: 1552ms
  Asset Size  ChunksChunk Names
 reactComponents.js  1.21 MB   0  [emitted]  [big]  reactComponents
 history.js  5.37 kB   1  [emitted] history
   slickgrid.js  4.78 kB   2  [emitted] slickgrid
[5] /Users/dpage/git/pgadmin4/web/~/object-assign/index.js 2.11 kB
 {0} [built]
   [20] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0}
 [built]
   [32] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0}
 [built]
  [196] ./js/history/history_collection.js 1.91 kB {1} [built]
  [197] ./jsx/history/query_history.jsx 3.65 kB {0} [built]
  [198] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0}
 [built]
  [199] ./bundle/components.js 604 bytes {0} [built]
  [200] ./bundle/slickgrid.js 620 bytes {2} [built]
  [201] ./js/history/index.js 690 bytes {1} [built]
  [202] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built]
  [233] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14
 kB {0} [built]
  [282] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/findDOMNode.j

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

[Dave Page]

On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Sorry, I forgot to attach screenshot.
> I looked into Query tool HTML using inspect tool.
>
>
That's code that's part of SlickGrid isn't it? If there are improvements to
be made there, patches should be sent upstream. We don't want to modify
(and thus have to vendorise) 3rd party code unless it's absolutely
essential.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

[Surinder Kumar]

On Fri, Jun 23, 2017 at 4:21 PM, Dave Page  wrote:

>
>
> On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar <
> surinder.ku...@enterprisedb.com> wrote:
>
>> Sorry, I forgot to attach screenshot.
>> I looked into Query tool HTML using inspect tool.
>>
>>
> That's code that's part of SlickGrid isn't it? If there are improvements
> to be made there, patches should be sent upstream. We don't want to modify
> (and thus have to vendorise) 3rd party code unless it's absolutely
> essential.
>
​Yes its part of SlickGrid and changes should go into slick grid repo.​

>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Murtuza Zabuawala]

Hi Dave,

Please find updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Yes, I'm looking into it, I will send updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jun 23, 2017 at 2:32 PM, Dave Page  wrote:
>
>> On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
>>  wrote:
>> > Yes Dave,
>> >
>> > You are right, I tested and found that indirect debugging is not
>> working.
>> > But otherwise for direct debugging it works properly.
>>
>> Does the patch take that into account, or are you modifying it?
>>
>> > On Fri, Jun 23, 2017 at 1:20 PM, Dave Page  wrote:
>> >>
>> >> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>> >>  wrote:
>> >> > Hi,
>> >> >
>> >> > PFA patch to fix the issue in Debugger module where it was unable to
>> >> > start
>> >> > debugging if 'plugin_debugger' can not found in
>> >> > shared_preload_libraries.
>> >> > RM#2162
>> >> >
>> >> > Original patch by: Kit Yam Tse
>> >> > (who reported the issue)
>> >> >
>> >> > I just re-based it against current code.
>> >>
>> >> Isn't that code required? We do need plugin_debugger to be present for
>> >> global (indirect) debugging to work. I suppose it may not be required
>> >> for direct debugging, but I haven't tested that.
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/pgadmin/tools/debugger/__init__.py 
b/web/pgadmin/tools/debugger/__init__.py
index 79e5eae..39bf23f 100644
--- a/web/pgadmin/tools/debugger/__init__.py
+++ b/web/pgadmin/tools/debugger/__init__.py
@@ -207,17 +207,6 @@ def init_function(node_type, sid, did, scid, fid, 
trid=None):
 " and cannot be debugged."
 )
 else:
-# If user is super user then we should check debugger library is 
loaded or not
-if user['is_superuser']:
-status_in, rid_pre = conn.execute_scalar("SHOW 
shared_preload_libraries")
-if not status_in:
-return internal_server_error(gettext("Could not fetch 
debugger plugin information."))
-
-# Need to check if plugin is really loaded or not with 
"plugin_debugger" string
-if "plugin_debugger" not in rid_pre:
-ret_status = False
-msg = gettext("The debugger plugin is not enabled. Please 
add the plugin to the shared_preload_libraries setting in the postgresql.conf 
file and restart the database server.")
-
 status_in, rid_tar = conn.execute_scalar(
 "SELECT count(*) FROM pg_proc WHERE proname = 
'pldbg_get_target_info'")
 if not status_in:
@@ -385,6 +374,31 @@ def initialize_target(debug_type, sid, did, scid, func_id, 
tri_id=None):
 if not status:
 return internal_server_error(errormsg=str(msg))
 
+user = manager.user_info
+if debug_type == 'indirect':
+# If user is super user then we should check debugger library is
+# loaded or not
+if user['is_superuser']:
+status_in, rid_pre = conn.execute_scalar(
+"SHOW shared_preload_libraries"
+)
+if not status_in:
+return internal_server_error(
+gettext("Could not fetch debugger plugin information.")
+)
+
+# Need to check if plugin is really loaded or not with
+# "plugin_debugger" string
+if "plugin_debugger" not in rid_pre:
+msg = gettext(
+"The debugger plugin is not enabled. " \
+"Please add the plugin to the shared_preload_libraries " \
+"setting in the postgresql.conf file and restart the " \
+"database server.(Indirect debugging prerequisite)"
+)
+current_app.logger.debug(msg)
+return internal_server_error(msg)
+
 # Set the template path required to read the sql files
 template_path = 'debugger/sql'
 
diff --git a/web/pgadmin/tools/debugger/templates/debugger/js/debugger.js 
b/web/pgadmin/tools/debugger/templates/debugger/js/debugger.js
index 7e7e31f..c18e0d3 100644
--- a/web/pgadmin/tools/debugger/templates/debugger/js/debugger.js
+++ b/web/pgadmin/tools/debugger/templates/debugger/js/debugger.js
@@ -269,10 +269,13 @@ define([
   });
 }
   },
-  error: function(e) {
-Alertify.alert(
-  'Debug

pgAdmin 4 commit: Wait for the Tools menu to be populated when running

[Dave Page]

Wait for the Tools menu to be populated when running the feature tests, instead 
of failing.

Fix by Khushboo, based on Harshal's previous work.

Branch
--
master

Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b6d3369b31547f5042428a579aa92a1726ba7b5
Author: Khushboo Vashi 

Modified Files
--
.../feature_tests/pg_datatype_validation_test.py   |  4 +---
.../feature_tests/query_tool_journey_test.py   |  5 +---
web/pgadmin/feature_tests/view_data_dml_queries.py |  1 -
web/regression/feature_utils/pgadmin_page.py   | 27 ++
4 files changed, 29 insertions(+), 8 deletions(-)

Jenkins build is back to normal : pgadmin4-master-python33 #196

[pgAdmin 4 Jenkins]

See 

Re: [pgAdmin4][Patch] To fix the issue in Debugger module

[Dave Page]

Hi

I'm unable to properly test this, as the debugger doesn't even seem to
launch for a non-superuser. I just get a white tab, and a whole lot of
polling indefinitely. Can you debug if you're not a superuser, but you
own the function?

Looking at the patch itself, I wonder if the logic is still a little
off. You need to be a superuser to use indirect debugging (because of
the DOS potential), so shouldn't the superuser check be changed to "if
!superuser then throw error"? As it is, if you're not superuser then
it just skips the check for the plugin, which seems like it'll never
end well.


On Fri, Jun 23, 2017 at 1:35 PM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> Please find updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Jun 23, 2017 at 2:38 PM, Murtuza Zabuawala
>  wrote:
>>
>> Yes, I'm looking into it, I will send updated patch.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Jun 23, 2017 at 2:32 PM, Dave Page  wrote:
>>>
>>> On Fri, Jun 23, 2017 at 9:56 AM, Murtuza Zabuawala
>>>  wrote:
>>> > Yes Dave,
>>> >
>>> > You are right, I tested and found that indirect debugging is not
>>> > working.
>>> > But otherwise for direct debugging it works properly.
>>>
>>> Does the patch take that into account, or are you modifying it?
>>>
>>> > On Fri, Jun 23, 2017 at 1:20 PM, Dave Page  wrote:
>>> >>
>>> >> On Fri, Jun 23, 2017 at 7:16 AM, Murtuza Zabuawala
>>> >>  wrote:
>>> >> > Hi,
>>> >> >
>>> >> > PFA patch to fix the issue in Debugger module where it was unable to
>>> >> > start
>>> >> > debugging if 'plugin_debugger' can not found in
>>> >> > shared_preload_libraries.
>>> >> > RM#2162
>>> >> >
>>> >> > Original patch by: Kit Yam Tse
>>> >> > (who reported the issue)
>>> >> >
>>> >> > I just re-based it against current code.
>>> >>
>>> >> Isn't that code required? We do need plugin_debugger to be present for
>>> >> global (indirect) debugging to work. I suppose it may not be required
>>> >> for direct debugging, but I haven't tested that.
>>> >>
>>> >>
>>> >> --
>>> >> Dave Page
>>> >> Blog: http://pgsnake.blogspot.com
>>> >> Twitter: @pgsnake
>>> >>
>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> The Enterprise PostgreSQL Company
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

[Atul Sharma]

Hi,

Please find updated patch.

Regards,
Atul

On Thu, Jun 22, 2017 at 5:02 PM, Dave Page  wrote:

> Hi
>
> On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma
>  wrote:
> > Hi,
> >
> > Please find attached patch for RM #2191 : Add support for hostaddr
> > connection parameter
>
> Unfortunately there are a few issues with this patch:
>
> - It needs rebasing (blame Ashesh :-p )
>
> - It's missing the documentation update (and screenshot update)
>
> - I'm not sure the validation for a valid IPv6 address in
> check_for_valid_ipv6 is correct. For example:
>
> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('::1');
> false
> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('fe80::187f:316f:4bb8:8a3d');
> false
>
> Both of those are valid addresses.
>
> Note that I've only eye-balled the patch so far, as I was unable to
> apply it without manual work.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_2191_ver2.patch
Description: Binary data

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

[Dave Page]

Hi,

I'm getting:

(pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch
error: cannot apply binary patch to
'docs/en_US/images/server_advanced.png' without full index line
error: docs/en_US/images/server_advanced.png: patch does not apply

when trying to apply. If memory serves, this normally happens if you
forget to use --binary when creating the diff.

Can you send an updated version please?

On Fri, Jun 23, 2017 at 3:59 PM, Atul Sharma
 wrote:
> Hi,
>
> Please find updated patch.
>
> Regards,
> Atul
>
> On Thu, Jun 22, 2017 at 5:02 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma
>>  wrote:
>> > Hi,
>> >
>> > Please find attached patch for RM #2191 : Add support for hostaddr
>> > connection parameter
>>
>> Unfortunately there are a few issues with this patch:
>>
>> - It needs rebasing (blame Ashesh :-p )
>>
>> - It's missing the documentation update (and screenshot update)
>>
>> - I'm not sure the validation for a valid IPv6 address in
>> check_for_valid_ipv6 is correct. For example:
>>
>> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('::1');
>> false
>> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('fe80::187f:316f:4bb8:8a3d');
>> false
>>
>> Both of those are valid addresses.
>>
>> Note that I've only eye-balled the patch so far, as I was unable to
>> apply it without manual work.
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4]

[Dave Page]

Hi Harshal,

When can we expect an updated version of this patch? I think it's
important to get this into the next release.

Thanks!

On Fri, Jun 16, 2017 at 10:55 AM, Dave Page  wrote:
> Hi,
>
> That's better - the failures are far less random now :-). I got the
> following two though, on both PG and EPAS 9.5:
>
> ==
> ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest)
> Query tool feature test
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
> line 95, in runTest
> self._query_tool_explain_analyze_buffers()
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/query_tool_tests.py",
> line 443, in _query_tool_explain_analyze_buffers
> canvas.find_element_by_xpath("//*[contains(string(), 'Shared Read
> Blocks')]")
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
> line 260, in find_element_by_xpath
> return self.find_element(by=By.XPATH, value=xpath)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
> line 508, in find_element
> {"using": by, "value": value})['value']
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
> line 491, in _execute
> return self._parent.execute(command, params)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
> line 238, in execute
> self.error_handler.check_response(response)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
> line 193, in check_response
> raise exception_class(message, screen, stacktrace)
> NoSuchElementException: Message: no such element: Unable to locate
> element: {"method":"xpath","selector":"//*[contains(string(), 'Shared
> Read Blocks')]"}
>   (Session info: chrome=58.0.3029.110)
>   (Driver info: chromedriver=2.29.461585
> (0be2cd95f834e9ee7c46bcc7cf405b483f5ae83b),platform=Mac OS X 10.12.3
> x86_64)
>
>
> ==
> ERROR: runTest 
> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
> Validate Insert, Update operations in View data with given test data
> --
> Traceback (most recent call last):
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 104, in runTest
> self._add_row()
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 255, in _add_row
> self._update_cell(cell_xpath, config_data[str(idx)])
>   File 
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 164, in _update_cell
> cell_el = self.page.find_by_xpath(xpath)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 122, in find_by_xpath
> return self.wait_for_element(lambda driver:
> driver.find_element_by_xpath(xpath))
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 205, in wait_for_element
> return self._wait_for("element to exist", element_if_it_exists)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 255, in _wait_for
> "Timed out waiting for " + waiting_for_message)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/support/wait.py",
> line 71, in until
> value = method(self._driver)
>   File 
> "/Users/dpage/git/pgadmin4/web/regression/feature_utils/pgadmin_page.py",
> line 200, in element_if_it_exists
> if element.is_displayed() and element.is_enabled():
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
> line 358, in is_displayed
> return self._execute(Command.IS_ELEMENT_DISPLAYED)['value']
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webelement.py",
> line 491, in _execute
> return self._parent.execute(command, params)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py",
> line 238, in execute
> self.error_handler.check_response(response)
>   File 
> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py",
> line 193, in check_response
> raise exception_class(message, screen, stacktrace)
> StaleElementReferenceException: Message: stale element reference:
> element is not attached to the page document
>   (Session info: chrome=58.0.3029.110)
>   (Dri

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

[Atul Sharma]

Hi Dave,

Please find updated version attached.

Regards,
Atul

On Fri, Jun 23, 2017 at 8:49 PM, Dave Page  wrote:

> Hi,
>
> I'm getting:
>
> (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM_2191_ver2.patch
> error: cannot apply binary patch to
> 'docs/en_US/images/server_advanced.png' without full index line
> error: docs/en_US/images/server_advanced.png: patch does not apply
>
> when trying to apply. If memory serves, this normally happens if you
> forget to use --binary when creating the diff.
>
> Can you send an updated version please?
>
> On Fri, Jun 23, 2017 at 3:59 PM, Atul Sharma
>  wrote:
> > Hi,
> >
> > Please find updated patch.
> >
> > Regards,
> > Atul
> >
> > On Thu, Jun 22, 2017 at 5:02 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma
> >>  wrote:
> >> > Hi,
> >> >
> >> > Please find attached patch for RM #2191 : Add support for hostaddr
> >> > connection parameter
> >>
> >> Unfortunately there are a few issues with this patch:
> >>
> >> - It needs rebasing (blame Ashesh :-p )
> >>
> >> - It's missing the documentation update (and screenshot update)
> >>
> >> - I'm not sure the validation for a valid IPv6 address in
> >> check_for_valid_ipv6 is correct. For example:
> >>
> >> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('::1');
> >> false
> >> /^(?:[A-F0-9]{1,4}:){7}[A-F0-9]{1,4}$/.test('fe80::187f:
> 316f:4bb8:8a3d');
> >> false
> >>
> >> Both of those are valid addresses.
> >>
> >> Note that I've only eye-balled the patch so far, as I was unable to
> >> apply it without manual work.
> >>
> >> Thanks!
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM_2191_ver4.patch
Description: Binary data