[opensource-dev] STORM-467

[Twisted Laws]

Added a patch for STORM-467 2.x minimap zoom does not persist to the next 
session thats needs review and to be applied.
Note that I mistakenly added this same patch to STORM-466 (too early in the 
morning) and I'm not sure how to remove it from there.
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-466

[Twisted Laws]

Ok, figured out how to get rid of the bad attachment from 467 and created a 
patch for Storm-466 as well to add a zoom default to the minimap menu in 
english.  from my understanding this should not break other languages, the menu 
option just won't appear.   So if theres interest in fixing 466, theres a patch 
available now.
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] cmake issues with latest pull 12/22 - r14261:5d69e36a53ee

[Twisted Laws]

after pulling these changes, cmake . seems to go into a loop or something and 
never does anything and never exits on windows 7 (64), vc 2005.  is it just me?
this is after the social fixes and a lot of checkins from callum
if you break it...
 
$ Traceback (most recent call last):
  File "install.py", line 1150, in 
sys.exit(main())
  File "install.py", line 1142, in main
options.scp)
  File "install.py", line 636, in do_install
cache_dir)
  File "install.py", line 595, in install
ifile.fetch_local()
  File "install.py", line 135, in fetch_local
file(self.filename, 'wb').write(urllib2.urlopen(self.url).read())
  File "C:\Python26\Lib\socket.py", line 327, in read
data = self._sock.recv(rbufsize)
  File "C:\Python26\lib\httplib.py", line 537, in read
s = self.fp.read(amt)
  File "C:\Python26\Lib\socket.py", line 351, in read
data = self._sock.recv(left)
KeyboardInterrupt
close failed in file object destructor:
Error in sys.excepthook:
Original exception was:
 
Note there is nothing further printed... so i don't know what the original 
exception was
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] cmake issues with latest pull 12/22 - r14261:5d69e36a53ee

[Twisted Laws]

i'm guessing the file it wanted to download (llqtwebkit) just wasn't available 
at the time and it blocked for some reason.
works fine today.  sorry for the interruption
 


orig: after pulling these changes, cmake . seems to go into a loop or something 
and never does anything and never exits on windows 7 (64), vc 2005.  is it just 
me?
this is after the social fixes and a lot of checkins from callum
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] build 218026 silently failing

[Twisted Laws]

I may have seen this on around 4 occasions while in the sandboxes over the last 
month.  I've always assumed it was a bad object and immediately logged back in 
and ran in the debugger but it didn't re-occur.  Its just a poof and its gone 
with nothing useful in the log files.  My builds are a daily pull from 
viewer-development and compiled daily but I have some changes of my own in the 
viewer so I've not reported it but have tried to track it down.  (Figured it 
was some error of mine since I'm still trying to get used to all the changes in 
folder and panel views.)  My environment is Microsoft Windows 7 64-bit  (Build 
7600), compiled with vc2005 express.
 


From: me...@lindenlab.com
Date: Tue, 4 Jan 2011 10:01:04 -0800
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] build 218026 silently failing

Hi,


On Mon, Jan 3, 2011 at 7:52 PM, Erin Mallory  
wrote:


build 218026 seems to just continuously silently fail. it doesn;t seem to 
trigger any particular error and i cannot figure out what is triggering it, 
other then possibly a memory leak.
It just is there one moment and gone the next, leaving behind two instances of 
SLplugin.  for a breif moment when this happens the secondlifedevelopement.exe 
file is still in the list usually taking up INSANE amounts of memory (more then 
2 gig ram and 4 gig virtual), but only for a moment.  it doesn't even trigger 
the crash logger.
It does seem to happen most when i am in the middle of typing something into an 
im window but i can't consistently repo it enough to determine if that has 
something to do with it.  I'm really frustrated and wondering if anyone else 
running this build or one from about the same timeframe is seeing this as well?


 Hmmm... This is concerning. I suppose you're using the Windows build though, 
to avoid ambiguities, please mention the operating system you're using in your 
future reports.

I certainly don't repro on Mac but I don't follow a very typical use pattern. 

Anyone else seeing this issue? On which platform?

Thanks for the report Erin.

Cheers,
- Merov

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

[Twisted Laws]

that would be bad to check for "/me", what about "/meow" ?

 


From: aleric.inglew...@gmail.com
To: opensource-dev@lists.secondlife.com; aleric.inglew...@gmail.com; 
jhwe...@gmail.com
Date: Thu, 6 Jan 2011 22:03:14 +
Subject: Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse 
/me in object Instant Messages






This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/71/ 


On January 6th, 2011, 7 a.m., Aleric Inglewood wrote:
What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", "/me!", 
etc...
Just asking because these comparisions with just "/me " and "/me'" seem very 
limited,
almost weird. More logical would be to not check anything at ALL - and either 
expand
things, or not. What happens if you just set a flag saying "whatever is in this
string, don't expand /me, /who, /whois, /kick etc" without at that point 
checking
for one specific case (missing possibly many other variations).

On January 6th, 2011, 7:45 a.m., Jonathan Yap wrote:
If it was me writing the original code I would not have made it case-sensitive, 
but as this is a bug fix and not a new feature I am following the current 
design of having just /me work.  I didn't suggest to make it case insensitive, 
I wondered what happens
when you use /ME instead of /me with and without the patch.
And I wonder why it is necessary at all to compare a string with "/me ".
At the very least that indicates code duplication.

Let me clarify,

void do_it(std::string const& str)
{
  if (!flag && str == "/me")
...
  else
...
}

Bad code:

if (str == "/me")
  flag = 1;
do_it(str);

---

Code that makes more sense:

flag = 1;
do_it(str);


But keep in mind that I didn't look at the actual code ;). I just looked at 
your patch.


- Aleric

On January 5th, 2011, 6:14 p.m., Jonathan Yap wrote:




Review request for Viewer.
By Jonathan Yap.
Updated Jan. 5, 2011, 6:14 p.m.
Description 



The "/me" in the lsl code below would be displayed rather than being translated 
to a name:
llInstantMessage(llGetOwner(),"/me Hello, Avatar!");
Bugs: STORM-829 
Diffs 

indra/newview/llviewermessage.cpp (845cab866155)
View Diff
___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] failed to find libboost_system-vc80-mt-1_39.lib in non-standalone

[Twisted Laws]

A fresh clone of viewer-development up to r14487:5f4034c58817 1/12/2011 fails 
to buid non-standalone because of missing the libboost_system-vc80-mt-1_39.lib 
(or debug version).
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] failed to find libboost_system-vc80-mt-1_39.lib in non-standalone

[Twisted Laws]

of course i forgot to say on Windows 7 64 with vc 2005 express
 


From: twisted_l...@hotmail.com
To: opensource-dev@lists.secondlife.com
Date: Wed, 12 Jan 2011 20:46:30 -0500
Subject: [opensource-dev] failed to find libboost_system-vc80-mt-1_39.lib in 
non-standalone




A fresh clone of viewer-development up to r14487:5f4034c58817 1/12/2011 fails 
to buid non-standalone because of missing the libboost_system-vc80-mt-1_39.lib 
(or debug version).
 

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/78/#review148
---


To me, this is the wrong solution.  label_selected used to work to allow a 
button to display different text when it was selected, so you could have a 
button that said More until it was pressed or selected and displayed more 
informaiton.  At that time the text could change to Less indicating that 
pressing the button a second time would maybe reduce the information displayed. 
 If the button in question here doesn't change when pressing, that means that 
something down in the control code is wrong. 

- Twisted


On Jan. 12, 2011, 6:02 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/78/
> ---
> 
> (Updated Jan. 12, 2011, 6:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> "More" should be "Less" when Media Control is open
> 
> This is a trivial text change in an xml file.  The reason I am posting this 
> here is due to some confusion using label_selected.  In this case having it 
> set to a different value than when label is set to seems to have no effect, 
> so I have made them identical.
> 
> I scanned all the xml files and there are only about 5 places where 
> label_selected is different from the preceding label= value.
> 
> Is there any reason to revert back to having them set to different values?
> i.e. label="More" and label_selected="Less"
> 
> 
> This addresses bug storm-844.
> http://jira.secondlife.com/browse/storm-844
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 179e0754a27d 
>   indra/newview/skins/default/xui/en/panel_nearby_media.xml 179e0754a27d 
> 
> Diff: http://codereview.secondlife.com/r/78/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

[Twisted Laws]

> On Jan. 13, 2011, 8:05 a.m., Twisted Laws wrote:
> > To me, this is the wrong solution.  label_selected used to work to allow a 
> > button to display different text when it was selected, so you could have a 
> > button that said More until it was pressed or selected and displayed more 
> > informaiton.  At that time the text could change to Less indicating that 
> > pressing the button a second time would maybe reduce the information 
> > displayed.  If the button in question here doesn't change when pressing, 
> > that means that something down in the control code is wrong.
> 
> Jonathan Yap wrote:
> I did a test with the floater preview UI (one of the few places that 
> label is not the same as label_selected.  There is a >> button there that 
> does change to << when pressed.
> 
> However, in this case, there is some code that does the button swapping.  
> In llpanelnearbymedia.cpp / void LLPanelNearByMedia::onMoreLess()
> 
>   getChild("more_btn")->setVisible(!is_more);
>   getChild("less_btn")->setVisible(is_more);
> 
> If people think refactoring rather then just rewording is the way to go 
> please say so.  I always hesitate to "fix what ain't broke".
> 
> The vast majority of button definitions in the xml files have identical 
> entries for label and label_selected (is having label_selected present a 
> requirement in a button definition or are all these entires superfluous?).

I looked into this and have a patch that corrects it.  What the patch does in 
llPanelNearByMedia::onMoreLess(), the first statement is changed to bool 
is_more = getChild("more_btn")->getToggleState();  the two statements 
Jonathan shows are changed to just one 
getChild("more_btn")->setVisible(true); (may just be removed and not 
be necessary) and in the xml file, the first more_btn gets is_toggle="true" 
added and the less_btn is removed.  My patch file is attached to STORM-844.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/78/#review148
---


On Jan. 12, 2011, 6:02 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/78/
> ---
> 
> (Updated Jan. 12, 2011, 6:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> "More" should be "Less" when Media Control is open
> 
> This is a trivial text change in an xml file.  The reason I am posting this 
> here is due to some confusion using label_selected.  In this case having it 
> set to a different value than when label is set to seems to have no effect, 
> so I have made them identical.
> 
> I scanned all the xml files and there are only about 5 places where 
> label_selected is different from the preceding label= value.
> 
> Is there any reason to revert back to having them set to different values?
> i.e. label="More" and label_selected="Less"
> 
> 
> This addresses bug storm-844.
> http://jira.secondlife.com/browse/storm-844
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 179e0754a27d 
>   indra/newview/skins/default/xui/en/panel_nearby_media.xml 179e0754a27d 
> 
> Diff: http://codereview.secondlife.com/r/78/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Twisted Laws]

Personally I see no reason for it and a user could have a simple script they 
are wearing that triggers on changed, CHANGE_REGION, that tells them the 
version of the server if they are interested.  
 
default
{
  on_rez(integer start_param)
  {
 llOwnerSay(llGetRegionName + " " + llGetEnv("sim_channel") + " " + 
llGetEnv("sim_version"));
  }
   changed(integer change)
   {
  if(change & CHANGED_REGION)
 {
 llOwnerSay(llGetRegionName + " " + llGetEnv("sim_channel") + " " + 
llGetEnv("sim_version"));
 }
  }
}
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

[Twisted Laws]

> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote:
> > indra/newview/lltexturecache.cpp, line 1595
> > 
> >
> > validate_idx being used in a test later, it's not just for 
> > (validate_idx == 0) that the behavior will be different. I need to 
> > understand better what that idx is all about or you need to give a bit more 
> > explanation before I approve this diff.
> 
> Aleric Inglewood wrote:
> The debug setting CacheValidateCounter is set to 'next_id', which makes 
> clear what it's meaning is: namely, the id that we will check next time. 
> next_idx is a very local variable that is simply set to the value of 
> CacheValidateCounter plus 1, and then that value is stored to 
> CacheValidateCounter again for next time.
> 
> validate_idx is the ID that is actually being tested this time. Hence, it 
> should be the value of CacheValidateCounter before we increase that.
> 
> Obviously, those ID's should be in the range 0...255, which is garanteed 
> by doing a modulo 256 on next_id before writing it to CacheValidateCounter.
> 
> The old code also increases validate_idx *before* it is used. That means 
> that it will be in the range 1...256, and 0 is never tested (note that 
> validate_idx is just increased, there is no modulo applied, so it's obvious 
> that it shouldn't be increased). Even the wording ("next"_id) suggests that 
> validate_idx should just be the value of CacheValidateCounter, which is the 
> value of the previous next_id...
> 
> So, after this patch, we get to the following code with validate_idx in 
> the range 0...255, as it should be.
>
> 
> Cron Stardust wrote:
> Just double checking, as switching from pre-increment to addition can 
> change behavior: In both cases next_idx will have the same value after this 
> line is executed, however validate_idx will not.
> 
> Prediff start state: validate_idx == 0;
> Prediff stop state: validate_idx == 1; next_idx == 1;
> 
> Postdiff start state: validate_idx == 0;
> Postdiff stop state: validate_idx == 0; next_idx == 1;
> 
> And another round over at the other end:
> 
> Prediff start state: validate_idx == 255;
> Prediff stop state: validate_idx == 256; next_idx == 0;
> 
> Postdiff start state: validate_idx == 255;
> Postdiff stop state: validate_idx == 255; next_idx == 0;
> 
> So, yes, validate_idx will only have a 255 in it in this last case, 
> however the over-all behavior has changed: validate_idx isn't being 
> incremented at all in this line.
> 
> WARNING: I have NOT looked at the rest of the diff, only at this one 
> line.  Nor do I know if validate_idx should or shouldn't be incremented by 
> this line of code.

Given the way this seems to work to me without changing the sequence things are 
checked...  
I'd change line 1619 to  if (uuididx == (validate_idx % 256))
Otherwise it was checking for 1 thru 256 and never 0...  this does not change 
what appears
to be incorrect coding where Aleric pointed out and thus won't change the 
current
logic that it starts by checking 1 thru 255 before checking 0.  To retain the 
current sequence
that things are checked, you would have to compare uuididx to next_idx along 
with the change
Aleric provided.

However it seems to me that all is ok with using Aleric's correction and 
leaving the remaining
code untouched.  (I can't see where changing the sequence of checking makes a 
difference.)


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/#review191
---


On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/90/
> ---
> 
> (Updated Jan. 14, 2011, 1:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Trivial patch, just removes stupidity.
> 
> 
> This addresses bug VWR-24321.
> http://jira.secondlife.com/browse/VWR-24321
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/90/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-643

[Twisted Laws]

Added a patch to https://jira.secondlife.com/browse/STORM-643 Embed Minimap 
into Nearby list of People Sidebar.   I know I never make the meetings that 
would probably help determine if this would be included in the viewer, but it 
does help make viewer 2 just a little better than it was in my opinion.  
Additionally, selecting a user in the nearby avatar list will highlight the 
avatar on the minimap.  The patch also corrects an error I don't see in the 
Jira where the minimap hovertip is incorrect if double click teleport is 
enabled. 
 
I hope you find the patch useful.
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/
---

Review request for Viewer.


Summary
---

This patch fulfils STORM-643 by putting a copy of the mini-map control into the 
top of the Nearby tab of the People panel.  Both this and the mini-map can be 
open at the same time.  While working on this a bug was noticed in the hovertip 
of the minimap and a solution proposed for that as well although that adds a 
translation task.  Some of the code from llfloatermap.cpp is actually 
duplicated here without removing the code from there.  This doesn't have an 
effect since the control is pushed to the back in llfloatermap.cpp.  The code 
duplication could be removed from llfloatermap.cpp (the original source) but 
that may affect something I'm not aware of.


This addresses bug STORM-643.
http://jira.secondlife.com/browse/STORM-643


Diffs
-

  indra/newview/llfloatermap.cpp 26c09ad4293e 
  indra/newview/llnetmap.h 26c09ad4293e 
  indra/newview/llnetmap.cpp 26c09ad4293e 
  indra/newview/llpanelpeople.h 26c09ad4293e 
  indra/newview/llpanelpeople.cpp 26c09ad4293e 
  indra/newview/skins/default/xui/en/floater_map.xml 26c09ad4293e 
  indra/newview/skins/default/xui/en/panel_people.xml 26c09ad4293e 

Diff: http://codereview.secondlife.com/r/124/diff


Testing
---

This patch seems to work fine and tested under by compiling and running under 
Windows 7.0 (64) and Ubuntu Linux.

Tested by having all combinations of mini-map (existing) open and closed, 
having the people panel open on all of the different tabs with the only effect 
on the Nearby tab, and having the panel docked in sidebar and not docked.  The 
highlighting of avatars that are selected in the avatar list only affect the 
copy of the mini-map displayed there.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Test Viewer

[Twisted Laws]

Dang its nice to run a viewer with kdu instead of openjpeg  Made me go ride 
the train thru 20 or so regions!
 
STORM-236 Allow the "Speak" button to be removed, like other buttons 
Seems to work as expected

STORM-348 "Edit this shape button" button and "lock" icon are shown after each 
body part name after resizing the floater 
(not tested)

STORM-373 'Rename' option is disabled if the inventory context menu was opened 
by right mouse click without preliminary selection 
Available after a brief period time (less than a second)

STORM-465 Missing Strings from strings.xml 
2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in 
strings.xml: [LSLTipText_llSound]
2011-01-26T19:30:59Z WARNING: LLTrans::findString: ONCE: Missing String in 
strings.xml: [InvFolder Favorites]
all the other ones disappeared tho

STORM-547 Name of blocked person is not presented in list if person was blocked 
from Inspector 
Seems to work as expected

STORM-643 Embed Minimap into the Nearby list of the People Sidebar 
Seems to work as expected, except Stop tracking is never enabled (simple 3 line 
patch should fix that), and the directions are not displayed (this was not done 
because of the impact it would have on other people panel code, investigating a 
llnetmap.cpp method for a future patch)

STORM-843 Inventory incremental string search not working (search starts over) 
Search very responsive :)

STORM-845 Up arrow icon on nearby chat for "Shows/hides nearby chat log" always 
shows as an up arrow. Should, show change to down arrow to indicate close when 
log is open. 
Changes as expected

And I like the mini-map in the nearby people tab :)   Its a good start.
 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml

[Twisted Laws]

> On Jan. 20, 2011, 6:46 a.m., Seth ProductEngine wrote:
> > No missing string warnings while looking through the menu with this patch.

2011-01-26T19:57:39Z WARNING: LLTrans::getString: ONCE: Missing String in 
strings.xml: [LSLTipText_llSound]
2011-01-26T19:30:59Z WARNING: LLTrans::findString: ONCE: Missing String in 
strings.xml: [InvFolder Favorites]

Not saying they should hold anything up tho.  This came from running Oz's build 
with this patch applied.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/108/#review208
---


On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/108/
> ---
> 
> (Updated Jan. 19, 2011, 8:30 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Made all keys localizable.
> 
> 
> This addresses bug STORM-465.
> http://jira.secondlife.com/browse/STORM-465
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/strings.xml 38465c40c060 
> 
> Diff: http://codereview.secondlife.com/r/108/diff
> 
> 
> Testing
> ---
> 
> Tested on Linux. No keys produce the warning for me.
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-643 mini-map control displayed at top of Nearby people tab

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/124/
---

(Updated Jan. 26, 2011, 3:34 p.m.)


Review request for Viewer.


Changes
---

Patch after the original patch, this corrects the Stop Tracking menu option not 
working properly.


Summary
---

This patch fulfils STORM-643 by putting a copy of the mini-map control into the 
top of the Nearby tab of the People panel.  Both this and the mini-map can be 
open at the same time.  While working on this a bug was noticed in the hovertip 
of the minimap and a solution proposed for that as well although that adds a 
translation task.  Some of the code from llfloatermap.cpp is actually 
duplicated here without removing the code from there.  This doesn't have an 
effect since the control is pushed to the back in llfloatermap.cpp.  The code 
duplication could be removed from llfloatermap.cpp (the original source) but 
that may affect something I'm not aware of.


This addresses bug STORM-643.
http://jira.secondlife.com/browse/STORM-643


Diffs (updated)
-

  indra/newview/llnetmap.cpp 38ed1abd9cd9 

Diff: http://codereview.secondlife.com/r/124/diff


Testing
---

This patch seems to work fine and tested under by compiling and running under 
Windows 7.0 (64) and Ubuntu Linux.

Tested by having all combinations of mini-map (existing) open and closed, 
having the people panel open on all of the different tabs with the only effect 
on the Nearby tab, and having the panel docked in sidebar and not docked.  The 
highlighting of avatars that are selected in the avatar list only affect the 
copy of the mini-map displayed there.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] "Nearby" people tab

[Twisted Laws]

Added a viewer 2 patch to https://jira.secondlife.com/browse/VWR-17050 that 
corrects this issue.  Needs to be brought into STORM and applied.   
 
Twisted
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: No nearby people when over approxiamately 1000 meters

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/
---

Review request for Viewer.


Summary
---

This modifies the getAvatars function in llworld to also include any avatars 
that are found within the range from the LLCharactes list as well (the list of 
avatars that is in the viewer object list).  This should make sure that anyone 
that you visually see within range shows up in the list.  Note that changing it 
in this function also affects LLFloaterAvatarPicker::populateNearMe, 
LLLocalSpeakerMgr::updateSpeakerList, as well as the 
LLPanelPeople::updateNearbyList that was originally mentioned in the Jira.  The 
region avatars lists only contain valid position data when the avatars are 
below 1024m.  The comment that mentions about retrieving uuids is based on the 
function, not the current uses.  No current calls in the code are done with the 
avatar_ids argument NULL.  Duplicates in the returned list need to be 
suppressed.


This addresses bug VWR-17050.
http://jira.secondlife.com/browse/VWR-17050


Diffs
-

  indra/newview/llworld.cpp 691e3941d950 

Diff: http://codereview.secondlife.com/r/132/diff


Testing
---

Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
without avatars nearby.  Tested with varying the NearMeRange to insure it does 
not show avatars beyond the range.  Testers need to understand that 
RenderFarClip has an impact on the avatars that are actually in the viewer 
object list, so setting NearMeRange to a great distance at high altitude won't 
necessarily add avatars to the list.  Basically if you can see the avatar and 
its within NearMeRange, the avatar should be in the nearby avatar list in the 
people panel.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/
---

(Updated Jan. 31, 2011, 3:34 p.m.)


Review request for Viewer.


Changes
---

fixed the title


Summary (updated)
---

This modifies the getAvatars function in llworld to also include any avatars 
that are found within the range from the LLCharactes list as well (the list of 
avatars that is in the viewer object list).  This should make sure that anyone 
that you visually see within range shows up in the list.  Note that changing it 
in this function also affects LLFloaterAvatarPicker::populateNearMe, 
LLLocalSpeakerMgr::updateSpeakerList, as well as the 
LLPanelPeople::updateNearbyList that was originally mentioned in the Jira.  The 
region avatars lists only contain valid position data when the avatars are 
below 1024m.  The comment that mentions about retrieving uuids is based on the 
function, not the current uses.  No current calls in the code are done with the 
avatar_ids argument NULL.  Duplicates in the returned list need to be 
suppressed.


This addresses bug VWR-17050.
http://jira.secondlife.com/browse/VWR-17050


Diffs
-

  indra/newview/llworld.cpp 691e3941d950 

Diff: http://codereview.secondlife.com/r/132/diff


Testing
---

Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
without avatars nearby.  Tested with varying the NearMeRange to insure it does 
not show avatars beyond the range.  Testers need to understand that 
RenderFarClip has an impact on the avatars that are actually in the viewer 
object list, so setting NearMeRange to a great distance at high altitude won't 
necessarily add avatars to the list.  Basically if you can see the avatar and 
its within NearMeRange, the avatar should be in the nearby avatar list in the 
people panel.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] problems working with autobuild

[Twisted Laws]

So I figured I'd give the autobuild method of building a try.   I've not made 
it far yet 
and wondering if someone might give me a pointer on what I've done wrong...
 
I read: http://wiki.secondlife.com/wiki/Autobuild_Quick_Start
and read: 
https://lists.secondlife.com/pipermail/opensource-dev/2011-January/005633.html
v-autobuild is from: https://bitbucket.org/mani_linden/viewer-autobuild
 
I must be missing something here but I'm not sure what.  The autobuild/bin 
directory is 
in the path.   Python 2.6 installed.
 
Thanks for any hints,  session log follows  (note that the ./setup.py install 
fails, and i have
to use python setup.py install)
 
dir: /cygdrive/c/dev/hgbuilds
$ cd autobuild
dir: /cygdrive/c/dev/hgbuilds/autobuild
$ ls
autobuild  bin  build  setup.py
dir: /cygdrive/c/dev/hgbuilds/autobuild
$ ./setup.py install
./setup.py: line 23: from: command not found
./setup.py: line 27: PACKAGE_NAME: command not found
./setup.py: line 28: LLAUTOBUILD_VERSION: command not found
./setup.py: line 29: LLAUTOBUILD_SOURCE: command not found
./setup.py: line 30: CLASSIFIERS: command not found
./setup.py: line 41: ext_modules: command not found
./setup.py: line 43: syntax error near unexpected token `newline'
./setup.py: line 43: `setup('
dir: /cygdrive/c/dev/hgbuilds/autobuild
$ python setup.py install
running install
running build
running build_py
running build_scripts
running install_lib
running install_scripts
running install_egg_info
Removing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info
Writing C:\Python26\Lib\site-packages\autobuild-0.0.0-py2.6.egg-info
dir: /cygdrive/c/dev/hgbuilds/autobuild
$ cd ../v-autobuild
dir: /cygdrive/c/dev/hgbuilds/v-autobuild
$ autobuild configure -c OpenSourceRelWithDebInfo
C:\cygwin\bin\python: can't open file 
'/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file or 
directory
dir: /cygdrive/c/dev/hgbuilds/v-autobuild
$ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild
-rwxr-xr-x 1 John None 2213 Jan 31 20:37 
/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild
dir: /cygdrive/c/dev/hgbuilds/v-autobuild
$ ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/#review302
---



indra/newview/llworld.cpp
<http://codereview.secondlife.com/r/132/#comment225>

This area where I search for the existance of an uuid in the list is 
something that works but it would seem that theres some better method.  Open to 
suggestions.


- Twisted


On Jan. 31, 2011, 3:34 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/132/
> ---
> 
> (Updated Jan. 31, 2011, 3:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modifies the getAvatars function in llworld to also include any avatars 
> that are found within the range from the LLCharactes list as well (the list 
> of avatars that is in the viewer object list).  This should make sure that 
> anyone that you visually see within range shows up in the list.  Note that 
> changing it in this function also affects 
> LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, 
> as well as the LLPanelPeople::updateNearbyList that was originally mentioned 
> in the Jira.  The region avatars lists only contain valid position data when 
> the avatars are below 1024m.  The comment that mentions about retrieving 
> uuids is based on the function, not the current uses.  No current calls in 
> the code are done with the avatar_ids argument NULL.  Duplicates in the 
> returned list need to be suppressed.
> 
> 
> This addresses bug VWR-17050.
> http://jira.secondlife.com/browse/VWR-17050
> 
> 
> Diffs
> -
> 
>   indra/newview/llworld.cpp 691e3941d950 
> 
> Diff: http://codereview.secondlife.com/r/132/diff
> 
> 
> Testing
> ---
> 
> Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
> without avatars nearby.  Tested with varying the NearMeRange to insure it 
> does not show avatars beyond the range.  Testers need to understand that 
> RenderFarClip has an impact on the avatars that are actually in the viewer 
> object list, so setting NearMeRange to a great distance at high altitude 
> won't necessarily add avatars to the list.  Basically if you can see the 
> avatar and its within NearMeRange, the avatar should be in the nearby avatar 
> list in the people panel.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Twisted Laws]

> On Jan. 31, 2011, 5:48 p.m., Merov Linden wrote:
> > It seems to me that the new code can completely replace the old one, i.e. 
> > the search based on the map is not adding anything different or is it?

There are several reasons that replacing the code may provide a different 
result.  The list of avatars returned by the function is based on NearMeRange 
which could be a greater value than RenderFarClip.  In that case, replacing the 
code would only return the list of avatars in RenderFarClip range and would 
ignore a greater NearMeRange.  In the case of a person owning an island, they 
may have NearMeList set to 1200 so they could see the presence of any avatar in 
their region at any altitude and yet have RenderFarClip set to 128.  I realize 
that at this point its not really "NearMe".  Also I've noticed in the sandboxes 
that quite often a person shows up in the region avatar list before showing up 
in the viewer object list and in my personal implementation of a radar floater 
I mark the avatar names that are not visible.  In the released versions of the 
Nearby list, the Zoom-in option is not available for avatars that are not 
visible so designers must have considered this situation.

I guess my other reason would be changing it in llworld wouldn't be the right 
place to have the function getAvatars if it ignored map data and only used 
character data.  Maybe creating a new getAvatars in LLCharacters would be the 
right way to do it then.


> On Jan. 31, 2011, 5:48 p.m., Merov Linden wrote:
> > indra/newview/llworld.cpp, lines 1475-1477
> > <http://codereview.secondlife.com/r/132/diff/1/?file=751#file751line1475>
> >
> > I fail to see how the "1000m" condition is tested in this code. Same 
> > for the "only do this when we are retrieving uuid's".

It can only provide the function if it has been storing uuid's (avatar_ids not 
null) or it would provide duplicates.  The reason its for over 1000m is the 
viewer object list position is ignored if it had already added the uuid from 
the region data.  I.e, the region avatar position is incorrect if the user is 
over 1024m and will not be added to the list as its not in NearMeRange.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/#review297
---


On Jan. 31, 2011, 3:34 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/132/
> ---
> 
> (Updated Jan. 31, 2011, 3:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modifies the getAvatars function in llworld to also include any avatars 
> that are found within the range from the LLCharactes list as well (the list 
> of avatars that is in the viewer object list).  This should make sure that 
> anyone that you visually see within range shows up in the list.  Note that 
> changing it in this function also affects 
> LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, 
> as well as the LLPanelPeople::updateNearbyList that was originally mentioned 
> in the Jira.  The region avatars lists only contain valid position data when 
> the avatars are below 1024m.  The comment that mentions about retrieving 
> uuids is based on the function, not the current uses.  No current calls in 
> the code are done with the avatar_ids argument NULL.  Duplicates in the 
> returned list need to be suppressed.
> 
> 
> This addresses bug VWR-17050.
> http://jira.secondlife.com/browse/VWR-17050
> 
> 
> Diffs
> -
> 
>   indra/newview/llworld.cpp 691e3941d950 
> 
> Diff: http://codereview.secondlife.com/r/132/diff
> 
> 
> Testing
> ---
> 
> Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
> without avatars nearby.  Tested with varying the NearMeRange to insure it 
> does not show avatars beyond the range.  Testers need to understand that 
> RenderFarClip has an impact on the avatars that are actually in the viewer 
> object list, so setting NearMeRange to a great distance at high altitude 
> won't necessarily add avatars to the list.  Basically if you can see the 
> avatar and its within NearMeRange, the avatar should be in the nearby avatar 
> list in the people panel.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] problems working with autobuild

[Twisted Laws]

just to be clear here, i've no problems configuring and building in 
vc2005expess the old way.  
i start the process with "cmake ." in the indra directory in a cygwin window.  
then i open 
the .sln file with vc2005express and set the build type and build it.  all is 
fine.I can also 
use the older way of "./develop.py -G vc80 configure".   I don't see a visual 
studio 2005 
command prompt in my vc2005express.   i have python26 installed and the one in 
/usr/bin 
is linked to that python26.  

i can run develop.py with "./develop.py -G vc80 configure" and it works ok, so 
its not a 
wrong python error (one in /usr/bin is linked to python26).  Every python 
script on my 
system worked until this one.
 
but i don't understand this sequence...
> > $ autobuild configure -c OpenSourceRelWithDebInfo
> > C:\cygwin\bin\python: can't open file
> > '/cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild': [Errno 2] No such file
> > or directory
> > dir: /cygdrive/c/dev/hgbuilds/v-autobuild
> > $ ls -l /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild
> > -rwxr-xr-x 1 John None 2213 Jan 31 20:37
> > /cygdrive/c/dev/hgbuilds/autobuild/bin/autobuild
 
where it says the file or directory doesn't exist yet it does...  it obviously 
existed or 
python wouldn't have started to begin with.
 
 

> The old style build didn't work in cygwin shell either. It wanted
> cmake and python to be native windows versions. After deleting cygwin
> versions of those, all worked. Perhaps a similar thing can help for
> the autobuild?

  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] problems working with autobuild

[Twisted Laws]

Thanks to Nicky, I've made it further.  I didn't have a command prompt menu 
option in vc2005 express but i was able to find information on the net to help 
me create one.  So now autobuild does run in a vc2005 command prompt window for 
me but still fails with the following (raw) log:(note at the end of it i 
did verify i was up-to-date)
 
Setting environment for using Microsoft Visual Studio 2005 x86 tools.
C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>echo %PATH%
C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE;C:\Program Files (x
86)\Microsoft Visual Studio 8\VC\BIN;C:\Program Files (x86)\Microsoft Visual Stu
dio 8\Common7\Tools;C:\Program Files (x86)\Microsoft Visual Studio 8\SDK\v2.0\bi
n;C:\Windows\Microsoft.NET\Framework\v2.0.50727;C:\Program Files (x86)\Microsoft
 Visual Studio 8\VC\VCPackages;C:\Program Files\Common Files\Microsoft Shared\Wi
ndows Live;C:\Program Files (x86)\Common Files\Microsoft Shared\Windows Live;C:\
Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Program Files (x86)\Cybe
rLink\Power2Go;C:\Program Files (x86)\ATI Technologies\ATI.ACE\Core-Static;c:\Pr
ogram Files (x86)\Microsoft SQL Server\100\Tools\Binn\;c:\Program Files (x86)\Mi
crosoft SQL Server\100\DTS\Binn\;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\
Program Files (x86)\QuickTime\QTSystem\;C:\Program Files (x86)\Mercurial\;C:\Pro
gram Files (x86)\Windows Live\Shared;C:\Python26;C:\Program Files (x86)\CMake 2.
6\bin;C:\Program Files (x86)\Microsoft Visual Studio 8\VC\bin;C:\dev\hgbuilds\au
tobuild\bin
C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>cd c:\dev\hgbuilds\
v-autobuild
c:\dev\hgbuilds\v-autobuild>autobuild configure -c Release
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio
8/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio
8/VC/bin/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi
o 8/VC/bin/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studi
o 8/VC/bin/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Using autobuild at: C:/dev/hgbuilds/autobuild/bin/autobuild.cmd
unable to download file: 
Traceback (most recent call last):
  File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa
d_package
file(cachename, 'wb').write(urllib2.urlopen(package).read())
  File "C:\Python26\lib\urllib2.py", line 124, in urlopen
return _opener.open(url, data, timeout)
  File "C:\Python26\lib\urllib2.py", line 383, in open
response = self._open(req, data)
  File "C:\Python26\lib\urllib2.py", line 401, in _open
'_open', req)
  File "C:\Python26\lib\urllib2.py", line 361, in _call_chain
result = func(*args)
  File "C:\Python26\lib\urllib2.py", line 1130, in http_open
return self.do_open(httplib.HTTPConnection, req)
  File "C:\Python26\lib\urllib2.py", line 1105, in do_open
raise URLError(err)
URLError: 
ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif
e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi
ndows-20110113.tar.bz2
For more information: try re-running your command with --verbose or --debug
CMake Error at cmake/Prebuilt.cmake:51 (message):
  Failed to download or unpack prebuilt 'fmod'.  Process returned 1.
Call Stack (most recent call first):
  cmake/FMOD.cmake:12 (use_prebuilt_binary)
  llaudio/CMakeLists.txt:8 (include)

-- Configuring incomplete, errors occurred!
ERROR: default configuration returned 1
For more information: try re-running your command with --verbose or --debug
c:\dev\hgbuilds\v-autobuild>hg pull
pulling from https://bitbucket.org/mani_linden/viewer-autobuild
searching for changes
no changes found
c:\dev\hgbuilds\v-autobuild>cd ../autobuild
c:\dev\hgbuilds\autobuild>hg pull
pulling from https://bitbucket.org/lindenlab/autobuild
searching for changes
no changes found
c:\dev\hgbuilds\autobuild>___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] problems working with autobuild

[Twisted Laws]

Ok, I figured out i made a mistake with -c Release...   now i can't find devenv
 

c:\dev\hgbuilds\v-autobuild>autobuild configure -c OpenSourceRelWithDebInfo
package libuuid has no installation information configured for platform windows
package fontconfig has no installation information configured for platform windo
ws
-- We seem to have an artwork bundle in the tree - brilliant.
-- Version of viewer is 2.6.0.0
-- Configuring done
-- Generating done
-- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80
c:\dev\hgbuilds\v-autobuild>autobuild build -c OpenSourceRelWithDebInfo
package libuuid has no installation information configured for platform windows
package fontconfig has no installation information configured for platform windo
ws
-- We seem to have an artwork bundle in the tree - brilliant.
-- Version of viewer is 2.6.0.0
-- Configuring done
-- Generating done
-- Build files have been written to: C:/dev/hgbuilds/v-autobuild/build-vc80
'devenv.com' is not recognized as an internal or external command,
operable program or batch file.
ERROR: building default configuration returned 1
For more information: try re-running your command with --verbose or --debug
c:\dev\hgbuilds\v-autobuild>  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/
---

(Updated Feb. 2, 2011, 3:39 p.m.)


Review request for Viewer.


Changes
---

I redid the patch, hopefully making the comments more acceptable and took out 
the use of continue.   I moved retrieval of the character positions before the 
world positions as I found cases where the information would be incorrect right 
near 1024 testing with a couple people below 1024, and a couple people above.  
Note this is a replacement patch.


Summary
---

This modifies the getAvatars function in llworld to also include any avatars 
that are found within the range from the LLCharactes list as well (the list of 
avatars that is in the viewer object list).  This should make sure that anyone 
that you visually see within range shows up in the list.  Note that changing it 
in this function also affects LLFloaterAvatarPicker::populateNearMe, 
LLLocalSpeakerMgr::updateSpeakerList, as well as the 
LLPanelPeople::updateNearbyList that was originally mentioned in the Jira.  The 
region avatars lists only contain valid position data when the avatars are 
below 1024m.  The comment that mentions about retrieving uuids is based on the 
function, not the current uses.  No current calls in the code are done with the 
avatar_ids argument NULL.  Duplicates in the returned list need to be 
suppressed.


This addresses bug VWR-17050.
http://jira.secondlife.com/browse/VWR-17050


Diffs (updated)
-

  indra/newview/llworld.cpp ebd53632620a 

Diff: http://codereview.secondlife.com/r/132/diff


Testing
---

Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
without avatars nearby.  Tested with varying the NearMeRange to insure it does 
not show avatars beyond the range.  Testers need to understand that 
RenderFarClip has an impact on the avatars that are actually in the viewer 
object list, so setting NearMeRange to a great distance at high altitude won't 
necessarily add avatars to the list.  Basically if you can see the avatar and 
its within NearMeRange, the avatar should be in the nearby avatar list in the 
people panel.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/
---

Review request for Viewer.


Summary
---

Sets "Stop Tracking" enabled based on tracking if true or false instead of only 
when true.  Also made it check for menu pointer validity to remove a remote 
crash possiblity.


This addresses bug STORM-971.
http://jira.secondlife.com/browse/STORM-971


Diffs
-

  indra/newview/llnetmap.cpp ec4a9fd30688 

Diff: http://codereview.secondlife.com/r/133/diff


Testing
---

My testing was to open the side panel nearby, and verify that the state of the 
menu was correct when tracking by the different methods and disabled.   Then 
leaving that open, openned a mini-map instance and repeated testing its state 
tracking and not.  Also tried the reverse. Verified that every possibility I 
could think of, the state of both menus was always correct.  

Correct state is Stop Tracking is enabled anytime tracking is on for avatars or 
landmarks and is not enabled when Tracking has been stopped no matter where you 
stopped tracking (i.e, clicking on red arrow in view window, and using the 
various menues).


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

The autobuild configure -c OpenSourceRelWithDebInfo worked fine if I run it 
from a Visual C++ command prompt but not in a cygwin window.   But the build 
fails with an expected (??) error with fmod.

 c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build
unable to download file: 
Traceback (most recent call last):
  File "C:\Python26\Lib\site-packages\autobuild\common.py", line 243, in downloa
d_package
file(cachename, 'wb').write(urllib2.urlopen(package).read())
  File "C:\Python26\lib\urllib2.py", line 124, in urlopen
return _opener.open(url, data, timeout)
  File "C:\Python26\lib\urllib2.py", line 383, in open
response = self._open(req, data)
  File "C:\Python26\lib\urllib2.py", line 401, in _open
'_open', req)
  File "C:\Python26\lib\urllib2.py", line 361, in _call_chain
result = func(*args)
  File "C:\Python26\lib\urllib2.py", line 1130, in http_open
return self.do_open(httplib.HTTPConnection, req)
  File "C:\Python26\lib\urllib2.py", line 1105, in do_open
raise URLError(err)
URLError: 
ERROR: failed to download http://s3-proxy.lindenlab.com/private-builds-secondlif
e-com/hg/repo/merov_fmod-autobuild/rev/219050/arch/CYGWIN/installer/fmod-3.75-wi
ndows-20110113.tar.bz2
For more information: try re-running your command with --verbose or --debug
CMake Error at cmake/Prebuilt.cmake:51 (message):
  Failed to download or unpack prebuilt 'fmod'.  Process returned 1.
Call Stack (most recent call first):
  cmake/FMOD.cmake:12 (use_prebuilt_binary)
  llaudio/CMakeLists.txt:8 (include)

-- Configuring incomplete, errors occurred!
ERROR: configuring default configuration returned 1
For more information: try re-running your command with --verbose or --debug
c:\dev\hgbuilds\viewer-autobuildvs8>  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

Since I wasn't sure of the exact command to run I also tried:
 
c:\dev\hgbuilds\viewer-autobuildvs8>autobuild build -c OpenSourceRelWithDebInfo
--verbose
executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA
TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G
"Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO
D=FALSE ../indra
package libuuid has no installation information configured for platform windows
package fontconfig has no installation information configured for platform windo
ws
-- We seem to have an artwork bundle in the tree - brilliant.
-- Version of viewer is 2.6.0.0
-- Configuring done
-- Generating done
-- Build files have been written to: C:/dev/hgbuilds/viewer-autobuildvs8/build-v
c80
executing build command devenv.com /build RelWithDebInfo SecondLife.sln
'devenv.com' is not recognized as an internal or external command,
operable program or batch file.
ERROR: building default configuration returned 1
For more information: try re-running your command with --verbose or --debug
c:\dev\hgbuilds\viewer-autobuildvs8>  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

Ok, i'm an idiot and can't follow instructions   So i  reread Oz's msg and 
found i was using the wrong config and redid it with 
autobuild configure -c VCexpressRelWithDebInfo
 
Then that part worked ok.
 
If i then just used "autobuild build" it had the same fmod error as before.
 
So i tried autobuild build -c VCexpressRelWithDebInfo --verbose  and things 
went further but as someone else reported then i got 100's of errors about 
winsock2.h not being found.   Why does it continue to try to build everything 
after it gets so many errors?  
 
Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped
 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

Ok, i found i can get much further compiling in the IDE and this is all i end 
up with now.  Note that the issue with winres.h is one i always have had with 
and easy change of defining IDC_STATIC and including winresrc.h instead.
 
Twisted
 
Warning 1 warning LNK4099: PDB 'vc80.pdb' was not found with 
'..\packages\lib\release\exception_handler.lib' or at 
'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb';
 linking object as if no debug info exception_handler.lib 
Warning 2 warning LNK4099: PDB 'vc80.pdb' was not found with 
'..\packages\lib\release\crash_generation_client.lib' or at 
'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb';
 linking object as if no debug info crash_generation_client.lib 
Warning 3 warning LNK4099: PDB 'vc80.pdb' was not found with 
'..\packages\lib\release\common.lib' or at 
'C:\dev\hgbuilds\viewer-autobuildvs8\build-vc80\sharedlibs\RelWithDebInfo\vc80.pdb';
 linking object as if no debug info common.lib 
Error 4 error PRJ0019: A tool returned an error code from "Generating 
PROJECT_llmessage_TEST_lltemplatemessagedispatcher_ok.txt" llmessage_tests 
Error 5 error PRJ0019: A tool returned an error code from "Generating 
PROJECT_llupdaterservice_TEST_llupdaterservice_ok.txt" llupdaterservice_tests 
Error 6 error PRJ0019: A tool returned an error code from "Performing 
viewer_manifest copy" copy_w_viewer_manifest 
Warning 7 warning LNK4221: no public symbols found; archive member will be 
inaccessible llfunctorregistry.obj 
Error 8 fatal error RC1015: cannot open include file 'winres.h'. 
c:\dev\hgbuilds\viewer-autobuildvs8\indra\newview\res\viewerRes.rc 10 
Error 9 error PRJ0019: A tool returned an error code from "Generating 
RelWithDebInfo/touched.bat" package 

 


From: twisted_l...@hotmail.com
To: o...@lindenlab.com; opensource-dev@lists.secondlife.com
Date: Sun, 6 Feb 2011 12:56:55 -0500
Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under 
Visual Studio 2005 Express Edition.




Ok, i'm an idiot and can't follow instructions   So i  reread Oz's msg and 
found i was using the wrong config and redid it with 
autobuild configure -c VCexpressRelWithDebInfo
 
Then that part worked ok.
 
If i then just used "autobuild build" it had the same fmod error as before.
 
So i tried autobuild build -c VCexpressRelWithDebInfo --verbose  and things 
went further but as someone else reported then i got 100's of errors about 
winsock2.h not being found.   Why does it continue to try to build everything 
after it gets so many errors?  
 
Build complete: 12 Projects succeeded, 113 Projects failed, 2 Projects skipped
 
 

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

I tried making these changes...   it did not do anything different or help me 
in my situation of not finding the windows.h and winsock2.h. 

 I'd start over and rebuild the dev environment but its not a good option for 
me at this time.
 
> Date: Sun, 6 Feb 2011 20:23:41 +
> From: ima.mechani...@blueyonder.co.uk
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work 
> under Visual Studio 2005 Express Edition.
> 
> > What is your windows OS? I may be able to Vbox/VM it to test.
> 
> WinXP 64 bit.
> 
> The following altered function from 
> indra\lib\python\indra\util\test_win32_manifest.py
> fixes the issues for me.
> 
> def find_vc_dir():
> supported_versions = (r'8.0', r'9.0')
> supported_products = (r'VisualStudio', r'VCExpress')
> value_str = (r'ProductDir')
> 
> for product in supported_products:
> for version in supported_versions:
> key_str = (r'SOFTWARE\Microsoft\%s\%s\Setup\VC' %
> (product, version))
> try:
> return get_HKLM_registry_value(key_str, value_str)
> except WindowsError, err:
> if product == "VisualStudio":
> reg_key = "VS"
> elif product == "VCExpress":
> reg_key = "VC"
> else:
> raise Exception("Unknown package!")
> 
> x64_key_str = (r'SOFTWARE\Wow6432Node\Microsoft\%s\%s\Setup\%s' %
> (product, version, reg_key))
> 
> try:
> return get_HKLM_registry_value(x64_key_str, value_str)
> except:
> print >> sys.stderr, "Didn't find MS %s version %s " % (product,version)
> 
> raise
> 
> 
> > 
> > From: Ima Mechanique 
> > To: opensource-dev@lists.secondlife.com
> > Sent: Sun, February 6, 2011 1:15:31 PM
> > Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work 
> > under 
> > Visual Studio 2005 Express Edition.
> > 
> > > I'm getting dozens of these errors
> > > 
> > > fatal error C1083: Cannot open include file: 'winsock2.h': No such file 
> > > or 
> > >directory
> > > 
> > > and
> > > 
> > > fatal error C1083: Cannot open include file: 'windows.h': No such file or 
> > >directory
> > > 
> > > Seems that it is not using the Include directories list.
> > 
> > Just to clarify. These errors are only generated when using "autobuild
> > build -c VCexpressRelWithDebInfo" If using the MSVC Express gui it
> > builds with only the usual niggles (like failing on x64 because it can't
> > find a directory)
> > 
> > 
> > --
> > Ima Mechanique
> > ima.mechanique(at)blueyonder.co.uk
> > 
> > 
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting 
> > privileges
> > 
> > 
> > 
> > 
> 
> --
> Ima Mechanique
> ima.mechanique(at)blueyonder.co.uk
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

[Twisted Laws]

I'm sort of lost here, sorry :(  I did try a lot of different things (except i 
didn't look in the python files as i'm not sure what i'd be looking at).
 
our versions seem to match exactly
 
Microsoft Visual Studio 2005
Version 8.0.50727.867  (vsvista.050727-8600)
Microsoft .NET Framework
Version 2.0.50727 SP2
Installed Edition: VC Express
Microsoft Visual C++ 2005   76542-000-011-00125
Microsoft Visual C++ 2005
 
all my tests after you pointed out running from a vc2005 cmd window have that 
 
Setting environment for using Microsoft Visual Studio 2005 x86 tools.
C:\Program Files (x86)\Microsoft Visual Studio 8\Common7\IDE>
 
i also modified my vcvars32.bat file to include
 
@set INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 
8\VC\INCLUDE;%INCLUDE%
@set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include;%INCLUDE%
@set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.1\Include\gl;%INCLUDE%
@set INCLUDE=C:\Program Files (x86)\Microsoft DirectX SDK (August 
2008)\Include;%INCLUDE%
 
didn't change anything for me :(
 


Date: Sun, 6 Feb 2011 18:55:34 -0800
From: nickyper...@yahoo.com
Subject: Re: [opensource-dev] Review Request: Make viewer-autobuild work under 
Visual Studio 2005 Express Edition.
To: twisted_l...@hotmail.com; opensource-dev@lists.secondlife.com; 
ima.mechani...@blueyonder.co.uk







Help->About VC++2005 Express Edition->Copy Info-->Paste from Clipboard 
yeilds--
Microsoft Visual Studio 2005
Version 8.0.50727.867  (vsvista.050727-8600)
Microsoft .NET Framework
Version 2.0.50727 SP2


Installed Edition: VC Express


Microsoft Visual C++ 2005   76542-000-011-00125
Microsoft Visual C++ 2005
**
Invoke Terminal and execute->>
"C:\Program Files\Microsoft Visual Studio 8\Common7\Tools\vsvars32.bat"
Yeilds
Setting environment for using Microsoft Visual Studio 2005 x86 tools.
C:\>




Early on I had a problem where vcvars32.bat did not execute properly when
invoked from within Express. I had to drill down through All Programs
and invoke from within Visual Studio Tools.


You should have "Setting environment for using Microsoft Visual Studio 2005 x86 
tools."
without any errors before using the terminal.


Anyway a couple things to check. I have tried unsucessfully 
to force a repo of failed includes.

  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

[Twisted Laws]

When I try running autobuild on Linux (Ubuntu) using this autobuild and 
viewer-autobuild2010, it immediately fails with a pathcheck error looking for 
boto.  Looking at common.py (in 
/usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the 
pathcheck lines in there contain "lib/python2.5/...".  So I'm assuming that 
this doesn't work with Python 2.6 ??
 
On Windows 7 with Visual Studio 2010 (not express), I run into an issue with 
not finding SCP, so I installed PuTTY and linked pscp.exe to scp.exe and then 
it still fails to download the googlebreakpad.   (This IS using 
OpenSourceRelWithDebInfo)

 


Date: Thu, 17 Feb 2011 19:56:05 -0500
From: o...@lindenlab.com
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...


On 2011-02-16 16:01, Oz Linden (Scott Lawrence) wrote: 

Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an 
in-house Hackathon (stopping work on many other things, getting many developers 
together all at once, and focusing on getting a lot done in short time) to 
upgrade our builds of all our libraries and the viewer to a new toolchain, 
including our new package management tool (autobuild) and Visual Studio 2010 
for Windows (yes... about time... whatever... we're doing it).

I could use some help with a linux build problem... if you have a chance, 
please check out a copy of 

https://bitbucket.org/lindenlab/autobuild
and arrange for the bin/autobuild command from that repository to be in your 
$PATH

Then check out:

https://bitbucket.org/oz_linden/viewer-autobuild2010
cd into the top level of that directory, and run:

autobuild configure -c OpenSourceRelWithDebInfo

autobuild configure -c OpenSourceRelWithDebInfo
and let me know if it works (and if not, see if you can figure out why not).  
On our build farm, I'm getting an error:


[19:13:30]: LogScan (1s)
[19:13:30]: [LogScan] from /usr/include/c++/4.1.3/cmath:53,
[19:13:30]: [LogScan] from 
/var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48,
[19:13:30]: [LogScan] from 
/var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26:
[19:13:30]: [LogScan] /usr/include/bits/huge_val.h:28:18: error: missing binary 
operator before token "("
[19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing binary 
operator before token "("


___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

[Twisted Laws]

exact error on linux is:  autobuild.common.AutobuildError: invalid 'pathcheck' 
setting for 'boto'
 


From: twisted_l...@hotmail.com
To: o...@lindenlab.com; opensource-dev@lists.secondlife.com
Date: Fri, 18 Feb 2011 08:50:11 -0500
Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...




When I try running autobuild on Linux (Ubuntu) using this autobuild and 
viewer-autobuild2010, it immediately fails with a pathcheck error looking for 
boto.  Looking at common.py (in 
/usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the 
pathcheck lines in there contain "lib/python2.5/...".  So I'm assuming that 
this doesn't work with Python 2.6 ??
 
On Windows 7 with Visual Studio 2010 (not express), I run into an issue with 
not finding SCP, so I installed PuTTY and linked pscp.exe to scp.exe and then 
it still fails to download the googlebreakpad.   (This IS using 
OpenSourceRelWithDebInfo)

 


Date: Thu, 17 Feb 2011 19:56:05 -0500
From: o...@lindenlab.com
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

On 2011-02-16 16:01, Oz Linden (Scott Lawrence) wrote: 

Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an 
in-house Hackathon (stopping work on many other things, getting many developers 
together all at once, and focusing on getting a lot done in short time) to 
upgrade our builds of all our libraries and the viewer to a new toolchain, 
including our new package management tool (autobuild) and Visual Studio 2010 
for Windows (yes... about time... whatever... we're doing it).

I could use some help with a linux build problem... if you have a chance, 
please check out a copy of 

https://bitbucket.org/lindenlab/autobuild
and arrange for the bin/autobuild command from that repository to be in your 
$PATH

Then check out:

https://bitbucket.org/oz_linden/viewer-autobuild2010
cd into the top level of that directory, and run:

autobuild configure -c OpenSourceRelWithDebInfo

autobuild configure -c OpenSourceRelWithDebInfo
and let me know if it works (and if not, see if you can figure out why not).  
On our build farm, I'm getting an error:


[19:13:30]: LogScan (1s)
[19:13:30]: [LogScan] from /usr/include/c++/4.1.3/cmath:53,
[19:13:30]: [LogScan] from 
/var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/llcommon/linden_common.h:48,
[19:13:30]: [LogScan] from 
/var/opt/teamcity/checkout/L-oz_viewer-autobuild2010/latest/indra/newview/tests/lldateutil_test.cpp:26:
[19:13:30]: [LogScan] /usr/include/bits/huge_val.h:28:18: error: missing binary 
operator before token "("
[19:13:30]: [LogScan] /usr/include/bits/huge_val.h:30:20: error: missing binary 
operator before token "("


___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges 
___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

[Twisted Laws]

Thanks  i'm unclear of what i should do next then.   (I primarily work in 
windows)   Can i just delete the files in 
/usr/local/lib/python2.6/dist-packages/autobuild ?

 
> From: thickbrick.sleaf...@gmail.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...
> Date: Fri, 18 Feb 2011 16:45:00 +0200
> CC: twisted_l...@hotmail.com
> 
> On Friday 18 February 2011 15:50:11 Twisted Laws wrote:
> > When I try running autobuild on Linux (Ubuntu) using this autobuild and
> > viewer-autobuild2010, it immediately fails with a pathcheck error looking
> > for boto. Looking at common.py (in
> > /usr/local/lib/python2.6/dist-packages/autobuild/common.py) I see that the
> > pathcheck lines in there contain "lib/python2.5/...". So I'm assuming
> > that this doesn't work with Python 2.6 ??
> > 
> 
> I had a similar problem after I installed the autobuild package system-wide 
> with the setup.py that came with it (./setup.py build && sudo ./setup.py 
> install). It turns out it does not work when installed system wide. As far as 
> I could tell, the python version in the pre-packaged files' path don't matter.
> 
> Also, it seems prone to leaving bad files /var/tmp/$USER/install.cache/ when 
> bailing due to exceptions, and barfing when encountering those files on 
> subsequent runs.
> 
> -- 
> Thickbrick
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

[Twisted Laws]

hmmm...  ok, so i removed them...   './setup.py build' works ok and i added 
autobuild/bin to path and I still get the same error from running 
 
$ autobuild configure -c OpenSourceRelWithDebInfo
autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto'

looking at it, the file still contains 'pathcheck' : "lib/python2.5/boto"
 
what is "boto" btw?  did i miss installing something?   there are no boto 
packages that i can find
 
 
> From: thickbrick.sleaf...@gmail.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...
> Date: Fri, 18 Feb 2011 17:03:05 +0200
> CC: twisted_l...@hotmail.com
> 
> That's what I did (together with /usr/local/bin/autobuild). Maybe there's a 
> proper way of removing packages installed with easy_install, but I couldn't 
> figure it out...
> 
> 
> -- 
> Thickbrick
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

[Twisted Laws]

in my case, i copied autobuild.xml to altered.xml and changed all occurrances 
of '"Visual Studio 8 2005" to "Visual Studio 10" and then specified it on the 
autobuild command line with --config_file altered.xml 
 
then it works but I have problems getting googlebreakpad, but thats a different 
issue
 


Date: Fri, 18 Feb 2011 10:51:24 -0600
From: xot...@gmail.com
To: o...@lindenlab.com
CC: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] Hacking up to Visual Studio 2010 ...

Trying to build with vs2k10 pro


D:\Other\vd\viewer-autobuild>autobuild configure -c OpenSourceRelWithDebInfo --d
ebug
Configuration file 'D:\Other\vd\viewer-autobuild\autobuild.xml'
configuring in D:\Other\vd\viewer-autobuild\build-vc80
configuring for configuration(s) [{'default': False, 'configure': {'command': No
ne, 'options': ['-G', '"Visual Studio 8 2005"', '-DSTANDALONE:BOOL=FALSE', '-DIN
STALL_PROPRIETARY=FALSE', '-DFMOD=FALSE'], 'arguments': None}, 'name': 'OpenSour
ceRelWithDebInfo', 'build': {'command': 'devenv.com', 'options': ['/build', 'Rel
WithDebInfo'], 'arguments': ['SecondLife.sln']}}]
executing configure command cmake -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DUNA
TTENDED:BOOL=OFF -DWORD_SIZE:STRING=32 -DROOT_PROJECT_NAME:STRING=SecondLife -G
"Visual Studio 8 2005" -DSTANDALONE:BOOL=FALSE -DINSTALL_PROPRIETARY=FALSE -DFMO
D=FALSE ../indra
CMake Error: CMake was unable to find a build program corresponding to "Visual S
tudio 8 2005".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a di
fferent build tool.
CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build
-vc80/CMakeFiles/CMakeCCompiler.cmake
CMake Error: Could not find cmake module file:D:/Other/vd/viewer-autobuild/build
-vc80/CMakeFiles/CMakeCXXCompiler.cmake
-- Configuring incomplete, errors occurred!
default configuration returned 1
Traceback (most recent call last):
  File "D:\Python26\Scripts\autobuild", line 47, in 
sys.exit( Autobuild().main(sys.argv[1:]) )
  File "D:\Python26\lib\site-packages\autobuild\autobuild_main.py", line 188, in
 main
tool_to_run.run(args)
  File "D:\Python26\lib\site-packages\autobuild\autobuild_tool_configure.py", li
ne 88, in run
raise ConfigurationError("default configuration returned %d" % (result))
ConfigurationError: default configuration returned 1
ERROR: default configuration returned 1
For more information: try re-running your command with --verbose or --debug

D:\Other\vd\viewer-autobuild>


On Wed, Feb 16, 2011 at 3:01 PM, Oz Linden (Scott Lawrence) 
 wrote:



Tomorrow and Friday (Feb 17 & 18), Linden Lab is going to be holding an 
in-house Hackathon (stopping work on many other things, getting many developers 
together all at once, and focusing on getting a lot done in short time) to 
upgrade our builds of all our libraries and the viewer to a new toolchain, 
including our new package management tool (autobuild) and Visual Studio 2010 
for Windows (yes... about time... whatever... we're doing it).

Our goals are simply stated:


Get all open source components into repositories under hg.secondlife.com (eg 
bitbucket.org/lindenlab/).  All the third party components (things not created 
by LL) that we incorporate will be in repositories named with the prefix "3p-". 
 Most of these repositories exist now, but not all have sources in them yet.
Get each component packaged with an autobuild configuration for whatever 
platforms it is needed on.
Get each component needed on Windows building under autobuild with VS 2010.
Get a TeamCity-automated build configured for each component repository with 
the resulting prebuilds of open components uploaded to public directories.

Get the viewer built using the resulting prebuilt libraries, also under 
autobuild with VS 2010.We also expect to integrate some automated viewer 
testing into our automated viewer builds, but none of that will be externally 
visible.

If you make a chart with a row for each component, and a column for each of 1 
through 4 above, it's a lot of boxes to fill in... many have already been done: 
there are some complete rows, but it's still a big job.

I will be providing public updates on the wiki (form and location TBD... watch 
this thread) and on the #opensl IRC channel of how we're doing and the status 
of each public repository.

A non-goal for the Lindens is building the components with Visual Studio 
Express.  There is currently a limitation (see OPEN-1 in jira) that makes using 
Express cumbersome (it requires separate configuration). We do recognize that 
Express is important to open developers, and want it to be supported, but 
there's only so much we can do ourselves in two days.  There is an autobuild 
configuration checked in for building the viewer under autobuild including VS 
Express: http://bitbucket.org/oz_linden/viewer-autobuild


I'm going to try to get some supporting documentation up on the wiki today or 
early tomorrow.  It should be possible for open developers to hel

[opensource-dev] autobuild on linux

[Twisted Laws]

on Ubuntu ...
 
i've installed python-boto (sudo apt-get install python-boto) [also tried 
getting boto source direct and installing with 'sudo python setup.py install' 
after pulling with 'svn checkout http://boto.googlecode.com/svn/trunk']
 
i've installed llbase (hg clone https://bitbucket.org/lindenlab/llbase) and 
installed with 'sudo python setup.py install'
 
i've re-installed autobuild (hg clone 
https://bitbucket.org/lindenlab/autobuild) and installed with 'sudo python 
setup.py install'
 
when i run autobuild configure -c OpenSourceRelWithDebInfo I still get 
'autobuild.common.AutobuildError: invalid 'pathcheck' setting for 'boto'   
looking in common.py, the pathcheck for boto is 'lib/python2.5/boto'
 
Anyone have any hints to help me get further?
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod

[Twisted Laws]

to get fmod working i used this changeset and used
autobuild --debug configure -c VC10msbuildRelWithDebInfo -- -DLL_TESTS:BOOL=OFF 
-DFMOD:BOOL=ON -DFMOD_INCLUDE_DIR=C:\Dev\fmod -DFMOD_LIBRARY=C:\Dev\fmod
 
successfully compiles, runs and has sound  (not standalone)
 


From: me...@lindenlab.com
Date: Thu, 24 Feb 2011 22:03:46 -0800
To: opensource-dev@lists.secondlife.com
Subject: [opensource-dev] STORM-1023 (was OPEN-4) : fmod

Hi,

I worked on this and submitted what I think should solve the problem on a dev 
repo forked from oz_linden/viewer-autobuild:

https://bitbucket.org/merov_linden/viewer-autobuild-open-4/changeset/e439abf2be8e

If autobuild interested people building from home STANDALONE and NOT STANDALONE 
could review that proposal and test the changeset, that would help tremendously.

Cheers,
- Merov

___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

[Twisted Laws]

> On Feb. 27, 2011, 5:57 a.m., Boroondas Gupte wrote:
> >

Works as advertised for me in use in world and I've not found any adverse 
effects.   Aleric's rewriting (with comment) makes the most sense.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/153/#review392
---


On Feb. 19, 2011, 9:32 a.m., ardy.lay wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/153/
> ---
> 
> (Updated Feb. 19, 2011, 9:32 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> https://jira.secondlife.com/browse/VWR-24917
> I have been finding the redundent display of functionally equivalent names in 
> nearby chat history and IM history quite tiresome.
> Simple proposal: If the resident's Display Name is at the default then do not 
> display their user.name.
> https://bitbucket.org/ArdyLay/viewer-development-vwr-24917
> 
> Change is to: LLAvatarName::getCompleteName
> 
> I find the following Callers:
> LLAvatarActions::requestFriendshipDialog
> LLAvatarActions::startIM
> LLAvatarActions::startCall
> LLIMModel::LLIMSession
> LLIMModel::logToFile
> LLPostponedNotification::onAvatarNameCache
> LLUrlEntryAgent::onAvatarNameCache
> LLUrlEntryAgent::getLabel
> LLUrlEntryAgentCompleteName::getName
> 
> // Callback for name resolution of a god/estate message
> llviewermessage.cpp(2149): args["NAME"] = av_name.getCompleteName();
> llviewermessage.cpp(2154): chat.mText = av_name.getCompleteName() + ": " + 
> message;
> 
> static void on_avatar_name_cache_toast ...
> llimview.cpp(108): args["FROM"] = av_name.getCompleteName();
> 
> Some of these make me wonder if this change will cause some defects and 
> should be implimented as a seperate function.
> 
> 
> This addresses bug VWR-24917.
> http://jira.secondlife.com/browse/VWR-24917
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt c10d5e37db1e 
>   indra/llcommon/llavatarname.cpp c10d5e37db1e 
> 
> Diff: http://codereview.secondlife.com/r/153/diff
> 
> 
> Testing
> ---
> 
> I have been using this trivial change and have shared it with a friend, via 
> bitbucket.  We have both built the viewer on Windows 7 and find the resulting 
> reduction in redundent text in chat and IM history on screen to be very 
> helpful.
> 
> 
> Thanks,
> 
> ardy.lay
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

[Twisted Laws]

> On Feb. 3, 2011, 5:06 a.m., Oz Linden wrote:
> >
> 
> Kitty Barnett wrote:
> Is there any reason to "fix" this in getAvatars() rather than just 
> "fixing" it when processing the CoarseLocationUpdate legacy region message 
> (and when processing the still unused cap)?
> 
> The minimap for instance won't call getAvatars() but will rather access 
> the position directly so it would still be broken for nearby avatars when 
> >1000m.
> 
> Additionally, if the plan is to still enable the http cap at some point 
> in the future then fixing the viewer's handling of that now would ideally 
> mean that the problem is fixed for everyone as soon as it's enabled rather 
> than having to wait another quarter for the next viewer release that contains 
> the fix.

Note that the final version of this patch that was tagged "ship it" was not 
what was in the merge in viewer-development, instead the first version was 
included.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/132/#review316
---


On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/132/
> ---
> 
> (Updated Feb. 2, 2011, 3:39 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This modifies the getAvatars function in llworld to also include any avatars 
> that are found within the range from the LLCharactes list as well (the list 
> of avatars that is in the viewer object list).  This should make sure that 
> anyone that you visually see within range shows up in the list.  Note that 
> changing it in this function also affects 
> LLFloaterAvatarPicker::populateNearMe, LLLocalSpeakerMgr::updateSpeakerList, 
> as well as the LLPanelPeople::updateNearbyList that was originally mentioned 
> in the Jira.  The region avatars lists only contain valid position data when 
> the avatars are below 1024m.  The comment that mentions about retrieving 
> uuids is based on the function, not the current uses.  No current calls in 
> the code are done with the avatar_ids argument NULL.  Duplicates in the 
> returned list need to be suppressed.
> 
> 
> This addresses bug VWR-17050.
> http://jira.secondlife.com/browse/VWR-17050
> 
> 
> Diffs
> -
> 
>   indra/newview/llworld.cpp ebd53632620a 
> 
> Diff: http://codereview.secondlife.com/r/132/diff
> 
> 
> Testing
> ---
> 
> Simple testing in sandboxes of this patch at 20m and 2000m heights with and 
> without avatars nearby.  Tested with varying the NearMeRange to insure it 
> does not show avatars beyond the range.  Testers need to understand that 
> RenderFarClip has an impact on the avatars that are actually in the viewer 
> object list, so setting NearMeRange to a great distance at high altitude 
> won't necessarily add avatars to the list.  Basically if you can see the 
> avatar and its within NearMeRange, the avatar should be in the nearby avatar 
> list in the people panel.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] VCmsbuildOpenSourceRelWithDebInfo Incremental Link Testers Needed.

[Twisted Laws]

This works well for me and is much  nicer than it starting over every build.

 


Date: Tue, 1 Mar 2011 12:26:45 -0800
From: nickyper...@yahoo.com
To: opensource-dev@lists.secondlife.com
Subject: [opensource-dev] VCmsbuildOpenSourceRelWithDebInfo Incremental Link 
Testers Needed.





One line addition to autobuild.xml VCmsbuildRelWithDebInfo Section for 
incremental linking.




   VC10msbuildRelWithDebInfo

  build
  
command
msbuild.exe
options

  SecondLife.sln
  /t:build
  /p:Configuration=RelWithDebInfo
  /p:Platform=Win32
  /p:"VCBuildAdditionalOptions= /useenv"
  /p:"VCBuildAdditionalOptions= /incremental"
  
  
  configure
  
options

  -G
  "Visual Studio 10"
  -DSTANDALONE:BOOL=FALSE
  -DINSTALL_PROPRIETARY=FALSE
  -DFMOD=TRUE

  
  name
  VC10msbuildRelWithDebInfo

   



___ Policies and (un)subscribe 
information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
Please read the policies before posting to keep unmoderated posting privileges  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-1023 (was OPEN-4) : fmod

[Twisted Laws]

dang, just talked to Jonathan...   sorry about my incorrect response on the 
list prior...
 
Evidently in early attempts to get it to compile with fmod in it, I had copied 
the files to 
the build-vc100/packages/include(and lib) directories. In a new attempt on 
a different
computer I found that I had to copy the files to the proper package directories 
and only
needed to state -DFMOD:BOOL=ON
 
I've not been keeping up much with the autobuild stuff the last few days, sorry.
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-954 corrected patch

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/194/
---

Review request for Viewer.


Summary
---

STORM-954 review had 2 patches, the second of which was approved in review 
process but the first patch is what went into viewer-development.  This is that 
second patch again. This patch modifies getAvatars() in llworld.cpp.  Note this 
patch becomes more important if/when avatar distances may be displayed to users 
in the viewer as it corrects for map data being incorrect above 1024m by using 
the viewer characters list to get avatar position if known and then falling 
back on the map data for the avatars that are beyond view range.  This patch is 
in the repository 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-954


This addresses bug storm-954.
http://jira.secondlife.com/browse/storm-954


Diffs
-

  indra/newview/llworld.cpp aed94e854443 

Diff: http://codereview.secondlife.com/r/194/diff


Testing
---

Proper testing with and without this patch is to have 2 or more avatars at 1050 
height with other avatars on the ground under you, and the NearmeRange (debug 
setting) set to 4096 and the sort order in the Nearby avatars panel set to sort 
by distance. (A busy region like a sandbox, is a good place to test.) Without 
this patch, a nearby avatar will not necessarily be displayed before avatars 
that are further away.  With this patch, the avatar standing closest to you 
should show up as the first in the list.   


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-954 corrected patch

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/194/
---

(Updated March 9, 2011, 3:33 p.m.)


Review request for Viewer.


Summary
---

STORM-954 review had 2 patches, the second of which was approved in review 
process but the first patch is what went into viewer-development.  This is that 
second patch again. This patch modifies getAvatars() in llworld.cpp.  Note this 
patch becomes more important if/when avatar distances may be displayed to users 
in the viewer as it corrects for map data being incorrect above 1024m by using 
the viewer characters list to get avatar position if known and then falling 
back on the map data for the avatars that are beyond view range.  This patch is 
in the repository 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-954


This addresses bug storm-954.
http://jira.secondlife.com/browse/storm-954


Diffs
-

  indra/newview/llworld.cpp aed94e854443 

Diff: http://codereview.secondlife.com/r/194/diff


Testing
---

Proper testing with and without this patch is to have 2 or more avatars at 1050 
height with other avatars on the ground under you, and the NearmeRange (debug 
setting) set to 4096 and the sort order in the Nearby avatars panel set to sort 
by distance. (A busy region like a sandbox, is a good place to test.) Without 
this patch, a nearby avatar will not necessarily be displayed before avatars 
that are further away.  With this patch, the avatar standing closest to you 
should show up as the first in the list.   


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] VWR-25112 Nearby sidebar minimap should be optional‏

[Twisted Laws]

VWR-25112 Nearby sidebar minimap should be optional‏
https://jira.secondlife.com/browse/VWR-25112
 
I ask that this be brought into STORM and for me to be able to provide a 
possible solution for a future sprint.
 
1. my proposed solution is to add a "View Map" checked menu option to the gear 
menu for the Nearby tab that when enabled would display the map as it does now, 
and when disabled, hide the map and resize the avatar_list to use the full 
space.
 
2. a possible solution for resizing the map is to use layout-stacks and 
layout-panels altho i think that should be done seperate.
 
3. the top/bottom positioning should be a separate issue as I'm not sure the 
way I'd do it would be acceptable.  (I could accomplish it but it would be by 
having code override xml or by having duplicate controls hidden/displayed.)
 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 'Stop Tracking' menu item is still enabled in Mini-map floater after you stopped tracking in Nearby mini-map

[Twisted Laws]

> On March 10, 2011, 2:57 p.m., Jonathan Yap wrote:
> > indra/newview/llnetmap.cpp, line 514
> > <http://codereview.secondlife.com/r/133/diff/1/?file=767#file767line514>
> >
> > Why is a 0 (or in some other places of the code, a NULL) being passed 
> > here?  It seems the definition of isTracking() does nothing with this and 
> > it could be eliminated from the definition in the .h file and the code that 
> > calls it.

it would have been beyond the scope of the change to have modified that.  just 
following the style of existing code.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/133/#review442
-------


On Feb. 3, 2011, 12:43 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/133/
> ---
> 
> (Updated Feb. 3, 2011, 12:43 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Sets "Stop Tracking" enabled based on tracking if true or false instead of 
> only when true.  Also made it check for menu pointer validity to remove a 
> remote crash possiblity.
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llnetmap.cpp ec4a9fd30688 
> 
> Diff: http://codereview.secondlife.com/r/133/diff
> 
> 
> Testing
> ---
> 
> My testing was to open the side panel nearby, and verify that the state of 
> the menu was correct when tracking by the different methods and disabled.   
> Then leaving that open, openned a mini-map instance and repeated testing its 
> state tracking and not.  Also tried the reverse. Verified that every 
> possibility I could think of, the state of both menus was always correct.  
> 
> Correct state is Stop Tracking is enabled anytime tracking is on for avatars 
> or landmarks and is not enabled when Tracking has been stopped no matter 
> where you stopped tracking (i.e, clicking on red arrow in view window, and 
> using the various menues).
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] VWR-25112 Nearby sidebar minimap should be optional

[Twisted Laws]

I attached a patch to https://jira.secondlife.com/browse/VWR-25112 with a 
repository in 
https://bitbucket.org/Twisted_Laws/viewer-development-vwr-25112/changeset/8905c772541a
 to hide/show the minimap in the Nearby tab.   I'm not sure this is going to be 
a final resolution of this jira as there are alternate solutions being 
proposed, thus I did not create a Review task for it.   If I should create the 
review, let me know.
 
Note that this must be retested in conjunction with the changes from Jonathan 
that change the size of the minimap but it should work ok with any resizing he 
may have done.
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---


This looks good to me and I've already made most of these changes in my own 
viewer as it makes the mini-map control be more useful and able to be used 
more places.  One additional change I'd recommend is in 
llNetMap::handleMouseDown
or you may not be able to drag the true mini-map floater around the screen.
This is to only return TRUE (or handled) when the mini-map control really is
handling the call.

BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
{
BOOL ret = FALSE;
if (mask & MASK_SHIFT)
{
// Start panning
gFocusMgr.setMouseCapture(this);

mStartPan = mCurPan;
ret = TRUE;
}
mMouseDown.mX = x;
mMouseDown.mY = y;
return ret;
}


- Twisted


On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
> 
> (Updated March 14, 2011, 8:44 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
>   that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
>   out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
>   (BOOL is known to cause hard-to-debug side effects with values > 1
>   because it's essentially just an int and thus doesn't enforce
>   any limitations on the value).
> 
> Originally based on the patch by Twisted Laws: 
> https://codereview.secondlife.com/r/133/
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatermap.h 439fc3a274d8 
>   indra/newview/llfloatermap.cpp 439fc3a274d8 
>   indra/newview/llnetmap.cpp 439fc3a274d8 
>   indra/newview/lltracker.h 439fc3a274d8 
> 
> Diff: http://codereview.secondlife.com/r/200/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

[Twisted Laws]

> On March 14, 2011, 8:53 a.m., Twisted Laws wrote:
> > This looks good to me and I've already made most of these changes in my own 
> > viewer as it makes the mini-map control be more useful and able to be used 
> > more places.  One additional change I'd recommend is in 
> > llNetMap::handleMouseDown
> > or you may not be able to drag the true mini-map floater around the screen.
> > This is to only return TRUE (or handled) when the mini-map control really is
> > handling the call.
> > 
> > BOOL LLNetMap::handleMouseDown( S32 x, S32 y, MASK mask )
> > {
> > BOOL ret = FALSE;
> > if (mask & MASK_SHIFT)
> > {
> > // Start panning
> > gFocusMgr.setMouseCapture(this);
> > 
> > mStartPan = mCurPan;
> > ret = TRUE;
> > }
> > mMouseDown.mX = x;
> > mMouseDown.mY = y;
> > return ret;
> > }
> >
> 
> Vadim ProductEngine wrote:
> Twisted, I fail to see any dragging problrem with the mini-map floater. 
> Are you sure this change is needed?

Hmmm... maybe it was because I also removed LLFloaterMap::handleDoubleClick as 
its 
duplicated in LLNetMap::handleDoubleClick.  I just remembered when I removed 
all 
the duplications that the mini-map wouldn't drag until I changed the return 
from the
control (actual dragging is handled elsewhere in the class structure, llfloater 
maybe).
I guess thats beyond the scope of this change tho.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review457
---


On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
> 
> (Updated March 14, 2011, 8:44 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
>   that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
>   out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
>   (BOOL is known to cause hard-to-debug side effects with values > 1
>   because it's essentially just an int and thus doesn't enforce
>   any limitations on the value).
> 
> Originally based on the patch by Twisted Laws: 
> https://codereview.secondlife.com/r/133/
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatermap.h 439fc3a274d8 
>   indra/newview/llfloatermap.cpp 439fc3a274d8 
>   indra/newview/llnetmap.cpp 439fc3a274d8 
>   indra/newview/lltracker.h 439fc3a274d8 
> 
> Diff: http://codereview.secondlife.com/r/200/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-971 Disable the 'Stop Tracking' menu item in Mini-map floater when location tracking gets stopped.

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/200/#review461
---

Ship it!


Looks excellent!

- Twisted


On March 14, 2011, 8:44 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/200/
> ---
> 
> (Updated March 14, 2011, 8:44 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes:
> - Removed the menu from LLFloaterMap (the mini-map floater)
>   that had conflicted with the one in the LLNetMap widget.
> - Fixed updating of the "Stop Tracking" menu item; moved that code
>   out of draw() to avoid excessive updates.
> - Preventively fixed LLTracker::isTracking() to return strictly 1 or 0
>   (BOOL is known to cause hard-to-debug side effects with values > 1
>   because it's essentially just an int and thus doesn't enforce
>   any limitations on the value).
> 
> Originally based on the patch by Twisted Laws: 
> https://codereview.secondlife.com/r/133/
> 
> 
> This addresses bug STORM-971.
> http://jira.secondlife.com/browse/STORM-971
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloatermap.h 439fc3a274d8 
>   indra/newview/llfloatermap.cpp 439fc3a274d8 
>   indra/newview/llnetmap.cpp 439fc3a274d8 
>   indra/newview/lltracker.h 439fc3a274d8 
> 
> Diff: http://codereview.secondlife.com/r/200/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] merov's viewer-autobuild2010

[Twisted Laws]

I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting 
yesterday 
and manually inserted fmod files and then ran
 
autobuild --debug configure -c OpenSourceRelWithDebInfo
 
autobuild --debug build -c OpenSourceRelWithDebInfo
 
logged in with LindenDeveloper.exe in the RelWithDebInfo directory.
 
I'm on Windows 7, with Visual Studio 10.0 Professional with a fresh pull from
bitbucket.org/merov_linden/viewer-autobuild2010 with autobuild up to date
 
YEAH!
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-954 corrected patch

[Twisted Laws]

> On March 31, 2011, 12:24 p.m., Merov Linden wrote:
> > +1 on this patch modulo the code convention fix I mention here under.

Corrected and updated in 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-954/changeset/7bcb336642f4
 (the braces changes only)


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/194/#review526
---


On March 9, 2011, 3:33 p.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/194/
> ---
> 
> (Updated March 9, 2011, 3:33 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> STORM-954 review had 2 patches, the second of which was approved in review 
> process but the first patch is what went into viewer-development.  This is 
> that second patch again. This patch modifies getAvatars() in llworld.cpp.  
> Note this patch becomes more important if/when avatar distances may be 
> displayed to users in the viewer as it corrects for map data being incorrect 
> above 1024m by using the viewer characters list to get avatar position if 
> known and then falling back on the map data for the avatars that are beyond 
> view range.  This patch is in the repository 
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-954
> 
> 
> This addresses bug storm-954.
> http://jira.secondlife.com/browse/storm-954
> 
> 
> Diffs
> -
> 
>   indra/newview/llworld.cpp aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/194/diff
> 
> 
> Testing
> ---
> 
> Proper testing with and without this patch is to have 2 or more avatars at 
> 1050 height with other avatars on the ground under you, and the NearmeRange 
> (debug setting) set to 4096 and the sort order in the Nearby avatars panel 
> set to sort by distance. (A busy region like a sandbox, is a good place to 
> test.) Without this patch, a nearby avatar will not necessarily be displayed 
> before avatars that are further away.  With this patch, the avatar standing 
> closest to you should show up as the first in the list.   
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Windows compiling problem

[Twisted Laws]

A possibility is the sequence of your includes ...  it needs the 7.1 version of 
the SDK
and to have \Microsoft SDKs\Windows\v7.1\Include as the first include

i have a batch file that i run after opening the Visual Studio Command Prompt 
window...
 
@set INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v7.1\Include;C:\Program 
Files\Microsoft SDKs\Windows\v7.1\Include\gl;C:\Program Files (x86)\Microsoft 
DirectX SDK (June 2010)\Include;%INCLUDE%
@set LIB=C:\Program Files\Microsoft SDKs\Windows\v7.1\Lib;C:\Program 
Files\Microsoft SDKs\Windows\v7.1\Lib\x64;C:\Program Files (x86)\Microsoft 
DirectX SDK (June 2010)\Lib;%LIB%
@set PATH=%PATH%;C:\Dev\hgbuilds\autobuild\bin
 
Maybe it helps, hope so.
 
> Date: Wed, 6 Apr 2011 11:46:39 -0400
> From: mo...@lindenlab.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Windows compiling problem
> 
> On 4/5/2011 4:03 PM, Jonathan Welch wrote:
> > I have not had much chance to compile since viewer-development took in
> > the autobuild changes. This afternoon I gave it a try and fixed a few
> > issues but am stumped at how to fix this, which occurs in a number of
> > places:
> >
> > -- Build started: Project: llwindow, Configuration: Release Win32 --
> > llwindowwin32.cpp
> > lldxhardware.cpp
> > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11280): error C2061:
> > syntax error : identifier '__RPC__out_xcount_part'
> > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): error C2059:
> > syntax error : ')'
> > e:\Microsoft SDKs\Windows\v7.1\Include\objidl.h(11281): fatal error
> > C1903: unable to recover from previous error(s); stopping compilation
> >
> > I fiddled a bit with the include path in the props file and this is
> > what I currently have:
> > E:\Microsoft Visual Studio 10.0\VC\INCLUDE;e:\Microsoft
> > SDKs\Windows\v7.1\Include;e:\Microsoft
> > SDKs\Windows\v7.1\Include\gl;e:\Microsoft DirectX SDK (June
> > 2010)\Include;e:\Microsoft
> > SDKs\Windows\v7.1\Samples\winui\TSF\tsfapp;$(WindowsSdkDir)\include;$(IncludePath)
> >
> > That first entry is a result of my fiddling. This is happening in
> > vs2010 but also via autobuild in a dos window.
> >
> > Googling on this error says it is an issue of having the include file
> > list in a certain order, but as far as I can tell my list is
> > correct...and worked when we were testing autobuild builds before the
> > code got merged into viewer-development.
> >
> > Can you shed any light on this? I am stumped.
> 
> Confirmed (I get it myself). Probably has to do with sensitivity to
> the SDKs installed on the system. The offending include order,
> in reverse order, is:
> 
> "C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A\\include\\objid
> l.h"
> "C:\\Program Files (x86)\\Microsoft SDKs\\Windows\\v7.0A\\include\\obj
> base.h"
> "C:\\Program Files (x86)\\Microsoft 
> SDKs\\Windows\\v7.0A\\include\\ole2.h"
> "c:\\mcb\\hg\\viewer-development\\indra\\llwindow\\lldragdropwin32.h"
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/
---

Review request for Viewer.


Summary
---

Patch makes the map in the Nearby people tab optional with a menu option in the 
gear 
menu.  Patch is XML only and resizing of the map is disabled 
(user_resize="false" in 
the layout_panels) as I could not find a way to easily save window sizes purely 
in XML.
Patch is in the repository of 
https://Twisted_Laws/viewer-development-storm-1103 as
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af


This addresses bug STORM-1103.
http://jira.secondlife.com/browse/STORM-1103


Diffs
-

  doc/contributions.txt ee4d271eef9b 
  indra/newview/app_settings/settings.xml ee4d271eef9b 
  indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml 
ee4d271eef9b 
  indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 

Diff: http://codereview.secondlife.com/r/265/diff


Testing
---

Tested by exercising the gear menu option of "View Map" with the People tab 
attached 
and detached insuring the map appears and disappears properly.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

> On April 14, 2011, 12:37 p.m., Boroondas Gupte wrote:
> > indra/newview/skins/default/xui/en/panel_people.xml, lines 117-127
> > <http://codereview.secondlife.com/r/265/diff/1/?file=1475#file1475line117>
> >
> > I'd prefer to have the attributes ordered semantically (i.e. 'name' 
> > first, 'top' and 'left' right after each other, 'height' and 'width' right 
> > after each other etc.) rather than alphabetically. But as the surrounding 
> > code also seems to have its attributes ordered alphabetically, we might as 
> > well stick to that. Though, then, keep_one_selected should be moved up.

I always wondered about the sequencing of these, but I figured that it was some 
application that 
made it easier to work on these did that ordering.  The code that reads it 
doesn't care about ordering.
As far as if fields are required or not, I've no idea as I don't believe I have 
any access to any 
documentation.  Me working on XML files is try it, change it, try it, etc...

I'll leave it sit a little while for any other comments, and then I'll change 
it as you suggest.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/#review602
---


On April 14, 2011, 5:29 a.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/265/
> ---
> 
> (Updated April 14, 2011, 5:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Patch makes the map in the Nearby people tab optional with a menu option in 
> the gear 
> menu.  Patch is XML only and resizing of the map is disabled 
> (user_resize="false" in 
> the layout_panels) as I could not find a way to easily save window sizes 
> purely in XML.
> Patch is in the repository of 
> https://Twisted_Laws/viewer-development-storm-1103 as
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
> 
> 
> This addresses bug STORM-1103.
> http://jira.secondlife.com/browse/STORM-1103
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt ee4d271eef9b 
>   indra/newview/app_settings/settings.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml 
> ee4d271eef9b 
>   indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 
> 
> Diff: http://codereview.secondlife.com/r/265/diff
> 
> 
> Testing
> ---
> 
> Tested by exercising the gear menu option of "View Map" with the People tab 
> attached 
> and detached insuring the map appears and disappears properly.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

> On April 14, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml, line 45
> > <http://codereview.secondlife.com/r/265/diff/1/?file=1474#file1474line45>
> >
> > I'd say "View Mini-Map": by "Map" we usually mean the world map, which 
> > is obviously a different thing.

I was making the other changes mentioned in the reviews, but this one I 
question...  imho, putting in View Mini-Map is misleading also as a requirement 
of implementation was to leave the mini-map available seperately.  I would not 
consider this the "mini-map".  But I'm open to have it however you (as a 
Linden) want it.


- Twisted


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/#review603
-------


On April 14, 2011, 5:29 a.m., Twisted Laws wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/265/
> ---
> 
> (Updated April 14, 2011, 5:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Patch makes the map in the Nearby people tab optional with a menu option in 
> the gear 
> menu.  Patch is XML only and resizing of the map is disabled 
> (user_resize="false" in 
> the layout_panels) as I could not find a way to easily save window sizes 
> purely in XML.
> Patch is in the repository of 
> https://Twisted_Laws/viewer-development-storm-1103 as
> https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
> 
> 
> This addresses bug STORM-1103.
> http://jira.secondlife.com/browse/STORM-1103
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt ee4d271eef9b 
>   indra/newview/app_settings/settings.xml ee4d271eef9b 
>   indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml 
> ee4d271eef9b 
>   indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 
> 
> Diff: http://codereview.secondlife.com/r/265/diff
> 
> 
> Testing
> ---
> 
> Tested by exercising the gear menu option of "View Map" with the People tab 
> attached 
> and detached insuring the map appears and disappears properly.
> 
> 
> Thanks,
> 
> Twisted
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/
---

(Updated April 15, 2011, 11:46 a.m.)


Review request for Viewer.


Changes
---

revised patch is attached, repository updated


Summary
---

Patch makes the map in the Nearby people tab optional with a menu option in the 
gear 
menu.  Patch is XML only and resizing of the map is disabled 
(user_resize="false" in 
the layout_panels) as I could not find a way to easily save window sizes purely 
in XML.
Patch is in the repository of 
https://Twisted_Laws/viewer-development-storm-1103 as
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af


This addresses bug STORM-1103.
http://jira.secondlife.com/browse/STORM-1103


Diffs (updated)
-

  doc/contributions.txt ee4d271eef9b 
  indra/newview/app_settings/settings.xml ee4d271eef9b 
  indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml 
ee4d271eef9b 
  indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 

Diff: http://codereview.secondlife.com/r/265/diff


Testing
---

Tested by exercising the gear menu option of "View Map" with the People tab 
attached 
and detached insuring the map appears and disappears properly.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/
---

(Updated May 14, 2011, 1:07 p.m.)


Review request for Viewer.


Changes
---

corrected a bad url to the repository in my description and added the second 
changeset url


Summary (updated)
---

Patch makes the map in the Nearby people tab optional with a menu option in the 
gear 
menu.  Patch is XML only and resizing of the map is disabled 
(user_resize="false" in 
the layout_panels) as I could not find a way to easily save window sizes purely 
in XML.
Patch is in the repository of 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
and 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1


This addresses bug STORM-1103.
http://jira.secondlife.com/browse/STORM-1103


Diffs
-

  doc/contributions.txt ee4d271eef9b 
  indra/newview/app_settings/settings.xml ee4d271eef9b 
  indra/newview/skins/default/xui/en/menu_people_nearby_view_sort.xml 
ee4d271eef9b 
  indra/newview/skins/default/xui/en/panel_people.xml ee4d271eef9b 

Diff: http://codereview.secondlife.com/r/265/diff


Testing
---

Tested by exercising the gear menu option of "View Map" with the People tab 
attached 
and detached insuring the map appears and disappears properly.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

[Twisted Laws]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/265/
---

(Updated June 26, 2011, 8:32 a.m.)


Review request for Viewer.


Changes
---

Corrects an issue identified in JIRA STORM-1103 where it is possible to make it 
so the map can no longer be displayed.
Quoted from JIRA

 1. Open Nearby Panel
 2. Decrease viewer window height until mini-map disappears automatically
 3. Disable mini-map in the gear menu
 4. Maximize viewer window height
 5. Enable minim-map via gear menu

Actual Results Minimap isn't displayed without this patch.  With this patch, 
the Minimap is still displayable.


Summary
---

Patch makes the map in the Nearby people tab optional with a menu option in the 
gear 
menu.  Patch is XML only and resizing of the map is disabled 
(user_resize="false" in 
the layout_panels) as I could not find a way to easily save window sizes purely 
in XML.
Patch is in the repository of 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103 as
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/3455e79a14af
and 
https://bitbucket.org/Twisted_Laws/viewer-development-storm-1103/changeset/48b66643a4d1


This addresses bug STORM-1103.
http://jira.secondlife.com/browse/STORM-1103


Diffs (updated)
-

  indra/newview/skins/default/xui/en/panel_people.xml 48b66643a4d1 

Diff: http://codereview.secondlife.com/r/265/diff


Testing
---

Tested by exercising the gear menu option of "View Map" with the People tab 
attached 
and detached insuring the map appears and disappears properly.


Thanks,

Twisted

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm PO review build

[Twisted Laws]

fails STORM-64, STORM-787 , STORM-1396 , VWR-25062
passes STORM-323, STORM-1103, STORM-1334, STORM-1392, STORM-1393, 
comments intermixed
EXP-825  - untested 
[#STORM-1439] [crashhunters] crash in LLToolPie::handleMouseUp 
 
STORM-64  - couldn’t figure out how to invoke this 
As a Builder, I want the ability to use temporary images, animations, etc. 
and preview them inworld before uploading them 
 
STORM-323  - good 
redundant popups 
 
STORM-787  - setting not displayed in preferences media 
Mute Gestures Button 
 
STORM-1103 – good, works as expected 
Nearby sidebar minimap should be optional 
 
STORM-1292  - untested 
[UNTRANSLATABLE XUI ATTRIBUTE] "Mi apariencia" tab in side menu bar > "MIS 
VESTUARIOS". You don't have any outfits yet. Try Search. (ALL LANGS) 
 
STORM-1302 – untested 
(all langs) [TRANSLATED BUT IN ENG] (Spanish) Side Menu > Gente tab > MIS 
AMIGOS tab > buttons "Call", "Share" and "Teleport" and their tooltips 
 
STORM-1326 – untested 
[ALL LANGS] (Spanish) [HARDCODED] Selling land, advice with "Anyone" in 
English. 
 
STORM-1334 – good 
Console debug data scrolls away too quickly and is hard to read 
 
STORM-1352 – untested 
[crashhunters] crash in LLNearbyChatScreenChannel::showToastsBottom() 
 
STORM-1372 – untested 
[crashhunters] crash at [1] LLTemplateMessageBuilder::nextBlock(char const 
*) [secondlife-bin lltemplatemessagebuilder.cpp] 
 
STORM-1392 – good 
Add Nearby Voice to the Communicate menu 
 
STORM-1393 – good 
Missing Object/Prim count in Second Life 2.7.4 (233201) Jun 17 2011 
21:33:05 (Second Life Development) 
 
STORM-1396 – untested (no setting in preferences media) 
Storm-787 (mute gestures) also mutes sounds from objects 
 
VWR-24099  - untested 
[#STORM-1372] [crashhunters] crash at [1] 
LLTemplateMessageBuilder::nextBlock(char const *) [secondlife-bin 
lltemplatemessagebuilder.cpp] 
 
VWR-25062 – the preferences media panel is empty below Allow Media to 
auto-play and Enable media filter checkboxes, losing Play media attached to 
other avatars, Play sounds from gestures, Voice Chat Settings and Input/output 
devices. 
[#STORM-1346] Add the ability to allow or deny domains that parcel owners 
want to play in the viewer's media and audio players 
 
VWR-25480 – untested 
[#STORM-1350] Worldmap: Partial region name search UI bug 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Mesh viewers and tcmalloc issues

[Twisted Laws]

Only thing I don't understand about all this, is if you clone and build 
viewer-development and 3p-google-perftools, then LL_USE_TCMALLOC is undefined 
in both.
 in GooglePerfTools.cmake:  set(TCMALLOC_FLAG -ULL_USE_TCMALLOC=1)
and in llcommon property pagesUndefine Preprocessor Definitions: 
LL_USE_TCMALLOC=1So it would appear, at least by default, that tcmalloc is not 
enabled.   Am I understanding this wrong?  Or does LL build their viewer with 
it defined and sending the viewer out the opensource world with it disabled? I 
did follow Henri's msg and built a viewer with 
EnvToDouble("TCMALLOC_RELEASE_RATE", 1.0) (in 3p-google-perftools) and it 
seems to do exactly the same as without it. Twisted > Date: Sat, 1 Oct 2011 
22:24:56 +0200
> From: sl...@free.fr
> To: opensource-dev@lists.secondlife.com
> Subject: [opensource-dev] Mesh viewers and tcmalloc issues
> 
> Greetings,
> 
> I noticed that all the viewers using tcmalloc (mesh viewers under Linux
> and Windows, since those use SSE2 and must gain memory-aligned malloc()
> and new() calls that their standard library does not provide) suffer
> from a serious problem: they never release memory back to the system,
> meaning that after visiting a crowded place and caming around a lot,
> the viewer can occupy 2.5Gb of memory, and even after you TP out to a
> skybox with almost no objects/textures and no avatar around, the viewer
> retains the full amount of alloctaed memory for itself.
> 
> Worst, should you manage to keep the viewer from crashing during a full
> hour or so, its allocated memory will get so badly fragmented that it
> starts crawling down and finally crashes, even in quiet sims.
> 
> Bao Linden recently worked on private memory pools to work around these
> issues, but so far and despite his hard work, the result is less than 
> satisfactory: the memory is still never released to the system, and the
> viewers using private memory pools crash every few minutes after issuing
> a warning:
> "LLPluginProcessParent::poll: apr_pollset_poll failed with status 4
> 
> Well, be happy since I found an easy work around for these problems
> while working on the Cool VL Viewer v1.26.1 (the mesh branch).
> 
> tcmalloc is actually supposed to release back to the system the memory
> freed by the application using it, but it does so only after a certain
> number of memory blocks have been freed. There is an environment
> variable that you can set (TCMALLOC_RELEASE_RATE) to adjust the "rate"
> at which tcmalloc will release the freed blocks back to the system.
> In fact, this is not really a rate, but a divisor (the number of freed
> blocks is divided by the rate number (when != 0: a 0 rate means "never
> release memory"), and compared to a threshold. If the number is below
> the threshold, the freed blocks are released.
> The documentation for tcmalloc says that "Reasonable rates are in the
> range [0,10]", but even with a rate of 10, you never get the viewer to
> release more than a couple hundreds megabytes for 2+Gb of allocated
> memory. It occurred to me that the algorithm tcmalloc uses is simply
> crippled !
> 
> The good news, is that if you pass an "unreasonnable" rate, tcmalloc
> will finally release memory (the more "unreasonnable" and the more
> memory is released). With a rate of 1 (yes, ten thousands), you
> get the viewer to release everything when it doesn't need it any more,
> which matches the behaviour of tcmalloc-less viewers.
> 
> Since the Windows builds don't use a wrapper script to launch the
> viewer, it is however best to hardcode this new rate as the default
> one in tcmalloc istelf. This is what I did for the Cool VL Viewer
> and it works like a charm. There is only one line to change in
> tcmalloc source, in src/page_heap.cc:
> DEFINE_double(tcmalloc_release_rate,
> EnvToDouble("TCMALLOC_RELEASE_RATE", 1.0),<--- HERE
> "Rate at which we release unused memory to the system.  "
> "Zero means we never release memory back to the system.  "
> "Increase this flag to return memory faster; decrease it "
> "to return memory slower.  Reasonable rates are in the "
> "range [0,10]");
> 
> Now, the viewer runs rock stable (just like the non-mesh, tcmalloc-less
> version) and uses very reasonnable amounts of memory. It also doesn't
> suffer from memory fragmentation any more since it is transparently
> taken care of by the OS (via the page table and the PMMU of the CPU,
> something neither tcmalloc nor Bao's private memory pool can do since
> these are userspace code).
> 
> For what it is worth...
> 
> Henri.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.c

Re: [opensource-dev] whatever happened to the versioning scripts?

[Twisted Laws]

Maybe I’m missing something here... or did someone forget to hg add this file?  
Its not in viewer-release or viewer-development.

Twisted

From: Oz Linden (Scott Lawrence) 
Sent: Thursday, May 02, 2013 2:03 PM
To: opensource-dev@lists.secondlife.com 
Subject: Re: [opensource-dev] whatever happened to the versioning scripts?

On 2013-05-01 09:50 , Lance Corrimal wrote:

Hi,

I just noticed that a commit in viewer-beta removed the two scripts 
build_version.py and update_version_files.py from the scripts/ directory, is 
that supposed to be that way? What should be used now to update the different 
version files, other than vi?

See 
https://wiki.secondlife.com/wiki/Channel_and_Version_Requirements#Version_Number

To update the first three levels of the version number, edit just one file: 
indra/newview/VIEWER_VERSION.txt

That value is then propagated everywhere it needs to be (more places than it 
used to be, in fact).

The fourth level number can be set manually at build time by the 'revision' 
environment variable; if that is not set, the build will try to use the 
Mercurial revision number of the current repo, or zero if it can't use that.



-- 

Scott Lawrence | Director of Open Development
Skype ozlinden | Second Life Oz Linden

Linden Lab | Makers of Shared Creative Spaces
SECOND LIFE | PATTERNS | CREATORVERSE | DIO | VERSU 



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] possible display name crash

[Twisted Laws]

Not sure what the issue is, but today, i've had 3 crashes in 
LLHUDNameTag::setLabel at mLabelSegments.clear() running my own build of latest 
pull from viewer-development on Windows 7.  It may have something to do with 
boost or just a timing issue between threads or maybe its just me or where i 
was.  These all happened in sandbox goguen while my display name was set to 
something different.  It appeared it happens when someone leaves the region.  
All the locals looked good further in the call stack but when it gets to the 
crash point, "this" equals 0x.  Any other issues like this?   This only 
started happening today and never with builds before last wednesday.  Turning 
off display names allows me to run the same version with no problems.  I don't 
see recent changes in this area and have tried rebuild all, etc..  Anyone have 
an idea?
 
Twisted
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] possible display name crash

[Twisted Laws]

Thanks, the patch in that jira corrected the problem I was having.  No more 
crashes for me, yeah!
 
> I'm not sure if this is actually your crash, but it seems to match rather
> closely with a lot of what you described:
> https://jira.secondlife.com/browse/VWR-23653 (patch attached).
> 
> Kitty
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-151 : KDU v6.4.1 upgrade update

[Twisted Laws]

I downloaded this and attempt to run on the 64bit  Windows 7 Ultimate and it 
failed with "The program can't start because kdu_v64R.dll is missing from your 
computer."
 


I worked on that today and got it working locally on my Windows machine. The 
Team City build went through and it's there:
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-features/rev/215468/index.html
 

I couldn't test Windows or Linux but if someone could give those a spin, that'd 
be swell.

  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-151 : KDU v6.4.1 upgrade update

[Twisted Laws]

If I clone your source, i can compile and run (without kdu obviously) but I 
can't run the version that you compiled with kdu.
Maybe since I'm on 64bit Win 7, the static lib wants the 64bit dll (assumed 
from name).
 
Here is the list of dependencies of your executable reported by DEPENDS.EXE 
(from MS):

 $ c:/dev/depends/depends secondlifedeveloper.exe
WLDAP32.dll
WSOCK32.dll
WINMM.dll
MSACM32.dll
fmod.dll
API-MS-Win-Security-SDDL-L1-1-0.dll
dwmapi.dll
DEVOBJ.dll
CFGMGR32.dll
SETUPAPI.dll
DCIMAN32.dll
DDRAW.dll
GLU32.dll
OPENGL32.dll
OLEAUT32.dll
ole32.dll
COMCTL32.dll
comdlg32.dll
SHLWAPI.dll
SHELL32.dll
DINPUT8.dll
MSVCP80.dll
dbghelp.dll
wkscli.dll
srvcli.dll
netutils.dll
NETAPI32.dll
PSAPI.DLL
libapriconv-1.dll
MSVCR80.dll
API-MS-WIN-Service-Management-L2-1-0.dll
API-MS-WIN-Service-Management-L1-1-0.dll
API-MS-WIN-Service-winsvc-L1-1-0.dll
API-MS-WIN-Service-Core-L1-1-0.dll
ADVAPI32.dll
USP10.dll
LPK.dll
API-MS-Win-Core-RtlSupport-L1-1-0.dll
KERNEL32.dll
GDI32.dll
user32.dll
MSWSOCK.dll
NSI.dll
API-MS-Win-Security-LSALookup-L1-1-0.dll
API-MS-Win-Core-DelayLoad-L1-1-0.dll
CRYPTBASE.dll
SspiCli.dll
API-MS-Win-Core-ThreadPool-L1-1-0.dll
RPCRT4.dll
API-MS-Win-Security-Base-L1-1-0.dll
API-MS-Win-Core-LocalRegistry-L1-1-0.dll
API-MS-Win-Core-IO-L1-1-0.dll
API-MS-Win-Core-Util-L1-1-0.dll
API-MS-Win-Core-SysInfo-L1-1-0.dll
API-MS-Win-Core-Synch-L1-1-0.dll
API-MS-Win-Core-String-L1-1-0.dll
API-MS-Win-Core-Profile-L1-1-0.dll
API-MS-Win-Core-ProcessThreads-L1-1-0.dll
API-MS-Win-Core-ProcessEnvironment-L1-1-0.dll
API-MS-Win-Core-NamedPipe-L1-1-0.dll
API-MS-Win-Core-Misc-L1-1-0.dll
API-MS-Win-Core-Memory-L1-1-0.dll
API-MS-Win-Core-LibraryLoader-L1-1-0.dll
API-MS-Win-Core-Localization-L1-1-0.dll
API-MS-Win-Core-Interlocked-L1-1-0.dll
API-MS-Win-Core-Heap-L1-1-0.dll
API-MS-Win-Core-Handle-L1-1-0.dll
API-MS-Win-Core-File-L1-1-0.dll
API-MS-Win-Core-Fibers-L1-1-0.dll
API-MS-Win-Core-ErrorHandling-L1-1-0.dll
API-MS-Win-Core-Debug-L1-1-0.dll
API-MS-Win-Core-DateTime-L1-1-0.dll
API-MS-Win-Core-Console-L1-1-0.dll
ntdll.dll
KERNELBASE.dll
msvcrt.dll
WS2_32.dll
libapr-1.dll
libaprutil-1.dll
llcommon.dll
secondlifedeveloper.exe
  Not found: kdu_v64R.dll
 
Twisted
 



On Wed, Nov 24, 2010 at 5:28 AM, Twisted Laws  wrote:


I downloaded this and attempt to run on the 64bit  Windows 7 Ultimate and it 
failed with "The program can't start because kdu_v64R.dll is missing from your 
computer."


Strange that it worked for Patnad and Zha... Anyone else with that error?

Cheers,
- Merov 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-151 : KDU v6.4.1 upgrade update

[Twisted Laws]

The build from yesterday works great!
 
Second Life 2.4.0 (215468) Nov 23 2010 20:17:31 (Second Life Developer)
Release Notes
You are at 255,699.0, 255,436.0, 21.0 in Sandbox Goguen located at 
sim9026.agni.lindenlab.com (216.82.41.202:13004)
Second Life RC Magnum 10.11.09.214391
Release Notes
CPU: Intel(R) Core(TM)2 Quad  CPU   Q9000  @ 2.00GHz (1995.01 MHz)
Memory: 6142 MB
OS Version: Microsoft Windows 7 64-bit  (Build 7600)
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: ATI Mobility Radeon HD 4650
Windows Graphics Driver Version: 8.14.0010.0678
OpenGL Version: 2.1.8787
libcurl Version: libcurl/7.20.1 OpenSSL/0.9.8j zlib/1.2.3
J2C Decoder Version: KDU
Audio Driver Version: FMOD version 3.75
Qt Webkit Version: 4.6 (version number hard-coded)
Voice Server Version: Vivox 3.2.0002.9361
Built with MSVC version 1400
Packets Lost: 273/17,198 (1.6%)
 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges