Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review856
---

Ship it!


Looks good.
Works for me.

- Seth


On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> ---
> 
> (Updated July 10, 2011, 6:24 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations 
> that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that 
> file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
> http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> ---
> 
> Switched to French, relogged, changed to default mode and logged out. Applied 
> this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded 
> build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and 
> Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

[Boroondas Gupte]

> On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote:
> > Looks good.
> > Works for me.

Thanks for reviewing. As you write "Works for me.", I assume you tested it, 
too? Which languages did you try?


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review856
---


On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> ---
> 
> (Updated July 10, 2011, 6:24 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations 
> that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that 
> file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
> http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> ---
> 
> Switched to French, relogged, changed to default mode and logged out. Applied 
> this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded 
> build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and 
> Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Viewer development 2.8.1 and a few new bugs

[Marine Kelley]

Hi all,

I was trying to adapt the RLV to the latest revision of
viewer-development, and was quite satisfied with the results :

- Far fewer crashes as opposed to 2.7.2 when the deferred renderer is activated
- The "/me" issue in chat when the chat history is hidden is resolved too

However, I am running into a few new issues, and I wonder if anyone
spotted them too :

- Invisiprims don't render well, they are completely black UNLESS they
are set to fullbright (no matter whether deferred shading is on or
off)
- Alpha doesn't render well either, once again unless fullbright is
on. Full strands of hair disappear, it's really ugly
- The viewer slows down to a crawl when attaching or detaching objects
(this is not a RLV bug, I've tested and observed this into the vanilla
viewer too). Worse, if a second inventory window is visible but
minimized, often it will bring it up !
- And the "/me" bug has now migrated to the chat history itself. It
works on the chat floater, but if I say "/me smiles", I'll see "Marine
KelleyMarine Kelley smiles" on the history. This is NOT due to the
"Loading" bug though, this one is completely different and new.

Is any of these new bugs in a JIRA already ? I don't even know what or
where to search... Any pointer is appreciated.

Thanks,
Marine
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] LLQtWebKit Mac OSX Build Instructions

[Laurent Bechir]

Hello,

I'm trying to build LLQtWebKit and when it comes to JavaScriptCore, build fails 
with this message :

http://pastie.org/2198921


Any idea which could help me ? I have a problem when building Kirstens Viewer 
on my Mac. LLQtWebKit doesn't work and always launch a 400 error. That's why I 
would like to try to build it from scratch to see if it could solve the problem.

Thank you
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape.

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/388/
---

Review request for Viewer.


Summary
---

As a Builder, I want to be able to create prims that are more than 95 % hollow 
which will allow me to create more realistic paper sheets, flags, fabric bits, 
ribbons, etc.


This addresses bug STORM-58.
http://jira.secondlife.com/browse/STORM-58


Diffs
-

  doc/contributions.txt d4cd5f0f33d2 
  indra/llmath/llvolume.cpp d4cd5f0f33d2 
  indra/newview/llpanelobject.cpp d4cd5f0f33d2 
  indra/newview/skins/default/xui/en/floater_tools.xml d4cd5f0f33d2 

Diff: http://codereview.secondlife.com/r/388/diff


Testing
---

Built viewer locally and testes Viewer Phase of Acceptance Criteria. 


Thanks,

Wolfpup

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Viewer development 2.8.1 and a few new bugs

[Ardy Lay]

Shining SH-2048 Invisiprims that are members of an attached linkset are 
making the entire linkset invisible.

https://jira.secondlife.com/browse/SH-2048


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Allow objects to have 99.99% max hollow for default hollow shape.

[Dahlia Trimble]

One thing I noticed while coding collision geometry for OpenSimulator is as
hollow is increased and prims are twisted or otherwise manipulated such that
the hollow shape doesnt exactly follow the outer shape, the probability
increases that the surfaces formed by the triangles that make up the hollow
shape may actually protrude beyond those that make up the outer surface. I'm
not sure what SL sims do under these conditions but what ODE (Open Dynamics
Engine - most commonly used physics engine in OpenSimulator) is create a
condition where physical objects may become trapped between the resulting
surfaces. ODE uses trimesh colliders and surface normals for determining
collision surfaces and if prim hollow surfaces protrude outside of prim
outer surfaces, the surface normals for these surfaces point in the wrong
direction. This can be alleviated by increasing prim vertex count, but for
some of these prims vertex count may already be even greater than 4000
vertices. Increasing it further would use excessive memory and likely
increase the cost of computing collisions dramatically. I've found that a
limit of 95% maximum hollow is a good compromise between prim complexity and
usability.


On Mon, Jul 11, 2011 at 7:34 PM, Wolfpup Lowenhar
wrote:

>This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/388/
>   Review request for Viewer.
> By Wolfpup Lowenhar.
> Description
>
> As a Builder, I want to be able to create prims that are more than 95 % 
> hollow which will allow me to create more realistic paper sheets, flags, 
> fabric bits, ribbons, etc.
>
>   Testing
>
> Built viewer locally and testes Viewer Phase of Acceptance Criteria.
>
>   *Bugs: * STORM-58 
> Diffs
>
>- doc/contributions.txt (d4cd5f0f33d2)
>- indra/llmath/llvolume.cpp (d4cd5f0f33d2)
>- indra/newview/llpanelobject.cpp (d4cd5f0f33d2)
>- indra/newview/skins/default/xui/en/floater_tools.xml (d4cd5f0f33d2)
>
> View Diff 
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Viewer development 2.8.1 and a few new bugs

[Marine Kelley]

Thanks... That's not what I observe though, only the invisiprim goes
black, obscuring the prims inside or behind it, but not the entire
linkset

On 12/07/2011, Ardy Lay  wrote:
> Shining SH-2048 Invisiprims that are members of an attached linkset are
> making the entire linkset invisible.
> https://jira.secondlife.com/browse/SH-2048
>
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges