KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 65 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/65/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 06:54:10 + Build duration: 1 hr 58 min and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 3 test(s), Skipped: 1 test(s), Total: 14 test(s)Failed: TestSuite.addremoveannotationtestFailed: TestSuite.annotationstestFailed: TestSuite.documenttestFailed: TestSuite.editannotationcontentstestFailed: TestSuite.editformstestFailed: TestSuite.kimgiotestFailed: TestSuite.modifyannotationpropertiestestFailed: TestSuite.parttestFailed: TestSuite.searchtestFailed: TestSuite.translateannotationtest
[okular] [Bug 387030] New: Overview page mode orders pages from right to left.
https://bugs.kde.org/show_bug.cgi?id=387030 Bug ID: 387030 Summary: Overview page mode orders pages from right to left. Product: okular Version: 1.2.1 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: am...@fisica.ist.utl.pt Target Milestone: --- In the Fedora 27 version of okular the multiple page view mode of pdfs shows pages in reverse order (lowest page number on the right). -- You are receiving this mail because: You are the assignee for the bug.
D8863: Workaround to build with older Qt
aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY As explained in the comment we can do with using an older Qt since what this adds is really a small nicety in a corner case Give warnings when the file is modified externally Unfortunately, poppler (the only backed that supports saving) is not able to save properly if the file is modified by a third party while it is opened So we give the user a warning saying things went wrong and give him the option to not reload/close, that way if there was something very important in the annotations she added she can try to save them (even if by copy&paste the contents to a third program) REPOSITORY R223 Okular BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTED FILES core/document.cpp part.cpp part.h To: aacid Cc: #okular, ngraham, aacid
D8863: Give warnings when the file is modified externally
aacid retitled this revision from "Workaround to build with older Qt" to "Give warnings when the file is modified externally". aacid edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: #okular, ngraham, aacid
D8863: Give warnings when the file is modified externally
aacid updated this revision to Diff 22515. aacid added a comment. actual diff REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8863?vs=22514&id=22515 BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTED FILES part.cpp part.h To: aacid Cc: #okular, ngraham, aacid
D8863: Give warnings when the file is modified externally
aacid added subscribers: ltoscano, rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: rkflx, ltoscano, #okular, ngraham, aacid
[okular] [Bug 387030] Overview page mode orders pages from right to left.
https://bugs.kde.org/show_bug.cgi?id=387030 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO CC||aa...@kde.org --- Comment #1 from Albert Astals Cid --- Can you attach a screenshot? Are you sure you didn't enable RTL mode on the settings? -- You are receiving this mail because: You are the assignee for the bug.
D8863: Give warnings when the file is modified externally
ngraham added inline comments. INLINE COMMENTS > part.cpp:1720 > +res = KMessageBox::warningYesNo( widget(), > + i18n( "You have unsaved > modifications and the file has been modified externally since it was > opened.Unfortunately that means that we can no longer save it and your > changes will be lost.Do you want to continue the reload?" ), > + i18n( "File changed" ), How about this? "There are unsaved changes, but the file has been modified by another program since it was opened.Which version would you like to keep?" [choices would then be "Keep Okular version" and "Keep externally-modified version"] > part.cpp:1728 > +res = KMessageBox::warningYesNo( widget(), > +i18n( "You have unsaved > modifications and the file has been modified externally since it was > opened.Unfortunately that means that we can no longer save it and your > changes will be lost.Do you want to continue closing the file?" ), > +i18n( "File changed" ), How about this? "There are unsaved changes, but the file has been modified by another program since it was opened.The file can no longer be saved and your changes will be lost.Do you want to continue closing the file?" > part.cpp:2489 > + i18n( "File changed" ), > + i18n( "The file has been modified externally > since it was opened, unfortunately that means that we can no longer save it." > ) ); > +return false; How about this? "The file has been changed by another program since it was opened, which means it can no longer be saved." REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: ngraham, rkflx, ltoscano, #okular, aacid
D8863: Give warnings when the file is modified externally
aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > How about this? > > "There are unsaved changes, but the file has been modified by another program > since it was opened.Which version would you like to keep?" > > [choices would then be "Keep Okular version" and "Keep externally-modified > version"] I dont' like this wording, seems like it will let you not lose your changes if you say "keep okular version". All you can do is "hopefully" still see what is rendered, but doing much will probably also break really. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: ngraham, rkflx, ltoscano, #okular, aacid
D8863: Give warnings when the file is modified externally
ngraham added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1720 > I dont' like this wording, seems like it will let you not lose your changes > if you say "keep okular version". All you can do is "hopefully" still see > what is rendered, but doing much will probably also break really. With "Keep Okular version", could we make it save over the file again using the copy in memory--including the current state of the user's annotations and forms? If not, then how about this? "There are unsaved changes, but the file has been modified by another program since it was opened and cannot be saved. Reloading will display the modified version of the file without any of your changes." REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: ngraham, rkflx, ltoscano, #okular, aacid
D8863: Give warnings when the file is modified externally
aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > With "Keep Okular version", could we make it save over the file again using > the copy in memory--including the current state of the user's annotations and > forms? > > If not, then how about this? > > "There are unsaved changes, but the file has been modified by another program > since it was opened and cannot be saved. Reloading will display the modified > version of the file without any of your changes." There's no such thing as "the copy in memory" (at least for PDF that is really what matters at this stage) "modified" is not clear if it's the old or new version, something like "new version" makes more sense REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: ngraham, rkflx, ltoscano, #okular, aacid
