Re: Review Request 129288: Fix unused computation result warning in plucker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 --- Which code are you working against? I fixed this in July. For reference, this code is almost verbatim from the explode tool in the original plucker source. The font variable is used to track whether to start or end a formatted string span (represented by tags in the explode tool). - Martin Tobias Holmedahl Sandsmark On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129288/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > If we assume that the code was correct, then the pointer dereference is > unnecessary. If we assume that the code was wrong, then it probably wanted to > do (*font)--. I assumed the former, but I can't test it. > > > Diffs > - > > generators/plucker/unpluck/qunpluck.cpp 8363dd3 > > Diff: https://git.reviewboard.kde.org/r/129288/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129288: Fix unused computation result warning in plucker
> On Nov. 19, 2016, 12:50 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > Which code are you working against? I fixed this in July. > > > > For reference, this code is almost verbatim from the explode tool in the > > original plucker source. The font variable is used to track whether to > > start or end a formatted string span (represented by tags in the > > explode tool). https://cgit.kde.org/okular.git/commit/?id=d9a31fa02ad92c663b3c5bd0fc5be38b09bc761f for more reference. - Martin Tobias Holmedahl --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129288/#review100941 --- On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129288/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > If we assume that the code was correct, then the pointer dereference is > unnecessary. If we assume that the code was wrong, then it probably wanted to > do (*font)--. I assumed the former, but I can't test it. > > > Diffs > - > > generators/plucker/unpluck/qunpluck.cpp 8363dd3 > > Diff: https://git.reviewboard.kde.org/r/129288/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
[okular] [Bug 159007] Personal gallery od stamps
https://bugs.kde.org/show_bug.cgi?id=159007 Robert Cabane changed: What|Removed |Added CC||rcab...@free.fr --- Comment #9 from Robert Cabane --- (In reply to kdebug from comment #8) > There is a way now to add a custom image (svg, png) to a stamp (description > here -> http://wiki.ubuntuusers.de/Okular) > With "Save as.." it is even possible to write annotations down to the > PDF-file. > > Unfortunately, those notifications are not shown by common PDF Viewers > (Adobe Reader, PDF-Master,...) Neither it is possible to print them to a new > PDf File (which seems to work just for text-annotations) I agree. Just the same with Okular 0.24 (under OpenSuSE) : the stamp is really included in the exported PDF file (whose size grows), but in a special manner, which isn't compatible with Adobe Reader. Hopefully one will find how to fix that ... -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 363298] Allow users to define custom stamp to use with the review functions.
https://bugs.kde.org/show_bug.cgi?id=363298 --- Comment #4 from Robert Cabane --- As of Okular 0.24, it's really possible to create personal stamps, see here : https://wiki.ubuntuusers.de/Okular/ However, the exported PDF file doesn't show the personal stamps with any other viewer as Okular (tested with Evince and the pdf viewers included in FireFox or Chrome). -- You are receiving this mail because: You are the assignee for the bug.
