[GH] (pekko): Workflow run "Link Validator" failed!
The GitHub Actions job "Link Validator" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 9844a1befaad5d9396ed43fb80e9e81a97cede94 / He-Pin(kerr) chore: bump Scala to 2.13.16 (#1704) Report URL: https://github.com/apache/pekko/actions/runs/12721792649 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Publish nightly snapshots and documentation" failed!
The GitHub Actions job "Publish nightly snapshots and documentation" on pekko.git has failed. Run started by GitHub user seglo (triggered by seglo). Head commit for run: 9844a1befaad5d9396ed43fb80e9e81a97cede94 / He-Pin(kerr) chore: bump Scala to 2.13.16 (#1704) Report URL: https://github.com/apache/pekko/actions/runs/12719331274 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-connectors): Workflow run "CI" failed!
The GitHub Actions job "CI" on pekko-connectors.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: d6749177e626d14a821d1ef772b6defe16cda06e / PJ Fanning increase build memory Report URL: https://github.com/apache/pekko-connectors/actions/runs/12718676585 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-dynamodb): Workflow run "Publish nightly artifacts" failed!
The GitHub Actions job "Publish nightly artifacts" on pekko-persistence-dynamodb.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 782ceb3645dee37d9d28a5f5735bc2d1cefc7f22 / PJ Fanning Update PekkoCoreDependency.scala (#193) Report URL: https://github.com/apache/pekko-persistence-dynamodb/actions/runs/12719126724 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-management): Workflow run "Nightly Tests" is working again!
The GitHub Actions job "Nightly Tests" on pekko-management.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: b5af2563d1f312e25ebe8ab04c41e3c0b130ccb2 / PJ Fanning pekko 1.1.3 (#374) Report URL: https://github.com/apache/pekko-management/actions/runs/12720353216 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-connectors-kafka): Workflow run "Nightly Build and Test" failed!
The GitHub Actions job "Nightly Build and Test" on pekko-connectors-kafka.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 85a0ee74c478b0c72314d5b17dcde1f969458e8c / PJ Fanning pekko 1.1.3 (#272) Report URL: https://github.com/apache/pekko-connectors-kafka/actions/runs/12720322230 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Nightly Builds" failed!
The GitHub Actions job "Nightly Builds" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 9844a1befaad5d9396ed43fb80e9e81a97cede94 / He-Pin(kerr) chore: bump Scala to 2.13.16 (#1704) Report URL: https://github.com/apache/pekko/actions/runs/12719287936 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-http): Workflow run "Nightly Builds" failed!
The GitHub Actions job "Nightly Builds" on pekko-http.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 7edc11ca40fd76d17df73c43600059cb6a8b2398 / PJ Fanning build with pekko 1.1.3 (#649) * test with pekko 1.1.3 (RC1) * chore: Update pekko to 1.1.3 * Update build.sbt - Co-authored-by: He-Pin(kerr) Report URL: https://github.com/apache/pekko-http/actions/runs/12720141695 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko 1.1.3 [pekko-persistence-jdbc]
raboof merged PR #257: URL: https://github.com/apache/pekko-persistence-jdbc/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko 1.1.3 [pekko-grpc]
raboof merged PR #425: URL: https://github.com/apache/pekko-grpc/pull/425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko 1.1.3 [pekko-persistence-r2dbc]
raboof merged PR #187: URL: https://github.com/apache/pekko-persistence-r2dbc/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
He-Pin closed pull request #1698: perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) URL: https://github.com/apache/pekko/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
He-Pin commented on PR #1698: URL: https://github.com/apache/pekko/pull/1698#issuecomment-2582244196 OK, that seems fine now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
He-Pin opened a new pull request, #1698: URL: https://github.com/apache/pekko/pull/1698 (cherry picked from commit 03712a927e67723e9ffeadaa0b774dae45cbea88) For Better performance. refs: https://github.com/apache/flink/pull/25866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
He-Pin commented on PR #1698: URL: https://github.com/apache/pekko/pull/1698#issuecomment-2582200932 We will not have 1.2.x any soon I think, it doesn't harm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
pjfanning commented on PR #1698: URL: https://github.com/apache/pekko/pull/1698#issuecomment-2582207340 We have already discussed doing a 1.2.0-M1 in the next few weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: Require breadth >= 1 in FlattenMerge [pekko]
He-Pin opened a new pull request, #1699: URL: https://github.com/apache/pekko/pull/1699 Motivation: Check `breadth` >= 1 in FlattenMerge Modification: Add a requirement for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
He-Pin opened a new pull request, #1700: URL: https://github.com/apache/pekko/pull/1700 Motivation: require parallelism >= 1 in MapAsync and MapAsyncUnordered Modification: Add requirements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require breadth >= 1 in FlattenMerge [pekko]
He-Pin merged PR #1699: URL: https://github.com/apache/pekko/pull/1699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-r2dbc): Workflow run "Publish Nightly" is working again!
The GitHub Actions job "Publish Nightly" on pekko-persistence-r2dbc.git has succeeded. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: b49048b8d512566b0bfca66e05922a359510c96d / PJ Fanning pekko 1.1.3 (#187) Report URL: https://github.com/apache/pekko-persistence-r2dbc/actions/runs/12719413115 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require breadth >= 1 in FlattenMerge [pekko]
He-Pin commented on PR #1699: URL: https://github.com/apache/pekko/pull/1699#issuecomment-2582500213 @pjfanning This is extract of a pending PR, I can't keep 100% code coverage at $Work too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
He-Pin commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582503217 @pjfanning The code is the same as it is in `MapAsyncPartitioned` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require breadth >= 1 in FlattenMerge [pekko]
pjfanning commented on PR #1699: URL: https://github.com/apache/pekko/pull/1699#issuecomment-2582479866 * is it really possible to end up in a position where the requirement fails? * if so, can we add a test? * also, what would users of older versions see in this case? an exception, a nonsensical result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin opened a new pull request, #1701: URL: https://github.com/apache/pekko/pull/1701 Motivation: Add helper method to extract the value presented graph which will enable future optimization. Modification: Add TraversalBuilder.getValuePresentedSource method Result: TraversalBuilder.getValuePresentedSource internal method added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910312521
##
stream/src/main/scala/org/apache/pekko/stream/impl/JavaStreamSource.scala:
##
@@ -23,7 +23,7 @@ import java.util.function.Consumer
/** INTERNAL API */
@InternalApi private[stream] final class JavaStreamSource[T, S <:
java.util.stream.BaseStream[T, S]](
-open: () => java.util.stream.BaseStream[T, S])
+val open: () => java.util.stream.BaseStream[T, S])
Review Comment:
needed for optimization.
##
stream/src/main/scala/org/apache/pekko/stream/impl/FailedSource.scala:
##
@@ -22,7 +22,7 @@ import pekko.stream.stage.{ GraphStage, GraphStageLogic,
OutHandler }
/**
* INTERNAL API
*/
-@InternalApi private[pekko] final class FailedSource[T](failure: Throwable)
extends GraphStage[SourceShape[T]] {
+@InternalApi private[pekko] final class FailedSource[T](val failure:
Throwable) extends GraphStage[SourceShape[T]] {
Review Comment:
needed for optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Scalafmt" failed!
The GitHub Actions job "Scalafmt" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 684155c5f492fc8560387c9e597548fda54fc395 / He-Pin feat: Add TraversalBuilder.getValuePresentedSource method for further optimization. Report URL: https://github.com/apache/pekko/actions/runs/12709508615 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2582790700 I hate 2.12.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
pjfanning commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582479338 * is it really possible to end up in a position where the requirement fails? * if so, can we add a test? * also, what would users of older versions see in this case? an exception, a nonsensical result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Scalafmt" is working again!
The GitHub Actions job "Scalafmt" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 07358936d8cf49dc66739218175e89412636feed / He-Pin feat: Add TraversalBuilder.getValuePresentedSource method for further optimization. Report URL: https://github.com/apache/pekko/actions/runs/12709538732 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Enable deserialization of old Akka cluster messages (mixed pekko/akka cluster) [pekko]
pjfanning commented on PR #1578: URL: https://github.com/apache/pekko/pull/1578#issuecomment-2582603562 I would prefer not to use this because I think trying to support Akka before v2.6.5 almost certainly will lead to us having to add extra fixes. One that I suspect that we'd need is that we might need to also allow Pekko nodes to optionally send cluster messages that look like the old Akka format and this PR does not address that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 684155c5f492fc8560387c9e597548fda54fc395 / He-Pin feat: Add TraversalBuilder.getValuePresentedSource method for further optimization. Report URL: https://github.com/apache/pekko/actions/runs/12709508610 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
pjfanning commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910318273
##
stream/src/main/scala/org/apache/pekko/stream/impl/TraversalBuilder.scala:
##
@@ -380,12 +380,53 @@ import pekko.util.unused
}
}
+ /**
+ * Try to find `SingleSource` or wrapped such. This is used as a
+ * performance optimization in FlattenConcat and possibly other places.
+ * @since 1.2.0
+ */
+ @InternalApi def getValuePresentedSource[A >: Null](
+ graph: Graph[SourceShape[A], _]): OptionVal[Graph[SourceShape[A], _]] = {
+def isValuePresentedSource(graph: Graph[SourceShape[_ <: A], _]): Boolean
= graph match {
+ case _: SingleSource[_] | _: FutureSource[_] | _: IterableSource[_] | _:
JavaStreamSource[_, _] |
+ _: FailedSource[_] =>
+true
+ case maybeEmpty if isEmptySource(maybeEmpty) => true
+ case _ => false
+}
+graph match {
+ case _ if isValuePresentedSource(graph) => OptionVal.Some(graph)
+ case _ =>
+graph.traversalBuilder match {
+ case l: LinearTraversalBuilder =>
+l.pendingBuilder match {
+ case OptionVal.Some(a: AtomicTraversalBuilder) =>
+a.module match {
+ case m: GraphStageModule[_, _] =>
+m.stage match {
+ case _ if
isValuePresentedSource(m.stage.asInstanceOf[Graph[SourceShape[A], _]]) =>
+// It would be != EmptyTraversal if
mapMaterializedValue was used and then we can't optimize.
+if ((l.traversalSoFar eq EmptyTraversal) &&
!l.attributes.isAsync)
+
OptionVal.Some(m.stage.asInstanceOf[Graph[SourceShape[A], _]])
+else OptionVal.None
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+}
+ }
+
/**
* Test if a Graph is an empty Source.
*/
def isEmptySource(graph: Graph[SourceShape[_], _]): Boolean = graph match {
case source: scaladsl.Source[_, _] if source eq scaladsl.Source.empty =>
true
case source: javadsl.Source[_, _] if source eq javadsl.Source.empty() =>
true
+case EmptySource =>
true
Review Comment:
this doesn't look related to this change - is this a bug that needs to be
fixed in its own PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Enable deserialization of old Akka cluster messages (mixed pekko/akka cluster) [pekko]
raboof commented on PR #1578: URL: https://github.com/apache/pekko/pull/1578#issuecomment-2582606926 > I would prefer not to use this because I think trying to support Akka before v2.6.5 almost certainly will lead to us having to add extra fixes. Sounds reasonable to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 07358936d8cf49dc66739218175e89412636feed / He-Pin feat: Add TraversalBuilder.getValuePresentedSource method for further optimization. Report URL: https://github.com/apache/pekko/actions/runs/12709538748 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910320234
##
stream/src/main/scala/org/apache/pekko/stream/impl/TraversalBuilder.scala:
##
@@ -380,12 +380,53 @@ import pekko.util.unused
}
}
+ /**
+ * Try to find `SingleSource` or wrapped such. This is used as a
+ * performance optimization in FlattenConcat and possibly other places.
+ * @since 1.2.0
+ */
+ @InternalApi def getValuePresentedSource[A >: Null](
+ graph: Graph[SourceShape[A], _]): OptionVal[Graph[SourceShape[A], _]] = {
+def isValuePresentedSource(graph: Graph[SourceShape[_ <: A], _]): Boolean
= graph match {
+ case _: SingleSource[_] | _: FutureSource[_] | _: IterableSource[_] | _:
JavaStreamSource[_, _] |
+ _: FailedSource[_] =>
+true
+ case maybeEmpty if isEmptySource(maybeEmpty) => true
+ case _ => false
+}
+graph match {
+ case _ if isValuePresentedSource(graph) => OptionVal.Some(graph)
+ case _ =>
+graph.traversalBuilder match {
+ case l: LinearTraversalBuilder =>
+l.pendingBuilder match {
+ case OptionVal.Some(a: AtomicTraversalBuilder) =>
+a.module match {
+ case m: GraphStageModule[_, _] =>
+m.stage match {
+ case _ if
isValuePresentedSource(m.stage.asInstanceOf[Graph[SourceShape[A], _]]) =>
+// It would be != EmptyTraversal if
mapMaterializedValue was used and then we can't optimize.
+if ((l.traversalSoFar eq EmptyTraversal) &&
!l.attributes.isAsync)
+
OptionVal.Some(m.stage.asInstanceOf[Graph[SourceShape[A], _]])
+else OptionVal.None
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+}
+ }
+
/**
* Test if a Graph is an empty Source.
*/
def isEmptySource(graph: Graph[SourceShape[_], _]): Boolean = graph match {
case source: scaladsl.Source[_, _] if source eq scaladsl.Source.empty =>
true
case source: javadsl.Source[_, _] if source eq javadsl.Source.empty() =>
true
+case EmptySource =>
true
Review Comment:
It's not a bug, just a missing optimization case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910319857
##
stream-tests/src/test/scala/org/apache/pekko/stream/impl/TraversalBuilderSpec.scala:
##
@@ -447,4 +452,93 @@ class TraversalBuilderSpec extends PekkoSpec {
}
}
+ "find Source.single via TraversalBuilder" in {
+TraversalBuilder.getSingleSource(Source.single("a")).get.elem should
===("a")
+TraversalBuilder.getSingleSource(Source(List("a", "b"))) should
be(OptionVal.None)
+
+val singleSourceA = new SingleSource("a")
+TraversalBuilder.getSingleSource(singleSourceA) should
be(OptionVal.Some(singleSourceA))
+
+TraversalBuilder.getSingleSource(Source.single("c").async) should
be(OptionVal.None)
+TraversalBuilder.getSingleSource(Source.single("d").mapMaterializedValue(_
=> "Mat")) should be(OptionVal.None)
+ }
+
+ "find Source.single via TraversalBuilder with getValuePresentedSource" in {
+
TraversalBuilder.getValuePresentedSource(Source.single("a")).get.asInstanceOf[SingleSource[String]].elem
should ===(
+ "a")
+val singleSourceA = new SingleSource("a")
+TraversalBuilder.getValuePresentedSource(singleSourceA) should
be(OptionVal.Some(singleSourceA))
+
+TraversalBuilder.getValuePresentedSource(Source.single("c").async) should
be(OptionVal.None)
+
TraversalBuilder.getValuePresentedSource(Source.single("d").mapMaterializedValue(_
=> "Mat")) should be(
+ OptionVal.None)
+ }
+
+ "find Source.empty via TraversalBuilder with getValuePresentedSource" in {
+val emptySource = EmptySource
Review Comment:
@pjfanning the tests coverage is here for the `EmptySource`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
pjfanning commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582612861 > @pjfanning The code is the same as it is in `MapAsyncPartitioned` this is still a change that reduces performance by adding a check that needs evaluation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
pjfanning commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910323719
##
stream/src/main/scala/org/apache/pekko/stream/impl/TraversalBuilder.scala:
##
@@ -380,12 +380,53 @@ import pekko.util.unused
}
}
+ /**
+ * Try to find `SingleSource` or wrapped such. This is used as a
+ * performance optimization in FlattenConcat and possibly other places.
+ * @since 1.2.0
+ */
+ @InternalApi def getValuePresentedSource[A >: Null](
+ graph: Graph[SourceShape[A], _]): OptionVal[Graph[SourceShape[A], _]] = {
+def isValuePresentedSource(graph: Graph[SourceShape[_ <: A], _]): Boolean
= graph match {
+ case _: SingleSource[_] | _: FutureSource[_] | _: IterableSource[_] | _:
JavaStreamSource[_, _] |
+ _: FailedSource[_] =>
+true
+ case maybeEmpty if isEmptySource(maybeEmpty) => true
+ case _ => false
+}
+graph match {
+ case _ if isValuePresentedSource(graph) => OptionVal.Some(graph)
+ case _ =>
+graph.traversalBuilder match {
+ case l: LinearTraversalBuilder =>
+l.pendingBuilder match {
+ case OptionVal.Some(a: AtomicTraversalBuilder) =>
+a.module match {
+ case m: GraphStageModule[_, _] =>
+m.stage match {
+ case _ if
isValuePresentedSource(m.stage.asInstanceOf[Graph[SourceShape[A], _]]) =>
+// It would be != EmptyTraversal if
mapMaterializedValue was used and then we can't optimize.
+if ((l.traversalSoFar eq EmptyTraversal) &&
!l.attributes.isAsync)
+
OptionVal.Some(m.stage.asInstanceOf[Graph[SourceShape[A], _]])
+else OptionVal.None
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+}
+ }
+
/**
* Test if a Graph is an empty Source.
*/
def isEmptySource(graph: Graph[SourceShape[_], _]): Boolean = graph match {
case source: scaladsl.Source[_, _] if source eq scaladsl.Source.empty =>
true
case source: javadsl.Source[_, _] if source eq javadsl.Source.empty() =>
true
+case EmptySource =>
true
Review Comment:
I thought that the cases were evaluated in order so this would not change
performance in that case and it would actually lead to a different result if
EmptySource was matched but that neither of the first 2 cases matched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require breadth >= 1 in FlattenMerge [pekko]
raboof commented on PR #1699: URL: https://github.com/apache/pekko/pull/1699#issuecomment-2582618845 I think checks like this are helpful because they make it easier to read the implementation of `FlattenMerge` and be confident you don't need to consider the case where breadth < 1 > * is it really possible to end up in a position where the requirement fails? That's indeed not super obvious, but I suspect it can when the user chooses a <1 parallelism somewhere. > * if so, can we add a test? I guess so, though I'm not sure it's worth it to test error checking so explicitly > * also, what would users of older versions see in this case? an exception, a nonsensical result? I suspect they'd see a flow which stalls (fails to pull) after accepting its first element. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910326290
##
stream/src/main/scala/org/apache/pekko/stream/impl/TraversalBuilder.scala:
##
@@ -380,12 +380,53 @@ import pekko.util.unused
}
}
+ /**
+ * Try to find `SingleSource` or wrapped such. This is used as a
+ * performance optimization in FlattenConcat and possibly other places.
+ * @since 1.2.0
+ */
+ @InternalApi def getValuePresentedSource[A >: Null](
+ graph: Graph[SourceShape[A], _]): OptionVal[Graph[SourceShape[A], _]] = {
+def isValuePresentedSource(graph: Graph[SourceShape[_ <: A], _]): Boolean
= graph match {
+ case _: SingleSource[_] | _: FutureSource[_] | _: IterableSource[_] | _:
JavaStreamSource[_, _] |
+ _: FailedSource[_] =>
+true
+ case maybeEmpty if isEmptySource(maybeEmpty) => true
+ case _ => false
+}
+graph match {
+ case _ if isValuePresentedSource(graph) => OptionVal.Some(graph)
+ case _ =>
+graph.traversalBuilder match {
+ case l: LinearTraversalBuilder =>
+l.pendingBuilder match {
+ case OptionVal.Some(a: AtomicTraversalBuilder) =>
+a.module match {
+ case m: GraphStageModule[_, _] =>
+m.stage match {
+ case _ if
isValuePresentedSource(m.stage.asInstanceOf[Graph[SourceShape[A], _]]) =>
+// It would be != EmptyTraversal if
mapMaterializedValue was used and then we can't optimize.
+if ((l.traversalSoFar eq EmptyTraversal) &&
!l.attributes.isAsync)
+
OptionVal.Some(m.stage.asInstanceOf[Graph[SourceShape[A], _]])
+else OptionVal.None
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+ case _ => OptionVal.None
+}
+}
+ }
+
/**
* Test if a Graph is an empty Source.
*/
def isEmptySource(graph: Graph[SourceShape[_], _]): Boolean = graph match {
case source: scaladsl.Source[_, _] if source eq scaladsl.Source.empty =>
true
case source: javadsl.Source[_, _] if source eq javadsl.Source.empty() =>
true
+case EmptySource =>
true
Review Comment:
these methods are internal methods acutually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko 1.1.3 [pekko-connectors-kafka]
raboof merged PR #272: URL: https://github.com/apache/pekko-connectors-kafka/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] pekko 1.1.3 [pekko-management]
raboof merged PR #374: URL: https://github.com/apache/pekko-management/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
He-Pin merged PR #1700: URL: https://github.com/apache/pekko/pull/1700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered [pekko]
He-Pin commented on PR #1700: URL: https://github.com/apache/pekko/pull/1700#issuecomment-2582697165 @pjfanning Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" failed!
The GitHub Actions job "Binary Compatibility" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 251171e1d525b78be3e7adeaee297ea989377f09 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710254654 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" is working again!
The GitHub Actions job "Generate doc check" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 4b92618f4cd10a261234f509b27073f8c9491441 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12711037406 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 251171e1d525b78be3e7adeaee297ea989377f09 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710254643 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Add flatmapConcat with parallelism support [pekko]
He-Pin opened a new pull request, #1702: URL: https://github.com/apache/pekko/pull/1702 Motivation: Add support for https://github.com/apache/pekko/issues/1672 Based on: https://github.com/apache/pekko/pull/1701 Modification: 1. Add flatmapConcat with parallelism 2. add optimization to avoid materialization at the same time. Result: 1. flatmapConcat with parallelism supported Benchmark: Update later, benchmark update in later commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 5c723a0b454d73a1ac43956be32f151e09472693 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710365430 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" failed!
The GitHub Actions job "Binary Compatibility" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 5c723a0b454d73a1ac43956be32f151e09472693 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710365419 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Pull Requests" failed!
The GitHub Actions job "Pull Requests" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 5c723a0b454d73a1ac43956be32f151e09472693 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710365415 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 77ac9a1bb876e811e7825c958bf3a3ecfe4ac5ae / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710508604 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" failed!
The GitHub Actions job "Binary Compatibility" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 77ac9a1bb876e811e7825c958bf3a3ecfe4ac5ae / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710508589 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" failed!
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 77ac9a1bb876e811e7825c958bf3a3ecfe4ac5ae / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710508598 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add TraversalBuilder.getValuePresentedSource method for further optimization [pekko]
He-Pin commented on PR #1701: URL: https://github.com/apache/pekko/pull/1701#issuecomment-2582918165 After this pr get merged, we can do some optimization for `flatmapMerge` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" is working again!
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 4b92618f4cd10a261234f509b27073f8c9491441 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12711037399 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Enable deserialization of old Akka cluster messages (mixed pekko/akka cluster) [pekko]
raboof commented on PR #1578: URL: https://github.com/apache/pekko/pull/1578#issuecomment-2582581857 Does that mean we can close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" is working again!
The GitHub Actions job "Generate doc check" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 5ee21b8a752d565e961cddef9ae2eb148a459960 / He-Pin feat: Add TraversalBuilder.getValuePresentedSource method for further optimization. Report URL: https://github.com/apache/pekko/actions/runs/12709669683 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Pull Requests" is working again!
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 77ac9a1bb876e811e7825c958bf3a3ecfe4ac5ae / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12710508578 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" is working again!
The GitHub Actions job "Binary Compatibility" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 4b92618f4cd10a261234f509b27073f8c9491441 / He-Pin feat: Add flatMapConcat with parallelism support. Report URL: https://github.com/apache/pekko/actions/runs/12711037395 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]
jrudolph commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2582998628 I wonder if it is really necessary, wouldn't it be easier to just prematerialize to get the same effect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] feat: Add flatmapConcat with parallelism support [pekko]
He-Pin commented on PR #1702: URL: https://github.com/apache/pekko/pull/1702#issuecomment-2583027627 Yes, but I think it would be nice to have this out of box. otherwise will need a `mapAsync` and `prematerialize` and then `flatmapConcat`, and I think the current implementation will have better performance than that too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" is working again!
The GitHub Actions job "Binary Compatibility" on pekko.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: b160861c4186f73ef44de30f1f3b5a33c2c55562 / He-Pin(kerr) chore: Require parallelism >= 1 in MapAsync and MapAsyncUnordered (#1700) Report URL: https://github.com/apache/pekko/actions/runs/12710292214 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: bump Scala to 2.13.16 [pekko]
He-Pin opened a new pull request, #1704: URL: https://github.com/apache/pekko/pull/1704 Motivation: Bump Scala to 2.13.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] Update commons-codec to 1.17.2 [pekko]
scala-steward-asf[bot] opened a new pull request, #1703:
URL: https://github.com/apache/pekko/pull/1703
## About this PR
📦 Updates
[commons-codec:commons-codec](https://github.com/apache/commons-codec) from
`1.17.1` to `1.17.2`
## Usage
✅ **Please merge!**
I'll automatically update this PR to resolve conflicts as long as you don't
change it yourself.
If you'd like to skip this version, you can just close this PR. If you have
any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
[`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/8929fadb6f535472bd63397b1cb55a835fa1b5cb/docs/repo-specific-configuration.md)
file.
_Have a fantastic day writing Scala!_
âš™ Adjust future updates
Add this to your `.scala-steward.conf` file to ignore future updates of this
dependency:
```
updates.ignore = [ { groupId = "commons-codec", artifactId = "commons-codec"
} ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "commons-codec", artifactId = "commons-codec" }
}]
```
labels: test-library-update, early-semver-patch, semver-spec-patch,
commit-count:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] perf: optmize NettyChannelHandlerAdapter with explict extends. (#1667) [pekko]
pjfanning commented on PR #1698: URL: https://github.com/apache/pekko/pull/1698#issuecomment-2582146625 I don't think we should backport small perf changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: bump Scala to 2.13.16 [pekko]
pjfanning merged PR #1704: URL: https://github.com/apache/pekko/pull/1704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] Update commons-codec to 1.17.2 [pekko]
He-Pin merged PR #1703: URL: https://github.com/apache/pekko/pull/1703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
