He-Pin commented on code in PR #1701:
URL: https://github.com/apache/pekko/pull/1701#discussion_r1910312521
##########
stream/src/main/scala/org/apache/pekko/stream/impl/JavaStreamSource.scala:
##########
@@ -23,7 +23,7 @@ import java.util.function.Consumer
/** INTERNAL API */
@InternalApi private[stream] final class JavaStreamSource[T, S <:
java.util.stream.BaseStream[T, S]](
- open: () => java.util.stream.BaseStream[T, S])
+ val open: () => java.util.stream.BaseStream[T, S])
Review Comment:
needed for optimization.
##########
stream/src/main/scala/org/apache/pekko/stream/impl/FailedSource.scala:
##########
@@ -22,7 +22,7 @@ import pekko.stream.stage.{ GraphStage, GraphStageLogic,
OutHandler }
/**
* INTERNAL API
*/
-@InternalApi private[pekko] final class FailedSource[T](failure: Throwable)
extends GraphStage[SourceShape[T]] {
+@InternalApi private[pekko] final class FailedSource[T](val failure:
Throwable) extends GraphStage[SourceShape[T]] {
Review Comment:
needed for optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
