[GH] (pekko): Workflow run "Link Validator" is working again!
The GitHub Actions job "Link Validator" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 2b6d2dc0a0f2cc98b9ec59212880ceb6f6da015f / PJ Fanning missing header (#1665) Report URL: https://github.com/apache/pekko/actions/runs/12593531928 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568745107 @pjfanning I have attached the result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-http): Workflow run "Nightly Builds" is working again!
The GitHub Actions job "Nightly Builds" on pekko-http.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 6df0cbd7c50d8a30ac5e79139b195e2c60e4974c / PJ Fanning add source headers to CI files (#645) Report URL: https://github.com/apache/pekko-http/actions/runs/12591547713 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-grpc): Workflow run "Nightly Snapshot Dependency Test" is working again!
The GitHub Actions job "Nightly Snapshot Dependency Test" on pekko-grpc.git has succeeded. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 3682fa01d64a4c4b65276df0bec89841c66c445f / PJ Fanning CI: add source headers (#422) Report URL: https://github.com/apache/pekko-grpc/actions/runs/12591756413 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-management): Workflow run "Nightly Tests" failed!
The GitHub Actions job "Nightly Tests" on pekko-management.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: d86e9f551ca19961a9d23905005bb4c8a608f356 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update sbt, scripted-plugin to 1.10.7 (#369) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko-management/actions/runs/12591781784 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on code in PR #1666:
URL: https://github.com/apache/pekko/pull/1666#discussion_r1901499742
##
actor/src/main/scala/org/apache/pekko/util/Helpers.scala:
##
@@ -195,4 +199,19 @@ object Helpers {
Duration(config.getDuration(path, unit), unit)
}
+ /**
+ * INTERNAL API
+ */
+ private[pekko] final implicit class FutureOps[T](val future: Future[T])
extends AnyVal {
+
+/**
+ * Wait for the future to complete and return the result, or throw an
exception if the future failed.
+ * Optimize for the case when the future is already completed.
+ * @since 1.2.0
+ */
+def await(atMost: Duration = Duration.Inf): T = future.value match {
+ case Some(value) => value.get
+ case None=> blocking(future.result(atMost)(null))
Review Comment:
```scala
@throws(classOf[TimeoutException])
@throws(classOf[InterruptedException])
final def resultOption[T](awaitable: Awaitable[T], atMost: Duration): T
= awaitable match {
case CompletedFuture(v) => v.get
case _ => blocking(awaitable.result(atMost)(AwaitPermission))
}
private final object CompletedFuture {
def unapply[T](f: Future[T]): Option[Try[T]] = f.value
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-projection): Workflow run "Publish Nightly" failed!
The GitHub Actions job "Publish Nightly" on pekko-projection.git has failed. Run started by GitHub user mdedetrich (triggered by mdedetrich). Head commit for run: b9061628e91cea546f4918a36ce3a3ef5b9f6f95 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update sbt, scripted-plugin to 1.10.7 (#236) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko-projection/actions/runs/12590811321 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-jdbc): Workflow run "Publish 1.0 Nightly" failed!
The GitHub Actions job "Publish 1.0 Nightly" on pekko-persistence-jdbc.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 458fa081a72a8fda5096f7c787fdd3277ca0c4a6 / PJ Fanning add 2025 to copyright (#254) Report URL: https://github.com/apache/pekko-persistence-jdbc/actions/runs/12590812893 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-dynamodb): Workflow run "Publish nightly artifacts" is working again!
The GitHub Actions job "Publish nightly artifacts" on pekko-persistence-dynamodb.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 0151dbb47fc3b3f0f12407a21ea56f9c68e37e13 / PJ Fanning remove CMSClassUnloadingEnabled from .jvmopts (#191) Report URL: https://github.com/apache/pekko-persistence-dynamodb/actions/runs/12590496406 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] add source headers to CI files [pekko-http]
pjfanning opened a new pull request, #645: URL: https://github.com/apache/pekko-http/pull/645 header depends on if the yml was added first for Pekko or if it is based on one that we inherited from Akka code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Pull Requests" is working again!
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: b17140a9657c0b640c8d8c905e43f1a580c31f46 / PJ Fanning reimplement fix for akka/pekko cluster (#1594) * Revert "revert #1568 due to test failures (#1587)" This reverts commit 7af03e5215dc69df9702803dba7f22d94b49ead4. * temp run nightly test in this PR * no need for square brackets because the set print adds them * logging to find issue * support tcp protocols * Update ClusterDaemon.scala * remove temp logging * try to fix issue in Remoting * extra tests * more tests * ignore udp tests * try to make tests tidy up after failures * Update MixedProtocolClusterSpec.scala * Update MixedProtocolClusterSpec.scala * run main cluster tests for PR Report URL: https://github.com/apache/pekko/actions/runs/12581501469 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [EXPERIMENT] stub test for harmless=true [pekko]
raboof commented on code in PR #1555:
URL: https://github.com/apache/pekko/pull/1555#discussion_r1900925191
##
remote/src/main/mima-filters/1.1.x.backwards.excludes/quarantine.backwards.excludes:
##
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# changes made due to issues with downing during harmless quarantine
+# https://github.com/apache/pekko/issues/578
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.remote.artery.AssociationState#QuarantinedTimestamp.copy")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.remote.artery.AssociationState#QuarantinedTimestamp.this")
+ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.pekko.remote.artery.AssociationState#QuarantinedTimestamp.apply")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.remote.artery.AssociationState#QuarantinedTimestamp.unapply")
+ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.remote.artery.AssociationState$QuarantinedTimestamp$")
Review Comment:
This class is in `private[remote]` context, so indeed these changes are safe.
I think you could use a wildcard:
```
ProblemFilters.exclude[Problem]("org.apache.pekko.remote.artery.AssociationState#QuarantinedTimestamp*")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
pjfanning commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568771510 > @pjfanning I have attached the result I would still like this discussed with the Scala team to understand if the Await.result can be improved. Everyone benefits if you have discovered a perf issue there and that it then gets fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568782660 @pjfanning https://github.com/scala/scala/pull/10972 , submitted to scala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-http): Workflow run "Publish nightly 1.0 snapshots" failed!
The GitHub Actions job "Publish nightly 1.0 snapshots" on pekko-http.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 6df0cbd7c50d8a30ac5e79139b195e2c60e4974c / PJ Fanning add source headers to CI files (#645) Report URL: https://github.com/apache/pekko-http/actions/runs/12591529001 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-connectors): Workflow run "Nightly Pekko 1.0 Builds" failed!
The GitHub Actions job "Nightly Pekko 1.0 Builds" on pekko-connectors.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 711cabb5bc7309980703652d0415652d574ac265 / scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Update sbt, scripted-plugin to 1.10.7 (#933) Co-authored-by: scala-steward-asf[bot] <147768647+scala-steward-asf[bot]@users.noreply.github.com> Report URL: https://github.com/apache/pekko-connectors/actions/runs/12592093917 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-grpc): Workflow run "Publish Nightly" failed!
The GitHub Actions job "Publish Nightly" on pekko-grpc.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 3682fa01d64a4c4b65276df0bec89841c66c445f / PJ Fanning CI: add source headers (#422) Report URL: https://github.com/apache/pekko-grpc/actions/runs/12591771955 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add non-default config that allows InboundQuarantineCheck to ignore 'harmless' quarantine events [pekko]
pjfanning commented on PR #1555: URL: https://github.com/apache/pekko/pull/1555#issuecomment-2568283492 The tests seem to be working for me today. If reviewers are amenable, we could merge this to main and 1.1.x branches and document that the config exists to enable an experimental fix for #578. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-persistence-jdbc): Workflow run "Nightly Testing with Pekko 1.0" failed!
The GitHub Actions job "Nightly Testing with Pekko 1.0" on pekko-persistence-jdbc.git has failed. Run started by GitHub user raboof (triggered by raboof). Head commit for run: 458fa081a72a8fda5096f7c787fdd3277ca0c4a6 / PJ Fanning add 2025 to copyright (#254) Report URL: https://github.com/apache/pekko-persistence-jdbc/actions/runs/12592551721 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] reimplement fix for akka/pekko cluster (#1594) [pekko]
He-Pin commented on code in PR #1664: URL: https://github.com/apache/pekko/pull/1664#discussion_r1900780945 ## .github/workflows/build-test-prValidation.yml: ## @@ -101,6 +101,53 @@ jobs: -Dpekko.log.timestamps=true \ validatePullRequest + pekko-classic-remoting-tests: +name: Pekko Classic Remoting Tests +runs-on: ubuntu-22.04 +if: github.repository == 'apache/pekko' +strategy: + fail-fast: false + matrix: +command: + - cluster/test distributed-data/test cluster-tools/test cluster-metrics/test +steps: + - name: Checkout +uses: actions/checkout@v4 Review Comment: needs branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] reimplement fix for akka/pekko cluster (#1594) [pekko]
pjfanning commented on code in PR #1664: URL: https://github.com/apache/pekko/pull/1664#discussion_r1900785805 ## .github/workflows/build-test-prValidation.yml: ## @@ -101,6 +101,53 @@ jobs: -Dpekko.log.timestamps=true \ validatePullRequest + pekko-classic-remoting-tests: +name: Pekko Classic Remoting Tests +runs-on: ubuntu-22.04 +if: github.repository == 'apache/pekko' +strategy: + fail-fast: false + matrix: +command: + - cluster/test distributed-data/test cluster-tools/test cluster-metrics/test +steps: + - name: Checkout +uses: actions/checkout@v4 Review Comment: when the PR targets a branch, GitHub CI seems intelligent enough to checkout the PR branch Have a look at https://github.com/apache/pekko/blob/1.0.x/.github/workflows/build-test-prValidation.yml -- no refs for any checkouts. The nightly runs are different because we have the ymls in the main branch so if we want to test a branch, we need to adjust the checkouts in that case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature Request: Add Flow#concatAllDeferred operator. [pekko]
He-Pin commented on issue #1652: URL: https://github.com/apache/pekko/issues/1652#issuecomment-2567903565 @raboof wdyt about this, I think this is the only way for @queimadus 's user case, or we can add some documents about that. This method should be handy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] reimplement fix for akka/pekko cluster (#1594) [pekko]
pjfanning opened a new pull request, #1664: URL: https://github.com/apache/pekko/pull/1664 cherry pick ef212e9a98614ba13cd65cde3cd8140702f1f35b #1594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko-grpc): Workflow run "Validate and test" failed!
The GitHub Actions job "Validate and test" on pekko-grpc.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 3682fa01d64a4c4b65276df0bec89841c66c445f / PJ Fanning CI: add source headers (#422) Report URL: https://github.com/apache/pekko-grpc/actions/runs/12583862101 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] CI: add source headers [pekko-grpc]
pjfanning merged PR #422: URL: https://github.com/apache/pekko-grpc/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
pjfanning commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568185948 This code is internal. Does it matter if it is fluent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568189163 So does performance, I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [EXPERIMENT] stub test for harmless=true [pekko]
He-Pin commented on PR #1555: URL: https://github.com/apache/pekko/pull/1555#issuecomment-2568197786 A workmate told me this ,but as I am not using the cluster at work, so thanks for take care of this hard task. I knew a team is using akka/pekko cluster with a centralized nodes server, we called it vipserver, which will decided which nodes are on the same cluster as a single source of truth instead of this gossip thing, where a wrong message spreading the cluster can take the whole cluster down. Another reason I'm not using clustering at work is because the chaos monkey, where the sre team will schedule some randomly network partition, and I think that will always require a reboot by the application owner, I am a little lazy here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] add 2025 to copyright in NOTICE [pekko-samples]
pjfanning opened a new pull request, #124: URL: https://github.com/apache/pekko-samples/pull/124 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] missing header [pekko]
pjfanning opened a new pull request, #1665: URL: https://github.com/apache/pekko/pull/1665 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] CI: add source headers [pekko-grpc]
pjfanning opened a new pull request, #422: URL: https://github.com/apache/pekko-grpc/pull/422 header depends on whether the initial work is from Pekko times or if the yml is based on work that we inherited from Akka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" failed!
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has failed. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 1fccb6fd720bafd4bc67e44f9b7a0ce37e28b152 / PJ Fanning missing header Report URL: https://github.com/apache/pekko/actions/runs/12582806908 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] missing header [pekko]
pjfanning merged PR #1665: URL: https://github.com/apache/pekko/pull/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature Request: Add Flow#concatAllDeferred operator. [pekko]
He-Pin commented on issue #1652: URL: https://github.com/apache/pekko/issues/1652#issuecomment-2568075363 eg: the `concatAllLazy` will materialize all graphs before they are pulled and keep them in memory until the resulting graph completes, if you have large numbers of graphs that can not be what you want, try `concatAllDeferred`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] [EXPERIMENT] stub test for harmless=true [pekko]
pjfanning commented on PR #1555: URL: https://github.com/apache/pekko/pull/1555#issuecomment-2568088488 Thanks for the review. I was running the tests a few weeks ago and I'm not sure that they work. @fredfp tested this a few weeks ago and said it helped but I don't yet think this is ready - until the new tests are improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add source headers to CI files [pekko-http]
raboof commented on code in PR #645: URL: https://github.com/apache/pekko-http/pull/645#discussion_r1901088133 ## .github/workflows/dependency-graph.yml: ## @@ -12,6 +29,6 @@ jobs: - uses: actions/checkout@v4 - name: Install sbt uses: sbt/setup-sbt@v1 - - uses: scalacenter/sbt-dependency-submission@v2 + - uses: scalacenter/sbt-dependency-submission@v3 Review Comment: sneaky :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" is working again!
The GitHub Actions job "Binary Compatibility" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7c34c67678f0b1d18af1ddc25d35d87432ed1abb / PJ Fanning rework test Report URL: https://github.com/apache/pekko/actions/runs/12585973685 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Pull Requests" is working again!
The GitHub Actions job "Pull Requests" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7c34c67678f0b1d18af1ddc25d35d87432ed1abb / PJ Fanning rework test Report URL: https://github.com/apache/pekko/actions/runs/12585973679 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add 2025 to copyright in NOTICE [pekko-samples]
raboof merged PR #124: URL: https://github.com/apache/pekko-samples/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] add source headers to CI files [pekko-http]
raboof merged PR #645: URL: https://github.com/apache/pekko-http/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" is working again!
The GitHub Actions job "Generate doc check" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7c34c67678f0b1d18af1ddc25d35d87432ed1abb / PJ Fanning rework test Report URL: https://github.com/apache/pekko/actions/runs/12585973690 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Build and test Pekko with Scala 3" is working again!
The GitHub Actions job "Build and test Pekko with Scala 3" on pekko.git has succeeded. Run started by GitHub user pjfanning (triggered by pjfanning). Head commit for run: 7c34c67678f0b1d18af1ddc25d35d87432ed1abb / PJ Fanning rework test Report URL: https://github.com/apache/pekko/actions/runs/12585973688 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] fix: avoid call finalizeStage more times than once. (#1650) [pekko]
pjfanning commented on PR #1654: URL: https://github.com/apache/pekko/pull/1654#issuecomment-2567755344 My preference is not to backfit changes that are not definitely causing major issues. With the main branch, we could start doing milestone releases, eg 1.2.0-M1. We just need more people to get involved in voting on releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] fix: avoid call finalizeStage more times than once. (#1650) [pekko]
He-Pin commented on PR #1654: URL: https://github.com/apache/pekko/pull/1654#issuecomment-2567775095 let's keep this open to see if a user requests it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] fix: avoid call finalizeStage more times than once. [pekko]
He-Pin closed pull request #1649: fix: avoid call finalizeStage more times than once. URL: https://github.com/apache/pekko/pull/1649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature request: Add Flow#flattenConcat [pekko]
raboof commented on issue #1661: URL: https://github.com/apache/pekko/issues/1661#issuecomment-2568000848 hmm, we already have your #937 - how would this be different? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature Request: Add Flow#concatAllDeferred operator. [pekko]
raboof commented on issue #1652: URL: https://github.com/apache/pekko/issues/1652#issuecomment-2568016461 Hmm, this seems like quite a corner case. If you're using Streams like this, you'll have to be quite aware of those intricacies already. At that point perhaps it isn't too much to ask the user to combine `concatLazy`, ` lazySource` and `flatMapConcat` (would `flatten` work here?). Adding `concatAllDeferred` might make things shorter, but I'm not sure it'd make things easier to understand. What would the scaladoc say - can we give a clear description of in what kinds of situations you'd use this function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature request: Add Flow#flattenConcat [pekko]
He-Pin closed issue #1661: Feature request: Add Flow#flattenConcat URL: https://github.com/apache/pekko/issues/1661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] Feature request: Add Flow#flattenConcat [pekko]
He-Pin commented on issue #1661: URL: https://github.com/apache/pekko/issues/1661#issuecomment-2568021590 @raboof Wow, I forgot this, but I planed to add a flatmapConcat with a parallelism, let't me close this:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] reimplement fix for akka/pekko cluster (#1594) [pekko]
pjfanning merged PR #1664: URL: https://github.com/apache/pekko/pull/1664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] try to fix mixed akka/pekko issue again [pekko]
pjfanning closed issue #1590: try to fix mixed akka/pekko issue again URL: https://github.com/apache/pekko/issues/1590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [I] try to fix mixed akka/pekko issue again [pekko]
pjfanning commented on issue #1590: URL: https://github.com/apache/pekko/issues/1590#issuecomment-2567747160 #1664 has been merged to 1.1 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin opened a new pull request, #1666: URL: https://github.com/apache/pekko/pull/1666 Motivation: I found the `Await.result` is everywhere. Modification: Add an `await` operator to the future. Result: Fluent code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Generate doc check" failed!
The GitHub Actions job "Generate doc check" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 821ee1389539e0cb16f20a78434f73017cd66a14 / He-Pin chore: Add FutureOps which with an await style. Report URL: https://github.com/apache/pekko/actions/runs/12585735938 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Binary Compatibility" failed!
The GitHub Actions job "Binary Compatibility" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 821ee1389539e0cb16f20a78434f73017cd66a14 / He-Pin chore: Add FutureOps which with an await style. Report URL: https://github.com/apache/pekko/actions/runs/12585735910 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
[GH] (pekko): Workflow run "Pull Requests" failed!
The GitHub Actions job "Pull Requests" on pekko.git has failed. Run started by GitHub user He-Pin (triggered by He-Pin). Head commit for run: 821ee1389539e0cb16f20a78434f73017cd66a14 / He-Pin chore: Add FutureOps which with an await style. Report URL: https://github.com/apache/pekko/actions/runs/12585735912 With regards, GitHub Actions via GitBox - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
pjfanning commented on PR #1666:
URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568229564
If there is a perf issue in Await.result, I would prefer it was fixed in
Scala runtime.
The Scala 2 impl seems to try to optimise for the completed case.
```
final def result[T](awaitable: Awaitable[T], atMost: Duration): T =
awaitable match {
case f: Future[T] if f.isCompleted => f.result(atMost)(AwaitPermission)
case _ => blocking(awaitable.result(atMost)(AwaitPermission))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568237907 The code seems need more adjustment, as we don't need to test if it's a future anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin closed pull request #1666: chore: Add FutureOps which with an await style. URL: https://github.com/apache/pekko/pull/1666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on code in PR #1666:
URL: https://github.com/apache/pekko/pull/1666#discussion_r1901201350
##
actor/src/main/scala/org/apache/pekko/util/Helpers.scala:
##
@@ -195,4 +199,19 @@ object Helpers {
Duration(config.getDuration(path, unit), unit)
}
+ /**
+ * INTERNAL API
+ */
+ private[pekko] final implicit class FutureOps[T](val future: Future[T])
extends AnyVal {
+
+/**
+ * Wait for the future to complete and return the result, or throw an
exception if the future failed.
+ * Optimize for the case when the future is already completed.
+ * @since 1.2.0
+ */
+def await(atMost: Duration = Duration.Inf): T = future.value match {
+ case Some(value) => value.get
+ case None=> blocking(future.result(atMost)(null))
Review Comment:
avoid the double checking now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
Re: [PR] chore: Add FutureOps which with an await style. [pekko]
He-Pin commented on PR #1666: URL: https://github.com/apache/pekko/pull/1666#issuecomment-2568277526 ??? Why its closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org For additional commands, e-mail: notifications-h...@pekko.apache.org
