pjfanning commented on code in PR #1664:
URL: https://github.com/apache/pekko/pull/1664#discussion_r1900785805
##########
.github/workflows/build-test-prValidation.yml:
##########
@@ -101,6 +101,53 @@ jobs:
-Dpekko.log.timestamps=true \
validatePullRequest
+ pekko-classic-remoting-tests:
+ name: Pekko Classic Remoting Tests
+ runs-on: ubuntu-22.04
+ if: github.repository == 'apache/pekko'
+ strategy:
+ fail-fast: false
+ matrix:
+ command:
+ - cluster/test distributed-data/test cluster-tools/test
cluster-metrics/test
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v4
Review Comment:
when the PR targets a branch, GitHub CI seems intelligent enough to checkout
the PR branch
Have a look at
https://github.com/apache/pekko/blob/1.0.x/.github/workflows/build-test-prValidation.yml
-- no refs for any checkouts.
The nightly runs are different because we have the ymls in the main branch
so if we want to test a branch, we need to adjust the checkouts in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
