Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]
On Wed, 25 Sep 2024 18:28:02 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >> comment on the JBS issue for the reason why they were not included. > > Justin Lu has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains three additional commits since > the last revision: > > - update TEST.groups with DefaultTimeZoneTest.java removal > - Merge branch 'master' into JDK-8340326-tests-appletRemoval > - init Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to me. It's a manual test that involves underlying OS settings manipulation which cannot be automated. - PR Review: https://git.openjdk.org/jdk/pull/21096#pullrequestreview-2329580972
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v3]
On Wed, 25 Sep 2024 22:06:55 GMT, Justin Lu wrote: >> Please review this PR which removes usages of Applet within the corelibs >> tests. >> >> Most changes are removed comments/updated var names. The JBS issue lists >> more files than the ones included in this pull request, please see the >> comment on the JBS issue for the reason why they were not included. >> >> The following files were removed, >> >> - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html >> - Test runner is no longer an Applet, so not needed >> - test/jdk/sun/net/www/ParseUtil_6380332.java >> - Outdated test that checks a SunTea applet >> - test/jdk/java/net/Socket/SocketImplTest.java >> - An old Applet test missing Jtreg tags. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > restore DefaultTimeZoneTest.java as a manual test using PassFailJFrame test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 29: > 27: * @summary Ensure that Java detects the platform time zone correctly, > even > 28: * if changed during runtime. Also ensure that the system time zone > detection code > 29: * detects the "Automatically adjust clock for daylight saving changes" > setting Probably taking this opportunity, changing the wording/instructions aligned with "Settings app", instead of deprecated "Control Panel" would be good. - PR Review Comment: https://git.openjdk.org/jdk/pull/21096#discussion_r1776065785
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v3]
> Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment on > the JBS issue for the reason why they were not included. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: restore DefaultTimeZoneTest.java as a manual test using PassFailJFrame - Changes: - all: https://git.openjdk.org/jdk/pull/21096/files - new: https://git.openjdk.org/jdk/pull/21096/files/cc860712..6b2c060b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=01-02 Stats: 120 lines in 2 files changed: 119 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/21096.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21096/head:pull/21096 PR: https://git.openjdk.org/jdk/pull/21096
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]
On Wed, 25 Sep 2024 21:36:54 GMT, Naoto Sato wrote: > Removing `test/jdk/java/util/TimeZone/DefaultTimeZoneTest.*` looks good to > me. It's a manual test that involves underlying OS settings manipulation > which cannot be automated. As we previously spoke offline, I did not think there was much value in preserving the test. However, I realize it is a unique test that does validate that the runtime detects the "Automatically adjust clock for daylight saving changes" setting correctly on Windows. I preserved it and replaced the `Applet` overhead with `PassFailJFrame` in the most recent commit. Not sure if it will be ran by anyone as it is manual, but at least we can verify the setting if needed and the test history is preserved. - PR Comment: https://git.openjdk.org/jdk/pull/21096#issuecomment-2375345354
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]
On Wed, 25 Sep 2024 22:03:59 GMT, Justin Lu wrote: > Not sure if it will be ran by anyone as it is manual, I don't know about other vendors, but for Oracle, manual tests are run at least once on every release some time after RDP1 and before RDP2. - PR Comment: https://git.openjdk.org/jdk/pull/21096#issuecomment-2375365153
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v4]
> Please review this PR which removes usages of Applet within the corelibs > tests. > > Most changes are removed comments/updated var names. The JBS issue lists more > files than the ones included in this pull request, please see the comment on > the JBS issue for the reason why they were not included. > > The following files were removed, > > - test/jdk/java/util/TimeZone/DefaultTimeZoneTest.html > - Test runner is no longer an Applet, so not needed > - test/jdk/sun/net/www/ParseUtil_6380332.java > - Outdated test that checks a SunTea applet > - test/jdk/java/net/Socket/SocketImplTest.java > - An old Applet test missing Jtreg tags. Justin Lu has updated the pull request incrementally with one additional commit since the last revision: review: update wording of instructions - Changes: - all: https://git.openjdk.org/jdk/pull/21096/files - new: https://git.openjdk.org/jdk/pull/21096/files/6b2c060b..603e40fa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=02-03 Stats: 10 lines in 1 file changed: 0 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/21096.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21096/head:pull/21096 PR: https://git.openjdk.org/jdk/pull/21096
Re: RFR: 8340326: Remove references to Applet in core-libs/security tests [v2]
> Please review this PR which removes usages of Applet within the corelibs > tests. This includes both code usage as well as occurrences of the word. > > There were more files found than the ones included in this PR, please see the > comment on the JBS issue for the reason why they were not included. In > general, I removed the file if the entirety was focused on Applet, otherwise > I removed the portions applicable. Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - update TEST.groups with DefaultTimeZoneTest.java removal - Merge branch 'master' into JDK-8340326-tests-appletRemoval - init - Changes: - all: https://git.openjdk.org/jdk/pull/21096/files - new: https://git.openjdk.org/jdk/pull/21096/files/a50c1972..cc860712 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21096&range=00-01 Stats: 153402 lines in 749 files changed: 148791 ins; 1873 del; 2738 mod Patch: https://git.openjdk.org/jdk/pull/21096.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21096/head:pull/21096 PR: https://git.openjdk.org/jdk/pull/21096
