RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently
Hi All,
Please review the fix for JDK-8031661
http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/
Description:
Root Cause:
In line 195 and 196, the two actions can be ordered by a happens-before
relationship, which will cause synchronization fail.
t1cond1latch.countDown();
t1cond2latch.await();
Suggested Fixes:
Using only one CyclicBarrier ("t1Cond1") sync c1,c2 and main thread
Re:Re:RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently
Hi Michael,
Could you sponsor this for me?
Thanks,
Amanda
*发件人**:*Michael McMahon
*发送时间**:*Monday, February 10, 2014 6:13 PM
*收件人**:*net-dev@openjdk.java.net
*主题**:*Re: RFR for JDK-8031661 java/net/Authenticator/B4769350.java
failed intermittently
That seems reasonable Amanda. I've run the updated test for a while and
I can't see any problem with it.
Thanks,
Michael
On 10/02/14 08:56, Amanda Jiang wrote:
Hi All,
Please review the fix for JDK-8031661
http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/
<http://cr.openjdk.java.net/%7Etyan/amandaj/JDK-8031661/webrev.01/>
Description:
Root Cause:
In line 195 and 196, the two actions can be ordered by a
happens-before relationship, which will cause synchronization fail.
t1cond1latch.countDown();
t1cond2latch.await();
Suggested Fixes:
Using only one CyclicBarrier ("t1Cond1") sync c1,c2 and main thread
Re: RFR for JDK-8031661 java/net/Authenticator/B4769350.java failed intermittently
Hi Michael,
Could you sponsor this for me? Thanks a lot.
Amanda
On 2/10/14 4:10 PM, Amanda Jiang wrote:
> Hi Michael,
>
> Could you sponsor this for me?
>
> Thanks,
> Amanda
>
> *发件人**:*Michael McMahon
> *发送时间**:*Monday, February 10, 2014 6:13 PM
> *收件人**:*net-dev@openjdk.java.net
> *主题**:*Re: RFR for JDK-8031661 java/net/Authenticator/B4769350.java
> failed intermittently
>
> That seems reasonable Amanda. I've run the updated test for a while and
> I can't see any problem with it.
>
> Thanks,
> Michael
>
> On 10/02/14 08:56, Amanda Jiang wrote:
>
> Hi All,
>
> Please review the fix for JDK-8031661
>
> http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/
> <http://cr.openjdk.java.net/%7Etyan/amandaj/JDK-8031661/webrev.01/>
>
> Description:
> Root Cause:
> In line 195 and 196, the two actions can be ordered by a
> happens-before relationship, which will cause synchronization fail.
> t1cond1latch.countDown();
> t1cond2latch.await();
>
> Suggested Fixes:
> Using only one CyclicBarrier ("t1Cond1") sync c1,c2 and main thread
>
>
>
>
RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface
Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang/amanda/JDK-8038276/webrev.00/ Description of issue: Root Cause: Test java/net/NetworkInterface/Test.java failed because virtual interface "Teredo Tunneling Pseudo-Interface" on windows returned random addresses, we should not test on that interface. Suggested Fixes: Remove windows&&Teredo Interfaces from test.
Re: RFR for JDK-8038276 java/net/NetworkInterface/Test.java fails on windows intermittently for Teredo Interface
Please sponsor this change . Thank you, Chris. Amanda On 3/28/14 6:10 AM, Chris Hegarty wrote: Looks ok to me Amanda. I can sponsor this change, if needed. -Chris. On 28/03/14 05:07, Amanda Jiang wrote: Hi All , Please check and review following changes: http://cr.openjdk.java.net/~ewang/amanda/JDK-8038276/webrev.00/ Description of issue: Root Cause: Test java/net/NetworkInterface/Test.java failed because virtual interface "Teredo Tunneling Pseudo-Interface" on windows returned random addresses, we should not test on that interface. Suggested Fixes: Remove windows&&Teredo Interfaces from test.
RFR 8047031: Need new tests to check socket permission
Hi All, Could you please review 1 new test to be added for SocketPermission. New test is added to check socket permissions, for instance - - java.net.SocketPermission with "connect", "resolve", "accept", "listen" with Socket, DatagramSocket, MulticastSocket etc. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8047031 WebRev: http://cr.openjdk.java.net/~rhalade/8047031/webrev.00/ Thanks, Amanda
Re: RFR 8047031: Need new tests to check socket permission
Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Could you please help to review these tests? Thanks, Amanda On 7/28/14 5:25 PM, Amanda Jiang wrote: Hi All, Could you please review 1 new test to be added for SocketPermission. New test is added to check socket permissions, for instance - - java.net.SocketPermission with "connect", "resolve", "accept", "listen" with Socket, DatagramSocket, MulticastSocket etc. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8047031 WebRev: http://cr.openjdk.java.net/~rhalade/8047031/webrev.00/ Thanks, Amanda
Re: RFR 8047031: Need new tests to check socket permission
Hi Chris, Thanks for reviewing this test. I have upgraded the test by your suggestions, in the new version, free port is generated first then socket permission instances are created dynamically. Lambda and TestNG are also applied for simplifying tests and reducing redundant codes. Please check the webrev below: http://cr.openjdk.java.net/~tyan/amandaj/8047031/webrev00/ Thanks, Amanda On 8/27/14 10:45 AM, Chris Hegarty wrote: Amanda, I see you have implemented a getFreePort in this test, and it attempts to find a port within a range of 10 of the given port. I would have a concern about this when the test is run concurrently. Though we have come across similar issues in the past, as the socket permission needs to have a defined port range. I'm not sure if we ever came up with a good solution. Do you think it would be possible to get the free port first, and then create the socket permission instances dynamically accordingly? Or would this make the test very difficult to debug? -Chris. On 25/08/14 17:48, Amanda Jiang wrote: Hi Michael, Chris and others We’re working on moving our internal security tests to open idk repo(Include refactoring effort). Could you please help to review these tests? Thanks, Amanda On 7/28/14 5:25 PM, Amanda Jiang wrote: Hi All, Could you please review 1 new test to be added for SocketPermission. New test is added to check socket permissions, for instance - - java.net.SocketPermission with "connect", "resolve", "accept", "listen" with Socket, DatagramSocket, MulticastSocket etc. JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8047031 WebRev: http://cr.openjdk.java.net/~rhalade/8047031/webrev.00/ Thanks, Amanda
RFR 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
Hi, May I request your review for following changeset? There are 33 networking tests that have dependency on internal APIsun.net.www.MessageHeader and sun.net.www.HeaderParser This fix is to remove the internal API dependency from those tests. bug: https://bugs.openjdk.java.net/browse/JDK-8061729 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8061729/webrev.05/ Thanks, Amanda
RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency
Hi, May I request your review for following changeset? There is one networking tests that has dependency on internal API sun.net.www.ParseUtil. This fix is to remove the internal API dependency from that test. bug:https://bugs.openjdk.java.net/browse/JDK-8065420 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8065420/webrev.00/ Thanks, Amanda
Re: RFR 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
I have updated the fixes to reduce code duplication, please check the new webrev below: http://cr.openjdk.java.net/~tyan/amandaj/8061729/webrev/ Thanks, Amanda On 12/5/14 1:58 PM, Amanda Jiang wrote: Hi, May I request your review for following changeset? There are 33 networking tests that have dependency on internal APIsun.net.www.MessageHeader and sun.net.www.HeaderParser This fix is to remove the internal API dependency from those tests. bug:https://bugs.openjdk.java.net/browse/JDK-8061729 webrev:http://cr.openjdk.java.net/~tyan/amandaj/8061729/webrev.05/ Thanks, Amanda
Re: RFR 8065420: Update test java/net/ResponseCache/ResponseCacheTest.java to eliminate internal API dependency
Thank you Chris, could you please sponsor this? Thanks, Amanda On 12/18/14 4:18 AM, Chris Hegarty wrote: This looks ok to me Amanda. -Chris. On 17 Dec 2014, at 23:23, Amanda Jiang wrote: Hi, May I request your review for following changeset? There is one networking tests that has dependency on internal API sun.net.www.ParseUtil. This fix is to remove the internal API dependency from that test. bug:https://bugs.openjdk.java.net/browse/JDK-8065420 webrev: http://cr.openjdk.java.net/~tyan/amandaj/8065420/webrev.00/ Thanks, Amanda
