Ping: RFR(S): 8163181: Further improvements for Unix NetworkInterface native implementation

[Langer, Christoph]

Ping: Can I get a review for this small set of changes please?

Thanks
Christoph

From: Langer, Christoph
Sent: Donnerstag, 4. August 2016 15:04
To: net-dev@openjdk.java.net
Subject: RFR(S): 8163181: Further improvements for Unix NetworkInterface native 
implementation

Hi,

I had made a few more cleanups when I was working on NetworkInterface.c which I 
thought are worth contributing.

Please review: http://cr.openjdk.java.net/~clanger/webrevs/8163181.1/
Bug: https://bugs.openjdk.java.net/browse/JDK-8163181

As always, changes were built and tested on Linux, AIX, Solaris and Mac.

Thanks
Christoph

RFR 8146602: jdk/test/sun/misc/URLClassPath/ClassnameCharTest.java test fails with NullPointerException

[Svetlana Nikandrova]

Hello,

please review this test update. Test do not consider that exception 
could happen while variable "server" is not initialized yet. As a result 
log shows NPE instead of the real exception which is irrecoverably lost. 
I added check for "null" to prevent this situation.
Also did some code-style refactoring: IMHO "all-code-in-one-line" 
methods are really hard to read.


Webrev: http://cr.openjdk.java.net/~snikandrova/8146602/webrev.00/ 


 JBS: https://bugs.openjdk.java.net/browse/JDK-8146602

Thank you,
Svetlana

RE: RFR 8146602: jdk/test/sun/misc/URLClassPath/ClassnameCharTest.java test fails with NullPointerException

[Langer, Christoph]

Hi Svetlana,

the patch looks nice. But unfortunately I'm not a reviewer.

Best regards
Christoph


> -Original Message-
> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of
> Svetlana Nikandrova
> Sent: Dienstag, 16. August 2016 17:35
> To: OpenJDK Network Dev list 
> Subject: RFR 8146602:
> jdk/test/sun/misc/URLClassPath/ClassnameCharTest.java test fails with
> NullPointerException
> 
> Hello,
> 
> please review this test update. Test do not consider that exception
> could happen while variable "server" is not initialized yet. As a result
> log shows NPE instead of the real exception which is irrecoverably lost.
> I added check for "null" to prevent this situation.
> Also did some code-style refactoring: IMHO "all-code-in-one-line"
> methods are really hard to read.
> 
> Webrev: http://cr.openjdk.java.net/~snikandrova/8146602/webrev.00/
> 
>   JBS: https://bugs.openjdk.java.net/browse/JDK-8146602
> 
> Thank you,
> Svetlana