Hi Svetlana, the patch looks nice. But unfortunately I'm not a reviewer.
Best regards Christoph > -----Original Message----- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of > Svetlana Nikandrova > Sent: Dienstag, 16. August 2016 17:35 > To: OpenJDK Network Dev list <net-dev@openjdk.java.net> > Subject: RFR 8146602: > jdk/test/sun/misc/URLClassPath/ClassnameCharTest.java test fails with > NullPointerException > > Hello, > > please review this test update. Test do not consider that exception > could happen while variable "server" is not initialized yet. As a result > log shows NPE instead of the real exception which is irrecoverably lost. > I added check for "null" to prevent this situation. > Also did some code-style refactoring: IMHO "all-code-in-one-line" > methods are really hard to read. > > Webrev: http://cr.openjdk.java.net/~snikandrova/8146602/webrev.00/ > <http://cr.openjdk.java.net/%7Esnikandrova/8146602/webrev.00/> > JBS: https://bugs.openjdk.java.net/browse/JDK-8146602 > > Thank you, > Svetlana
