RFR JDK-8041563: ProblemList.txt updates

2014-04-23 Thread hefeng cui

Hi,

Please review the my code changes for JDK-8041563 



Here is the webrev link : 
http://cr.openjdk.java.net/~ewang/michael/JDK-8041563/webrev.00/ 



Thanks,
Michael Cui


Re: RFR JDK-8041563: ProblemList.txt updates

2014-04-23 Thread Chris Hegarty

Looks ok to me Michael. I can sponsor this change for you.

-Chris.

On 23/04/14 10:01, hefeng cui wrote:

Hi,

Please review the my code changes for JDK-8041563


Here is the webrev link :
http://cr.openjdk.java.net/~ewang/michael/JDK-8041563/webrev.00/


Thanks,
Michael Cui


Re: RFR JDK-8041563: ProblemList.txt updates

2014-04-23 Thread hefeng cui

Hi Chris,

Thanks for your review and sponsor!

Regards,
Michael Cui

On 2014/4/23 17:26, Chris Hegarty wrote:

Looks ok to me Michael. I can sponsor this change for you.

-Chris.

On 23/04/14 10:01, hefeng cui wrote:

Hi,

Please review the my code changes for JDK-8041563


Here is the webrev link :
http://cr.openjdk.java.net/~ewang/michael/JDK-8041563/webrev.00/


Thanks,
Michael Cui




Re: Proxied https connection reuse by sun.net.www.http.HttpClient can send CONNECT to the destination server

2014-04-23 Thread Chris Hegarty

..and finally pushed to JDK 9.

  http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ea0d59f39e8f

I will request backports to both 8u and 7u.

-Chris.

On 15/04/14 18:54, Steven Lawrance wrote:

Thanks! Hopefully, it can also get backported to JDK7, but it's good
that it can get fixed in at least JDK9.


Steven Lawrance


On Tue, Apr 15, 2014 at 12:53 PM, Andreas Rieber
mailto:rieberandr...@gmail.com>> wrote:

Hi Chris,

i have also checked this problem and yes: the proxy header can end
on the server side. The fix looks right. I have rewritten the test
so it is in the right place and using existing certificate. I guess
Steven would like to see this fix going in somehow ;-)

I did run a full jtreg test on ubuntu, jdk 9 dev and jdk 9, where
this test fails.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8025710

Webrev:
http://cr.openjdk.java.net/~arieber/8025710/webrev.00/

thanks
Andreas



On 24.12.2013 15:01, Chris Hegarty wrote:

Andreas, Steven,

I updated the bug and assigned it to myself ( to remind me to
sponsor the change ). I'll need to look at the changes in a little
more detail, but at first glance they look right to me. I will
also look to see if the test can be reduced a little, and add
appropriate jtreg tags ( to allow it to be run in our test
environment ).

Thanks,
-Chris

On 24 Dec 2013, at 08:44, Andreas Rieber mailto:rieberandr...@gmail.com>> wrote:


Hi Steven,

On 24.12.2013 00:41, Steven Lawrance wrote:

Hi net-dev,

I filed this on September 26 at bugs.sun.com
, which assigned bug ID 9007104 to it, but
that bug still does not appear to be visible. I'm emailing in
case if that system malfunctioned. I now see that OpenJDK has a
Bugzilla system, but I don't have an account to file this bug.


Your bug is visible in new JBS at:
https://bugs.openjdk.java.net/browse/JDK-8025710

- Andreas

cut
...






RFR: 8041397: Lint regression in java.net.SocketOption

2014-04-23 Thread Michael McMahon

Could I get the following small change reviewed please?

It fixes a number of recently introduced lint warnings

http://cr.openjdk.java.net/~michaelm/8041397/webrev.1/

Thanks
Michael.


Re: RFR: 8041397: Lint regression in java.net.SocketOption

2014-04-23 Thread roger riggs

Hi Michael,

Looks fine.

Roger


On 4/23/2014 11:56 AM, Michael McMahon wrote:

Could I get the following small change reviewed please?

It fixes a number of recently introduced lint warnings

http://cr.openjdk.java.net/~michaelm/8041397/webrev.1/

Thanks
Michael.




Re: RFR: 8041397: Lint regression in java.net.SocketOption

2014-04-23 Thread Chris Hegarty

> On 23 Apr 2014, at 17:07, roger riggs  wrote:
> 
> Hi Michael,
> 
> Looks fine.

+1

-Chris.

> 
> Roger
> 
> 
>> On 4/23/2014 11:56 AM, Michael McMahon wrote:
>> Could I get the following small change reviewed please?
>> 
>> It fixes a number of recently introduced lint warnings
>> 
>> http://cr.openjdk.java.net/~michaelm/8041397/webrev.1/
>> 
>> Thanks
>> Michael.
>