Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'. It is just a general utility method to get the value of the defaultIndex field of NetworkInterace. Yes, the value will be 0 on all platforms other than Mac, but equally getDefaultScopeID will not be called on any platform, other than Mac. -Chris. On 02/14/12 07:46 AM, Alan Bateman wrote: On 13/02/2012 22:03, Kurchi Hazra wrote: Hi, Before joining multicast groups with IPv6 addresses on Mac OS, the network interface to be used should also be set correctly. This change enables using a default network interface on Mac OS X if no interface has been specified. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274 Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/ Kurchi - I think you should include an #else return 0; in getDefaultScopeID as otherwise I will guess you will get warnings when this code is compiled on other platforms. -Alan.
hg: jdk8/tl/jdk: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc
Changeset: f62077973f9b Author:vinnie Date: 2012-02-14 11:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f62077973f9b 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/ec.sh
Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/ - Kurchi On 2/14/2012 12:58 AM, Chris Hegarty wrote: Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'. It is just a general utility method to get the value of the defaultIndex field of NetworkInterace. Yes, the value will be 0 on all platforms other than Mac, but equally getDefaultScopeID will not be called on any platform, other than Mac. -Chris. On 02/14/12 07:46 AM, Alan Bateman wrote: On 13/02/2012 22:03, Kurchi Hazra wrote: Hi, Before joining multicast groups with IPv6 addresses on Mac OS, the network interface to be used should also be set correctly. This change enables using a default network interface on Mac OS X if no interface has been specified. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274 Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/ Kurchi - I think you should include an #else return 0; in getDefaultScopeID as otherwise I will guess you will get warnings when this code is compiled on other platforms. -Alan. -- -Kurchi
Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()
Looks fine to me. -Chris. On 02/14/12 07:12 PM, Kurchi Hazra wrote: Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/ - Kurchi On 2/14/2012 12:58 AM, Chris Hegarty wrote: Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'. It is just a general utility method to get the value of the defaultIndex field of NetworkInterace. Yes, the value will be 0 on all platforms other than Mac, but equally getDefaultScopeID will not be called on any platform, other than Mac. -Chris. On 02/14/12 07:46 AM, Alan Bateman wrote: On 13/02/2012 22:03, Kurchi Hazra wrote: Hi, Before joining multicast groups with IPv6 addresses on Mac OS, the network interface to be used should also be set correctly. This change enables using a default network interface on Mac OS X if no interface has been specified. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274 Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/ Kurchi - I think you should include an #else return 0; in getDefaultScopeID as otherwise I will guess you will get warnings when this code is compiled on other platforms. -Alan.
hg: jdk8/tl/langtools: 7142086: performance problem in Check.checkOverrideClashes(...)
Changeset: 84b61130cbed Author:mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to MethodSymbol.overrides Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/7142086/T7142086.java
