Looks fine to me.
-Chris.
On 02/14/12 07:12 PM, Kurchi Hazra wrote:
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/
- Kurchi
On 2/14/2012 12:58 AM, Chris Hegarty wrote:
Trivially, I don't think getDefaultScopeID needs it's implementation
to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'.
It is just a general utility method to get the value of the
defaultIndex field of NetworkInterace. Yes, the value will be 0 on all
platforms other than Mac, but equally getDefaultScopeID will not be
called on any platform, other than Mac.
-Chris.
On 02/14/12 07:46 AM, Alan Bateman wrote:
On 13/02/2012 22:03, Kurchi Hazra wrote:
Hi,
Before joining multicast groups with IPv6 addresses on Mac OS, the
network interface to be used should also be set correctly. This
change enables using a default network interface on Mac OS X if no
interface
has been specified.
Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144274
Webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.01/
Kurchi - I think you should include an #else return 0; in
getDefaultScopeID as otherwise I will guess you will get warnings when
this code is compiled on other platforms.
-Alan.
