[Mesa-dev] [PATCH] configure.ac: remove -fcolor-diagnostics from LLVM flags
When LLVM is build with Clang, "llvm-config --cxxflags" contains the
-fcolor-diagnostics flag. It is not recognized by gcc and the build
fails. Fix by removing the flag.
Signed-off-by: Markus Trippelsdorf
diff --git a/configure.ac b/configure.ac
index c14d39a285a6..da8be8b02f3e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1546,6 +1546,7 @@ strip_unwanted_llvm_flags() {
-e 's/-O.\>//g' \
-e 's/-g\>//g' \
-e 's/-Wall\>//g' \
+ -e 's/-fcolor-diagnostics\>//g' \
-e 's/-fomit-frame-pointer\>//g'
}
--
Markus
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 2/6] r600g: apply disable workaround on all scissors
On 2015.09.03 at 01:54 +0300, Grazvydas Ignotas wrote: > During review of the "r600g: make all scissor states use single atom" patch > Marek Olšák noticed that scissor disable workaround should be applied on > all scissor states and not just first one, so let's do so. This patch causes: https://bugs.freedesktop.org/show_bug.cgi?id=91921 -- Markus ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader
On 2017.04.12 at 20:45 +0100, Emil Velikov wrote: > On 12 April 2017 at 20:34, Constantine Kharlamov wrote: > > >> I suspect this breaks because r600 more often fails to > >> compile some shaders, > >> and the hw requires a fragment shader and we use the empty one as a > >> fallback in that case. > > > > Ok, that wasn't obvious, I running the system with the patchset on HD5730, > > including > > piglit testing — so far is fine. > > > If in doubt ask the bug reporter(s) to test a patch on their machines. Well, the question is why bother with this legacy code at all? I would expect a much more conservative approach. Except for essential patches to keep the hardware running, everything else should be rejected. Nobody is expecting new features for this ancient hardware anyway. -- Markus ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH 3/3 v2] r600g: get rid of dummy pixel shader
On 2017.04.10 at 22:48 +0200, Marek Olšák wrote: > Pushed the series, thanks! > > Marek > > On Mon, Apr 10, 2017 at 10:04 PM, Constantine Kharlamov > wrote: > > The idea is taken from radeonsi. The code mostly was already checking for > > null > > pixel shader, so little checks had to be added. > > > > Interestingly, acc. to testing with GTAⅣ, though binding of null shader > > happens > > a lot at the start (then just stops), but draw_vbo() never actually sees > > null > > ps. > > > > v2: added a check I missed because of a macros using a prefix to choose > > a shader. This commit causes ring 0 stalls on r600: https://bugs.freedesktop.org/show_bug.cgi?id=100663 -- Markus ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
