[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D52618#1250909, @zturner wrote:

> One idea would be to define some lit substitutions like %debuginfo. It’s
>  true you can produce a gcc style command line that will be equivalent to a
>  clang-cl invocation but it won’t be easy. eg you’ll needing to pass
>  -fms-compatibility as well as various -I for includes.
>
> It may be easier to have substitutions instead


Another option would be to define a way in lit to specify a command to run 
based on requirements - similar how we can use "windows" or "linux" in the 
"requires" command.


https://reviews.llvm.org/D52618



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

Could you document that in the test?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53086



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This test has been failing on Windows since it was added as it doesn't build 
correctly. I noticed some of the tests are also disabled on Linux. Is this 
supposed to pass on all platforms?

  Error when building test subject.
  Build Command:
  make 
VPATH=E:\_work\60\s\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\target_create_deps
 -C 
E:\_work\60\b\LLVMBuild\lldb-test-build.noindex\functionalities\target_create_deps\TestTargetCreateDeps.test_dependents_explicit_default_lib
 -I 
E:\_work\60\s\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\target_create_deps
 -f 
E:\_work\60\s\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\target_create_deps\Makefile
 all ARCH=x86_64 CC="E:\_work\60\b\LLVMBuild\Release\bin\clang.exe" 
  
  ##[error]lld-link(0,0): Error : undefined symbol: "int __cdecl 
a_function(void)" (?a_function@@YAHXZ)
  lld-link : error : undefined symbol: "int __cdecl a_function(void)" 
(?a_function@@YAHXZ) [e:\_work\60\b\LLVMBuild\check-all.vcxproj]
  >>> referenced by main.o:(main)
  ##[error]clang(0,0): Error : linker command failed with exit code 1 (use -v 
to see invocation)
  clang : error : linker command failed with exit code 1 (use -v to see 
invocation) [e:\_work\60\b\LLVMBuild\check-all.vcxproj]
  make: *** [a.out] Error 1


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51934



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: zturner, asmith.
Herald added a subscriber: lldb-commits.

This is another string/byte conversion issue between Python 2 and 3. In Python 
2, the subprocess communication expects a byte string, but in Python 3, it 
expects bytes.

There are a pair of functions to_bytes/to_string in lit that implement the 
correct conversion, but they're not available throughout the lldb suite which 
is why this fix is 'in place' rather than calling one of these functions.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53166

Files:
  packages/Python/lldbsuite/test/lldbtest.py


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2227,6 +2227,10 @@
 # Get the error text if there was an error, and the regular text if 
not.
 output = self.res.GetOutput() if self.res.Succeeded() \
 else self.res.GetError()
+# In Python 2, communicate sends byte strings. In Python 3, 
communicate sends bytes.
+# If we got a string (and not a byte string), encode it before sending.
+if isinstance(output, str) and not isinstance(output, bytes):
+output = output.encode()
 
 # Assemble the absolute path to the check file. As a convenience for
 # LLDB inline tests, assume that the check file is a relative path to


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2227,6 +2227,10 @@
 # Get the error text if there was an error, and the regular text if not.
 output = self.res.GetOutput() if self.res.Succeeded() \
 else self.res.GetError()
+# In Python 2, communicate sends byte strings. In Python 3, communicate sends bytes.
+# If we got a string (and not a byte string), encode it before sending.
+if isinstance(output, str) and not isinstance(output, bytes):
+output = output.encode()
 
 # Assemble the absolute path to the check file. As a convenience for
 # LLDB inline tests, assume that the check file is a relative path to
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Unfortunately, the bots are broken because of the FileCheck issue, so I can't 
confirm with them, but I see a number of these tests fail in our local testing. 
Some fail on both Windows and Linux and some just fail on Linux. Here are the 
failing tests:

  Linux:
  lldb-Suite :: 
functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
  lldb-Suite :: 
functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
  lldb-Suite :: 
functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
  lldb-Suite :: 
functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
  lldb-Suite :: 
functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
  lldb-Suite :: 
functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
  lldb-Suite :: 
functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
  
  Windows:
  lldb-Suite :: 
functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
  lldb-Suite :: 
functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py

Let me know what you need to investigate.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D50478



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I spent a bit more time on this and I think I have a better idea of what's 
happening.

Vedant added functionality so that we can use FileCheck-style checks inside 
non-lit LLDB tests. Part of that change was to require a parameter --filecheck 
to be passed when calling the scripts (such as dotests.py). Also as part of 
that change, the CMakeFiles now propagate a default location for FileCheck as 
an input to the scripts, so that if you just run the tests by default using any 
of the generated outputs (for ninja, or make, or VS), they work correctly

The bots (at least some bots) don't just use the generated solutions to run the 
tests. There's some complicated logic in the zorg repo to create the list of 
parameters that are passed to the bots and they do not include the new 
--filecheck argument. So it's not individual bots that need to be updated, but 
the test harness. I haven't really looked at it before, so I'm still trying to 
understand it - especially how we would get FileCheck to any of the bots that 
run the tests remotely using lldbserver today.


https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The failing bots are not windows bots but Linux bots. It looks like you only 
updated the configurations for xcode.

I think the file that needs to be updated is:

zorg\buildbot\builders\LLDBBuilder.py


https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

@jasonmolenda That's not a bad idea. If you have a change ready, you could send 
it for review ;)


https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova requested changes to this revision.
stella.stamenova added a comment.
This revision now requires changes to proceed.

@vsk Could you also make the filecheck function explicitly fail when it doesn't 
have a path to the binary? That way it will be fairly obvious what the problem 
is and the error combined with the warning should be clear enough.


https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I see this test failing on Linux right now (bots are down, so I can't confirm 
that the official bots fail as well). The failure is because of the last 
decorator which was not part of the review:

  @skipIf(macos_version=["<", "10.14"])

It looks like this only works correctly when mac_ver returns a meaningful 
result (a.k.a. on mac platforms), so linux is broken.

Another thing that I noticed is that the name of the test class 
(LibcxxOptionalDataFormatterTestCase) was re-used from another test. This has 
caused problems in the past with test overriding each other's results because 
they share the same class and test name (as these do).


https://reviews.llvm.org/D49271



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova updated this revision to Diff 169459.
stella.stamenova edited the summary of this revision.
stella.stamenova added a comment.

Force the comparison in filecheck to use text rather than bytes


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53166

Files:
  packages/Python/lldbsuite/test/lldbtest.py


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2240,7 +2240,7 @@
 filecheck_args = [filecheck_bin, check_file_abs]
 if filecheck_options:
 filecheck_args.append(filecheck_options)
-subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
+subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE, 
universal_newlines = True)
 cmd_stdout, cmd_stderr = subproc.communicate(input=output)
 cmd_status = subproc.returncode
 


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2240,7 +2240,7 @@
 filecheck_args = [filecheck_bin, check_file_abs]
 if filecheck_options:
 filecheck_args.append(filecheck_options)
-subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
+subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE, universal_newlines = True)
 cmd_stdout, cmd_stderr = subproc.communicate(input=output)
 cmd_status = subproc.returncode
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: packages/Python/lldbsuite/test/lldbtest.py:2247-2249
 subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
 cmd_stdout, cmd_stderr = subproc.communicate(input=output)
 cmd_status = subproc.returncode

zturner wrote:
> If I'm not mistaken, Python 3 can accept `stdin` as `bytes` or `string`, and 
> either will work, it depends on the value of `universal_newlines`, and 
> `stdout` will be in whatever format `stdin` was in.  If we pass 
> `universal_newlines=True`, then it will expect a `string` and output a 
> `string`, otherwise it expects a `bytes` and output a `bytes`.  Given that 
> `FileCheck` is supposed to operate on textual data and not binary data, 
> perhaps we should be doing that here?
Brilliant! :)


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53166



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: labath, davide, asmith, shafik.
Herald added a subscriber: lldb-commits.

On non-mac platforms, mac_ver returns an empty string which when converted to 
LooseVersion has no "version" property. This causes a failure when the 
decorator executes. Instead, check whether the value returned from mac_ver is 
an empty string and avoid the LooseVersion comparison.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208

Files:
  packages/Python/lldbsuite/test/decorators.py


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -191,7 +191,7 @@
 skip_for_py_version = (
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
-skip_for_macos_version = (macos_version is None) or (
+skip_for_macos_version = (macos_version is None) or 
(platform.mac_ver()[0] == "") or (
 _check_expected_version(
 macos_version[0],
 macos_version[1],


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -191,7 +191,7 @@
 skip_for_py_version = (
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
-skip_for_macos_version = (macos_version is None) or (
+skip_for_macos_version = (macos_version is None) or (platform.mac_ver()[0] == "") or (
 _check_expected_version(
 macos_version[0],
 macos_version[1],
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344386: [lldbsuite] Fix the filecheck functionality to 
work with Python 3 (authored by stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53166

Files:
  packages/Python/lldbsuite/test/lldbtest.py


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2240,7 +2240,7 @@
 filecheck_args = [filecheck_bin, check_file_abs]
 if filecheck_options:
 filecheck_args.append(filecheck_options)
-subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
+subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE, 
universal_newlines = True)
 cmd_stdout, cmd_stderr = subproc.communicate(input=output)
 cmd_status = subproc.returncode
 


Index: packages/Python/lldbsuite/test/lldbtest.py
===
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2240,7 +2240,7 @@
 filecheck_args = [filecheck_bin, check_file_abs]
 if filecheck_options:
 filecheck_args.append(filecheck_options)
-subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
+subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE, universal_newlines = True)
 cmd_stdout, cmd_stderr = subproc.communicate(input=output)
 cmd_status = subproc.returncode
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52851: Adding support to step into the callable wrapped by libc++ std::function

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This change has the same problem as https://reviews.llvm.org/D49271 - the class 
name LibCxxFunctionTestCase is re-used from another test case. This will cause 
issues when the tests report results and create logs. Please use unique names 
for each class and test.


Repository:
  rL LLVM

https://reviews.llvm.org/D52851



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

Thanks!


https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The bots are now failing because lexists doesn't handle NoneType correctly:

File 
"/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py",
 line 191, in get_filecheck_path
  if os.path.lexists(filecheck):
File "/lldb-buildbot/virenv/lib/python2.7/posixpath.py", line 152, in 
lexists
  os.lstat(path)
  TypeError: coercing to Unicode: need string or buffer, NoneType found

I think get_filecheck_path should check if filecheck is set first before 
calling lexists:

  if filecheck and os.path.lexists(filecheck):
  return filecheck


Repository:
  rL LLVM

https://reviews.llvm.org/D53175



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D49271#1263842, @shafik wrote:

> @stella.stamenova Thank you for catching this. I fixed the test names, I am 
> looking into the best way to fix the skipif now.


@shafik I send a change for review this morning that I think should do the 
trick: https://reviews.llvm.org/D53208. The other option is to change the 
skipIf to include the os like some of the other ones.


https://reviews.llvm.org/D49271



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: packages/Python/lldbsuite/test/decorators.py:194
 py_version[0], py_version[1], sys.version_info)
-skip_for_macos_version = (macos_version is None) or (
+skip_for_macos_version = (macos_version is None) or 
(platform.mac_ver()[0] == "") or (
 _check_expected_version(

shafik wrote:
> If I am reading the following code correctly this will default to skipping 
> when `platform.mac_ver()[0]  == ""` shouldn't it be the other way around? 
Yes, you are reading it correctly. I can see either as being "right" - the 
question is how the decorator is supposed to be used.

Usually, it is paired with a skipUnlessDarwin (or similar), so skipping if it 
is not mac is "right".

On the other hand, for the test you added, I think you wanted it to run on 
other platforms and on mac only if the version requirement was met, so we 
should not skip if the platform is not Darwin. Was that your goal?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova updated this revision to Diff 169509.

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208

Files:
  packages/Python/lldbsuite/test/decorators.py


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -192,10 +192,10 @@
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
 skip_for_macos_version = (macos_version is None) or (
-_check_expected_version(
+(platform.mac_ver()[0] != "") and (_check_expected_version(
 macos_version[0],
 macos_version[1],
-platform.mac_ver()[0]))
+platform.mac_ver()[0])))
 
 # For the test to be skipped, all specified (e.g. not None) parameters 
must be True.
 # An unspecified parameter means "any", so those are marked skip by 
default.  And we skip


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -192,10 +192,10 @@
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
 skip_for_macos_version = (macos_version is None) or (
-_check_expected_version(
+(platform.mac_ver()[0] != "") and (_check_expected_version(
 macos_version[0],
 macos_version[1],
-platform.mac_ver()[0]))
+platform.mac_ver()[0])))
 
 # For the test to be skipped, all specified (e.g. not None) parameters must be True.
 # An unspecified parameter means "any", so those are marked skip by default.  And we skip
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: davide, asmith.
Herald added a subscriber: lldb-commits.

This test is failing on Windows because lldb does not support JIT on Windows.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53226

Files:
  
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py


Index: 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+llldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])


Index: packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+llldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova updated this revision to Diff 169515.

https://reviews.llvm.org/D53226

Files:
  
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py


Index: 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+lldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])


Index: packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+lldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53226: [lldbsuite] Disable Test128BitsInteger on Windows

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344543: [lldbsuite] Disable Test128BitsInteger on Windows 
(authored by stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53226

Files:
  
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py


Index: 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ 
packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+lldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])


Index: packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
===
--- packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
+++ packages/Python/lldbsuite/test/expression_command/rdar44436068/Test128BitsInteger.py
@@ -1,4 +1,7 @@
 from lldbsuite.test import lldbinline
 from lldbsuite.test import decorators
 
-lldbinline.MakeInlineTest(__file__, globals(), None)
+lldbinline.MakeInlineTest(
+__file__, globals(), [
+decorators.expectedFailureAll(
+oslist=["windows"], bugnumber="llvm.org/pr37656")])
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: jasonmolenda, asmith.
Herald added subscribers: lldb-commits, kbarton, nemanjai.

If the names are not unique, the tests overwrite each other's results and logs. 
This also causes failures on platforms where the files are locked for writing.

The names of the class/test pairs *have to* always be unique. The easiest way 
to achieve that is to name each class differently (usually the same as the file 
name).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53297

Files:
  
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py


Index: 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===
--- 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
 def test(self):
 class MyResponder(MockGDBServerResponder):
 def haltReason(self):


Index: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===
--- packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
 def test(self):
 class MyResponder(MockGDBServerResponder):
 def haltReason(self):
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344547: [lldbsuite] Make the names of test classes unique 
(authored by stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53297

Files:
  
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py


Index: 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===
--- 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ 
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
 def test(self):
 class MyResponder(MockGDBServerResponder):
 def haltReason(self):


Index: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===
--- packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
 def test(self):
 class MyResponder(MockGDBServerResponder):
 def haltReason(self):
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D53208#1264056, @jingham wrote:

> We do compose the decorators in a bunch of places (like Shafik's usage here). 
>  That will work more naturally if the categories that the decorators assert 
> are as decoupled as possible.  So the statement about macos version should 
> only skip the test if the os is macos, and make no comment about other os's.  
> That decouples the macos_version test from the oslist test, and allows 
> something like the construct in the tests that Shafik wrote, which seems a 
> pretty natural way to express "if on macOS, it has to be version > x, 
> otherwise it has to be clang > y".


I updated the change to support that. Could you have a look?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Thanks. I guess the more explicit question is: which platforms is this feature 
(and test) applicable to? The test should be disabled on other platforms. It is 
already disabled on Linux because it is not applicable and it is failing to 
even build on Windows in its current state.

@JDevlieghere , do you expect this to work on Windows?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51934



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D50478#1262717, @vsk wrote:

> In https://reviews.llvm.org/D50478#1262710, @stella.stamenova wrote:
>
> > Unfortunately, the bots are broken because of the FileCheck issue, so I 
> > can't confirm with them, but I see a number of these tests fail in our 
> > local testing. Some fail on both Windows and Linux and some just fail on 
> > Linux. Here are the failing tests:
> >
> >   Linux:
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/disambiguate_call_site/TestDisambiguateCallSite.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/disambiguate_paths_to_common_sink/TestDisambiguatePathsToCommonSink.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/disambiguate_tail_call_seq/TestDisambiguateTailCallSeq.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/inlining_and_tail_calls/TestInliningAndTailCalls.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/thread_step_out_message/TestArtificialFrameStepOutMessage.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/unambiguous_sequence/TestUnambiguousTailCalls.py
> >  
> >   Windows:
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
> >   lldb-Suite :: 
> > functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
> >
> >
> > Let me know what you need to investigate.
>
>
> Strange, I didn't get any bot failure notifications in the days after this 
> landed. Could you share the output from the failing tests?


All the failures on Windows are happening when validating the function name. 
For example:

  ==
  
  FAIL: test_tail_call_frame_sbapi 
(TestTailCallFrameSBAPI.TestTailCallFrameSBAPI)
  
  --
  
  Traceback (most recent call last):
  
File 
"E:\_work\55\s\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\tail_call_frames\sbapi_support\TestTailCallFrameSBAPI.py",
 line 19, in test_tail_call_frame_sbapi
  
  self.do_test()
  
File 
"E:\_work\55\s\llvm\tools\lldb\packages\Python\lldbsuite\test\functionalities\tail_call_frames\sbapi_support\TestTailCallFrameSBAPI.py",
 line 64, in do_test
  
  self.assertTrue(frame.GetDisplayFunctionName() == name)
  
  AssertionError: False is not True
  
  Config=x86_64-E:\_work\55\b\LLVMBuild\Release\bin\clang.exe
  
  --

There are several different failures on Linux. Here's the first one:

  FAIL: LLDB (/vstsdrive/_work/38/b/LLVMBuild/bin/clang-8-x86_64) :: test_dwarf 
(lldbsuite.test.lldbtest.TestDisambiguateCallSite)
  
  --- FileCheck trace (code=1) ---
  /vstsdrive/_work/38/b/LLVMBuild/bin/FileCheck 
/vstsdrive/_work/38/s/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/disambiguate_call_site/main.cpp
 -implicit-check-not=artificial
  
  FileCheck input:
  * thread #1, name = 'a.out', stop reason = breakpoint 1.1
* frame #0: 0x00400580 a.out`sink() at main.cpp:13:4 [opt]
  frame #1: 0x004005b8 a.out`main(argc=1, (null)=) at 
main.cpp:28:3 [opt]
  frame #2: 0x7f980aff7830 libc.so.6`__libc_start_main + 240
  frame #3: 0x004004a9 a.out`_start + 41
  
  
  FileCheck output:
  
  
/vstsdrive/_work/38/s/llvm/tools/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/disambiguate_call_site/main.cpp:15:17:
 error: CHECK-NEXT: expected string not found in input
   // CHECK-NEXT: func2{{.*}} [opt] [artificial]
  ^
  :3:2: note: scanning from here
   frame #1: 0x004005b8 a.out`main(argc=1, (null)=) at 
main.cpp:28:3 [opt]
   ^
  :3:80: note: possible intended match here
   frame #1: 0x004005b8 a.out`main(argc=1, (null)=) at 
main.cpp:28:3 [opt]

^

Let me know if you need more logs.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D50478



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, zturner.
Herald added subscribers: lldb-commits, abidh.

They fail similarly to some of the other breakpoint tests on Windows, so I 
suspect the cause is the same. I've linked to the same bug.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53331

Files:
  
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py


Index: 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
===
--- 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
+++ 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
@@ -10,6 +10,7 @@
 import re
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 
@@ -19,17 +20,20 @@
 
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_scripted_resolver(self):
 """Use a scripted resolver to set a by symbol name breakpoint"""
 self.build()
 self.do_test()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_search_depths(self):
 """ Make sure we are called at the right depths depending on what we 
return
 from __get_depth__"""
 self.build()
 self.do_test_depths()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_command_line(self):
 """ Make sure we are called at the right depths depending on what we 
return
 from __get_depth__"""


Index: packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
===
--- packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
+++ packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
@@ -10,6 +10,7 @@
 import re
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 
@@ -19,17 +20,20 @@
 
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_scripted_resolver(self):
 """Use a scripted resolver to set a by symbol name breakpoint"""
 self.build()
 self.do_test()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_search_depths(self):
 """ Make sure we are called at the right depths depending on what we return
 from __get_depth__"""
 self.build()
 self.do_test_depths()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_command_line(self):
 """ Make sure we are called at the right depths depending on what we return
 from __get_depth__"""
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344623: [lldbsuite] Fix the mac version decorator to work 
on non-mac platforms (authored by stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208

Files:
  packages/Python/lldbsuite/test/decorators.py


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -192,10 +192,10 @@
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
 skip_for_macos_version = (macos_version is None) or (
-_check_expected_version(
+(platform.mac_ver()[0] != "") and (_check_expected_version(
 macos_version[0],
 macos_version[1],
-platform.mac_ver()[0]))
+platform.mac_ver()[0])))
 
 # For the test to be skipped, all specified (e.g. not None) parameters 
must be True.
 # An unspecified parameter means "any", so those are marked skip by 
default.  And we skip


Index: packages/Python/lldbsuite/test/decorators.py
===
--- packages/Python/lldbsuite/test/decorators.py
+++ packages/Python/lldbsuite/test/decorators.py
@@ -192,10 +192,10 @@
 py_version is None) or _check_expected_version(
 py_version[0], py_version[1], sys.version_info)
 skip_for_macos_version = (macos_version is None) or (
-_check_expected_version(
+(platform.mac_ver()[0] != "") and (_check_expected_version(
 macos_version[0],
 macos_version[1],
-platform.mac_ver()[0]))
+platform.mac_ver()[0])))
 
 # For the test to be skipped, all specified (e.g. not None) parameters must be True.
 # An unspecified parameter means "any", so those are marked skip by default.  And we skip
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53357: [Windows] Fix threads comparison on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53357



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53331: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344744: [lldbsuite] Mark the TestScriptedResolver tests 
as XFAIL on Windows (authored by stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53331

Files:
  
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py


Index: 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
===
--- 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
+++ 
packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
@@ -10,6 +10,7 @@
 import re
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 
@@ -19,17 +20,20 @@
 
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_scripted_resolver(self):
 """Use a scripted resolver to set a by symbol name breakpoint"""
 self.build()
 self.do_test()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_search_depths(self):
 """ Make sure we are called at the right depths depending on what we 
return
 from __get_depth__"""
 self.build()
 self.do_test_depths()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_command_line(self):
 """ Make sure we are called at the right depths depending on what we 
return
 from __get_depth__"""


Index: packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
===
--- packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
+++ packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
@@ -10,6 +10,7 @@
 import re
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 
@@ -19,17 +20,20 @@
 
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_scripted_resolver(self):
 """Use a scripted resolver to set a by symbol name breakpoint"""
 self.build()
 self.do_test()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_search_depths(self):
 """ Make sure we are called at the right depths depending on what we return
 from __get_depth__"""
 self.build()
 self.do_test_depths()
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528")
 def test_command_line(self):
 """ Make sure we are called at the right depths depending on what we return
 from __get_depth__"""
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: asmith, vsk.
Herald added subscribers: lldb-commits, abidh.

These tests fail on Windows because of known limitations (a.k.a. bugs) with the 
current implementation of GetFrameAtIndex


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53415

Files:
  
packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
  
packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py


Index: 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
===
--- 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
+++ 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestArtificialFrameThreadStepOut1(TestBase):
@@ -51,6 +52,7 @@
 #   frame #4: ... a.out`main at main.cpp:23:3 [opt]
 return thread
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_stepping_out_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
@@ -68,6 +70,7 @@
 self.assertEqual(frame4.GetDisplayFunctionName(), "main")
 self.assertFalse(frame2.IsArtificial())
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_return_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
Index: 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
===
--- 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
+++ 
packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestTailCallFrameSBAPI(TestBase):
@@ -14,6 +15,7 @@
 # each debug info format.
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_tail_call_frame_sbapi(self):
 self.build()
 self.do_test()


Index: packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
===
--- packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
+++ packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestArtificialFrameThreadStepOut1(TestBase):
@@ -51,6 +52,7 @@
 #   frame #4: ... a.out`main at main.cpp:23:3 [opt]
 return thread
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_stepping_out_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
@@ -68,6 +70,7 @@
 self.assertEqual(frame4.GetDisplayFunctionName(), "main")
 self.assertFalse(frame2.IsArtificial())
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_return_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
Index: packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
===
--- packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
+++ packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestTailCallFrameSBAPI(TestBase):
@@ -14,6 +15,7 @@
 # each debug info format.
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_tail_call_frame_sbapi(self):
 self.build()
 self.do_test()
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D53415: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL344788: [lldbsuite, windows] Disable two tail call frames 
tests that fail on Windows (authored by stella.stamenova, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D53415?vs=170135&id=170209#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53415

Files:
  
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
  
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py


Index: 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
===
--- 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
+++ 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestTailCallFrameSBAPI(TestBase):
@@ -14,6 +15,7 @@
 # each debug info format.
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_tail_call_frame_sbapi(self):
 self.build()
 self.do_test()
Index: 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
===
--- 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
+++ 
lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestArtificialFrameThreadStepOut1(TestBase):
@@ -51,6 +52,7 @@
 #   frame #4: ... a.out`main at main.cpp:23:3 [opt]
 return thread
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_stepping_out_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
@@ -68,6 +70,7 @@
 self.assertEqual(frame4.GetDisplayFunctionName(), "main")
 self.assertFalse(frame2.IsArtificial())
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_return_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()


Index: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestTailCallFrameSBAPI(TestBase):
@@ -14,6 +15,7 @@
 # each debug info format.
 NO_DEBUG_INFO_TESTCASE = True
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_tail_call_frame_sbapi(self):
 self.build()
 self.do_test()
Index: lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
===
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
@@ -4,6 +4,7 @@
 
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 
 class TestArtificialFrameThreadStepOut1(TestBase):
@@ -51,6 +52,7 @@
 #   frame #4: ... a.out`main at main.cpp:23:3 [opt]
 return thread
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def test_stepping_out_past_artificial_frame(self):
 self.build()
 thread = self.prepare_thread()
@@ -68,6 +70,7 @@
 self.assertEqual(frame4.GetDisplayFunctionName(), "main")
 self.assertFalse(frame2.IsArtificial())
 
+@expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265")
 def 

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

A couple of comments, but looks good otherwise. I'd wait for someone else to 
have a look as well.




Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:959
+// It may be an expression evaluation crash.
+SetPrivateState(eStateStopped);
   }

Are we going to determine later whether it is supposed to be a crash or just 
never crash on second chance exceptions?



Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:1085
+  } else
+set = &m_namespaces;
+  assert(set);

Nit: Maybe add curly braces here. Since the if statement has them, the code is 
easier to read if the else does as well.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53759



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

Looks good. The formatting in lit.cfg.py is a bit messy (indentations, 
especially), but as long as the tests pass, this is an improvement :). Thanks!


https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54009#1284839, @zturner wrote:

> In https://reviews.llvm.org/D54009#1284827, @stella.stamenova wrote:
>
> > Looks good. The formatting in lit.cfg.py is a bit messy (indentations, 
> > especially), but as long as the tests pass, this is an improvement :). 
> > Thanks!
>
>
> Is there something like clang-format for Python?  Happy to fix it if so.  (I 
> don't do a lot of Python so it's hard for me to eyeball it and figure out 
> what's wrong, so I have to say it looks fine to me :))


There's no clang-format for Python that I know of. Since python cares about 
indentation, it's always a good idea to make sure that we use the same number 
of spaces for all of the 'if's and such as it will occasionally lead to hard to 
track down bugs. There are (in the final version) of lit.cfg.py a couple of 
places where two spaces make the indentation and everything else uses four. 
It's not a big deal because of where they are, but something to look out for.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53915: [FileSystem] Move resolve logic out of FileSpec

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Some of the file spec changes caused a bunch of failures on Windows. We know 
have a silent Buildbot that you can see the failures on as well:

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1128/steps/test/logs/stdio

Let me know if you need anything else. Once all the tests are green again we're 
going to make the Buildbot no longer silent, so this should be easier to catch.


Repository:
  rL LLVM

https://reviews.llvm.org/D53915



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Several of the windows tests that invoke clang-cl have started failing recently 
(I am not sure exactly when) and I suspect this change is the culprit. Were you 
able to run the tests successfully with this change?


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54009#1290644, @zturner wrote:

> I have not run the dotest suite recently, is that where you’re seeing the
>  failures? I successfully ran the lit suite and unit tests though


Yes, they are primarily in the lldb-suite but not only:

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio

There are some other failures, but what I suspect happened after this change is 
that the tests are now not picking up clang-cl correctly:

  $ "clang-cl" "/Zi" 
"E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\Expr/Inputs/call-function.cpp"
 "-o" 
"E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\Expr\Output\TestIRMemoryMapWindows.test.tmp"
  # command stderr:
  clang-cl: warning: unable to find a Visual Studio installation; try running 
Clang from a developer command prompt [-Wmsvc-not-found]
  
  clang-cl: error: unable to execute command: program not executable
  
  clang-cl: error: linker command failed with exit code 1 (use -v to see 
invocation)

I will have some time to have a look in more detail tomorrow.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

TestVla fails on Windows: 
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio

  AssertionError: False is not True : 'frame var vla' returns expected result, 
got '(int []) vla = {}'

I will have time to look in more detail later this week, but if you have any 
ideas in the mean time, that would be great.


Repository:
  rL LLVM

https://reviews.llvm.org/D53530



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D53530#1290680, @aprantl wrote:

> In https://reviews.llvm.org/D53530#1290664, @stella.stamenova wrote:
>
> > TestVla fails on Windows: 
> > http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio
> >
> >   AssertionError: False is not True : 'frame var vla' returns expected 
> > result, got '(int []) vla = {}'
> >
> >
> > I will have time to look in more detail later this week, but if you have 
> > any ideas in the mean time, that would be great.
>
>
> Is your bot using DWARF or CodeView as a debug info format? Because this test 
> definitely requires DWARF.


I was under the impression that each test can control how to build the 
necessary payloads. Is that not the case?


Repository:
  rL LLVM

https://reviews.llvm.org/D53530



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I haven't verified this yet - but I suspect it is now picking up the clang-cl 
that comes with VS rather than the one that was just built.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The builds don't specify the two options for LLDB_TEST_C/CXX_COMPILER, so they 
should be picking up the freshly build compilers. We don't have an option for 
clang-cl though - so it's never been explicitly specified.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54009



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the 
cmake files along with this change, otherwise, people will still expect them to 
work.


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54567#122, @aprantl wrote:

> In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote:
>
> > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from 
> > the cmake files along with this change, otherwise, people will still expect 
> > them to work.
>
>
> That would not be a good idea. There are several bots that are using these 
> flags.


The change that Zachary is making is removing their usage, so after his change 
they would not do anything. If he ends up committing this change, these two 
properties (along with LLDB_DEFAULT_TEST_C_COMPILER and 
LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54567#129, @zturner wrote:

> In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote:
>
> > In https://reviews.llvm.org/D54567#122, @aprantl wrote:
> >
> > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote:
> > >
> > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER 
> > > > from the cmake files along with this change, otherwise, people will 
> > > > still expect them to work.
> > >
> > >
> > > That would not be a good idea. There are several bots that are using 
> > > these flags.
> >
> >
> > The change that Zachary is making is removing their usage, so after his 
> > change they would not do anything. If he ends up committing this change, 
> > these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and 
> > LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.
>
>
> The flags are still needed for (and used by) the dotest suite, I didn't 
> change that part.  Normally you run that suite by doing `ninja check-lldb`, 
> in which case it never goes through these lit files to begin with.  But they 
> will also run as part of `ninja check-lldb-lit`, but that lit configuration 
> file totally overrides everything in the parent one, so nothing in this patch 
> should have any effect on that.


I think this is actually confusing - there are two ways to specify compilers 
for the lldb test suite at cmake time:

1. Via LLDB_TEST_USE_CUSTOM_C_COMPILER and friends
2. Via LLDB_TEST_USER_ARGS

As far as I can tell, the ubuntu 14 bot that @aprantl pointed to uses the 
LLDB_TEST_USER_ARGS path. I *think* the green dragon bots also use the 
LLDB_TEST_USER_ARGS and AFAIK it's the only way gcc is ever specified for the 
tests. If the LLDB_TEST_USE_CUSTOM_C_COMPILER and friends are not used for the 
lit tests, I don't think we need them for the suite tests.


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54567#1300030, @aprantl wrote:

> In https://reviews.llvm.org/D54567#130, @zturner wrote:
>
> > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/
> >
> > What do I need to click on to get the equivalent of this: 
> > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/31244/steps/test6/logs/stdio
>
>
> Click on a recent build and then on "Console Output". Here is one from 
> yesterday (we are upgrading the machines right now and temporarily broke the 
> build):
>  
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/1356/consoleFull


Ok, now I see it:

  python /opt/llvm/zorg/zorg/jenkins//build.py --assertions 
--cmake-type=Release --cmake-flag=-DLLVM_TARGETS_TO_BUILD=X86 
--cmake-flag=-DLLDB_TEST_USE_CUSTOM_C_COMPILER=On 
--cmake-flag=-DLLDB_TEST_USE_CUSTOM_CXX_COMPILER=On 
--cmake-flag=-DLLDB_TEST_C_COMPILER=/Users/buildslave/jenkins/workspace/lldb-cmake-clang-5.0.2/lldb-build/history/clang-5.0.2/bin/clang
 
--cmake-flag=-DLLDB_TEST_CXX_COMPILER=/Users/buildslave/jenkins/workspace/lldb-cmake-clang-5.0.2/lldb-build/history/clang-5.0.2/bin/clang++
 --dotest-flag=--skip-category --dotest-flag=gmodules lldb-cmake


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D54567#1300064, @zturner wrote:

> In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote:
>
> > In https://reviews.llvm.org/D54567#129, @zturner wrote:
> >
> > > In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote:
> > >
> > > > In https://reviews.llvm.org/D54567#122, @aprantl wrote:
> > > >
> > > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote:
> > > > >
> > > > > > We should also remove LLDB_TEST_C_COMPILER and 
> > > > > > LLDB_TEST_CXX_COMPILER from the cmake files along with this change, 
> > > > > > otherwise, people will still expect them to work.
> > > > >
> > > > >
> > > > > That would not be a good idea. There are several bots that are using 
> > > > > these flags.
> > > >
> > > >
> > > > The change that Zachary is making is removing their usage, so after his 
> > > > change they would not do anything. If he ends up committing this 
> > > > change, these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER 
> > > > and LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.
> > >
> > >
> > > The flags are still needed for (and used by) the dotest suite, I didn't 
> > > change that part.  Normally you run that suite by doing `ninja 
> > > check-lldb`, in which case it never goes through these lit files to begin 
> > > with.  But they will also run as part of `ninja check-lldb-lit`, but that 
> > > lit configuration file totally overrides everything in the parent one, so 
> > > nothing in this patch should have any effect on that.
> >
> >
> > I think this is actually confusing - there are two ways to specify 
> > compilers for the lldb test suite at cmake time:
> >
> > 1. Via LLDB_TEST_USE_CUSTOM_C_COMPILER and friends
> > 2. Via LLDB_TEST_USER_ARGS
> >
> >   As far as I can tell, the ubuntu 14 bot that @aprantl pointed to uses the 
> > LLDB_TEST_USER_ARGS path. I *think* the green dragon bots also use the 
> > LLDB_TEST_USER_ARGS and AFAIK it's the only way gcc is ever specified for 
> > the tests. If the LLDB_TEST_USE_CUSTOM_C_COMPILER and friends are not used 
> > for the lit tests, I don't think we need them for the suite tests.
>
>
> You're right that it's confusing, but I don't have any good ideas here.  Some 
> ideas (which are not necessarily good):
>
> - We could change the names of `LLDB_TEST_C_COMPILER` and 
> `LLDB_TEST_CXX_COMPILER` to `LLDB_DOTEST_C_COMPILER` and 
> `LLDB_DOTEST_CXX_COMPILER`.
> - We could restructure the directories under `lldb/lit` so that it looks like 
> this:
>
>   ``` lldb \- lit |- tests |- unittests \- dotest ```
> - We could get rid of the lit folder entirely, and put everythign in the 
> tests folder, like this: ``` lldb \- test |- lit |- unittests \- dotest ```
>
>   Maybe some combinatino of these (or other ideas that others have) can make 
> things clearer.  But I don't want to change too much all at once.


I actually think we should remove it entirely and rely on LLDB_USER_TEST_ARGS 
because it allows for the user to specify exactly which compiler to use for the 
lldb suite and it only gives the user one way to do it (instead of two which 
magically get merged for the lldb suite).

In the cmake for the tests, this is what we do:

  list(APPEND LLDB_TEST_COMMON_ARGS
--executable ${LLDB_TEST_EXECUTABLE}
--dsymutil ${LLDB_TEST_DSYMUTIL}
--filecheck ${LLDB_TEST_FILECHECK}
-C ${LLDB_TEST_C_COMPILER}
)

so setting the LLDB_TEST_C_COMPILER is the equivalent of passing ```-c 
\path\to\compiler``` as part of the LLDB_TEST_USER_ARGS. Also, we don't 
actually use the LLDB_TEST_CXX_COMPILER for the lldb suite at all.


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.



> That said, in the interest of not changing too much all at once, it still 
> seems like something that's perhaps better done in a future patch.  WDYT?

I actually think it would be better now - the people who use the properties for 
compile the lit tests will have to make a change now anyway and those are most 
likely the same people that use the properties to compile the lldb suite tests, 
so they could make a change once and have both working rather than making it a 
two-step process.


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

Feel free to check this in. At this point this will only improve the results on 
Windows and it works correctly on Linux.




Comment at: lldb/lit/SymbolFile/PDB/class-layout.test:1
-REQUIRES: system-windows
-RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o 
%T/ClassLayoutTest.cpp.obj
-RUN: link %T/ClassLayoutTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main 
/OUT:%T/ClassLayoutTest.cpp.exe
+REQUIRES: msvc
+RUN: %clang_cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o 
%T/ClassLayoutTest.cpp.obj

Why only msvc and not system-windows like the rest of the tests?


https://reviews.llvm.org/D54567



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: aprantl, zturner.
Herald added subscribers: lldb-commits, teemperor.

In order to invoke sed on Windows, we need to quote the command correctly. 
Since we already have commands which do that, move the definitions at the 
beginning of the file and then re-use them for each command.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54709

Files:
  packages/Python/lldbsuite/test/make/Makefile.rules

Index: packages/Python/lldbsuite/test/make/Makefile.rules
===
--- packages/Python/lldbsuite/test/make/Makefile.rules
+++ packages/Python/lldbsuite/test/make/Makefile.rules
@@ -60,6 +60,22 @@
 	SHELL = $(WINDIR)\system32\cmd.exe
 endif
 
+#--
+# If the OS is Windows use double-quotes in commands
+#
+# For other operating systems, single-quotes work fine, but on Windows
+# we strictly required double-quotes
+#--
+ifeq "$(HOST_OS)" "Windows_NT"
+	JOIN_CMD = &
+	QUOTE = "
+	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = "
+else
+	JOIN_CMD = ;
+	QUOTE = '
+	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = '
+endif
+
 #--
 # If TRIPLE is not defined try to set the ARCH, CC, CFLAGS, and more
 # from the triple alone
@@ -74,8 +90,8 @@
 	TRIPLE_VERSION =$(word 2, $(triple_os_and_version))
 	ifeq "$(TRIPLE_VENDOR)" "apple"
 		ifeq "$(TRIPLE_OS)" "ios"
-		CODESIGN := codesign
-		ifeq "$(SDKROOT)" ""
+			CODESIGN := codesign
+			ifeq "$(SDKROOT)" ""
 # Set SDKROOT if it wasn't set
 ifneq (,$(findstring arm,$(ARCH)))
 	SDKROOT = $(shell xcrun --sdk iphoneos --show-sdk-path)
@@ -253,12 +269,7 @@
 endif
 
 # Use a shared module cache when building in the default test build directory.
-ifeq "$(OS)" "Windows_NT"
-CLANG_MODULE_CACHE_DIR := $(BUILDDIR)/module-cache
-else
-# FIXME: Get sed to work on Windows here.
-CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed 's/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/')
-endif
+CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed $(QUOTE)s/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/$(QUOTE))
 
 ifeq "$(findstring lldb-test-build.noindex, $(BUILDDIR))" ""
 CLANG_MODULE_CACHE_DIR := $(BUILDDIR)/module-cache
@@ -343,7 +354,7 @@
 endif
 
 ifdef PIE
-LDFLAGS += -pie
+	LDFLAGS += -pie
 endif
 
 #--
@@ -408,17 +419,17 @@
 endif
 
 ifneq "$(strip $(DYLIB_CXX_SOURCES))" ""
-DYLIB_OBJECTS +=$(strip $(DYLIB_CXX_SOURCES:.cpp=.o))
-CXX = $(call cxx_compiler,$(CC))
-LD = $(call cxx_linker,$(CC))
+	DYLIB_OBJECTS +=$(strip $(DYLIB_CXX_SOURCES:.cpp=.o))
+	CXX = $(call cxx_compiler,$(CC))
+	LD = $(call cxx_linker,$(CC))
 endif
 
 #--
 # Check if we have a precompiled header
 #--
 ifneq "$(strip $(PCH_CXX_SOURCE))" ""
-PCH_OUTPUT = $(PCH_CXX_SOURCE:.h=.h.pch)
-PCHFLAGS = -include $(PCH_CXX_SOURCE)
+	PCH_OUTPUT = $(PCH_CXX_SOURCE:.h=.h.pch)
+	PCHFLAGS = -include $(PCH_CXX_SOURCE)
 endif
 
 #--
@@ -500,21 +511,21 @@
 ifneq "$(filter g++,$(CXX))" ""
 	CXXVERSION = $(shell $(CXX) -dumpversion | cut -b 1-3)
 	ifeq "$(CXXVERSION)" "4.6"
-# GCC 4.6 cannot handle -std=c++11, so replace it with -std=c++0x
-# instead. FIXME: remove once GCC version is upgraded.
+		# GCC 4.6 cannot handle -std=c++11, so replace it with -std=c++0x
+		# instead. FIXME: remove once GCC version is upgraded.
 		override CXXFLAGS := $(subst -std=c++11,-std=c++0x,$(CXXFLAGS))
 	endif
 endif
 endif
 
 ifeq ($(findstring clang, $(CXX)), clang)
-  CXXFLAGS += --driver-mode=g++
+	CXXFLAGS += --driver-mode=g++
 endif
 
 ifneq "$(CXX)" ""
-  ifeq ($(findstring clang, $(LD)), clang)
-LDFLAGS += --driver-mode=g++
-  endif
+	ifeq ($(findstring clang, $(LD)), clang)
+		LDFLAGS += --driver-mode=g++
+	endif
 endif
 
 #--
@@ -628,16 +639,6 @@
 # the compiler -MM option. The -M option will list all system headers,
 # and the -MM option will list all non-system dependencies.
 #--
-ifeq "$(HOST_OS)" "Windows_NT"
-	JOIN_CMD = &
-	QUOTE = "
-	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = "
-else
-	JOIN_CMD = ;
-	QUOTE = '
-	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = '
-endif
-
 %.d: %.c
 	@rm -f $@ $(JOIN_CMD) \
 	$(CC) -M $(CFLAGS) $< > $@.tmp && \
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D54709: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347243: [lldbsuite] Invoke sed on Windows to determine the 
cache dir for clang (authored by stella.stamenova, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D54709?vs=174630&id=174649#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D54709

Files:
  lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules

Index: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
===
--- lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
+++ lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -61,6 +61,22 @@
 endif
 
 #--
+# If the OS is Windows use double-quotes in commands
+#
+# For other operating systems, single-quotes work fine, but on Windows
+# we strictly required double-quotes
+#--
+ifeq "$(HOST_OS)" "Windows_NT"
+	JOIN_CMD = &
+	QUOTE = "
+	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = "
+else
+	JOIN_CMD = ;
+	QUOTE = '
+	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = '
+endif
+
+#--
 # If TRIPLE is not defined try to set the ARCH, CC, CFLAGS, and more
 # from the triple alone
 #--
@@ -74,8 +90,8 @@
 	TRIPLE_VERSION =$(word 2, $(triple_os_and_version))
 	ifeq "$(TRIPLE_VENDOR)" "apple"
 		ifeq "$(TRIPLE_OS)" "ios"
-		CODESIGN := codesign
-		ifeq "$(SDKROOT)" ""
+			CODESIGN := codesign
+			ifeq "$(SDKROOT)" ""
 # Set SDKROOT if it wasn't set
 ifneq (,$(findstring arm,$(ARCH)))
 	SDKROOT = $(shell xcrun --sdk iphoneos --show-sdk-path)
@@ -253,12 +269,7 @@
 endif
 
 # Use a shared module cache when building in the default test build directory.
-ifeq "$(OS)" "Windows_NT"
-CLANG_MODULE_CACHE_DIR := $(BUILDDIR)/module-cache
-else
-# FIXME: Get sed to work on Windows here.
-CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed 's/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/')
-endif
+CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed $(QUOTE)s/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/$(QUOTE))
 
 ifeq "$(findstring lldb-test-build.noindex, $(BUILDDIR))" ""
 CLANG_MODULE_CACHE_DIR := $(BUILDDIR)/module-cache
@@ -343,7 +354,7 @@
 endif
 
 ifdef PIE
-LDFLAGS += -pie
+	LDFLAGS += -pie
 endif
 
 #--
@@ -408,17 +419,17 @@
 endif
 
 ifneq "$(strip $(DYLIB_CXX_SOURCES))" ""
-DYLIB_OBJECTS +=$(strip $(DYLIB_CXX_SOURCES:.cpp=.o))
-CXX = $(call cxx_compiler,$(CC))
-LD = $(call cxx_linker,$(CC))
+	DYLIB_OBJECTS +=$(strip $(DYLIB_CXX_SOURCES:.cpp=.o))
+	CXX = $(call cxx_compiler,$(CC))
+	LD = $(call cxx_linker,$(CC))
 endif
 
 #--
 # Check if we have a precompiled header
 #--
 ifneq "$(strip $(PCH_CXX_SOURCE))" ""
-PCH_OUTPUT = $(PCH_CXX_SOURCE:.h=.h.pch)
-PCHFLAGS = -include $(PCH_CXX_SOURCE)
+	PCH_OUTPUT = $(PCH_CXX_SOURCE:.h=.h.pch)
+	PCHFLAGS = -include $(PCH_CXX_SOURCE)
 endif
 
 #--
@@ -500,21 +511,21 @@
 ifneq "$(filter g++,$(CXX))" ""
 	CXXVERSION = $(shell $(CXX) -dumpversion | cut -b 1-3)
 	ifeq "$(CXXVERSION)" "4.6"
-# GCC 4.6 cannot handle -std=c++11, so replace it with -std=c++0x
-# instead. FIXME: remove once GCC version is upgraded.
+		# GCC 4.6 cannot handle -std=c++11, so replace it with -std=c++0x
+		# instead. FIXME: remove once GCC version is upgraded.
 		override CXXFLAGS := $(subst -std=c++11,-std=c++0x,$(CXXFLAGS))
 	endif
 endif
 endif
 
 ifeq ($(findstring clang, $(CXX)), clang)
-  CXXFLAGS += --driver-mode=g++
+	CXXFLAGS += --driver-mode=g++
 endif
 
 ifneq "$(CXX)" ""
-  ifeq ($(findstring clang, $(LD)), clang)
-LDFLAGS += --driver-mode=g++
-  endif
+	ifeq ($(findstring clang, $(LD)), clang)
+		LDFLAGS += --driver-mode=g++
+	endif
 endif
 
 #--
@@ -628,16 +639,6 @@
 # the compiler -MM option. The -M option will list all system headers,
 # and the -MM option will list all non-system dependencies.
 #--
-ifeq "$(HOST_OS)" "Windows_NT"
-	JOIN_CMD = &
-	QUOTE = "
-	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = "
-else
-	JOIN_CMD = ;
-	QUOTE = '
-	FIXUP_SYNTAX_HIGHLIGHTING_IN_MY_EDITOR = '
-endif
-
 %.d: %.c
 	@rm -f $@ $(JOIN_CMD) \
 	$(CC) -M $(CFLAGS) $< > $@.tmp && \
__

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

LGTM as long as the tests are all still passing :)


https://reviews.llvm.org/D54731



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: labath, zturner, asmith.
Herald added subscribers: lldb-commits, jfb.

Right now only some platforms add pthread to the compilation, however, at least 
one of the tests requires the pthread library on Linux as well. Since the 
library is available, this change adds it by default on Linux.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54808

Files:
  lit/helper/toolchain.py


Index: lit/helper/toolchain.py
===
--- lit/helper/toolchain.py
+++ lit/helper/toolchain.py
@@ -78,7 +78,7 @@
 sdk_path = lit.util.to_string(out)
 lit_config.note('using SDKROOT: %r' % sdk_path)
 flags = ['-isysroot', sdk_path]
-elif platform.system() in ['OpenBSD']:
+elif platform.system() in ['OpenBSD', 'Linux']:
 flags = ['-pthread']
 
 


Index: lit/helper/toolchain.py
===
--- lit/helper/toolchain.py
+++ lit/helper/toolchain.py
@@ -78,7 +78,7 @@
 sdk_path = lit.util.to_string(out)
 lit_config.note('using SDKROOT: %r' % sdk_path)
 flags = ['-isysroot', sdk_path]
-elif platform.system() in ['OpenBSD']:
+elif platform.system() in ['OpenBSD', 'Linux']:
 flags = ['-pthread']
 
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

[Stella Stamenova via Phabricator via lldb-commits]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347412: [lit] Add pthread to the compilation of the tests on 
Linux (authored by stella.stamenova, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D54808?vs=174962&id=174964#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D54808

Files:
  lldb/trunk/lit/helper/toolchain.py


Index: lldb/trunk/lit/helper/toolchain.py
===
--- lldb/trunk/lit/helper/toolchain.py
+++ lldb/trunk/lit/helper/toolchain.py
@@ -78,7 +78,7 @@
 sdk_path = lit.util.to_string(out)
 lit_config.note('using SDKROOT: %r' % sdk_path)
 flags = ['-isysroot', sdk_path]
-elif platform.system() in ['OpenBSD']:
+elif platform.system() in ['OpenBSD', 'Linux']:
 flags = ['-pthread']
 
 


Index: lldb/trunk/lit/helper/toolchain.py
===
--- lldb/trunk/lit/helper/toolchain.py
+++ lldb/trunk/lit/helper/toolchain.py
@@ -78,7 +78,7 @@
 sdk_path = lit.util.to_string(out)
 lit_config.note('using SDKROOT: %r' % sdk_path)
 flags = ['-isysroot', sdk_path]
-elif platform.system() in ['OpenBSD']:
+elif platform.system() in ['OpenBSD', 'Linux']:
 flags = ['-pthread']
 
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This looks fine, but let's see if Zachary's change lands first and how it looks 
like after it lands :).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54942/new/

https://reviews.llvm.org/D54942



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I ran the tests with this change and there are about a dozen new failures:

  2018-11-28T20:25:29.2437909Z  
  2018-11-28T20:25:29.2581909Z  FAIL: LLDB :: 
SymbolFile/NativePDB/function-types-builtins.cpp (16962 of 45532)
  2018-11-28T20:25:29.2593650Z   TEST 'LLDB :: 
SymbolFile/NativePDB/function-types-builtins.cpp' FAILED 
  2018-11-28T20:25:29.2627299Z  Script:
  2018-11-28T20:25:29.2627541Z  --
  2018-11-28T20:25:29.2628080Z  : 'RUN: at line 4';   C:\Program Files 
(x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe 
E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py --compiler=any --arch=64 
--tools-dir=E:/_work/80/b/LLVMBuild/Release/bin --compiler=clang-cl 
--nodefaultlib -o 
E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe
 -- 
E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp
  2018-11-28T20:25:29.2629494Z  : 'RUN: at line 5';   env 
LLDB_USE_NATIVE_PDB_READER=1 E:\_work\80\b\LLVMBuild\Release\bin\lldb.EXE -S 
E:/_work/80/s/llvm/tools/lldb/lit\lit-lldb-init -f 
E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe
 -s  
E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/function-types-builtins.lldbinit
 | E:\_work\80\b\LLVMBuild\Release\bin\FileCheck.EXE 
E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp
  2018-11-28T20:25:29.2629805Z  --
  2018-11-28T20:25:29.2629901Z  Exit Code: 127
  2018-11-28T20:25:29.2630016Z  
  2018-11-28T20:25:29.2630140Z  Command Output (stdout):
  2018-11-28T20:25:29.2630258Z  --
  2018-11-28T20:25:29.2630427Z  $ ":" "RUN: at line 4"
  2018-11-28T20:25:29.2630915Z  $ "C:\Program" "Files" 
"(x86)\Microsoft" "Visual" "Studio\Shared\Python36_64\python.exe" 
"E:\_work\80\s\llvm\tools\lldb\lit\helper\build.py" "--compiler=any" 
"--arch=64" "--tools-dir=E:/_work/80/b/LLVMBuild/Release/bin" 
"--compiler=clang-cl" "--nodefaultlib" "-o" 
"E:\_work\80\b\LLVMBuild\tools\lldb\lit\SymbolFile\NativePDB\Output\function-types-builtins.cpp.tmp.exe"
 "--" 
"E:\_work\80\s\llvm\tools\lldb\lit\SymbolFile\NativePDB\function-types-builtins.cpp"
  2018-11-28T20:25:29.2631273Z  # command stderr:
  2018-11-28T20:25:29.2631382Z  'C:\\Program': command not found

It looks like the script doesn't handle paths that have spaces correctly. I 
think the issue is on line 45 where we add sys.executable as the command - we 
need quotes around that. I'm going to rerun the tests with that change to see 
the result.




Comment at: lldb/lit/helper/toolchain.py:45
+ToolSubst('%build',
+  command=sys.executable,
+  extra_args=build_script_args)

I think this is where we need quotes around sys.executable, so that if the path 
contains spaces it is handled correctly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54914/new/

https://reviews.llvm.org/D54914



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It works for me when you make the command:

  command='"%s"' % (sys.executable),

I haven't tested it on Linux yet, but the tests work fine on Windows.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54914/new/

https://reviews.llvm.org/D54914



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It looks like after this change went in, the tests on Windows starting timing 
out instead of completing. The last run before the change took about 2 minutes 
and starting with the first run with this change, they're running for 40 
minutes before being killed:

After:
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1774

Before:
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1773

Can you fix this today or pull the change out?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53759/new/

https://reviews.llvm.org/D53759



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

One of these tests fail on Windows:


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55038/new/

https://reviews.llvm.org/D55038



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lldb/lit/helper/build.py:664
+if args.output and args.mode == 'compile' and len(args.inputs) > 1:
+raise ValueError('Cannot specify -o with mode=compile and multiple 
source files.  Use --outdir instead.')
+

Why not? It makes sense that the test might still need to know and/or specify 
the name of the binary that was produced. The script could require that both -o 
and --outdir are specified, but I think -o is still needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55230/new/

https://reviews.llvm.org/D55230



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

LLDB :: BuildScript/toolchain-clang-cl.test is failing on Linux.

  2018-12-05T17:59:42.1570845Z Command Output (stderr):
  2018-12-05T17:59:42.1582271Z --
  2018-12-05T17:59:42.1593369Z Traceback (most recent call last):
  2018-12-05T17:59:42.1604689Z   File 
"/home/e2admin/vstsdrive/_work/51/s/llvm/tools/lldb/lit/helper/build.py", line 
723, in 
  2018-12-05T17:59:42.1615962Z build(cmds)
  2018-12-05T17:59:42.1627379Z   File 
"/home/e2admin/vstsdrive/_work/51/s/llvm/tools/lldb/lit/helper/build.py", line 
621, in build
  2018-12-05T17:59:42.1794738Z print_environment(env)
  2018-12-05T17:59:42.1806250Z   File 
"/home/e2admin/vstsdrive/_work/51/s/llvm/tools/lldb/lit/helper/build.py", line 
154, in print_environment
  2018-12-05T17:59:42.1817473Z for e in env:
  2018-12-05T17:59:42.1837821Z TypeError: 'NoneType' object is not iterable
  2018-12-05T17:59:42.1850161Z 
/home/e2admin/vstsdrive/_work/51/s/llvm/tools/lldb/lit/BuildScript/toolchain-clang-cl.test:13:11:
 error: CHECK-32: expected string not found in input
  2018-12-05T17:59:42.1861865Z CHECK-32: Output: 
{{.*}}toolchain-clang-cl.test.tmp\foo.exe
  2018-12-05T17:59:42.1872878Z   ^
  2018-12-05T17:59:42.1883892Z :5:2: note: scanning from here
  2018-12-05T17:59:42.1895337Z  Output: 
/home/e2admin/vstsdrive/_work/51/b/LLVMBuild/tools/lldb/lit/BuildScript/Output/toolchain-clang-cl.test.tmp/foo.exe
  2018-12-05T17:59:42.1906629Z  ^
  2018-12-05T17:59:42.1917610Z :5:82: note: possible intended match here
  2018-12-05T17:59:42.1929075Z  Output: 
/home/e2admin/vstsdrive/_work/51/b/LLVMBuild/tools/lldb/lit/BuildScript/Output/toolchain-clang-cl.test.tmp/foo.exe
  2018-12-05T17:59:42.1940723Z  
^
  2018-12-05T17:59:42.1946391Z 
  2018-12-05T17:59:42.1957310Z --


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55230/new/

https://reviews.llvm.org/D55230



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

enums-layout.test is now failing on Windows:

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1938/steps/test/logs/stdio


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54942/new/

https://reviews.llvm.org/D54942



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
-   --targetDir=${LLDB_PYTHON_TARGET_DIR}
-   --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+   --targetDir=$
+   --cfgBldDir=$

I have a vague recollection that using TARGET_PROPERTY didn't work for some 
changes I was working on a few months ago, but I don't remember the details. It 
would be good to make sure that this works on mac, linux and windows all before 
you commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55332/new/

https://reviews.llvm.org/D55332



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: labath, asmith.
Herald added a subscriber: lldb-commits.

Instead use a more reasonable value to start and rely on the fact that 
SmallString will resize if necessary.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D55457

Files:
  source/Commands/CommandCompletions.cpp
  source/Commands/CommandObjectPlatform.cpp
  source/Host/common/Host.cpp
  source/Host/posix/PipePosix.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Target/ProcessInfo.cpp

Index: source/Target/ProcessInfo.cpp
===
--- source/Target/ProcessInfo.cpp
+++ source/Target/ProcessInfo.cpp
@@ -63,7 +63,7 @@
   if (exe_file) {
 m_executable = exe_file;
 if (add_exe_file_as_first_arg) {
-  llvm::SmallString filename;
+  llvm::SmallString<128> filename;
   exe_file.GetPath(filename);
   if (!filename.empty())
 m_arguments.InsertArgumentAtIndex(0, filename);
Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
@@ -538,8 +538,8 @@
 
 FileSpec
 GDBRemoteCommunicationServerPlatform::GetDomainSocketPath(const char *prefix) {
-  llvm::SmallString socket_path;
-  llvm::SmallString socket_name(
+  llvm::SmallString<128> socket_path;
+  llvm::SmallString<128> socket_name(
   (llvm::StringRef(prefix) + ".%%").str());
 
   FileSpec socket_path_spec(GetDomainSocketDir());
Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
@@ -1011,7 +1011,7 @@
   debugserver_args.AppendArgument(llvm::StringRef("--setsid"));
 }
 
-llvm::SmallString named_pipe_path;
+llvm::SmallString<128> named_pipe_path;
 // socket_pipe is used by debug server to communicate back either
 // TCP port or domain socket name which it listens on.
 // The second purpose of the pipe to serve as a synchronization point -
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
===
--- source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -889,7 +889,7 @@
 // At this moment we only have the base name of the DLL. The full path can
 // only be seen after the dynamic loading.  Our best guess is Try to get it
 // with the help of the object file's directory.
-llvm::SmallString dll_fullpath;
+llvm::SmallString<128> dll_fullpath;
 FileSpec dll_specs(dll_name);
 dll_specs.GetDirectory().SetString(m_file.GetDirectory().GetCString());
 
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -832,7 +832,7 @@
 
   if (should_create_file) {
 int temp_fd = -1;
-llvm::SmallString result_path;
+llvm::SmallString<128> result_path;
 if (FileSpec tmpdir_file_spec = HostInfo::GetProcessTempDir()) {
   tmpdir_file_spec.AppendPathComponent("lldb-%%.expr");
   std::string temp_source_path = tmpdir_file_spec.GetPath();
Index: source/Host/posix/PipePosix.cpp
===
--- source/Host/posix/PipePosix.cpp
+++ source/Host/posix/PipePosix.cpp
@@ -125,8 +125,8 @@
 Status PipePosix::CreateWithUniqueName(llvm::StringRef prefix,
bool child_process_inherit,
llvm::SmallVectorImpl &name) {
-  llvm::SmallString named_pipe_path;
-  llvm::SmallString pipe_spec((prefix + ".%%").str());
+  llvm::SmallString<128> named_pipe_path;
+  llvm::SmallString<128> pipe_spec((prefix + ".%%").str());
   FileSpec tmpdir_file_spec = HostInfo::GetProcessTempDir();
   if (!tmpdir_file_spec)
 tmpdir_file_spec.AppendPathComponent("/tmp");
Index: source/Host/common/Host.cpp
===
--- source/Host/common/Host.cpp
+++ source/Host/common/Host.cpp
@@ -496,7 +496,7 @@
 
   if (working_dir)
 launch_info.SetWorkingDirectory(working_dir);
-  llvm::SmallString output_file_path;
+  llvm::SmallString<64> output_file_path;
 
   if (command_output_ptr) {
 // Create a 

[Lldb-commits] [PATCH] D55457: Do not use PATH_MAX with SmallString

[Stella Stamenova via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB348775: Do not use PATH_MAX with SmallString (authored by 
stella.stamenova, committed by ).

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55457/new/

https://reviews.llvm.org/D55457

Files:
  source/Commands/CommandCompletions.cpp
  source/Commands/CommandObjectPlatform.cpp
  source/Host/common/Host.cpp
  source/Host/posix/PipePosix.cpp
  source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Target/ProcessInfo.cpp

Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
@@ -1011,7 +1011,7 @@
   debugserver_args.AppendArgument(llvm::StringRef("--setsid"));
 }
 
-llvm::SmallString named_pipe_path;
+llvm::SmallString<128> named_pipe_path;
 // socket_pipe is used by debug server to communicate back either
 // TCP port or domain socket name which it listens on.
 // The second purpose of the pipe to serve as a synchronization point -
Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
===
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
@@ -538,8 +538,8 @@
 
 FileSpec
 GDBRemoteCommunicationServerPlatform::GetDomainSocketPath(const char *prefix) {
-  llvm::SmallString socket_path;
-  llvm::SmallString socket_name(
+  llvm::SmallString<128> socket_path;
+  llvm::SmallString<128> socket_name(
   (llvm::StringRef(prefix) + ".%%").str());
 
   FileSpec socket_path_spec(GetDomainSocketDir());
Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
===
--- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
+++ source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
@@ -832,7 +832,7 @@
 
   if (should_create_file) {
 int temp_fd = -1;
-llvm::SmallString result_path;
+llvm::SmallString<128> result_path;
 if (FileSpec tmpdir_file_spec = HostInfo::GetProcessTempDir()) {
   tmpdir_file_spec.AppendPathComponent("lldb-%%.expr");
   std::string temp_source_path = tmpdir_file_spec.GetPath();
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
===
--- source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -889,7 +889,7 @@
 // At this moment we only have the base name of the DLL. The full path can
 // only be seen after the dynamic loading.  Our best guess is Try to get it
 // with the help of the object file's directory.
-llvm::SmallString dll_fullpath;
+llvm::SmallString<128> dll_fullpath;
 FileSpec dll_specs(dll_name);
 dll_specs.GetDirectory().SetString(m_file.GetDirectory().GetCString());
 
Index: source/Commands/CommandCompletions.cpp
===
--- source/Commands/CommandCompletions.cpp
+++ source/Commands/CommandCompletions.cpp
@@ -116,7 +116,7 @@
 if (FirstSep != llvm::StringRef::npos)
   Remainder = Buffer.drop_front(FirstSep + 1);
 
-llvm::SmallString Resolved;
+llvm::SmallString<256> Resolved;
 if (!Resolver.ResolveExact(Username, Resolved)) {
   // We couldn't resolve it as a full username.  If there were no slashes
   // then this might be a partial username.   We try to resolve it as such
Index: source/Commands/CommandObjectPlatform.cpp
===
--- source/Commands/CommandObjectPlatform.cpp
+++ source/Commands/CommandObjectPlatform.cpp
@@ -1038,7 +1038,7 @@
   Module *exe_module = target->GetExecutableModulePointer();
   if (exe_module) {
 m_options.launch_info.GetExecutableFile() = exe_module->GetFileSpec();
-llvm::SmallString exe_path;
+llvm::SmallString<128> exe_path;
 m_options.launch_info.GetExecutableFile().GetPath(exe_path);
 if (!exe_path.empty())
   m_options.launch_info.GetArguments().AppendArgument(exe_path);
Index: source/Host/common/Host.cpp
===
--- source/Host/common/Host.cpp
+++ source/Host/common/Host.cpp
@@ -496,7 +496,7 @@
 
   if (working_dir)
 launch_info.SetWorkingDirectory(working_dir);
-  llvm::SmallString output_file_path;
+  llvm::SmallString<64> output_file_path

[Lldb-commits] [PATCH] D55569: [lit] Add a basic implementation of build for GccBuilder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: zturner, asmith.
Herald added subscribers: lldb-commits, abidh.

This adds an implementation for compile as well as compile-and-link, but not 
link. For compile-and-link we rely on clang to orchestrate both similarly to 
how the tests use it today.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D55569

Files:
  lit/BuildScript/modes-nonwin.test
  lit/BuildScript/modes-win.test
  lit/BuildScript/modes.test
  lit/BuildScript/script-args.test
  lit/helper/build.py

Index: lit/helper/build.py
===
--- lit/helper/build.py
+++ lit/helper/build.py
@@ -151,11 +151,14 @@
 return result
 
 def print_environment(env):
-for e in env:
-value = env[e]
-lines = value.split(os.pathsep)
-formatted_value = format_text(lines, 0, 7 + len(e))
-print('{0} = {1}'.format(e, formatted_value))
+if env:
+for e in env:
+value = env[e]
+lines = value.split(os.pathsep)
+formatted_value = format_text(lines, 0, 7 + len(e))
+print('{0} = {1}'.format(e, formatted_value))
+else:
+print('No environment specified')
 
 def find_executable(binary_name, search_paths):
 if sys.platform == 'win32':
@@ -604,11 +607,108 @@
 def __init__(self, toolchain_type, args):
 Builder.__init__(self, toolchain_type, args)
 
+def _output_name(self, input, extension, with_executable=False):
+basename = os.path.splitext(os.path.basename(input))[0] + extension
+if with_executable:
+exe_basename = os.path.basename(self._exe_file_name())
+basename = exe_basename + '-' + basename
+
+output = os.path.join(self.outdir, basename)
+return os.path.normpath(output)
+
+def _obj_file_names(self):
+if self.mode == 'link':
+return self.inputs
+
+if self.mode == 'compile-and-link':
+# Object file names should factor in both the input file (source)
+# name and output file (executable) name, to ensure that two tests
+# which share a common source file don't race to write the same
+# object file.
+return [self._output_name(x, '.o', True) for x in self.inputs]
+
+if self.mode == 'compile' and self.output:
+return [self.output]
+
+return [self._output_name(x, '.o') for x in self.inputs]
+
+def _exe_file_name(self):
+if self.mode == 'compile':
+return None
+return self.output
+
+def _get_compilation_command(self, source, obj):
+args = []
+
+args.append(self.compiler)
+
+if self.opt == 'none':
+args.append('-O0')
+elif self.opt == 'basic':
+args.append('-O2')
+elif self.opt == 'lto':
+args.append('-flto=thin')
+
+args.append('-c')
+args.append('-g')
+args.append('-o' + obj)
+args.append(source)
+
+return ('compiling', [source], obj,
+None,
+args)
+
+def _get_compile_and_link_command(self):
+args = []
+
+args.append(self.compiler)
+
+if self.opt == 'none':
+args.append('-O0')
+elif self.opt == 'basic':
+args.append('-O2')
+elif self.opt == 'lto':
+args.append('-flto=thin')
+
+args.append('-g')
+args.append('-o' + self._exe_file_name())
+args.extend(self.inputs)
+
+return ('compiling and linking', self.inputs, self._exe_file_name(),
+None,
+args)
+
+def _get_link_command(self):
+args = []
+args.append('echo linking only not supported')
+
+return ('linking', self._obj_file_names(), self._exe_file_name(),
+None,
+args)
+
 def build_commands(self):
-pass
+commands = []
+if self.mode == 'compile':
+for input, output in zip(self.inputs, self._obj_file_names()):
+commands.append(self._get_compilation_command(input, output))
+if self.mode == 'compile-and-link':
+commands.append(self._get_compile_and_link_command())
+if self.mode == 'link':
+commands.append(self._get_link_command())
+return commands
 
 def output_files(self):
-pass
+outdir = os.path.dirname(self.output)
+file = os.path.basename(self.output)
+name, ext = os.path.splitext(file)
+
+outputs = []
+if self.mode == 'compile' or self.mode == 'compile-and-link':
+outputs.extend(self._obj_file_names())
+if self.mode == 'link' or self.mode == 'compile-and-link':
+outputs.append(self._exe_file_name())
+
+return [x for x in outputs if x is not None]
 
 def indent(text, spaces):
 def prefixed_lines():
Index: lit

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

A couple of small comments, but it looks good otherwise. Thanks!




Comment at: lit/BuildScript/toolchain-clang.test:1
+RUN: %build -n --verbose --arch=32 --compiler=clang --mode=compile-and-link -o 
%t/foo.exe foobar.c \
+RUN:| FileCheck --check-prefix=CHECK --check-prefix=CHECK-32 %s

There are a couple of tests for the build script that we should enable on 
non-windows as well:
* script-args
* modes
Both should pass with your change



Comment at: lit/helper/build.py:627
+elif self.opt == 'lto':
+raise NotImplementedError("LTO not implemented in gcc builder")
+if self.nodefaultlib:

You can just add the thinlto command here. That should give you parity with the 
msvc builder:

args.append('-flto=thin')





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55430/new/

https://reviews.llvm.org/D55430



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55569: [lit] Add a basic implementation of build for GccBuilder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova abandoned this revision.
stella.stamenova added a comment.

Let's use @labath's change instead.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55569/new/

https://reviews.llvm.org/D55569



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

local-variables.cpp is failing on the Buildbot:

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2255/steps/test/logs/stdio


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55575/new/

https://reviews.llvm.org/D55575



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

  $ ":" "RUN: at line 5"
  $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\lldb.EXE" "-S" 
"E:/build_slave/lldb-x64-windows-ninja/llvm/tools/lldb/lit\lit-lldb-init" "-f" 
"E:\build_slave\lldb-x64-windows-ninja\build\tools\lldb\lit\SymbolFile\NativePDB\Output\local-variables.cpp.tmp.exe"
 "-s" 
"E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB/Inputs/local-variables.lldbinit"
  $ "E:\build_slave\lldb-x64-windows-ninja\build\bin\FileCheck.EXE" 
"E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp"
  # command stderr:
  
E:\build_slave\lldb-x64-windows-ninja\llvm\tools\lldb\lit\SymbolFile\NativePDB\local-variables.cpp:154:16:
 error: CHECK-NEXT: expected string not found in input
  
  // CHECK-NEXT: Dumping clang ast for 7 modules.
  
 ^
  
  :140:1: note: scanning from here
  
  Dumping clang ast for 8 modules.
  
  ^
  
  
  error: command failed with exit status: 1


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55575/new/

https://reviews.llvm.org/D55575



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I am trying to use the new builder to build the lldb-mi tests, so that they can 
start consistently passing on Windows, so they're now using the gcc builder on 
Linux and failing:

  2018-12-14T19:24:41.8890855Z 
  2018-12-14T19:24:41.8904193Z Testing: 0 .. 10.. 20.. 30.
  2018-12-14T19:24:41.8918035Z FAIL: LLDB :: 
tools/lldb-mi/exec/exec-interrupt.test (17141 of 45941)
  2018-12-14T19:24:41.8932384Z  TEST 'LLDB :: 
tools/lldb-mi/exec/exec-interrupt.test' FAILED 
  2018-12-14T19:24:41.8945979Z Script:
  2018-12-14T19:24:41.8959648Z --
  2018-12-14T19:24:41.8974664Z : 'RUN: at line 1';   '/usr/bin/python2.7' 
/vstsdrive/_work/42/s/llvm/tools/lldb/lit/helper/build.py --compiler=any 
--arch=64 --tools-dir=/vstsdrive/_work/42/b/LLVMBuild/./bin 
/vstsdrive/_work/42/s/llvm/tools/lldb/lit/tools/lldb-mi/exec/inputs/main.c 
--nodefaultlib -o 
/vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output/exec-interrupt.test.tmp
  2018-12-14T19:24:41.8991443Z : 'RUN: at line 2';   
/vstsdrive/_work/42/b/LLVMBuild/bin/lldb-mi --synchronous 
/vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output/exec-interrupt.test.tmp
 < 
/vstsdrive/_work/42/s/llvm/tools/lldb/lit/tools/lldb-mi/exec/exec-interrupt.test
 | /vstsdrive/_work/42/b/LLVMBuild/bin/FileCheck 
/vstsdrive/_work/42/s/llvm/tools/lldb/lit/tools/lldb-mi/exec/exec-interrupt.test
  2018-12-14T19:24:41.9006101Z --
  2018-12-14T19:24:41.9019550Z Exit Code: 1
  2018-12-14T19:24:41.9026154Z 
  2018-12-14T19:24:41.9039902Z Command Output (stdout):
  2018-12-14T19:24:41.9053450Z --
  2018-12-14T19:24:41.9066966Z Cleaning exec-interrupt.test.tmp-main.o
  2018-12-14T19:24:41.9081046Z Cleaning exec-interrupt.test.tmp
  2018-12-14T19:24:41.9087711Z 
  2018-12-14T19:24:41.9094525Z 
  2018-12-14T19:24:41.9101310Z 
  2018-12-14T19:24:41.9114993Z compiling main.c -> 
exec-interrupt.test.tmp-main.o
  2018-12-14T19:24:41.9128817Z   STDOUT:
  2018-12-14T19:24:41.9135428Z 
  2018-12-14T19:24:41.9142241Z 
  2018-12-14T19:24:41.9149031Z 
  2018-12-14T19:24:41.9155781Z 
  2018-12-14T19:24:41.9169689Z linking exec-interrupt.test.tmp-main.o -> 
exec-interrupt.test.tmp
  2018-12-14T19:24:41.9183153Z   STDOUT:
  2018-12-14T19:24:41.9190134Z 
  2018-12-14T19:24:41.9203611Z   STDERR:
  2018-12-14T19:24:41.9217412Z clang-8: error: unable to execute command: 
Executable "ld" doesn't exist!
  2018-12-14T19:24:41.9231640Z clang-8: error: linker command failed with 
exit code 1 (use -v to see invocation)
  2018-12-14T19:24:41.9238695Z 
  2018-12-14T19:24:41.9245289Z 
  2018-12-14T19:24:41.9258832Z --


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55430/new/

https://reviews.llvm.org/D55430



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55736: build.py: inherit environment in the gcc builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

This does fix the issues. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55736/new/

https://reviews.llvm.org/D55736



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This change made the Windows test get stuck: 
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2340

They are now being killed after running for 40 minutes instead of completing in 
under 2.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55607/new/

https://reviews.llvm.org/D55607



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In D55607#1334666 , @aprantl wrote:

> Can you confirm that reverting this path actually fixes the issue? I'm asking 
> because the only test that is executing this script has a REQUIRES: 
> system-darwin line in it.


Removing the test does fix the issue. I suspect the problem is the ordering of 
the REQUIRES and RUN lines, but I have not tested it. Regardless, the crashlog 
changes were the only two changes to LLDB in the first build that got stuck 
(there was also an llvm change). Please fix/revert this in the next couple of 
hours as we haven't had a good test run for LLDB on Windows since your change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55607/new/

https://reviews.llvm.org/D55607



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

A bunch of the NativePDB tests are failing on Windows now.

http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/2365/steps/test/logs/stdio


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55384/new/

https://reviews.llvm.org/D55384



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

It looks like this might not be specific to your change as a few other tests 
are failing with a similar error. I'm looking into it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55384/new/

https://reviews.llvm.org/D55384



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I tracked this down - the failures are not due to this change (or any LLDB 
change). It's this change to the common CMake files in LLVM: 
https://reviews.llvm.org/D55056


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55384/new/

https://reviews.llvm.org/D55384



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

While you are at it, can you make sure this works on Windows? The current 
version of the test that is checked in fails.


https://reviews.llvm.org/D47646



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D47646#1119471, @vsk wrote:

> In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote:
>
> > While you are at it, can you make sure this works on Windows? The current 
> > version of the test that is checked in fails.
>
>
> Sorry about that. Could you point me to the error message?


"Cannot use process to test IRMemoryMap"


https://reviews.llvm.org/D47646



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I can look into the failure - but can you XFAIL the test rather than skipping 
it and log a bug, so that we can track the failure rather than potentially 
assuming down the line that the test is not meant for windows?


https://reviews.llvm.org/D47646



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

You can actually follow the pattern in the other tests and do:

  %cc -o %t %p/inputs/break-insert.c -g



  %t``` then becomes the name of the output file and you can use that in our 
other commands. This is better than specifying a hardcoded name.
  
  Having said that, I believe this won't fix the test. If you look at the 
comments of the review when I disabled the test, there is output of what 
happens when you give it the correct name - which is to run until the program 
exits *normally* rather than hitting a breakpoint as the test expects. After 
the program exits normally, lldb-mi just waits and the test will hang. Your 
other change will address the issue of the test hanging when it's given the 
incorrect file name, but I don't think it will fix this case.


Repository:
  rL LLVM

https://reviews.llvm.org/D47679



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote:

> Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL 
> directive for Windows.


Not true. As I said, the original review when I disabled the test has the log 
of what happens when you give it the correct path and the test still hangs in 
that scenario. If you XFAIL it, it will hang.

@aprantl There is currently no public not that runs the tests. The one you 
found just builds but runs no tests. I have a machine I am going to add as a 
bot but there are still a lot of failing tests, so I don’t want to add it yet 
as it will be just noise until the tests are fixed or disabled.

In https://reviews.llvm.org/D47679#1120166, @aprantl wrote:

> Stella, is there a public bot that runs the tests on Windows that we could 
> watch? I found 
> http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015?numbuilds=1000 
> but it doesn't look like that one actually failed with the error you saw.







Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:1
-# REQUIRES: nowindows
+# XFAIL: windows
 # -> llvm.org/pr24452

aprantl wrote:
> Do we still expect the test to fail after this change?
It will still fail and it will still hang.


https://reviews.llvm.org/D47679



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D47679#1120177, @polyakov.alex wrote:

> In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote:
>
> > In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote:
> >
> > > Due to https://reviews.llvm.org/D47678 we can enable this test with a 
> > > XFAIL directive for Windows.
> >
> >
> > Not true. As I said, the original review when I disabled the test has the 
> > log of what happens when you give it the correct path and the test still 
> > hangs in that scenario. If you XFAIL it, it will hang.
>
>
> Yep, I got the same on Linux. But if you run it through llvm-lit(not `lldb-mi 
> < input-file`) it won't hang.


I can apply your change locally on Monday and double-check. You have to 
remember that the behavior of the tools and test suite is not exactly the same 
on Linux and Windows.


https://reviews.llvm.org/D47679



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D47646#1120498, @labath wrote:

> Looks great, thanks for doing this.
>
> As far as windows goes, I believe that there we simply don't have the memory 
> allocation part implemented, so it's not surprising that these tests fail. It 
> may be possible that the host-only tests would work (if you remove the 
> `CanJIT` check in lldb-test), but I can't say that for sure.


I believe you are correct about the implementation - the failure occurs before 
CanJit is even called though, so I don't know if any of the tests can run on 
Windows today.


https://reviews.llvm.org/D47646



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

I stand corrected. The test didn't hang.


https://reviews.llvm.org/D47679



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.



Comment at: lit/tools/lldb-mi/exec/exec-next.test:2
+# XFAIL: windows
+# -> llvm.org/pr24452
+#

aprantl wrote:
> @stella.stemanova: Would be interesting to understand why (/if ?) this 
> doesn't work on windows
I can test it out after it's committed.


https://reviews.llvm.org/D47797



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48665: Added test case for: r334978 - Fixed file completion for paths that start with '~'

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

This test fails on Windows with the Visual Studio generator.

  ##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291,0): 
Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + 
"nested" + path::get_separator(), Results)
  e:\_work\1\s\llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(291): 
error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + 
"nested" + path::get_separator(), Results) 
[E:\_work\1\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]

  Actual: false

Expected: true

   ##[error]llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(297,0): 
Error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + 
"nested" + path::get_separator(), Results)
  e:\_work\1\s\llvm\tools\lldb\unittests\interpreter\testcompletion.cpp(297): 
error : Value of: ContainsExactString(Twine("~/foo") + path::get_separator() + 
"nested" + path::get_separator(), Results) 
[E:\_work\1\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]

  Actual: false

Expected: true

[  FAILED  ] CompletionTest.DirCompletionUsername (1 ms)

[--] 1 test from CompletionTest (1 ms total)


Repository:
  rL LLVM

https://reviews.llvm.org/D48665



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48746: Fix path completion test case added in rL335905 on Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.

The test passes with the fix. Thanks!


https://reviews.llvm.org/D48746



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

symbol-list-lines.test fails on windows. I'm trying to get through the rest of 
the failing tests on Windows, so I can add a bot to run the tests and alert on 
new failures.

   
   FAIL: lldb :: tools/lldb-mi/symbol/symbol-list-lines.test (45 of 
1063)
    TEST 'lldb :: 
tools/lldb-mi/symbol/symbol-list-lines.test' FAILED 
   Script:
   --
   : 'RUN: at line 1';   E:/_work/4/b/LLVMBuild/Release/bin/clang.exe 
-o 
E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp
 E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/main.c 
E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/symbol-list-lines.c
 
E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/list-lines-helper.c
 -g
   : 'RUN: at line 2';   E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE 
--synchronous 
E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp
 < E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test 
| E:\_work\4\b\LLVMBuild\Release\bin\FileCheck.EXE 
E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test
   --
   Exit Code: 1
   
   Command Output (stdout):
   --
   $ ":" "RUN: at line 1"
   $ "E:/_work/4/b/LLVMBuild/Release/bin/clang.exe" "-o" 
"E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp"
 "E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/main.c" 
"E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/symbol-list-lines.c"
 
"E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol/inputs/list-lines-helper.c"
 "-g"
   $ ":" "RUN: at line 2"
   $ "E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE" "--synchronous" 
"E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp"
   $ "E:\_work\4\b\LLVMBuild\Release\bin\FileCheck.EXE" 
"E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test"
   # command stderr:
  
##[error]llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test(14,10):
 Error G8E235623: expected string not found in input
   
3>E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\symbol\symbol-list-lines.test(14,10):
 error G8E235623: expected string not found in input 
[E:\_work\4\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]
   
   # CHECK: 
^done,lines=[{pc="0x{{[0-9A-Fa-f]+}}",line="3"},{pc="0x{{[0-9A-Fa-f]+}}",line="4"},{pc="0x{{[0-9A-Fa-f]+}}",line="5"}]
   
^
   
   :17:1: note: scanning from here
   
   (gdb)
   
   ^


Repository:
  rL LLVM

https://reviews.llvm.org/D48802



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.



  (gdb)
  -file-exec-and-symbols 
"E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp"
  ^done
  (gdb)
  ^done
  (gdb)
  
=library-loaded,id="E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp",target-name="E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp",host-name="E:\\_work\\4\\b\\LLVMBuild\\tools\\lldb\\lit\\tools\\lldb-mi\\symbol\\Output\\symbol-list-lines.test.tmp",symbols-loaded="0",loaded_addr="-",size="0"
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^error,msg="File Handler. Invalid file name path"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^error,msg="File Handler. Invalid file name path"
  (gdb)
  ^done
  (gdb)
  ^error,msg="File Handler. Invalid file name path"
  (gdb)
  ^done
  (gdb)


Repository:
  rL LLVM

https://reviews.llvm.org/D48802



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48960: Use an unwinder to get register contexts of frames other than zeroth under Windows

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I'm actually in the middle of cleaning up the change attached to this bug: 
https://bugs.llvm.org/show_bug.cgi?id=37495 which is equivalent functionally 
but follows the pattern for the other targets. Let me run some tests and I'll 
submit it for review. It should fix your issue.


https://reviews.llvm.org/D48960



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I am not 100% sure that this is the cause yet, but the test variables.test is 
now failing on Windows. @aleksandr.urakov and @JDevlieghere, which tests did 
you run on Windows? Did they all pass?


Repository:
  rL LLVM

https://reviews.llvm.org/D49018



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I am debugging through it right now, but I believe this change caused several 
tests on Windows with Python 3 to fail. The failures are all related to UTF-8. 
For example:

  UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: 
invalid start byte


Repository:
  rL LLVM

https://reviews.llvm.org/D49207



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

@apolyakov Perhaps we can mark the test as XFAIL on Windows while you 
investigate. Any objections?


Repository:
  rL LLVM

https://reviews.llvm.org/D48802



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

All better now! Tests are passing.


Repository:
  rL LLVM

https://reviews.llvm.org/D49309



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

Thank you!


Repository:
  rL LLVM

https://reviews.llvm.org/D48802



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

I'll spend some time looking into this today, but with commit 
0fa537f42f1af238c74bf41998dc1af31195839a variables.test passes. Then with 
commit d9899ad86e0a9b05781015cacced1438fcf70343, the test fails. There are 
clearly a couple of other commits in that range, but they are a lot less likely 
to have caused the failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D49018



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added a comment.

The CHECK-SAME expression on line 10 can no longer find the expected string in 
the output. This is due to an extra `location = DW_OP_addr(000140004114) ,` 
in the output between the two expected strings `CHECK-SAME: scope = global, 
external`, so it looks like it is this change that is causing the failure. This 
can be fixed by updating the CHECK-SAME expression, but I will leave it up to 
you to decide if that is the correct fix. I also noticed that `location = 
DW_OP_addr(000140004114) ,` has an extra space before the comma which other 
values do not. Here is the log:

`location = DW_OP_addr(000140004114) ,`

   # command stderr:
  ##[error]llvm\tools\lldb\lit\SymbolFile\PDB\variables.test(10,13): Error 
GBE9F3850: CHECK-SAME: expected string not found in input
   
3>C:\agent1\_work\15\s\llvm\tools\lldb\lit\SymbolFile\PDB\variables.test(10,13):
 error GBE9F3850: CHECK-SAME: expected string not found in input 
[C:\agent1\_work\15\b\LLVMBuild\tools\lldb\lit\check-lldb-lit.vcxproj]
   
   CHECK-SAME: scope = global, external
   
   ^
   
   :117:58: note: scanning from here
   
   022CA2072050: Variable{0x0002}, name = "g_IntVar", type = 
{0004} 0x022ca20c2390 (int), scope = global, location = 
DW_OP_addr(000140004114) , external
   
^
   
   :117:112: note: possible intended match here
   
   022CA2072050: Variable{0x0002}, name = "g_IntVar", type = 
{0004} 0x022ca20c2390 (int), scope = global, location = 
DW_OP_addr(000140004114) , external




Repository:
  rL LLVM

https://reviews.llvm.org/D49018



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits