[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]

2020-12-20 Thread Pavel Labath via Phabricator via lldb-commits 
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.



Comment at: 
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.

I don't know if this namespace snuck into the FreeBSD file, but generally, this 
is not the proper use of anonymous namespaces in llvm. See [[ 
http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding 
standards ]] for more details.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93541/new/

https://reviews.llvm.org/D93541

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 37974b4 - [lldb/test] Enable reverse-connect on windows too

2020-12-20 Thread Pavel Labath via lldb-commits 

Author: Pavel Labath
Date: 2020-12-20T10:37:48+01:00
New Revision: 37974b493a48cf97ac3d486512d6cd70c176924a

URL: 
https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a
DIFF: 
https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a.diff

LOG: [lldb/test] Enable reverse-connect on windows too

It works, and it should be more stable than forward connections.

Added: 


Modified: 
lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

Removed: 




diff  --git 
a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py 
b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
index 03cf2d4ab981..0e3cde01520a 100644
--- 
a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
+++ 
b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
@@ -195,10 +195,6 @@ def _init_llgs_test(self):
 # Remove if it's there.
 self.debug_monitor_exe = re.sub(r' \(deleted\)$', '', exe)
 else:
-# TODO: enable this
-if platform.system() == 'Windows':
-reverse_connect = False
-
 self.debug_monitor_exe = get_lldb_server_exe()
 if not self.debug_monitor_exe:
 self.skipTest("lldb-server exe not found")



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9956233 - [lldb] [test] Update test status for NetBSD

2020-12-20 Thread Michał Górny via lldb-commits 

Author: Michał Górny
Date: 2020-12-20T11:32:43+01:00
New Revision: 99562332e3de19da9da1714a58b5cc2d24724ef5

URL: 
https://github.com/llvm/llvm-project/commit/99562332e3de19da9da1714a58b5cc2d24724ef5
DIFF: 
https://github.com/llvm/llvm-project/commit/99562332e3de19da9da1714a58b5cc2d24724ef5.diff

LOG: [lldb] [test] Update test status for NetBSD

Added: 


Modified: 
lldb/test/API/api/multiple-targets/TestMultipleTargets.py
lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
lldb/test/API/commands/expression/ir-interpreter/TestIRInterpreter.py
lldb/test/API/commands/expression/radar_9531204/TestPrintfAfterUp.py
lldb/test/API/commands/expression/save_jit_objects/TestSaveJITObjects.py
lldb/test/API/commands/expression/test/TestExprs.py
lldb/test/API/commands/gui/viewlarge/TestGuiViewLarge.py
lldb/test/API/commands/process/attach/TestProcessAttach.py

lldb/test/API/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py

lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
lldb/test/API/functionalities/completion/TestCompletion.py

lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
lldb/test/API/functionalities/inferior-assert/TestInferiorAssert.py

lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentBreakpointDelayBreakpointOneSignal.py

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentSignalDelayBreak.py

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoBreakpointsOneDelaySignal.py

lldb/test/API/functionalities/thread/concurrent_events/TestConcurrentTwoBreakpointsOneSignal.py

lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py

lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py

lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
lldb/test/API/functionalities/unwind/noreturn/TestNoreturnUnwind.py
lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
lldb/test/API/lang/c/const_variables/TestConstVariables.py
lldb/test/API/lang/c/function_types/TestFunctionTypes.py
lldb/test/API/lang/c/global_variables/TestGlobalVariables.py
lldb/test/API/lang/c/shared_lib/TestSharedLib.py
lldb/test/API/lang/cpp/exceptions/TestCPPExceptionBreakpoints.py
lldb/test/API/lang/cpp/namespace_definitions/TestNamespaceDefinitions.py
lldb/test/API/lang/cpp/stl/TestStdCXXDisassembly.py
lldb/test/API/lang/cpp/this/TestCPPThis.py
lldb/test/API/python_api/event/TestEvents.py
lldb/test/API/python_api/lldbutil/iter/TestRegistersIterator.py
lldb/test/API/python_api/thread/TestThreadAPI.py
lldb/test/API/tools/lldb-server/TestGdbRemote_vContThreads.py

lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py
lldb/test/Shell/Recognizer/assert.test
lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
lldb/test/Shell/ScriptInterpreter/Lua/watchpoint_callback.test

Removed: 




diff  --git a/lldb/test/API/api/multiple-targets/TestMultipleTargets.py 
b/lldb/test/API/api/multiple-targets/TestMultipleTargets.py
index eebaea3c4fd2..7931cc4be050 100644
--- a/lldb/test/API/api/multiple-targets/TestMultipleTargets.py
+++ b/lldb/test/API/api/multiple-targets/TestMultipleTargets.py
@@ -21,6 +21,7 @@ class TestMultipleTargets(TestBase):
 @expectedFailureAll(
 oslist=["windows"],
 bugnumber="llvm.org/pr20282")
+@expectedFlakeyNetBSD
 def test_multiple_targets(self):
 env = {self.dylibPath: self.getLLDBLibraryEnvVal()}
 

diff  --git 
a/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py 
b/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
index 87e7386c3dcb..6647176e7a18 100644
--- a/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
+++ b/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
@@ -25,7 +25,7 @@ def setUp(self):
 @skipIfDarwin  # llvm.org/pr19246: intermittent failure
 @skipIfWindows  # Test relies on signals, unsupported on Windows
 @expectedFlakeyAndroid(bugnumber="llvm.org/pr19246")
-@expectedFailureNetBSD
+@expectedFlakeyNetBSD
 def test(self):
 """Test calling function that hits a signal and restarts."""
 self.build()

diff  --git 
a/lldb/test/API/commands/expression/ir-interpreter/TestIRInterpreter.py 
b/lldb/test/API/commands/expression/ir-interpreter/TestIRInterpreter.py
index 5efbba90ccba..16c88c53ef1a 100644
--- a/lldb/t

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

2020-12-20 Thread Pavel Labath via Phabricator via lldb-commits 
labath added a comment.

I've included two logs, showing failing and successful runs (the successful run 
was captured without this patch). Interesting things happen around line 1057, 
where the "step out" plan decides we should not stop after stepping out. I'm 
not sure what's the relation to this patch, but I suppose it could have 
something to do with it not (always) fetching the correct frame (from which it 
should step out) from the execution context.

F14780068: fail.log 

F14780071: ok.log 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92164/new/

https://reviews.llvm.org/D92164

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D93541: [Process/NetBSD] Copy changes from FreeBSDRemote and reformat [WIP]

2020-12-20 Thread Michał Górny via Phabricator via lldb-commits 
mgorny added inline comments.



Comment at: 
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:41
+
+namespace {
+// x86 64-bit general purpose registers.

labath wrote:
> I don't know if this namespace snuck into the FreeBSD file, but generally, 
> this is not the proper use of anonymous namespaces in llvm. See [[ 
> http://llvm.org/docs/CodingStandards.html#anonymous-namespaces | the coding 
> standards ]] for more details.
I guess I've copied it from Linux. Should I eliminate it entirely or move to 
`lldb_private::process_netbsd`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93541/new/

https://reviews.llvm.org/D93541

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D93601: lldb-vscode: Install package.json to share/lldb-vscode

2020-12-20 Thread Daan De Meyer via Phabricator via lldb-commits 
DaanDeMeyer created this revision.
DaanDeMeyer added a reviewer: LLDB.
DaanDeMeyer added a project: LLDB.
Herald added subscribers: JDevlieghere, mgorny.
DaanDeMeyer requested review of this revision.
Herald added a subscriber: lldb-commits.

  This makes it easier to install the extension since the necessary file
  is already made available when lldb is installed instead of having to
  go and retrieve it from the llvm repo.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93601

Files:
  lldb/tools/lldb-vscode/CMakeLists.txt


Index: lldb/tools/lldb-vscode/CMakeLists.txt
===
--- lldb/tools/lldb-vscode/CMakeLists.txt
+++ lldb/tools/lldb-vscode/CMakeLists.txt
@@ -44,6 +44,8 @@
 Support
   )
 
+install(FILES package.json DESTINATION share/lldb-vscode)
+
 if(LLDB_BUILD_FRAMEWORK)
   # In the build-tree, we know the exact path to the framework directory.
   # The installed framework can be in different locations.


Index: lldb/tools/lldb-vscode/CMakeLists.txt
===
--- lldb/tools/lldb-vscode/CMakeLists.txt
+++ lldb/tools/lldb-vscode/CMakeLists.txt
@@ -44,6 +44,8 @@
 Support
   )
 
+install(FILES package.json DESTINATION share/lldb-vscode)
+
 if(LLDB_BUILD_FRAMEWORK)
   # In the build-tree, we know the exact path to the framework directory.
   # The installed framework can be in different locations.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits