[Lldb-commits] [PATCH] D38323: Enable breakpoints and read/write GPRs for ppc64le

2017-10-08 Thread Pavel Labath via Phabricator via lldb-commits 
labath added a comment.

In https://reviews.llvm.org/D38323#889534, @alexandreyy wrote:

> In https://reviews.llvm.org/D38323#889473, @labath wrote:
>
> > Looks fine to me. Sorry about the delay.
> >
> > @eugene should be able to help you commit this.
> >
> > Wrt. the extra register context discussion, I believe you will need to 
> > implement an extra class or two when you get around to debugging core 
> > files, but that should not be necessary right now. (And yes, linux now uses 
> > lldb-server for local debugging as well).
>
>
> Thanks for the review.
>  What are the classes/structures that I should implement?


Take a look at ProcessElfCore class. The things to implement should be fairly 
self-evident from the code there.

If you get stuck, I should be able to take a closer look at this next week.


Repository:
  rL LLVM

https://reviews.llvm.org/D38323



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r315199 - [SymbolFile/DWARF] Simplify two functions. NFCI.

2017-10-08 Thread Davide Italiano via lldb-commits 
Author: davide
Date: Sun Oct  8 17:11:49 2017
New Revision: 315199

URL: http://llvm.org/viewvc/llvm-project?rev=315199&view=rev
Log:
[SymbolFile/DWARF] Simplify two functions. NFCI.

Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp?rev=315199&r1=315198&r2=315199&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp Sun Oct  8 17:11:49 
2017
@@ -392,17 +392,11 @@ lldb::ModuleSP DWARFDIE::GetContainingDW
 }
 
 bool DWARFDIE::HasChildren() const {
-  if (m_die)
-return m_die->HasChildren();
-  else
-return false;
+  return m_die && m_die->HasChildren();
 }
 
 bool DWARFDIE::Supports_DW_AT_APPLE_objc_complete_type() const {
-  if (IsValid())
-return GetDWARF()->Supports_DW_AT_APPLE_objc_complete_type(m_cu);
-  else
-return false;
+  return IsValid() && 
GetDWARF()->Supports_DW_AT_APPLE_objc_complete_type(m_cu);
 }
 
 size_t DWARFDIE::GetAttributes(DWARFAttributes &attributes,


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r315200 - [DWARFDIE] Rewrite `operator !=` using `operator ==`. NFCI.

2017-10-08 Thread Davide Italiano via lldb-commits 
Author: davide
Date: Sun Oct  8 17:18:45 2017
New Revision: 315200

URL: http://llvm.org/viewvc/llvm-project?rev=315200&view=rev
Log:
[DWARFDIE] Rewrite `operator !=` using `operator ==`. NFCI.

Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
URL: 
http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp?rev=315200&r1=315199&r2=315200&view=diff
==
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp Sun Oct  8 17:18:45 
2017
@@ -458,5 +458,5 @@ bool operator==(const DWARFDIE &lhs, con
 }
 
 bool operator!=(const DWARFDIE &lhs, const DWARFDIE &rhs) {
-  return lhs.GetDIE() != rhs.GetDIE() || lhs.GetCU() != rhs.GetCU();
+  return !(lhs == rhs);
 }


___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits