labath added a comment. In https://reviews.llvm.org/D38323#889534, @alexandreyy wrote:
> In https://reviews.llvm.org/D38323#889473, @labath wrote: > > > Looks fine to me. Sorry about the delay. > > > > @eugene should be able to help you commit this. > > > > Wrt. the extra register context discussion, I believe you will need to > > implement an extra class or two when you get around to debugging core > > files, but that should not be necessary right now. (And yes, linux now uses > > lldb-server for local debugging as well). > > > Thanks for the review. > What are the classes/structures that I should implement? Take a look at ProcessElfCore class. The things to implement should be fairly self-evident from the code there. If you get stuck, I should be able to take a closer look at this next week. Repository: rL LLVM https://reviews.llvm.org/D38323 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits