Re: [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule
On 10/2/2023 8:10 AM, Christian Marangi wrote:
Now that napi_schedule return a bool, we can drop napi_reschedule that
does the same exact function. The function comes from a very old commit
bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct
net_device") and the purpose is actually deprecated in favour of
different logic.
Convert every user of napi_reschedule to napi_schedule.
Signed-off-by: Christian Marangi
---
For
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
Acked-by: Jeff Johnson
Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule
On 10/2/2023 8:10 AM, Christian Marangi wrote:
Change napi_schedule to return a bool on NAPI successful schedule. This
might be useful for some driver to do additional step after a NAPI ahs
nit:s/ahs/has/
been scheduled.
Signed-off-by: Christian Marangi
---
include/linux/netdevice.h | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 7e520c14eb8c..2bead8e2a14d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -490,11 +490,18 @@ bool napi_schedule_prep(struct napi_struct *n);
*
* Schedule NAPI poll routine to be called if it is not already
* running.
+ * Return true if we schedule a NAPI or false if not.
+ * Refer to napi_schedule_prep() for additional reason on why
+ * a NAPI might not be scheduled.
*/
-static inline void napi_schedule(struct napi_struct *n)
+static inline bool napi_schedule(struct napi_struct *n)
{
- if (napi_schedule_prep(n))
+ if (napi_schedule_prep(n)) {
__napi_schedule(n);
+ return true;
+ }
+
+ return false;
}
/**
Re: [PATCH] [RFC] wireless: move obsolete drivers to staging
On 10/13/2023 11:02 AM, Johannes Berg wrote: On Fri, 2023-10-13 at 17:44 +0200, Arnd Bergmann wrote: On Thu, Oct 12, 2023, at 18:36, Geoff Levand wrote: On 10/12/23 17:41, Johannes Berg wrote: But seriously - is it worth to try to keep a wireless driver for it if we don't even know anyone using a PS3 at all? There is still a considerable user base for the PS3, so we must keep the ps3-gelic-wireless driver. Do you know if anyone has tried changing this driver over to the cfg80211 interface from the wireless extensions? I looked at that yesterday, and sadly I _think_ it's not even possible, there are some corner cases in it like "no WPA2" that don't seem to be fully covered in cfg80211/nl80211, at least not with the APIs today and with current versions of wpa_supplicant. It might still be doable because things like WPA_DRIVER_CAPA_KEY_MGMT_WPA2_PSK don't really seem to be used much in wpa_supplicant, but we'd have to carefully test that I guess. Also, it depends on the PS3 firmware version whether or not that's supported. Then again, arguably wifi without WPA2 is pretty much useless these days? This is a good point. It doesn't matter if the clients work if there are no Access Points to connect to. And if you do have an old one you can connect to, it will be an insecure connection. Wardriving, anyone? /jeff
Re: [FYI][PATCH] tracing/treewide: Remove second parameter of __assign_str()
On 2/23/2024 9:56 AM, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of v6.9 and submit it then. Hoping >to keep the conflicts that it will cause to a minimum. > ] > > With the rework of how the __string() handles dynamic strings where it > saves off the source string in field in the helper structure[1], the > assignment of that value to the trace event field is stored in the helper > value and does not need to be passed in again. Just curious if this could be done piecemeal by first changing the macros to be variadic macros which allows you to ignore the extra argument. The callers could then be modified in their separate trees. And then once all the callers have be merged, the macros could be changed to no longer be variadic.
[PATCH] macintosh/mac_hid: add MODULE_DESCRIPTION()
Fix the make W=1 warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o
Signed-off-by: Jeff Johnson
---
drivers/macintosh/mac_hid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
index 1ae3539beff5..eb7a173da071 100644
--- a/drivers/macintosh/mac_hid.c
+++ b/drivers/macintosh/mac_hid.c
@@ -16,6 +16,7 @@
#include
#include
+MODULE_DESCRIPTION("Macintosh mouse button 2+3 emulation");
MODULE_LICENSE("GPL");
static int mouse_emulate_buttons;
---
base-commit: dd5a440a31fae6e459c0d627162825505361
change-id: 20240509-mac_hid-md-7df0c349753c
Re: [PATCH 19/22] wnc36xx: Replace comments with C99 initializers
On 3/26/2022 9:59 AM, Benjamin Stürz wrote:
This replaces comments with C99's designated
initializers because the kernel supports them now.
Signed-off-by: Benjamin Stürz
---
drivers/net/wireless/ath/wcn36xx/main.c | 122
1 file changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
b/drivers/net/wireless/ath/wcn36xx/main.c
index 95ea7d040d8c..0fed64bd37b4 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -193,67 +193,67 @@ static inline u8 get_sta_index(struct ieee80211_vif *vif,
}
static const char * const wcn36xx_caps_names[] = {
- "MCC",/* 0 */
- "P2P",/* 1 */
- "DOT11AC",/* 2 */
- "SLM_SESSIONIZATION", /* 3 */
- "DOT11AC_OPMODE", /* 4 */
- "SAP32STA", /* 5 */
- "TDLS", /* 6 */
- "P2P_GO_NOA_DECOUPLE_INIT_SCAN",/* 7 */
- "WLANACTIVE_OFFLOAD", /* 8 */
- "BEACON_OFFLOAD", /* 9 */
- "SCAN_OFFLOAD", /* 10 */
- "ROAM_OFFLOAD", /* 11 */
- "BCN_MISS_OFFLOAD", /* 12 */
- "STA_POWERSAVE", /* 13 */
- "STA_ADVANCED_PWRSAVE", /* 14 */
- "AP_UAPSD", /* 15 */
- "AP_DFS", /* 16 */
- "BLOCKACK", /* 17 */
- "PHY_ERR",/* 18 */
- "BCN_FILTER", /* 19 */
- "RTT",/* 20 */
- "RATECTRL", /* 21 */
- "WOW",/* 22 */
- "WLAN_ROAM_SCAN_OFFLOAD", /* 23 */
- "SPECULATIVE_PS_POLL",/* 24 */
- "SCAN_SCH", /* 25 */
- "IBSS_HEARTBEAT_OFFLOAD", /* 26 */
- "WLAN_SCAN_OFFLOAD", /* 27 */
- "WLAN_PERIODIC_TX_PTRN", /* 28 */
- "ADVANCE_TDLS", /* 29 */
- "BATCH_SCAN", /* 30 */
- "FW_IN_TX_PATH", /* 31 */
- "EXTENDED_NSOFFLOAD_SLOT",/* 32 */
- "CH_SWITCH_V1", /* 33 */
- "HT40_OBSS_SCAN", /* 34 */
- "UPDATE_CHANNEL_LIST",/* 35 */
- "WLAN_MCADDR_FLT",/* 36 */
- "WLAN_CH144", /* 37 */
- "NAN",/* 38 */
- "TDLS_SCAN_COEXISTENCE", /* 39 */
- "LINK_LAYER_STATS_MEAS", /* 40 */
- "MU_MIMO",/* 41 */
- "EXTENDED_SCAN", /* 42 */
- "DYNAMIC_WMM_PS", /* 43 */
- "MAC_SPOOFED_SCAN", /* 44 */
- "BMU_ERROR_GENERIC_RECOVERY", /* 45 */
- "DISA", /* 46 */
- "FW_STATS", /* 47 */
- "WPS_PRBRSP_TMPL",/* 48 */
- "BCN_IE_FLT_DELTA", /* 49 */
- "TDLS_OFF_CHANNEL", /* 51 */
- "RTT3", /* 52 */
- "MGMT_FRAME_LOGGING", /* 53 */
- "ENHANCED_TXBD_COMPLETION", /* 54 */
- "LOGGING_ENHANCEMENT",/* 55 */
- "EXT_SCAN_ENHANCED", /* 56 */
- "MEMORY_DUMP_SUPPORTED", /* 57 */
- "PER_PKT_STATS_SUPPORTED",/* 58 */
- "EXT_LL_STAT",/* 60 */
- "WIFI_CONFIG",/* 61 */
- "ANTENNA_DIVERSITY_SELECTION",/* 62 */
+ [0] = "MCC",
+ [1] = "P2P",
+ [2] = "DOT11AC",
+ [3] = "SLM_SESSIONIZATION",
+ [4] = "DOT11AC_OPMODE",
+ [5] = "SAP32STA",
+ [6] = "TDLS",
+ [7] = "P2P_GO_NOA_DECOUPLE_INIT_SCAN",
+ [8] = "WLANACTIVE_OFFLOAD",
+ [9] = "BEACON_OFFLOAD",
+ [10] = "SCAN_OFFLOAD",
+ [11] = "ROAM_OFFLOAD",
+ [12] = "BCN_MISS_OFFLOAD",
+ [13] = "STA_POWERSAVE",
+ [14] = "STA_ADVANCED_PWRSAVE",
+ [15] = "AP_UAPSD",
+ [16] = "AP_DFS",
+ [17] = "BLOCKACK",
+ [18] = "PHY_ERR",
+ [19] = "BCN_FILTER",
+ [20] = "RTT",
+ [21] = "RATECTRL",
+ [22] = "WOW",
+ [23] = "WLAN_ROAM_SCAN_OFFLOAD",
+ [24] = "SPECULATIVE_PS_POLL",
+ [25] = "SCAN_SCH",
+ [26] = "IBSS_HEARTBEAT_OFFLOAD",
+ [27] = "WLAN_SCAN_OFFLOAD",
+ [28] = "WLAN_PERIODIC_TX_PTRN",
+ [29] = "ADVANCE_TDLS",
+ [30] = "BATCH_SCAN",
+ [31] = "FW_IN_TX_PATH",
+ [32] = "EXTENDED_NSOFFLOAD_SLOT",
+ [33] = "CH_SWITCH_V1",
+ [34] = "HT40_OBSS_SCAN",
+ [35] = "UPDATE_CHANNEL_LIST",
+ [36] = "WLAN_MCADDR_FLT",
+ [37] = "WLAN_CH144",
+ [38] = "NAN",
+ [39] = "TDLS_SCAN_COEXISTENCE",
+ [40] = "LINK_LAYER_STATS_MEAS",
+ [4
Re: [PATCH v4 03/14] modpost: split the section mismatch checks into section-check.c
On 5/11/2022 12:27 PM, Masahiro Yamada wrote: On Thu, May 12, 2022 at 3:48 AM Nick Desaulniers wrote: On Mon, May 9, 2022 at 11:57 PM Masahiro Yamada wrote: diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index a78b75f0eeb0..e7e2c70a98f5 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -31,7 +31,7 @@ static bool external_module; /* Only warn about unresolved symbols */ static bool warn_unresolved; -static int sec_mismatch_count; +int sec_mismatch_count; ^ this should go in modpost.h if it is to be used in two translation units, rather than forward declaring it in section-check.c. You did this for the functions. Sorry, I do not understand. In modpost.h, I put the declaration: extern int sec_mismatch_count; If I moved it to the header without 'extern' I would get multiple definitions. Yeah, you need to _declare_ it w/ extern in the header, then _define_ it in one source file. That way, if the type ever changes, the sources will agree on type in all source files. You will get a redefinition error if the definition changes the type of the variable since the last declaration. What you're doing is forward declaring, which works, and is a common pattern for (bloated) C++, but is less type safe than sharing a single common declaration between multiple source files via a single common shared header. (Sorry I didn't respond before you sent v5) Sorry, I still do not understand your suggestion. Could you provide me with a code diff showing how to do this better? I think you are doing exactly what he's asking for: declare it with extern in the header (modpost.h change) define it in one source file (modpost.c change)
[PATCH] ASoC: fsl: add missing MODULE_DESCRIPTION() macro
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/fsl/imx-pcm-dma.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
sound/soc/fsl/imx-pcm-dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c
index 14e94270911c..4fa208d6a032 100644
--- a/sound/soc/fsl/imx-pcm-dma.c
+++ b/sound/soc/fsl/imx-pcm-dma.c
@@ -50,4 +50,5 @@ int imx_pcm_dma_init(struct platform_device *pdev)
}
EXPORT_SYMBOL_GPL(imx_pcm_dma_init);
+MODULE_DESCRIPTION("Freescale i.MX PCM DMA interface");
MODULE_LICENSE("GPL");
---
base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
change-id: 20240602-md-snd-fsl-imx-pcm-dma-06224c50d4d1
[PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/ppc-cbe-cpufreq.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/powernv-cpufreq.o
Add the missing invocation of the MODULE_DESCRIPTION() macro to all
files which have a MODULE_LICENSE().
This includes three additional files which, although they did not
produce a warning with the powerpc allmodconfig configuration, may
cause this warning with specific options enabled in the kernel
configuration.
Signed-off-by: Jeff Johnson
---
Corrections to these descriptions are welcomed. I'm not an expert in
this code so in most cases I've taken these descriptions directly from
code comments, Kconfig descriptions, or git logs. History has shown
that in some cases these are originally wrong due to cut-n-paste
errors, and in other cases the drivers have evolved such that the
original information is no longer accurate.
---
drivers/cpufreq/maple-cpufreq.c | 1 +
drivers/cpufreq/pasemi-cpufreq.c | 1 +
drivers/cpufreq/pmac64-cpufreq.c | 1 +
drivers/cpufreq/powernv-cpufreq.c | 1 +
drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
index f9306410a07f..19ca7f874d28 100644
--- a/drivers/cpufreq/maple-cpufreq.c
+++ b/drivers/cpufreq/maple-cpufreq.c
@@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
module_init(maple_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for Maple 970FX Evaluation Board");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
index 039a66bbe1be..92a99f09884a 100644
--- a/drivers/cpufreq/pasemi-cpufreq.c
+++ b/drivers/cpufreq/pasemi-cpufreq.c
@@ -271,5 +271,6 @@ static void __exit pas_cpufreq_exit(void)
module_init(pas_cpufreq_init);
module_exit(pas_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for PA Semi PWRficient");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Egor Martovetsky , Olof Johansson
");
diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 2cd2b06849a2..9d3fe36075f8 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -671,4 +671,5 @@ static int __init g5_cpufreq_init(void)
module_init(g5_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for SMU & 970FX based G5 Macs");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index fddbd1ea1635..e923f717e1d7 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -1162,5 +1162,6 @@ static void __exit powernv_cpufreq_exit(void)
}
module_exit(powernv_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for the IBM POWER processors");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Vaidyanathan Srinivasan ");
diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c
b/drivers/cpufreq/ppc_cbe_cpufreq.c
index 88afc49941b7..72f568d14f30 100644
--- a/drivers/cpufreq/ppc_cbe_cpufreq.c
+++ b/drivers/cpufreq/ppc_cbe_cpufreq.c
@@ -169,5 +169,6 @@ static void __exit cbe_cpufreq_exit(void)
module_init(cbe_cpufreq_init);
module_exit(cbe_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for Cell BE processors");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240614-md-powerpc-drivers-cpufreq-6d345e48164e
[PATCH] KVM: PPC: add missing MODULE_DESCRIPTION() macros
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/kvm/test-guest-state-buffer.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-pr.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-hv.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
arch/powerpc/kvm/book3s_hv.c | 1 +
arch/powerpc/kvm/book3s_pr.c | 1 +
arch/powerpc/kvm/test-guest-state-buffer.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index daaf7faf21a5..e16c096a2422 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -6519,6 +6519,7 @@ static void kvmppc_book3s_exit_hv(void)
module_init(kvmppc_book3s_init_hv);
module_exit(kvmppc_book3s_exit_hv);
+MODULE_DESCRIPTION("KVM on Book 3S (POWER7 and later) in hypervisor mode");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(KVM_MINOR);
MODULE_ALIAS("devname:kvm");
diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c
index a7d7137ea0c8..7c19744c43cb 100644
--- a/arch/powerpc/kvm/book3s_pr.c
+++ b/arch/powerpc/kvm/book3s_pr.c
@@ -2111,6 +2111,7 @@ void kvmppc_book3s_exit_pr(void)
module_init(kvmppc_book3s_init_pr);
module_exit(kvmppc_book3s_exit_pr);
+MODULE_DESCRIPTION("KVM on Book 3S without using hypervisor mode");
MODULE_LICENSE("GPL");
MODULE_ALIAS_MISCDEV(KVM_MINOR);
MODULE_ALIAS("devname:kvm");
diff --git a/arch/powerpc/kvm/test-guest-state-buffer.c
b/arch/powerpc/kvm/test-guest-state-buffer.c
index 4720b8dc8837..10238556c113 100644
--- a/arch/powerpc/kvm/test-guest-state-buffer.c
+++ b/arch/powerpc/kvm/test-guest-state-buffer.c
@@ -325,4 +325,5 @@ static struct kunit_suite guest_state_buffer_test_suite = {
kunit_test_suites(&guest_state_buffer_test_suite);
+MODULE_DESCRIPTION("KUnit tests for Guest State Buffer APIs");
MODULE_LICENSE("GPL");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-powerpc-arch-powerpc-kvm-9267fc8b0a8b
[PATCH] powerpc: add missing MODULE_DESCRIPTION() macros
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/kernel/rtas_flash.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/sysdev/rtc_cmos_setup.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/platforms/pseries/papr_scm.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/platforms/cell/spufs/spufs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/platforms/cell/cbe_thermal.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/platforms/cell/cpufreq_spudemand.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/platforms/cell/cbe_powerbutton.o
Add the missing invocation of the MODULE_DESCRIPTION() macro to all
files which have a MODULE_LICENSE().
This includes 85xx/t1042rdb_diu.c and chrp/nvram.c which, although
they did not produce a warning with the powerpc allmodconfig
configuration, may cause this warning with other configurations.
Signed-off-by: Jeff Johnson
---
Corrections to these descriptions are welcomed. I'm not an expert in
this code so in most cases I've taken these descriptions directly from
code comments, Kconfig descriptions, or git logs. History has shown
that in some cases these are originally wrong due to cut-n-paste
errors, and in other cases the drivers have evolved such that the
original information is no longer accurate.
---
arch/powerpc/kernel/rtas_flash.c| 1 +
arch/powerpc/platforms/85xx/t1042rdb_diu.c | 1 +
arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 +
arch/powerpc/platforms/cell/cbe_thermal.c | 1 +
arch/powerpc/platforms/cell/cpufreq_spudemand.c | 1 +
arch/powerpc/platforms/cell/spufs/inode.c | 1 +
arch/powerpc/platforms/chrp/nvram.c | 1 +
arch/powerpc/platforms/pseries/papr_scm.c | 1 +
arch/powerpc/sysdev/rtc_cmos_setup.c| 1 +
9 files changed, 9 insertions(+)
diff --git a/arch/powerpc/kernel/rtas_flash.c b/arch/powerpc/kernel/rtas_flash.c
index 359577ec1680..5407024881e5 100644
--- a/arch/powerpc/kernel/rtas_flash.c
+++ b/arch/powerpc/kernel/rtas_flash.c
@@ -773,4 +773,5 @@ static void __exit rtas_flash_cleanup(void)
module_init(rtas_flash_init);
module_exit(rtas_flash_cleanup);
+MODULE_DESCRIPTION("PPC procfs firmware flash interface");
MODULE_LICENSE("GPL");
diff --git a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
index 767eed98a0a8..d4fbb6eff38a 100644
--- a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
+++ b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
@@ -149,4 +149,5 @@ static int __init t1042rdb_diu_init(void)
early_initcall(t1042rdb_diu_init);
+MODULE_DESCRIPTION("Freescale T1042 DIU driver");
MODULE_LICENSE("GPL");
diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c
b/arch/powerpc/platforms/cell/cbe_powerbutton.c
index a3ee397486f6..3d121acdf69b 100644
--- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
+++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
@@ -101,5 +101,6 @@ static void __exit cbe_powerbutton_exit(void)
module_init(cbe_powerbutton_init);
module_exit(cbe_powerbutton_exit);
+MODULE_DESCRIPTION("Driver for powerbutton on IBM cell blades");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c
b/arch/powerpc/platforms/cell/cbe_thermal.c
index 2f45428e32c8..c295c6714f9b 100644
--- a/arch/powerpc/platforms/cell/cbe_thermal.c
+++ b/arch/powerpc/platforms/cell/cbe_thermal.c
@@ -381,6 +381,7 @@ static void __exit thermal_exit(void)
}
module_exit(thermal_exit);
+MODULE_DESCRIPTION("Cell processor thermal driver");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
index ca7849e113d7..79172ba36eca 100644
--- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
+++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
@@ -129,5 +129,6 @@ static struct cpufreq_governor spu_governor = {
cpufreq_governor_init(spu_governor);
cpufreq_governor_exit(spu_governor);
+MODULE_DESCRIPTION("SPU-aware cpufreq governor for the cell processor");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
diff --git a/arch/powerpc/platforms/cell/spufs/inode.c
b/arch/powerpc/platforms/cell/spufs/inode.c
index 030de2b8c145..70236d1df3d3 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -822,6 +822,7 @@ static void __exit spufs_exit(void)
}
module_exit(spufs_exit);
+MODULE_DESCRIPTION("SPU file system");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Arnd Bergmann ");
diff --git a/arch/powerpc/platforms/chrp/nvram.c
b/arch/powerpc/platforms/chrp/nvram.c
index 0eedae
[PATCH] ASoC: fsl: imx-pcm-fiq: add missing MODULE_DESCRIPTION() macro
With ARCH=arm, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/fsl/imx-pcm-fiq.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
sound/soc/fsl/imx-pcm-fiq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c
index 0d124002678e..5ea6dd4c89a1 100644
--- a/sound/soc/fsl/imx-pcm-fiq.c
+++ b/sound/soc/fsl/imx-pcm-fiq.c
@@ -319,4 +319,5 @@ void imx_pcm_fiq_exit(struct platform_device *pdev)
}
EXPORT_SYMBOL_GPL(imx_pcm_fiq_exit);
+MODULE_DESCRIPTION("Freescle i.MX PCM FIQ handler");
MODULE_LICENSE("GPL");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-arm-sound-soc-fsl-c598fb353e69
Re: [PATCH] ASoC: fsl: imx-pcm-fiq: add missing MODULE_DESCRIPTION() macro
On 6/16/2024 12:14 AM, Christophe JAILLET wrote:
> Le 16/06/2024 à 08:42, Jeff Johnson a écrit :
>> With ARCH=arm, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/fsl/imx-pcm-fiq.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson
>> ---
>> sound/soc/fsl/imx-pcm-fiq.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c
>> index 0d124002678e..5ea6dd4c89a1 100644
>> --- a/sound/soc/fsl/imx-pcm-fiq.c
>> +++ b/sound/soc/fsl/imx-pcm-fiq.c
>> @@ -319,4 +319,5 @@ void imx_pcm_fiq_exit(struct platform_device *pdev)
>> }
>> EXPORT_SYMBOL_GPL(imx_pcm_fiq_exit);
>>
>> +MODULE_DESCRIPTION("Freescle i.MX PCM FIQ handler");
>
> Freescale? (missing 'a')
thanks for the catch, will send a v2
[PATCH v2] ASoC: fsl: imx-pcm-fiq: add missing MODULE_DESCRIPTION() macro
With ARCH=arm, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in sound/soc/fsl/imx-pcm-fiq.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
Changes in v2:
- Fixed spelling of Freescale
- Link to v1:
https://lore.kernel.org/r/20240615-md-arm-sound-soc-fsl-v1-1-8ed731c2f...@quicinc.com
---
sound/soc/fsl/imx-pcm-fiq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c
index 0d124002678e..3391430e4253 100644
--- a/sound/soc/fsl/imx-pcm-fiq.c
+++ b/sound/soc/fsl/imx-pcm-fiq.c
@@ -319,4 +319,5 @@ void imx_pcm_fiq_exit(struct platform_device *pdev)
}
EXPORT_SYMBOL_GPL(imx_pcm_fiq_exit);
+MODULE_DESCRIPTION("Freescale i.MX PCM FIQ handler");
MODULE_LICENSE("GPL");
---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240615-md-arm-sound-soc-fsl-c598fb353e69
Re: [PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
On 6/14/2024 11:08 PM, Jeff Johnson wrote:
> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/cpufreq/ppc-cbe-cpufreq.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> drivers/cpufreq/powernv-cpufreq.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
> files which have a MODULE_LICENSE().
>
> This includes three additional files which, although they did not
> produce a warning with the powerpc allmodconfig configuration, may
> cause this warning with specific options enabled in the kernel
> configuration.
>
> Signed-off-by: Jeff Johnson
> ---
> Corrections to these descriptions are welcomed. I'm not an expert in
> this code so in most cases I've taken these descriptions directly from
> code comments, Kconfig descriptions, or git logs. History has shown
> that in some cases these are originally wrong due to cut-n-paste
> errors, and in other cases the drivers have evolved such that the
> original information is no longer accurate.
> ---
> drivers/cpufreq/maple-cpufreq.c | 1 +
> drivers/cpufreq/pasemi-cpufreq.c | 1 +
> drivers/cpufreq/pmac64-cpufreq.c | 1 +
> drivers/cpufreq/powernv-cpufreq.c | 1 +
> drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
> index f9306410a07f..19ca7f874d28 100644
> --- a/drivers/cpufreq/maple-cpufreq.c
> +++ b/drivers/cpufreq/maple-cpufreq.c
> @@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
> module_init(maple_cpufreq_init);
>
>
> +MODULE_DESCRIPTION("cpufreq driver for Maple 970FX Evaluation Board");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c
> b/drivers/cpufreq/pasemi-cpufreq.c
> index 039a66bbe1be..92a99f09884a 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -271,5 +271,6 @@ static void __exit pas_cpufreq_exit(void)
> module_init(pas_cpufreq_init);
> module_exit(pas_cpufreq_exit);
>
> +MODULE_DESCRIPTION("cpufreq driver for PA Semi PWRficient");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Egor Martovetsky , Olof Johansson
> ");
> diff --git a/drivers/cpufreq/pmac64-cpufreq.c
> b/drivers/cpufreq/pmac64-cpufreq.c
> index 2cd2b06849a2..9d3fe36075f8 100644
> --- a/drivers/cpufreq/pmac64-cpufreq.c
> +++ b/drivers/cpufreq/pmac64-cpufreq.c
> @@ -671,4 +671,5 @@ static int __init g5_cpufreq_init(void)
> module_init(g5_cpufreq_init);
>
>
> +MODULE_DESCRIPTION("cpufreq driver for SMU & 970FX based G5 Macs");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/cpufreq/powernv-cpufreq.c
> b/drivers/cpufreq/powernv-cpufreq.c
> index fddbd1ea1635..e923f717e1d7 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -1162,5 +1162,6 @@ static void __exit powernv_cpufreq_exit(void)
> }
> module_exit(powernv_cpufreq_exit);
>
> +MODULE_DESCRIPTION("cpufreq driver for the IBM POWER processors");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Vaidyanathan Srinivasan ");
> diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c
> b/drivers/cpufreq/ppc_cbe_cpufreq.c
> index 88afc49941b7..72f568d14f30 100644
> --- a/drivers/cpufreq/ppc_cbe_cpufreq.c
> +++ b/drivers/cpufreq/ppc_cbe_cpufreq.c
> @@ -169,5 +169,6 @@ static void __exit cbe_cpufreq_exit(void)
> module_init(cbe_cpufreq_init);
> module_exit(cbe_cpufreq_exit);
>
> +MODULE_DESCRIPTION("cpufreq driver for Cell BE processors");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft ");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240614-md-powerpc-drivers-cpufreq-6d345e48164e
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff
Re: [PATCH] KVM: PPC: add missing MODULE_DESCRIPTION() macros
On 6/15/2024 8:18 AM, Jeff Johnson wrote:
> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/kvm/test-guest-state-buffer.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-pr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-hv.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson
> ---
> arch/powerpc/kvm/book3s_hv.c | 1 +
> arch/powerpc/kvm/book3s_pr.c | 1 +
> arch/powerpc/kvm/test-guest-state-buffer.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index daaf7faf21a5..e16c096a2422 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -6519,6 +6519,7 @@ static void kvmppc_book3s_exit_hv(void)
>
> module_init(kvmppc_book3s_init_hv);
> module_exit(kvmppc_book3s_exit_hv);
> +MODULE_DESCRIPTION("KVM on Book 3S (POWER7 and later) in hypervisor mode");
> MODULE_LICENSE("GPL");
> MODULE_ALIAS_MISCDEV(KVM_MINOR);
> MODULE_ALIAS("devname:kvm");
> diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c
> index a7d7137ea0c8..7c19744c43cb 100644
> --- a/arch/powerpc/kvm/book3s_pr.c
> +++ b/arch/powerpc/kvm/book3s_pr.c
> @@ -2111,6 +2111,7 @@ void kvmppc_book3s_exit_pr(void)
> module_init(kvmppc_book3s_init_pr);
> module_exit(kvmppc_book3s_exit_pr);
>
> +MODULE_DESCRIPTION("KVM on Book 3S without using hypervisor mode");
> MODULE_LICENSE("GPL");
> MODULE_ALIAS_MISCDEV(KVM_MINOR);
> MODULE_ALIAS("devname:kvm");
> diff --git a/arch/powerpc/kvm/test-guest-state-buffer.c
> b/arch/powerpc/kvm/test-guest-state-buffer.c
> index 4720b8dc8837..10238556c113 100644
> --- a/arch/powerpc/kvm/test-guest-state-buffer.c
> +++ b/arch/powerpc/kvm/test-guest-state-buffer.c
> @@ -325,4 +325,5 @@ static struct kunit_suite guest_state_buffer_test_suite =
> {
>
> kunit_test_suites(&guest_state_buffer_test_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for Guest State Buffer APIs");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-powerpc-arch-powerpc-kvm-9267fc8b0a8b
Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)
/jeff
Re: [PATCH] powerpc: add missing MODULE_DESCRIPTION() macros
On 6/15/2024 10:06 AM, Jeff Johnson wrote:
> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/kernel/rtas_flash.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/sysdev/rtc_cmos_setup.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/platforms/pseries/papr_scm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/platforms/cell/spufs/spufs.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/platforms/cell/cbe_thermal.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/platforms/cell/cpufreq_spudemand.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in
> arch/powerpc/platforms/cell/cbe_powerbutton.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
> files which have a MODULE_LICENSE().
>
> This includes 85xx/t1042rdb_diu.c and chrp/nvram.c which, although
> they did not produce a warning with the powerpc allmodconfig
> configuration, may cause this warning with other configurations.
>
> Signed-off-by: Jeff Johnson
> ---
> Corrections to these descriptions are welcomed. I'm not an expert in
> this code so in most cases I've taken these descriptions directly from
> code comments, Kconfig descriptions, or git logs. History has shown
> that in some cases these are originally wrong due to cut-n-paste
> errors, and in other cases the drivers have evolved such that the
> original information is no longer accurate.
> ---
> arch/powerpc/kernel/rtas_flash.c| 1 +
> arch/powerpc/platforms/85xx/t1042rdb_diu.c | 1 +
> arch/powerpc/platforms/cell/cbe_powerbutton.c | 1 +
> arch/powerpc/platforms/cell/cbe_thermal.c | 1 +
> arch/powerpc/platforms/cell/cpufreq_spudemand.c | 1 +
> arch/powerpc/platforms/cell/spufs/inode.c | 1 +
> arch/powerpc/platforms/chrp/nvram.c | 1 +
> arch/powerpc/platforms/pseries/papr_scm.c | 1 +
> arch/powerpc/sysdev/rtc_cmos_setup.c| 1 +
> 9 files changed, 9 insertions(+)
>
> diff --git a/arch/powerpc/kernel/rtas_flash.c
> b/arch/powerpc/kernel/rtas_flash.c
> index 359577ec1680..5407024881e5 100644
> --- a/arch/powerpc/kernel/rtas_flash.c
> +++ b/arch/powerpc/kernel/rtas_flash.c
> @@ -773,4 +773,5 @@ static void __exit rtas_flash_cleanup(void)
>
> module_init(rtas_flash_init);
> module_exit(rtas_flash_cleanup);
> +MODULE_DESCRIPTION("PPC procfs firmware flash interface");
> MODULE_LICENSE("GPL");
> diff --git a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> index 767eed98a0a8..d4fbb6eff38a 100644
> --- a/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> +++ b/arch/powerpc/platforms/85xx/t1042rdb_diu.c
> @@ -149,4 +149,5 @@ static int __init t1042rdb_diu_init(void)
>
> early_initcall(t1042rdb_diu_init);
>
> +MODULE_DESCRIPTION("Freescale T1042 DIU driver");
> MODULE_LICENSE("GPL");
> diff --git a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> index a3ee397486f6..3d121acdf69b 100644
> --- a/arch/powerpc/platforms/cell/cbe_powerbutton.c
> +++ b/arch/powerpc/platforms/cell/cbe_powerbutton.c
> @@ -101,5 +101,6 @@ static void __exit cbe_powerbutton_exit(void)
> module_init(cbe_powerbutton_init);
> module_exit(cbe_powerbutton_exit);
>
> +MODULE_DESCRIPTION("Driver for powerbutton on IBM cell blades");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft ");
> diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c
> b/arch/powerpc/platforms/cell/cbe_thermal.c
> index 2f45428e32c8..c295c6714f9b 100644
> --- a/arch/powerpc/platforms/cell/cbe_thermal.c
> +++ b/arch/powerpc/platforms/cell/cbe_thermal.c
> @@ -381,6 +381,7 @@ static void __exit thermal_exit(void)
> }
> module_exit(thermal_exit);
>
> +MODULE_DESCRIPTION("Cell processor thermal driver");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Krafft ");
>
> diff --git a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> index ca7849e113d7..79172ba36eca 100644
> --- a/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> +++ b/arch/powerpc/platforms/cell/cpufreq_spudemand.c
> @@ -129,5 +129,6 @@ static struct cpufreq_governor spu_governor = {
> cpufreq_governor_init(spu_governor);
> cpufreq_governor_exit(spu_governor);
>
> +MODULE_DESCRIPTION("SPU-aware cpufreq governor for the cell processor");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Christian Kr
Re: [PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
On 7/1/2024 1:33 AM, Viresh Kumar wrote: > On 14-06-24, 23:08, Jeff Johnson wrote: >> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> drivers/cpufreq/ppc-cbe-cpufreq.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> drivers/cpufreq/powernv-cpufreq.o >> >> Add the missing invocation of the MODULE_DESCRIPTION() macro to all >> files which have a MODULE_LICENSE(). >> >> This includes three additional files which, although they did not >> produce a warning with the powerpc allmodconfig configuration, may >> cause this warning with specific options enabled in the kernel >> configuration. >> >> Signed-off-by: Jeff Johnson > > Acked-by: Viresh Kumar > I still don't see this in linux-next. Is anything else needed from me? Of the almost 300 patches I've submitted to fix these issues tree-wide, this is one of the 13 remaining. Hopefully this can make it into the 6.11 merge window. If not, Greg KH has indicated he'll take this as an -rc instead of waiting for 6.12.
Re: [PATCH v2 2/3] crypto: X25519 core functions for ppc64le
On 5/16/24 08:19, Danny Tsen wrote:
X25519 core functions to handle scalar multiplication for ppc64le.
Signed-off-by: Danny Tsen
---
arch/powerpc/crypto/curve25519-ppc64le-core.c | 299 ++
1 file changed, 299 insertions(+)
create mode 100644 arch/powerpc/crypto/curve25519-ppc64le-core.c
...
+MODULE_ALIAS_CRYPTO("curve25519");
+MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Danny Tsen ");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. I'm in the process of building
ppc64le with CRYPTO_CURVE25519_PPC64=m to validate my suspicion, but I
expect this to generate a warning.
Can you submit a follow-up patch that adds a MODULE_DESCRIPTION()?
And since I'm trying to fix all of the existing issues in 6.11, Herbert
can you push this to Linus when it lands?
Thanks,
/jeff
Re: [PATCH v2 2/3] crypto: X25519 core functions for ppc64le
On 7/18/2024 5:25 PM, Jeff Johnson wrote:
> On 5/16/24 08:19, Danny Tsen wrote:
>> X25519 core functions to handle scalar multiplication for ppc64le.
>>
>> Signed-off-by: Danny Tsen
>> ---
>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 299 ++
>> 1 file changed, 299 insertions(+)
>> create mode 100644 arch/powerpc/crypto/curve25519-ppc64le-core.c
> ...
>
>> +MODULE_ALIAS_CRYPTO("curve25519");
>> +MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_AUTHOR("Danny Tsen ");
>
> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
> description is missing"), a module without a MODULE_DESCRIPTION() will
> result in a warning with make W=1. I'm in the process of building
> ppc64le with CRYPTO_CURVE25519_PPC64=m to validate my suspicion, but I
> expect this to generate a warning.
>
> Can you submit a follow-up patch that adds a MODULE_DESCRIPTION()?
> And since I'm trying to fix all of the existing issues in 6.11, Herbert
> can you push this to Linus when it lands?
And my build did produce:
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/crypto/curve25519-ppc64le.o
[PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning with make W=1. The following warning is being
observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
WARNING: modpost: missing MODULE_DESCRIPTION() in
arch/powerpc/crypto/curve25519-ppc64le.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/crypto/curve25519-ppc64le-core.c
b/arch/powerpc/crypto/curve25519-ppc64le-core.c
index 4e3e44ea4484..f7810be0b292 100644
--- a/arch/powerpc/crypto/curve25519-ppc64le-core.c
+++ b/arch/powerpc/crypto/curve25519-ppc64le-core.c
@@ -295,5 +295,6 @@ module_exit(curve25519_mod_exit);
MODULE_ALIAS_CRYPTO("curve25519");
MODULE_ALIAS_CRYPTO("curve25519-ppc64le");
+MODULE_DESCRIPTION("PPC64le Curve25519 scalar multiplication with 51 bits
limbs");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Danny Tsen ");
---
base-commit: df1e9791998a92fe9f1e7d3f031b34daaad39e2f
change-id: 20240718-md-powerpc-arch-powerpc-crypto-2c96382d0eaf
Re: [PATCH] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
On 7/22/2024 12:13 AM, Michael Ellerman wrote:
> Jeff Johnson writes:
>> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/cpufreq/ppc-cbe-cpufreq.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> drivers/cpufreq/powernv-cpufreq.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro to all
>> files which have a MODULE_LICENSE().
>>
>> This includes three additional files which, although they did not
>> produce a warning with the powerpc allmodconfig configuration, may
>> cause this warning with specific options enabled in the kernel
>> configuration.
>>
>> Signed-off-by: Jeff Johnson
>> ---
>> Corrections to these descriptions are welcomed. I'm not an expert in
>> this code so in most cases I've taken these descriptions directly from
>> code comments, Kconfig descriptions, or git logs. History has shown
>> that in some cases these are originally wrong due to cut-n-paste
>> errors, and in other cases the drivers have evolved such that the
>> original information is no longer accurate.
>> ---
>> drivers/cpufreq/maple-cpufreq.c | 1 +
>> drivers/cpufreq/pasemi-cpufreq.c | 1 +
>> drivers/cpufreq/pmac64-cpufreq.c | 1 +
>> drivers/cpufreq/powernv-cpufreq.c | 1 +
>> drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
>> 5 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/cpufreq/maple-cpufreq.c
>> b/drivers/cpufreq/maple-cpufreq.c
>> index f9306410a07f..19ca7f874d28 100644
>> --- a/drivers/cpufreq/maple-cpufreq.c
>> +++ b/drivers/cpufreq/maple-cpufreq.c
>> @@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
>> module_init(maple_cpufreq_init);
>>
>>
>> +MODULE_DESCRIPTION("cpufreq driver for Maple 970FX Evaluation Board");
>
> Can you change this one to:
>
> "cpufreq driver for Maple 970FX/970MP boards");
>
> It looks for both those CPUs in probe.
>
>> diff --git a/drivers/cpufreq/powernv-cpufreq.c
>> b/drivers/cpufreq/powernv-cpufreq.c
>> index fddbd1ea1635..e923f717e1d7 100644
>> --- a/drivers/cpufreq/powernv-cpufreq.c
>> +++ b/drivers/cpufreq/powernv-cpufreq.c
>> @@ -1162,5 +1162,6 @@ static void __exit powernv_cpufreq_exit(void)
>> }
>> module_exit(powernv_cpufreq_exit);
>>
>> +MODULE_DESCRIPTION("cpufreq driver for the IBM POWER processors");
>
> This one's tricky, because it probes based on the device tree, though it
> is restricted to CONFIG_POWERNV. It also supports non-IBM CPUs in theory
> at least. Maybe something like:
>
> "cpufreq driver for IBM/OpenPOWER powernv systems");
>
> cheers
Sure, I'll send an update shortly.
/jeff
[PATCH v2] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/ppc-cbe-cpufreq.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/powernv-cpufreq.o
Add the missing invocation of the MODULE_DESCRIPTION() macro to all
files which have a MODULE_LICENSE().
This includes three additional files which, although they did not
produce a warning with the powerpc allmodconfig configuration, may
cause this warning with specific options enabled in the kernel
configuration.
Signed-off-by: Jeff Johnson
---
Changes in v2:
- Per Michael Ellerman updated maple-cpufreq.c and powernv-cpufreq.c
descriptions
- Did not carry forward Viresh Kumar's Acked-by due to this change
- Link to v1:
https://lore.kernel.org/r/20240614-md-powerpc-drivers-cpufreq-v1-1-de4034d87...@quicinc.com
---
drivers/cpufreq/maple-cpufreq.c | 1 +
drivers/cpufreq/pasemi-cpufreq.c | 1 +
drivers/cpufreq/pmac64-cpufreq.c | 1 +
drivers/cpufreq/powernv-cpufreq.c | 1 +
drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
index f9306410a07f..690da85c4865 100644
--- a/drivers/cpufreq/maple-cpufreq.c
+++ b/drivers/cpufreq/maple-cpufreq.c
@@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
module_init(maple_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for Maple 970FX/970MP boards");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
index ee925b53b6b9..5fc9cb480516 100644
--- a/drivers/cpufreq/pasemi-cpufreq.c
+++ b/drivers/cpufreq/pasemi-cpufreq.c
@@ -269,5 +269,6 @@ static void __exit pas_cpufreq_exit(void)
module_init(pas_cpufreq_init);
module_exit(pas_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for PA Semi PWRficient");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Egor Martovetsky , Olof Johansson
");
diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 2cd2b06849a2..9d3fe36075f8 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -671,4 +671,5 @@ static int __init g5_cpufreq_init(void)
module_init(g5_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for SMU & 970FX based G5 Macs");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 50c62929f7ca..bc55723b4d87 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -1160,5 +1160,6 @@ static void __exit powernv_cpufreq_exit(void)
}
module_exit(powernv_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for IBM/OpenPOWER powernv systems");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Vaidyanathan Srinivasan ");
diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c
b/drivers/cpufreq/ppc_cbe_cpufreq.c
index 5ee4c7bfdcc5..98595b3ea13f 100644
--- a/drivers/cpufreq/ppc_cbe_cpufreq.c
+++ b/drivers/cpufreq/ppc_cbe_cpufreq.c
@@ -168,5 +168,6 @@ static void __exit cbe_cpufreq_exit(void)
module_init(cbe_cpufreq_init);
module_exit(cbe_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for Cell BE processors");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
---
base-commit: 933069701c1b507825b514317d4edd5d3fd9d417
change-id: 20240614-md-powerpc-drivers-cpufreq-6d345e48164e
[PATCH 1/5] crypto: arm/xor - add missing MODULE_DESCRIPTION() macro
With ARCH=arm and CONFIG_KERNEL_MODE_NEON=y, make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/lib/xor-neon.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson
---
arch/arm/lib/xor-neon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c
index 522510baed49..cf57fca97908 100644
--- a/arch/arm/lib/xor-neon.c
+++ b/arch/arm/lib/xor-neon.c
@@ -8,6 +8,7 @@
#include
#include
+MODULE_DESCRIPTION("NEON accelerated XOR implementation");
MODULE_LICENSE("GPL");
#ifndef __ARM_NEON__
--
2.42.0
[PATCH 2/5] x86/mm: add testmmiotrace MODULE_DESCRIPTION()
Fix the following 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/mm/testmmiotrace.o
Signed-off-by: Jeff Johnson
---
arch/x86/mm/testmmiotrace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/mm/testmmiotrace.c b/arch/x86/mm/testmmiotrace.c
index bda73cb7a044..ae295659ca14 100644
--- a/arch/x86/mm/testmmiotrace.c
+++ b/arch/x86/mm/testmmiotrace.c
@@ -144,3 +144,4 @@ static void __exit cleanup(void)
module_init(init);
module_exit(cleanup);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Test module for mmiotrace");
--
2.42.0
[PATCH 4/5] fsi: add missing MODULE_DESCRIPTION() macros
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-core.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-hub.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/fsi/fsi-master-aspeed.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-master-gpio.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/fsi/fsi-master-ast-cf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fsi/fsi-scom.o
Add the missing invocations of the MODULE_DESCRIPTION() macro, and fix the
copy/paste of the module description comment in fsi-master-ast-cf.c.
Reviewed-by: Eddie James
Signed-off-by: Jeff Johnson
---
drivers/fsi/fsi-core.c | 1 +
drivers/fsi/fsi-master-aspeed.c | 1 +
drivers/fsi/fsi-master-ast-cf.c | 3 ++-
drivers/fsi/fsi-master-gpio.c | 1 +
drivers/fsi/fsi-master-hub.c| 1 +
drivers/fsi/fsi-scom.c | 1 +
6 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 46ac5a8beab7..e2e1e9df6115 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -1444,5 +1444,6 @@ static void fsi_exit(void)
}
module_exit(fsi_exit);
module_param(discard_errors, int, 0664);
+MODULE_DESCRIPTION("FSI core driver");
MODULE_LICENSE("GPL");
MODULE_PARM_DESC(discard_errors, "Don't invoke error handling on bus
accesses");
diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
index b0b624c3717b..6f5e1bdf7e40 100644
--- a/drivers/fsi/fsi-master-aspeed.c
+++ b/drivers/fsi/fsi-master-aspeed.c
@@ -670,4 +670,5 @@ static struct platform_driver fsi_master_aspeed_driver = {
};
module_platform_driver(fsi_master_aspeed_driver);
+MODULE_DESCRIPTION("FSI master driver for AST2600");
MODULE_LICENSE("GPL");
diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index f8c776ce1b56..a4c37ff8edd6 100644
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0+
// Copyright 2018 IBM Corp
/*
- * A FSI master controller, using a simple GPIO bit-banging interface
+ * A FSI master based on Aspeed ColdFire coprocessor
*/
#include
@@ -1438,5 +1438,6 @@ static struct platform_driver fsi_master_acf = {
};
module_platform_driver(fsi_master_acf);
+MODULE_DESCRIPTION("A FSI master based on Aspeed ColdFire coprocessor");
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(FW_FILE_NAME);
diff --git a/drivers/fsi/fsi-master-gpio.c b/drivers/fsi/fsi-master-gpio.c
index 10fc344b6b22..f761344f4873 100644
--- a/drivers/fsi/fsi-master-gpio.c
+++ b/drivers/fsi/fsi-master-gpio.c
@@ -892,4 +892,5 @@ static struct platform_driver fsi_master_gpio_driver = {
};
module_platform_driver(fsi_master_gpio_driver);
+MODULE_DESCRIPTION("A FSI master controller, using a simple GPIO bit-banging
interface");
MODULE_LICENSE("GPL");
diff --git a/drivers/fsi/fsi-master-hub.c b/drivers/fsi/fsi-master-hub.c
index 6d8b6e8854e5..6568fed7db3c 100644
--- a/drivers/fsi/fsi-master-hub.c
+++ b/drivers/fsi/fsi-master-hub.c
@@ -295,4 +295,5 @@ static struct fsi_driver hub_master_driver = {
};
module_fsi_driver(hub_master_driver);
+MODULE_DESCRIPTION("FSI hub master driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index 61dbda9dbe2b..411ddc018cd8 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -625,4 +625,5 @@ static void scom_exit(void)
module_init(scom_init);
module_exit(scom_exit);
+MODULE_DESCRIPTION("SCOM FSI Client device driver");
MODULE_LICENSE("GPL");
--
2.42.0
[PATCH 5/5] locking/ww_mutex/test: add MODULE_DESCRIPTION()
Fix the 'make W=1' warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/locking/test-ww_mutex.o
Signed-off-by: Jeff Johnson
---
kernel/locking/test-ww_mutex.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index 78719e1ef1b1..10a5736a21c2 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -697,3 +697,4 @@ module_exit(test_ww_mutex_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Intel Corporation");
+MODULE_DESCRIPTION("API test facility for ww_mutexes");
--
2.42.0
[PATCH 0/5] treewide: add missing MODULE_DESCRIPTION() macros
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1.
Recently, multiple developers have been eradicating these warnings
treewide, and I personally submitted almost 300 patches over the past
few months. Almost all of my patches landed by 6.11-rc1, either by
being merged in a 6.10-rc or by being merged in the 6.11 merge
window. However, a few of my patches did not land.
In some cases I see them in linux-next, but they did not land during
the merge window. I'm still monitoring those.
In a few cases I have not had any feedback that the patches have been
accepted into a maintainer's tree. At the advice of Greg KH I've
consolidated those patches into this single series with the hope these
can still land before 6.11-final.
https://lore.kernel.org/all/2024071518-ridden-election-8118@gregkh/
Links to the original individual patches:
crypto: arm/xor - add missing MODULE_DESCRIPTION() macro
https://lore.kernel.org/all/20240711-md-arm-arch-arm-lib-v2-1-ab08653dc...@quicinc.com/
x86/mm: add testmmiotrace MODULE_DESCRIPTION()
https://lore.kernel.org/all/20240515-testmmiotrace-md-v1-1-10919a8b2...@quicinc.com/
cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
https://lore.kernel.org/all/20240722-md-powerpc-drivers-cpufreq-v2-1-bb84d715e...@quicinc.com/
fsi: add missing MODULE_DESCRIPTION() macros
https://lore.kernel.org/all/20240605-md-drivers-fsi-v1-1-fefc82d81...@quicinc.com/
locking/ww_mutex/test: add MODULE_DESCRIPTION()
https://lore.kernel.org/all/20240528-md-test-ww_mutex-v2-1-a2a19e920...@quicinc.com/
---
Jeff Johnson (5):
crypto: arm/xor - add missing MODULE_DESCRIPTION() macro
x86/mm: add testmmiotrace MODULE_DESCRIPTION()
cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
fsi: add missing MODULE_DESCRIPTION() macros
locking/ww_mutex/test: add MODULE_DESCRIPTION()
arch/arm/lib/xor-neon.c | 1 +
arch/x86/mm/testmmiotrace.c | 1 +
drivers/cpufreq/maple-cpufreq.c | 1 +
drivers/cpufreq/pasemi-cpufreq.c | 1 +
drivers/cpufreq/pmac64-cpufreq.c | 1 +
drivers/cpufreq/powernv-cpufreq.c | 1 +
drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
drivers/fsi/fsi-core.c| 1 +
drivers/fsi/fsi-master-aspeed.c | 1 +
drivers/fsi/fsi-master-ast-cf.c | 3 ++-
drivers/fsi/fsi-master-gpio.c | 1 +
drivers/fsi/fsi-master-hub.c | 1 +
drivers/fsi/fsi-scom.c| 1 +
kernel/locking/test-ww_mutex.c| 1 +
14 files changed, 15 insertions(+), 1 deletion(-)
---
base-commit: 94ede2a3e9135764736221c080ac7c0ad993dc2d
change-id: 20240730-module_description_orphans-cb5e25fe1656
[PATCH 3/5] cpufreq: powerpc: add missing MODULE_DESCRIPTION() macros
With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/ppc-cbe-cpufreq.o
WARNING: modpost: missing MODULE_DESCRIPTION() in
drivers/cpufreq/powernv-cpufreq.o
Add the missing invocation of the MODULE_DESCRIPTION() macro to all
files which have a MODULE_LICENSE().
This includes three additional files which, although they did not
produce a warning with the powerpc allmodconfig configuration, may
cause this warning with specific options enabled in the kernel
configuration.
Acked-by: Viresh Kumar
Acked-by: Michael Ellerman
Signed-off-by: Jeff Johnson
---
drivers/cpufreq/maple-cpufreq.c | 1 +
drivers/cpufreq/pasemi-cpufreq.c | 1 +
drivers/cpufreq/pmac64-cpufreq.c | 1 +
drivers/cpufreq/powernv-cpufreq.c | 1 +
drivers/cpufreq/ppc_cbe_cpufreq.c | 1 +
5 files changed, 5 insertions(+)
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
index f9306410a07f..690da85c4865 100644
--- a/drivers/cpufreq/maple-cpufreq.c
+++ b/drivers/cpufreq/maple-cpufreq.c
@@ -238,4 +238,5 @@ static int __init maple_cpufreq_init(void)
module_init(maple_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for Maple 970FX/970MP boards");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
index ee925b53b6b9..5fc9cb480516 100644
--- a/drivers/cpufreq/pasemi-cpufreq.c
+++ b/drivers/cpufreq/pasemi-cpufreq.c
@@ -269,5 +269,6 @@ static void __exit pas_cpufreq_exit(void)
module_init(pas_cpufreq_init);
module_exit(pas_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for PA Semi PWRficient");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Egor Martovetsky , Olof Johansson
");
diff --git a/drivers/cpufreq/pmac64-cpufreq.c b/drivers/cpufreq/pmac64-cpufreq.c
index 2cd2b06849a2..9d3fe36075f8 100644
--- a/drivers/cpufreq/pmac64-cpufreq.c
+++ b/drivers/cpufreq/pmac64-cpufreq.c
@@ -671,4 +671,5 @@ static int __init g5_cpufreq_init(void)
module_init(g5_cpufreq_init);
+MODULE_DESCRIPTION("cpufreq driver for SMU & 970FX based G5 Macs");
MODULE_LICENSE("GPL");
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 50c62929f7ca..bc55723b4d87 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -1160,5 +1160,6 @@ static void __exit powernv_cpufreq_exit(void)
}
module_exit(powernv_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for IBM/OpenPOWER powernv systems");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Vaidyanathan Srinivasan ");
diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c
b/drivers/cpufreq/ppc_cbe_cpufreq.c
index 5ee4c7bfdcc5..98595b3ea13f 100644
--- a/drivers/cpufreq/ppc_cbe_cpufreq.c
+++ b/drivers/cpufreq/ppc_cbe_cpufreq.c
@@ -168,5 +168,6 @@ static void __exit cbe_cpufreq_exit(void)
module_init(cbe_cpufreq_init);
module_exit(cbe_cpufreq_exit);
+MODULE_DESCRIPTION("cpufreq driver for Cell BE processors");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Christian Krafft ");
--
2.42.0
Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
On 8/2/2024 6:15 AM, Herbert Xu wrote:
> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
>> description is missing"), a module without a MODULE_DESCRIPTION() will
>> result in a warning with make W=1. The following warning is being
>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>>
>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>> arch/powerpc/crypto/curve25519-ppc64le.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson
>> ---
>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Patch applied. Thanks.
Great, that was the last of my MODULE_DESCRIPTION patches!!!
There are a few more instances of the warning that Arnd has patches for,
covering issues that appear in randconfigs that I didn't test.
/jeff
Re: [PATCH] crypto: ppc/curve25519 - add missing MODULE_DESCRIPTION() macro
On 8/2/2024 8:16 AM, Arnd Bergmann wrote:
> On Fri, Aug 2, 2024, at 16:27, Jeff Johnson wrote:
>> On 8/2/2024 6:15 AM, Herbert Xu wrote:
>>> On Thu, Jul 18, 2024 at 06:14:18PM -0700, Jeff Johnson wrote:
>>>> Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
>>>> description is missing"), a module without a MODULE_DESCRIPTION() will
>>>> result in a warning with make W=1. The following warning is being
>>>> observed when building ppc64le with CRYPTO_CURVE25519_PPC64=m:
>>>>
>>>> WARNING: modpost: missing MODULE_DESCRIPTION() in
>>>> arch/powerpc/crypto/curve25519-ppc64le.o
>>>>
>>>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>>>
>>>> Signed-off-by: Jeff Johnson
>>>> ---
>>>> arch/powerpc/crypto/curve25519-ppc64le-core.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Patch applied. Thanks.
>>
>> Great, that was the last of my MODULE_DESCRIPTION patches!!!
>>
>> There are a few more instances of the warning that Arnd has patches for,
>> covering issues that appear in randconfigs that I didn't test.
>
> Are all of your patches in linux-next now, or is there a another
> git tree that has them all?
>
> I can send the ones I have left, but I want to avoid duplication.
>
> Arnd
When this one lands they'll all be in linux-next
Re: [PATCHES] drm/radeon issues
On 10/10/24 06:57, Christian Zigotzky wrote: > Hi All, > > There is another issue with the Radeon DRM driver but there is already a > patch available for this issue. > > Link: > https://lists.freedesktop.org/archives/dri-devel/2024-October/473314.html > > I compiled a new RC2 of kernel 6.12 with this patch for the X1000 and X5000 > today. > > Download: https://github.com/chzigotzky/kernels/releases/tag/v6.12.0-rc2-2 > > We need 3 patches for the Radeon DRM driver currently. Can you provide links to all 3 patches? 6.12-rc2 was back merged to my ath.git project, but then my laptop stopped booting correctly and I discovered a few Radeon KASAN reports. Based upon my search of lore I found: 20241003060650.18454-1-wuhoi...@gmail.com [PATCH] drm/radeon: add late_register for connector 20241007183241.1584-1-christian.koe...@amd.com [PATCH] drm/radeon: always set GEM function pointer But that is only 2 patches.
Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()
On 11/15/2024 1:29 PM, Easwar Hariharan wrote: > On 11/15/2024 1:26 PM, Easwar Hariharan wrote: >> This is a series that follows up on my previous series to introduce >> secs_to_jiffies() and convert a few initial users.[1] In the review for >> that series, Anna-Maria requested converting other users with >> Coccinelle. This is part 1 that converts users of msecs_to_jiffies() >> that use the multiply pattern of either of: >> - msecs_to_jiffies(N*1000), or >> - msecs_to_jiffies(N*MSEC_PER_SEC) >> >> The entire conversion is made with Coccinelle in the script added in >> patch 2. Some changes suggested by Coccinelle have been deferred to >> later parts that will address other possible variant patterns. >> >> CC: Anna-Maria Behnsen >> Signed-off-by: Easwar Hariharan >> >> [1] >> https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-0-9ba123fac...@linux.microsoft.com/ >> [2] https://lore.kernel.org/all/8734kngfni.fsf@somnus/ >> >> --- >> Changes in v2: >> - EDITME: describe what is new in this series revision. >> - EDITME: use bulletpoints and terse descriptions. >> - Link to v1: >> https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v1-0-19aadc349...@linux.microsoft.com >> > > Apologies, I missed out on editing the changelog here. v1 included a > patch that's already been accepted, there are no other changes in v2. > > Thanks, > Easwar How do you expect this series to land since it overlaps a large number of maintainer trees? Do you have a maintainer who has volunteered to take the series and the maintainers should just ack? Or do you want the maintainers to take the individual patches that are applicable to them? /jeff
Re: [PATCH v2 15/21] wifi: ath11k: Convert timeouts to secs_to_jiffies()
On 11/15/2024 1:26 PM, Easwar Hariharan wrote: > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan Acked-by: Jeff Johnson > --- > drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c > b/drivers/net/wireless/ath/ath11k/debugfs.c > index > 57281a135dd7fa6b8610636f47873c8bba21053c..bf192529e3fe26a91e72105a77b4c6f849b905ec > 100644 > --- a/drivers/net/wireless/ath/ath11k/debugfs.c > +++ b/drivers/net/wireless/ath/ath11k/debugfs.c > @@ -178,7 +178,7 @@ static int ath11k_debugfs_fw_stats_request(struct ath11k > *ar, >* received 'update stats' event, we keep a 3 seconds timeout in case, >* fw_stats_done is not marked yet >*/ > - timeout = jiffies + msecs_to_jiffies(3 * 1000); > + timeout = jiffies + secs_to_jiffies(3); > > ath11k_debugfs_fw_stats_reset(ar); > >
Re: [PATCH 22/22] jiffies: Define secs_to_jiffies()
On 11/15/2024 1:22 PM, Easwar Hariharan wrote: > secs_to_jiffies() is defined in hci_event.c and cannot be reused by > other call sites. Hoist it into the core code to allow conversion of the > ~1150 usages of msecs_to_jiffies() that either: > > - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or > - have timeouts that are denominated in seconds (i.e. end in 000) > > It's implemented as a macro to allow usage in static initializers. > > This will also allow conversion of yet more sites that use (sec * HZ) > directly, and improve their readability. > > Suggested-by: Michael Kelley > Signed-off-by: Easwar Hariharan > Signed-off-by: Thomas Gleixner > Reviewed-by: Luiz Augusto von Dentz > Link: > https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123fac...@linux.microsoft.com your signed-off-by should be last. and you have a patch ordering problem since this patch must come before all the patches that use secs_to_jiffies(), otherwise this series cannot be bisected
Re: [PATCH v3 00/19] Converge on using secs_to_jiffies()
On 12/10/2024 2:02 PM, Easwar Hariharan wrote: > This is a series that follows up on my previous series to introduce > secs_to_jiffies() and convert a few initial users.[1] In the review for > that series, Anna-Maria requested converting other users with > Coccinelle. [2] This is part 1 that converts users of msecs_to_jiffies() > that use the multiply pattern of either of: > - msecs_to_jiffies(N*1000), or > - msecs_to_jiffies(N*MSEC_PER_SEC) > > where N is a constant, to avoid the multiplication. > > The entire conversion is made with Coccinelle in the script added in > patch 2. Some changes suggested by Coccinelle have been deferred to > later parts that will address other possible variant patterns. > > CC: Anna-Maria Behnsen > Signed-off-by: Easwar Hariharan I have the same question as before: How do you expect these to land? Do you now have a maintainer who will take all of them? Or do you want individual maintainers to take the ones applicable to them? /jeff
