Fwd: Lilypond/LSR graphics
Hi all, Seba needed to move the LSR to a new server. Most problems seems to be fixed now apart from those below. I've no experience with a jailed LilyPond, so any help appreciated. >From the logs: I'm not sure about those texgyre warnings, those fonts were not required with 2.18.2. Also I vaguely seem to remember about some problems with gs 9.20 and/or cairo, (I may be wrong here.) Cheers, Harm -- Forwarded message -- From: Sebastiano Vigna Date: 2017-03-18 0:35 GMT+01:00 Subject: Re: Lilypond/LSR graphics To: Pierre Perol-Schneider Cc: Thomas Morley , Phil Holmes I have been able to fix 99% of the problems. Presently, the six snippet below cannot be compiled because of font problems (see the log). Sometimes a font is not found, sometimes a glyph. This does NOT HAPPEN unless lilypond is jailed. That is, I can compile these snippets from the command line. Which means that there's some library or data that I haven't moved to the jail and that is necessary to compile correctly. If anybody has a clue looking at the log, please tell me. Otherwise in the weekend I'll do a trial-and-error session to find which pieces are missing from the jail (presently there's guile, pango and cairo). Ciao, seba *** Updating snippet "Changing the default text font family" (id=221)... *** done. *** Updating snippet "Aligning marks with various notation objects" (id=433)... *** done. *** Updating snippet "Metronome marks with more options" (id=1008)... *** done. *** Updating snippet "Changing breathe marks to markup text" (id=640)... *** done. *** Updating snippet "Use custom font's flat (b) and sharp (#) symbols for chords" (id=750)... *** done. *** Updating snippet "tempo (metronome) marks with approximation sign" (id=869)... *** done. lsr_log Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Prevent race condition in font export directory making (issue 319510043 by truer...@gmail.com)
https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm#newcode551 scm/framework-ps.scm:551: (let ((errno (system-error-errno stuff))) This is just (if (= EEXIST (system-error-errno stuff)) (ly:debug ...) (throw 'system-error (cdr stuff))) https://codereview.appspot.com/319510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Lilypond/LSR graphics
Hello, On Sun, 19 Mar 2017 09:38:16 +0100 Thomas Morley wrote: > Hi all, > > Seba needed to move the LSR to a new server. > Most problems seems to be fixed now apart from those below. > > I've no experience with a jailed LilyPond, so any help appreciated. > > >From the logs: I'm not sure about those texgyre warnings, those > >fonts > were not required with 2.18.2. Also I vaguely seem to remember about > some problems with gs 9.20 and/or cairo, (I may be wrong here.) version 2.19.26 TexGyre fonts were introduced here: https://codereview.appspot.com/258250043/ (August 2015). Most linux distributions will install the OTF files from their local repos fonts-texgyre Some even include them now as part of the 'build-dep' LilyPond files that you can download. See: http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#requirements-for-compiling-lilypond This lists a number of the more 'popular' distributions step-by-step to install all the required dependencies. However in the 'Other' Linux section at the end, I have documented this for those that don't provide the OTF files for the fonts. --snip-- TeX Gyre ‘OTF’ font packages. As of LilyPond version 2.19.26, the previous default serif, san serif and monospace fonts now use Tex Gyre’s Schola, Heros and Cursor fonts respectively. Also See Fonts. Some distributions do not always provide ‘OTF’ font files in the Tex Gyre packages from their repositories. Use the command fc-list | grep texgyre to list the fonts available to your system and check that the appropriate *.otf files are reported. If they are not then download and manually extract the ‘OTF’ files to either your local ~/.fonts/ directory or use the configure command and the --with-texgyre-dir=/path_to_otf_files/ option. The following font families are required: Schola - http://www.gust.org.pl/projects/e-foundry/tex-gyre/schola Heros - http://www.gust.org.pl/projects/e-foundry/tex-gyre/heros Cursor - http://www.gust.org.pl/projects/e-foundry/tex-gyre/cursor --snip-- Also the same developer (Masamichi Hosada) added support for creating the PDFs with 'XeteX' (*if* it is installed) to create the PDFs instead of the default pdf2tex - I don't know if that matters to the LSR. Finally, and there are some trackers for this (including to update the CG), Masamichi updated the configure scripts to post a warning if URW++ fonts are not installed - but they are not 'required'. https://sourceforge.net/p/testlilyissues/issues/search/?q=URW I hope this helps. James > > Cheers, > Harm > > > -- Forwarded message -- > From: Sebastiano Vigna > Date: 2017-03-18 0:35 GMT+01:00 > Subject: Re: Lilypond/LSR graphics > To: Pierre Perol-Schneider > Cc: Thomas Morley , Phil Holmes > > > > I have been able to fix 99% of the problems. > > Presently, the six snippet below cannot be compiled because of font > problems (see the log). Sometimes a font is not found, sometimes a > glyph. > > This does NOT HAPPEN unless lilypond is jailed. That is, I can compile > these snippets from the command line. > > Which means that there's some library or data that I haven't moved to > the jail and that is necessary to compile correctly. If anybody has a > clue looking at the log, please tell me. Otherwise in the weekend I'll > do a trial-and-error session to find which pieces are missing from the > jail (presently there's guile, pango and cairo). > > Ciao, > > seba > > > > *** Updating snippet "Changing the default text font > family" (id=221)... *** done. > > *** Updating snippet "Aligning marks with various notation > objects" (id=433)... > *** done. > > *** Updating snippet "Metronome marks with more > options" (id=1008)... *** done. > > *** Updating snippet "Changing breathe marks to markup > text" (id=640)... *** done. > > *** Updating snippet "Use custom font's flat (b) and sharp (#) > symbols for chords" (id=750)... > *** done. > > *** Updating snippet "tempo (metronome) marks with > approximation sign" (id=869)... > *** done. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Lilypond/LSR graphics
Sebastiano, On Sun, 19 Mar 2017 12:54:04 +0100 Sebastiano Vigna wrote: > > On 19 Mar 2017, at 12:32, James wrote: > > > > CG), Masamichi updated the configure scripts to post a warning if > > URW++ fonts are not installed - but they are not 'required'. > > > > https://sourceforge.net/p/testlilyissues/issues/search/?q=URW > > > > > > I hope this helps. > > Thanks! The problem appears to be some weird consequence of the jail. > If I compile without jailing, the font file opens without problem. > But inside the jail, lilypond cannot open the font file *even if the > file is there*. I can see the system calls for the same file in the > two cases: one ends with OK, the other with a "NOT FOUND" error. But > I a do have installed a copy of that file inside the jail. Grrr. You can run configure with an explicit path-to-the-font switch or copy the fonts in ~/.fonts - in case one method works and the other doesn't. I wonder if you could spend a couple of minutes looking at http://lilypond.org/doc/v2.19/Documentation/usage-big-page.html#lilypond-in-chroot-jail As I assume this is what you are doing? if it is this section hasn't been updated since I started working on LP, so if you spot anything that needs updating/changing, let me know and I can update our documentation. Thanks James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for Sunday March 19th
Hello, Here is the current patch countdown list. The next countdown will be on March 22nd A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5096 MultiMeasureRest causes MultiMeasureRestNumber - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5096 http://codereview.appspot.com/315710043 5094 Change error message for unrecognized strings - David Kastrup https://sourceforge.net/p/testlilyissues/issues/5094 http://codereview.appspot.com/321720043 5092 Doc: change name of file feta-font.itexi to emmentaler.itexi - James Lowe https://sourceforge.net/p/testlilyissues/issues/5092 http://codereview.appspot.com/314630043 5077 build fail on GNU Hurd because of PATH_MAX - Masamichi Hosoda https://sourceforge.net/p/testlilyissues/issues/5077 http://codereview.appspot.com/320360043 Countdown: 5098 Fix some programming errors "no interface for property" - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/5098 http://codereview.appspot.com/321730043 5075 Web: nest GSOC project ideas under subsection/h3 - Paul Morris https://sourceforge.net/p/testlilyissues/issues/5075 http://codereview.appspot.com/314530043 Review: 4164 Patch: Additions in event-listener.ly - James Lowe https://sourceforge.net/p/testlilyissues/issues/4164 http://codereview.appspot.com/152600043 New: No new patches at this time. Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Lilypond/LSR graphics
> On 19 Mar 2017, at 12:32, James wrote: > > CG), Masamichi updated the configure scripts to post a warning if URW++ > fonts are not installed - but they are not 'required'. > > https://sourceforge.net/p/testlilyissues/issues/search/?q=URW > > > I hope this helps. Thanks! The problem appears to be some weird consequence of the jail. If I compile without jailing, the font file opens without problem. But inside the jail, lilypond cannot open the font file *even if the file is there*. I can see the system calls for the same file in the two cases: one ends with OK, the other with a "NOT FOUND" error. But I a do have installed a copy of that file inside the jail. Grrr. Ciao, seba ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
[guile-2.2] patches
Hi all, guile-2.2 is released. So I plan to implement most patches from the remotes/origin/dev/guile-v2-work-branch and those I've put locally on top of it. This will sometimes require some updating of those patches. Most of them were created to make lily work with guile-2.0.x. Also, I'd like to check whether those patches are still all needed: guile-devs claimed a far better port-encoding-handling wrt to utf-8, etc. We will see... The main question: I'd like to facilitate review by putting them on one by one. Though this may result in commits with only partly working LilyPond, if compiled with guile-2.2 For example the attached. It makes configure find all the needed files when done with --enable-guile2 But make will fail. (lily with guile-1.8 should be unaffected.) It's meant to replace fd6919c8fec9a61d1c7b6abc54ac5607bd62a0b9 from branch remotes/origin/dev/guile-v2-work How to proceed? Cheers, Harm From c4ec7dadd372a0e7f148bcfeacff382add548745 Mon Sep 17 00:00:00 2001 From: Thomas Morley Date: Sun, 19 Mar 2017 14:29:04 +0100 Subject: [PATCH] Let configure find all needed files with guile-2.2 in configure.ac Adds support for STEPMAKE_GUILE Update guile-versions for STEPMAKE_GUILE and STEPMAKE_GUILE_DEVEL in aclocal.m4 update the list to search for guile-config Many thanks to Antonio Ospite --- aclocal.m4 | 2 +- configure.ac | 10 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index ed47b83..6624a5e 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -658,7 +658,7 @@ AC_DEFUN(STEPMAKE_GUILE_DEVEL, [ AC_MSG_CHECKING([for guile-config]) guile_config="guile-config" found="no" -for r in $GUILE_CONFIG $target_guile_config $host_guile_config $build_guile_config guile-config guile2-config guile2.0-config guile-2.0-config guile1-config guile1.9-config guile1.8-config guile-1-config guile-1.9-config guile-1.8-config; do +for r in $GUILE_CONFIG $target_guile_config $host_guile_config $build_guile_config guile-config guile-2.2-config guile2.2-config guile2-config guile2.0-config guile-2.0-config guile1-config guile1.9-config guile1.8-config guile-1-config guile-1.9-config guile-1.8-config; do exe=`STEPMAKE_GET_EXECUTABLE($r)` if ! $exe --version > /dev/null 2>&1 ; then continue diff --git a/configure.ac b/configure.ac index d77ea15..ffdc24d 100644 --- a/configure.ac +++ b/configure.ac @@ -181,7 +181,7 @@ STEPMAKE_TEXMF(REQUIRED) STEPMAKE_TEXMF_DIRS(REQUIRED) if test "$GUILEv2" = "yes" then -STEPMAKE_GUILE_DEVEL(REQUIRED, 2.0.7, 2.2.0) +STEPMAKE_GUILE_DEVEL(REQUIRED, 2.0.7, 2.3.0) else STEPMAKE_GUILE_DEVEL(REQUIRED, 1.8.2, 1.9.0) fi @@ -267,7 +267,13 @@ STEPMAKE_FREETYPE2(freetype2, REQUIRED, 2.1.10) STEPMAKE_WINDOWS # guile executable for some scripts -STEPMAKE_GUILE(OPTIONAL, 1.8.2, 1.9.0) + # guile executable for some scripts + if test "$GUILEv2" = "yes" + then + STEPMAKE_GUILE(OPTIONAL, 2.0.7, 2.3.0) + else + STEPMAKE_GUILE(OPTIONAL, 1.8.2, 1.9.0) + fi # perl for help2man and for mf2pt1.pl STEPMAKE_PERL(REQUIRED) -- 2.7.4 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
2017-03-19 15:11 GMT+01:00 Thomas Morley : > For example the attached. Just found some bads in it, mostly c/p-errors. Not shrinking the functionality, though. Already corrected locally. Cheers, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
Thomas Morley writes: > Hi all, > > guile-2.2 is released. So I plan to implement most patches from the > remotes/origin/dev/guile-v2-work-branch and those I've put locally on > top of it. > > This will sometimes require some updating of those patches. Most of > them were created to make lily work with guile-2.0.x. Also, I'd like > to check whether those patches are still all needed: guile-devs > claimed a far better port-encoding-handling wrt to utf-8, etc. We will > see... > > The main question: > I'd like to facilitate review by putting them on one by one. > Though this may result in commits with only partly working LilyPond, > if compiled with guile-2.2 Well, that's not exactly a regression. > For example the attached. > It makes configure find all the needed files when done with --enable-guile2 > But make will fail. > (lily with guile-1.8 should be unaffected.) The problem is more that Guile-2.0 will not work at all any more, and it will take some time until Guile-2.2 becomes generally available. Now it's not like compilation with Guile-2.0 is doing us a lot of favors anyway. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
Am 19.03.2017 um 15:43 schrieb David Kastrup: > The problem is more that Guile-2.0 will not work at all any more, and it > will take some time until Guile-2.2 becomes generally available. Now > it's not like compilation with Guile-2.0 is doing us a lot of favors > anyway. I think that's what Harm wanted to imply and suggest (to drop any efforts towards Guile 2.0). -- u...@openlilylib.org https://openlilylib.org http://lilypondblog.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Prevent race condition in font export directory making (issue 319510043 by truer...@gmail.com)
Thank you for your reviewing. https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): https://codereview.appspot.com/319510043/diff/1/scm/framework-ps.scm#newcode551 scm/framework-ps.scm:551: (let ((errno (system-error-errno stuff))) On 2017/03/19 11:08:07, dak wrote: This is just (if (= EEXIST (system-error-errno stuff)) (ly:debug ...) (throw 'system-error (cdr stuff))) Done. https://codereview.appspot.com/319510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
2017-03-19 15:59 GMT+01:00 Urs Liska : > > > Am 19.03.2017 um 15:43 schrieb David Kastrup: >> The problem is more that Guile-2.0 will not work at all any more, and it >> will take some time until Guile-2.2 becomes generally available. Now >> it's not like compilation with Guile-2.0 is doing us a lot of favors >> anyway. > > I think that's what Harm wanted to imply and suggest (to drop any > efforts towards Guile 2.0). Well, the above attached patch works with guile-2.0.14 as well. Just tested. Though, the question remains what to do? (Some thoughts:) For both guile-versions we lack a method to deal with .go-files. Although I always happily test, I'm afraid I can't help with it. I have the feeling already touching the limits of my current skills. Also, for both guile-versions (more for 2.0.14) encoding and string-handling-issues may persist. I'm aware of your thoughts here http://lists.gnu.org/archive/html/guile-user/2017-03/msg00112.html Though, I think it's out of my depth as well. Forking guile-1.8 was discussed as well. Currently I have builds for guile-1.8.8, 2.0.14 and 2.2.0 on my computer, all working. It would be nice we could move to guile 2.2. As guile-devs claimed, I think I can confirm memory-handling is far better with guile 2.x. While forking 1.8 we wouldn't benefit from it. For huge scores my small laptop needs to be restarted every time I compile a huge score with lily-guile-1.8. That's a pain. Far better with guile 2.x Ok, lilypond is (sometimes much) slower (even slower with 2.0.14), that's the main drawback from a user's point of view. But back to the initial question. Possibilities: (1) I could try to revise the guile2-patches and implement them in master. (2) Doing the same but placing them in a new public branch for guile-2.2 (3) We could fork guile-1.8. I think we need a consensus or at least sort of a roadmap. Cheers, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
Thomas Morley writes: > But back to the initial question. > > Possibilities: > (1) I could try to revise the guile2-patches and implement them in master. > (2) Doing the same but placing them in a new public branch for guile-2.2 > (3) We could fork guile-1.8. > > I think we need a consensus or at least sort of a roadmap. My take is the following: a) for the precompiled LilyPond versions, foregoing Guile-1.8 is not a sensible option at the moment. We need to provide something working well. If I remember correctly, we don't need to fork yet, right? b) We want the guile-2-patches in master (with suitable guards/wrappers so that Guile-1.8 keeps working). If possible and feasible, in a working state for both 2.0 and 2.2. If not possible/feasible, focusing on Guile 2.2. We are spread thin enough with porting work as we are, and it does appear like Guile 2.2 is not going to end up as a dead-end version, at least in comparison to Guile 2.0. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [guile-2.2] patches
2017-03-19 18:05 GMT+01:00 David Kastrup : > Thomas Morley writes: > >> But back to the initial question. >> >> Possibilities: >> (1) I could try to revise the guile2-patches and implement them in master. >> (2) Doing the same but placing them in a new public branch for guile-2.2 >> (3) We could fork guile-1.8. >> >> I think we need a consensus or at least sort of a roadmap. > > My take is the following: > > a) for the precompiled LilyPond versions, foregoing Guile-1.8 is not a > sensible option at the moment. We need to provide something working > well. If I remember correctly, we don't need to fork yet, right? Not that I'm aware of any need to do it _now_. > > b) We want the guile-2-patches in master (with suitable guards/wrappers > so that Guile-1.8 keeps working). If possible and feasible, in a > working state for both 2.0 and 2.2. If not possible/feasible, focusing > on Guile 2.2. We are spread thin enough with porting work as we are, > and it does appear like Guile 2.2 is not going to end up as a dead-end > version, at least in comparison to Guile 2.0. Ok, will do. issue 5098 and 5099 were already up. Not really special for guile2, but at some point of time they needed to be done anyway. Cheers, Harm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix some warnings about string-delete and string-filter argument order (issue 318680043 by thomasmorle...@gmail.com)
Reviewers: , Message: This replaces 333eaf6cee3f1717f91a1a0f70592021daeaad38 from branch remotes/origin/dev/guile-v2-work Please review. Description: Fix some warnings about string-delete and string-filter argument order This makes guile2 stop printing some warning messages: Guile used to use the wrong argument order for string-delete. This call to string-filter had the arguments in the wrong order. See SRFI-13 for more details. At some point we will remove this hack. guile-1.8 will continue working. Please review this at https://codereview.appspot.com/318680043/ Affected files (+11, -5 lines): M scm/graphviz.scm M scm/lily.scm M scm/lily-library.scm Index: scm/graphviz.scm diff --git a/scm/graphviz.scm b/scm/graphviz.scm index 61fa5b1e1b7c3158f97864068cd8eeb6d6f939fe..657fdb23b3e00e5233c583ad8b31bd19ea4c4c84 100644 --- a/scm/graphviz.scm +++ b/scm/graphviz.scm @@ -69,7 +69,9 @@ es) (for-each (lambda (c) (format out "subgraph cluster_~a {\nlabel= \"~a\"\ncolor=blue\n" -(string-filter (car c) char-alphabetic?) +(if (guile-v2) +(string-filter char-alphabetic? (car c)) +(string-filter (car c) char-alphabetic?)) (car c)) (for-each (lambda (n) (format out "~a\n" n)) (cdr c)) (display "}\n" out)) Index: scm/lily-library.scm diff --git a/scm/lily-library.scm b/scm/lily-library.scm index c6f066ca3284918723d1be4b8a859d8801f2c2a8..1b3926af7fc98c88160f46fea01c43cb17b5c6d9 100644 --- a/scm/lily-library.scm +++ b/scm/lily-library.scm @@ -778,9 +778,9 @@ as rectangular coordinates @code{(x-length . y-length)}." (define-public (remove-whitespace strg) "Remove characters satisfying @code{char-whitespace?} from string @var{strg}" - (string-delete -strg -char-whitespace?)) + (if (guile-v2) + (string-delete char-whitespace? strg) + (string-delete strg char-whitespace?)) (define-public (string-encode-integer i) (cond Index: scm/lily.scm diff --git a/scm/lily.scm b/scm/lily.scm index d4553eec19fe74103f772abcf001a7fe7225cf54..4b3c9c7e1c4cad55c64a53fe611d1effcf692612 100644 --- a/scm/lily.scm +++ b/scm/lily.scm @@ -963,7 +963,11 @@ PIDs or the number of the process." (remove string-null? (append-map (lambda (f) - (string-split (string-delete (ly:gulp-file f) #\cr) #\nl)) + (string-split + (if (guile-v2) + (string-delete #\cr (ly:gulp-file f)) + (string-delete (ly:gulp-file f) #\cr)) + #\nl)) files (if (and (number? (ly:get-option 'job-count)) (>= (length files) (ly:get-option 'job-count))) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fw: Lilypond/LSR graphics
Begin forwarded message: Date: Sun, 19 Mar 2017 15:59:13 +0100 From: Sebastiano Vigna To: James Subject: Re: Lilypond/LSR graphics > On 19 Mar 2017, at 13:37, James wrote: > > http://lilypond.org/doc/v2.19/Documentation/usage-big-page.html#lilypond-in-chroot-jail > > As I assume this is what you are doing? So, the script for copying libraries doesn't work here but I understood the concept and try it. Turns out the answer is MUCH simpler! I forgot -L while copying the fonts in the jail. At at high lever, tex-gyre fonts are linked to the texlive distribution. Everything is fine now. Ciao, seba ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel