Re: Issue 4205: Improve part combiner's rest analysis (issue 174610043 by nine.fierce.ball...@gmail.com)

2014-11-28 Thread Urs Liska

As already stated, LGTM.

I'd be happy if this patch could make it into 2.19.16 because it's 
useful for our crowd engraving project.
I *can* set the requirements to >= 2.19.16, but I can't ask contributors 
to use custom-build LilyPonds or to patch their installation.


Best
Urs

Am 24.11.2014 06:12, schrieb nine.fierce.ball...@gmail.com:

Reviewers: ,

Description:
Issue 4205: Improve part combiner's rest analysis

Rests must begin and end simultaneously to be merged into the shared
voice.

Rests, skips, and multi-measure rests are kept apart even if they
begin and end simultaneously.

This does not produce ideal output in every case, but it avoids
producing musical nonsense.

Please review this at https://codereview.appspot.com/174610043/

Affected files (+131, -4 lines):
  A input/regression/part-combine-mmrest-shared.ly
  A input/regression/part-combine-silence.ly
  A input/regression/part-combine-silence-mixed.ly
  M scm/part-combiner.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Alternative Quarter Rest

2014-11-28 Thread Werner LEMBERG

> I’ve attached a PDF for visual inspection.

Thanks.

> Should I write a regtest and post a code review or does it need more
> work?

I think that the symbol itself could be improved.  Somehow the slant
of the diagonal line looks to steep, so I think its shape should
probably checked with original scores (e.g. old Italian and French
vocal scores like Ricordi's old edition of `L'esirir d'amore').


Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Alternative Quarter Rest

2014-11-28 Thread Dan Eble

> On Nov 28, 2014, at 03:49 , Werner LEMBERG  wrote:
> 
> 
>> I’ve attached a PDF for visual inspection.
> 
> Thanks.
> 
>> Should I write a regtest and post a code review or does it need more
>> work?
> 
> I think that the symbol itself could be improved.  Somehow the slant
> of the diagonal line looks to steep, so I think its shape should
> probably checked with original scores (e.g. old Italian and French
> vocal scores like Ricordi's old edition of `L'esirir d'amore').
> 
> 
>Werner

Thanks.  I don’t know if this is exactly what you meant, but in this 
low-resolution scan,

  http://www.dlib.indiana.edu/variations/scores/caw8891/large/index.html

the rests are probably taller than the samples I’ve been working from.
— 
Dan


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel