As already stated, LGTM.

I'd be happy if this patch could make it into 2.19.16 because it's useful for our crowd engraving project. I *can* set the requirements to >= 2.19.16, but I can't ask contributors to use custom-build LilyPonds or to patch their installation.

Best
Urs

Am 24.11.2014 06:12, schrieb nine.fierce.ball...@gmail.com:
Reviewers: ,

Description:
Issue 4205: Improve part combiner's rest analysis

Rests must begin and end simultaneously to be merged into the shared
voice.

Rests, skips, and multi-measure rests are kept apart even if they
begin and end simultaneously.

This does not produce ideal output in every case, but it avoids
producing musical nonsense.

Please review this at https://codereview.appspot.com/174610043/

Affected files (+131, -4 lines):
  A input/regression/part-combine-mmrest-shared.ly
  A input/regression/part-combine-silence.ly
  A input/regression/part-combine-silence-mixed.ly
  M scm/part-combiner.scm



_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to