core.git: include/vcl

[Andrea Gelmini (via logerrit)]

 include/vcl/UserResourceScanner.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ddb4047a19a4bda4385cb23046eb094beea88079
Author: Andrea Gelmini 
AuthorDate: Sat Jan 18 14:59:40 2025 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 18 21:29:14 2025 +0100

Fix typo

Change-Id: Idccd17065affa1d5ed0821f71faac7d71e9a8928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180443
Reviewed-by: Taichi Haradaguchi <20001...@protonmail.com>
Tested-by: Jenkins

diff --git a/include/vcl/UserResourceScanner.hxx 
b/include/vcl/UserResourceScanner.hxx
index 7a591a5951b4..db7da3accc90 100644
--- a/include/vcl/UserResourceScanner.hxx
+++ b/include/vcl/UserResourceScanner.hxx
@@ -25,7 +25,7 @@ VCL_DLLPUBLIC bool readFileStatus(osl::FileStatus& rStatus, 
const OUString& rFil
 class VCL_DLLPUBLIC UserResourceScanner
 {
 protected:
-/** Scans the provided directory for the resoruce.
+/** Scans the provided directory for the resource.
  *
  * The returned strings will contain the URLs to the resources.
  */

core.git: sdext/source

[Andrea Gelmini (via logerrit)]

 sdext/source/pdfimport/README.md |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2b15ec7525953ea61f35153ab7be2da61c257c1c
Author: Andrea Gelmini 
AuthorDate: Sat Jan 18 14:59:26 2025 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 18 21:28:50 2025 +0100

Fix typo

Change-Id: Ie50100eb2ab2b099aa4cc6962efc7923669dbf29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180442
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@protonmail.com>

diff --git a/sdext/source/pdfimport/README.md b/sdext/source/pdfimport/README.md
index 6ce7986005e9..83850833f54c 100644
--- a/sdext/source/pdfimport/README.md
+++ b/sdext/source/pdfimport/README.md
@@ -8,7 +8,7 @@ It is invoked when opening a PDF file, but **not** when 
inserting
 a PDF into a document.  Inserting a PDF file renders it and inserts
 a non-editable, rendered version.
 
-The parsing is done by the libary [Poppler](https://poppler.freedesktop.org/)
+The parsing is done by the library [Poppler](https://poppler.freedesktop.org/)
 which then calls back into one layer of this code which is built as a
 Poppler output device implementation.
 

help.git: help3xsl/default.css

[Olivier Hallot (via logerrit)]

 help3xsl/default.css |   21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)

New commits:
commit fb5ddc28e542ab1963a7e3fc5c3352a72cc86b22
Author: Olivier Hallot 
AuthorDate: Sat Jan 18 19:28:55 2025 -0300
Commit: Ilmari Lauhakangas 
CommitDate: Sun Jan 19 08:52:28 2025 +0100

Remove module colors from Index, plus...

+ Set Index module font color to heading-color
+ Darken headings color for A11Y
+ Set Contents font to bold.

Change-Id: If4708e1ac8e50f125787a0cded63588be895b4b9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180475
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 184a7dfb3b..2dcfab5ca7 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -32,7 +32,7 @@ do not break anything related to layout by scaling.
   --font-mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
   --font-body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
-  --heading-color: #18A303;
+  --heading-color: #007c3c;
   --hover-color: green;
   --link-color: #023a86;
   --visited-color: purple;
@@ -573,63 +573,63 @@ aside input[type="checkbox"]:checked ~ .contents-treeview 
{
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #083fa6;
+color: var(--heading-color);
 }
 #CALC::before {
 content: "Calc";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #007c3c;
+color: var(--heading-color);
 }
 #IMPRESS::before {
 content: "Impress";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #d0120d;
+color: var(--heading-color);
 }
 #DRAW::before {
 content: "Draw";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #cb6d30;
+color: var(--heading-color);
 }
 #BASE::before {
 content: "Base";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #7324a9;
+color: var(--heading-color);
 }
 #MATH::before {
 content: "Math";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: #c10018;
+color: var(--heading-color);
 }
 #CHART::before {
 content: "Chart";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: darkcyan;
+color: var(--heading-color);
 }
 #BASIC::before {
 content: "Basic";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: black;
+color: var(--heading-color);;
 }
 #SHARED::before {
 content: "%PRODUCTNAME";
 display: block;
 font-size: 22px;
 font-weight: bold;
-color: darkslategray;
+color: var(--heading-color);
 }
 .pagination-container {
 text-align: center;
@@ -1014,6 +1014,7 @@ li.disabled a {
 background-color: transparent;
 text-decoration: none;
 color: var(--heading-color);
+font-weight: bold;
 }
 label[for="accordion-1"]:hover {
 background-color: transparent;

core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a207e40dbf72c9209e444f17dc51e6167d840d9c
Author: Olivier Hallot 
AuthorDate: Sun Jan 19 04:52:28 2025 -0300
Commit: Gerrit Code Review 
CommitDate: Sun Jan 19 08:52:28 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to fb5ddc28e542ab1963a7e3fc5c3352a72cc86b22
  - Remove module colors from Index, plus...

+ Set Index module font color to heading-color
+ Darken headings color for A11Y
+ Set Contents font to bold.

Change-Id: If4708e1ac8e50f125787a0cded63588be895b4b9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180475
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index fae33ebe38ef..fb5ddc28e542 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fae33ebe38ef8314058d90831f2b6c933feb4e8e
+Subproject commit fb5ddc28e542ab1963a7e3fc5c3352a72cc86b22

core.git: sw/source

[Caolán McNamara (via logerrit)]

 sw/source/ui/dbui/mmresultdialogs.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 75840df232ec960afa20d40e85eb1f0ebd2d5312
Author: Caolán McNamara 
AuthorDate: Sat Jan 18 11:23:49 2025 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 18 22:12:48 2025 +0100

cid#1640468 Dereference after null check

Change-Id: I5ade1b36b43aca5a3370dc5d4ff30c383af1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180437
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/ui/dbui/mmresultdialogs.cxx 
b/sw/source/ui/dbui/mmresultdialogs.cxx
index 2a960e6a8f01..fea693fe7ffa 100644
--- a/sw/source/ui/dbui/mmresultdialogs.cxx
+++ b/sw/source/ui/dbui/mmresultdialogs.cxx
@@ -933,7 +933,11 @@ IMPL_LINK_NOARG(SwMMResultEmailDialog, 
SendDocumentsHdl_Impl, weld::Button&, voi
 
 //get the composed document
 SwView* pTargetView = xConfigItem->GetTargetView();
-SAL_WARN_IF(!pTargetView, "sw.ui", "No TargetView in 
SwMailMergeConfigItem");
+if (!pTargetView)
+{
+SAL_WARN("sw.ui", "No TargetView in SwMailMergeConfigItem");
+return;
+}
 
 if (xConfigItem->GetMailServer().isEmpty() ||
 
!SwMailMergeHelper::CheckMailAddress(xConfigItem->GetMailAddress()) )
@@ -945,8 +949,7 @@ IMPL_LINK_NOARG(SwMMResultEmailDialog, 
SendDocumentsHdl_Impl, weld::Button&, voi
 sal_uInt16 nRet = xQueryBox->run();
 if (RET_YES == nRet )
 {
-SwView* pConfigView = pTargetView ? pTargetView : pView;
-SfxAllItemSet aSet(pConfigView->GetPool());
+SfxAllItemSet aSet(pTargetView->GetPool());
 SwMailConfigDlg aDlg(m_xDialog.get(), aSet);
 nRet = aDlg.run();
 }

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1640500:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window 
*, const rtl::OUString &, const ScAddress &, const std::function 
&) const::[lambda(unsigned int) (instance 1)]::lambda(const [lambda(unsigned 
int) (instance 1)]&)()



*** CID 1640500:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window 
*, const rtl::OUString &, const ScAddress &, const std::function 
&) const::[lambda(unsigned int) (instance 1)]::lambda(const [lambda(unsigned 
int) (instance 1)]&)()
423 xBox->set_default_response(RET_CANCEL);
424 break;
425 default:
426 break;
427 }
428 
>>> CID 1640500:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "this" is not initialized in this constructor 
>>> nor in any functions that it calls.
429 xBox->runAsync(xBox, [&, callback](sal_uInt32 result)
430{ callback(eErrorStyle == SC_VALERR_STOP || result 
== RET_CANCEL); });
431 }
432 
433 bool ScValidationData::IsDataValidCustom(
434 const OUString& rTest,

** CID 1640499:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window 
*, const rtl::OUString &, const ScAddress &, const std::function 
&) const::[lambda(unsigned int) (instance 1)]::lambda([lambda(unsigned int) 
(instance 1)]&&)()



*** CID 1640499:  Uninitialized members  (UNINIT_CTOR)
/sc/source/core/data/validat.cxx: 429 in ScValidationData::DoError(weld::Window 
*, const rtl::OUString &, const ScAddress &, const std::function 
&) const::[lambda(unsigned int) (instance 1)]::lambda([lambda(unsigned int) 
(instance 1)]&&)()
423 xBox->set_default_response(RET_CANCEL);
424 break;
425 default:
426 break;
427 }
428 
>>> CID 1640499:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "this" is not initialized in this constructor 
>>> nor in any functions that it calls.
429 xBox->runAsync(xBox, [&, callback](sal_uInt32 result)
430{ callback(eErrorStyle == SC_VALERR_STOP || result 
== RET_CANCEL); });
431 }
432 
433 bool ScValidationData::IsDataValidCustom(
434 const OUString& rTest,



To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

core.git: 2 commits - sfx2/source

[Mike Kaganski (via logerrit)]

 sfx2/source/appl/shutdowniconw32.cxx |   45 ---
 1 file changed, 16 insertions(+), 29 deletions(-)

New commits:
commit 4213b4cb860900f7a6247f582aeb6e84c5772e2d
Author: Mike Kaganski 
AuthorDate: Sat Jan 18 18:59:01 2025 +0500
Commit: Mike Kaganski 
CommitDate: Sun Jan 19 06:21:00 2025 +0100

Use COMReference to handle COM pointers in CreateShortcut

Simplifies the code.

Change-Id: I25ab66380e982aaa111242507997f3bc0fda4bd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180446
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/appl/shutdowniconw32.cxx 
b/sfx2/source/appl/shutdowniconw32.cxx
index 332a183b27b1..9bbbac69c094 100644
--- a/sfx2/source/appl/shutdowniconw32.cxx
+++ b/sfx2/source/appl/shutdowniconw32.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -701,36 +702,22 @@ static HRESULT WINAPI SHCoCreateInstance( LPVOID 
lpszReserved, REFCLSID clsid, L
 static bool CreateShortcut( const OUString& rAbsObject, const OUString& 
rAbsObjectPath,
 const OUString& rAbsShortcut, const OUString& rDescription, const 
OUString& rParameter )
 {
-HRESULT hres;
-IShellLinkW* psl;
-CLSID clsid_ShellLink = CLSID_ShellLink;
-CLSID clsid_IShellLink = IID_IShellLinkW;
-
-hres = CoCreateInstance( clsid_ShellLink, nullptr, CLSCTX_INPROC_SERVER,
- clsid_IShellLink, reinterpret_cast(&psl) 
);
-if( FAILED(hres) )
-hres = SHCoCreateInstance( nullptr, clsid_ShellLink, nullptr, 
clsid_IShellLink, reinterpret_cast(&psl) );
-
-if( SUCCEEDED(hres) )
+try
 {
-IPersistFile* ppf;
+sal::systools::COMReference psl(CLSID_ShellLink, nullptr, 
CLSCTX_INPROC_SERVER);
 psl->SetPath( o3tl::toW(rAbsObject.getStr()) );
 psl->SetWorkingDirectory( o3tl::toW(rAbsObjectPath.getStr()) );
 psl->SetDescription( o3tl::toW(rDescription.getStr()) );
-if( rParameter.getLength() )
+if (!rParameter.isEmpty())
 psl->SetArguments( o3tl::toW(rParameter.getStr()) );
 
-CLSID clsid_IPersistFile = IID_IPersistFile;
-hres = psl->QueryInterface( clsid_IPersistFile, 
reinterpret_cast(&ppf) );
-
-if( SUCCEEDED(hres) )
-{
-hres = ppf->Save( o3tl::toW(rAbsShortcut.getStr()), TRUE );
-ppf->Release();
-} else return false;
-psl->Release();
-} else return false;
-return true;
+sal::systools::COMReference ppf(psl, 
sal::systools::COM_QUERY_THROW);
+return SUCCEEDED(ppf->Save(o3tl::toW(rAbsShortcut.getStr()), TRUE));
+}
+catch (const sal::systools::ComError&)
+{
+return false;
+}
 }
 
 
commit 582517d60032acfbed2622a2ee905d2c9d3860ce
Author: Mike Kaganski 
AuthorDate: Sat Jan 18 18:55:45 2025 +0500
Commit: Mike Kaganski 
CommitDate: Sun Jan 19 06:20:46 2025 +0100

Use std::u16string_view to avoid needless allocation

Change-Id: I0b7c64ea29f65a381a5d02e8818a848e8cc46258
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180445
Reviewed-by: Mike Kaganski 
Tested-by: Jenkins

diff --git a/sfx2/source/appl/shutdowniconw32.cxx 
b/sfx2/source/appl/shutdowniconw32.cxx
index 03c8bbf997a8..332a183b27b1 100644
--- a/sfx2/source/appl/shutdowniconw32.cxx
+++ b/sfx2/source/appl/shutdowniconw32.cxx
@@ -757,12 +757,12 @@ bool ShutdownIcon::IsQuickstarterInstalled()
 wchar_t aPath[EXTENDED_MAX_PATH];
 GetModuleFileNameW(nullptr, aPath, std::size(aPath));
 
-OUString aOfficepath( o3tl::toU(aPath) );
-int i = aOfficepath.lastIndexOf('\');
-if( i != -1 )
-aOfficepath = aOfficepath.copy(0, i);
+std::u16string_view aOfficepath(o3tl::toU(aPath));
+auto i = aOfficepath.find_last_of('\');
+if (i != std::u16string_view::npos)
+aOfficepath = aOfficepath.substr(0, i);
 
-OUString quickstartExe(aOfficepath + "\quickstart.exe");
+OUString quickstartExe(OUString::Concat(aOfficepath) + "\quickstart.exe");
 
 return FileExistsW( o3tl::toW(quickstartExe.getStr()) );
 }

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit be18ba67f31388e7107906233178fb5fd273f0b1
Author: Olivier Hallot 
AuthorDate: Sat Jan 18 05:51:32 2025 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 09:51:32 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 21e8ede653614efcec606d8468160fa1b24ab8c3
  - Fix "Contents" heading color

Change-Id: Ic6c42902bd554d365626793dd571607acb2c6433
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180418
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 186169d9bd0f713a780e5aae2d8ac71916fb3a60)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180426
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 2cdea9c17ac7..21e8ede65361 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2cdea9c17ac7daf6050fcd45ad1e9f0d10f1acbb
+Subproject commit 21e8ede653614efcec606d8468160fa1b24ab8c3

help.git: Branch 'libreoffice-25-2' - help3xsl/default.css

[Olivier Hallot (via logerrit)]

 help3xsl/default.css |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 21e8ede653614efcec606d8468160fa1b24ab8c3
Author: Olivier Hallot 
AuthorDate: Fri Jan 17 13:34:08 2025 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 09:51:32 2025 +0100

Fix "Contents" heading color

Change-Id: Ic6c42902bd554d365626793dd571607acb2c6433
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180418
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 186169d9bd0f713a780e5aae2d8ac71916fb3a60)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180426
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index cf7a4a566b..81c0450abc 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -1018,6 +1018,7 @@ li.disabled a {
 label[for=accordion-1] {
 background-color: transparent;
 text-decoration: none;
+color:var(--heading-color);
 }
 label[for=accordion-1]:hover {
 background-color: transparent;

help.git: Branch 'libreoffice-25-2' - help3xsl/default.css help3xsl/help2.js

[Olivier Hallot (via logerrit)]

 help3xsl/default.css |  217 +--
 help3xsl/help2.js|   19 
 2 files changed, 195 insertions(+), 41 deletions(-)

New commits:
commit 841284185dd547ab6e90ba56e4a586b485cf6875
Author: Olivier Hallot 
AuthorDate: Wed Jan 15 12:00:46 2025 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 09:51:52 2025 +0100

tdf#148016 Add dark mode to Help pages

+ First trial to implement a dark mode
+ Mode follows browser settings
+ removed modules color foo in help2.js

Change-Id: I0dfc62f832c3f5d406ac8d92d530eac382c4dc62
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180294
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit bd6c0ba10789ecf74cb220cf4e31cd3d6a66a954)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180423
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 81c0450abc..bc6a2446f1 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -32,7 +32,10 @@ do not break anything related to layout by scaling.
   --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
   --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
-  --module-color: #18A303;
+  --heading-color: #18A303;
+  --hover-color:green;
+  --link-color:#023a86;
+  --visited-color:purple;
 }
 /* Enable disable Javascript*/
 #WarnJS {
@@ -111,14 +114,14 @@ body {
 }
 a {
 text-decoration-color: rgba(0,0,0,0.15);
-color: #0461e0;
+color: var(--link-color);
 }
 a:hover {
 text-decoration: underline;
-color: #023a86;
+color: var(--hover-color);
 }
 a:visited {
-color: #633363;
+color: var(--visited-color);
 }
 pre,
 .code,
@@ -154,7 +157,7 @@ img[src$=".svg"] {
 .related {
 font-weight: bold;
 margin-top: 1.67rem;
-border-top: 1px solid black;
+border-top: 2px solid var(--heading-color);
 }
 .emph,
 .menuitem {
@@ -225,10 +228,11 @@ pre[class*="language-"] > code {
 }
 .iconcell {
 padding:0.3em;
+/* background: var(--heading-color); */
 }
 
 table {
-background: #FEFEFE;
+background: var(--background-color);
 box-shadow: rgba(0,0,0,0.08) 0 1px 5px 0;
 border-collapse: collapse;
 }
@@ -248,7 +252,7 @@ html[dir=ltr] th {
 margin-top: 0px;
 }
 .tableheadcell {
-background: var(--module-color);
+background: green;
 color: white;
 vertical-align:top;
 }
@@ -275,8 +279,8 @@ h4,
 h5,
 h6 {
 margin-bottom: 0.67rem;
-color: var(--module-color);
-border-bottom-color: var(--module-color);
+color: var(--heading-color);
+border-bottom-color: var(--heading-color);
 }
 p,
 ol,
@@ -286,7 +290,7 @@ td {
 }
 h1 {
 font-size: 1.83rem;
-font-weight: 300;
+font-weight: bold;
 border-bottom: 2px solid;
 margin-bottom: 1.67rem;
 }
@@ -307,6 +311,12 @@ h6 {
 .relatedtopics {
 font-weight: normal;
 }
+.related {
+font-weight: bold;
+margin-top: 1.67rem;
+border-top: 2px solid var(--heading-color);
+color: var(--heading-color);
+}
 .howtoget {
 background: #EBE7E9;
 border-left: 2px solid #4E4B55;
@@ -327,8 +337,8 @@ h6 {
 .howtogetbody {
 padding: 0 0.3em;
 }
-.samplefilesection{
-}
+/*.samplefilesection{}*/
+
 .wide {
 width: 100%;
 }
@@ -378,14 +388,13 @@ h6 {
 display:block;
 box-shadow: rgba(0,0,0,0.08) 0 1px 5px 0;
 }
-.iconimage {}
-
-.switch,
-.switchinline {}
+/* .iconimage{} */
+/* .switch, */
+/* .switchinline {} */
 
-.embedded {}
+/* .embedded {} */
 #TopLeftHeader {
-background: var(--module-color);
+background: var(--heading-color);
 grid-area: header;
 position: sticky;
 top: 0px;
@@ -686,15 +695,15 @@ li.disabled a {
 box-shadow: 0 2px 8px 0 rgba(0,0,0,.05);
 }
 #DonationFrame {
-background: var(--module-color);
+background: var(--background-color);
 position: sticky;
 top: 0px;
 }
 .donation{
 border: 1px solid #f1c62a;
 border-radius: 2px;
-padding: 5px 10px;
-margin: auto;
+padding: 10px 10px;
+margin: 5px 10px;
 max-width: 200px;
 color: #ff;
 }
@@ -963,9 +972,10 @@ li.disabled a {
 }
 #DonationFrame {
 grid-area: donation;
+background-color: var(--heading-color);
 }
 #SearchFrame {
-background: var(--module-color);
+background: var(--heading-color);
 grid-area: search;
 }
 footer {
@@ -1024,3 +1034,166 @@ li.disabled a {
 background-color: transparent;
 }
 }
+@media (prefers-color-scheme: dark) {
+:root {
+--background-color: #002a1a;
+--heading-color: #ddffee;
+--hover-color:#60ec93;
+--link-color:#BB86FC;
+--visited-color:#CF6679;
+}
+
+body {
+background-color: var(--

core.git: Branch 'libreoffice-25-2' - include/svx svx/CppunitTest_svx_unit.mk svx/qa svx/source vcl/qa

[Jonathan Clark (via logerrit)]

 include/svx/framelinkarray.hxx |8 -
 svx/CppunitTest_svx_unit.mk|1 
 svx/qa/unit/framelinkarray.cxx |  196 +
 svx/source/dialog/framelinkarray.cxx   |   45 +++---
 svx/source/table/viewcontactoftableobj.cxx |   24 ++-
 vcl/qa/cppunit/pdfexport/pdfexport2.cxx|4 
 6 files changed, 248 insertions(+), 30 deletions(-)

New commits:
commit 209eb64b6c45e5301fbef73bfa71fed88171e5df
Author: Jonathan Clark 
AuthorDate: Tue Jan 14 11:26:56 2025 -0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 10:27:08 2025 +0100

tdf#34837 sc: Use border from correct cell for merged cells in RTL

This change fixes a bug causing borders to fail to render for merged
cells in RTL spreadsheets.

The root cause for this bug was framelinkarray utility code using the
top-left cell as the source for border styles of merged cells. This use
was correct for LTR spreadsheets. However, this framelinkarray data is
mirrored for RTL documents. After mirroring, the correct cell containing
border styles is the top-right one.

This change also reverts and reimplements a prior fix for tdf#135843
(commit 586a0f149f332c0b0e53c0bb30568d4bd411b0e3), which violated the
framelinkarray contract that edge styles for merged cells must be added
to the top-left underlying cell of a merged cell.

Change-Id: I27eec416d54f9f99cd5df1151a12c758f350c789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180256
Tested-by: Jenkins
Reviewed-by: Jonathan Clark 
(cherry picked from commit bf54efbe21d6c6fcb910f7fa3d9f43978dc555c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180291
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/svx/framelinkarray.hxx b/include/svx/framelinkarray.hxx
index 1ddb9b76cbd0..47aa7ec1b9b9 100644
--- a/include/svx/framelinkarray.hxx
+++ b/include/svx/framelinkarray.hxx
@@ -131,28 +131,28 @@ public:
 Returns the style only if visible (i.e. at left border of a merged 
range).
 @return
 The left frame style or an invisible style for invalid cell 
addresses. */
-SAL_DLLPRIVATE const Style& GetCellStyleLeft( sal_Int32 nCol, sal_Int32 
nRow ) const;
+const Style& GetCellStyleLeft(sal_Int32 nCol, sal_Int32 nRow) const;
 
 /** Returns the right frame style of the cell (nCol,nRow).
 Returns thicker of own right style or left style of the cell to the 
right.
 Returns the style only if visible (i.e. at right border of a merged 
range).
 @return
 The left frame style or an invisible style for invalid cell 
addresses. */
-SAL_DLLPRIVATE const Style& GetCellStyleRight( sal_Int32 nCol, sal_Int32 
nRow ) const;
+const Style& GetCellStyleRight(sal_Int32 nCol, sal_Int32 nRow) const;
 
 /** Returns the top frame style of the cell (nCol,nRow).
 Returns thicker of own top style or bottom style of the cell above.
 Returns the style only if visible (i.e. at top border of a merged 
range).
 @return
 The top frame style or an invisible style for invalid cell 
addresses. */
-SAL_DLLPRIVATE const Style& GetCellStyleTop( sal_Int32 nCol, sal_Int32 
nRow ) const;
+const Style& GetCellStyleTop(sal_Int32 nCol, sal_Int32 nRow) const;
 
 /** Returns the top frame style of the cell (nCol,nRow).
 Returns thicker of own top style or bottom style of the cell above.
 Returns the style only if visible (i.e. at top border of a merged 
range).
 @return
 The top frame style or an invisible style for invalid cell 
addresses. */
-SAL_DLLPRIVATE const Style& GetCellStyleBottom( sal_Int32 nCol, sal_Int32 
nRow ) const;
+const Style& GetCellStyleBottom(sal_Int32 nCol, sal_Int32 nRow) const;
 
 /** Returns the top-left to bottom-right frame style of the cell 
(nCol,nRow).
 Ignores merged ranges;
diff --git a/svx/CppunitTest_svx_unit.mk b/svx/CppunitTest_svx_unit.mk
index 95c76b2d0733..0cad5af02c26 100644
--- a/svx/CppunitTest_svx_unit.mk
+++ b/svx/CppunitTest_svx_unit.mk
@@ -26,6 +26,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,svx_unit, \
svx/qa/unit/svdraw/test_SdrTextObject \
svx/qa/unit/customshapes \
 svx/qa/unit/classicshapes \
+   svx/qa/unit/framelinkarray \
 svx/qa/unit/gluepointTest \
svx/qa/unit/sdr \
svx/qa/unit/svdraw \
diff --git a/svx/qa/unit/framelinkarray.cxx b/svx/qa/unit/framelinkarray.cxx
new file mode 100644
index ..f94077a702b1
--- /dev/null
+++ b/svx/qa/unit/framelinkarray.cxx
@@ -0,0 +1,196 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one 

help.git: Branch 'libreoffice-25-2' - help3xsl/default.css

[Olivier Hallot (via logerrit)]

 help3xsl/default.css |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 17d9c7d53c5e7c07c1070604f5e32bd9ae9d36ea
Author: Olivier Hallot 
AuthorDate: Thu Jan 16 10:18:53 2025 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 10:30:23 2025 +0100

Center  in screen for Help pages

Change-Id: I60f45842ba7c8a86afd0714b72292a9bbf5bcaf2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180352
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins
(cherry picked from commit de99260dbb43ec2b4676b2daa31cc8499be4e11b)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180429
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index bc6a2446f1..958058fb32 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -1020,7 +1020,10 @@ li.disabled a {
 grid-template-rows: 1fr minmax(1em, auto) minmax(1em, auto);
 grid-template-areas: "header header search search donation"
 "leftside main main main ."
-". footer footer footer ."
+". footer footer footer .";
+margin: auto;
+width:  fit-content;
+height: fit-content;
 }
 .donation {
 max-width: 300px;

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 70e6b3c9bc1aac47c8a6bc438faa4cfb897282ec
Author: Olivier Hallot 
AuthorDate: Sat Jan 18 06:30:23 2025 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 10:30:23 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 17d9c7d53c5e7c07c1070604f5e32bd9ae9d36ea
  - Center  in screen for Help pages

Change-Id: I60f45842ba7c8a86afd0714b72292a9bbf5bcaf2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180352
Reviewed-by: Olivier Hallot 
Tested-by: Jenkins
(cherry picked from commit de99260dbb43ec2b4676b2daa31cc8499be4e11b)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180429
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 8b4dde5bb70f..17d9c7d53c5e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 8b4dde5bb70f5bc2e724146a1c9e541f0614fa77
+Subproject commit 17d9c7d53c5e7c07c1070604f5e32bd9ae9d36ea

core.git: Branch 'libreoffice-25-2' - android/source

[Weblate (via logerrit)]

 android/source/res/values-af/strings.xml |  111 
 android/source/res/values-ro/strings.xml |2 
 android/source/res/values-tl/strings.xml |  119 ++-
 3 files changed, 231 insertions(+), 1 deletion(-)

New commits:
commit 76d758e8f45cba2cca233b6a970ae1c4f1a82b0d
Author: Weblate 
AuthorDate: Wed Jan 15 03:53:36 2025 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 10:10:23 2025 +0100

android-viewer translated using Weblate

Tagalog currently translated at 100.0% (116 of 116 strings)

Change-Id: I04bae7a7e7d708615ff95461bed015a84c814923

android-viewer translated using Weblate

Tagalog currently translated at 14.6% (17 of 116 strings)

Change-Id: Ide358036e77b5337ead9eff8629ee54948b260e9

Added translation for android-viewer using Weblate (Romanian)

Change-Id: I0555a2d3a563b7386c2e7fc379a95525e68b52d0

android-viewer translated using Weblate

Afrikaans currently translated at 100.0% (116 of 116 strings)

Change-Id: I09f76734924ae79c879e0cbd76b47b70bcb0c88d

Added translation for android-viewer using Weblate (Afrikaans)

Change-Id: Ie6b2ce95bab4c8b6a0585c3812dff4671e1ee653
Co-authored-by: Andy Flagg 
Co-authored-by: Languages add-on 
Co-authored-by: Paul Roos 
Co-authored-by: Weblate 
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-2/af/
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-2/tl/
Translation: android-viewer/android-strings-25-2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179904
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/android/source/res/values-af/strings.xml 
b/android/source/res/values-af/strings.xml
new file mode 100644
index ..f895ef7b859e
--- /dev/null
+++ b/android/source/res/values-af/strings.xml
@@ -0,0 +1,111 @@
+
+
+LibreOffice Leser Instellings
+Weergawe: %1$s
Build ID: %2$s;
+LibreOffice Viewer is \'n dokument-leser 
gebaseer op LibreOffice.
+https://www.libreoffice.org
+Hierdie weergawe is verskaf deur 
$VENDOR.
+Hierdie lêer is lees-alleen.
+Vertoon Lisensie
+Vertoon Kennisgewing
+Privaatheidsbeleid
+Skep Nuwe Lêer
+Nuwe Teks Dokument
+Nuwe Aanbieding
+Nuwe Sigblad
+Nuwe Tekening
+on-getiteld
+Kies lêer om oop te maak
+Soek Volgende
+Vind Vorige
+lêer-ikoon
+Onlangse lêers
+Algemeen
+Ontwikkelaarmodus
+Meer oor
+Gedeeltes
+Instellings
+Vertoon sleutelbord
+Stoor
+Stoor As…
+Formaat Aanskakel
+Soek
+Stuur UNO Opdrag
+Stoor omvattend
+Stoor die dokument…
+Stoor van die dokument 
misluk.
+Wagwoord
+Maak Ongedaan
+Herdoen
+Stoor die dokument voor 
sluiting?
+STOOR
+Kanselleer
+NEE
+Skyfie vertoning
+Voeg Skyfie By
+Terug
+Invoeg
+Verwyder
+Verberg
+Optimale Hoogte
+Optimale Wydte
+OK
+Voer in, Ekstra Lengte in 
100ste/mm
+OK
+Wenk: Dubbelklik op 
\'n opskrif, stel die optimale breedte/hoogte.
+Voeg Werkblad By
+Kanselleer
+Voer in die wagwoord, 
asseblief
+Neem die Foto
+Selekteer Foto
+Kies \'n Prent
+Geen Kamera gevind nie
+Kleinste Grootte
+Medium Grootte
+Maks Kwaliteit
+Kopieer
+Plak
+Uitknip
+Terug
+Teks na knipbord gekopieer
+Tabel invoeg
+Kies invoeg-opsies:
+Kies verwyder-opsies:
+Hernoem werkblad
+Verwyder skyfie
+Gegewe naam word reeds in 
gebruik.
+Die naam vir die gedeelte is 
gewysig.
+Die gedeelte is verwyder.
+UNO-opdrag
+Tipe
+Waarde
+Boliggende 
Waarde
+As PDF uitskryf
+Karakter
+Huidige UNO-opdrag
+Invoeg
+Paragraaf
+OK
+Vertoonstyl
+PDF-uitskryf is voltooid
+Kan nie in PDF-formaat uitskryf 
nie
+Kan lêer nie uitskryf nie
+Foutief
+Voer gedeeltelike naam in
+Bmp is nul!
+Bladsy
+Blad
+Skyfie
+Gedeelte
+Beklemtoningskleur
+Font Kleur
+Hernoem Skyfie
+Automaties
+LibreOffice Leser
+Alle lêers
+Skakel ontwikkelaarmodus aan 
waar jy UNO-opdragte binne die toepassing kan stuur. Gebruik op eie 
risiko.
+Kanselleer
+Moenie Kompakteer
+Wil u die foto kompakteer?
+Verwyder werkblad
+
\ No newline at end of file
diff --git a/android/source/res/values-ro/strings.xml 
b/android/source/res/values-ro/strings.xml
new file mode 100644
index ..a6b3daec9354
--- /dev/null
+++ b/android/source/res/values-ro/strings.xml
@@ -0,0 +1,2 @@
+
+
\ No newline at end of file
diff --git a/android/source/res/values-tl/strings.xml 
b/android/source/res/values-tl/strings.xml
index a6b3daec9354..be42f5b0147c 100644
--- a/android/source/

core.git: sw/source

[Xisco Fauli (via logerrit)]

 sw/source/core/draw/dcontact.cxx  |6 +++---
 sw/source/core/fields/docufld.cxx |2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit fa3e0b27385258c2fbd24e02b9319e86db00e7e2
Author: Xisco Fauli 
AuthorDate: Sat Jan 18 10:21:29 2025 +0100
Commit: Xisco Fauli 
CommitDate: Sat Jan 18 12:28:11 2025 +0100

sw: Dereferencing NULL pointer 'pChangeHint'

After
commit c239b6cad271d20f443482bc8b6039b1734d18f2
Author: Noel Grandin 
Date:   Sat Jan 4 16:20:57 2025 +0200

convert RES_ATTRSET_CHG to SfxHint


C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/draw/dcontact.cxx(1670):
 error C2220: the following warning is treated as an error
C:
C: 
/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/fields/docufld.cxx(2318):
 error C2220: the following warning is treated as an error
C: Change-Id: I919d59d108a39dd77adb18967392a8ae8920275a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180431
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index cc0b3556bc1a..0f13027799ba 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -1526,10 +1526,10 @@ void SwDrawContact::SwClientNotify(const SwModify& 
rMod, const SfxHint& rHint)
 {
 // #i35443#
 auto pChangeHint = static_cast(&rHint);
-auto pChgSet = pChangeHint->m_pNew->GetChgSet();
-if(pChgSet->GetItemState(RES_SURROUND, false) == 
SfxItemState::SET ||
+auto pChgSet = pChangeHint->m_pNew ? 
pChangeHint->m_pNew->GetChgSet() : nullptr;
+if(pChgSet && (pChgSet->GetItemState(RES_SURROUND, false) == 
SfxItemState::SET ||
 pChgSet->GetItemState(RES_OPAQUE, false) == 
SfxItemState::SET ||
-pChgSet->GetItemState(RES_WRAP_INFLUENCE_ON_OBJPOS, 
false) == SfxItemState::SET)
+pChgSet->GetItemState(RES_WRAP_INFLUENCE_ON_OBJPOS, 
false) == SfxItemState::SET))
 bUpdateSortedObjsList = true;
 }
 lcl_NotifyBackgroundOfObj(*this, *GetMaster(), nullptr);
diff --git a/sw/source/core/fields/docufld.cxx 
b/sw/source/core/fields/docufld.cxx
index 0605bb34b0cc..7ea308f576cd 100644
--- a/sw/source/core/fields/docufld.cxx
+++ b/sw/source/core/fields/docufld.cxx
@@ -2291,7 +2291,7 @@ void SwRefPageGetFieldType::SwClientNotify(const 
SwModify&, const SfxHint& rHint
 
 // update all GetReference fields
 if( (pLegacy && !pLegacy->m_pNew && !pLegacy->m_pOld && 
HasWriterListeners())
-|| (!pChangeHint->m_pNew && !pChangeHint->m_pOld && 
HasWriterListeners()))
+|| (pChangeHint && !pChangeHint->m_pNew && !pChangeHint->m_pOld && 
HasWriterListeners()))
 {
 SwRootFrame const* pLayout(nullptr);
 SwRootFrame const* pLayoutRLHidden(nullptr);

回复: Latest changes to poppler breaks build against Clang and libc++15

[Etna -]

I notice this patch has already been committed, and I can confirm I can now 
build LO without needing the -fexperimental-library switch.
Thank you.

Regards,
Etna


发件人: LibreOffice  代表 Ilmari 
Lauhakangas 
发送时间: 2025年1月12日 16:22
收件人: libreoffice@lists.freedesktop.org 
主题: Re: Latest changes to poppler breaks build against Clang and libc++15

On 12.1.2025 3.49, Etna - wrote:
> Hello all, attempting to build the latest checkout against Debian 12 on a 
> self-compiled LLVM15, libc++15 and clang-15 returns the following error:
>
> ---
> /home/etna/Tmpdir/libreoffice/build/workdir/UnpackedTarball/poppler/poppler/Dict.cc:116:30:
>  error: no member named 'sort' in namespace 'std::ranges'
>  std::ranges::sort(that->entries, CmpDictEntry {});
>  ~^
> /home/etna/Tmpdir/libreoffice/build/workdir/UnpackedTarball/poppler/poppler/Dict.cc:123:39:
>  error: no member named 'lower_bound' in namespace 'std::ranges'
>  const auto pos = std::ranges::lower_bound(entries, key, std::less<> 
> {}, &DictEntry::first);

Try this patch and let us know how it goes:
https://gerrit.libreoffice.org/c/core/+/180026

Ilmari

help.git: help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |  354 +--
 1 file changed, 150 insertions(+), 204 deletions(-)

New commits:
commit fae33ebe38ef8314058d90831f2b6c933feb4e8e
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 13:41:00 2025 +0200
Commit: Olivier Hallot 
CommitDate: Sat Jan 18 17:46:45 2025 +0100

Clean up and optimise CSS

Prefer readability over compactness. Repetition is fine, if it
helps with readability.

Took some tips from this validator: https://stylelint.io/demo/

Change-Id: I36108e2f063c848182503ea469d146bb00099a75
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 04a9305c11..184a7dfb3b 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -29,20 +29,20 @@ do not break anything related to layout by scaling.
 
 */
 :root {
-  --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
-  --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
+  --font-mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
+  --font-body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
   --heading-color: #18A303;
-  --hover-color:green;
-  --link-color:#023a86;
-  --visited-color:purple;
+  --hover-color: green;
+  --link-color: #023a86;
+  --visited-color: purple;
 }
-/* Enable disable Javascript*/
+/* Enable disable Javascript */
 #WarnJS {
 margin: 20px;
-display:block;
+display: block;
 }
-#WarnJS h1{
+#WarnJS h1 {
 color: red;
 font-weight: bold;
 text-align: center;
@@ -59,27 +59,27 @@ h6,
 .listitem,
 .listitemintable,
 .tablecontent {
-font-family: var(--font_body);
+font-family: var(--font-body);
 }
 .input {
-background-color: rgba(0,0,0,0.04);
+background-color: rgb(0 0 0 / 4%);
 transition-property: background-color;
 transition-duration: 150ms;
-border-bottom: 1px dashed rgba(0,0,0,0.1);
-font-family: var(--font_mono);
+border-bottom: 1px dashed rgb(0 0 0 / 10%);
+font-family: var(--font-mono);
 }
-[data-tooltip]{
-  position:relative;
+[data-tooltip] {
+  position: relative;
 }
 [data-tooltip]::before {
 content: "";
 position: absolute;
-top:-6px;
-left:50%;
+top: -6px;
+left: 50%;
 transform: translateX(-50%);
-border-width: 4px 6px 0 6px;
+border-width: 4px 6px 0;
 border-style: solid;
-border-color: rgba(0,0,0,0.7) transparent transparent transparent;
+border-color: rgb(0 0 0 / 70%) transparent transparent;
 z-index: 100;
 opacity: 0;
 pointer-events: none;
@@ -87,20 +87,20 @@ h6,
 [data-tooltip]::after {
 content: attr(data-tooltip);
 position: absolute;
-left:50%;
-top:-6px;
+left: 50%;
+top: -6px;
 transform: translateX(-50%)   translateY(-100%);
-background: rgba(0,0,0,0.7);
+background: rgb(0 0 0 / 70%);
 text-align: center;
 color: #fff;
-padding:4px 2px;
+padding: 4px 2px;
 font-size: 12px;
 min-width: 80px;
 border-radius: 5px;
 opacity: 0;
 pointer-events: none;
 }
-[data-tooltip]:hover:before, [data-tooltip]:hover:after {
+[data-tooltip]:hover::before, [data-tooltip]:hover::after {
 opacity: 1;
 pointer-events: auto;
 }
@@ -113,7 +113,7 @@ body {
 background: #FFEB9F;
 }
 a {
-text-decoration-color: rgba(0,0,0,0.15);
+text-decoration-color: rgb(0 0 0 / 15%);
 color: var(--link-color);
 }
 a:hover {
@@ -132,12 +132,12 @@ pre,
 .literalintable,
 .path,
 .pathintable {
-background-color: rgba(0,0,0,0.04);
+background-color: rgb(0 0 0 / 4%);
 border-radius: 2px;
 display: inline;
 padding: 1px 3px;
-font-family: var(--font_mono);
-word-wrap: anywhere;
+font-family: var(--font-mono);
+overflow-wrap: anywhere;
 }
 /* prevent SVGs without width from overflowing the container */
 img[src$=".svg"] {
@@ -149,24 +149,23 @@ img[src$=".svg"] {
 .smathcode {
 border-radius: 2px;
 padding: 1px 3px;
-font-family: var(--font_mono);
+font-family: var(--font-mono);
 }
-.acronym {
+.acronym,
+.emph,
+.menuitem {
 font-weight: bold;
 }
 .related {
 font-weight: bold;
 margin-top: 1.67rem;
 border-top: 2px solid var(--heading-color);
-}
-.emph,
-.menuitem {
-font-weight: bold;
+color: var(--heading-color);
 }
 .keycode {
-font-family: var(--font_mono);
+font-family: var(--font-mono);
 }
-.widget{
+.widget {
 padding: 1px 10px;
 background: #f0f0f0;
 background: linear-gradient(to bottom,#f0f0f0,#fcfcfc);
@@ -180,7 +179,7 @@ img[src$=".svg"] 

Strange build errors with Clang 19

[Ilmari Lauhakangas]

I upgraded my Arch Linux and Clang was bumped from 18 to 19. Now I'm 
getting weird errors (log below). Linker is mold, but lld gives the same 
ones. I had done make distclean. Output is verbose.


Ilmari

mkdir -p /home/user/libreofficetwo/instdir
/home/user/libreofficetwo/solenv/bin/install-gdb-printers -a 
/home/user/libreofficetwo/instdir -c

make -j 8  -rs -f /home/user/libreofficetwo/Makefile.gbuild build
[build DEP] LNK:Executable/unoidl-check.d
[build DEP] LNK:Executable/unoidl-write.d
[build PRJ] libassuan
[build PKG] icu_ure
[build PKG] icu
[build PRJ] libtiff
[build C  ] UnpackedTarball/pdfium/core/fxcodec/jpeg/jpeg_common.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/event.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/function_list.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/bio.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/image.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/invert.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/cio.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/opj_clock.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/mqc.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/openjpeg.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/mct.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/thread.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/tgt.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/jp2.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/t2.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/pi.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/sparse_array.c
[build PAT] openldap
[build PKG] desktop_soffice_sh
[build MOD] beanshell
[build PRJ] hyphen
[build BIN] coinmp
[build EPK] icu
[build EPK] icu_ure
[build PRJ] jfreereport_liblayout
[build MOD] lcms2
[build MOD] libgpg-error
[build BIN] libtiff
[build BIN] libxml2
[build MOD] lpsolve
[build BIN] mythes
[build MOD] rhino
make[1]: *** Deleting file 
'/home/user/libreofficetwo/workdir/CustomTarget/extras/source/autotext/user/mytexts.bau'

[build ZIP] autotext/user/mytexts.bau

zip error: Nothing to do! 
(/home/user/libreofficetwo/workdir/CustomTarget/extras/source/autotext/user/mytexts.bau)
make[1]: *** 
[/home/user/libreofficetwo/extras/CustomTarget_autotextshare.mk:3668: 
/home/user/libreofficetwo/workdir/CustomTarget/extras/source/autotext/user/mytexts.bau] 
Error 12

make[1]: *** Waiting for unfinished jobs
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/tcd.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/ht_dec.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/dwt.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/j2k.c
[build C  ] UnpackedTarball/pdfium/third_party/libopenjpeg/t1.c
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether make supports nested variables... (cached) yes
checking whether make supports the include directive... yes (GNU style)
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C++... yes
checking whether clang++ -v  accepts -g... yes
checking for clang++ -v  option to enable C++11 features... none needed
checking dependency style of clang++ -v ... gcc3
checking whether clang++ -v  supports C++17 features with -std=c++17... yes
checking for x86_64-pc-linux-gnu-gcc... clang
checking whether the compiler supports GNU C... yes
checking whether clang  accepts -g... yes
checking for clang  option to enable C11 features... none needed
checking whether clang  understands -c and -o together... yes
checking dependency style of clang ... gcc3
checking how to run the C preprocessor... clang  -E
checking whether the compiler supports GNU C++... (cached) yes
checking whether clang++ -v  -std=c++17 accepts -g... (cached) yes
checking for clang++ -v  -std=c++17 option to enable C++11 features... 
(cached) none needed

checking dependency style of clang++ -v  -std=c++17... (cached) gcc3
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by clang ... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... llvm-nm
chec

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e5ff70521cf15fc5f15cad4b660a11e718352723
Author: Olivier Hallot 
AuthorDate: Sat Jan 18 05:51:52 2025 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 09:51:52 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 841284185dd547ab6e90ba56e4a586b485cf6875
  - tdf#148016 Add dark mode to Help pages

+ First trial to implement a dark mode
+ Mode follows browser settings
+ removed modules color foo in help2.js

Change-Id: I0dfc62f832c3f5d406ac8d92d530eac382c4dc62
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180294
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit bd6c0ba10789ecf74cb220cf4e31cd3d6a66a954)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180423
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 21e8ede65361..841284185dd5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 21e8ede653614efcec606d8468160fa1b24ab8c3
+Subproject commit 841284185dd547ab6e90ba56e4a586b485cf6875

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a37c7fa9de5e7672d3c4a9c923ab77c1f08c5d7b
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 10:52:13 2025 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 09:52:13 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 8b4dde5bb70f5bc2e724146a1c9e541f0614fa77
  - Wrap book icons for mobile-friendliness

Change-Id: I2475c2c65883f6c1c12c3d762d472fc5f83764a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180344
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit fc3b49ad5d6547412773419ce91fe2b1f0509c25)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180424
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 841284185dd5..8b4dde5bb70f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 841284185dd547ab6e90ba56e4a586b485cf6875
+Subproject commit 8b4dde5bb70f5bc2e724146a1c9e541f0614fa77

help.git: Branch 'libreoffice-25-2' - help3xsl/online_transform.xsl

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/online_transform.xsl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8b4dde5bb70f5bc2e724146a1c9e541f0614fa77
Author: Ilmari Lauhakangas 
AuthorDate: Thu Jan 16 13:30:46 2025 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jan 18 09:52:13 2025 +0100

Wrap book icons for mobile-friendliness

Change-Id: I2475c2c65883f6c1c12c3d762d472fc5f83764a2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180344
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit fc3b49ad5d6547412773419ce91fe2b1f0509c25)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180424
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl
index e869486411..d031d5f084 100644
--- a/help3xsl/online_transform.xsl
+++ b/help3xsl/online_transform.xsl
@@ -270,7 +270,7 @@
 
 
 https://books.libreoffice.org"; target="_blank">
-
+
 
 
 

core.git: android/source

[Weblate (via logerrit)]

 android/source/res/values-de/strings.xml |4 ++--
 android/source/res/values-ne/strings.xml |1 +
 android/source/res/values-pl/strings.xml |4 ++--
 android/source/res/values-ro/strings.xml |5 +
 4 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit b5419f147deffb40410ae50ef3f474dfe8c7d525
Author: Weblate 
AuthorDate: Tue Jan 14 17:53:38 2025 +0100
Commit: Michael Weghorn 
CommitDate: Sat Jan 18 11:23:38 2025 +0100

android-viewer translated using Weblate

Nepali currently translated at 17.2% (20 of 116 strings)

Change-Id: Ic4035d126f219a07a06e5fca1cbbcda44da450cd

android-viewer translated using Weblate

Romanian currently translated at 1.7% (2 of 116 strings)

Change-Id: I5546924ae3c8a06ef146ad9edace2d35b5808b77

Added translation for android-viewer using Weblate (Romanian)

Change-Id: Ia8a83b4214d1e2534effba69ec1b3616a94eee1a

android-viewer translated using Weblate

German currently translated at 100.0% (116 of 116 strings)

Change-Id: I4e8df9f44be8070659ef951e0a79ae1d358d9155

android-viewer translated using Weblate

Polish currently translated at 100.0% (116 of 116 strings)

Change-Id: I1963efa6ecef6c3259d31ef99fa087266c1e9156
Co-authored-by: Adam Rak 
Co-authored-by: Christian Kühl 
Co-authored-by: Miloiu Andrei 
Co-authored-by: Nabin  Khanal 
Co-authored-by: Weblate 
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
Translate-URL: 
https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/
Translation: android-viewer/android-strings
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178880
Reviewed-by: Michael Weghorn 
Tested-by: Jenkins

diff --git a/android/source/res/values-de/strings.xml 
b/android/source/res/values-de/strings.xml
index 7ebc8c9662ab..a7fa4a08 100644
--- a/android/source/res/values-de/strings.xml
+++ b/android/source/res/values-de/strings.xml
@@ -38,7 +38,7 @@
 Speichern beendet
 Dokument wird gespeichert…
 Speichern des Dokuments ist 
fehlgeschlagen.
-Passwort
+Kennwort
 Rückgängig
 Wiederherstellen
 
@@ -68,7 +68,7 @@
 
 OK
 Abbrechen
-Bitte Passwort eingeben
+Bitte Kennwort eingeben
 
 Foto Machen
 Foto Auswählen
diff --git a/android/source/res/values-ne/strings.xml 
b/android/source/res/values-ne/strings.xml
index 430de40d93d2..cb98829e9433 100644
--- a/android/source/res/values-ne/strings.xml
+++ b/android/source/res/values-ne/strings.xml
@@ -20,4 +20,5 @@
 शीर्षक नभएको
 इजाजतपत्र देखाउनुहोस्
 सबै फाइलहरू
+नयाँ फाइल बनाउनुहोस
 
\ No newline at end of file
diff --git a/android/source/res/values-pl/strings.xml 
b/android/source/res/values-pl/strings.xml
index 476875800659..8b18c0161f38 100644
--- a/android/source/res/values-pl/strings.xml
+++ b/android/source/res/values-pl/strings.xml
@@ -22,7 +22,7 @@
 Ogólne
 Tryb eksperymentalny
 Tryb programisty
-Włącz tryb programisty, w 
którym możesz wysyłać polecenia UNO w aplikacji. Używaj na własne 
ryzyko.
+Włącz tryb programisty, w 
którym możesz wysyłać polecenia UNO w aplikacji. Używaj na własne 
ryzyko.
 Części
 Ustawienia
 Pokaż klawiaturę
@@ -62,7 +62,7 @@
 Nie kompresuj
 Czy chcesz skompresować 
zdjęcie\?
 Kopiuj
-Wpisz dodatkową długość w 
setnych/mm
+Wpisz dodatkową długość w 
setnych/mm
 Wpisz hasło
 Wytnij
 Wstecz
diff --git a/android/source/res/values-ro/strings.xml 
b/android/source/res/values-ro/strings.xml
new file mode 100644
index ..abacac6cdd78
--- /dev/null
+++ b/android/source/res/values-ro/strings.xml
@@ -0,0 +1,5 @@
+
+
+Setări pentru LibreOffice Viewer
+LibreOffice Viewer
+
\ No newline at end of file

help.git: Branch 'libreoffice-25-2' - help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |   37 ++---
 1 file changed, 26 insertions(+), 11 deletions(-)

New commits:
commit 3d3e92d81a489c7d96a9d55d3a14279221028824
Author: Ilmari Lauhakangas 
AuthorDate: Wed Jan 15 18:21:39 2025 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Sat Jan 18 10:42:21 2025 +0100

Center everything with 1440px width

Change-Id: I4a97df011b58c70f5ff8ef73433d8f6bd325d371
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180297
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit d9104f52a1f7e3b2eee958544659cabb6808cd3c)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180425
Reviewed-by: Ilmari Lauhakangas 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 958058fb32..04a9305c11 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -423,6 +423,9 @@ h6 {
 .logo p {
 font-size: 24px;
 }
+.logo {
+grid-area: logo;
+}
 .symbol {
 grid-area: symbol;
 padding: 8px 8px 8px 20px;
@@ -876,9 +879,9 @@ li.disabled a {
 grid-template-columns: 320px 100px 300px 1fr;
 grid-template-rows: minmax(1em, auto) minmax(1em, auto) 1fr 
minmax(1em, auto);
 grid-template-areas: "header header search donation"
-"leftside main main main"
-"leftside main main main"
-". footer footer footer"
+ "leftside main main main"
+ "leftside main main main"
+ ". footer footer footer";
 }
 #TopLeftHeader {
 display: grid;
@@ -886,7 +889,7 @@ li.disabled a {
 grid-template-columns: auto auto;
 grid-template-rows: auto auto;
 grid-template-areas: "symbol logo"
-"symbol dropdowns"
+ "symbol dropdowns";
 }
 #SearchFrame {
 grid-area: search;
@@ -1016,14 +1019,26 @@ li.disabled a {
 @media screen and (min-width: 1440px) {
 body {
 display: grid;
-grid-template-columns: 360px 100px 400px 400px 1fr;
+grid-template-columns: 1fr 360px 100px 400px 400px 1fr;
 grid-template-rows: 1fr minmax(1em, auto) minmax(1em, auto);
-grid-template-areas: "header header search search donation"
-"leftside main main main ."
-". footer footer footer .";
-margin: auto;
-width:  fit-content;
-height: fit-content;
+grid-template-areas: "header header search search donation donation"
+ ". leftside main main main ."
+ ". footer footer footer footer .";
+}
+#TopLeftHeader {
+display: grid;
+align-items: end;
+grid-template-columns: 1fr auto auto;
+grid-template-rows: auto auto;
+grid-template-areas: ". symbol logo"
+ ". symbol dropdowns";
+}
+#SearchFrame {
+justify-content: center;
+}
+#DonationFrame {
+display: grid;
+grid-template-columns: subgrid;
 }
 .donation {
 max-width: 300px;

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f28eeda01c2490daca0c8fa95b26a202f4cf808
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 11:42:21 2025 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 10:42:21 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 3d3e92d81a489c7d96a9d55d3a14279221028824
  - Center everything with 1440px width

Change-Id: I4a97df011b58c70f5ff8ef73433d8f6bd325d371
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180297
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit d9104f52a1f7e3b2eee958544659cabb6808cd3c)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180425
Reviewed-by: Ilmari Lauhakangas 

diff --git a/helpcontent2 b/helpcontent2
index 17d9c7d53c5e..3d3e92d81a48 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 17d9c7d53c5e7c07c1070604f5e32bd9ae9d36ea
+Subproject commit 3d3e92d81a489c7d96a9d55d3a14279221028824

Re: Mac Silicon removed from download page

[Patrick Luby]

Well this is definitely not just me. There are now two new posts in the 
r/libreoffice subreddit about this. Apparently the Mac Silicon option has been 
removed.

Can someone look at this website change? It is very obviously broken to anyone 
using a Silicon Mac.

Patrick

> On Jan 17, 2025, at 10:40 AM, Patrick Luby  wrote:
> 
> So I saw the 25.2 RC2 announcement and went to download and to my surprise 
> the Mac Silicon option has been removed. Only Mac Intel is there (see 
> attached screen snapshot in Safari).
> 
> Did parsing the user agent string get added back? For those who aren’t aware: 
> all of the most popular browsers have a user agent string set to “macOS 
> Catalina, Intel chip” no matter if you are actually using a later macOS 
> version and/or an Arm chip.
> 
> I know this was working earlier this week so this must be a recent change.
> 
> Patrick
> 
> 
> 

core.git: vcl/source

[Xisco Fauli (via logerrit)]

 vcl/source/window/menu.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 8b7dfd32f417652087e3d880bcbf88bc2b4d2676
Author: Xisco Fauli 
AuthorDate: Sat Jan 18 10:04:33 2025 +0100
Commit: Xisco Fauli 
CommitDate: Sat Jan 18 12:02:54 2025 +0100

vcl: Dereferencing NULL pointer 'pData'

After
commit a108fce773d46441e30dcc14abe29751410ae4ed
Author: Michael Weghorn 
Date:   Fri Jan 17 14:18:30 2025 +0100

tdf#163186 qt: Show menu item tooltips

C: 
/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/vcl/source/window/menu.cxx(1144):
 error C2220: the following warning is treated as an error
C: Change-Id: I62e8462fcff83817f876489a10bd010e246a1d01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180430
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
index f7032281f7b2..75936aed46ca 100644
--- a/vcl/source/window/menu.cxx
+++ b/vcl/source/window/menu.cxx
@@ -1137,10 +1137,12 @@ void Menu::SetTipHelpText( sal_uInt16 nItemId, const 
OUString& rStr )
 MenuItemData* pData = pItemList->GetData( nItemId );
 
 if ( pData )
+{
 pData->aTipHelpText = rStr;
 
-if (ImplGetSalMenu() && pData->pSalMenuItem)
-ImplGetSalMenu()->SetItemTooltip(pData->pSalMenuItem.get(), rStr);
+if (ImplGetSalMenu() && pData->pSalMenuItem)
+ImplGetSalMenu()->SetItemTooltip(pData->pSalMenuItem.get(), rStr);
+}
 }
 
 OUString Menu::GetTipHelpText( sal_uInt16 nItemId ) const

core.git: helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 437cbf2293dc5a605fe77d97b7c08e3690461835
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 18:46:45 2025 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 17:46:45 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to fae33ebe38ef8314058d90831f2b6c933feb4e8e
  - Clean up and optimise CSS

Prefer readability over compactness. Repetition is fine, if it
helps with readability.

Took some tips from this validator: https://stylelint.io/demo/

Change-Id: I36108e2f063c848182503ea469d146bb00099a75
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index e17de2924949..fae33ebe38ef 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit e17de2924949bccdbe3aedb527fac6acc210e6e3
+Subproject commit fae33ebe38ef8314058d90831f2b6c933feb4e8e

help.git: Branch 'libreoffice-25-2' - help3xsl/default.css

[Ilmari Lauhakangas (via logerrit)]

 help3xsl/default.css |  354 +--
 1 file changed, 150 insertions(+), 204 deletions(-)

New commits:
commit 9b807f92a620c372440cb50a9f8a6627bf6cbfa6
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 13:41:00 2025 +0200
Commit: Ilmari Lauhakangas 
CommitDate: Sat Jan 18 17:51:29 2025 +0100

Clean up and optimise CSS

Prefer readability over compactness. Repetition is fine, if it
helps with readability.

Took some tips from this validator: https://stylelint.io/demo/

Change-Id: I36108e2f063c848182503ea469d146bb00099a75
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 
(cherry picked from commit fae33ebe38ef8314058d90831f2b6c933feb4e8e)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180453
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 04a9305c11..184a7dfb3b 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -29,20 +29,20 @@ do not break anything related to layout by scaling.
 
 */
 :root {
-  --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
-  --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
+  --font-mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
+  --font-body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
   --background-color: #f7f8f7;
   --heading-color: #18A303;
-  --hover-color:green;
-  --link-color:#023a86;
-  --visited-color:purple;
+  --hover-color: green;
+  --link-color: #023a86;
+  --visited-color: purple;
 }
-/* Enable disable Javascript*/
+/* Enable disable Javascript */
 #WarnJS {
 margin: 20px;
-display:block;
+display: block;
 }
-#WarnJS h1{
+#WarnJS h1 {
 color: red;
 font-weight: bold;
 text-align: center;
@@ -59,27 +59,27 @@ h6,
 .listitem,
 .listitemintable,
 .tablecontent {
-font-family: var(--font_body);
+font-family: var(--font-body);
 }
 .input {
-background-color: rgba(0,0,0,0.04);
+background-color: rgb(0 0 0 / 4%);
 transition-property: background-color;
 transition-duration: 150ms;
-border-bottom: 1px dashed rgba(0,0,0,0.1);
-font-family: var(--font_mono);
+border-bottom: 1px dashed rgb(0 0 0 / 10%);
+font-family: var(--font-mono);
 }
-[data-tooltip]{
-  position:relative;
+[data-tooltip] {
+  position: relative;
 }
 [data-tooltip]::before {
 content: "";
 position: absolute;
-top:-6px;
-left:50%;
+top: -6px;
+left: 50%;
 transform: translateX(-50%);
-border-width: 4px 6px 0 6px;
+border-width: 4px 6px 0;
 border-style: solid;
-border-color: rgba(0,0,0,0.7) transparent transparent transparent;
+border-color: rgb(0 0 0 / 70%) transparent transparent;
 z-index: 100;
 opacity: 0;
 pointer-events: none;
@@ -87,20 +87,20 @@ h6,
 [data-tooltip]::after {
 content: attr(data-tooltip);
 position: absolute;
-left:50%;
-top:-6px;
+left: 50%;
+top: -6px;
 transform: translateX(-50%)   translateY(-100%);
-background: rgba(0,0,0,0.7);
+background: rgb(0 0 0 / 70%);
 text-align: center;
 color: #fff;
-padding:4px 2px;
+padding: 4px 2px;
 font-size: 12px;
 min-width: 80px;
 border-radius: 5px;
 opacity: 0;
 pointer-events: none;
 }
-[data-tooltip]:hover:before, [data-tooltip]:hover:after {
+[data-tooltip]:hover::before, [data-tooltip]:hover::after {
 opacity: 1;
 pointer-events: auto;
 }
@@ -113,7 +113,7 @@ body {
 background: #FFEB9F;
 }
 a {
-text-decoration-color: rgba(0,0,0,0.15);
+text-decoration-color: rgb(0 0 0 / 15%);
 color: var(--link-color);
 }
 a:hover {
@@ -132,12 +132,12 @@ pre,
 .literalintable,
 .path,
 .pathintable {
-background-color: rgba(0,0,0,0.04);
+background-color: rgb(0 0 0 / 4%);
 border-radius: 2px;
 display: inline;
 padding: 1px 3px;
-font-family: var(--font_mono);
-word-wrap: anywhere;
+font-family: var(--font-mono);
+overflow-wrap: anywhere;
 }
 /* prevent SVGs without width from overflowing the container */
 img[src$=".svg"] {
@@ -149,24 +149,23 @@ img[src$=".svg"] {
 .smathcode {
 border-radius: 2px;
 padding: 1px 3px;
-font-family: var(--font_mono);
+font-family: var(--font-mono);
 }
-.acronym {
+.acronym,
+.emph,
+.menuitem {
 font-weight: bold;
 }
 .related {
 font-weight: bold;
 margin-top: 1.67rem;
 border-top: 2px solid var(--heading-color);
-}
-.emph,
-.menuitem {
-font-weight: bold;
+color: var(--heading-color);
 }
 .keycode {
-font-family: var(--font_mono);
+fo

core.git: Branch 'libreoffice-25-2' - helpcontent2

[Ilmari Lauhakangas (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bff21055c9eb5dfd3ff4af36e08c88a0eb7b3334
Author: Ilmari Lauhakangas 
AuthorDate: Sat Jan 18 18:51:29 2025 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Jan 18 17:51:29 2025 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-25-2'
  to 9b807f92a620c372440cb50a9f8a6627bf6cbfa6
  - Clean up and optimise CSS

Prefer readability over compactness. Repetition is fine, if it
helps with readability.

Took some tips from this validator: https://stylelint.io/demo/

Change-Id: I36108e2f063c848182503ea469d146bb00099a75
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 
(cherry picked from commit fae33ebe38ef8314058d90831f2b6c933feb4e8e)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180453
Reviewed-by: Ilmari Lauhakangas 
Tested-by: Jenkins

diff --git a/helpcontent2 b/helpcontent2
index 3d3e92d81a48..9b807f92a620 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3d3e92d81a489c7d96a9d55d3a14279221028824
+Subproject commit 9b807f92a620c372440cb50a9f8a6627bf6cbfa6

core.git: download.lst external/fontconfig

[Xisco Fauli (via logerrit)]

 download.lst |4 +-
 external/fontconfig/ExternalPackage_fontconfig.mk|2 -
 external/fontconfig/ExternalPackage_fontconfig_data.mk   |4 ++
 external/fontconfig/UnpackedTarball_fontconfig.mk|1 
 external/fontconfig/fontconfig-2.12.1.patch.1|4 +-
 external/fontconfig/libfontconfig-bundled-soname.patch.0 |4 +-
 external/fontconfig/ubsan.patch  |   22 ---
 7 files changed, 11 insertions(+), 30 deletions(-)

New commits:
commit dda2475304e316e9c4c98450d95b0744d95de8a7
Author: Xisco Fauli 
AuthorDate: Sat Jan 18 14:26:27 2025 +0100
Commit: Xisco Fauli 
CommitDate: Sat Jan 18 17:42:24 2025 +0100

fontconfig: upgrade to 2.16.0

* external/fontconfig/ubsan.patch is fixed upstream

Downloaded from 
https://www.freedesktop.org/software/fontconfig/release/fontconfig-2.16.0.tar.xz

Change-Id: Id1acbc473cc03e35c8a7a6bd2b2c080cbf653d1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180441
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/download.lst b/download.lst
index e2327fdd6827..b69313e91868 100644
--- a/download.lst
+++ b/download.lst
@@ -121,8 +121,8 @@ FIREBIRD_TARBALL := Firebird-3.0.7.33374-0.tar.bz2
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-FONTCONFIG_SHA256SUM := 
63a0658d0e06e0fa886106452b58ef04f21f58202ea02a94c39de0d3335d7c0e
-FONTCONFIG_TARBALL := fontconfig-2.15.0.tar.xz
+FONTCONFIG_SHA256SUM := 
6a33dc555cc9ba8b10caf7695878ef134eeb36d0af366041f639b1da9b6ed220
+FONTCONFIG_TARBALL := fontconfig-2.16.0.tar.xz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git a/external/fontconfig/ExternalPackage_fontconfig.mk 
b/external/fontconfig/ExternalPackage_fontconfig.mk
index 688ae520bfe8..dd0550ce2106 100644
--- a/external/fontconfig/ExternalPackage_fontconfig.mk
+++ b/external/fontconfig/ExternalPackage_fontconfig.mk
@@ -12,7 +12,7 @@ $(eval $(call 
gb_ExternalPackage_ExternalPackage,fontconfig,fontconfig))
 $(eval $(call gb_ExternalPackage_use_external_project,fontconfig,fontconfig))
 
 ifeq ($(DISABLE_DYNLOADING),)
-$(eval $(call 
gb_ExternalPackage_add_file,fontconfig,$(LIBO_LIB_FOLDER)/libfontconfig-lo.so.1.12.1,src/.libs/libfontconfig-lo.so.1.12.1))
+$(eval $(call 
gb_ExternalPackage_add_file,fontconfig,$(LIBO_LIB_FOLDER)/libfontconfig-lo.so.1.15.0,src/.libs/libfontconfig-lo.so.1.15.0))
 endif
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/fontconfig/ExternalPackage_fontconfig_data.mk 
b/external/fontconfig/ExternalPackage_fontconfig_data.mk
index 63bcc8a2a3a2..e7d78142f456 100644
--- a/external/fontconfig/ExternalPackage_fontconfig_data.mk
+++ b/external/fontconfig/ExternalPackage_fontconfig_data.mk
@@ -15,6 +15,8 @@ $(eval $(call 
gb_ExternalPackage_add_files,fontconfig_data,$(LIBO_SHARE_FOLDER)/
 fonts.conf \
 ))
 
+# The list below is created with
+# find workdir/UnpackedTarball/fontconfig/conf.d/ -name "*.conf" | 
LC_COLLATE=C sort | sed -e 's/^//' -e 's/$/ \/' -e 
's/workdir\/UnpackedTarball\/fontconfig\///'
 $(eval $(call 
gb_ExternalPackage_add_unpacked_files,fontconfig_data,$(LIBO_SHARE_FOLDER)/fontconfig/conf.d,\
 conf.d/05-reset-dirs-sample.conf \
 conf.d/09-autohint-if-no-hinting.conf \
@@ -53,6 +55,8 @@ $(eval $(call 
gb_ExternalPackage_add_unpacked_files,fontconfig_data,$(LIBO_SHARE
 conf.d/65-khmer.conf \
 conf.d/65-nonlatin.conf \
 conf.d/69-unifont.conf \
+conf.d/70-no-bitmaps-and-emoji.conf \
+conf.d/70-no-bitmaps-except-emoji.conf \
 conf.d/70-no-bitmaps.conf \
 conf.d/70-yes-bitmaps.conf \
 conf.d/80-delicious.conf \
diff --git a/external/fontconfig/UnpackedTarball_fontconfig.mk 
b/external/fontconfig/UnpackedTarball_fontconfig.mk
index ceb87ea062ad..e37e8f6cb3e5 100644
--- a/external/fontconfig/UnpackedTarball_fontconfig.mk
+++ b/external/fontconfig/UnpackedTarball_fontconfig.mk
@@ -15,7 +15,6 @@ $(eval $(call gb_UnpackedTarball_set_patchlevel,fontconfig,0))
 
 $(eval $(call gb_UnpackedTarball_add_patches,fontconfig,\
external/fontconfig/fontconfig-2.12.1.patch.1 \
-   external/fontconfig/ubsan.patch \
external/fontconfig/libfontconfig-bundled-soname.patch.0 \
 ))
 
diff --git a/external/fontconfig/fontconfig-2.12.1.patch.1 
b/external/fontconfig/fontconfig-2.12.1.patch.1
index b6f54361bb8c..b2dce3f1526b 100644
--- a/external/fontconfig/fontconfig-2.12.1.patch.1
+++ b/external/fontconfig/fontconfig-2.12.1.patch.1
@@ -19,13 +19,13 @@ diff -up fontconfig/configure.dt fontconfig/configure
else
ld_shlibs=no
fi
-@@ -11584,7 +11584,7 @@ _LT_EOF
+@@ -11913,7 +11913,7 @@
;;
  
  haiku*)
 -  archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags $wl-soname 
$wl$soname -o $lib'
 +  archive_cmds='$CC -shared $libobjs $deplibs $compiler_flags -o $lib'
-   link_all_deplibs=yes
+   link_all_deplibs=no
  

Re: Strange build errors with Clang 19

[Stephan Bergmann]

On 1/18/25 17:32, Ilmari Lauhakangas wrote:
make[1]: *** Deleting file '/home/user/libreofficetwo/workdir/ 
CustomTarget/extras/source/autotext/user/mytexts.bau'

[build ZIP] autotext/user/mytexts.bau

zip error: Nothing to do! (/home/user/libreofficetwo/workdir/ 
CustomTarget/extras/source/autotext/user/mytexts.bau)
make[1]: *** [/home/user/libreofficetwo/extras/ 
CustomTarget_autotextshare.mk:3668: /home/user/libreofficetwo/workdir/ 
CustomTarget/extras/source/autotext/user/mytexts.bau] Error 12

make[1]: *** Waiting for unfinished jobs


Finally, somebody else who gets hit by that.  :)  I keep applying 
 "Disambiguate pattern 
rules in extras/CustomTarget_autotext{share,user}.mk" locally whenever I 
get hit by that in a build of mine, but never yet debugged it further...

core.git: sfx2/source

[Mike Kaganski (via logerrit)]

 sfx2/source/appl/shutdowniconw32.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 99e88bb7497c7d31e660fa5e693b488bafdbf703
Author: Mike Kaganski 
AuthorDate: Sat Jan 18 18:49:50 2025 +0500
Commit: Mike Kaganski 
CommitDate: Sat Jan 18 20:06:09 2025 +0100

Use EXTENDED_MAX_PATH in ShutdownIcon

Allows to use long paths in quickstarter, could be useful when the
program is in a deeply nested directory.

Change-Id: Iba6f8e2f7c54bfd442d19da63c94da9a50a867e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180444
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/appl/shutdowniconw32.cxx 
b/sfx2/source/appl/shutdowniconw32.cxx
index 409ba80bbf2c..03c8bbf997a8 100644
--- a/sfx2/source/appl/shutdowniconw32.cxx
+++ b/sfx2/source/appl/shutdowniconw32.cxx
@@ -32,6 +32,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -753,8 +754,8 @@ static bool FileExistsW( LPCWSTR lpPath )
 
 bool ShutdownIcon::IsQuickstarterInstalled()
 {
-wchar_t aPath[_MAX_PATH];
-GetModuleFileNameW( nullptr, aPath, _MAX_PATH-1);
+wchar_t aPath[EXTENDED_MAX_PATH];
+GetModuleFileNameW(nullptr, aPath, std::size(aPath));
 
 OUString aOfficepath( o3tl::toU(aPath) );
 int i = aOfficepath.lastIndexOf('\');
@@ -768,8 +769,8 @@ bool ShutdownIcon::IsQuickstarterInstalled()
 
 void ShutdownIcon::EnableAutostartW32( const OUString &aShortcut )
 {
-wchar_t aPath[_MAX_PATH];
-GetModuleFileNameW( nullptr, aPath, _MAX_PATH-1);
+wchar_t aPath[EXTENDED_MAX_PATH];
+GetModuleFileNameW(nullptr, aPath, std::size(aPath));
 
 OUString aOfficepath( o3tl::toU(aPath) );
 int i = aOfficepath.lastIndexOf('\');

core.git: 2 commits - cui/source desktop/source

[Caolán McNamara (via logerrit)]

 cui/source/dialogs/SignSignatureLineDialog.cxx |2 +-
 desktop/source/lib/init.cxx|3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 848d3ec126be8d8b05b3a07d2eacb98524085dbe
Author: Caolán McNamara 
AuthorDate: Sat Jan 18 11:12:45 2025 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 18 20:35:39 2025 +0100

cid#1640471 COPY_INSTEAD_OF_MOVE

Change-Id: I5b9e8ab80e884609bc18060674f3a974684a0303
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180434
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx 
b/cui/source/dialogs/SignSignatureLineDialog.cxx
index cb6a7191c436..52a5e5486cf7 100644
--- a/cui/source/dialogs/SignSignatureLineDialog.cxx
+++ b/cui/source/dialogs/SignSignatureLineDialog.cxx
@@ -164,7 +164,7 @@ IMPL_LINK_NOARG(SignSignatureLineDialog, chooseCertificate, 
weld::Button&, void)
 {
 m_xSelectedCertifate = xSignCertificate;
 svl::crypto::CertificateOrName aCertificateOrName;
-aCertificateOrName.m_xCertificate = xSignCertificate;
+aCertificateOrName.m_xCertificate = std::move(xSignCertificate);
 m_xBtnChooseCertificate->set_label(
 svx::SignatureLineHelper::getSignerName(aCertificateOrName));
 }
commit 055a1520e765bbff17dee77f6e045adc4829f3b4
Author: Caolán McNamara 
AuthorDate: Sat Jan 18 11:11:38 2025 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 18 20:35:30 2025 +0100

cid#1640467 COPY_INSTEAD_OF_MOVE

Change-Id: Id029fdf37d8b7b1e8d0bae672d37f6dfcbef8ce8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180433
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index ea9e089d4f73..109b5e9698d0 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -4767,11 +4767,10 @@ static void 
doc_initializeForRendering(LibreOfficeKitDocument* pThis,
 }
 if (!aSignatureCert.empty() && !aSignatureKey.empty())
 {
-uno::Reference xCertificate = 
SfxLokHelper::getSigningCertificate(aSignatureCert, aSignatureKey);
 if (SfxViewShell* pViewShell = SfxViewShell::Current())
 {
 svl::crypto::CertificateOrName aCertificateOrName;
-aCertificateOrName.m_xCertificate = xCertificate;
+aCertificateOrName.m_xCertificate = 
SfxLokHelper::getSigningCertificate(aSignatureCert, aSignatureKey);
 pViewShell->SetSigningCertificate(aCertificateOrName);
 }
 }

core.git: 2 commits - sc/inc sc/source

[Caolán McNamara (via logerrit)]

 sc/inc/validat.hxx  |2 +-
 sc/source/core/data/validat.cxx |2 +-
 sc/source/ui/miscdlgs/optsolver.cxx |   11 +++
 3 files changed, 9 insertions(+), 6 deletions(-)

New commits:
commit 9cba5a740eb07d4a9dacfc7d8eee9f6e2a006ca7
Author: Caolán McNamara 
AuthorDate: Sat Jan 18 11:19:02 2025 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 18 20:36:03 2025 +0100

cid#1640473 COPY_INSTEAD_OF_MOVE

Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins

diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index 863397f3ca57..365cc3aca074 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -160,7 +160,7 @@ public:
 
 // TRUE -> break
 void DoError(weld::Window* pParent, const OUString& rInput, const 
ScAddress& rPos,
- std::function callback) const;
+ const std::function& callback) const;
 void DoCalcError( ScFormulaCell* pCell ) const;
 
 bool IsEmpty() const;
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 744cee56adeb..fa47d68c63b7 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -374,7 +374,7 @@ IMPL_STATIC_LINK_NOARG(ScValidationData, 
InstallLOKNotifierHdl, void*, vcl::ILib
 // true -> abort
 
 void ScValidationData::DoError(weld::Window* pParent, const OUString& rInput, 
const ScAddress& rPos,
-   std::function callback) const
+   const std::function& 
callback) const
 {
 if ( eErrorStyle == SC_VALERR_MACRO ) {
 DoMacro(rPos, rInput, nullptr, pParent);
commit f74160c617667a25dba7fdbfb18583d12c16e991
Author: Caolán McNamara 
AuthorDate: Sat Jan 18 11:17:45 2025 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 18 20:35:52 2025 +0100

cid#1640469 Dereference null return value

Change-Id: Ib115c3ee73a0124d9d6a3c895722c89158da2d22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180435
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/miscdlgs/optsolver.cxx 
b/sc/source/ui/miscdlgs/optsolver.cxx
index 8adb033b3cac..cde2774153bc 100644
--- a/sc/source/ui/miscdlgs/optsolver.cxx
+++ b/sc/source/ui/miscdlgs/optsolver.cxx
@@ -1355,10 +1355,13 @@ bool ScOptSolverDlg::CallSolver()   // return true 
-> close dialog after cal
 }
 
 // Disable grid lines in the sensitivity report
-ScViewData& aData = 
ScTabViewShell::GetActiveViewShell()->GetViewData();
-aData.SetTabNo(nReportTab);
-aData.SetShowGrid(false);
-aData.SetTabNo(mnCurTab);
+if (ScTabViewShell* pViewSh = ScTabViewShell::GetActiveViewShell())
+{
+ScViewData& rData = pViewSh->GetViewData();
+rData.SetTabNo(nReportTab);
+rData.SetShowGrid(false);
+rData.SetTabNo(mnCurTab);
+}
 }
 }
 

core.git: vcl/inc vcl/qt5

[Noel Grandin (via logerrit)]

 vcl/inc/qt5/QtVirtualDevice.hxx |2 --
 vcl/qt5/QtVirtualDevice.cxx |   27 ---
 2 files changed, 29 deletions(-)

New commits:
commit 8c70c58c28fbaf004ef8fb3f157be0e719951669
Author: Noel Grandin 
AuthorDate: Sat Jan 18 14:15:46 2025 +0200
Commit: Noel Grandin 
CommitDate: Sat Jan 18 20:08:16 2025 +0100

QtVirtualDevice::SetSizeUsingBuffer is unnecessary

this method is only used by LOK and LOK only renders to the SVP backend

Change-Id: I33b47e549e4762c61cb921ebbe4e60f97b0c28cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180439
Reviewed-by: Noel Grandin 
Tested-by: Jenkins

diff --git a/vcl/inc/qt5/QtVirtualDevice.hxx b/vcl/inc/qt5/QtVirtualDevice.hxx
index 0673c03268cf..f20b937d5488 100644
--- a/vcl/inc/qt5/QtVirtualDevice.hxx
+++ b/vcl/inc/qt5/QtVirtualDevice.hxx
@@ -45,8 +45,6 @@ public:
 virtual void ReleaseGraphics(SalGraphics* pGraphics) override;
 
 virtual bool SetSize(tools::Long nNewDX, tools::Long nNewDY) override;
-virtual bool SetSizeUsingBuffer(tools::Long nNewDX, tools::Long nNewDY,
-sal_uInt8* pBuffer) override;
 
 // SalGeometryProvider
 virtual tools::Long GetWidth() const override;
diff --git a/vcl/qt5/QtVirtualDevice.cxx b/vcl/qt5/QtVirtualDevice.cxx
index 68c7c4a5add2..c52316eeb7c5 100644
--- a/vcl/qt5/QtVirtualDevice.cxx
+++ b/vcl/qt5/QtVirtualDevice.cxx
@@ -70,33 +70,6 @@ bool QtVirtualDevice::SetSize(tools::Long nNewDX, 
tools::Long nNewDY)
 return true;
 }
 
-bool QtVirtualDevice::SetSizeUsingBuffer(tools::Long nNewDX, tools::Long 
nNewDY, sal_uInt8* pBuffer)
-{
-if (nNewDX == 0)
-nNewDX = 1;
-if (nNewDY == 0)
-nNewDY = 1;
-
-if (m_pImage && m_aFrameSize.width() == nNewDX && m_aFrameSize.height() == 
nNewDY)
-return true;
-
-m_aFrameSize = QSize(nNewDX, nNewDY);
-
-nNewDX *= m_fScale;
-nNewDY *= m_fScale;
-
-m_pImage.reset(new QImage(pBuffer, nNewDX, nNewDY, Qt_DefaultFormat32));
-
-m_pImage->fill(Qt::transparent);
-m_pImage->setDevicePixelRatio(m_fScale);
-
-// update device in existing graphics
-for (auto pQtGraph : m_aGraphics)
-pQtGraph->ChangeQImage(m_pImage.get());
-
-return true;
-}
-
 tools::Long QtVirtualDevice::GetWidth() const { return m_pImage ? 
m_aFrameSize.width() : 0; }
 
 tools::Long QtVirtualDevice::GetHeight() const { return m_pImage ? 
m_aFrameSize.height() : 0; }