core.git: 2 commits - cui/source desktop/source

[Caolán McNamara (via logerrit)]

 cui/source/dialogs/SignSignatureLineDialog.cxx |    2 +-
 desktop/source/lib/init.cxx                    |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 848d3ec126be8d8b05b3a07d2eacb98524085dbe
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Jan 18 11:12:45 2025 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Jan 18 20:35:39 2025 +0100

    cid#1640471 COPY_INSTEAD_OF_MOVE
    
    Change-Id: I5b9e8ab80e884609bc18060674f3a974684a0303
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180434
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx 
b/cui/source/dialogs/SignSignatureLineDialog.cxx
index cb6a7191c436..52a5e5486cf7 100644
--- a/cui/source/dialogs/SignSignatureLineDialog.cxx
+++ b/cui/source/dialogs/SignSignatureLineDialog.cxx
@@ -164,7 +164,7 @@ IMPL_LINK_NOARG(SignSignatureLineDialog, chooseCertificate, 
weld::Button&, void)
     {
         m_xSelectedCertifate = xSignCertificate;
         svl::crypto::CertificateOrName aCertificateOrName;
-        aCertificateOrName.m_xCertificate = xSignCertificate;
+        aCertificateOrName.m_xCertificate = std::move(xSignCertificate);
         m_xBtnChooseCertificate->set_label(
             svx::SignatureLineHelper::getSignerName(aCertificateOrName));
     }
commit 055a1520e765bbff17dee77f6e045adc4829f3b4
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Jan 18 11:11:38 2025 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sat Jan 18 20:35:30 2025 +0100

    cid#1640467 COPY_INSTEAD_OF_MOVE
    
    Change-Id: Id029fdf37d8b7b1e8d0bae672d37f6dfcbef8ce8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180433
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index ea9e089d4f73..109b5e9698d0 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -4767,11 +4767,10 @@ static void 
doc_initializeForRendering(LibreOfficeKitDocument* pThis,
         }
         if (!aSignatureCert.empty() && !aSignatureKey.empty())
         {
-            uno::Reference<security::XCertificate> xCertificate = 
SfxLokHelper::getSigningCertificate(aSignatureCert, aSignatureKey);
             if (SfxViewShell* pViewShell = SfxViewShell::Current())
             {
                 svl::crypto::CertificateOrName aCertificateOrName;
-                aCertificateOrName.m_xCertificate = xCertificate;
+                aCertificateOrName.m_xCertificate = 
SfxLokHelper::getSigningCertificate(aSignatureCert, aSignatureKey);
                 pViewShell->SetSigningCertificate(aCertificateOrName);
             }
         }