Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Vincent Danjean
I forgot the CC

 Original Message 
Subject: Re: [Koha-devel] [Koha] Wrong SAX Parser - does it matter? -> impact 
on Debian packaging
Date: Sun, 07 Dec 2008 09:31:03 +0100
From: Vincent Danjean <[EMAIL PROTECTED]>
To: Chris Cormack <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>  <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
 <[EMAIL PROTECTED]> <[EMAIL PROTECTED]>

Chris Cormack wrote:
> Hi Vincent
> 
> Is the below issue still a problem?

This issue is still problematic (ie I do not know the answer and a good
packaging cannot modify a (not owned) global configuration file)

Other problem I got are config files in general. The same config file
is used by several packages so I must design config and postconf script
to deal with this.

You can see my current state here :
http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip
(not in a usable state as I just started to rewrite the management of
conffig file)

If you have some remarks about the packaging splitting, I would be glad
to get some feedback.
http://git.debian.org/?p=collab-maint/koha.git;a=blob;f=debian/control;hb=wip

> I was wondering what I could do to
> help you finish the packaging.
> I work with a couple of Debian Developers and Francois was telling me
> on friday that if we get the packaging finished soon, that although we
> have missed lenny, if its done before january we might get it into the
> next ubuntu release.
> 
> If you havent had an answer on the below question let me know and I'll
> go find the answer for you

Ok, if you can test if koha works with current expat parser, it will help.
I you kwow koha, telling me which config file is needed by which program would
also be a good thing. The idea is to be able to answer to the question:

Which config file (and which values will be read in it) do I need on each
machine A, B and C if I want to setup:
- koha opac and intranet on machine A
- zebra server on machine B
- pazpar2 server on machine C
And which crontab/script do I need to run on each of these machines.

  I CC koha-devel in case someone else can answer these questions.

  Best regards and thanks for for help
Vincent

> CHris
> 
> On Sat, Nov 15, 2008 at 9:13 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
>> [moving from koha to koha-devel due to my questions]
>>
>> Mason James wrote:
>>> On 2008/11/12, at 11:56 AM, Brendan Gallagher wrote:
 Did you try editing ParserDetails.ini
>> What I do not understand is why koha is requiring to modify such
>> a global configuration file.
>>
>> Is this setup really still required ? Were not the bugs from the
>> expat filter fixed ? I do not know at all why this parser is/was needed,
>> but Expact seems to work for the test case in koha scripts :
>> vdanjean koha/misc$ ./sax_parser_print.pl
>> XML::SAX::Expat=HASH(0x115c4f0)
>> vdanjean koha/misc$ ./sax_parser_test.pl
>> é
>> vdanjean koha/misc
>> )
>>
>> By the way, this kind of requirement is really a bad thing (with my
>> hat of trying to make a official Debian package) => it will be NOT
>> possible at all that the koha package modifies the global configuration
>> file.
>> However, I really do not understand why, if the SAX parser is really
>> needed, it is not required in the koha code itself.
>>
>> For example, I tried to add as the first line in sax_parser_print.pl
>> and sax_parser_test.pl the line:
>> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>> (tip found in the doc of XML::SAX::ParserFactory)
>> Without changing my global configuration file, sax_parser_print.pl
>> now report XML::LibXML::SAX.
>>
>> I failed to see where koha really instantiate a sax parser.
>> 'rgrep "use XML::SAX" koha/' does not return anything (but
>> sax_parser_print.pl and sax_parser_test.pl).
>>
>> Perhaps, koha gurus can know where SAX parser are used and add
>> the line requesting the particular parser if it is still needed ?
>>
>>  Regards,
>>Vincent
>>
>> --
>> Vincent Danjean   GPG key ID 0x9D025E87 [EMAIL PROTECTED]
>> GPG key fingerprint: FC95 08A6 854D DB48 4B9A  8A94 0BF7 7867 9D02 5E87
>> Unofficial pacakges: http://www-id.imag.fr/~danjean/deb.html#package
>> APT repo:  deb http://perso.debian.org/~vdanjean/debian unstable main
>>
>> ___
>> Koha-devel mailing list
>> Koha-devel@lists.koha.org
>> http://lists.koha.org/mailman/listinfo/koha-devel
>>
> 

-- 
Vincent Danjean Adresse: Laboratoire d'Informatique de Grenoble
Téléphone:  +33 4 76 61 20 11ENSIMAG - antenne de Montbonnot
Fax:+33 4 76 61 20 99ZIRST 51, avenue Jean Kuntzmann
Email: [EMAIL PROTECTED]   38330 Montbonnot Saint Martin
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Joshua Ferraro
Hi all,

I can say with certainty that Expact is not UNICODE safe, neither is
PurlPerl ... only LibXML is safe.

Cheers,

Josh

On Sun, Dec 7, 2008 at 3:33 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
> I forgot the CC
>
>  Original Message 
> Subject: Re: [Koha-devel] [Koha] Wrong SAX Parser - does it matter? -> impact 
> on Debian packaging
> Date: Sun, 07 Dec 2008 09:31:03 +0100
> From: Vincent Danjean <[EMAIL PROTECTED]>
> To: Chris Cormack <[EMAIL PROTECTED]>
> References: <[EMAIL PROTECTED]><[EMAIL PROTECTED]>   <[EMAIL 
> PROTECTED]><[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
>
> Chris Cormack wrote:
>> Hi Vincent
>>
>> Is the below issue still a problem?
>
> This issue is still problematic (ie I do not know the answer and a good
> packaging cannot modify a (not owned) global configuration file)
>
> Other problem I got are config files in general. The same config file
> is used by several packages so I must design config and postconf script
> to deal with this.
>
> You can see my current state here :
> http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip
> (not in a usable state as I just started to rewrite the management of
> conffig file)
>
> If you have some remarks about the packaging splitting, I would be glad
> to get some feedback.
> http://git.debian.org/?p=collab-maint/koha.git;a=blob;f=debian/control;hb=wip
>
>> I was wondering what I could do to
>> help you finish the packaging.
>> I work with a couple of Debian Developers and Francois was telling me
>> on friday that if we get the packaging finished soon, that although we
>> have missed lenny, if its done before january we might get it into the
>> next ubuntu release.
>>
>> If you havent had an answer on the below question let me know and I'll
>> go find the answer for you
>
> Ok, if you can test if koha works with current expat parser, it will help.
> I you kwow koha, telling me which config file is needed by which program would
> also be a good thing. The idea is to be able to answer to the question:
>
> Which config file (and which values will be read in it) do I need on each
> machine A, B and C if I want to setup:
> - koha opac and intranet on machine A
> - zebra server on machine B
> - pazpar2 server on machine C
> And which crontab/script do I need to run on each of these machines.
>
>  I CC koha-devel in case someone else can answer these questions.
>
>  Best regards and thanks for for help
>Vincent
>
>> CHris
>>
>> On Sat, Nov 15, 2008 at 9:13 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
>>> [moving from koha to koha-devel due to my questions]
>>>
>>> Mason James wrote:
 On 2008/11/12, at 11:56 AM, Brendan Gallagher wrote:
> Did you try editing ParserDetails.ini
>>> What I do not understand is why koha is requiring to modify such
>>> a global configuration file.
>>>
>>> Is this setup really still required ? Were not the bugs from the
>>> expat filter fixed ? I do not know at all why this parser is/was needed,
>>> but Expact seems to work for the test case in koha scripts :
>>> vdanjean koha/misc$ ./sax_parser_print.pl
>>> XML::SAX::Expat=HASH(0x115c4f0)
>>> vdanjean koha/misc$ ./sax_parser_test.pl
>>> é
>>> vdanjean koha/misc
>>> )
>>>
>>> By the way, this kind of requirement is really a bad thing (with my
>>> hat of trying to make a official Debian package) => it will be NOT
>>> possible at all that the koha package modifies the global configuration
>>> file.
>>> However, I really do not understand why, if the SAX parser is really
>>> needed, it is not required in the koha code itself.
>>>
>>> For example, I tried to add as the first line in sax_parser_print.pl
>>> and sax_parser_test.pl the line:
>>> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>>> (tip found in the doc of XML::SAX::ParserFactory)
>>> Without changing my global configuration file, sax_parser_print.pl
>>> now report XML::LibXML::SAX.
>>>
>>> I failed to see where koha really instantiate a sax parser.
>>> 'rgrep "use XML::SAX" koha/' does not return anything (but
>>> sax_parser_print.pl and sax_parser_test.pl).
>>>
>>> Perhaps, koha gurus can know where SAX parser are used and add
>>> the line requesting the particular parser if it is still needed ?
>>>
>>>  Regards,
>>>Vincent
>>>
>>> --
>>> Vincent Danjean   GPG key ID 0x9D025E87 [EMAIL PROTECTED]
>>> GPG key fingerprint: FC95 08A6 854D DB48 4B9A  8A94 0BF7 7867 9D02 5E87
>>> Unofficial pacakges: http://www-id.imag.fr/~danjean/deb.html#package
>>> APT repo:  deb http://perso.debian.org/~vdanjean/debian unstable main
>>>
>>> ___
>>> Koha-devel mailing list
>>> Koha-devel@lists.koha.org
>>> http://lists.koha.org/mailman/listinfo/koha-devel
>>>
>>
>
> --
> Vincent Danjean Adresse: Laboratoire d'Informatique de 
> Grenoble
> Téléphone:  +33 4 76 61 20 11ENSIMAG - antenne de Montbonnot
> Fax:+33 4 76 61 20 99ZIRST 51, avenue Jean Kunt

Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Vincent Danjean
Joshua Ferraro wrote:
> I can say with certainty that Expact is not UNICODE safe, neither is
> PurlPerl ... only LibXML is safe.

In this case, do you know which part of Koha really call the XML parser ?
As said before:
 I failed to see where koha really instantiate a sax parser.
 'rgrep "use XML::SAX" koha/' does not return anything (but
 sax_parser_print.pl and sax_parser_test.pl).

And if we know where the XML parser is called (directly or indirectly),
we can set in the koha file(s) the global variable
 $XML::SAX::ParserPackage = "XML::LibXML::SAX";
in order to force the good XML parser without requiring to modify a
global configuration file

  Best regards,
Vincent

>>> On Sat, Nov 15, 2008 at 9:13 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
 [moving from koha to koha-devel due to my questions]

 Mason James wrote:
> On 2008/11/12, at 11:56 AM, Brendan Gallagher wrote:
>> Did you try editing ParserDetails.ini
 What I do not understand is why koha is requiring to modify such
 a global configuration file.

 Is this setup really still required ? Were not the bugs from the
 expat filter fixed ? I do not know at all why this parser is/was needed,
 but Expact seems to work for the test case in koha scripts :
 vdanjean koha/misc$ ./sax_parser_print.pl
 XML::SAX::Expat=HASH(0x115c4f0)
 vdanjean koha/misc$ ./sax_parser_test.pl
 é
 vdanjean koha/misc
 )

 By the way, this kind of requirement is really a bad thing (with my
 hat of trying to make a official Debian package) => it will be NOT
 possible at all that the koha package modifies the global configuration
 file.
 However, I really do not understand why, if the SAX parser is really
 needed, it is not required in the koha code itself.

 For example, I tried to add as the first line in sax_parser_print.pl
 and sax_parser_test.pl the line:
 $XML::SAX::ParserPackage = "XML::LibXML::SAX";
 (tip found in the doc of XML::SAX::ParserFactory)
 Without changing my global configuration file, sax_parser_print.pl
 now report XML::LibXML::SAX.

 I failed to see where koha really instantiate a sax parser.
 'rgrep "use XML::SAX" koha/' does not return anything (but
 sax_parser_print.pl and sax_parser_test.pl).

 Perhaps, koha gurus can know where SAX parser are used and add
 the line requesting the particular parser if it is still needed ?

  Regards,
Vincent

-- 
Vincent Danjean Adresse: Laboratoire d'Informatique de Grenoble
Téléphone:  +33 4 76 61 20 11ENSIMAG - antenne de Montbonnot
Fax:+33 4 76 61 20 99ZIRST 51, avenue Jean Kuntzmann
Email: [EMAIL PROTECTED]   38330 Montbonnot Saint Martin
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] String freeze for 3.0.1

2008-12-07 Thread Vincent Danjean
  Hi,

Henri-Damien LAURENT wrote:
> Hi,
> I am glad to announce String Freeze for 3.0.1.
> Translators, you have 3 week time for translations.
> It should be only differences from 3.0.0
> But strings Normalization sometimes did many tiny changes.
> Sorry about that.
> 
> Chris will tell you more about Pootle site that will allow good
> translations.
> Let me know if you encounter any problem.
> Hopefully, christmas will bring us 3.0.1 release. ;)

  Can you consider the last three patches from my git tree in the branch
wip-for-upstream:
http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip-for-upstream
I would be glad if they are applied on koha master and on koha 3.0.x branches.
Here is a brief description of these patches:
- "Use relative path to avoid people dependent paths":
  misc/translator/install.pl and misc/translator/update.pl uses absolute paths
  depending on one particular developer (/home/jmf/kohaclone for example)
- "Force ordering of files when creating/updating po files":
  This avoid to generate false differences in po files
  due to different file ordering on different machines
- "Remove temporary files when updating po files"
  Do not let temporary files on the filesystem after regenerating translated 
files

The aim of these patches is to allow to regenerate translated files at
Debian build-package time. This will allow to correct (with a new Debian
package with a patch) a translation error without waiting for a new
upstream release of koha fixing this error.

  Best regards,
Vincent

-- 
Vincent Danjean   GPG key ID 0x9D025E87 [EMAIL PROTECTED]
GPG key fingerprint: FC95 08A6 854D DB48 4B9A  8A94 0BF7 7867 9D02 5E87
Unofficial pacakges: http://www-id.imag.fr/~danjean/deb.html#package
APT repo:  deb http://perso.debian.org/~vdanjean/debian unstable main

___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Joshua Ferraro
On Sun, Dec 7, 2008 at 11:53 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
> Joshua Ferraro wrote:
>> I can say with certainty that Expact is not UNICODE safe, neither is
>> PurlPerl ... only LibXML is safe.
>
> In this case, do you know which part of Koha really call the XML parser ?
> As said before:
> I failed to see where koha really instantiate a sax parser.
> 'rgrep "use XML::SAX" koha/' does not return anything (but
> sax_parser_print.pl and sax_parser_test.pl).
>
> And if we know where the XML parser is called (directly or indirectly),
> we can set in the koha file(s) the global variable
> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
> in order to force the good XML parser without requiring to modify a
> global configuration file
Primarily, Koha uses a SAX parser in MARC::File::XML, but also XML::Simple.

Cheers,

Josh

>  Best regards,
>Vincent
>
 On Sat, Nov 15, 2008 at 9:13 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
> [moving from koha to koha-devel due to my questions]
>
> Mason James wrote:
>> On 2008/11/12, at 11:56 AM, Brendan Gallagher wrote:
>>> Did you try editing ParserDetails.ini
> What I do not understand is why koha is requiring to modify such
> a global configuration file.
>
> Is this setup really still required ? Were not the bugs from the
> expat filter fixed ? I do not know at all why this parser is/was needed,
> but Expact seems to work for the test case in koha scripts :
> vdanjean koha/misc$ ./sax_parser_print.pl
> XML::SAX::Expat=HASH(0x115c4f0)
> vdanjean koha/misc$ ./sax_parser_test.pl
> é
> vdanjean koha/misc
> )
>
> By the way, this kind of requirement is really a bad thing (with my
> hat of trying to make a official Debian package) => it will be NOT
> possible at all that the koha package modifies the global configuration
> file.
> However, I really do not understand why, if the SAX parser is really
> needed, it is not required in the koha code itself.
>
> For example, I tried to add as the first line in sax_parser_print.pl
> and sax_parser_test.pl the line:
> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
> (tip found in the doc of XML::SAX::ParserFactory)
> Without changing my global configuration file, sax_parser_print.pl
> now report XML::LibXML::SAX.
>
> I failed to see where koha really instantiate a sax parser.
> 'rgrep "use XML::SAX" koha/' does not return anything (but
> sax_parser_print.pl and sax_parser_test.pl).
>
> Perhaps, koha gurus can know where SAX parser are used and add
> the line requesting the particular parser if it is still needed ?
>
>  Regards,
>Vincent
>
> --
> Vincent Danjean Adresse: Laboratoire d'Informatique de 
> Grenoble
> Téléphone:  +33 4 76 61 20 11ENSIMAG - antenne de Montbonnot
> Fax:+33 4 76 61 20 99ZIRST 51, avenue Jean Kuntzmann
> Email: [EMAIL PROTECTED]   38330 Montbonnot Saint Martin
>



-- 
Joshua Ferraro   SUPPORT FOR OPEN-SOURCE SOFTWARE
CEO migration, training, maintenance, support
LibLimeFeaturing Koha Open-Source ILS
[EMAIL PROTECTED] |Full Demos at http://liblime.com/koha |1(888)KohaILS
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Frederic Demians

>> And if we know where the XML parser is called (directly or indirectly),
>> we can set in the koha file(s) the global variable
 $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>> in order to force the good XML parser without requiring to modify a
>> global configuration file
> Primarily, Koha uses a SAX parser in MARC::File::XML, but also 
> XML::Simple.

XML::LibXML::SAX is specifically required by MARC::File::XML. With 
another SAX parser, XML MARC records are not correctly decoded-encoded 
and accented characters, for example, are mixed.

In this file:

MARC/File/XML.pm

line 21:

my $factory = XML::SAX::ParserFactory->new();

a SAX parser is instantiated.

So since MARC::File::XML need XML::LibXML::SAX, it should ask explicitly 
this parser and insert before line 21, as said by Vincent:

$XML::SAX::ParserPackage = "XML::LibXML::SAX";

Can't someone contact MARC::File:XML package maintainer and ask him to 
update his code?

--
Frédéric



___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] String freeze for 3.0.1

2008-12-07 Thread Chris Cormack
On Mon, Dec 8, 2008 at 6:42 AM, Vincent Danjean <[EMAIL PROTECTED]> wrote:
>  Hi,
>
> Henri-Damien LAURENT wrote:
>> Hi,
>> I am glad to announce String Freeze for 3.0.1.
>> Translators, you have 3 week time for translations.
>> It should be only differences from 3.0.0
>> But strings Normalization sometimes did many tiny changes.
>> Sorry about that.
>>
>> Chris will tell you more about Pootle site that will allow good
>> translations.
>> Let me know if you encounter any problem.
>> Hopefully, christmas will bring us 3.0.1 release. ;)
>
>  Can you consider the last three patches from my git tree in the branch
> wip-for-upstream:
> http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip-for-upstream
> I would be glad if they are applied on koha master and on koha 3.0.x branches.
> Here is a brief description of these patches:
> - "Use relative path to avoid people dependent paths":
>  misc/translator/install.pl and misc/translator/update.pl uses absolute paths
>  depending on one particular developer (/home/jmf/kohaclone for example)
> - "Force ordering of files when creating/updating po files":
>  This avoid to generate false differences in po files
>  due to different file ordering on different machines
> - "Remove temporary files when updating po files"
>  Do not let temporary files on the filesystem after regenerating translated 
> files
>
> The aim of these patches is to allow to regenerate translated files at
> Debian build-package time. This will allow to correct (with a new Debian
> package with a patch) a translation error without waiting for a new
> upstream release of koha fixing this error.
>
Those patches look fine to me.

I also really like the idea of being able to correct the translation errors :)

Chris
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Vincent Danjean
Frederic Demians wrote:
>>> And if we know where the XML parser is called (directly or indirectly),
>>> we can set in the koha file(s) the global variable
> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>>> in order to force the good XML parser without requiring to modify a
>>> global configuration file
>> Primarily, Koha uses a SAX parser in MARC::File::XML, but also 
>> XML::Simple.
> 
> XML::LibXML::SAX is specifically required by MARC::File::XML. With 
> another SAX parser, XML MARC records are not correctly decoded-encoded 
> and accented characters, for example, are mixed.
> 
> In this file:
> 
> MARC/File/XML.pm
> 
> line 21:
> 
> my $factory = XML::SAX::ParserFactory->new();
> 
> a SAX parser is instantiated.
> 
> So since MARC::File::XML need XML::LibXML::SAX, it should ask explicitly 
> this parser and insert before line 21, as said by Vincent:
> 
> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
> 
> Can't someone contact MARC::File:XML package maintainer and ask him to 
> update his code?

Someone can ask but I'm not sure that the MARC::File:XML package maintainer
will agree with this modification. Perhaps, he will add the line. But he
can also answer:
- MARC::File::XML can work with other XML parser if there is no accentuated
  letter (no non-ASCII letter) so I do not want to force a specific dependency
or
- MARC::File::XML requires a correct XML parser. If one XML parser is buggy
  then bug must be filled against this XML parser and not against packages
  that use XML parser.
or
- MARC::File::XML will implement in a future release a mechanism to be able
  to choose the XML parser (such as XML::Simple)
or
- ...

So, asking him is a good thing (perhaps he does not know the issue). But
koha can also force the use of the parser it needs (ie add
$XML::SAX::ParserPackage = "XML::LibXML::SAX";
when it uses MARC::File::XML)

It would be good also that misc/sax_parser_test.pl really tests the parser
(I get the same binary output with XML::LibXML::SAX or with the Expat XML
parser)

Note that, according to the XML::Simple documentation, XML::Simple can also
force the XML parser it will use by setting:
$XML::Simple::PREFERRED_PARSER="XML::LibXML::SAX";

I prepared two commits for koha to force the use of the LibXML parser. Can you
test them and apply them if they are ok ? (I only greped for any occurrences
of XML::Simple and MARC::File::XML and add the correct line).
Both commits are available at the top of my wip-for-upstream branch:
http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip-for-upstream
They are:
- "Force MARC::File::XML to use the XML::LibXML::SAX parser"
and
- "Force XML::Simple to use to XML::LibXML::SAX parser"

  Regards,
Vincent
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Henri-Damien LAURENT
Vincent Danjean a écrit :
> Frederic Demians wrote:
>   
 And if we know where the XML parser is called (directly or indirectly),
 we can set in the koha file(s) the global variable
 
>> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>> 
 in order to force the good XML parser without requiring to modify a
 global configuration file
 
>>> Primarily, Koha uses a SAX parser in MARC::File::XML, but also 
>>> XML::Simple.
>>>   
>> XML::LibXML::SAX is specifically required by MARC::File::XML. With 
>> another SAX parser, XML MARC records are not correctly decoded-encoded 
>> and accented characters, for example, are mixed.
>>
>> In this file:
>>
>> MARC/File/XML.pm
>>
>> line 21:
>>
>> my $factory = XML::SAX::ParserFactory->new();
>>
>> a SAX parser is instantiated.
>>
>> So since MARC::File::XML need XML::LibXML::SAX, it should ask explicitly 
>> this parser and insert before line 21, as said by Vincent:
>>
>> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
>>
>> Can't someone contact MARC::File:XML package maintainer and ask him to 
>> update his code?
>> 
>
> Someone can ask but I'm not sure that the MARC::File:XML package maintainer
> will agree with this modification.
Josh is the package maintainer, he may agree with that modification ;)
>  Perhaps, he will add the line. But he
> can also answer:
> - MARC::File::XML can work with other XML parser if there is no accentuated
>   letter (no non-ASCII letter) so I do not want to force a specific dependency
> or
> - MARC::File::XML requires a correct XML parser. If one XML parser is buggy
>   then bug must be filled against this XML parser and not against packages
>   that use XML parser.
> or
> - MARC::File::XML will implement in a future release a mechanism to be able
>   to choose the XML parser (such as XML::Simple)
> or
> - ...
>
> So, asking him is a good thing (perhaps he does not know the issue). But
> koha can also force the use of the parser it needs (ie add
> $XML::SAX::ParserPackage = "XML::LibXML::SAX";
> when it uses MARC::File::XML)
>
> It would be good also that misc/sax_parser_test.pl really tests the parser
> (I get the same binary output with XML::LibXML::SAX or with the Expat XML
> parser)
>
> Note that, according to the XML::Simple documentation, XML::Simple can also
> force the XML parser it will use by setting:
> $XML::Simple::PREFERRED_PARSER="XML::LibXML::SAX";
>
> I prepared two commits for koha to force the use of the LibXML parser. Can you
> test them and apply them if they are ok ? (I only greped for any occurrences
> of XML::Simple and MARC::File::XML and add the correct line).
> Both commits are available at the top of my wip-for-upstream branch:
> http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip-for-upstream
> They are:
> - "Force MARC::File::XML to use the XML::LibXML::SAX parser"
> and
> - "Force XML::Simple to use to XML::LibXML::SAX parser"
>   
I'll try your patches.

___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


[Koha-devel] Fw: Koha Hindi translation

2008-12-07 Thread Krishnan Mani
Sorry to intrude, but i am sending this out to the dev list to check if anyone 
knows who's running the translate list.

i sent the e-mail below to the translate list on 1st December, then wrote to 
the list admin on the 4th, but haven't received a response yet.

BTW, i can volunteer to run the translate list.

Thanks and regards,



krishnan mani

Pune, India

--- On Mon, 1/12/08, Krishnan Mani <[EMAIL PROTECTED]> wrote:
From: Krishnan Mani <[EMAIL PROTECTED]>
Subject: Koha Hindi translation
To: [EMAIL PROTECTED]
Date: Monday, 1 December, 2008, 11:58 PM

Hello,

i'd like to contribute a Hindi translation for Koha, and i don't think this is 
already listed at the Koha translation manager site.

i request the admin to kindly add the same (as indicated on the home page)

Thanks and regards,



krishnan mani

Pune, India

   Add more friends to your messenger and enjoy!  Invite them now.


  Add more friends to your messenger and enjoy! Go to 
http://messenger.yahoo.com/invite/___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] Fw: Koha Hindi translation

2008-12-07 Thread Chris Cormack
On Mon, Dec 8, 2008 at 7:17 PM, Krishnan Mani <[EMAIL PROTECTED]> wrote:
> Sorry to intrude, but i am sending this out to the dev list to check if
> anyone knows who's running the translate list.
>
> i sent the e-mail below to the translate list on 1st December, then wrote to
> the list admin on the 4th, but haven't received a response yet.
>
> BTW, i can volunteer to run the translate list.
>
Hi Krishnan

You sent the below mail to the old koha-translate mailing list. The
current koha-translate mailing list is
[EMAIL PROTECTED]

http://lists.koha.org/mailman/listinfo/koha-translate

Chris
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] State of the debian packaging

2008-12-07 Thread Frederic Demians

> I prepared two commits for koha to force the use of the LibXML parser. 
> Can you test them and apply them if they are ok ? (I only greped for 
> any occurrences of XML::Simple and MARC::File::XML and add the correct 
> line). Both commits are available at the top of my wip-for-upstream 
> branch: 
> http://git.debian.org/?p=collab-maint/koha.git;a=shortlog;h=refs/heads/wip-for-upstream
> They are:
> - "Force MARC::File::XML to use the XML::LibXML::SAX parser"

You have:

$XML::SAX::ParserPackage = "XML::LibXML::SAX";
use MARC::File::XML;

It doesn't work. I've tested it on a Debian box where I can see 
immediately if extended characters are properly displayed or not which 
is not the case with your patch. This modification works:

$XML::SAX::ParserPackage = "XML::LibXML::SAX";
require MARC::File::XML;


> and
> - "Force XML::Simple to use to XML::LibXML::SAX parser"

I can't say if it works and even if it's necessary. We know for sure 
that MARC::File::XML requires LibXML,  but I haven't seen yet that it's 
also the case for XML::Simple.

Another solution for MARC::File::XML would be to embed this package with 
Koha by copying 'MARC' directory and it's subdirectory into Koha 
installation root directory at the same level than 'C4' and then 
modifying XML.pm file to force LibXML use.

Thank you very much Vincent for the good job!
--
Frédéric
___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel


Re: [Koha-devel] Fw: Koha Hindi translation

2008-12-07 Thread Krishnan Mani
Thanks Chris!

Well, before i did anything else, i did hop over to the web archives and found 
my post was there soon after i sent it on the 1st, so i thought i was posting 
to the right list. In any case, i will try the new e-mail address.

This also means the translate site needs to be corrected/updated? It still 
provides a 'non-gnu' e-mail

Thanks and regards,



krishnan mani

Pune, India

--- On Mon, 8/12/08, Chris Cormack <[EMAIL PROTECTED]> wrote:
From: Chris Cormack <[EMAIL PROTECTED]>
Subject: Re: [Koha-devel] Fw: Koha Hindi translation
To: [EMAIL PROTECTED]
Cc: "Koha Devel" 
Date: Monday, 8 December, 2008, 12:56 PM

On Mon, Dec 8, 2008 at 7:17 PM, Krishnan Mani <[EMAIL PROTECTED]>
wrote:
> Sorry to intrude, but i am sending this out to the dev list to check if
> anyone knows who's running the translate list.
>
> i sent the e-mail below to the translate list on 1st December, then wrote
to
> the list admin on the 4th, but haven't received a response yet.
>
> BTW, i can volunteer to run the translate list.
>
Hi Krishnan

You sent the below mail to the old koha-translate mailing list. The
current koha-translate mailing list is
[EMAIL PROTECTED]

http://lists.koha.org/mailman/listinfo/koha-translate

Chris



  Add more friends to your messenger and enjoy! Go to 
http://messenger.yahoo.com/invite/___
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel