Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

[Sune Vuorela]

> On Jan. 15, 2014, 9:17 a.m., Sune Vuorela wrote:
> > kdeui/kmessagewidgetdemo/CMakeLists.txt, line 23
> > 
> >
> > Would it be hard to get rid of XmlGui here? I don't see what it really 
> > buy us for this example?
> > 
> > Replacing it with kwidgetaddons - and maybe switch from kmainwindow to 
> > qmainwindow will make the example simpler.
> 
> Laurent Navet wrote:
> XmlGui replaced with KWidgetAddons and KConfigWidgets.
> switched from KMainWindow to QMainWindow.

I don't see the updated diff ?


- Sune


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/#review47428
---


On Jan. 10, 2014, 8:49 p.m., Laurent Navet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114933/
> ---
> 
> (Updated Jan. 10, 2014, 8:49 p.m.)
> 
> 
> Review request for KDE Examples and Sune Vuorela.
> 
> 
> Repository: kdeexamples
> 
> 
> Description
> ---
> 
> This is part of Google Code-IN Contest.
> As I'm no more student, I've waited for the end of the contest to work on it.
> 
> Comments appreciated,
> 
> 
> Diffs
> -
> 
>   kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac 
>   kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 
>   kdeui/kmessagewidgetdemo/window.h d3a67c8 
>   kdeui/kmessagewidgetdemo/window.cpp 9786da6 
> 
> Diff: https://git.reviewboard.kde.org/r/114933/diff/
> 
> 
> Testing
> ---
> 
> Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit 
> I've commented the line.
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re:compiling okular

[GAURAV Agrawal]

Hello,

As suggested ,I removed the CMakeCache.txt file and then executed the
following command
 cmake -DQT_QMAKE_EXECUTABLE=/usr/bin/qmake-qt4

The following errors occured-

CMake Error at CMakeLists.txt:25 (add_subdirectory):
  add_subdirectory given source "active" which is not an existing directory.


CMake Error at CMakeLists.txt:26 (add_subdirectory):
  add_subdirectory given source "ui" which is not an existing directory.


CMake Error at CMakeLists.txt:27 (add_subdirectory):
  add_subdirectory given source "shell" which is not an existing directory.


CMake Error at CMakeLists.txt:28 (add_subdirectory):
  add_subdirectory given source "generators" which is not an existing
  directory.


CMake Error at CMakeLists.txt:29 (add_subdirectory):
  add_subdirectory given source "tests" which is not an existing directory.


CMake Error at CMakeLists.txt:32 (include):
  include could not find load file:

OkularConfigureChecks.cmake


CMake Error at /usr/share/kde4/apps/cmake/modules/KDE4Macros.cmake:90
(file):
  file Internal CMake error when trying to open file:
  /home/gaurav/okular/build/conf/settings_core.kcfgc for reading.
Call Stack (most recent call first):
  CMakeLists.txt:127 (kde4_add_kcfg_files)


CMake Error at /usr/share/kde4/apps/cmake/modules/KDE4Macros.cmake:90
(file):
  file Internal CMake error when trying to open file:
  /home/gaurav/okular/build/conf/settings.kcfgc for reading.
Call Stack (most recent call first):
  CMakeLists.txt:211 (kde4_add_kcfg_files)



I cant understand these errors.please help me compile the application.

Thanks
Gaurav

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114632: Improve pdf title extraction

[Luis Silva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114632/
---

(Updated Jan. 16, 2014, 1:02 p.m.)


Status
--

This change has been discarded.


Review request for Baloo and Vishesh Handa.


Repository: kfilemetadata


Description
---

A good portion of scientific papers in my collection had a doi or an index 
number in the title. These are in general short string chains, shorter than the 
real title.
I improve extraction of titles from pdf's by setting a minimum size below which 
parsing of the first page is forced.
The cut-off size is arbitrarily set to 25 characters (three "big words").


Diffs
-

  src/extractors/popplerextractor.cpp b056581f51d10b632799586eed3cc15ac539fe80 

Diff: https://git.reviewboard.kde.org/r/114632/diff/


Testing
---

This improved the title extraction on my pdf collection of scientific papers by 
quite a lot.


Thanks,

Luis Silva


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

[Simeon Bird]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115053/
---

Review request for Baloo and Vishesh Handa.


Repository: baloo


Description
---

If indexing a file which no longer exists, remove it from the FileMapping db as 
well as the xapian db


Diffs
-

  src/file/extractor/app.cpp 478ead2bba5b17bad26afa8f04261e8c26dbff55 

Diff: https://git.reviewboard.kde.org/r/115053/diff/


Testing
---

Ran with it, but probably not exercised this code too much.


Thanks,

Simeon Bird


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

[Vishesh Handa]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115053/#review47537
---

Ship it!


:D

- Vishesh Handa


On Jan. 16, 2014, 3:08 p.m., Simeon Bird wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115053/
> ---
> 
> (Updated Jan. 16, 2014, 3:08 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> If indexing a file which no longer exists, remove it from the FileMapping db 
> as well as the xapian db
> 
> 
> Diffs
> -
> 
>   src/file/extractor/app.cpp 478ead2bba5b17bad26afa8f04261e8c26dbff55 
> 
> Diff: https://git.reviewboard.kde.org/r/115053/diff/
> 
> 
> Testing
> ---
> 
> Ran with it, but probably not exercised this code too much.
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

[Laurent Navet]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114933/
---

(Updated Jan. 16, 2014, 8:30 p.m.)


Review request for KDE Examples and Sune Vuorela.


Changes
---

diff updated


Repository: kdeexamples


Description
---

This is part of Google Code-IN Contest.
As I'm no more student, I've waited for the end of the contest to work on it.

Comments appreciated,


Diffs (updated)
-

  kdeui/kmessagewidgetdemo/CMakeLists.txt 12ef4ac 
  kdeui/kmessagewidgetdemo/main.cpp d3a5bf0 
  kdeui/kmessagewidgetdemo/window.h d3a67c8 
  kdeui/kmessagewidgetdemo/window.cpp 9786da6 

Diff: https://git.reviewboard.kde.org/r/114933/diff/


Testing
---

Regression on KTextedit::setClickMessage(), as it don't exist in QTextEdit I've 
commented the line.


Thanks,

Laurent Navet


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: compiling okular

[Albert Astals Cid]

El Dijous, 16 de gener de 2014, a les 16:07:28, GAURAV Agrawal va escriure:
> Hello,
> 
> As suggested ,I removed the CMakeCache.txt file and then executed the
> following command
>  cmake -DQT_QMAKE_EXECUTABLE=/usr/bin/qmake-qt4

In which directory are you running that?

Cheers,
  Albert

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115053/#review47548
---


This review has been submitted with commit 
3b891c133f1c239dad42a10e67e13fcd3a092fe7 by Simeon Bird to branch master.

- Commit Hook


On Jan. 16, 2014, 3:08 p.m., Simeon Bird wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115053/
> ---
> 
> (Updated Jan. 16, 2014, 3:08 p.m.)
> 
> 
> Review request for Baloo and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> If indexing a file which no longer exists, remove it from the FileMapping db 
> as well as the xapian db
> 
> 
> Diffs
> -
> 
>   src/file/extractor/app.cpp 478ead2bba5b17bad26afa8f04261e8c26dbff55 
> 
> Diff: https://git.reviewboard.kde.org/r/115053/diff/
> 
> 
> Testing
> ---
> 
> Ran with it, but probably not exercised this code too much.
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 115053: If indexing a file which no longer exists, remove it from the FileMapping db as well as the xapian db

[Simeon Bird]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115053/
---

(Updated Jan. 16, 2014, 11:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and Vishesh Handa.


Repository: baloo


Description
---

If indexing a file which no longer exists, remove it from the FileMapping db as 
well as the xapian db


Diffs
-

  src/file/extractor/app.cpp 478ead2bba5b17bad26afa8f04261e8c26dbff55 

Diff: https://git.reviewboard.kde.org/r/115053/diff/


Testing
---

Ran with it, but probably not exercised this code too much.


Thanks,

Simeon Bird


>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: compiling okular

[GAURAV Agrawal]

Hi,

I am running that in okular/build directory.

Gaurav


On Fri, Jan 17, 2014 at 2:23 AM, Albert Astals Cid  wrote:

> El Dijous, 16 de gener de 2014, a les 16:07:28, GAURAV Agrawal va escriure:
> > Hello,
> >
> > As suggested ,I removed the CMakeCache.txt file and then executed the
> > following command
> >  cmake -DQT_QMAKE_EXECUTABLE=/usr/bin/qmake-qt4
>
> In which directory are you running that?
>
> Cheers,
>   Albert
>

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<