[amarok] [Bug 432895] Cover art sometimes disappears from current track after rating track

2021-02-13 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=432895

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com
Version|kf5 |2.9.71

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

2021-06-15 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=438651

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #2 from Pedro de Carvalho Gomes  ---
Hi Toni, thanks for the report. I will take a look as soon as I find some time.
But it may be faster if you send the patch and test yourself, given that you
have already invested the time to look at the code. If you're interested, I can
help you with any build/development doubt you have

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

2021-06-24 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=438651

--- Comment #4 from Pedro de Carvalho Gomes  ---
I take a look at this in the next few days. Thanks for the effort

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

2021-06-25 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=438651

--- Comment #5 from Pedro de Carvalho Gomes  ---
I have revised and merged the code for StandardTrackNavigator. As I wrote at
Gitlab, your logic was correct, and my suggestion was merely to refactor the
two for-loops into a single do-while. But that I'll do myself, at the two
choose*Track methods

It's still pending for me to look at how to address the issue with Non-linear
navigators

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

2021-06-25 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=438651

--- Comment #6 from Pedro de Carvalho Gomes  ---
I fixed the problem for Non-linear playlists as well.

Answering your question at the older Merger Request, m_model->trackAt(nextItem)
returns a track by its row. That is, its position at the playlist. But here we
should use m_model->trackById(nextItem) which returns a track by its ID, which
is the info stored at m_historyItems

I have fixed NonlinearTrackNavigator::requestLastTrack(), and now it scans till
it finds a playable track in history. I'm considering to do the same for
likelyLastTrack(), which is used to preview the "prev" track to be played. I
just have to think about some use case, such as the file was temporarily
removed (network filesystem, for example), than reappeared

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 428769] Amarok crashes when saving lyrics [QMapNode]

2021-06-25 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=428769

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/commit/7f800a
   ||80dac088461d102580984b6b95c
   ||be468c0
 Resolution|--- |FIXED
   Version Fixed In||2.9.72
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Pedro de Carvalho Gomes  ---
Git commit 7f800a80dac088461d102580984b6b95cbe468c0 by Pedro Gomes, on behalf
of Jürgen Thomann.
Committed on 25/06/2021 at 21:20.
Pushed by pgomes into branch 'master'.

Prevent Signal from kRichTextEdit during deletion

When the ui is deleted, the deletion of KRichTextEdit will cause a new
signal that will trigger textChanged. As we are already deleting all
objects in the ui, the check for changes in textChanged will access
already deleted objects which crashes Amarok.
FIXED-IN: 2.9.72

M  +3-0src/dialogs/TagDialog.cpp

https://invent.kde.org/multimedia/amarok/commit/7f800a80dac088461d102580984b6b95cbe468c0

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 438651] Amarok stalls if the Previous Track button is pressed but the file not longer exists

2021-06-27 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=438651

--- Comment #9 from Pedro de Carvalho Gomes  ---
Hey Toni, indeed something similar should be implemented for the next track.
That is, a loop until a playable track is found. Can you take care of this? The
code from requestLastTrack() can be used as inspiration

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 434940] NetworkManager-fortisslvpn plugin not working.

2021-03-28 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=434940

--- Comment #4 from Pedro de Carvalho Gomes  ---
The bug is caused by unnecessary empty 2fa values that are added to the
.nmconnection file when the "2FA" is left unchecked. This empty values are used
downstream, and if the openfortivpn client doesn't support it, it will complain
and terminate.

At the simple fix, now plasma-nm doesn't store the 2fa garbage is the checkbox
is not set.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 434940] NetworkManager-fortisslvpn plugin not working.

2021-03-29 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=434940

--- Comment #7 from Pedro de Carvalho Gomes  ---
It's worth pointing out that the fix won't have effect with existing
connections that had the bad "2fa" values. Either the person removes the
garbage manually, or delete and create a new connection.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 424567] Edit track details does not always work in local collection

2020-07-24 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=424567

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Pedro de Carvalho Gomes  ---
I have noticed the same issue and already started to take a look. The issue
seems to be caused by some wrong internal type conversion. Instead of the
SQLMeta, which holds info for local collection, track type is the generic Meta.

Currently I'm busy concluding the port of Amarok scripting engine to QJSEngine.
I take a look as soon as I conclude it, which might take a while.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 424567] Edit track details does not always work in local collection

2020-07-24 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=424567

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

Version|2.9.0   |kf5

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-07-30 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
   |imedia/amarok/commit/4de6bb |imedia/amarok/commit/80b2b9
   |675a3e4dbffa46dae87d08549b4 |aa9b8267c184dacb38cd38c5d4e
   |f728a33 |a03e336

--- Comment #15 from Pedro de Carvalho Gomes  ---
Git commit 80b2b9aa9b8267c184dacb38cd38c5d4ea03e336 by Pedro de Carvalho Gomes.
Committed on 30/07/2020 at 20:36.
Pushed by pgomes into branch
'bug_421456-crash_when_exiting_edit_filter_dialog'.

Summary: Fix crash when closing dialog to edit filter

M  +6-6src/dialogs/EditFilterDialog.cpp
M  +1-1src/dialogs/EditFilterDialog.h
M  +4-5src/widgets/Token.cpp
M  +1-0src/widgets/Token.h
M  +2-2src/widgets/TokenDropTarget.cpp

https://invent.kde.org/multimedia/amarok/commit/80b2b9aa9b8267c184dacb38cd38c5d4ea03e336

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-07-30 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
   |imedia/amarok/commit/80b2b9 |imedia/amarok/commit/df34fd
   |aa9b8267c184dacb38cd38c5d4e |789a8cd14bea5482c88c85216b2
   |a03e336 |ef791c9

--- Comment #16 from Pedro de Carvalho Gomes  ---
Git commit df34fd789a8cd14bea5482c88c85216b2ef791c9 by Pedro Gomes.
Committed on 30/07/2020 at 20:42.
Pushed by pgomes into branch 'master'.

Summary: Fix crash when closing dialog to edit filter

M  +6-6src/dialogs/EditFilterDialog.cpp
M  +1-1src/dialogs/EditFilterDialog.h
M  +4-5src/widgets/Token.cpp
M  +1-0src/widgets/Token.h
M  +2-2src/widgets/TokenDropTarget.cpp

https://invent.kde.org/multimedia/amarok/commit/df34fd789a8cd14bea5482c88c85216b2ef791c9

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-27 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #13 from Pedro de Carvalho Gomes  ---
The problem was at the package and the source it used to be built. Basically I
made some confusion between branches. I have recreated packages for 19.10 and
20.04, and all should be back to track

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-27 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/amarok/commit/4de6bb
   ||675a3e4dbffa46dae87d08549b4
   ||f728a33

--- Comment #14 from Pedro de Carvalho Gomes  ---
Git commit 4de6bb675a3e4dbffa46dae87d08549b4f728a33 by Pedro de Carvalho Gomes.
Committed on 27/06/2020 at 12:03.
Pushed by pgomes into branch
'bug_421456-crash_when_exiting_edit_filter_dialog'.

Summary: Fix crash when closing dialog to edit filter

M  +6-6src/dialogs/EditFilterDialog.cpp
M  +1-1src/dialogs/EditFilterDialog.h
M  +4-5src/widgets/Token.cpp
M  +1-0src/widgets/Token.h
M  +2-2src/widgets/TokenDropTarget.cpp

https://invent.kde.org/multimedia/amarok/commit/4de6bb675a3e4dbffa46dae87d08549b4f728a33

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 434940] NetworkManager-fortisslvpn plugin not working.

2021-03-26 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=434940

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #1 from Pedro de Carvalho Gomes  ---
I confirm the issue. It is caused by the 2fa-flags configuration added by
plasma-nm. See here: https://bugs.archlinux.org/task/69749

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 432903] Amarok crashes on exit [BrowserBreadcrumbWidget::addBreadCrumbItem(BrowserBreadcrumbItem*) ]

2021-02-23 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=432903

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #7 from Pedro de Carvalho Gomes  ---
Hi,

The crash seems to be caused by Amarok trying to stop some running script. Can
you provide all the scripts that you have installed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog

2020-06-04 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #5 from Pedro de Carvalho Gomes  ---
Hi Robert,it doesn't seem that you've installed the package with the debug
symbols: amarok-dbgsym. It's optional, but crucial when sending traces.

Can you do so, reproduce the error, and send the new trace?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-09 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

--- Comment #7 from Pedro de Carvalho Gomes  ---
I confirm the crash. As stated above, it required at least one item at the
filter.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-12 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

--- Comment #8 from Pedro de Carvalho Gomes  ---
I fixed the bug. It was caused by a bad habit that I see all across the code:
widgets that capture QObject::destroyed signal from its descendants. This is
bad because such are signaled either when the code deletes the descendant, or
when it was deleted in the deletion chain of the ascendant widget when it was
deleted. This leads to slots of "half-dead" widgets being called, which in turn
accesss a deleted member, thus leading to the crash

I have already published a new version with the fix in my launchpad. I have
also created the Merge request to the main repository, but I am waiting
revision.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Pedro de Carvalho Gomes  ---
The reported confirmed that the bug was fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421456] Crash when exiting Edit filter dialog [TokenDropTarget::tokensAtRow ]

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421456

--- Comment #11 from Pedro de Carvalho Gomes  ---
(In reply to robert marshall from comment #9)
> This looks fixed to me - though maybe there's more of this - looking at
> https://bugs.kde.org/show_bug.cgi?id=422132 which seems similar - a crash
> when trying to return to displaying Local Collection. But this instance can
> be closed - thanks!

Thanks Robert for pointing out those. I will take a look at the other bug

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 422132] If you go from dynamic playlists to local collection amarok will crash

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=422132

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com
 Status|REPORTED|CONFIRMED
  Component|Playlists/Dynamic Playlists |Collection Browser
 Ever confirmed|0   |1

--- Comment #5 from Pedro de Carvalho Gomes  ---
I managed to reproduce it locally. I have started to look on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 418643] Dynamic album playlist not repopulating queue

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=418643

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||pedrogome...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 389138] Dynamic playlist not advancing

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=389138

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
 CC||pedrogome...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 325094] Dynamic playlist fails to add appropriate tracks automatically

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=325094

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #11 from Pedro de Carvalho Gomes  ---
Myriam, this report is from an older version. But looking at the code, I can
see that the issue has been there since long and probably the cause was the
same as the others. Thus, I believe that this should be closed as well. Please
do so if you agree

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 421341] Script installed not on list

2020-06-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=421341

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1
 CC||pedrogome...@gmail.com
 Status|RESOLVED|REOPENED

--- Comment #4 from Pedro de Carvalho Gomes  ---
I am rewriting the Script engine, and I believe I know the reason for this: KF5
does not read KPluginInfo configuration files if they do not have the correct
suffix ".desktop". However Amarok uses the name "script.spec" all across the
script engine.

The new script engine will fix this by renaming the file, and encouraging the
migration to the newer KPluginMetaData json format.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 422132] If you go from dynamic playlists to local collection amarok will crash

2020-06-16 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=422132

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Pedro de Carvalho Gomes  ---
The error was caused by a wrong deletion of child menus in Breadcrumb widget.
It was introduced at my fix of the widget, which is not at upstream yet.

I concluded the fix and published a new package. I also fix the merge request
for the upstream

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419970] Amarok does not play - Does not load Phonon plugins and simply does nothing when I try to start a track

2020-04-16 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419970

--- Comment #12 from Pedro de Carvalho Gomes  ---
Please do open bugs for all those issues. And please add the commit ID or date
from your compilation. It is possible that few of those problems have already
been solved.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419970] Amarok does not play - Does not load Phonon plugins and simply does nothing when I try to start a track

2020-04-18 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419970

--- Comment #13 from Pedro de Carvalho Gomes  ---
Just like Myriam, When I first read this bug report,I understood that it was
about KF5's version from HEAD/master. So I created a Dockerfile for Neon to
check it. I will attach this to the bug report in case someone else hits here
for the KF5 compilation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419970] Amarok does not play - Does not load Phonon plugins and simply does nothing when I try to start a track

2020-04-18 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419970

--- Comment #14 from Pedro de Carvalho Gomes  ---
Created attachment 127642
  --> https://bugs.kde.org/attachment.cgi?id=127642&action=edit
Dockerfile that builds Amarok KF5 for Neon 18.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419524] lyrics exist in db and are not displayed

2020-04-20 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419524

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #2 from Pedro de Carvalho Gomes  ---
I ran the same version at Opensuse Tumbleweed, but could not detect the error.
Please run in debug mode (amarok -d) and attach the log here. Please open few
tracks to help identifying where the problem might be

(In reply to Philippe Conde from comment #1)
> Created attachment 127643 [details]
> tracks details differences from playlist and from media source
> 
> One observation:
> I have a track in the playlist. I restart amarok and using the track details
> (right button) on the playlist I can see the lyrics in tab lyrics
> If I select the same track from the media source and go to the track details
> the lyrics tab is empty.Same for all other tracks in the media source (local
> collection)
> 
> See image linked

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419524] lyrics exist in db and are not displayed

2020-04-25 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419524

--- Comment #5 from Pedro de Carvalho Gomes  ---
Hi Philippe,

Only today I could take a careful look at the lyrics issue. Basically, there's
no support for cached (stored in db) lyrics after the port to KF5 yet. I won't
retrieve nor store lyrics at DB. The only available support at this point is to
retrieve from lyrics.fandom.com (that's what I was looking at my Opensuse)

I might re-implement this. But I have other functionalities that have higher
priority before. If you're a programmer and would like to take a look, I can
gladly help you here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 420964] Current Track applet layout a mess

2020-05-05 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=420964

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #4 from Pedro de Carvalho Gomes  ---
Right now the "Current track" applet at this point doesn't allow resizing.
Also, it loads covers with large size. Thus, when the applet doesn't have all
required size (for example, in low-resolution screens), the rest is simply
hidden to the right

I might take a look at this applet soon. This size issue has been bothering me
for a while as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-01-08 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #13 from Pedro de Carvalho Gomes  ---
Hi, I need more information that what I have to be able to know what's going
on.

But I suspect that you are not using Mysql. Rather you have MariaDB, which
hasn't deprecated the embedded server.

By the way, this is a quick alternative for Lapineige to try to get it working.
Replace all Mysql packages with MariaDB alternatives:

apt-get install libmariadbclient-dev libmariadbd-dev mariadb-client
mariadb-common

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-01-09 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #15 from Pedro de Carvalho Gomes  ---
I am also running Kubuntu 19.10 and I am able to compile Amarok/master and run
with MariaDB. MariaDB is a complete replacement to Mysql. So it seems like a
good idea to replace all Mysql packages with MariaDB ones. But especially  make
sure that you have libmariadbd-dev and libmariadbd19.

But before you try MariaDB, let's make sure that the package that you're trying
to run was correctly built. That is, it is linked to libmariadbd or libmysqld.
And not to libmysqlclient. You can know it by running the following command. It
lists the linkage of the amarok's Mysql embedded module:

ldd /usr/lib/x86_64-linux-gnu/qt5/plugins/amarok_storage-mysqlestorage.so

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-02-03 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #18 from Pedro de Carvalho Gomes  ---
(In reply to Lapineige from comment #17)
> >ldd 
> >/usr/lib/x86_64-linux-gnu/qt5/plugins/amarok_storage-mysqlserverstorage.so # 
> >not amarok_storage-mysqlestorage.so
> >libmysqlclient.so.21
> 
> I guess I'll need to built it my-self ? :/

I have built it and I can pack it for you if you want. But I can also assist
you to build your own package. What do you prefer?

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 417259] New: Amarok fails to load lyrics from lyrics.wikia.com

2020-02-07 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=417259

Bug ID: 417259
   Summary: Amarok fails to load lyrics from lyrics.wikia.com
   Product: amarok
   Version: 2.9.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Context View/Lyrics
  Assignee: amarok-bugs-d...@kde.org
  Reporter: pedrogome...@gmail.com
  Target Milestone: kf5

Amarok does not load lyrics from lyrics.wikia.com since the domain now is
redirected to lyrics.fandom.com

STEPS TO REPRODUCE
1. enable the Lyrics applet
2. play a song which hasn't the lyrics cached

OBSERVED RESULT
The lyrics are not loaded. A simple log inspection shows the reason: the applet
doesn't handle the HTTP redirection to lyrics.fandom.com (and to HTTPS schema).

EXPECTED RESULT
Lyrics are loaded inside the applet


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 19.10
(available in About System)
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
I have already implemented the fix to this. I need someone to assist me on the
steps to push it to the main branch

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 417259] Amarok fails to load lyrics from lyrics.wikia.com

2020-02-13 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=417259

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

   Assignee|amarok-bugs-d...@kde.org|pedrogome...@gmail.com

--- Comment #2 from Pedro de Carvalho Gomes  ---
Thank you Myriam for the reply. I have created a review request (D27369) for
this bug, and others

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-02-13 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #21 from Pedro de Carvalho Gomes  ---
I have build the package, but it will take me a while to set-up my launchpad to
public it  correctly. Do you want the .deb file? I could even send you by
e-mail. The file is about 5 MB.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-02-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #23 from Pedro de Carvalho Gomes  ---
I have uploaded the package amarok_2.9.70-0ubuntu1_amd64.deb. It is available
until March 15 20202 at the link below

https://framadrop.org/r/kXFlmE3RFf#jxKU+8OyFxXOI+w6jHks9Rwcsa4xQt50+8wl/AlwQbk=

For your safety, here are the checksums:

SHA256: ae1d7aeb4256c1f9286240d036799b0f37e09c34d523f85ab5e2d4ccad5efbf3
MD5:70ec336237dd51844cafbc93b9395dcb

I built the package from my Amarok repo in Github. The branch Kubuntu_19.10 is
basically master/HEAD with few fixes I wrote to the Lyrics and Wikipedia
applets.

https://github.com/pcgomes/amarok/tree/Kubuntu_19.10

Let me know if it worked for you

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-02-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #25 from Pedro de Carvalho Gomes  ---
Hard to say with this log. But it seems likely that it has to do with the old
PPA. Especially because its versions is newer (2.9.80) than mine (2.9.70); thus
apt may stick to the most recent.

In addition to trying to remove the other Amarok PPA, here are few more
thoughts:

- you can unset the localization at command line with "unset LANG". This way
you don't need to translate localized logs back to english

- I have attached a Dockerfile that downloads automatically Amarok for
(K)Ubuntu 19.10 and run the configure. After, a simple "make" (which I omitted
because it takes long) compiles Amarok.

If you're not familiar with docker, you still can use it as reference to
prepare your own build environment

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-02-14 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #26 from Pedro de Carvalho Gomes  ---
Created attachment 126019
  --> https://bugs.kde.org/attachment.cgi?id=126019&action=edit
Dockerfile that set-up Amarok's build environment

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2019-12-06 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #1 from Pedro de Carvalho Gomes  ---
The error happens because Kubuntu 19.10 is shipped with Mysql 8. This major
Mysql version deprecated Mysql Embedded, which is the standard DB for Amarok.
You can read more about it here:

https://mysqlserverteam.com/mysql-8-0-retiring-support-for-libmysqld/

I assume the package you installed is linked with libmysqlclient, whose API is
almost exactly the same as libmysqld. If this is the case, Amarok will try to
open a socket to a local mysql standalone instead of reading the old DB from
~/.local/share/amarok/mysqle. It seems that there's no such mysql (or you can't
connect to it witout password), so you get the error.

The obvious workaround is to import the old DB to a stand-alobe mysql instance.

However, a permanent fix is harded. It depends on what Amarok team will decide
to replace Mysql embedded. I assume it will be to run a standalone mysql,
similar to Akonadi.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2019-12-09 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #3 from Pedro de Carvalho Gomes  ---
The following command starts a mysql server with your old Amarok DB that is
accessible only via socket (notice that paths my vary):

/usr/sbin/mysqld --defaults-file=/home/your_user/.local/share/amarok/my.cnf
--datadir=/home/your_user/.kde/share/apps/amarok/mysqle
--socket=/run/user/1000/akonadi/default/mysql-amarok.socket
--pid-file=/run/user/1000/akonadi/default/mysql-amarok.pid --skip-networking
--skip_grant_tables

You may test connection with the command below:

mysql --socket=/run/user/1000/akonadi/default/mysql-amarok.socket


Add the following command to your .my.cnf file in your home directory
(/home/your_user/.my.cnf in this example):

[client]
socket=/run/user/1000/akonadi/default/mysql-amarok.socket

Now Amarok should be able to connect to the old DB and run as before

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2019-12-10 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #5 from Pedro de Carvalho Gomes  ---
Keep in mind that the command and parameters I write are mere suggestions.
Everything is dependant on your local environment.

Some hints about your last question:

1) it's probably fine to remove the
"--defaults-file=/home/your_user/.local/share/amarok/my.cnf" option. I guess
that it only contains an "[embedded]" session, which is not used by Mysql 8

2) if you don't have the ~/.my.cnf, you have to create it. I can't tell if this
is sufficient, but should be. All this file does is to define a default
connection to mysqlclient library (which is also used by "mysql" command)

So, a good way to test if your connection to mysql server will work is to turn
"mysql" without parameters. If your .my.cnf is correct, and your "mysqld"
(server) is running, you should be able to connect

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419159] QT5 release is required to bring Amarok back into Debian and Ubuntu repositories

2020-04-11 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419159

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #3 from Pedro de Carvalho Gomes  ---
I went after Mariadb's plans for the embedded library. I couldn't find any
mention to it. Only references to 10.5 series mirroring Mysql 8, which is the
version that dropped Mysql embedded. However Mariadb 10.4 contains the embedded
library, and is supported until June 2024 (see
https://mariadb.com/kb/en/new-and-old-releases/)

I wonder if Amarok could release a version with dependency to Mariadb <= 10.4.
Thus bridging the 2-year gap from previous release. Then we prioritize the port
to the alternative to mariadb/mysql.

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 414407] Can't load database (plugin)

2020-04-11 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=414407

--- Comment #36 from Pedro de Carvalho Gomes  ---
I finally set my launchpad. There I am publishing builds from my personal
repository. There I publish the patches that I send upstream, but are still
under revision. Also, I rebase from the official repository before every new
snapshot. Comments are welcome

https://launchpad.net/~pgomes/+archive/ubuntu/amarok

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 411716] Amarok crashes when Add to Collections dialog is closed.

2020-04-11 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=411716

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/ama
   ||rok/96eaac4fc0996328f8f218a
   ||178a7e216623b2266
 Resolution|BACKTRACE   |FIXED

--- Comment #4 from Pedro de Carvalho Gomes  ---
Git commit 96eaac4fc0996328f8f218a178a7e216623b2266 by Pedro de Carvalho Gomes.
Committed on 11/04/2020 at 15:00.
Pushed by pgomes into branch 'master'.

Fix copying and moving files to collection

Summary:
The importation of files to collections was not working. Both because its
dialogs were crashing and because the copying method was wrong. This patch does
the following:

- fix the crash of confirmation dialog when either accepting or rejecting the
import. The crash was caused because a "detroyed" signal was being used at a
chain of deleted widgets, eventually causing a crash signal
- fix the file copying (SqlCollectionLocation.cpp). The code was using a QURL
(with the "file:///" scheme) to locate the destination, and thus failing to
find the destination dir
- fix the layout of Transcoding dialog. Before the buttonbox was doubled, and
only the KPageDialog was being show. And was overlapped by another widget
fix the layout of the importation configuration menu
(OrganizeCollectionDialog). Before the QDialog didn't have a layout, and
resizing the window was not resizing widgets
- restore the importation menu to "Copy to Collection". Before only "Move to
Collection" was popping up an importation dialog. The reason was a wrong
connection of signals

Reviewers: #amarok, amarok-devel, heikobecker

Reviewed By: #amarok, heikobecker

Subscribers: #amarok, heikobecker, amarok-devel

Differential Revision: https://phabricator.kde.org/D28593

M  +1-1src/browsers/filebrowser/FileView.cpp
M  +1-1src/core-impl/collections/db/sql/SqlCollectionLocation.cpp
M  +8-4src/dialogs/OrganizeCollectionDialog.cpp
M  +2-7src/transcoding/TranscodingAssistantDialog.cpp
M  +1-1src/transcoding/TranscodingAssistantDialog.ui
M  +2-2src/transcoding/TranscodingPropertySliderWidget.cpp
M  +3-2src/widgets/TokenDropTarget.cpp

https://commits.kde.org/amarok/96eaac4fc0996328f8f218a178a7e216623b2266

-- 
You are receiving this mail because:
You are watching all bug changes.

[amarok] [Bug 419970] Amarok does not play - Does not load Phonon plugins and simply does nothing when I try to start a track

2020-04-12 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=419970

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC||pedrogome...@gmail.com

--- Comment #6 from Pedro de Carvalho Gomes  ---
I disagree that Amarok is not being maintained. You may argue that the
development has been slow, though.

I see that you have KF5 installed. Have you tried to compile amarok from
master/HEAD? Also, I remember few things in Amarok searched for absolute paths.
Have you tried "sudo make install" and then run Amarok?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 226414] Kopete crash - doing nothing ( running in the background ) [free, QRingBuffer, QAbstractSocketPrivate::canWriteNotification]

2018-10-03 Thread Pedro de Carvalho Gomes
https://bugs.kde.org/show_bug.cgi?id=226414

Pedro de Carvalho Gomes  changed:

   What|Removed |Added

 CC|pedrogome...@gmail.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 361236] New: Kwin crashes when trying to open configurations of the system tray

2016-03-31 Thread Pedro de Carvalho Gomes via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361236

Bug ID: 361236
   Summary: Kwin crashes when trying to open configurations of the
system tray
   Product: kwin
   Version: 5.6.1
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: kwin-bugs-n...@kde.org
  Reporter: pedrogome...@gmail.com

Application: kwin_x11 (5.6.1)

Qt Version: 5.6.0
Frameworks Version: 5.20.0
Operating System: Linux 4.5.0-5.g8cf0ce6-default x86_64
Distribution: "openSUSE Leap 42.1 (x86_64)"

-- Information about the crash:
- What I was doing when the application crashed:

I had just started a new KDE session, and NetworkManager was still connecting
to the wi-fi.

I right-clicked in the system's tray arrow. It show the menu with
"Configurations of the system tray" (Inställningar av systembricka in Swedish),
and then I left-click on it. The configuration window opens despite the crash.

- Unusual behavior I noticed: the crash just happens once. After, Kwin is
restarted automatically, and the crash no longer happens when I try to open the
system tray configuration.

- Custom settings of the application: SV (Swedish) localization.

The crash can be reproduced every time.

-- Backtrace:
Application: Kwin (kwin_x11), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7febd387c840 (LWP 2746))]

Thread 6 (Thread 0x7febb925d700 (LWP 2756)):
#0  0x7febd31f3bbd in poll () from /lib64/libc.so.6
#1  0x7febd0b2b422 in ?? () from /usr/lib64/libxcb.so.1
#2  0x7febd0b2d00f in xcb_wait_for_event () from /usr/lib64/libxcb.so.1
#3  0x7febba133979 in QXcbEventReader::run (this=0xb76200) at
qxcbconnection.cpp:1313
#4  0x7febd0def079 in QThreadPrivate::start (arg=0xb76200) at
thread/qthread_unix.cpp:340
#5  0x7febd28130a4 in start_thread () from /lib64/libpthread.so.0
#6  0x7febd31fbfed in clone () from /lib64/libc.so.6

Thread 5 (Thread 0x7febb3151700 (LWP 2761)):
#0  0x7febd31f5253 in select () from /lib64/libc.so.6
#1  0x7febd0ffc8e9 in qt_safe_select (nfds=8, fdread=0x7febac000a98,
fdwrite=0x7febac000d28, fdexcept=0x7febac000fb8, orig_timeout=0x0) at
kernel/qcore_unix.cpp:75
#2  0x7febd0ffe1b5 in QEventDispatcherUNIXPrivate::doSelect
(this=this@entry=0x7febac000900, flags=..., flags@entry=..., timeout=0x0) at
kernel/qeventdispatcher_unix.cpp:196
#3  0x7febd0ffe5f7 in QEventDispatcherUNIX::processEvents
(this=0x7febac0008e0, flags=...) at kernel/qeventdispatcher_unix.cpp:607
#4  0x7febd0fae04b in QEventLoop::exec (this=this@entry=0x7febb3150d60,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:204
#5  0x7febd0dea5da in QThread::exec (this=) at
thread/qthread.cpp:503
#6  0x7febc9e3b095 in ?? () from /usr/lib64/libQt5DBus.so.5
#7  0x7febd0def079 in QThreadPrivate::start (arg=0x7febca0a3d00) at
thread/qthread_unix.cpp:340
#8  0x7febd28130a4 in start_thread () from /lib64/libpthread.so.0
#9  0x7febd31fbfed in clone () from /lib64/libc.so.6

Thread 4 (Thread 0x7febb0e28700 (LWP 2770)):
#0  0x7febd31f5253 in select () from /lib64/libc.so.6
#1  0x7febd0ffc8e9 in qt_safe_select (nfds=14, fdread=0x7feba8000a98,
fdwrite=0x7feba8000d28, fdexcept=0x7feba8000fb8, orig_timeout=0x0) at
kernel/qcore_unix.cpp:75
#2  0x7febd0ffe1b5 in QEventDispatcherUNIXPrivate::doSelect
(this=this@entry=0x7feba8000900, flags=..., flags@entry=..., timeout=0x0) at
kernel/qeventdispatcher_unix.cpp:196
#3  0x7febd0ffe5f7 in QEventDispatcherUNIX::processEvents
(this=0x7feba80008e0, flags=...) at kernel/qeventdispatcher_unix.cpp:607
#4  0x7febd0fae04b in QEventLoop::exec (this=this@entry=0x7febb0e27d70,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:204
#5  0x7febd0dea5da in QThread::exec (this=this@entry=0xf5a3e0) at
thread/qthread.cpp:503
#6  0x7febcaeb44d8 in QQmlThreadPrivate::run (this=0xf5a3e0) at
/usr/src/debug/qtdeclarative-opensource-src-5.6.0/src/qml/qml/ftw/qqmlthread.cpp:141
#7  0x7febd0def079 in QThreadPrivate::start (arg=0xf5a3e0) at
thread/qthread_unix.cpp:340
#8  0x7febd28130a4 in start_thread () from /lib64/libpthread.so.0
#9  0x7febd31fbfed in clone () from /lib64/libc.so.6

Thread 3 (Thread 0x7feba27fd700 (LWP 2779)):
#0  0x7febd281703f in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib64/libpthread.so.0
#1  0x7febcfd6797b in ?? () from /usr/lib64/libQt5Script.so.5
#2  0x7febcfd679a9 in ?? () from /usr/lib64/libQt5Script.so.5
#3  0x7febd28130a4 in start_thread () from /lib64/libpthread.so.0
#4  0x7febd31fbfed in clone () from /lib64/libc.so.6

Thread 2 (Thread 0x7feb0e757700 (LWP 3088)):
#0  0x7febd31f5253 in select () from /lib64/libc.so.6
#1  0x7febd0ffc8e9 in qt_safe_select (nfds=18, fdread=0x7feb080add68,
fdwrite=0x7feb080adff8, fdexcept=0x7feb0