https://bugs.kde.org/show_bug.cgi?id=411716
Pedro de Carvalho Gomes <pedrogome...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/ama
| |rok/96eaac4fc0996328f8f218a
| |178a7e216623b2266
Resolution|BACKTRACE |FIXED
--- Comment #4 from Pedro de Carvalho Gomes <pedrogome...@gmail.com> ---
Git commit 96eaac4fc0996328f8f218a178a7e216623b2266 by Pedro de Carvalho Gomes.
Committed on 11/04/2020 at 15:00.
Pushed by pgomes into branch 'master'.
Fix copying and moving files to collection
Summary:
The importation of files to collections was not working. Both because its
dialogs were crashing and because the copying method was wrong. This patch does
the following:
- fix the crash of confirmation dialog when either accepting or rejecting the
import. The crash was caused because a "detroyed" signal was being used at a
chain of deleted widgets, eventually causing a crash signal
- fix the file copying (SqlCollectionLocation.cpp). The code was using a QURL
(with the "file:///" scheme) to locate the destination, and thus failing to
find the destination dir
- fix the layout of Transcoding dialog. Before the buttonbox was doubled, and
only the KPageDialog was being show. And was overlapped by another widget
fix the layout of the importation configuration menu
(OrganizeCollectionDialog). Before the QDialog didn't have a layout, and
resizing the window was not resizing widgets
- restore the importation menu to "Copy to Collection". Before only "Move to
Collection" was popping up an importation dialog. The reason was a wrong
connection of signals
Reviewers: #amarok, amarok-devel, heikobecker
Reviewed By: #amarok, heikobecker
Subscribers: #amarok, heikobecker, amarok-devel
Differential Revision: https://phabricator.kde.org/D28593
M +1 -1 src/browsers/filebrowser/FileView.cpp
M +1 -1 src/core-impl/collections/db/sql/SqlCollectionLocation.cpp
M +8 -4 src/dialogs/OrganizeCollectionDialog.cpp
M +2 -7 src/transcoding/TranscodingAssistantDialog.cpp
M +1 -1 src/transcoding/TranscodingAssistantDialog.ui
M +2 -2 src/transcoding/TranscodingPropertySliderWidget.cpp
M +3 -2 src/widgets/TokenDropTarget.cpp
https://commits.kde.org/amarok/96eaac4fc0996328f8f218a178a7e216623b2266
--
You are receiving this mail because:
You are watching all bug changes.
