Re: [JPP-Devel] Deprecation with GeoPackage and spatial index
Hi, I will have a look at it ! Nicolas On Wed, 12 Feb 2020 at 08:31, Rahkonen Jukka (MML) < jukka.rahko...@maanmittauslaitos.fi> wrote: > Hi, > > > > It seems that loosing spatial index of GeoPackage tables is a side effect > of this changeset that was otherwise a nice improvement > https://sourceforge.net/p/jump-pilot/code/5976/ > > > > -Jukka- > > > > *Lähettäjä:* Rahkonen Jukka (MML) > *Lähetetty:* keskiviikko 12. helmikuuta 2020 0.14 > *Vastaanottaja:* jump-pilot-devel@lists.sourceforge.net > *Aihe:* [JPP-Devel] Deprecation with GeoPackage and spatial index > > > > Hi, > > > > I noticed that there has happened some deprecation with GeoPackages since > released OpenJUMP 1.12. Version 1.12 detects and utilizes the spatial index > of a table which makes it very fast to use even huge tables if map is > zoomed close enough. New snapshots do not utilize spatial index which > makes OJ very slow with large tables. I have not yet analyzed more closely > when this change has happened. It seems that the layer list is sorted > differently now than in 1.12. Perhaps that change is related. > > > > I believe that the detection is done here > https://sourceforge.net/p/jump-pilot/code/HEAD/tree/core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java#l151 > . > > > > -Jukka Rahkonen- > ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Deprecation with GeoPackage and spatial index
hey Nico, would you like me to hold the release for the fix or do you need more time? .. snappy new one btw. ede On 12.02.2020 10:57, Nicolas Ribot wrote: > Hi, > > I will have a look at it ! > > Nicolas > > On Wed, 12 Feb 2020 at 08:31, Rahkonen Jukka (MML) < > jukka.rahko...@maanmittauslaitos.fi> wrote: > >> Hi, >> >> >> >> It seems that loosing spatial index of GeoPackage tables is a side effect >> of this changeset that was otherwise a nice improvement >> https://sourceforge.net/p/jump-pilot/code/5976/ >> >> >> >> -Jukka- >> >> >> >> *Lähettäjä:* Rahkonen Jukka (MML) >> *Lähetetty:* keskiviikko 12. helmikuuta 2020 0.14 >> *Vastaanottaja:* jump-pilot-devel@lists.sourceforge.net >> *Aihe:* [JPP-Devel] Deprecation with GeoPackage and spatial index >> >> >> >> Hi, >> >> >> >> I noticed that there has happened some deprecation with GeoPackages since >> released OpenJUMP 1.12. Version 1.12 detects and utilizes the spatial index >> of a table which makes it very fast to use even huge tables if map is >> zoomed close enough. New snapshots do not utilize spatial index which >> makes OJ very slow with large tables. I have not yet analyzed more closely >> when this change has happened. It seems that the layer list is sorted >> differently now than in 1.12. Perhaps that change is related. >> >> >> >> I believe that the detection is done here >> https://sourceforge.net/p/jump-pilot/code/HEAD/tree/core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java#l151 >> . >> >> >> >> -Jukka Rahkonen- >> > > > > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Deprecation with GeoPackage and spatial index
Hi, I'm currently looking at the problem, that also occur with spatialite format. I hope it will be fixed in few hours. I'll keep you posted. Nicolas On Wed, 12 Feb 2020 at 11:53, wrote: > hey Nico, > > would you like me to hold the release for the fix or do you need more > time? .. snappy new one btw. ede > > > On 12.02.2020 10:57, Nicolas Ribot wrote: > > Hi, > > > > I will have a look at it ! > > > > Nicolas > > > > On Wed, 12 Feb 2020 at 08:31, Rahkonen Jukka (MML) < > > jukka.rahko...@maanmittauslaitos.fi> wrote: > > > >> Hi, > >> > >> > >> > >> It seems that loosing spatial index of GeoPackage tables is a side > effect > >> of this changeset that was otherwise a nice improvement > >> https://sourceforge.net/p/jump-pilot/code/5976/ > >> > >> > >> > >> -Jukka- > >> > >> > >> > >> *Lähettäjä:* Rahkonen Jukka (MML) > >> *Lähetetty:* keskiviikko 12. helmikuuta 2020 0.14 > >> *Vastaanottaja:* jump-pilot-devel@lists.sourceforge.net > >> *Aihe:* [JPP-Devel] Deprecation with GeoPackage and spatial index > >> > >> > >> > >> Hi, > >> > >> > >> > >> I noticed that there has happened some deprecation with GeoPackages > since > >> released OpenJUMP 1.12. Version 1.12 detects and utilizes the spatial > index > >> of a table which makes it very fast to use even huge tables if map is > >> zoomed close enough. New snapshots do not utilize spatial index which > >> makes OJ very slow with large tables. I have not yet analyzed more > closely > >> when this change has happened. It seems that the layer list is sorted > >> differently now than in 1.12. Perhaps that change is related. > >> > >> > >> > >> I believe that the detection is done here > >> > https://sourceforge.net/p/jump-pilot/code/HEAD/tree/core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java#l151 > >> . > >> > >> > >> > >> -Jukka Rahkonen- > >> > > > > > > > > ___ > > Jump-pilot-devel mailing list > > Jump-pilot-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > > > > ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Deprecation with GeoPackage and spatial index
sounds good!.. ede On 12.02.2020 12:27, Nicolas Ribot wrote: > Hi, > > I'm currently looking at the problem, that also occur with spatialite > format. > I hope it will be fixed in few hours. > I'll keep you posted. > > Nicolas > > On Wed, 12 Feb 2020 at 11:53, wrote: > >> hey Nico, >> >> would you like me to hold the release for the fix or do you need more >> time? .. snappy new one btw. ede >> >> >> On 12.02.2020 10:57, Nicolas Ribot wrote: >>> Hi, >>> >>> I will have a look at it ! >>> >>> Nicolas >>> >>> On Wed, 12 Feb 2020 at 08:31, Rahkonen Jukka (MML) < >>> jukka.rahko...@maanmittauslaitos.fi> wrote: >>> Hi, It seems that loosing spatial index of GeoPackage tables is a side >> effect of this changeset that was otherwise a nice improvement https://sourceforge.net/p/jump-pilot/code/5976/ -Jukka- *Lähettäjä:* Rahkonen Jukka (MML) *Lähetetty:* keskiviikko 12. helmikuuta 2020 0.14 *Vastaanottaja:* jump-pilot-devel@lists.sourceforge.net *Aihe:* [JPP-Devel] Deprecation with GeoPackage and spatial index Hi, I noticed that there has happened some deprecation with GeoPackages >> since released OpenJUMP 1.12. Version 1.12 detects and utilizes the spatial >> index of a table which makes it very fast to use even huge tables if map is zoomed close enough. New snapshots do not utilize spatial index which makes OJ very slow with large tables. I have not yet analyzed more >> closely when this change has happened. It seems that the layer list is sorted differently now than in 1.12. Perhaps that change is related. I believe that the detection is done here >> https://sourceforge.net/p/jump-pilot/code/HEAD/tree/core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java#l151 . -Jukka Rahkonen- >>> >>> >>> >>> ___ >>> Jump-pilot-devel mailing list >>> Jump-pilot-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel >>> >> >> > ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] Deprecation with GeoPackage and spatial index
Hi You were right Jukka, when changing mechanism to retrieve all geometric layers information at once, I missed a step to set information whether a geometric column is indexed or not. GeometryColumn where built with a default value of False for isIndex attribute. I fixed the code and now spatial index is used, either for spatialite or geospatial package. Furthermore, another bug prevented the default spatial filter to be applied for spatialite datasources, leading to a full layer load even for a small view bounding box. (tested On a 800K polygons dataset: several seconds to load a small area with the bug, 25ms after correction and use of spatial index) Nicolas On Wed, 12 Feb 2020 at 13:20, wrote: > sounds good!.. ede > > On 12.02.2020 12:27, Nicolas Ribot wrote: > > Hi, > > > > I'm currently looking at the problem, that also occur with spatialite > > format. > > I hope it will be fixed in few hours. > > I'll keep you posted. > > > > Nicolas > > > > On Wed, 12 Feb 2020 at 11:53, wrote: > > > >> hey Nico, > >> > >> would you like me to hold the release for the fix or do you need more > >> time? .. snappy new one btw. ede > >> > >> > >> On 12.02.2020 10:57, Nicolas Ribot wrote: > >>> Hi, > >>> > >>> I will have a look at it ! > >>> > >>> Nicolas > >>> > >>> On Wed, 12 Feb 2020 at 08:31, Rahkonen Jukka (MML) < > >>> jukka.rahko...@maanmittauslaitos.fi> wrote: > >>> > Hi, > > > > It seems that loosing spatial index of GeoPackage tables is a side > >> effect > of this changeset that was otherwise a nice improvement > https://sourceforge.net/p/jump-pilot/code/5976/ > > > > -Jukka- > > > > *Lähettäjä:* Rahkonen Jukka (MML) < > jukka.rahko...@maanmittauslaitos.fi> > *Lähetetty:* keskiviikko 12. helmikuuta 2020 0.14 > *Vastaanottaja:* jump-pilot-devel@lists.sourceforge.net > *Aihe:* [JPP-Devel] Deprecation with GeoPackage and spatial index > > > > Hi, > > > > I noticed that there has happened some deprecation with GeoPackages > >> since > released OpenJUMP 1.12. Version 1.12 detects and utilizes the spatial > >> index > of a table which makes it very fast to use even huge tables if map is > zoomed close enough. New snapshots do not utilize spatial index which > makes OJ very slow with large tables. I have not yet analyzed more > >> closely > when this change has happened. It seems that the layer list is sorted > differently now than in 1.12. Perhaps that change is related. > > > > I believe that the detection is done here > > >> > https://sourceforge.net/p/jump-pilot/code/HEAD/tree/core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java#l151 > . > > > > -Jukka Rahkonen- > > >>> > >>> > >>> > >>> ___ > >>> Jump-pilot-devel mailing list > >>> Jump-pilot-devel@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > >>> > >> > >> > > > > > > ___ > Jump-pilot-devel mailing list > Jump-pilot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel > ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] SVN: [6237] core/trunk
Revision: 6237
http://sourceforge.net/p/jump-pilot/code/6237
Author: elnico
Date: 2020-02-12 14:16:26 + (Wed, 12 Feb 2020)
Log Message:
---
fix bug in Spatialite datasources management, where spatial index query was not
built even if a spatial index was defined on the geometric column.
Also removed debug comments preventing spatialite to be detected
Modified Paths:
--
core/trunk/ChangeLog
core/trunk/src/com/vividsolutions/jump/datastore/GeometryColumn.java
core/trunk/src/com/vividsolutions/jump/datastore/spatialdatabases/SpatialDatabasesDSMetadata.java
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteSQLBuilder.java
Modified: core/trunk/ChangeLog
===
--- core/trunk/ChangeLog2020-02-11 10:23:54 UTC (rev 6236)
+++ core/trunk/ChangeLog2020-02-12 14:16:26 UTC (rev 6237)
@@ -5,6 +5,10 @@
* Changes.txt updated until here **
+2020-02-12 Nicolas Ribot
+ * fix bug in Spatialite datasources management, where spatial index query
was not built
+even if a spatial index was defined on the geometric column
+
2020-01-26 mmichaud
* FR#265 : add a plugin to make line from ordered points
* fix bug in MakeValidOp
Modified: core/trunk/src/com/vividsolutions/jump/datastore/GeometryColumn.java
===
--- core/trunk/src/com/vividsolutions/jump/datastore/GeometryColumn.java
2020-02-11 10:23:54 UTC (rev 6236)
+++ core/trunk/src/com/vividsolutions/jump/datastore/GeometryColumn.java
2020-02-12 14:16:26 UTC (rev 6237)
@@ -8,7 +8,7 @@
private String name;
private int srid = 0;
private String type = "Geometry";
-private boolean indexed = false;
+private Boolean indexed = null;
private int coordDimension = 2;
public GeometryColumn(String name) {
@@ -90,11 +90,11 @@
", srid=" + srid + ")";
}
-public boolean isIndexed() {
+public Boolean isIndexed() {
return indexed;
}
-public void setIndexed(boolean indexed) {
+public void setIndexed(Boolean indexed) {
this.indexed = indexed;
}
}
Modified:
core/trunk/src/com/vividsolutions/jump/datastore/spatialdatabases/SpatialDatabasesDSMetadata.java
===
---
core/trunk/src/com/vividsolutions/jump/datastore/spatialdatabases/SpatialDatabasesDSMetadata.java
2020-02-11 10:23:54 UTC (rev 6236)
+++
core/trunk/src/com/vividsolutions/jump/datastore/spatialdatabases/SpatialDatabasesDSMetadata.java
2020-02-12 14:16:26 UTC (rev 6237)
@@ -279,7 +279,9 @@
if (! datasetNames.contains(table)) {
datasetNames.add(table);
}
-// datastoreLayers
+// datastoreLayers:
+// 2020-02-12: caution here; geometryColumn is built without
index info
+// this info is retrieved as necessary by specialized classes
GeometryColumn geo = new GeometryColumn(
resultSet.getString(3),
resultSet.getInt(4),
Modified:
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
===
---
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
2020-02-11 10:23:54 UTC (rev 6236)
+++
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
2020-02-12 14:16:26 UTC (rev 6237)
@@ -189,6 +189,7 @@
* Overriden to deal with indexed geo columns, as queries to get features
are different
* if spatial index is detected on the column.
* Buids a GeometryColumn object with 5 params ctor.
+ * TODO: no more used now all layers info are retrieved at once ? refactor
* @param sql
* @param datasetName
* @return
@@ -290,17 +291,17 @@
// tries to load spatialite, assuming it is available on the system's path
Statement stmt = null;
try {
-// stmt = conn.getJdbcConnection().createStatement();
-// stmt.executeUpdate("SELECT load_extension('mod_spatialite')");
-// // ex is thrown if extension cannot be loaded
-// this.spatialiteLoaded = true;
-// ResultSet rs = stmt.executeQuery("select spatialite_version()");
-// rs.next();
-// this.setSpatialiteVersion(rs.getString(1));
-//
-// JUMPWorkbench.getInstance().getFrame().log(
-// "SpatialDatabasesPlugin: Spatialite extension loaded for this
connexion, version: "
-// + this.getSpatialiteVersion(), this.getClass());
+ stmt = conn.getJdbcConnection().createStatement();
+ stmt.executeUpdate("SELECT load_extension
[JPP-Devel] SVN: [6238] core/trunk
Revision: 6238
http://sourceforge.net/p/jump-pilot/code/6238
Author: elnico
Date: 2020-02-12 14:23:33 + (Wed, 12 Feb 2020)
Log Message:
---
Removed debug left at previous commit
Modified Paths:
--
core/trunk/ChangeLog
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
Modified: core/trunk/ChangeLog
===
--- core/trunk/ChangeLog2020-02-12 14:16:26 UTC (rev 6237)
+++ core/trunk/ChangeLog2020-02-12 14:23:33 UTC (rev 6238)
@@ -6,6 +6,9 @@
* Changes.txt updated until here **
2020-02-12 Nicolas Ribot
+ * remove debug info left at previous commit
+
+2020-02-12 Nicolas Ribot
* fix bug in Spatialite datasources management, where spatial index query
was not built
even if a spatial index was defined on the geometric column
Modified:
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
===
---
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
2020-02-12 14:16:26 UTC (rev 6237)
+++
core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
2020-02-12 14:23:33 UTC (rev 6238)
@@ -448,7 +448,7 @@
public boolean isSpatialiteLoaded() {
// TODO: clean up type detection: geopackage vs spatialite
-return spatialiteLoaded || this.geometryColumnsLayout ==
GeometryColumnsLayout.OGC_GEOPACKAGE_LAYOUT;
+return spatialiteLoaded;
}
public String getSpatialiteVersion() {
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [6238] core/trunk
Jukka, can you test please?.. ede
On 12.02.2020 15:23, jump-pilot-svn--- via Jump-pilot-devel wrote:
> Revision: 6238
> http://sourceforge.net/p/jump-pilot/code/6238
> Author: elnico
> Date: 2020-02-12 14:23:33 + (Wed, 12 Feb 2020)
> Log Message:
> ---
> Removed debug left at previous commit
>
> Modified Paths:
> --
> core/trunk/ChangeLog
>
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
>
> Modified: core/trunk/ChangeLog
> ===
> --- core/trunk/ChangeLog 2020-02-12 14:16:26 UTC (rev 6237)
> +++ core/trunk/ChangeLog 2020-02-12 14:23:33 UTC (rev 6238)
> @@ -6,6 +6,9 @@
> * Changes.txt updated until here
> **
>
> 2020-02-12 Nicolas Ribot
> + * remove debug info left at previous commit
> +
> +2020-02-12 Nicolas Ribot
>* fix bug in Spatialite datasources management, where spatial index query
> was not built
> even if a spatial index was defined on the geometric column
>
>
> Modified:
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
> ===
> ---
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
> 2020-02-12 14:16:26 UTC (rev 6237)
> +++
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
> 2020-02-12 14:23:33 UTC (rev 6238)
> @@ -448,7 +448,7 @@
>
>public boolean isSpatialiteLoaded() {
> // TODO: clean up type detection: geopackage vs spatialite
> -return spatialiteLoaded || this.geometryColumnsLayout ==
> GeometryColumnsLayout.OGC_GEOPACKAGE_LAYOUT;
> +return spatialiteLoaded;
>}
>
>public String getSpatialiteVersion() {
>
>
>
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [6237] core/trunk
Nico, please add your changes above the "updated until here" line next time. it's for me to know if there were changes after me transfering changes over to Changes.txt while preparing the release ;) thanks! ..ede On 12.02.2020 15:16, jump-pilot-svn--- via Jump-pilot-devel wrote: > Modified: core/trunk/ChangeLog > === > --- core/trunk/ChangeLog 2020-02-11 10:23:54 UTC (rev 6236) > +++ core/trunk/ChangeLog 2020-02-12 14:16:26 UTC (rev 6237) > @@ -5,6 +5,10 @@ > > * Changes.txt updated until here > ** > > +2020-02-12 Nicolas Ribot > + * fix bug in Spatialite datasources management, where spatial index query > was not built > +even if a spatial index was defined on the geometric column > + > 2020-01-26 mmichaud >* FR#265 : add a plugin to make line from ordered points >* fix bug in MakeValidOp ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
[JPP-Devel] SVN: [6239] core/trunk/ChangeLog
Revision: 6239 http://sourceforge.net/p/jump-pilot/code/6239 Author: elnico Date: 2020-02-12 14:36:21 + (Wed, 12 Feb 2020) Log Message: --- reordered changelog notes Modified Paths: -- core/trunk/ChangeLog Modified: core/trunk/ChangeLog === --- core/trunk/ChangeLog2020-02-12 14:23:33 UTC (rev 6238) +++ core/trunk/ChangeLog2020-02-12 14:36:21 UTC (rev 6239) @@ -3,8 +3,6 @@ # 2. make sure that lines break at 80 chars for constricted display situations #< 80 chars --># -* Changes.txt updated until here ** - 2020-02-12 Nicolas Ribot * remove debug info left at previous commit @@ -12,6 +10,8 @@ * fix bug in Spatialite datasources management, where spatial index query was not built even if a spatial index was defined on the geometric column +* Changes.txt updated until here ** + 2020-01-26 mmichaud * FR#265 : add a plugin to make line from ordered points * fix bug in MakeValidOp ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [6237] core/trunk
On Wed, 12 Feb 2020 at 15:32, wrote: > Nico, > > please add your changes above the "updated until here" line next time. > it's for me to know if there were changes after me transfering changes over > to Changes.txt while preparing the release ;) > > thanks! ..ede > > Sorry, I didn't notice the line. Done Nico ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [6237] core/trunk
On 12.02.2020 15:36, Nicolas Ribot wrote: > On Wed, 12 Feb 2020 at 15:32, wrote: > >> Nico, >> >> please add your changes above the "updated until here" line next time. >> it's for me to know if there were changes after me transfering changes over >> to Changes.txt while preparing the release ;) >> >> thanks! ..ede >> >> > Sorry, I didn't notice the line. Done > Nico haha.. no biggie, could have done it myself this time.. thanks again :).. ede ___ Jump-pilot-devel mailing list Jump-pilot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
Re: [JPP-Devel] SVN: [6238] core/trunk
Hi,
The fix seems to be good, thank you!
I have been thinking sometimes that perhaps it would be better to open SQLite
databases (SpatiaLite and GeoPackage) as read only. It could prevent some
locking issues and OpenJUMP does not really need read/write access. It is
actually possible to update the database by using the Run database query but
that is probably something that average OpenJUMP users do not even know.
However, I have utilized that possibility at least for updating attributes and
deleting rows from a table.
Nicolas, do you have any opinion about read-only vs. read-write access?
-Jukka-
-Alkuperäinen viesti-
Lähettäjä: edgar.sol...@web.de
Lähetetty: keskiviikko 12. helmikuuta 2020 16.29
Vastaanottaja: jump-pilot-devel@lists.sourceforge.net
Aihe: Re: [JPP-Devel] SVN: [6238] core/trunk
Jukka, can you test please?.. ede
On 12.02.2020 15:23, jump-pilot-svn--- via Jump-pilot-devel wrote:
> Revision: 6238
> http://sourceforge.net/p/jump-pilot/code/6238
> Author: elnico
> Date: 2020-02-12 14:23:33 + (Wed, 12 Feb 2020)
> Log Message:
> ---
> Removed debug left at previous commit
>
> Modified Paths:
> --
> core/trunk/ChangeLog
>
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/Spatialite
> DSMetadata.java
>
> Modified: core/trunk/ChangeLog
> ===
> --- core/trunk/ChangeLog 2020-02-12 14:16:26 UTC (rev 6237)
> +++ core/trunk/ChangeLog 2020-02-12 14:23:33 UTC (rev 6238)
> @@ -6,6 +6,9 @@
> * Changes.txt updated until here
> **
>
> 2020-02-12 Nicolas Ribot
> + * remove debug info left at previous commit
> +
> +2020-02-12 Nicolas Ribot
>* fix bug in Spatialite datasources management, where spatial index query
> was not built
> even if a spatial index was defined on the geometric column
>
>
> Modified:
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/Spatialite
> DSMetadata.java
> ===
> ---
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
> 2020-02-12 14:16:26 UTC (rev 6237)
> +++
> core/trunk/src/com/vividsolutions/jump/datastore/spatialite/SpatialiteDSMetadata.java
> 2020-02-12 14:23:33 UTC (rev 6238)
> @@ -448,7 +448,7 @@
>
>public boolean isSpatialiteLoaded() {
> // TODO: clean up type detection: geopackage vs spatialite
> -return spatialiteLoaded || this.geometryColumnsLayout ==
> GeometryColumnsLayout.OGC_GEOPACKAGE_LAYOUT;
> +return spatialiteLoaded;
>}
>
>public String getSpatialiteVersion() {
>
>
>
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
