Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1984121100
##
solr/core/src/test/org/apache/solr/search/TestReRankQParserPlugin.java:
##
@@ -64,6 +64,80 @@ public void testReRankQParserPluginConstants() {
assertEquals(ReRankQParserPlugin.RERANK_OPERATOR, "reRankOperator");
}
+ @Test
+ public void testRerankReturnOriginalScore() throws Exception {
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")
[
https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aviral Sinha updated SOLR-17691:
Attachment: Solr8.4SourceCompilationError.txt
> Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string:
> 'null'")
> -
>
> Key: SOLR-17691
> URL: https://issues.apache.org/jira/browse/SOLR-17691
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.4
> Environment: UAT/PROD
>Reporter: Aviral Sinha
>Priority: Critical
> Labels: patch
> Attachments: Solr8.4SourceCompilationError.txt, solrError.jpeg
>
>
> We are currently using {*}Sitecore 10 CMS{*}, which only supports {*}Solr
> 8.4{*}. Previously, we were using {*}ZooKeeper 3.4.14{*}, but since it has
> reached End of Life (EOL), we have upgraded to {*}ZooKeeper 3.8.4{*}.
> After upgrading and configuring Solr to point to the ZooKeeper host
> ({{{}zk_host{}}}), we are encountering an error on the {*}Solr Admin Page →
> ZooKeeper Status{*}:
> *"For input string: 'null'"*
> Please find the attached screenshot for reference.
> We noticed that this issue has already been addressed in later Solr versions,
> as referenced in the following JIRA cases:
> * SOLR-14463
> * SOLR-14669
> Since {*}our Sitecore application depends on Solr 8.4{*}, we are unable to
> upgrade to a higher Solr version. We kindly request you to provide a patch
> for Solr 8.4 to resolve this issue.
> Looking forward to your response.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")
[
https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933186#comment-17933186
]
Aviral Sinha commented on SOLR-17691:
-
Hi Jan,
Thanks for your response.
I checked out the Sitecore 8.4 solution from the release tag *8.4* and compiled
the code, but I encountered an error. Please find the attached error details.
Could you advise if there's a workaround for this issue, or would applying the
fix from the mentioned issues to the *branch_8_4* source and building a custom
release be the only viable option?
Looking forward to your guidance.
Best regards,
> Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string:
> 'null'")
> -
>
> Key: SOLR-17691
> URL: https://issues.apache.org/jira/browse/SOLR-17691
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.4
> Environment: UAT/PROD
>Reporter: Aviral Sinha
>Priority: Critical
> Labels: patch
> Attachments: Solr8.4SourceCompilationError.txt, solrError.jpeg
>
>
> We are currently using {*}Sitecore 10 CMS{*}, which only supports {*}Solr
> 8.4{*}. Previously, we were using {*}ZooKeeper 3.4.14{*}, but since it has
> reached End of Life (EOL), we have upgraded to {*}ZooKeeper 3.8.4{*}.
> After upgrading and configuring Solr to point to the ZooKeeper host
> ({{{}zk_host{}}}), we are encountering an error on the {*}Solr Admin Page →
> ZooKeeper Status{*}:
> *"For input string: 'null'"*
> Please find the attached screenshot for reference.
> We noticed that this issue has already been addressed in later Solr versions,
> as referenced in the following JIRA cases:
> * SOLR-14463
> * SOLR-14669
> Since {*}our Sitecore application depends on Solr 8.4{*}, we are unable to
> upgrade to a higher Solr version. We kindly request you to provide a patch
> for Solr 8.4 to resolve this issue.
> Looking forward to your response.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")
[
https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933186#comment-17933186
]
Aviral Sinha edited comment on SOLR-17691 at 3/7/25 3:16 AM:
-
Hi Jan,
Thanks for your response.
I checked out the Solr 8.4 solution from the release tag *8.4* and compiled the
code, but I encountered an error. Please find the attached error details.
Could you advise if there's a workaround for this issue, or would applying the
fix from the mentioned issues to the *branch_8_4* source and building a custom
release be the only viable option?
Looking forward to your guidance.
Best regards,
was (Author: JIRAUSER308915):
Hi Jan,
Thanks for your response.
I checked out the Sitecore 8.4 solution from the release tag *8.4* and compiled
the code, but I encountered an error. Please find the attached error details.
Could you advise if there's a workaround for this issue, or would applying the
fix from the mentioned issues to the *branch_8_4* source and building a custom
release be the only viable option?
Looking forward to your guidance.
Best regards,
> Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string:
> 'null'")
> -
>
> Key: SOLR-17691
> URL: https://issues.apache.org/jira/browse/SOLR-17691
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.4
> Environment: UAT/PROD
>Reporter: Aviral Sinha
>Priority: Critical
> Labels: patch
> Attachments: Solr8.4SourceCompilationError.txt, solrError.jpeg
>
>
> We are currently using {*}Sitecore 10 CMS{*}, which only supports {*}Solr
> 8.4{*}. Previously, we were using {*}ZooKeeper 3.4.14{*}, but since it has
> reached End of Life (EOL), we have upgraded to {*}ZooKeeper 3.8.4{*}.
> After upgrading and configuring Solr to point to the ZooKeeper host
> ({{{}zk_host{}}}), we are encountering an error on the {*}Solr Admin Page →
> ZooKeeper Status{*}:
> *"For input string: 'null'"*
> Please find the attached screenshot for reference.
> We noticed that this issue has already been addressed in later Solr versions,
> as referenced in the following JIRA cases:
> * SOLR-14463
> * SOLR-14669
> Since {*}our Sitecore application depends on Solr 8.4{*}, we are unable to
> upgrade to a higher Solr version. We kindly request you to provide a patch
> for Solr 8.4 to resolve this issue.
> Looking forward to your response.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17632) Text to Vector Update Request Processor
[ https://issues.apache.org/jira/browse/SOLR-17632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932909#comment-17932909 ] Renato Haeberli commented on SOLR-17632: [~abenedetti] I think it would make sense to add the label https://issues.apache.org/jira/browse/SOLR-17679?jql=labels%20%3D%20vector-based-search to this ticket, it took me a while to find it. Thanks. > Text to Vector Update Request Processor > --- > > Key: SOLR-17632 > URL: https://issues.apache.org/jira/browse/SOLR-17632 > Project: Solr > Issue Type: New Feature > Components: UpdateRequestProcessors >Reporter: Alessandro Benedetti >Assignee: Alessandro Benedetti >Priority: Major > Labels: pull-request-available > Time Spent: 5h 50m > Remaining Estimate: 0h > > Scope of this issue is to introduce support for automatic text vectorisation > in Apache Solr, directly in a update request processor. > A LLM fine-tuned for sentence similarity will be accessed to embed the text. > Apache Solr will host the configuration parameters to access embedding > services and the update request processor will use such services to directly > encode the document field as a vector. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982990193
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the ZooKeeper connection string from either the zk-host command-line
option or if not
+ * configured, from the 'zkHost' system property aka the 'ZK_HOST'
environment variable.
+ *
+ * @param cli the command line
+ * @return the ZooKeeper connection string or null if not configured
+ */
+ public static String getZkHostFromCliOrEnv(CommandLine cli) {
Review Comment:
I had another look at the CommonCLIOptions. You are correct that the
[SOLR_URL_OPTION](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/CommonCLIOptions.java#L43)
documents that it defaults to an URL defined by a set of sysProps. But not all
tools do fallback in the same way, e.g. CreateTool looks up a live node in zk
instead.
The
[ZK_HOST_OPTION](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/CommonCLIOptions.java#L32-L41)
main help text says it defaults to `localhost:9983` but many tools uses
`getZkHost()` which queries solr to find zkHost, but with this change consults
ZK_HOST first, which is really not documented in help docs.
In my mind, this change brings tools in line with ZK_HOST_OPTION help docs
"Zookeeper connection string; unnecessary if ZK_HOST is defined in
solr.in.sh;", but the last part "otherwise, defaults to localhost:9983" is
still largely wrong since we actually try to look it up from Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982990193
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +216,29 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the ZooKeeper connection string from either the zk-host command-line
option or if not
+ * configured, from the 'zkHost' system property aka the 'ZK_HOST'
environment variable.
+ *
+ * @param cli the command line
+ * @return the ZooKeeper connection string or null if not configured
+ */
+ public static String getZkHostFromCliOrEnv(CommandLine cli) {
Review Comment:
I had another look at the CommonCLIOptions. You are correct that the
[SOLR_URL_OPTION](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/CommonCLIOptions.java#L43)
documents that it defaults to an URL defined by a set of sysProps. But not all
tools do fallback in the same way, e.g. CreateTool looks up a live node in zk
instead.
The
[ZK_HOST_OPTION](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cli/CommonCLIOptions.java#L32-L41)
main help text says it defaults to `localhost:9983` but many tools uses
`getZkHost()` which queries solr to find zkHost, but that is really not
documented in help docs.
This PR brings tools in line with ZK_HOST_OPTION help docs
> "Zookeeper connection string; unnecessary if ZK_HOST is defined in
solr.in.sh;
But the last part
>"otherwise, defaults to localhost:9983"
is still largely wrong for many tools, since we actually try to look it up
via Solr APIs. We could change that help text to align with reality but I have
not surveyed every single use, have not seen what refGuide says etc, so let it
be for a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17655: Remove ExternalFileField [solr]
epugh opened a new pull request, #3244: URL: https://github.com/apache/solr/pull/3244 https://issues.apache.org/jira/browse/SOLR-17655 # Description ExternalFileField is deprecated, remove it. # Solution Remove deprecated Field Type. # Tests Existing tests # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17438 Resolve committer GPG key from other source [solr]
madrob commented on PR #3145: URL: https://github.com/apache/solr/pull/3145#issuecomment-2703782935 I linked to a an infra issue on JIRA, it looks like there hasn't been any work yet. I may have been too optimistic about software development timelines, we may as well finish this now and then move again _eventually_, rather than waiting indefinitely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1983473324
##
solr/core/src/java/org/apache/solr/search/DocIterator.java:
##
@@ -43,4 +43,13 @@ public interface DocIterator extends Iterator {
* instance was retrieved.
*/
public float score();
+
+ /**
+ * Returns the query match score in case of rerank queries
+ *
+ * @return the query match score in case of a rerank query, null otherwise.
+ */
+ public default Float matchScore() {
+return null;
+ }
Review Comment:
Much like `score()` we might want to keep this as a `float` and return 0.
Not really leaning either way on this yet.
##
solr/core/src/java/org/apache/solr/search/DocSlice.java:
##
Review Comment:
For this, would it make more sense to have another implementation of
DocSlice for a TopDocs? It looks like every method has an if statement in it.
Might be more efficient to go with two implementations.
##
solr/solr-ref-guide/modules/query-guide/pages/query-re-ranking.adoc:
##
@@ -107,6 +107,9 @@ q=greetings&rq={!rerank reRankQuery=$rqq reRankDocs=1000
reRankWeight=3}&rqq=(hi
If a document matches the original query, but does not match the re-ranking
query, the document's original score will remain.
+For reranked documents, an additional _matchScore_ field in the response will
indicate the original score for a reranked doc. This
+is the score for the document prior to rerank being applied. For documents
that were not reranked, the matchScore and score fields
+will have the same value.
Review Comment:
```suggestion
For reranked documents, an additional `matchScore` field in the response
will indicate the original score for a reranked doc. This
is the score for the document prior to rerank being applied. For documents
that were not reranked, the matchScore and score fields
will have the same value. For the example above, you would use the following
to return the match score:
[source,text]
q=greetings&rq={!rerank reRankQuery=$rqq reRankDocs=1000
reRankWeight=3}&rqq=(hi+hello+hey+hiya)&fl=id,matchScore
```
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
Review Comment:
This in general looks fine to me, but I am not an expert here and would love
another set of eyes.
##
solr/core/src/java/org/apache/solr/search/ReRankCollector.java:
##
@@ -205,18 +205,29 @@ public TopDocs topDocs(int start, int howMany) {
ScoreDoc[] scoreDocs = new ScoreDoc[howMany];
System.arraycopy(rescoredDocs.scoreDocs, 0, scoreDocs, 0, howMany);
rescoredDocs.scoreDocs = scoreDocs;
-return rescoredDocs;
}
+ return toRescoredDocs(rescoredDocs, docToOriginalScore);
Review Comment:
Don't we only want to do this if the user has asked for it?
##
solr/core/src/test/org/apache/solr/search/TestReRankQParserPlugin.java:
##
@@ -64,6 +64,80 @@ public void testReRankQParserPluginConstants() {
assertEquals(ReRankQParserPlugin.RERANK_OPERATOR, "reRankOperator");
}
+ @Test
+ public void testRerankReturnOriginalScore() throws Exception {
Review Comment:
This should be MatchScore not OriginalScore, right?
Also can we test returning the MatchScore for a non-reranked query? You
mentioned that in the ref-guide update.
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -194,7 +193,6 @@ public class SolrIndexSearcher extends IndexSearcher
implements Closeable, SolrI
private final StatsCache statsCache;
- private Set metricNames = ConcurrentHashMap.newKeySet();
Review Comment:
Also this?
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -183,7 +182,7 @@ public class SolrIndexSearcher extends IndexSearcher
implements Closeable, SolrI
@SuppressWarnings({"rawtypes"})
private final SolrCache[] cacheList;
- private DirectoryFactory directoryFactory;
+ private final DirectoryFactory directoryFactory;
Review Comment:
Why did you change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
epugh commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1983432038
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the value of the specified CLI option with fallback to system
property and default value.
+ *
+ * @param cli the command line
+ * @param option the commons cli {@link Option}
+ * @param sysprop the system property to fall back to
+ * @param defaultValue the default value. Use null if no default value is
desired
+ * @return the value of the option or system property or the default value
+ */
+ public static String getCliOptionOrPropValue(
+ CommandLine cli, Option option, String sysprop, String defaultValue) {
+String value = cli.getOptionValue(option);
Review Comment:
I think doing the same for SOLR_URL makes sense. It could be another PR,
but it could also be in this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17655) Deprecate ExternalFileField in lieu of in-place docValue updates
[ https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17655: -- Labels: pull-request-available (was: ) > Deprecate ExternalFileField in lieu of in-place docValue updates > > > Key: SOLR-17655 > URL: https://issues.apache.org/jira/browse/SOLR-17655 > Project: Solr > Issue Type: Task >Reporter: David Smiley >Priority: Blocker > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 10m > Remaining Estimate: 0h > > ExternalFileField is an old capability of Solr that pre-dated in-place > partial updates of numeric DocValue fields. There are [some issues with > it|https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR%20AND%20text%20~%20%22FileFloatSource%22%20AND%20resolution%20is%20null%20ORDER%20BY%20created%20DESC], > and it has code to be maintained. It's time to deprecate it in 9.9 so it > can be removed in 10. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17684: SolrJ Reference Guide (Ping) - Incorrect Status Retrieval [solr]
umut-sar commented on PR #3237: URL: https://github.com/apache/solr/pull/3237#issuecomment-2703195348 @epugh Thanks! I appreciate the guidance and the opportunity to improve the solution. Always happy to contribute! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982953396
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the value of the specified CLI option with fallback to system
property and default value.
+ *
+ * @param cli the command line
+ * @param option the commons cli {@link Option}
+ * @param sysprop the system property to fall back to
+ * @param defaultValue the default value. Use null if no default value is
desired
+ * @return the value of the option or system property or the default value
+ */
+ public static String getCliOptionOrPropValue(
+ CommandLine cli, Option option, String sysprop, String defaultValue) {
+String value = cli.getOptionValue(option);
Review Comment:
@epugh In my last commit I generalized the util method to this
getCliOptionOrPropValue which can be used by any Tool that wishes to read a CLI
OPTION with a fallback to env/prop and also a fallback to defaultvalue.
Currently I only use it for zkhost. IMO the calling code also becomes more
clear, as you will see in the same line both the OPT name and the prop name.
Perhaps this could be used also for SOLR_URL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982951185
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the value of the specified CLI option with fallback to system
property and default value.
+ *
+ * @param cli the command line
+ * @param option the commons cli {@link Option}
+ * @param sysprop the system property to fall back to
+ * @param defaultValue the default value. Use null if no default value is
desired
+ * @return the value of the option or system property or the default value
+ */
+ public static String getCliOptionOrPropValue(
+ CommandLine cli, Option option, String sysprop, String defaultValue) {
+String value = cli.getOptionValue(option);
+if (value == null) {
+ value = EnvUtils.getProperty(sysprop, defaultValue);
+}
+return value;
+ }
Review Comment:
@epugh In my last commit I generalized the util method to this
`getCliOptionOrPropValue` which can be used by any Tool that wishes to read a
CLI OPTION with a fallback to env/prop and also a fallback to defaultvalue.
Currently I only use it for zkhost. IMO the calling code also becomes more
clear, as you will see in the same line both the OPT name and the prop name.
Perhaps this could be used also for SOLR_URL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17690 Make solr zk tools read ZK_HOST environment [solr]
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1982951185
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -216,12 +217,32 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
}
/**
- * Get the ZooKeeper connection string from either the zk-host command-line
option or by looking
- * it up from a running Solr instance based on the solr-url option.
+ * Get the value of the specified CLI option with fallback to system
property and default value.
+ *
+ * @param cli the command line
+ * @param option the commons cli {@link Option}
+ * @param sysprop the system property to fall back to
+ * @param defaultValue the default value. Use null if no default value is
desired
+ * @return the value of the option or system property or the default value
+ */
+ public static String getCliOptionOrPropValue(
+ CommandLine cli, Option option, String sysprop, String defaultValue) {
+String value = cli.getOptionValue(option);
+if (value == null) {
+ value = EnvUtils.getProperty(sysprop, defaultValue);
+}
+return value;
+ }
Review Comment:
@epugh In my last commit I generalized the util method to this
`getCliOptionOrPropValue` which can be used by any Tool that wishes to read a
CLI OPTION with a fallback to env/prop and also a fallback to defaultvalue.
Currently I only use it for zkhost. IMO the calling code also becomes more
clear, as you will see in the same line both the OPT name and the prop name.
Perhaps this could be used also for SOLR_URL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17690) Solr CLI tools like zk cp does not read ZK_HOST
[
https://issues.apache.org/jira/browse/SOLR-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17690:
---
Fix Version/s: (was: 9.8.1)
> Solr CLI tools like zk cp does not read ZK_HOST
> ---
>
> Key: SOLR-17690
> URL: https://issues.apache.org/jira/browse/SOLR-17690
> Project: Solr
> Issue Type: Bug
> Components: cli, scripts and tools
>Affects Versions: 9.8.0
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Major
> Labels: pull-request-available
> Fix For: 9.9
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> As reported in solr operator issue
> [https://github.com/apache/solr-operator/issues/762] there is a regression in
> solr-operator 0.9 which uses {{solr zk cp}} instead of {{{}zkCli.sh{}}}, so
> that when using a combo of operator 0.9 and Solr 9.8.0, the script will fail
> due to not picking up {{ZK_HOST}} env.var.
> Older solr-operator used {{zkCli.sh}} which read the env.var but had other
> issues. Pre 9.8 versions of Solr parsed "solr zk cp" command in bash instead
> of Java and thus works.
> The solution is to enable CLI tools to get ZK_HOST from environment if
> {{--zk-host}} is not passed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")
Aviral Sinha created SOLR-17691:
---
Summary: Request for Patch for Solr 8.4 - Zookeeper Status Error
("For input string: 'null'")
Key: SOLR-17691
URL: https://issues.apache.org/jira/browse/SOLR-17691
Project: Solr
Issue Type: Bug
Affects Versions: 8.4
Environment: UAT/PROD
Reporter: Aviral Sinha
Attachments: solrError.jpeg
We are currently using {*}Sitecore 10 CMS{*}, which only supports {*}Solr
8.4{*}. Previously, we were using {*}ZooKeeper 3.4.14{*}, but since it has
reached End of Life (EOL), we have upgraded to {*}ZooKeeper 3.8.4{*}.
After upgrading and configuring Solr to point to the ZooKeeper host
({{{}zk_host{}}}), we are encountering an error on the {*}Solr Admin Page →
ZooKeeper Status{*}:
*"For input string: 'null'"*
Please find the attached screenshot for reference.
We noticed that this issue has already been addressed in later Solr versions,
as referenced in the following JIRA cases:
* SOLR-14463
* SOLR-14669
Since {*}our Sitecore application depends on Solr 8.4{*}, we are unable to
upgrade to a higher Solr version. We kindly request you to provide a patch for
Solr 8.4 to resolve this issue.
Looking forward to your response.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
sijuv commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r1984120901 ## solr/core/src/java/org/apache/solr/search/DocSlice.java: ## Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1984122502
##
solr/solr-ref-guide/modules/query-guide/pages/query-re-ranking.adoc:
##
@@ -107,6 +107,9 @@ q=greetings&rq={!rerank reRankQuery=$rqq reRankDocs=1000
reRankWeight=3}&rqq=(hi
If a document matches the original query, but does not match the re-ranking
query, the document's original score will remain.
+For reranked documents, an additional _matchScore_ field in the response will
indicate the original score for a reranked doc. This
+is the score for the document prior to rerank being applied. For documents
that were not reranked, the matchScore and score fields
+will have the same value.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17691) Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string: 'null'")
[
https://issues.apache.org/jira/browse/SOLR-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17691.
Resolution: Information Provided
Hi,
As Solr 8.4 is end of life and not recommended there will not be any updates
from the project.
The primary recommendation for you is to try out Solr 8.11.x, which is
[supported by Sitecore
10.4|https://support.sitecore.com/kb?id=kb_article_view&sysparm_article=KB0227897].
But note that even Solr 8.11 is EOL, but less out of date than 8.4. Note that
Solr 8.11 may also work with older sitecore since all 8.x are basically
compatible.
If that does not work for you, you can apply the fix from the issues you linked
to the source code of solr (git branch branch_8_4) and build your own release
of solr which you can use. If you do not know how to do that you can lookup
"Support" section of our web site and find individuals and companies who can
assist with such custom development.
> Request for Patch for Solr 8.4 - Zookeeper Status Error ("For input string:
> 'null'")
> -
>
> Key: SOLR-17691
> URL: https://issues.apache.org/jira/browse/SOLR-17691
> Project: Solr
> Issue Type: Bug
>Affects Versions: 8.4
> Environment: UAT/PROD
>Reporter: Aviral Sinha
>Priority: Critical
> Labels: patch
> Attachments: solrError.jpeg
>
>
> We are currently using {*}Sitecore 10 CMS{*}, which only supports {*}Solr
> 8.4{*}. Previously, we were using {*}ZooKeeper 3.4.14{*}, but since it has
> reached End of Life (EOL), we have upgraded to {*}ZooKeeper 3.8.4{*}.
> After upgrading and configuring Solr to point to the ZooKeeper host
> ({{{}zk_host{}}}), we are encountering an error on the {*}Solr Admin Page →
> ZooKeeper Status{*}:
> *"For input string: 'null'"*
> Please find the attached screenshot for reference.
> We noticed that this issue has already been addressed in later Solr versions,
> as referenced in the following JIRA cases:
> * SOLR-14463
> * SOLR-14669
> Since {*}our Sitecore application depends on Solr 8.4{*}, we are unable to
> upgrade to a higher Solr version. We kindly request you to provide a patch
> for Solr 8.4 to resolve this issue.
> Looking forward to your response.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1984125791
##
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##
@@ -183,7 +182,7 @@ public class SolrIndexSearcher extends IndexSearcher
implements Closeable, SolrI
@SuppressWarnings({"rawtypes"})
private final SolrCache[] cacheList;
- private DirectoryFactory directoryFactory;
+ private final DirectoryFactory directoryFactory;
Review Comment:
this variable cold be final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17655) Deprecate ExternalFileField in lieu of in-place docValue updates
[ https://issues.apache.org/jira/browse/SOLR-17655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17655: Assignee: Eric Pugh > Deprecate ExternalFileField in lieu of in-place docValue updates > > > Key: SOLR-17655 > URL: https://issues.apache.org/jira/browse/SOLR-17655 > Project: Solr > Issue Type: Task >Reporter: David Smiley >Assignee: Eric Pugh >Priority: Blocker > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 10m > Remaining Estimate: 0h > > ExternalFileField is an old capability of Solr that pre-dated in-place > partial updates of numeric DocValue fields. There are [some issues with > it|https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR%20AND%20text%20~%20%22FileFloatSource%22%20AND%20resolution%20is%20null%20ORDER%20BY%20created%20DESC], > and it has code to be maintained. It's time to deprecate it in 9.9 so it > can be removed in 10. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17658) Implement Admin UI Start Screen
[ https://issues.apache.org/jira/browse/SOLR-17658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17658: Status: Patch Available (was: Open) > Implement Admin UI Start Screen > --- > > Key: SOLR-17658 > URL: https://issues.apache.org/jira/browse/SOLR-17658 > Project: Solr > Issue Type: New Feature > Components: Admin UI >Reporter: Christos Malliaridis >Priority: Major > Labels: new-ui, newdev, ui > > The new UI is built for web (shipped with Solr server and webapp) and desktop > (JVM). The POC has a hardcoded URL to localhost:8983 to interact with the > API. In order to have an option to allow the user to select the Solr instance > (URL), a start screen was designed that should be displayed as initial screen > / entrypoint. > h2. Task > Implement the start screen according to the [new > designs|https://www.figma.com/design/VdbEfcWQ8mirFNquBzbPk2/Apache-Solr-Admin-UI-v2-Concept?node-id=1185-13443&t=vMgOa9QlzQZSdjLf-1]. > Only the first form where the user can provide a Solr URL is relevant for > this ticket. > h2. Acceptance Criteria > - When the user opens for the first time the new UI, the start screen is > displayed > - On desktop, the user can edit the Solr URL and provide a custom URL > - A placeholder to http://localhost:8983 is used on desktop as default value > for the Solr URL > - If the user is on web and accessed the Solr instance via a Solr URL, the > host from the current URL is used and the user is automatically connected > - When successfully connected, the user is redirected to the Dashboard (or > any existing screen for now) > - The provided Solr URL is used in the HTTP client > - The logout button redirects the user back to the start screen > - A warning dialog is shown before connecting to an HTTP URL (see designs) > h2. Additional Information > You should avoid handling authentication / authorization in this issue, as > this is addressed in a separate issue. The designs cover an authentication > form, but that can be ignored for now. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]
HoustonPutman commented on code in PR #2960:
URL: https://github.com/apache/solr/pull/2960#discussion_r1983655608
##
solr/core/src/java/org/apache/solr/search/QueryResult.java:
##
@@ -22,6 +22,7 @@ public class QueryResult {
// Object for back compatibility so that we render true not "true" in json
private Object partialResults;
private Boolean segmentTerminatedEarly;
Review Comment:
I agree with "maxShardHitsReached" does make more sense than
"terminatedEarly" for me... Especially given that "segmentTerminatedEarly" is
completely unrelated, as gus mentioned.
##
solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollector.java:
##
@@ -29,11 +30,15 @@
*/
public class EarlyTerminatingCollector extends FilterCollector {
+ private final int chunkSize = 100; // Check across threads only at a chunk
size
+
private final int maxDocsToCollect;
private int numCollected = 0;
private int prevReaderCumulativeSize = 0;
private int currentReaderSize = 0;
+ private final LongAdder pendingDocsToCollect;
Review Comment:
Yeah as @sijuv mentioned in the other thread, I believe he is only actually
checking this every 100 docs, not after every add.
##
solr/core/src/java/org/apache/solr/search/QueryCommand.java:
##
@@ -194,7 +195,8 @@ public QueryCommand setNeedDocSet(boolean needDocSet) {
}
public boolean getTerminateEarly() {
-return (flags & SolrIndexSearcher.TERMINATE_EARLY) != 0;
+return (flags & SolrIndexSearcher.TERMINATE_EARLY) != 0
Review Comment:
This is really confusing to me, a different name would really help here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17309: Enhance certificate based authentication plugin with flexible cert principal resolution [solr]
laminelam commented on PR #3029: URL: https://github.com/apache/solr/pull/3029#issuecomment-2704941460 Hi @epugh Could you merge this when you get a chance? I have another PR built on top of this one that I'd like to push upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17678 Add support to return original score ( the query score ) in case of r… [solr]
sijuv commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r1983830223
##
solr/core/src/java/org/apache/solr/search/DocIterator.java:
##
@@ -43,4 +43,13 @@ public interface DocIterator extends Iterator {
* instance was retrieved.
*/
public float score();
+
+ /**
+ * Returns the query match score in case of rerank queries
+ *
+ * @return the query match score in case of a rerank query, null otherwise.
+ */
+ public default Float matchScore() {
+return null;
+ }
Review Comment:
the issue is that the matchScore is only relevant if there is a rerank in
question. We cannot return 0 and rely on this being 0 to not populate the field
because 0 could be a valid score. The scores would depend on how the user
formed the scoring query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17438 Resolve committer GPG key from other source [solr]
janhoy commented on PR #3145: URL: https://github.com/apache/solr/pull/3145#issuecomment-2704318289 Ok, will commit this then. It is fairly simple to modify should the file move -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix the solr zk invocation [solr-operator]
elangelo commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2704474666 > Has anyone tested this with Solr 8.11 (This is still supported for the 0.9 line)  At the very least the help page says `-z` should work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
