Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
mlbiscoc commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966047995
##
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##
@@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig
config) {
// TODO: remove after updating to an slf4j based zookeeper
System.setProperty("zookeeper.jmx.log4j.disable", "true");
-String solrHome = cc.getSolrHome();
+String solrHome = cc.getSolrHome().toString();
Review Comment:
If I am reading this right, this can be removed and the call below doesn't
need `Paths.get()` but can just be
`cc.getSolrHome().resolve(zoo_data).toString()`
##
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add("zkHost",
getCoreContainer(req).getZkController().getZkServerAddress());
}
if (cc != null) {
- rsp.add("solr_home", cc.getSolrHome());
+ rsp.add("solr_home", cc.getSolrHome().toString());
Review Comment:
`toString()` might not be necessary here because of this
[textWriter](https://github.com/apache/solr/blob/d2fdb16a78195e5eb40caf48761afeb1bce041ee/solr/solrj/src/java/org/apache/solr/common/util/TextWriter.java#L78)
I think but this probably needs to be confirmed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix the solr zk invocation [solr-operator]
HoustonPutman commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2675380584 We also desperately need integration tests for the basic auth stuff. Our biggest testing gap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
AndreyBozhko commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966064254
##
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##
@@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig
config) {
// TODO: remove after updating to an slf4j based zookeeper
System.setProperty("zookeeper.jmx.log4j.disable", "true");
-String solrHome = cc.getSolrHome();
+String solrHome = cc.getSolrHome().toString();
Review Comment:
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
epugh commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966069823
##
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add("zkHost",
getCoreContainer(req).getZkController().getZkServerAddress());
}
if (cc != null) {
- rsp.add("solr_home", cc.getSolrHome());
+ rsp.add("solr_home", cc.getSolrHome().toString());
Review Comment:
;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] fix the solr zk invocation [solr-operator]
HoustonPutman commented on PR #756: URL: https://github.com/apache/solr-operator/pull/756#issuecomment-2675378459 Yeah, this will need a bug fix release probably -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
AndreyBozhko commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966067522
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java:
##
@@ -80,7 +80,7 @@ public void testCustomUlogDir() throws Exception {
cores.getAllowPaths().add(dataDir.toPath()); // Allow the test dir
cores.getAllowPaths().add(newCoreInstanceDir.toPath()); // Allow the
test dir
- File instanceDir = new File(cores.getSolrHome());
+ File instanceDir = cores.getSolrHome().toFile();
Review Comment:
Yes, it's possible to replace FileUtils here with
`org.apache.commons.io.file.PathUtils`. For now I changed just the callsites
for CoreContainer#getSolrHome, to simplify the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]
gerlowskija commented on PR #3203: URL: https://github.com/apache/solr/pull/3203#issuecomment-2675454565 Alright - looks like that was a problem on the 'main' I was based on - there was a revert on main and I've rebased on that now. Should be good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17680) Unable to create Dimensional Routed Alias(DRA)
Marcel Gawron created SOLR-17680: Summary: Unable to create Dimensional Routed Alias(DRA) Key: SOLR-17680 URL: https://issues.apache.org/jira/browse/SOLR-17680 Project: Solr Issue Type: Bug Components: SolrCloud Affects Versions: 9.8, 9.6.1, 9.6, 9.4.1, 9.5, 9.4, 9.3, 9.7.0 Reporter: Marcel Gawron When trying to create a DRA using instructions from [https://solr.apache.org/guide/solr/latest/deployment-guide/alias-management.html#examples-using-createalias] Request is being rejected with message: "A routed alias requires these params: [router.field, router.name] plus some create-collection prefixed ones." Looks like it became broken by [https://github.com/apache/solr/pull/1590] https://issues.apache.org/jira/browse/SOLR-16393 DRA's have been introduced in https://issues.apache.org/jira/browse/SOLR-13375 Issue / ticket is (as of writing) open/unresolved. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
epugh commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1965992291
##
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##
@@ -87,7 +87,7 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig
config) {
// TODO: remove after updating to an slf4j based zookeeper
System.setProperty("zookeeper.jmx.log4j.disable", "true");
-String solrHome = cc.getSolrHome();
+String solrHome = cc.getSolrHome().toString();
Review Comment:
Just want to confirm that we are still stuck with String here? I see below
the `Paths.get`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
epugh commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1965995115
##
solr/solrj/src/test/org/apache/solr/client/solrj/request/TestCoreAdmin.java:
##
@@ -80,7 +80,7 @@ public void testCustomUlogDir() throws Exception {
cores.getAllowPaths().add(dataDir.toPath()); // Allow the test dir
cores.getAllowPaths().add(newCoreInstanceDir.toPath()); // Allow the
test dir
- File instanceDir = new File(cores.getSolrHome());
+ File instanceDir = cores.getSolrHome().toFile();
Review Comment:
Could we stay in path land if we change FileUtils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] in tests replace deprecated IndexSearcher.doc() calls [solr]
cpoerschke merged PR #3149: URL: https://github.com/apache/solr/pull/3149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17680) Unable to create Dimensional Routed Alias(DRA)
[ https://issues.apache.org/jira/browse/SOLR-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Gawron updated SOLR-17680: - Affects Version/s: 9.7 (was: 9.7.0) > Unable to create Dimensional Routed Alias(DRA) > -- > > Key: SOLR-17680 > URL: https://issues.apache.org/jira/browse/SOLR-17680 > Project: Solr > Issue Type: Bug > Components: SolrCloud >Affects Versions: 9.3, 9.4, 9.5, 9.4.1, 9.6, 9.7, 9.6.1, 9.8 >Reporter: Marcel Gawron >Priority: Major > > When trying to create a DRA using instructions from > [https://solr.apache.org/guide/solr/latest/deployment-guide/alias-management.html#examples-using-createalias] > > Request is being rejected with message: > "A routed alias requires these params: [router.field, router.name] plus > some create-collection prefixed ones." > Looks like it became broken by [https://github.com/apache/solr/pull/1590] > https://issues.apache.org/jira/browse/SOLR-16393 > DRA's have been introduced in > https://issues.apache.org/jira/browse/SOLR-13375 > Issue / ticket is (as of writing) open/unresolved. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]
gerlowskija commented on PR #3203:
URL: https://github.com/apache/solr/pull/3203#issuecomment-2674963541
Check and tests pass for me locally.
The `precommit` PR check fails with the error below, but this is almost
certainly unrelated to the PR. Will investigate a bit though to see if I can
resolve...
```
/home/runner/work/solr/solr/solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java:505:
error: cannot find symbol
} catch (AlreadyClosedException ignored) {
^
symbol: class AlreadyClosedException
location: class OverseerTaskProcessor
> Task :solr:core:compileJava
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-8282) Move Java APIs to NIO2 (Path), and ban use of java.io.File
[ https://issues.apache.org/jira/browse/SOLR-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-8282: - Labels: pull-request-available (was: ) > Move Java APIs to NIO2 (Path), and ban use of java.io.File > -- > > Key: SOLR-8282 > URL: https://issues.apache.org/jira/browse/SOLR-8282 > Project: Solr > Issue Type: Improvement >Reporter: Alan Woodward >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > This is an umbrella issue for removing all usage of java.io.File from Solr, > and replacing it with NIO2. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-8282: Switch CoreContainer#getSolrHome to return Path instead of String [solr]
AndreyBozhko opened a new pull request, #3204: URL: https://github.com/apache/solr/pull/3204 https://issues.apache.org/jira/browse/SOLR-8282 # Description This is only a part of SOLR-8282, prompted by the comment here: https://github.com/apache/solr/pull/3146#discussion_r1935722062 Please provide a short description of the changes you're making with this pull request. # Solution Updated public getter to return Path. Suggested review order commit-by-commit. # Tests Existing tests. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17675) Remove DirContext param from DirectoryFactory create method
[ https://issues.apache.org/jira/browse/SOLR-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-17675. --- Fix Version/s: main (10.0) Resolution: Fixed > Remove DirContext param from DirectoryFactory create method > --- > > Key: SOLR-17675 > URL: https://issues.apache.org/jira/browse/SOLR-17675 > Project: Solr > Issue Type: Improvement >Reporter: Bruno Roustant >Priority: Major > Labels: pull-request-available > Fix For: main (10.0) > > Time Spent: 40m > Remaining Estimate: 0h > > In a previous PR, we noted that the DirContext of the DirectoryFactory.create > method should be removed. It was used only by the HdfsDirectoryFactory (now > removed), and there was a bug in CachingDirectoryFactory which would create a > Directory with this param, and cache it without this param in the cache key. > We already added a todo in DirectoryFactory, and the proposal is to apply > this todo: remove the DirContext param from the DirectoryFactory.create > method. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Fix race condition in TestThinCache [solr]
HoustonPutman commented on PR #3198: URL: https://github.com/apache/solr/pull/3198#issuecomment-2674924334 In the meantime I'll merge, since this is failing the tests occasionally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Fix race condition in TestThinCache [solr]
HoustonPutman merged PR #3198: URL: https://github.com/apache/solr/pull/3198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-17444: Add Passage Sorting Option in UnifiedSolrHighlighter [solr]
Seunghan-Jung opened a new pull request, #2697: URL: https://github.com/apache/solr/pull/2697 https://issues.apache.org/jira/browse/SOLR-17444 # Description We will add the `passageSortComparator` option, introduced in the `UnifiedHighlighter` in the Lucene 9.11 project, to the Solr highlighter parameters, enabling its functionality within Solr. For reference, here is the related Lucene project commit: https://github.com/apache/lucene/commit/8773725ac0f15962b39bcc1f6fc5fb331b7a6d62 # Solution 1. Added the parameter name `PASSAGE_SORT` to HighlightParams to support the related functionality. 2. In the `UnifiedSolrHighlighter.SolrExtendedUnifiedHighlighter` class, I overrode the `getPassageSortComparator` method from the superclass `UnifiedHighlighter`. The `PASSAGE_SORT` parameter from the request is parsed and the corresponding `Comparator` object is used. # Tests # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]
cpoerschke commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2675080382 > I think I figured out how to add the Lucene `queries` module to the local Javadocs. I had to manually edit the lockfiles... Thanks for figuring it out and picking this up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] LogListener: remove no-arg convenience methods [solr]
dsmiley merged PR #3202: URL: https://github.com/apache/solr/pull/3202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]
epugh merged PR #2693: URL: https://github.com/apache/solr/pull/2693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]
bruno-roustant merged PR #3194: URL: https://github.com/apache/solr/pull/3194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17675) Remove DirContext param from DirectoryFactory create method
[ https://issues.apache.org/jira/browse/SOLR-17675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929116#comment-17929116 ] ASF subversion and git services commented on SOLR-17675: Commit 5ac5c26c92c93625847fce82f3b596f3ace63a6f in solr's branch refs/heads/main from Bruno Roustant [ https://gitbox.apache.org/repos/asf?p=solr.git;h=5ac5c26c92c ] SOLR-17675: Remove DirContext param from DirectoryFactory create method. (#3194) > Remove DirContext param from DirectoryFactory create method > --- > > Key: SOLR-17675 > URL: https://issues.apache.org/jira/browse/SOLR-17675 > Project: Solr > Issue Type: Improvement >Reporter: Bruno Roustant >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > In a previous PR, we noted that the DirContext of the DirectoryFactory.create > method should be removed. It was used only by the HdfsDirectoryFactory (now > removed), and there was a bug in CachingDirectoryFactory which would create a > Directory with this param, and cache it without this param in the cache key. > We already added a todo in DirectoryFactory, and the proposal is to apply > this todo: remove the DirContext param from the DirectoryFactory.create > method. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] Text to Vector Filter for Indexing [solr-operator]
HoustonPutman closed issue #758: Text to Vector Filter for Indexing URL: https://github.com/apache/solr-operator/issues/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16391: Convert create-core, core-status to JAX-RS [solr]
gerlowskija merged PR #3054: URL: https://github.com/apache/solr/pull/3054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17677: Ensure DBQ is safe before running [solr]
gerlowskija merged PR #3203: URL: https://github.com/apache/solr/pull/3203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17677) {!join} in delete-by-query throws ClassCastException and closes IndexWriter
[
https://issues.apache.org/jira/browse/SOLR-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929297#comment-17929297
]
ASF subversion and git services commented on SOLR-17677:
Commit 76e9b331a35ae2a80a675c98794b677758470b09 in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=76e9b331a35 ]
SOLR-17677: Ensure DBQ is safe before running (#3203)
Portions of the DBQ codepath execute the deletion query with a standard
Lucene IndexSearcher, which upsets some Solr Query implementations that
have been built to assume SolrIndexSearcher in (e.g.)
Query.createWeight.
This commit adds checks for this case, which work by using a Lucene
"QueryVisitor" to iterate over a parsed query tree and detect whether
any of the individual queries require SolrIndexSearcher.
(The QueryVisitor implementation has been added as 'lucene.
experimental', to leave us free to modify or remove it in future as desired.)
> {!join} in delete-by-query throws ClassCastException and closes IndexWriter
> ---
>
> Key: SOLR-17677
> URL: https://issues.apache.org/jira/browse/SOLR-17677
> Project: Solr
> Issue Type: Improvement
>Affects Versions: 9.8
>Reporter: Jason Gerlowski
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Solr's JoinQuery implementation explicitly casts the provided "IndexSearcher"
> to a "SolrIndexSearcher". In most contexts this assumption bears out, but
> not always.
> One counter-example is Solr's "Delete By Query" codepath, which runs the
> deletion query using a "raw" Lucene IndexSearcher. (Presumably this is
> because the new searcher has just been opened?). Any DBQ containing a join
> query will throw a ClassCastException, which then bubbles up to the
> IndexWriter as a "tragic" Lucene exception, force-closing the IndexWriter and
> throwing the surrounding SolrCore in to a bad state:
> {code}
> 2025-02-18 19:39:25.339 ERROR (qtp1426725223-177-localhost-73)
> [c:techproducts s:shard2 r:core_node3 x:techproducts_shard2_replica_n1
> t:localhost-73] o.a.s.h.RequestHandlerBase Server exception =>
> org.apache.solr.common.SolrException: this IndexWriter is closed
> at
> org.apache.solr.common.SolrException.wrapLuceneTragicExceptionIfNecessary(SolrException.java:218)
> org.apache.solr.common.SolrException: this IndexWriter is closed
> at
> org.apache.solr.common.SolrException.wrapLuceneTragicExceptionIfNecessary(SolrException.java:218)
> ~[?:?]
> at
> org.apache.solr.handler.RequestHandlerBase.normalizeReceivedException(RequestHandlerBase.java:272)
> ~[?:?]
> at
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:238)
> ~[?:?]
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2880) ~[?:?]
> at
> org.apache.solr.servlet.HttpSolrCall.executeCoreRequest(HttpSolrCall.java:890)
> ~[?:?]
> at org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:576)
> ~[?:?]
> at
> org.apache.solr.servlet.SolrDispatchFilter.dispatch(SolrDispatchFilter.java:241)
> ~[?:?]
> at
> org.apache.solr.servlet.SolrDispatchFilter.lambda$doFilterRetry$0(SolrDispatchFilter.java:198)
> ~[?:?]
> at
> org.apache.solr.servlet.ServletUtils.traceHttpRequestExecution2(ServletUtils.java:227)
> ~[?:?]
> at
> org.apache.solr.servlet.ServletUtils.rateLimitRequest(ServletUtils.java:197)
> ~[?:?]
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilterRetry(SolrDispatchFilter.java:192)
> ~[?:?]
> at
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:181)
> ~[?:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:97)
> ~[jetty-servlet-api-4.0.6.jar:?]
> at
> org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:210)
> ~[jetty-servlet-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1635)
> ~[jetty-servlet-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:527)
> ~[jetty-servlet-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:131)
> ~[jetty-server-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:598)
> ~[jetty-security-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)
> ~[jetty-server-10.0.22.jar:10.0.22]
> at
> org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:223)
> ~[jetty-server-10.0.22.jar:10.0.2
[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)
[
https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929295#comment-17929295
]
ASF subversion and git services commented on SOLR-16391:
Commit 5fafabdb13d62b2d590f7602b7720042e5f3a3db in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=5fafabdb13d ]
SOLR-16391: Convert create-core, core-status to JAX-RS (#3054)
The migration to JAX-RS implicitly adds these APIs to the OAS, and ensures
autogeneration of SolrRequest/SolrResponse types.
> Cosmetic improvements and migration to JAX-RS (collection, collection prop,
> core CRUD APIs)
> ---
>
> Key: SOLR-16391
> URL: https://issues.apache.org/jira/browse/SOLR-16391
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Affects Versions: main (10.0)
>Reporter: Jason Gerlowski
>Priority: Major
> Labels: newdev, pull-request-available
> Time Spent: 7h
> Remaining Estimate: 0h
>
> As mentioned on SOLR-15781, the v2 API currently has an experimental
> designation, and the community has expressed an interest in using this period
> to update our v2 endpoints to be more REST-ful and consistent. The current
> plan is to follow the specific changes laid out in [this
> spreadsheet|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing],
> though of course nothing there is set in stone and there are still warts to
> be worked out.
> While we're touching the code for these endpoints, we should also convert
> them to JAX-RS framework definitions. (This was initially tracked as a
> separate effort - see SOLR-16370 - but the edit that were required ended up
> overlapping so significantly with the "cosmetic" improvements here that in
> practice it almost always makes sense to do the two together.)
> This ticket plans to tackle making the changes required for Solr's collection
> and collection-prop CRUD APIs, as well as its collection-status APIs. These
> are described in detail in the spreadsheet linked above, but are summarized
> in the tables below for convenience and ease of tracking progress.
> *JAX-RS Conversion and Cosmetic Changes*
> ||API Name||Original Form||Desired Form||Status||Volunteer||
> |-Create Collection-|-POST /api/collections \{create: \{...\}\}-|-POST
> /api/collections \{...\}-|-Finished-|-Jason-|
> |-Get Collection Details-|-N/A-|-GET
> /api/collections/collName?details=specificFlags-|-Finished-|-Jason-|
> |Create Core|POST /api/cores \{"create": \{...\}\}|POST /api/cores
> \{...\}|Open|N/A|
> |Collection Ping/Healthcheck|GET /api/collections/collName/admin/ping|GET
> /api/collections/collName/health|Open|N/A|
> |Is Collection Healthcheck Enabled|GET
> /api/collections/collName/admin/ping?action=STATUS|GET
> /api/collections/collName/health/status|Open|N/A|
> |Enable/Disable Collection Healthcheck|GET
> /api/collections/collName/admin/ping?action=enable\|disable|PUT
> /api/collections/collName/health/status \{"enabled": true\|false\}|Open|N/A|
> |-Delete Collections-|-DELETE /api/collections/collName-|-DELETE
> /api/collections/collName-|-Finished-|-Jason-|
> |-Set Collection Property-|-POST /api/collections/collName
> \{set-collection-property: \{...\}\}-|-PUT
> /api/collections/collName/properties/propName \{"value":
> "someVal"\}-|-Finished-|-Jason-|
> |-Delete Collection Property-|-POST /api/collections/collName
> \{set-collection-property: \{...\}\}-|-DELETE
> /api/collections/collName/properties/propName-|-Finished-|-Jason-|
> *JAX-RS Conversion Only*
> ||API Name||Endpoint||Status||Volunteer||
> |-List Collections-|-GET /api/collections-|-Finished-|-Jason-|
> Some helpful links related to these changes these changes. Should help get
> any interested newcomers started!
> * For detailed information on Solr's current and desired v2 APIs see the
> spreadsheet
> [here|https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?usp=sharing]
> * [Discussion of how APIs work in Solr
> (video)|https://www.youtube.com/watch?v=iIpvfXBjDog]
> * [Step-by-step guide to creating
> APIs|https://issues.apache.org/jira/browse/SOLR-15737?focusedCommentId=17617923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17617923]
> using the JAX-RS v2 API framework
> * [Example PR for a similar change|https://github.com/apache/solr/pull/1679]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Finally fix TestCoordinatorRole for good. [solr]
HoustonPutman opened a new pull request, #3205: URL: https://github.com/apache/solr/pull/3205 `TestCoordinatorRole.testNRTRestart()` has been flaky for a long time, and for various reasons. I believe this is the last one. Basically in the last part, it's supposed to turn off the NRT replica and the PULL replica alternating, and keep trying requests that have `shards.preference=NRT`, until a PULL replica is forced to be used to serve the request. The issue was that the pull node is started right before this. So if a very low (< 300 ms) random value is chosen for `serveTogetherTime`, then the Pull replica will fail to recover from the NRT replica leader. Pull replicas do not become active unless they recover on startup. So when the NRT replica is offline, requests will fail because there are no replicas serving the requested shard. The `getHostCoreName` call can handle up to 500 ms of failures, so if `downTime` (another random int) is > 500, or a lower number, because it takes time to startup, then it will exceed the number of allowed errors. The fix here is 2 parts: - The only really necessary fix is waiting for the pull replica to come online before starting to take down other nodes - In order to keep the spirit of the test, I reversed the ordering of the jettys that will be brought down, because otherwise the PULL replica is chosen immediately and we don't have to do any iterations of this loop. Because of this, we need to do the same replica-state-check at the end of the loop, to ensure the above failure scenario doesn't happen during our loop either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [I] Text to Vector Filter for Indexing [solr-operator]
HoustonPutman commented on issue #758: URL: https://github.com/apache/solr-operator/issues/758#issuecomment-2675799680 Agreed, please open an issue at https://issues.apache.org/jira/projects/SOLR! Great idea though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-17531: Use new unified GC log options [solr]
github-actions[bot] commented on PR #2815: URL: https://github.com/apache/solr/pull/2815#issuecomment-2675846661 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the d...@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
