[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470030#comment-16470030
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9114:


rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during 
network restart
URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-387979763
 
 
   Tests LGTM, we've enough reviews to merge this. If there are no objections, 
this will be merged by end of the day tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> restartnetwork with cleanup should not update/restart both routers at once
> --
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start 
> two  new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470054#comment-16470054
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-387985818
 
 
   Closing this, will send a new PR taking over this issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470055#comment-16470055
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd closed pull request #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
index b0f87af648d..bb451ceb392 100644
--- 
a/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
+++ 
b/plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
@@ -134,6 +134,10 @@
 private static final long SECONDS_PER_MINUTE = 60;
 private static final int STARTUP_DELAY = 6; // 60 
seconds
 private static final long DEFAULT_HOST_SCAN_INTERVAL = 60; // 
every 10 minutes
+
+private static final int DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x = 256;
+private static final int DEFAULT_PORTS_PER_DV_PORT_GROUP = 8;
+
 private long _hostScanInterval = DEFAULT_HOST_SCAN_INTERVAL;
 private int _timeout;
 
@@ -180,7 +184,7 @@
 private StorageLayer _storage;
 private final String _privateNetworkVSwitchName = "vSwitch0";
 
-private int _portsPerDvPortGroup = 256;
+private int _portsPerDvPortGroup = DEFAULT_PORTS_PER_DV_PORT_GROUP;
 private boolean _fullCloneFlag;
 private boolean _instanceNameFlag;
 private String _serviceConsoleName;
@@ -267,8 +271,6 @@ public boolean configure(String name, Map 
params) throws Configu
 _instanceNameFlag = Boolean.parseBoolean(value);
 }
 
-_portsPerDvPortGroup = 
NumbersUtil.parseInt(_configDao.getValue(Config.VmwarePortsPerDVPortGroup.key()),
 _portsPerDvPortGroup);
-
 _serviceConsoleName = 
_configDao.getValue(Config.VmwareServiceConsole.key());
 if (_serviceConsoleName == null) {
 _serviceConsoleName = "Service Console";
@@ -387,8 +389,17 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") || 
version.equals("4.1")) && _portsPerDvPortGroup < 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+portsPerDvPortGroup = 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x;
+}
+}
+
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, null, 18,
-vsType, _portsPerDvPortGroup, null, false, 
BroadcastDomainType.Vlan, null);
+vsType, portsPerDvPortGroup, null, false, 
BroadcastDomainType.Vlan, null);
 }
 }
 
diff --git a/server/src/com/cloud/configuration/Config.java 
b/server/src/com/cloud/configuration/Config.java
index 551c61ea2e4..e9ef4432f75 100644
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -1135,14 +1135,6 @@
 "false",
 "Enable/Disable Nexus/Vmware dvSwitch in VMware environment",
 null),
-VmwarePortsPerDVPortGroup(
-"Network",
-ManagementServer.class,
-Integer.class,
-"vmware.ports.per.dvportgroup",
-"256",
-"Default number of ports per Vmware dvPortGroup in VMware 
environment",
-null),
 VmwareCreateFullClone(
 "Advanced",
 ManagementServer.class,
diff --git a/setup/db/db/schema-4930to41000-cleanup.sql 
b/setup/db/db/schema-4930to41000-cleanup.sql
index 986dcdfe7da..b9b853e34f2 100644
--- a/setup/db/db/schema-4930to41000-cleanup.sql
+++ b/setup/db/db/schema-4930to41000-cleanup.sql
@@ -21,4 +21,6 @@
 
 DELETE FROM `cloud`.`configuration` WHERE 
name='consoleproxy.loadscan.interval';
 
+DELETE FROM `cloud`.`configuration` WHERE 
`name`='vmware.ports.per.dvportgroup';
+
 DELETE FROM `cloud`.`host_details` where name = 'vmName' and  value in (select 
name from `cloud`.`vm_instance`  where state = 'Expunging' and hypervis

[jira] [Closed] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread Rohit Yadav (JIRA)

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Yadav closed CLOUDSTACK-9184.
---
Resolution: Fixed

> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470059#comment-16470059
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd opened a new pull request #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634
 
 
   This deprecates the vmware.ports.per.dvportgroup global setting.
   
   The vSphere Auto Expand feature (introduced in vSphere 5.0) will take
   care of dynamically increasing/decreasing the dvPorts when running out
   of distributed ports . But in case of vSphere 4.1/4.0 (If used), as this
   feature is not there, the new default value (=> 8) have an impact in the
   existing deployments. Action item for vSphere 4.1/4.0: Admin should
   modify the global configuration setting "vmware.ports.per.dvportgroup"
   from 8 to any number based on their environment because the proposal
   default value of 8 would be very less without auto expand feature in
   general. The current default value of 256 may not need immediate
   modification after deployment, but 8 would be very less which means
   admin need to update immediately after upgrade.
   
   This continues and take-over from PR 
https://github.com/apache/cloudstack/pull/1253
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## GitHub Issue/PRs
   
   
   
   
   
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470060#comment-16470060
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387987066
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470062#comment-16470062
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387987251
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470095#comment-16470095
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-387994777
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2040


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470105#comment-16470105
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


sureshanaparti commented on issue #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-387996149
 
 
   @PaulAngus , @rhtyd  I'll continue work on the changes required if any, on 
this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread Suresh Anaparti (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470123#comment-16470123
 ] 

Suresh Anaparti commented on CLOUDSTACK-9184:
-

Hi Rohit,

I’ll fix the PR# 1253 with the changes required if any. Can you please reopen 
that?  I don’t see any extra changes in the PR# 2634, other than rebasing.

Thanks,
Suresh

On 10/05/18, 1:48 PM, "Rohit Yadav (JIRA)"  wrote:


 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rohit Yadav closed CLOUDSTACK-9184.
---
Resolution: Fixed

> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
vCenter 5.0 onwards
> 
---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
setting the number of ports per dvportgroup of Distributed Virtual Switch (DVS) 
and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
dynamically from ESX 5.0 release. So, even if we set this global setting, auto 
expand will take effect and the value configured at cloudstack is not useful 
anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470141#comment-16470141
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388003370
 
 
   @blueorangutan test centos7 vmware-65


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470140#comment-16470140
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd commented on issue #1253: CLOUDSTACK-9184: [VMware] 
vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 
onwards
URL: https://github.com/apache/cloudstack/pull/1253#issuecomment-388003293
 
 
   @sureshanaparti I've moved the changes to this new PR against 4.11: 
https://github.com/apache/cloudstack/pull/2634#issuecomment-387994777
   Perhaps you can share how you tested it, help with testing in general.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470142#comment-16470142
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388003574
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread Rohit Yadav (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470150#comment-16470150
 ] 

Rohit Yadav commented on CLOUDSTACK-9184:
-

Suresh - the reason for closing the old PR was that my requests for rebasing 
were ignored for months, the issue was recently reported as blocker so I opened 
a new PR rebasing your changes. If you need to make further improvements, you 
can push changes to the new PR, no point closing the new PR and opening the old 
PR when the work of rebasing is already done.


I'm in the meanwhile testing it against 4.11 including doing an upgrade related 
tests based on the reported blocker issue:

https://github.com/apache/cloudstack/issues/2631


- Rohit







> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470307#comment-16470307
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rhtyd commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388034846
 
 
   @sureshanaparti I've concluded a standalone and upgrade test (upgrade from 
4.6) and conclude no regressions. Do you have any comments on the PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470363#comment-16470363
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184: 
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187320904
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null, 
null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") || 
version.equals("4.1")) && _portsPerDvPortGroup < 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
 
 Review comment:
   do you need that second condition there `_portsPerDvPortGroup < 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470362#comment-16470362
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


rafaelweingartner commented on a change in pull request #2634: CLOUDSTACK-9184: 
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187322162
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null, 
null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
 
 Review comment:
   Are the versions fixed? I mean, can't we have `4.2`, `4.3`, and so on.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470612#comment-16470612
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


sureshanaparti commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware 
dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388100897
 
 
   @rhtyd No comments. Thanks for taking this up!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470618#comment-16470618
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: 
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187379525
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null, 
null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
 
 Review comment:
   @rafaelweingartner No VMware ESXi/ESX hosts with these release versions. 
Take a look at the versions in the article 
https://kb.vmware.com/s/article/2143832.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470635#comment-16470635
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: 
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187382206
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null, 
null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") || 
version.equals("4.1")) && _portsPerDvPortGroup < 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
 
 Review comment:
   @rafaelweingartner Yes. For these versions, the default ports which is 256 
shouldn't change, for the backward compatibility. 
   
   `In case of vSphere 4.1/4.0 (If used), as this feature is not there, the new 
default value (=> 8) have an impact in the existing deployments. Action item 
for vSphere 4.1/4.0: Admin should modify the global configuration setting 
"vmware.ports.per.dvportgroup" from 8 to any number based on their environment 
because the proposal default value of 8 would be very less without auto expand 
feature in general. The current default value of 256 may not need immediate 
modification after deployment, but 8 would be very less which means admin need 
to update immediately after upgrade.`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470645#comment-16470645
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184: 
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187382206
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ##
 @@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String 
privateTrafficLabel) throws Excep
 HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private", 
hostMo, vlanId, null, null, 18, false, BroadcastDomainType.Vlan, null, 
null);
 }
 else {
+int portsPerDvPortGroup = _portsPerDvPortGroup;
+AboutInfo about = hostMo.getHostAboutInfo();
+if (about != null) {
+String version = about.getApiVersion();
+if (version != null && (version.equals("4.0") || 
version.equals("4.1")) && _portsPerDvPortGroup < 
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
 
 Review comment:
   @rafaelweingartner Yes. For these versions, the default ports which is 256 
shouldn't change, for the backward compatibility. The below details can be 
documented in the upgrade details.
   
   `In case of vSphere 4.1/4.0 (If used), as this feature is not there, the new 
default value (=> 8) have an impact in the existing deployments. Action item 
for vSphere 4.1/4.0: Admin should modify the global configuration setting 
"vmware.ports.per.dvportgroup" from 8 to any number based on their environment 
because the proposal default value of 8 would be very less without auto expand 
feature in general. The current default value of 256 may not need immediate 
modification after deployment, but 8 would be very less which means admin need 
to update immediately after upgrade.`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CLOUDSTACK-9184) [VMware] vmware.ports.per.dvportgroup global setting is not useful from vCenter 5.0 onwards

2018-05-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471240#comment-16471240
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9184:


blueorangutan commented on issue #2634: CLOUDSTACK-9184: Fixes #2631 VMware dvs 
portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#issuecomment-388205878
 
 
   Trillian test result (tid-2653)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45122 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2634-t2653-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.32 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] vmware.ports.per.dvportgroup global setting is not useful from 
> vCenter 5.0 onwards
> ---
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, VMware
>Affects Versions: 4.5.2
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
>Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for 
> setting the number of ports per dvportgroup of Distributed Virtual Switch 
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value 
> dynamically from ESX 5.0 release. So, even if we set this global setting, 
> auto expand will take effect and the value configured at cloudstack is not 
> useful anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)