[
https://issues.apache.org/jira/browse/CLOUDSTACK-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470645#comment-16470645
]
ASF GitHub Bot commented on CLOUDSTACK-9184:
--------------------------------------------
sureshanaparti commented on a change in pull request #2634: CLOUDSTACK-9184:
Fixes #2631 VMware dvs portgroup autogrowth
URL: https://github.com/apache/cloudstack/pull/2634#discussion_r187382206
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -394,8 +394,16 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
HypervisorHostHelper.prepareNetwork(vSwitchName, "cloud.private",
hostMo, vlanId, null, null, 180000, false, BroadcastDomainType.Vlan, null,
null);
}
else {
+ int portsPerDvPortGroup = _portsPerDvPortGroup;
+ AboutInfo about = hostMo.getHostAboutInfo();
+ if (about != null) {
+ String version = about.getApiVersion();
+ if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
Review comment:
@rafaelweingartner Yes. For these versions, the default ports which is 256
shouldn't change, for the backward compatibility. The below details can be
documented in the upgrade details.
`In case of vSphere 4.1/4.0 (If used), as this feature is not there, the new
default value (=> 8) have an impact in the existing deployments. Action item
for vSphere 4.1/4.0: Admin should modify the global configuration setting
"vmware.ports.per.dvportgroup" from 8 to any number based on their environment
because the proposal default value of 8 would be very less without auto expand
feature in general. The current default value of 256 may not need immediate
modification after deployment, but 8 would be very less which means admin need
to update immediately after upgrade.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [VMware] vmware.ports.per.dvportgroup global setting is not useful from
> vCenter 5.0 onwards
> -------------------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-9184
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9184
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server, VMware
> Affects Versions: 4.5.2
> Reporter: Suresh Kumar Anaparti
> Assignee: Suresh Kumar Anaparti
> Priority: Major
>
> CloudStack has a global config paramter vmware.ports.per.dvportgroup for
> setting the number of ports per dvportgroup of Distributed Virtual Switch
> (DVS) and this takes effect when the zone is created.
> Auto expand/shrink features adjusts the ports per dvportgroup value
> dynamically from ESX 5.0 release. So, even if we set this global setting,
> auto expand will take effect and the value configured at cloudstack is not
> useful anymore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
