[hibernate-dev] [search] Purpose of FullTextSharedSessionBuilder
Hi, Sanne and I started a discussion around FullTextSharedSessionBuilder as part of HSEARCH-1169 [1] and its corresponding pull request #308. The pull request exposes FullTextSharedSessionBuilder in the public FullTextSession API. My question to begin with is why we need FullTextSharedSessionBuilder in the first place? It offers hardly (if any at all) benefits. I suggest we even remove this interface rather than exposing it in FullTextSession. Thoughts? --Hardy [1] https://hibernate.onjira.com/browse/HSEARCH-1169 [2] https://github.com/hibernate/hibernate-search/pull/308 ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [search] Purpose of FullTextSharedSessionBuilder
To reiterate what I've commented in the pull requests, I think it's nice to have and properly fits the goal for a flawless integration with the Hibernate ORM APIs. Also, it doesn't look like a demanding feature to maintain, and it's already there. +1 to keep it. On 27 June 2012 10:52, Hardy Ferentschik wrote: > Hi, > > Sanne and I started a discussion around FullTextSharedSessionBuilder as part > of HSEARCH-1169 [1] > and its corresponding pull request #308. > > The pull request exposes FullTextSharedSessionBuilder in the public > FullTextSession API. My question to begin with > is why we need FullTextSharedSessionBuilder in the first place? It offers > hardly (if any at all) benefits. I suggest we even remove > this interface rather than exposing it in FullTextSession. > > Thoughts? > > --Hardy > > > > [1] https://hibernate.onjira.com/browse/HSEARCH-1169 > [2] https://github.com/hibernate/hibernate-search/pull/308 > > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [search] Purpose of FullTextSharedSessionBuilder
On Jun 27, 2012, at 12:42 PM, Sanne Grinovero wrote: > To reiterate what I've commented in the pull requests, I think it's > nice to have and properly fits the goal for a flawless integration > with the Hibernate ORM APIs. I don't see a flaw in the integration as it is. AFAIKS, all we gain with FullTextSharedSessionBuilder is that builder#openSession returns a FullTextSession instead of a Session. The cost for this are two more classes FullTextSharedSession and FullTextSharedSessionBuilderDelegator which are basically just full of noop operations. Easy to maintain maybe, but also easier to understand? > and it's already there. That's really a weak argument. Are you implying just because something is written in code it makes sense it needs to be kept around? > +1 to keep it. -1 from me --Hardy > > On 27 June 2012 10:52, Hardy Ferentschik wrote: >> Hi, >> >> Sanne and I started a discussion around FullTextSharedSessionBuilder as part >> of HSEARCH-1169 [1] >> and its corresponding pull request #308. >> >> The pull request exposes FullTextSharedSessionBuilder in the public >> FullTextSession API. My question to begin with >> is why we need FullTextSharedSessionBuilder in the first place? It offers >> hardly (if any at all) benefits. I suggest we even remove >> this interface rather than exposing it in FullTextSession. >> >> Thoughts? >> >> --Hardy >> >> >> >> [1] https://hibernate.onjira.com/browse/HSEARCH-1169 >> [2] https://github.com/hibernate/hibernate-search/pull/308 >> >> >> >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] 4.1.5
Going to push 4.1.5 out 2 more weeks (7/11) -- st...@hibernate.org http://hibernate.org ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] (no subject)
http://www.linchouston.com/wp-content/themes/LINC-Houston/rgpas.html ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
