To reiterate what I've commented in the pull requests, I think it's
nice to have and properly fits the goal for a flawless integration
with the Hibernate ORM APIs.

Also, it doesn't look like a demanding feature to maintain, and it's
already there.

+1 to keep it.

On 27 June 2012 10:52, Hardy Ferentschik <ha...@hibernate.org> wrote:
> Hi,
>
> Sanne and I started a discussion around FullTextSharedSessionBuilder as part 
> of HSEARCH-1169 [1]
> and its corresponding pull request #308.
>
> The pull request exposes FullTextSharedSessionBuilder in the public 
> FullTextSession API. My question to begin with
> is why we need FullTextSharedSessionBuilder in the first place? It offers 
> hardly (if any at all) benefits. I suggest we even remove
> this interface rather than exposing it in FullTextSession.
>
> Thoughts?
>
> --Hardy
>
>
>
> [1] https://hibernate.onjira.com/browse/HSEARCH-1169
> [2] https://github.com/hibernate/hibernate-search/pull/308
>
>
>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
_______________________________________________
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev

Reply via email to