Re: [PATCH] Add nvi

2014-09-02 Thread Ludovic Courtès
Hi!

Marek Benc  skribis:

> Disregard my previous email, I figured it out.

OK, perfect.  :-)

> Here is my favorite text editor. This is my first package, so I'm
> sorry if I messed up somewhere.
> The formatting is probably bad, but every package seemed to be
> formatted slightly differently, so I don't know.

Formatting looks good.  I’m just reporting a few minor issues below.

Could you send an updated patch in the format produced by ‘git
format-patch’, and with a ChangeLog-style commit log?  See “Submitting
Patches” in the ‘HACKING’ file for details.

> +(uri
> +  (string-append "http://harrier.slackbuilds.org/misc/nvi-"; version
> + ".tar.bz2"))

Shouldn’t it be
https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
the URL given on the home page.)

> +(arguments
> +  `(#:out-of-source? '(#t)))

Just:

  `(#:out-of-source? #t)

> +(license bsd-3)))

This is actually bsd-4 (see its ‘LICENSE’ file: it has the four clauses,
as shown at .)

> --- a/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:22:45.219850258 +0200
> +++ b/gnu/packages/patches/nvi-assume-preserve-path.patch 2014-09-01
> 15:03:50.395813104 +0200
> @@ -0,0 +1,28 @@
> +--- a/dist/configure2014-09-01 14:46:01.075778095 +0200
>  b/dist/configure2014-09-01 14:52:08.411790122 +0200

Please add a sentence or two at the beginning of the file saying what it
does and why.  (You can remove the comment above ‘search-patch’ in
nvi.scm.)

Thanks!

Ludo’.



Re: [PATCH] Add nvi

2014-09-02 Thread Marek Benc



On 09/02/2014 10:19 AM, Ludovic Courtès wrote:

Hi!

Hello,
Could you send an updated patch in the format produced by ‘git 
format-patch’, and with a ChangeLog-style commit log? See “Submitting 
Patches” in the ‘HACKING’ file for details. 

Will do.

+(uri
+  (string-append "http://harrier.slackbuilds.org/misc/nvi-"; version
+ ".tar.bz2"))

Shouldn’t it be
https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
the URL given on the home page.)
Actually, no. The actual home page, according to Debain, is 
http://www.kotnet.org/~skimo/nvi/ ; However, that site is dead. I've 
looked at what other distributions report and they say 
https://sites.google.com/a/bostic.com/keithbostic/vi is currently the 
home of nvi. Unfortunately, they don't provide the latest version of the 
editor (there's even a bug in the build system of that version), so I 
had to look somewhere else to get the newest one, which I found at 
Slackbuilds and some other places, like the Debian source repository.


I think I'll remove the website from the definition, as it'll cause 
confusion (It confused even me).

+(license bsd-3)))

This is actually bsd-4 (see its ‘LICENSE’ file: it has the four clauses,
as shown at .)

Really? I see there only 3 clauses, here's a listing of the LICENSE file:

/*-
 * $Id: LICENSE,v 8.17 2000/08/18 14:58:41 bostic Exp $ (Sleepycat) 
$Date: 2000/

08/18 14:58:41 $
 */

The following are the copyrights and redistribution conditions that apply
to this copy of the Vi software.

/*
 * Copyright (c) 1991, 1992, 1993, 1994
 *  The Regents of the University of California.  All rights reserved.
 *  Copyright (c) 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 
2000

 *  Keith Bostic.  All rights reserved.
 *  Copyright (c) 1999, 2000
 *  Sven Verdoolaege.  All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *notice, this list of conditions and the following disclaimer in the
 *documentation and/or other materials provided with the distribution.
 * 3. Neither the name of the University nor the names of its contributors
 *may be used to endorse or promote products derived from this software
 *without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 
PURPOSE

 * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 
CONSEQUENTIAL

 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, 
STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN 
ANY WAY

 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 * SUCH DAMAGE.
 */



Okay, now that that's out of the way, here's the updated patch:

2014-09-02  Marek Benc  
* gnu/packages/nvi.scm: Add the nvi editor.
* gnu/packages/patches/nvi-assume-preserve-path.patch: Assume nvi can 
store backups in /var/tmp.

---
 gnu/packages/nvi.scm   |   68 


 .../patches/nvi-assume-preserve-path.patch |   30 +
 2 files changed, 98 insertions(+)
 create mode 100644 gnu/packages/nvi.scm
 create mode 100644 gnu/packages/patches/nvi-assume-preserve-path.patch

diff --git a/gnu/packages/nvi.scm b/gnu/packages/nvi.scm
new file mode 100644
index 000..7553006
--- /dev/null
+++ b/gnu/packages/nvi.scm
@@ -0,0 +1,68 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 Marek Benc 
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see .
+
+(define-module (gnu packages nvi)
+  #:use-module (gnu packages)
+  #:use-mod

Re: [PATCH] Add nvi

2014-09-02 Thread Cyril Roelandt
On 09/01/2014 03:33 PM, Marek Benc wrote:
> Disregard my previous email, I figured it out.
> 
> Here is my favorite text editor. This is my first package, so I'm sorry 
> if I messed up somewhere.
> The formatting is probably bad, but every package seemed to be formatted 
> slightly differently, so I don't know.
> 
> --- a/gnu/packages/nvi.scm2014-09-01 15:22:45.219850258 +0200

Maybe we should have all vi-like editors in one file. We currently have
vim in gnu/packages/vim.scm, maybe we should have both nvi and vim in
gnu/packages/vi.scm, WDYT ?


Cyril.



Re: [PATCH] Add nvi

2014-09-02 Thread Taylan Ulrich Bayirli/Kammer
Cyril Roelandt  writes:

> Maybe we should have all vi-like editors in one file. We currently have
> vim in gnu/packages/vim.scm, maybe we should have both nvi and vim in
> gnu/packages/vi.scm, WDYT ?

I think at least Vim is, on the meanwhile, a very different beast from
any random vi implementation.  (Don't know about nvi or others.)

Do we have any guidelines regarding what packages go in what files, or
is it determined on an "intuitive" basis?

Taylan



Re: [PATCH] Add nvi

2014-09-02 Thread Ludovic Courtès
Cyril Roelandt  skribis:

> On 09/01/2014 03:33 PM, Marek Benc wrote:
>> Disregard my previous email, I figured it out.
>> 
>> Here is my favorite text editor. This is my first package, so I'm sorry 
>> if I messed up somewhere.
>> The formatting is probably bad, but every package seemed to be formatted 
>> slightly differently, so I don't know.
>> 
>> --- a/gnu/packages/nvi.scm2014-09-01 15:22:45.219850258 +0200
>
> Maybe we should have all vi-like editors in one file. We currently have
> vim in gnu/packages/vim.scm, maybe we should have both nvi and vim in
> gnu/packages/vi.scm, WDYT ?

Yes, definitely.  We can do this either before or after adding nvi.

Ludo’.



Re: guix 0.7 installation

2014-09-02 Thread Federico Beffa
> This is due to the lack of the above LIBRARY_PATH setting.
>
> Could you try setting and report back?

I'll be away from my computer for 2 weeks. Will report as soon as I
will try out.

Thanks.
Fede



Re: [PATCH] Add nvi

2014-09-02 Thread Ludovic Courtès
Taylan Ulrich Bayirli/Kammer  skribis:

> Do we have any guidelines regarding what packages go in what files, or
> is it determined on an "intuitive" basis?

The latter.  :-)

That’s not ideal, but from my experience with Nixpkgs, it’s hard to find
a formal categorization scheme that would be really helpful.

Ludo’.



Re: [PATCH] Add nvi

2014-09-02 Thread Ludovic Courtès
Marek Benc  skribis:

> On 09/02/2014 10:19 AM, Ludovic Courtès wrote:

[...]

>> Shouldn’t it be
>> https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
>> the URL given on the home page.)
> Actually, no. The actual home page, according to Debain, is
> http://www.kotnet.org/~skimo/nvi/ ; However, that site is dead. I've
> looked at what other distributions report and they say
> https://sites.google.com/a/bostic.com/keithbostic/vi is currently the
> home of nvi. Unfortunately, they don't provide the latest version of
> the editor (there's even a bug in the build system of that version),
> so I had to look somewhere else to get the newest one, which I found
> at Slackbuilds and some other places, like the Debian source
> repository.

In that case please leave the sites.google.com home page, with a comment
above the source URL stating that sites.google.com is stale etc.

> I think I'll remove the website from the definition, as it'll cause
> confusion (It confused even me).
>>> +(license bsd-3)))
>> This is actually bsd-4 (see its ‘LICENSE’ file: it has the four clauses,
>> as shown at .)
> Really? I see there only 3 clauses, here's a listing of the LICENSE file:

I was looking at nvi-1.79/LICENSE and nvi-1.79/regex/COPYRIGHT, which
both contain the 4-clause text.  It’s surprising that the newer version
no longer has the fourth clause.

Which version do Trisquel or Debian ship?  What does their ‘copyright’
file says?

> Okay, now that that's out of the way, here's the updated patch:
>
> 2014-09-02  Marek Benc  

For the subject line, use “gnu: Add nvi.”

> * gnu/packages/nvi.scm: Add the nvi editor.
> * gnu/packages/patches/nvi-assume-preserve-path.patch: Assume nvi can
> store backups in /var/tmp.

In both cases, “New file.” is enough (try ‘git log’ to see examples.)

The files also need to be added to gnu-system.am.

Could you send the patch (with the added comments) as an attachment,
because the mail client apparently mangled it?

Thanks,
Ludo’.



Re: [PATCH] Add nvi

2014-09-02 Thread Marek Benc


On 09/02/2014 02:29 PM, Ludovic Courtès wrote:

Marek Benc  skribis:


On 09/02/2014 10:19 AM, Ludovic Courtès wrote:

[...]


Shouldn’t it be
https://sites.google.com/a/bostic.com/keithbostic/files/... ?  (This is
the URL given on the home page.)

Actually, no. The actual home page, according to Debain, is
http://www.kotnet.org/~skimo/nvi/ ; However, that site is dead. I've
looked at what other distributions report and they say
https://sites.google.com/a/bostic.com/keithbostic/vi is currently the
home of nvi. Unfortunately, they don't provide the latest version of
the editor (there's even a bug in the build system of that version),
so I had to look somewhere else to get the newest one, which I found
at Slackbuilds and some other places, like the Debian source
repository.

In that case please leave the sites.google.com home page, with a comment
above the source URL stating that sites.google.com is stale etc.


I think I'll remove the website from the definition, as it'll cause
confusion (It confused even me).

+(license bsd-3)))

This is actually bsd-4 (see its ‘LICENSE’ file: it has the four clauses,
as shown at .)

Really? I see there only 3 clauses, here's a listing of the LICENSE file:

I was looking at nvi-1.79/LICENSE and nvi-1.79/regex/COPYRIGHT, which
both contain the 4-clause text.  It’s surprising that the newer version
no longer has the fourth clause.

Which version do Trisquel or Debian ship?  What does their ‘copyright’
file says?


Debian Stable ships with 1.81.6, with some additional patches (which I 
might eventually add in, we'llsee). The license there is BSD-3 as well, 
I'll enclose the copyright file as an attachment.



Okay, now that that's out of the way, here's the updated patch:

2014-09-02  Marek Benc  

For the subject line, use “gnu: Add nvi.”


* gnu/packages/nvi.scm: Add the nvi editor.
* gnu/packages/patches/nvi-assume-preserve-path.patch: Assume nvi can
store backups in /var/tmp.

In both cases, “New file.” is enough (try ‘git log’ to see examples.)

The files also need to be added to gnu-system.am.


Ah, there it is. I was actually searching for this file, thinking it 
would be Makefile.am in some subdirectory, but I couldn't find it.




Could you send the patch (with the added comments) as an attachment,
because the mail client apparently mangled it?


Okay, It's as an attachment. Here's the changelog entries:

2014-09-02 Marek Benc 
* gnu/packages/nvi.scm: New file.
* gnu/packages/patches/nvi-assume-preserve-path.patch: New file.
* gnu-system.am: Added the preceding 2 files.



Thanks,
Ludo’.


Format-Specification: http://wiki.debian.org/Proposals/CopyrightFormat
Upstream-Name: nvi
Upstream-Maintainer: Sven Verdoolaege 
Upstream-Source: http://www.kotnet.org/~skimo/nvi/devel/

Files: *
Copyright: Copyright (c) 1991, 1992, 1993, 1994, The Regents of the University 
of California.  All rights reserved.
  Copyright (c) 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 
Keith Bostic.  All rights reserved.
  Copyright (c) 1993, Alan Richardson.  All rights reserved.
  Copyright (c) 1994, 1996, Rob Mayoff.  All rights reserved.
  Copyright (c) 1995, George V. Neville-Neil.  All rights reserved.
  Copyright (c) 1996, Rob Zimmermann.  All rights reserved.
  Copyright (c) 1996, 1999, 2000, Sven Verdoolaege.  All rights reserved.
  Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006, 
2007, Free Software Foundation, Inc.
License: BSD-3
  The following are the copyrights and redistribution conditions that apply
  to this copy of the Vi software.
  
  /*
   * Copyright (c) 1991, 1992, 1993, 1994
   *  The Regents of the University of California.  All rights reserved.
   *  Copyright (c) 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000
   *Keith Bostic.  All rights reserved.
   *  Copyright (c) 1999, 2000
   *Sven Verdoolaege.  All rights reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   * 1. Redistributions of source code must retain the above copyright
   *notice, this list of conditions and the following disclaimer.
   * 2. Redistributions in binary form must reproduce the above copyright
   *notice, this list of conditions and the following disclaimer in the
   *documentation and/or other materials provided with the distribution.
   * 3. Neither the name of the University nor the names of its contributors
   *may be used to endorse or promote products derived from this software
   *without specific prior written permission.
   *
   * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
   * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
   * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
   * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LI

Re: [PATCH] Add nvi

2014-09-02 Thread Ludovic Courtès
Marek Benc  skribis:

> On 09/02/2014 02:29 PM, Ludovic Courtès wrote:

[...]

>> Could you send the patch (with the added comments) as an attachment,
>> because the mail client apparently mangled it?
>
> Okay, It's as an attachment. Here's the changelog entries:
>
> 2014-09-02 Marek Benc 
> * gnu/packages/nvi.scm: New file.
> * gnu/packages/patches/nvi-assume-preserve-path.patch: New file.
> * gnu-system.am: Added the preceding 2 files.

Actually, if you make the 3 lines above part of the commit log, ‘git
format-patch’ will preserve them, and so the patch will be directly
applicable with ‘git am’–which is better.  :-)

Anyway I’ve now pushed the patch, thanks!

[...]

>   (The files in the clib/ subdirectory bear a BSD-4 license header, yet the
>   only copyright holder of those files is the University of California,
>   Berkeley, which removed the ad-clause in 1997 retroactively (i.e. it
>   relicensed all BSD-4 code under its copyright to BSD-3). Thus those files
>   are effectively distributed under the BSD-3 license as well.)

This seems to be the explanation: at some point UC Berkeley changed the
license to BSD-3, which it can do as the sole copyright holder.

Thanks,
Ludo’.



Re: [PATCH] profiles: Report about upgrades.

2014-09-02 Thread Ludovic Courtès
Alex Kost  skribis:

> Ludovic Courtès (2014-08-31 23:57 +0400) wrote:
>
> [...]
>
>> Perhaps even a different format, like, say:
>>
>>   The following package will be upgraded:
>> guile 1.8.8 → 2.0.9out /gnu/store/...
>>
>> Thoughts?
>
> I think, it would be perfect!

Commit ef8993e does that.

While I was at it, I took the freedom to adjust the format of these
lines (commit 9a91476) so that the version number would always appear in
the second column, while the output name no longer has a separate
column:

--8<---cut here---start->8---
$ ./pre-inst-env guix package -r idutils -u libtasn1 -i emacs libgc libgc:debug 
-n -p foo
The following package would be removed:
   idutils  4.6 /gnu/store/40nbigb0bghwqvnchjdxsrafbzxmybh8-idutils-4.6

The following package would be upgraded:
   libtasn1 3.6 → 4.1   
/gnu/store/52kdi2gmrl2ms92as0nsxbbkndqx07s4-libtasn1-4.1

The following packages would be installed:
   libgc:debug  7.4.0   
/gnu/store/98r76vrmvv3fvg26n3dzq3i72l25whl1-libgc-7.4.0-debug
   libgc7.4.0   /gnu/store/cqhp23ak0kaa4kv1jdvzbsrkw41krczh-libgc-7.4.0
   emacs24.3/gnu/store/majxvz4dxcw75m1ni2hph3kbws400y94-emacs-24.3
--8<---cut here---end--->8---

It’s still time to complain if you don’t like it.  :-)

Ludo’.



Re: Merging guix.el

2014-09-02 Thread Alex Kost
Ludovic Courtès (2014-09-02 02:28 +0400) wrote:

> Alex Kost  skribis:
>
>> I've just pushed a manual for “guix.el” (into “emacs-ui” branch).  I
>> tried my best, but I'm not a native English speaker and I have never
>> worked with Texinfo before, so there may be... issues :-)
>
> Looks good to me!  Here are some minor comments (I’m not a native
> speaker either):

[...]

Thanks for all your comments.  I believe I fixed everything you
mentioned.

> +@menu
> +* Initial Setup::
> +* Usage::
> +* Configuration::
> +@end menu
>
> Please add something to the right-hand side.

Inventing something useful for the right side was the hardest part :-)

> Node names are global, so they need to be less generic, to avoid
> possible name clashes with the rest of the manual.  For instance:
>
>   guix.el Setup
>   guix.el Usage
>   guix.el Configuration
>
> The section names can remain unchanged, though.

I used “emacs” instead of “guix.el” because the dot (in “guix.el”)
breaks menu items.  Is it OK?

--
Alex



Re: Merging guix.el

2014-09-02 Thread Alex Kost
Ludovic Courtès (2014-08-31 18:59 +0400) wrote:

[...]

> I think the profile’s file name could be kept on the elisp side, and
> passed to the Scheme code, which wouldn’t need to keep it in a global
> variable.  That would also allow guix.el to be used on profiles other
> than the default one.

Done (in the emacs-ui branch).  Thanks again.

--
Alex



Re: Merging guix.el

2014-09-02 Thread Alex Kost
Ludovic Courtès (2014-09-01 16:10 +0400) wrote:

> Alex Kost  skribis:
>
>> Ludovic Courtès (2014-08-31 18:59 +0400) wrote:
>
> [...]
>
>>> The key is ‘vhash-fold*’ (info "(guile) VHashes").  It allows you to
>>> traverse all the entries associated with a given key:
>>>
>>> scheme@(guile-user)> (vhash-cons '("guile" "2.0") 'foo
>>>  (vhash-cons '("guile" "2.0") 'bar
>>>  vlist-null))
>>> $12 = #
>>> scheme@(guile-user)> (vhash-fold* cons '() '("guile" "2.0") $12)
>>> $13 = (bar foo)
>>>
>>> I think that answers your question, right?
>>
>> Absolutely; sorry for missing that feature.  But will it be a real
>> optimization?  If I want to get information for all packages, I have to
>> perform ‘vhash-fold*’ on ‘manifest-name->entry’ vhash for each package
>> (to get installed outputs).  With hash-table, I just need to use
>> ‘hash-ref’ for each package.
>
> ‘vhash-fold*’ iterates only on the values associated with the given key;
> it has time complexity linear in the number of values associated with
> that key.  So no worries here (and again, 90% of the time there’ll be
> exactly one package corresponding to a name/version pair.)

Ah, OK then.  (I still have some worries but it's just paranoia
apparently).

>> Also I need to fold over unique names (I use ‘fold-manifest-entries’
>> from “guix-main.scm” for that) and I have no idea how vhash can help
>> there.
>
> Would ‘vlist-fold’ work?
>
> scheme@(guile-user)> (vhash-cons 'a 1 (vhash-cons 'b 2 (vhash-cons 'a 3 
> vlist-null)))
> $2 = #
> scheme@(guile-user)> (vlist-fold cons '() $2)
> $3 = ((a . 3) (b . 2) (a . 1))

Sorry, I don't see how it could work.  Here is an example:

;; What I currently have is a hash-table like this one:
(define table (make-hash-table 3))

(hash-set! table 'a '(1 2 3))
(hash-set! table 'b '(4))
(hash-set! table 'c '(5 6))

;; And I can easily fold through unique keys like this:
(hash-fold (lambda (key entries res)
 (cons (cons key (apply + entries)) res))
   '()
   table) ; => ((c . 11) (b . 4) (a . 6))

;; What you suggest is a vhash like this:
(define vhash
  (vhash-cons
   'a 1
   (vhash-cons
'a 2
(vhash-cons
 'a 3
 (vhash-cons
  'b 4
  (vhash-cons
   'c 5
   (vhash-cons
'c 6 vlist-null)))

;; But how can I fold through unique keys there?

[...]

> I’ll check the doc later today, but it seems this is essentially ready
> for merging, no?

Yes, If you don't mind that I'm still using hash-tables, I think it can
be merged.

> When we merge, would you like to rewrite history and make the whole
> thing appear as a single “perfect” commit, or just merge ‘emacs-ui’ into
> ‘master’?  (I often do the former, but I’m fine with the latter here.)

I don't have a preference here.  I can do a single commit if it is more
appropriate.  Would the following commit message be OK?

--8<---cut here---start->8---
Add Emacs user interface.

* configure.ac (emacsuidir): New variable.
  (AC_CONFIG_FILES): Add 'emacs/guix-init.el', 'emacs/guix-helper.scm'.
* Makefile.am: Include 'emacs.am'.
* emacs.am: New file.
* doc/emacs.texi: New file.
* doc/guix.texi: Include 'emacs.texi'.
* emacs/guix-backend.el: New file.
* emacs/guix-base.el: New file.
* emacs/guix-helper.scm.in: New file.
* emacs/guix-history.el: New file.
* emacs/guix-info.el: New file.
* emacs/guix-init.el.in: New file.
* emacs/guix-list.el: New file.
* emacs/guix-main.scm: New file.
* emacs/guix-utils.el: New file.
* emacs/guix.el: New file.
--8<---cut here---end--->8---



Re: Proposal: prefetch tarballs in a batch

2014-09-02 Thread Ludovic Courtès
l...@gnu.org (Ludovic Courtès) skribis:

>> Test end:
>>   result-kind: fail
>>   actual-value: #f
>>   actual-error: (srfi-34 #> file descriptor 1599602736: Bad file descriptor" status: 1] 8a62798>)
>
> That one occurs many times.  I suspect this has to do with the daemon
> features enabled by c0412fedf, though I don’t see which one.

(4 months later...)

I reproduced this EBADF thing with a 2.6.35 kernel on x86_64, and the
culprit turned out to be vfork: commenting out uses of vfork in the
daemon solved the problem.

That sort of ringed a bell, and indeed, Nix commit f794465c (Nov. 2012!)
disabled vfork for similar reasons.

So guix-daemon no longer uses vfork.

Ludo’.



Re: Proposal: prefetch tarballs in a batch

2014-09-02 Thread Ludovic Courtès
BTW, I’ve been traveling lately, and I’ve really missed ‘guix prefetch’.

So if you have spare time to pour into it, or if someone else wants to
take it over, that’d be nice!

Ludo’.



Re: Merging guix.el

2014-09-02 Thread Ludovic Courtès
Alex Kost  skribis:

> Ludovic Courtès (2014-08-31 18:59 +0400) wrote:
>
> [...]
>
>> I think the profile’s file name could be kept on the elisp side, and
>> passed to the Scheme code, which wouldn’t need to keep it in a global
>> variable.  That would also allow guix.el to be used on profiles other
>> than the default one.
>
> Done (in the emacs-ui branch).  Thanks again.

Excellent!

Ludo'.



Re: Merging guix.el

2014-09-02 Thread Ludovic Courtès
Alex Kost  skribis:

> Ludovic Courtès (2014-09-02 02:28 +0400) wrote:
>
>> Alex Kost  skribis:
>>
>>> I've just pushed a manual for “guix.el” (into “emacs-ui” branch).  I
>>> tried my best, but I'm not a native English speaker and I have never
>>> worked with Texinfo before, so there may be... issues :-)
>>
>> Looks good to me!  Here are some minor comments (I’m not a native
>> speaker either):
>
> [...]
>
> Thanks for all your comments.  I believe I fixed everything you
> mentioned.

Great, thank you for your patience.

>> +@menu
>> +* Initial Setup::
>> +* Usage::
>> +* Configuration::
>> +@end menu
>>
>> Please add something to the right-hand side.
>
> Inventing something useful for the right side was the hardest part :-)

Heh.  :-)

>> Node names are global, so they need to be less generic, to avoid
>> possible name clashes with the rest of the manual.  For instance:
>>
>>   guix.el Setup
>>   guix.el Usage
>>   guix.el Configuration
>>
>> The section names can remain unchanged, though.
>
> I used “emacs” instead of “guix.el” because the dot (in “guix.el”)
> breaks menu items.  Is it OK?

I would have made it uppercase, but otherwise yes.

Enough nitpicking: when do we merge? :-)

It seems to me the main issues have been addressed, so I’m happy with
continuing that work in ‘master’.  WDYT?

Ludo’.



Re: Proposal: prefetch tarballs in a batch

2014-09-02 Thread Nikita Karetnikov
> BTW, I’ve been traveling lately, and I’ve really missed ‘guix
> prefetch’.

Heh, that was the motivation.

> So if you have spare time to pour into it, or if someone else wants to
> take it over, that’d be nice!

I doubt so, unfortunately.  So please do take it over if you can.


pgpMOhIZmPKkm.pgp
Description: PGP signature


[PATCH] gnu: Add postgresql.

2014-09-02 Thread David Thompson
>From 4b760e9504f608ba460b85413206dbd5658fe78c Mon Sep 17 00:00:00 2001
From: David Thompson 
Date: Tue, 2 Sep 2014 19:06:45 -0400
Subject: [PATCH] gnu: Add postgresql.

* gnu/packages/postgresql.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am   |  1 +
 gnu/packages/postgresql.scm | 52 +
 2 files changed, 53 insertions(+)
 create mode 100644 gnu/packages/postgresql.scm

diff --git a/gnu-system.am b/gnu-system.am
index a3f04ec..abfb27f 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -199,6 +199,7 @@ GNU_SYSTEM_MODULES =\
   gnu/packages/pkg-config.scm			\
   gnu/packages/plotutils.scm			\
   gnu/packages/popt.scm\
+  gnu/packages/postgresql.scm			\
   gnu/packages/pth.scm\
   gnu/packages/pulseaudio.scm			\
   gnu/packages/pretty-print.scm			\
diff --git a/gnu/packages/postgresql.scm b/gnu/packages/postgresql.scm
new file mode 100644
index 000..d6b505f
--- /dev/null
+++ b/gnu/packages/postgresql.scm
@@ -0,0 +1,52 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2014 David Thompson 
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see .
+
+(define-module (gnu packages postgresql)
+  #:use-module ((guix licenses) #:select (x11-style))
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages readline))
+
+(define-public postgresql
+  (package
+   (name "postgresql")
+   (version "9.3.5")
+   (source (origin
+(method url-fetch)
+(uri (string-append "http://ftp.postgresql.org/pub/source/v";
+version "/postgresql-" version ".tar.gz"))
+(sha256
+ (base32
+  "08kga00izykgvnx7hn995wc4zjqslspapaa8z63045p1ya14mr4g"
+   (build-system gnu-build-system)
+   (inputs
+`(("readline" ,readline)
+  ("zlib" ,zlib)))
+   (home-page "http://www.postgresql.org/";)
+   (synopsis "Powerful object-relational database system")
+   (description
+"PostgreSQL is a powerful object-relational database system.  It is fully
+ACID compliant, has full support for foreign keys, joins, views, triggers, and
+stored procedures (in multiple languages).  It includes most SQL:2008 data
+types, including INTEGER, NUMERIC, BOOLEAN, CHAR, VARCHAR, DATE, INTERVAL, and
+TIMESTAMP.  It also supports storage of binary large objects, including
+pictures, sounds, or video.")
+   (license (x11-style "file://COPYRIGHT"
-- 
2.0.1


-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate