Re: [PATCH] Adjust deprecated QEMU device name.

[Marius Bakke]

Daniel Kiper  skriver:

> On Fri, Jul 16, 2021 at 05:22:42PM +0100, Dimitri John Ledkov wrote:
>> On Wed, Jul 7, 2021 at 2:52 PM Daniel Kiper  wrote:
>> >
>> > On Sun, Jun 13, 2021 at 03:11:51PM +0200, Marius Bakke wrote:
>> > > The 'ide-drive' device was removed in QEMU 6.0.
>> >
>> > Could you add your Signed-off-by?
>> >
>> > > * tests/ahci_test.in (outfile): s/ide-drive/ide-hd/
>> >
>> > Please drop this.
>> >
>> > > ---
>> > >  tests/ahci_test.in | 2 +-
>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/tests/ahci_test.in b/tests/ahci_test.in
>> > > index 7df560462..d844fe680 100644
>> > > --- a/tests/ahci_test.in
>> > > +++ b/tests/ahci_test.in
>> > > @@ -41,7 +41,7 @@ echo "hello" > "$outfile"
>> > >
>> > >  tar cf "$imgfile" "$outfile"
>> > >
>> > > -if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" 
>> > > --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci 
>> > > -device ide-drive,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" 
>> > > ]; then
>> > > +if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" 
>> > > --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci 
>> > > -device ide-hd,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; 
>> > > then
>> >
>> > Is it possible to check QEMU version here and use correct variant then?
>> >
>>
>> ide-hd has been available for more than 10 years now in qemu, thus
>> there shouldn't be any need for backwards compatible names.
>
> OK, Reviewed-by: Daniel Kiper  then...
>
> Marius, I will add your Signed-off-by if you do not object.

Sounds good, thank you!


signature.asc
Description: PGP signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 02/22] ieee1275: claim more memory

[Stefan Berger]

On 7/21/21 10:45 AM, Daniel Kiper wrote:

On Fri, Jul 16, 2021 at 05:59:20AM +0200, Patrick Steinhardt wrote:


I think that my [1] should solve the issue generically. Instead of
bumping any of the static limits we have in place, we just drop them
altogether in favor of dynamically requesting additional EFI regions
whenever we realize that the currently mapped regions cannot satisfy our
needs. Like this, we can lower the initially requested regions, but
scale them to the specific needs if need be.

I had planned to revisit this patch series much earlier, but somehow I
didn't yet find the time. Any comments on my approach would be welcome
though, and if we agree that this may be a viable route to go down then
I'd be happy to further pursue it.

Patrick, thanks a lot! I will take a look at the [1] patchset next week.

Daniel A., Stefan, may I ask you to take a look at the [1] too and tell
us how it will work in your cases?

Daniel

[1] https://lists.gnu.org/archive/html/grub-devel/2020-06/msg9.html



I tried to apply these patches now. 2/3 and 3/3 need forward porting. 
The file grub-core/kern/efi/mm.c that they touch is EFI-specific and not 
even compiled when building for/on [IBM IEEE1275] PowerPC, so I don't 
see how they would help on that platform.


  Stefan


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel